This is an archive of the discontinued LLVM Phabricator instance.

Differential D148976

Adopt Properties to store operations inherent Attributes in the X86Vector dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 6:08 PM.

Details

Reviewers
rriddle
jpienaar
aartbik
nicolasvasilache
dcaballe
Commits
rGee9c8b0d2dc3: Adopt Properties to store operations inherent Attributes in the X86Vector…
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 6:08 PM
Herald added a reviewer: aartbik. · View Herald TranscriptApr 21 2023, 6:08 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 6:08 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 6:08 PM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini added a parent revision: D148939: Adopt Properties to store operations inherent Attributes in the Vector dialect.Apr 21 2023, 6:09 PM
mehdi_amini updated this revision to Diff 516019.Apr 21 2023, 8:23 PM

Rebase

Harbormaster completed remote builds in B227414: Diff 516019.Apr 21 2023, 10:27 PM
mehdi_amini updated this revision to Diff 516273.Apr 23 2023, 10:33 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 11:06 PM
This revision is now accepted and ready to land.Apr 23 2023, 11:06 PM
Harbormaster completed remote builds in B227628: Diff 516273.Apr 24 2023, 12:00 AM
mehdi_amini updated this revision to Diff 516683.Apr 25 2023, 12:21 AM

Rebase

mehdi_amini added a child revision: D149515: Add support for Lazyloading to the MLIR bytecode.Apr 29 2023, 11:06 PM
This revision was landed with ongoing or failed builds.May 15 2023, 3:36 PM
Closed by commit rGee9c8b0d2dc3: Adopt Properties to store operations inherent Attributes in the X86Vector… (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rGee9c8b0d2dc3: Adopt Properties to store operations inherent Attributes in the X86Vector….

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
X86Vector/
1 line

Diff 522372

mlir/include/mlir/Dialect/X86Vector/X86Vector.td

Show All 18 Lines
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// X86Vector dialect definition // X86Vector dialect definition
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
def X86Vector_Dialect : Dialect { def X86Vector_Dialect : Dialect {
let name = "x86vector"; let name = "x86vector";
let cppNamespace = "::mlir::x86vector"; let cppNamespace = "::mlir::x86vector";
let usePropertiesForAttributes = 1;
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// AVX512 op definitions // AVX512 op definitions
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Operation that is part of the input dialect. // Operation that is part of the input dialect.
class AVX512_Op<string mnemonic, list<Trait> traits = []> : class AVX512_Op<string mnemonic, list<Trait> traits = []> :
▲ Show 20 Lines • Show All 311 Lines • Show Last 20 Lines