Adopt Properties to store operations inherent Attributes in the Transform dialect

[mehdi_amini]

Summary

This is part of an on-going migration to adopt Properties inside MLIR.

[mehdi_amini]

Rebase

[ftynse]

mlir/test/Dialect/Transform/ops-invalid.mlir

352

Should this say "requires property"? The attribute seems to be there.

[mehdi_amini]

Rebase after improving diagnostic on invalid IR

mlir/test/Dialect/Transform/ops-invalid.mlir

352

It fails the validation, I made failure_propagation_mode valid so that we keep the expected check for the target attribute.

[mehdi_amini]

Rebase

mlir/include/mlir/Dialect/Transform/IR/TransformDialect.td

def Transform_Dialect : Dialect {
   let cppNamespace = "::mlir::transform";
 
   let dependentDialects = [
     "::mlir::pdl::PDLDialect",
     "::mlir::pdl_interp::PDLInterpDialect",
   ];
 
   let hasOperationAttrVerify = 1;
+  let usePropertiesForAttributes = 1;
 
   let extraClassDeclaration = [{
       /// Name of the attribute attachable to the symbol table operation
       /// containing named sequences. This is used to trigger verification.
       constexpr const static llvm::StringLiteral
           kWithNamedSequenceAttrName = "transform.with_named_sequence";
 
       /// Names of the attribute attachable to an operation so it can be

mlir/test/Dialect/Transform/ops-invalid.mlir

module {
   }
 }
 
 // -----
 
 module attributes { transform.with_named_sequence } {
   transform.sequence failures(suppress) {
   ^bb0(%arg0: !transform.any_op):
     // expected-error @below {{requires attribute 'target'}}
-    "transform.include"() {failure_propagation_mode = 0} : () -> ()
+    "transform.include"() {failure_propagation_mode = 1 : i32} : () -> ()
   }
 }
 
 // -----
 
 module attributes { transform.with_named_sequence } {
   transform.named_sequence @foo(%arg0: !transform.any_op) -> () {
     transform.yield