Page MenuHomePhabricator

zero9178 (Markus Böck)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2019, 12:14 PM (58 w, 4 d)

Recent Activity

Apr 18 2020

zero9178 added a comment to D77957: [llvm-objdump] Demangle C++ Symbols in branch and call targets.

Friendly bump :)

Apr 18 2020, 4:50 AM · Restricted Project

Apr 16 2020

zero9178 added a comment to D77870: [MLIR] Introduce utility for affine loop unswitching / hoisting if/else.

This patch also breaks building with BUILD_SHARED_LIBS=ON on both Linux and windows:

Apr 16 2020, 5:36 AM · Restricted Project

Apr 12 2020

zero9178 added a comment to D77957: [llvm-objdump] Demangle C++ Symbols in branch and call targets.

Thank you! Would need someone to commit this for me

Apr 12 2020, 3:11 AM · Restricted Project

Apr 11 2020

zero9178 created D77957: [llvm-objdump] Demangle C++ Symbols in branch and call targets.
Apr 11 2020, 5:36 PM · Restricted Project

Apr 9 2020

zero9178 added a comment to D77371: [Codegen/Statepoint] Allow usage of registers for non gc deopt values..

This patch breaks building LLVM with BUILD_SHARED_LIBS due to a linker error. UseRegsitersForDeoptValues is declared as extern in TargetPassConfig while the definition of the value is in SelectionDAG/StatepointLower.cpp. As the LLVMCodegen target does not link against LLVMSelectionDAG it causes undefined reference errors when linking LLVMCodegen

Apr 9 2020, 4:18 AM · Restricted Project

Mar 28 2020

zero9178 added a comment to D75153: [ThinLTO] Allow usage of all SMT threads in the system.

This patch seems to break when disabling threading (aka LLVM_ENABLE_THREADS == 0) as get_threadpool_strategy is undefined therefore creating linker failures in clang. (Tested on Windows)

Mar 28 2020, 8:04 AM · Restricted Project, Restricted Project

Feb 8 2020

zero9178 added a comment to D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

Thank you! Would need someone to commit this for me

Feb 8 2020, 5:21 AM · Restricted Project

Feb 6 2020

zero9178 added a comment to D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

I hope we are not renaming everything because it add complexity on compatibility.

Rename only the refs from libunwind is not enough since there are refs from clang header and libc++abi as well. unwind.h and corresponding header from clang are both shipping products which add compatibility problem.

Feb 6 2020, 1:29 PM · Restricted Project
zero9178 updated the diff for D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

Refactored all uses of __personality_routine to _Unwind_Personality_Fn

Feb 6 2020, 9:28 AM · Restricted Project

Feb 3 2020

zero9178 updated the diff for D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

Reverted back to defining _Unwind_Personality_Fn in unwind.h

Feb 3 2020, 8:10 AM · Restricted Project

Feb 2 2020

zero9178 added a comment to D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

Just noticed that the unwind.h header of gcc does not provide a __personality_routine typedef. So we have 3 different unwind.h headers.

Feb 2 2020, 11:28 AM · Restricted Project
zero9178 added a comment to D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

As far as I understand __personality_routine is the way the various standards call it, so introducing a GCC specific typedef seems unnecessary and not portable to me

Feb 2 2020, 9:57 AM · Restricted Project

Feb 1 2020

zero9178 added a comment to D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.

Instead of changing the libunwind header to contain _Unwind_Personality_Fn, changed libcxxabi to use __personality_routine

Feb 1 2020, 3:01 AM · Restricted Project
zero9178 updated the diff for D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.
Feb 1 2020, 2:58 AM · Restricted Project

Jan 30 2020

zero9178 added a comment to D73639: [LLVM] Wrap extern TLS variable in getter Function.

Thank you! Would need someone to commit this for me

Jan 30 2020, 1:30 PM · Restricted Project
zero9178 added a comment to D73639: [LLVM] Wrap extern TLS variable in getter Function.

I also just measured compiling X86ISelLowering. Once on trunk and once with the patch applied. Using GCC 9.2 as the compiler got me 31.572, 31.843 and 31.936 for the current master and 32.241, 32.370 and 32.306 with the patch applied. So it's measurable on my machine

I realized I had built my clang with asserts enabled, which might dilute the effect of the change. But despite disabling asserts, I can't measure any significant difference due to this change - it's almost the contrary effect, this change actually seems to make it marginally faster (both when built with GCC 7 and Clang 9).

Jan 30 2020, 2:38 AM · Restricted Project

Jan 29 2020

zero9178 updated the diff for D73639: [LLVM] Wrap extern TLS variable in getter Function.

Changed function name to camelCase, Added using namespace llvm

Jan 29 2020, 2:17 PM · Restricted Project
zero9178 added a comment to D73639: [LLVM] Wrap extern TLS variable in getter Function.

I also just measured compiling X86ISelLowering. Once on trunk and once with the patch applied. Using GCC 9.2 as the compiler got me 31.572, 31.843 and 31.936 for the current master and 32.241, 32.370 and 32.306 with the patch applied. So it's measurable on my machine

Jan 29 2020, 1:59 PM · Restricted Project
zero9178 added a comment to D73639: [LLVM] Wrap extern TLS variable in getter Function.

Additionally it allows Clang versions prior to 10 to compile current trunk.

I have been using Clang prior to 10 to compile without this change. Do you mean with BUILD_SHARED_LIBS for this as well?

Jan 29 2020, 10:53 AM · Restricted Project
zero9178 created D73639: [LLVM] Wrap extern TLS variable in getter Function.
Jan 29 2020, 9:21 AM · Restricted Project
zero9178 edited reviewers for D73639: [LLVM] Wrap extern TLS variable in getter Function, added: russell.gallop; removed: ruscur.
Jan 29 2020, 9:21 AM · Restricted Project
zero9178 added a comment to D73508: [LLD][COFF] Fix dll import for thread_local storage.

If a wrapper function returning a pointer would work over dll boundaries then I think that would be the best way going forward. I will look into it! I have not encountered the multiple definitions error when building with shared libraries. I have encountered one when building current trunk as static libraries but I saw that you have fixed that for clang 10 already (was related to comdat and TLS)

Jan 29 2020, 12:41 AM · Restricted Project

Jan 28 2020

zero9178 created D73584: [libunwind] Rename __personality_routine to _Unwind_Personality_Fn.
Jan 28 2020, 2:34 PM · Restricted Project
zero9178 abandoned D73508: [LLD][COFF] Fix dll import for thread_local storage.
Jan 28 2020, 1:22 PM · Restricted Project
zero9178 added a comment to D73508: [LLD][COFF] Fix dll import for thread_local storage.

Thank you for your very detailed explanation. Do you think it'd be worth updating documentation and cmake then to error if threading is enabled and build shared libs chosen? Either way I think this can be closed. Thanks again!

Jan 28 2020, 9:26 AM · Restricted Project
zero9178 added a comment to D73508: [LLD][COFF] Fix dll import for thread_local storage.

Regarding the DLL boundary:
Clangs native approach uses the .tls sections of PE, just like MSVC. Microsofts documentation here: https://docs.microsoft.com/en-us/previous-versions/6yh4a9k1%28v%3dvs.140%29 States that it should work over dll boundaries if the dll is auto imported by the executable and work with a LoadLibrary call if it's Windows Vista or newer.

Jan 28 2020, 2:42 AM · Restricted Project

Jan 27 2020

zero9178 updated the summary of D73508: [LLD][COFF] Fix dll import for thread_local storage.
Jan 27 2020, 3:33 PM · Restricted Project
zero9178 created D73508: [LLD][COFF] Fix dll import for thread_local storage.
Jan 27 2020, 2:43 PM · Restricted Project

Jan 23 2020

zero9178 added a comment to D73139: [LLD][COFF] Enable linking of __declspec(selectany) symbols from Clang and GCC.

Thanks! Would need someone to commit this for me

Jan 23 2020, 12:39 AM · Restricted Project

Jan 22 2020

zero9178 updated the diff for D73139: [LLD][COFF] Enable linking of __declspec(selectany) symbols from Clang and GCC.

Added X86 requirement

Jan 22 2020, 10:42 AM · Restricted Project
zero9178 updated the diff for D73139: [LLD][COFF] Enable linking of __declspec(selectany) symbols from Clang and GCC.

Removed /:nodefaultlib. Applied formatting

Jan 22 2020, 8:41 AM · Restricted Project
zero9178 updated the diff for D73139: [LLD][COFF] Enable linking of __declspec(selectany) symbols from Clang and GCC.

Added tests to confirm behavior. Changed the resulting comdat to be "same size as" instead of "any". This matches ld.bfd's behavior

Jan 22 2020, 6:14 AM · Restricted Project

Jan 21 2020

zero9178 updated the summary of D73139: [LLD][COFF] Enable linking of __declspec(selectany) symbols from Clang and GCC.
Jan 21 2020, 1:47 PM · Restricted Project
zero9178 updated the summary of D73139: [LLD][COFF] Enable linking of __declspec(selectany) symbols from Clang and GCC.
Jan 21 2020, 1:47 PM · Restricted Project
zero9178 updated the summary of D73139: [LLD][COFF] Enable linking of __declspec(selectany) symbols from Clang and GCC.
Jan 21 2020, 1:47 PM · Restricted Project
zero9178 created D73139: [LLD][COFF] Enable linking of __declspec(selectany) symbols from Clang and GCC.
Jan 21 2020, 1:47 PM · Restricted Project

Jan 12 2020

zero9178 added a comment to D72564: [NFC] Fix compilation of CrashRecoveryContext.cpp on mingw.

That would be great thanks!

Jan 12 2020, 9:11 AM · Restricted Project

Jan 11 2020

zero9178 created D72564: [NFC] Fix compilation of CrashRecoveryContext.cpp on mingw.
Jan 11 2020, 4:24 PM · Restricted Project

Sep 10 2019

zero9178 added a comment to D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .

Friendly after a week ping.

Sep 10 2019, 1:04 AM · Restricted Project, lld

Sep 3 2019

zero9178 updated the diff for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .

Changed memberOffset to memberIndex as suggested by reviwer. Would need someone to commit this for me

Sep 3 2019, 5:08 AM · Restricted Project, lld

Aug 30 2019

zero9178 updated the diff for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .

Changed index from std::uint64_t to int. Made test accept both kinds of slashes

Aug 30 2019, 3:56 AM · Restricted Project, lld

Aug 14 2019

zero9178 added a reviewer for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive : pcc.
Aug 14 2019, 2:01 PM · Restricted Project, lld
zero9178 updated the diff for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .

Fixed test to show regression and verify output

Aug 14 2019, 1:15 PM · Restricted Project, lld
zero9178 edited projects for D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive , added: lld; removed Restricted Project.
Aug 14 2019, 12:38 PM · Restricted Project, lld
zero9178 created D66239: [LLD][COFF] Add index to disambiguate archive members when using -wholearchive .
Aug 14 2019, 12:35 PM · Restricted Project, lld