Page MenuHomePhabricator

zero9178 (Markus Böck)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 14 2019, 12:14 PM (96 w, 3 d)

Recent Activity

Yesterday

zero9178 added inline comments to D103773: [clang-cl] Add /permissive and /permissive- .
Sat, Jun 19, 4:30 AM · Restricted Project
zero9178 committed rGc9889c44ec5a: [clang-cl] Don't expand /permissive- to /ZC:strictStrings yet (authored by zero9178).
[clang-cl] Don't expand /permissive- to /ZC:strictStrings yet
Sat, Jun 19, 4:28 AM

Tue, Jun 15

zero9178 added inline comments to D103773: [clang-cl] Add /permissive and /permissive- .
Tue, Jun 15, 8:06 PM · Restricted Project

Sun, Jun 13

zero9178 committed rG7ff3a89a7b94: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of… (authored by zero9178).
[clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of…
Sun, Jun 13, 5:48 AM
zero9178 closed D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand.
Sun, Jun 13, 5:48 AM · Restricted Project

Sat, Jun 12

zero9178 added a comment to D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand.

Was this performance hit when using the static analyzer? A quick search suggests isAnyDestructorNoReturn() is only called within the analyzer, whereas comparable CXXRecordDecl methods whose results are stored (hasIrrelevantDestructor() etc.) seem to be called somewhere by Sema.

So non-users of the analyzer would not benefit from this change, and will incur a slight cost, IIUC. Is that cost remotely noticeable? Probably not, but a quick test along those lines would be helpful.

All in all this is probably good and advisable.

Sat, Jun 12, 1:15 PM · Restricted Project
zero9178 requested review of D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand.
Sat, Jun 12, 8:47 AM · Restricted Project

Thu, Jun 10

zero9178 committed rGc70b0e808da8: [clang-cl] Add /permissive and /permissive- (authored by zero9178).
[clang-cl] Add /permissive and /permissive-
Thu, Jun 10, 8:10 AM
zero9178 closed D103773: [clang-cl] Add /permissive and /permissive- .
Thu, Jun 10, 8:10 AM · Restricted Project
zero9178 committed rG936d6756ccfb: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti (authored by zero9178).
[clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti
Thu, Jun 10, 8:03 AM
zero9178 closed D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti.
Thu, Jun 10, 8:03 AM · Restricted Project
zero9178 committed rG9833b57981c4: [clang][driver] Add -foperator-names (authored by zero9178).
[clang][driver] Add -foperator-names
Thu, Jun 10, 8:02 AM
zero9178 closed D103749: [clang][driver] Add -foperator-names .
Thu, Jun 10, 8:02 AM · Restricted Project

Wed, Jun 9

zero9178 added a comment to D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined.

Microsofts STL does seem to be doing the same as can be seen here: https://github.com/microsoft/STL/blob/62137922ab168f8e23ec1a95c946821e24bde230/stl/inc/exception#L63.

Wed, Jun 9, 4:31 AM · Restricted Project

Mon, Jun 7

zero9178 added a comment to D103773: [clang-cl] Add /permissive and /permissive- .

I shall do that.

Mon, Jun 7, 6:29 AM · Restricted Project
zero9178 abandoned D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer.

Thanks for the info, seems like I was mislead after testing it again.

Mon, Jun 7, 4:27 AM · Restricted Project
zero9178 added a comment to D103773: [clang-cl] Add /permissive and /permissive- .

I think adding /permissive- to make things more conforming is great. The docs say "Starting in Visual Studio 2019 version 16.8, the /std:c++latest option implicitly sets the /permissive- option." so maybe we should do that too (doesn't have to be in this patch).

Mon, Jun 7, 4:26 AM · Restricted Project

Sun, Jun 6

zero9178 requested review of D103773: [clang-cl] Add /permissive and /permissive- .
Sun, Jun 6, 12:35 PM · Restricted Project
zero9178 updated the diff for D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer.

Rebased onto main

Sun, Jun 6, 12:02 PM · Restricted Project
zero9178 updated the diff for D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti.

Rebase & add comment in source code explaining the purpose of the define

Sun, Jun 6, 11:57 AM · Restricted Project
zero9178 requested review of D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer.
Sun, Jun 6, 11:23 AM · Restricted Project
zero9178 requested review of D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti.
Sun, Jun 6, 10:42 AM · Restricted Project

Sat, Jun 5

zero9178 requested review of D103749: [clang][driver] Add -foperator-names .
Sat, Jun 5, 5:34 AM · Restricted Project

Thu, Jun 3

zero9178 committed rG619fa0d7fc8a: [NFC] Add missing includes for LLVM_ENABLE_MODULES builds (authored by zero9178).
[NFC] Add missing includes for LLVM_ENABLE_MODULES builds
Thu, Jun 3, 2:29 PM
zero9178 closed D103645: [NFC] Add missing includes for LLVM_ENABLE_MODULES builds.
Thu, Jun 3, 2:29 PM · Restricted Project
zero9178 requested review of D103645: [NFC] Add missing includes for LLVM_ENABLE_MODULES builds.
Thu, Jun 3, 2:03 PM · Restricted Project

Tue, May 25

zero9178 added a comment to D103017: [3/4][mlir][doc] Fix links and references in documentation of Tutorials.

Addressed review comments in final commit

Tue, May 25, 11:19 AM · Restricted Project
zero9178 committed rG31d1ae79752d: [mlir][doc] Fix links and references in documentation of Tutorials (authored by zero9178).
[mlir][doc] Fix links and references in documentation of Tutorials
Tue, May 25, 11:19 AM
zero9178 closed D103017: [3/4][mlir][doc] Fix links and references in documentation of Tutorials.
Tue, May 25, 11:19 AM · Restricted Project
zero9178 committed rG09b5ebc07b47: [mlir][CAPI][test] Change casts and fprintf format strings from long to intptr_t (authored by zero9178).
[mlir][CAPI][test] Change casts and fprintf format strings from long to intptr_t
Tue, May 25, 8:49 AM
zero9178 closed D103085: [mlir][CAPI][test] Change casts and fprintf format strings from long to intptr_t.
Tue, May 25, 8:49 AM · Restricted Project
zero9178 requested review of D103085: [mlir][CAPI][test] Change casts and fprintf format strings from long to intptr_t.
Tue, May 25, 6:48 AM · Restricted Project
zero9178 updated the diff for D103017: [3/4][mlir][doc] Fix links and references in documentation of Tutorials.

Changed links named "TensorType" to "RankedTensorType".

Tue, May 25, 6:06 AM · Restricted Project
zero9178 committed rG9b99336d5daf: [mlir][doc] Fix links and references in documentation of Dialects (authored by zero9178).
[mlir][doc] Fix links and references in documentation of Dialects
Tue, May 25, 5:51 AM
zero9178 closed D103011: [1/4][mlir][doc] Fix links and references in documentation of Dialects.
Tue, May 25, 5:51 AM · Restricted Project
zero9178 committed rG5e2a302e37f1: [mlir][doc] Fix links and references in documentation of Rationale (authored by zero9178).
[mlir][doc] Fix links and references in documentation of Rationale
Tue, May 25, 5:48 AM
zero9178 closed D103013: [2/4][mlir][doc] Fix links and references in documentation of Rationale.
Tue, May 25, 5:48 AM · Restricted Project

Mon, May 24

zero9178 committed rGd35bd98651ec: [mlir][doc] Fix links and references in top level docs directory (authored by zero9178).
[mlir][doc] Fix links and references in top level docs directory
Mon, May 24, 9:43 AM
zero9178 closed D103032: [4/4][mlir][doc] Fix links and references in top level docs directory.
Mon, May 24, 9:43 AM · Restricted Project
zero9178 added inline comments to D103032: [4/4][mlir][doc] Fix links and references in top level docs directory.
Mon, May 24, 9:18 AM · Restricted Project
zero9178 requested review of D103032: [4/4][mlir][doc] Fix links and references in top level docs directory.
Mon, May 24, 9:14 AM · Restricted Project
zero9178 updated the summary of D103013: [2/4][mlir][doc] Fix links and references in documentation of Rationale.
Mon, May 24, 7:28 AM · Restricted Project
zero9178 updated the diff for D103013: [2/4][mlir][doc] Fix links and references in documentation of Rationale.

Remove anchor name from prior art in RationaleLinalgDialect. This way generated name to refer to the section in Markdown is just "prior-art"

Mon, May 24, 7:28 AM · Restricted Project
zero9178 updated the summary of D103011: [1/4][mlir][doc] Fix links and references in documentation of Dialects.
Mon, May 24, 7:26 AM · Restricted Project
zero9178 updated the diff for D103011: [1/4][mlir][doc] Fix links and references in documentation of Dialects.

Addressed Review comments.

Mon, May 24, 7:25 AM · Restricted Project
zero9178 retitled D103013: [2/4][mlir][doc] Fix links and references in documentation of Rationale from [mlir][doc] Fix links and references in documentation of Rationale to [2/4][mlir][doc] Fix links and references in documentation of Rationale.
Mon, May 24, 6:27 AM · Restricted Project
zero9178 retitled D103011: [1/4][mlir][doc] Fix links and references in documentation of Dialects from [mlir][doc] Fix links and references in documentation of Dialects to [1/4][mlir][doc] Fix links and references in documentation of Dialects.
Mon, May 24, 6:27 AM · Restricted Project
zero9178 requested review of D103017: [3/4][mlir][doc] Fix links and references in documentation of Tutorials.
Mon, May 24, 6:26 AM · Restricted Project
zero9178 requested review of D103013: [2/4][mlir][doc] Fix links and references in documentation of Rationale.
Mon, May 24, 5:21 AM · Restricted Project
zero9178 added inline comments to D103011: [1/4][mlir][doc] Fix links and references in documentation of Dialects.
Mon, May 24, 4:54 AM · Restricted Project
zero9178 requested review of D103011: [1/4][mlir][doc] Fix links and references in documentation of Dialects.
Mon, May 24, 4:53 AM · Restricted Project

Sun, May 23

zero9178 committed rG9a6eb4968e03: [mlir][doc] Fix links and indentation of mlir::ModuleOp description (authored by zero9178).
[mlir][doc] Fix links and indentation of mlir::ModuleOp description
Sun, May 23, 11:02 AM
zero9178 closed D102983: [mlir][doc] Fix links and indentation of mlir::ModuleOp description.
Sun, May 23, 11:02 AM · Restricted Project
zero9178 requested review of D102983: [mlir][doc] Fix links and indentation of mlir::ModuleOp description.
Sun, May 23, 4:55 AM · Restricted Project

May 17 2021

zero9178 committed rG65271ffe8416: [lld][MinGW] Introduce aliases for -Bdynamic and -Bstatic (authored by zero9178).
[lld][MinGW] Introduce aliases for -Bdynamic and -Bstatic
May 17 2021, 1:13 PM
zero9178 closed D102637: [lld][MinGW] Introduce aliases for -Bdynamic and -Bstatic.
May 17 2021, 1:13 PM · Restricted Project
zero9178 added a comment to D102637: [lld][MinGW] Introduce aliases for -Bdynamic and -Bstatic.

LGTM

Interesting, I wasn't aware of the others, other than -static.

Is this use of -static (which I'd presume is in the form of -Wl,-static) somewhere in the Qt source/build system itself (which would surprise me as I build Qt quite a lot, but I haven't tested building 6.x with cmake statically), or in a third party build script?

May 17 2021, 1:10 PM · Restricted Project
zero9178 requested review of D102637: [lld][MinGW] Introduce aliases for -Bdynamic and -Bstatic.
May 17 2021, 10:08 AM · Restricted Project

Mar 29 2021

zero9178 committed rG142d522dedbb: [llvm-profdata] Make sure to consume Error on the error path of… (authored by zero9178).
[llvm-profdata] Make sure to consume Error on the error path of…
Mar 29 2021, 11:53 PM
zero9178 closed D99457: [llvm-profdata] Make sure to consume Error on the error path of setIsIRLevelProfile.
Mar 29 2021, 11:53 PM · Restricted Project
zero9178 updated the diff for D99457: [llvm-profdata] Make sure to consume Error on the error path of setIsIRLevelProfile.

Thanks a lot for the help.
I have now added tests that reproduce the issue and also ensure the error is emitted.

Mar 29 2021, 10:50 AM · Restricted Project

Mar 27 2021

zero9178 requested review of D99457: [llvm-profdata] Make sure to consume Error on the error path of setIsIRLevelProfile.
Mar 27 2021, 10:05 AM · Restricted Project

Mar 26 2021

zero9178 added a comment to D99305: [docs] Document our norms around reverts.

As a very new contributor to LLVM (and open source in general, truth be told), I would like to just quickly mention that I like this addition to the documentation a lot. Getting one's commit reverted is definitely a rather scary experience at first, but I think this documentation, and in particular the wording chosen, helps reinforce LLVM as a positive development environment. It has certainly helped me.

Mar 26 2021, 9:29 AM · Restricted Project

Mar 25 2021

zero9178 committed rGc6047101ad5f: [Support][Windows] Make sure only executables are found by sys… (authored by zero9178).
[Support][Windows] Make sure only executables are found by sys…
Mar 25 2021, 12:30 PM
zero9178 closed D99357: [Support][Windows] Make sure only executables are found by sys::findProgramByName.
Mar 25 2021, 12:30 PM · Restricted Project
zero9178 requested review of D99357: [Support][Windows] Make sure only executables are found by sys::findProgramByName.
Mar 25 2021, 11:01 AM · Restricted Project

Mar 22 2021

zero9178 added a comment to D86974: [IRSim] Adding basic implementation of llvm-sim..

Visual Studios Standard library starts their errors in lower case, which do not match the hardcoded values you used in your tests. Take a look at the lit feature added here https://reviews.llvm.org/rGc52fe0b02172e707aa2ba38cd2e01a1fc70dd0da, you should be able to use it to expand to the correct platform specific error message

Ah I see, that only applies to the second part of the error right? The first part (Could not open file) is LLVM generated I think.

Mar 22 2021, 11:59 AM · Restricted Project
zero9178 added a comment to D86974: [IRSim] Adding basic implementation of llvm-sim..

There's a bug with one of the Windows buildbots where the error message doesn't match (even though it looks like it does), but I haven't quite been able to figure out why it's failing yet. I think it has something do to with the fact that it's reporting an error, and that there is a FileCheck prefix.

https://lab.llvm.org/buildbot#builders/123/builds/3498

Mar 22 2021, 10:18 AM · Restricted Project
zero9178 accepted D98861: [CMAKE] Fix cross-compilation build.

LGTM

Mar 22 2021, 3:16 AM · Restricted Project

Mar 20 2021

zero9178 requested changes to D98861: [CMAKE] Fix cross-compilation build.

The issues @mstorsjo has mentioned should be addressed. Merging the second and current version of that patch would probably do the trick.

Mar 20 2021, 4:49 AM · Restricted Project
zero9178 added a comment to D98278: [test] Add ability to get error messages from CMake for errc substitution.

Btw, while this change does explain _what_ it does, it doesn't actually say the exact reason _why_. Cleanliness? Sure, that's nice... Or is it a case where e.g. some translations produce different error messages?

Now that you mention it, it's indeed not as clear as I thought. But yes, in the case of MSVCs STL, the messages from std::error_codes which are used by various LLVM tools produce different strings then using strerror (the C function also called by Python) with the same error codes (Specifically, it has different casing).

Ok, but would e.g. a case insensitive comparison have worked instead of this?

And didn't the python script have hardcoded strings, specifically for the MSVC case? Why weren't they written with the right casing for the case that they're supposed to match? I.e. was it an issue with the existing hardcoded strings, or did they work in one case but not another one?

Mar 20 2021, 4:40 AM · Restricted Project, Restricted Project

Mar 19 2021

zero9178 added a comment to D98278: [test] Add ability to get error messages from CMake for errc substitution.

Btw, while this change does explain _what_ it does, it doesn't actually say the exact reason _why_. Cleanliness? Sure, that's nice... Or is it a case where e.g. some translations produce different error messages?

Mar 19 2021, 10:00 AM · Restricted Project, Restricted Project
zero9178 committed rGaafc3f7be804: [Driver] Add -print-runtime-dir (authored by zero9178).
[Driver] Add -print-runtime-dir
Mar 19 2021, 9:48 AM
zero9178 closed D98868: [Driver] Add -print-runtime-dir.
Mar 19 2021, 9:48 AM · Restricted Project
zero9178 added a comment to D98861: [CMAKE] Fix cross-compilation build.

LGTM as well

Mar 19 2021, 1:58 AM · Restricted Project

Mar 18 2021

zero9178 added a comment to D98861: [CMAKE] Fix cross-compilation build.

After taking a further look, I think part of the problem is that in the CMakeLists.txt of llvm, get_errc_messages get run unconditionally. I assume there are many users out there who want to cross compile, not want to set such variables and are also not interested in running tests. Maybe you could move that invocation into a block guarded by LLVM_INCLUDE_TESTS? That'd be all from me unless anyone else has any inquiries.

Mar 18 2021, 11:07 AM · Restricted Project
zero9178 added a comment to D98278: [test] Add ability to get error messages from CMake for errc substitution.

Add GetErrcMessages.cmake, which contains a cmake function to automatically get the error messages of various posix error codes needed by lit by running a small C++ program.
Currently ENOENT, EISDIR, EINVAL and EACCES are supplied.
These error messages are then currently supplied to clang, llvm and lld as the errc_messages config parameter.

Regarding Cross compiling: the function uses try_run which when cross compiling may use the CMAKE_CROSSCOMPILING_EMULATOR to run the code.

How does it behave if such a thing isn't hooked up? Ideally it'd fall back silently and these parts of tests would just fail, but not block things overall.

It will fall back to using Python's strerror, potentially failing if pythons strerror would not return the same strings (only the case for MSVC I believe).

Hi, this patch is causing a failure when cmake runs try_run() with a CMAKE_TOOLCHAIN_FILE defined. It seems related to having a fall back if the try_run fails.
Here is the error, and the build uses MSVC. What do you think we could do about this? Thanks.

[06:48:06][Step 1/4] CMake Error: TRY_RUN() invoked in cross-compiling mode, please set the following cache variables appropriately:
[06:48:06][Step 1/4]    errc_exit_code (advanced)
[06:48:06][Step 1/4]    errc_exit_code__TRYRUN_OUTPUT (advanced)
[06:48:06][Step 1/4] For details see <manually removed>/TryRunResults.cmake
Mar 18 2021, 11:01 AM · Restricted Project, Restricted Project
zero9178 committed rG6359049c3504: [CMake][runtimes] Add file level dependency to merge_archives commands (authored by zero9178).
[CMake][runtimes] Add file level dependency to merge_archives commands
Mar 18 2021, 10:53 AM
zero9178 closed D98129: [CMake][runtimes] Add file level dependency to merge_archives commands.
Mar 18 2021, 10:52 AM · Restricted Project, Restricted Project
zero9178 added a comment to D98861: [CMAKE] Fix cross-compilation build.

Is this approach going to work for all the previous cases we've identified as problematic (and hence why we ended up with this approach)? In other words, is there a risk that this will actually cause things to regress in some cases?

Mar 18 2021, 7:39 AM · Restricted Project
zero9178 requested review of D98868: [Driver] Add -print-runtime-dir.
Mar 18 2021, 7:25 AM · Restricted Project
zero9178 added a comment to D98861: [CMAKE] Fix cross-compilation build.

Just wondering, what's the current behaviour without these patches? I am aware that if CMAKE_CROSSCOMPILING_EMULATOR is not set, it can't be executed but does configuration automatically fail or does an error appear elsewhere down the line?

Mar 18 2021, 5:55 AM · Restricted Project
zero9178 committed rG3d0aed79362d: [CMake] Use compiler-rt location instead of resource directory to find clang… (authored by zero9178).
[CMake] Use compiler-rt location instead of resource directory to find clang…
Mar 18 2021, 1:26 AM
zero9178 closed D98786: [CMake] Use compiler-rt location instead of resource directory to find clang-cls runtime directory.
Mar 18 2021, 1:26 AM · Restricted Project

Mar 17 2021

zero9178 requested review of D98786: [CMake] Use compiler-rt location instead of resource directory to find clang-cls runtime directory.
Mar 17 2021, 8:49 AM · Restricted Project

Mar 16 2021

zero9178 added a comment to D98278: [test] Add ability to get error messages from CMake for errc substitution.

so perhaps there should be some additional error handling when running the compiled program doesn't work?

Could you try changing line 32 of llvm/cmake/modules/GetErrcMessages.cmake from if (errc_compiled) to if (errc_compiled AND "${errc_exit_code}" STREQUAL "0") and report back if it changes anything? I think that should fix your issue, although it'll fall back to using python's strerror messages. Indeed an oversight of mine.

Yes that helps, please submit. Thanks!

Mar 16 2021, 4:23 AM · Restricted Project, Restricted Project
zero9178 committed rG953bb5e5c8f6: [test] Make sure the test program in GetErrcMessages.cmake exits normally. (authored by zero9178).
[test] Make sure the test program in GetErrcMessages.cmake exits normally.
Mar 16 2021, 4:23 AM
zero9178 added a comment to D98278: [test] Add ability to get error messages from CMake for errc substitution.

Hi,

I'm seeing a problem with this. Compiling with gcc 9.3.0 the compilation of the test program works, but then when I run it I get

/repo/uabelho/master-github/llvm/build-all-bbigcc/CMakeFiles/CMakeTmp/cmTC_00188: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /repo/uabelho/master-github/llvm/build-all-bbigcc/CMakeFiles/CMakeTmp/cmTC_00188)

and this causes everything to fail with

llvm-lit: /repo/uabelho/master-github/llvm/utils/lit/lit/TestingConfig.py:100: fatal: unable to parse config file '/repo/uabelho/master-github/llvm/build-all-bbigcc/tools/clang/test/lit.site.cfg.py', traceback: Traceback (most recent call last):
  File "/repo/uabelho/master-github/llvm/build-all-bbigcc/bin/../../utils/lit/lit/TestingConfig.py", line 89, in load_from_path
    exec(compile(data, path, 'exec'), cfg_globals, None)
  File "/repo/uabelho/master-github/llvm/build-all-bbigcc/tools/clang/test/lit.site.cfg.py", line 19
    config.errc_messages = "/repo/uabelho/master-github/llvm/build-all-bbigcc/CMakeFiles/CMakeTmp/cmTC_00188: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /repo/uabelho/master-github/llvm/build-all-bbigcc/CMakeFiles/CMakeTmp/cmTC_00188)

so perhaps there should be some additional error handling when running the compiled program doesn't work?

Mar 16 2021, 3:38 AM · Restricted Project, Restricted Project
zero9178 added a comment to D98278: [test] Add ability to get error messages from CMake for errc substitution.

I addressed your comments in https://reviews.llvm.org/rG4a17ac0387f078529da02e355a24df99f645d364. Hope it should be alright now

Mar 16 2021, 3:10 AM · Restricted Project, Restricted Project
zero9178 committed rG4a17ac0387f0: [test][NFC] Minor formatting and comment adjustments in GetErrcMessages.cmake (authored by zero9178).
[test][NFC] Minor formatting and comment adjustments in GetErrcMessages.cmake
Mar 16 2021, 3:09 AM
zero9178 added inline comments to D98278: [test] Add ability to get error messages from CMake for errc substitution.
Mar 16 2021, 2:26 AM · Restricted Project, Restricted Project

Mar 15 2021

zero9178 committed rG68e4084bf68a: Revert line accidentally included in af2796c76d2ff4b73165ed47959afd35a769beee (authored by zero9178).
Revert line accidentally included in af2796c76d2ff4b73165ed47959afd35a769beee
Mar 15 2021, 1:04 PM
zero9178 committed rGaf2796c76d2f: [test] Add ability to get error messages from CMake for errc substitution (authored by zero9178).
[test] Add ability to get error messages from CMake for errc substitution
Mar 15 2021, 12:57 PM
zero9178 closed D98278: [test] Add ability to get error messages from CMake for errc substitution.
Mar 15 2021, 12:57 PM · Restricted Project, Restricted Project
zero9178 added a comment to D98278: [test] Add ability to get error messages from CMake for errc substitution.

These changes look good. One more thought I had is that instead of defaulting to python's os.strerror we can emit an error or warning saying that the errc_message is not defined for the project. What do you think?

Mar 15 2021, 12:32 PM · Restricted Project, Restricted Project
zero9178 added a comment to D98129: [CMake][runtimes] Add file level dependency to merge_archives commands.

Ping. I believe I also need approval from libc++ maintainers.

Mar 15 2021, 7:56 AM · Restricted Project, Restricted Project
zero9178 updated the diff for D98278: [test] Add ability to get error messages from CMake for errc substitution.

Rebased and reformatted python code to 80 column limit.

Mar 15 2021, 7:56 AM · Restricted Project, Restricted Project

Mar 11 2021

zero9178 retitled D98278: [test] Add ability to get error messages from CMake for errc substitution from [test] Only use hardcoded errno messages when compiling with an MSVC implementation to [test] Add ability to get error messages from CMake for errc substitution.
Mar 11 2021, 1:57 AM · Restricted Project, Restricted Project
zero9178 added a comment to D98278: [test] Add ability to get error messages from CMake for errc substitution.

Add GetErrcMessages.cmake, which contains a cmake function to automatically get the error messages of various posix error codes needed by lit by running a small C++ program.
Currently ENOENT, EISDIR, EINVAL and EACCES are supplied.
These error messages are then currently supplied to clang, llvm and lld as the errc_messages config parameter.

Regarding Cross compiling: the function uses try_run which when cross compiling may use the CMAKE_CROSSCOMPILING_EMULATOR to run the code.

How does it behave if such a thing isn't hooked up? Ideally it'd fall back silently and these parts of tests would just fail, but not block things overall.

Mar 11 2021, 1:51 AM · Restricted Project, Restricted Project

Mar 10 2021

zero9178 updated the diff for D98278: [test] Add ability to get error messages from CMake for errc substitution.

Add GetErrcMessages.cmake, which contains a cmake function to automatically get the error messages of various posix error codes needed by lit by running a small C++ program.
Currently ENOENT, EISDIR, EINVAL and EACCES are supplied.
These error messages are then currently supplied to clang, llvm and lld as the errc_messages config parameter.

Mar 10 2021, 7:43 AM · Restricted Project, Restricted Project