- User Since
- Aug 14 2019, 12:14 PM (96 w, 3 d)
Tue, Jun 15
Sun, Jun 13
Sat, Jun 12
Thu, Jun 10
Wed, Jun 9
Microsofts STL does seem to be doing the same as can be seen here: https://github.com/microsoft/STL/blob/62137922ab168f8e23ec1a95c946821e24bde230/stl/inc/exception#L63.
Mon, Jun 7
I shall do that.
Thanks for the info, seems like I was mislead after testing it again.
I think adding /permissive- to make things more conforming is great. The docs say "Starting in Visual Studio 2019 version 16.8, the /std:c++latest option implicitly sets the /permissive- option." so maybe we should do that too (doesn't have to be in this patch).
Sun, Jun 6
Rebased onto main
Rebase & add comment in source code explaining the purpose of the define
Sat, Jun 5
Thu, Jun 3
Tue, May 25
Addressed review comments in final commit
Changed links named "TensorType" to "RankedTensorType".
Mon, May 24
Remove anchor name from prior art in RationaleLinalgDialect. This way generated name to refer to the section in Markdown is just "prior-art"
Addressed Review comments.
Sun, May 23
May 17 2021
Mar 29 2021
Thanks a lot for the help.
I have now added tests that reproduce the issue and also ensure the error is emitted.
Mar 27 2021
Mar 26 2021
As a very new contributor to LLVM (and open source in general, truth be told), I would like to just quickly mention that I like this addition to the documentation a lot. Getting one's commit reverted is definitely a rather scary experience at first, but I think this documentation, and in particular the wording chosen, helps reinforce LLVM as a positive development environment. It has certainly helped me.
Mar 25 2021
Mar 22 2021
Mar 20 2021
The issues @mstorsjo has mentioned should be addressed. Merging the second and current version of that patch would probably do the trick.
Mar 19 2021
LGTM as well
Mar 18 2021
After taking a further look, I think part of the problem is that in the CMakeLists.txt of llvm, get_errc_messages get run unconditionally. I assume there are many users out there who want to cross compile, not want to set such variables and are also not interested in running tests. Maybe you could move that invocation into a block guarded by LLVM_INCLUDE_TESTS? That'd be all from me unless anyone else has any inquiries.
Just wondering, what's the current behaviour without these patches? I am aware that if CMAKE_CROSSCOMPILING_EMULATOR is not set, it can't be executed but does configuration automatically fail or does an error appear elsewhere down the line?
Mar 17 2021
Mar 16 2021
I addressed your comments in https://reviews.llvm.org/rG4a17ac0387f078529da02e355a24df99f645d364. Hope it should be alright now
Mar 15 2021
Ping. I believe I also need approval from libc++ maintainers.
Rebased and reformatted python code to 80 column limit.
Mar 11 2021
Mar 10 2021
Add GetErrcMessages.cmake, which contains a cmake function to automatically get the error messages of various posix error codes needed by lit by running a small C++ program.
Currently ENOENT, EISDIR, EINVAL and EACCES are supplied.
These error messages are then currently supplied to clang, llvm and lld as the errc_messages config parameter.