User Details
- User Since
- Aug 9 2020, 2:16 PM (136 w, 1 d)
Thu, Mar 16
rebase
Tue, Mar 14
add import test
amazing
Sun, Mar 12
Yep thanks for the suggestion
Fri, Mar 10
Wed, Mar 8
Tue, Mar 7
Mon, Mar 6
IMO that would make sense to me. Anything to land these changes incrementally.
LGTM
LGTM but River mentioned there were some perf issues. Do have a quick capture of the before vs. after time to run a pattern-heavy workload?
mostly stylistic comments
Sat, Mar 4
+1 to what Alex said, but otherwise LGT
Tue, Feb 28
+1 finally I'm happy to see this
Thu, Feb 23
FYI there's still mention of this folder API thing in the MLIR docs
please add a test
Wed, Feb 22
comments
Tue, Feb 21
This change overall makes sense to me
Sun, Feb 19
Feb 17 2023
Feb 16 2023
Is this meant to fix something?
Feb 15 2023
Please add a test
Feb 13 2023
sure
LGTM. mlir-translate is intended first and foremost to be a testing tool. Making it easier to test with makes sense to me.
Feb 2 2023
landed
Was there a discourse discussion on this? I might've missed it. If there isn't, I'm 100% behind the rationale I think is behind this change, but I would still like to see it discussed.
I think a unit test would've been more appropriate in this case, but LGTM
Jan 24 2023
Jan 20 2023
I assume AttrTypeHandler is now the only way to override the walk behaviour for an attribute or type? (And provide it for unusual attributes and types that might be written in C++..)
Jan 15 2023
nice
LGTM, thanks!
Jan 13 2023
I don't understand how this fixes the issue. How are you able to dereference an uninitialized optional?
Jan 12 2023
nuceu
rebase+review comments
rebase
Jan 11 2023
nice
review comments and update description with migration instructions
Jan 10 2023
There's a build option to disable TableGen warnings. That should work, of course.
fix build
Jan 9 2023
review comments
thank
Jan 8 2023
Yup
IRMapping
rebase