Page MenuHomePhabricator

Mogball (Jeff Niu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 9 2020, 2:16 PM (92 w, 12 h)

Recent Activity

Sat, May 14

Mogball added a comment to D125595: (DRAFT) [mlir][ods] Don't allow trailing optional operands in assembly formats.

Basically, I threw this patch up because I don't think, as things stand, there's a great way to detect this ambiguity. A lot of ops use the format $variadicOperands attr-dict require at least 1 operand or have some other invariant that make the format not actually ambiguous. Enforcing this check would make a lot of existing formats uglier than they need to be...

Sat, May 14, 12:05 AM · Restricted Project, Restricted Project

Fri, May 13

Mogball updated the diff for D125063: [mlir][transforms] Add a topological sort utility and pass.

review comments, and drop requirement that blocks need to not have SSA dominance

Fri, May 13, 6:30 PM · Restricted Project, Restricted Project
Mogball planned changes to D125595: (DRAFT) [mlir][ods] Don't allow trailing optional operands in assembly formats.
Fri, May 13, 6:17 PM · Restricted Project, Restricted Project
Mogball updated the diff for D125595: (DRAFT) [mlir][ods] Don't allow trailing optional operands in assembly formats.

make it compile at least

Fri, May 13, 6:16 PM · Restricted Project, Restricted Project
Mogball removed reviewers for D125595: (DRAFT) [mlir][ods] Don't allow trailing optional operands in assembly formats: herhut, jpienaar, bondhugula, ThomasRaoux.
Fri, May 13, 6:02 PM · Restricted Project, Restricted Project
Mogball planned changes to D125595: (DRAFT) [mlir][ods] Don't allow trailing optional operands in assembly formats.
Fri, May 13, 6:02 PM · Restricted Project, Restricted Project
Mogball edited reviewers for D125595: (DRAFT) [mlir][ods] Don't allow trailing optional operands in assembly formats, added: lattner; removed: jpienaar, bondhugula, ThomasRaoux, herhut.
Fri, May 13, 6:02 PM · Restricted Project, Restricted Project
Mogball requested review of D125595: (DRAFT) [mlir][ods] Don't allow trailing optional operands in assembly formats.
Fri, May 13, 6:01 PM · Restricted Project, Restricted Project
Mogball committed rGbf8049dc4831: [mlir][ods] (NFC) remove erroneous trait (authored by Mogball).
[mlir][ods] (NFC) remove erroneous trait
Fri, May 13, 5:38 PM · Restricted Project, Restricted Project
Mogball committed rG70b69c54fa8b: [mlir] Rename Zero* traits to Zero*s (authored by Mogball).
[mlir] Rename Zero* traits to Zero*s
Fri, May 13, 5:21 PM · Restricted Project, Restricted Project
Mogball updated the diff for D125445: [mlir][ods] Fix verification of attribute + colon type ambiguity.

simplify the implementation of the attribute-colon verifier and catch more cases

Fri, May 13, 3:40 PM · Restricted Project, Restricted Project
Mogball added inline comments to D125445: [mlir][ods] Fix verification of attribute + colon type ambiguity.
Fri, May 13, 11:02 AM · Restricted Project, Restricted Project
Mogball added inline comments to D125063: [mlir][transforms] Add a topological sort utility and pass.
Fri, May 13, 10:07 AM · Restricted Project, Restricted Project

Wed, May 11

Mogball committed rG0ffef0c23b51: [mlir][ods] (NFC) don't use std::function for map_range (authored by Mogball).
[mlir][ods] (NFC) don't use std::function for map_range
Wed, May 11, 10:15 PM · Restricted Project, Restricted Project
Mogball added inline comments to D125063: [mlir][transforms] Add a topological sort utility and pass.
Wed, May 11, 10:04 PM · Restricted Project, Restricted Project
Mogball updated the diff for D125063: [mlir][transforms] Add a topological sort utility and pass.

split out TestOps change as NFC

Wed, May 11, 9:51 PM · Restricted Project, Restricted Project
Mogball committed rG19906262c9cc: [mlir] (NFC) Use assembly format for test.graph_region (authored by Mogball).
[mlir] (NFC) Use assembly format for test.graph_region
Wed, May 11, 9:20 PM · Restricted Project, Restricted Project
Mogball added a reviewer for D124025: [mlir][GPU] Integer range inference for GPU index ops: Mogball.
Wed, May 11, 9:05 PM · Restricted Project, Restricted Project
Mogball added inline comments to D124025: [mlir][GPU] Integer range inference for GPU index ops.
Wed, May 11, 9:04 PM · Restricted Project, Restricted Project
Mogball accepted D124024: [mlir][Arith] Pass to switch signed ops for equivalent unsigned ones.
Wed, May 11, 9:02 PM · Restricted Project, Restricted Project
Mogball accepted D124022: [mlir][Arith] Implement InferIntRangeInterface for arithmetic ops.

LGTM but I'm not really an authority on the integer arithmetic...

Wed, May 11, 8:58 PM · Restricted Project, Restricted Project
Mogball accepted D124023: [mlir][Arith] Add integer range inference analysis.

Could you add one test op that sets the ranges of its block arguments and test that it works correctly?

Wed, May 11, 8:36 PM · Restricted Project, Restricted Project
Mogball updated the diff for D125445: [mlir][ods] Fix verification of attribute + colon type ambiguity.

add extra test case

Wed, May 11, 8:21 PM · Restricted Project, Restricted Project
Mogball requested review of D125445: [mlir][ods] Fix verification of attribute + colon type ambiguity.
Wed, May 11, 8:17 PM · Restricted Project, Restricted Project
Mogball committed rGa4b227c28aba: [mlir] Fix loop unrolling: properly replace the arguments of the epilogue loop. (authored by grosul1).
[mlir] Fix loop unrolling: properly replace the arguments of the epilogue loop.
Wed, May 11, 6:55 PM · Restricted Project, Restricted Project
Mogball added a comment to D124023: [mlir][Arith] Add integer range inference analysis.

MLIR is not entirely consistent with the namespace end comment but the preferred way is as such

Wed, May 11, 4:11 AM · Restricted Project, Restricted Project
Mogball added inline comments to D124023: [mlir][Arith] Add integer range inference analysis.
Wed, May 11, 4:08 AM · Restricted Project, Restricted Project
Mogball added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

I'm open to iterating in tree. Landing this utility first and then try adding it as a canonicalization SGTM.

Wed, May 11, 3:55 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 10

Mogball added a comment to D124023: [mlir][Arith] Add integer range inference analysis.

Mostly LGTM, just missing some tests

Tue, May 10, 9:26 AM · Restricted Project, Restricted Project
Mogball added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

On the matter of whether this should be a canonicalization, my concern with this is that if an operation has its own preferred ordering of operands that conflicts with the sort, then this will cause canonicalization to loop infinitely.

Tue, May 10, 7:59 AM · Restricted Project, Restricted Project, Restricted Project
Mogball added a comment to D124750: [MLIR] Add a utility to sort the operands of commutative ops.

I need to look at the algorithm in more detail, but I'm not a fan of using a string key. Concatenating strings to make compound keys is not very efficient and potentially brittle. Can you assign unique IDs and use an array of IDs instead?

Tue, May 10, 7:53 AM · Restricted Project, Restricted Project, Restricted Project
Mogball added a comment to D124023: [mlir][Arith] Add integer range inference analysis.

SCCP will defer to Dialect::materializeConstant. You could do the same with your pass.

Tue, May 10, 7:50 AM · Restricted Project, Restricted Project

Sun, May 8

Mogball accepted D125030: [mlir][LLVMIR] Add support for translating shufflevector.
Sun, May 8, 5:55 PM · Restricted Project, Restricted Project
Mogball accepted D125028: [mlir][LLVMIR] Add support for translating insert/extractvalue.
Sun, May 8, 5:54 PM · Restricted Project, Restricted Project
Mogball added a comment to D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..

Yeah that's... unfortunate to hear. ODS can be a bag of knives sometimes. I'll take a look at the bugs.

Sun, May 8, 5:14 PM · Restricted Project, Restricted Project

Fri, May 6

Mogball added inline comments to D125136: [mlir] Print some message for op-printing verification.
Fri, May 6, 3:16 PM · Restricted Project, Restricted Project
Mogball added inline comments to D125063: [mlir][transforms] Add a topological sort utility and pass.
Fri, May 6, 9:19 AM · Restricted Project, Restricted Project

Thu, May 5

Mogball added a comment to D125063: [mlir][transforms] Add a topological sort utility and pass.

Context: this pass was sitting around internally and since it's not anything specific, thought I'd upstream it

Thu, May 5, 6:41 PM · Restricted Project, Restricted Project
Mogball requested review of D125063: [mlir][transforms] Add a topological sort utility and pass.
Thu, May 5, 6:41 PM · Restricted Project, Restricted Project
Mogball added inline comments to D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..
Thu, May 5, 2:39 PM · Restricted Project, Restricted Project
Mogball requested changes to D125028: [mlir][LLVMIR] Add support for translating insert/extractvalue.

thanks for all the additions, by the way

Thu, May 5, 2:32 PM · Restricted Project, Restricted Project
Mogball requested changes to D125030: [mlir][LLVMIR] Add support for translating shufflevector.
Thu, May 5, 2:30 PM · Restricted Project, Restricted Project
Mogball added a comment to D124023: [mlir][Arith] Add integer range inference analysis.

So to keep the ball rolling on this one, I will pretend to be river and answer your questions :P

Thu, May 5, 2:28 PM · Restricted Project, Restricted Project

Thu, Apr 28

Mogball added inline comments to D124023: [mlir][Arith] Add integer range inference analysis.
Thu, Apr 28, 2:52 PM · Restricted Project, Restricted Project
Mogball accepted D124627: [mlir][LLVMIR] Do not update instMap via assignments to map entry references.

lgtm but you might want to wait if anyone else has complaints

Thu, Apr 28, 2:49 PM · Restricted Project, Restricted Project
Mogball accepted D124628: [mlir][LLVMIR] Add support for translating Switch instruction.

Thanks for all the fixes/additions to the LLVM importer

Thu, Apr 28, 2:48 PM · Restricted Project, Restricted Project
Mogball accepted D124627: [mlir][LLVMIR] Do not update instMap via assignments to map entry references.
Thu, Apr 28, 11:53 AM · Restricted Project, Restricted Project
Mogball requested changes to D124628: [mlir][LLVMIR] Add support for translating Switch instruction.
Thu, Apr 28, 11:51 AM · Restricted Project, Restricted Project
Mogball accepted D124630: [mlir][LLVMIR] Add support for translating FCmp & more FP constants.
Thu, Apr 28, 11:43 AM · Restricted Project, Restricted Project
Mogball added inline comments to D124023: [mlir][Arith] Add integer range inference analysis.
Thu, Apr 28, 9:17 AM · Restricted Project, Restricted Project

Mon, Apr 25

Mogball added a comment to D124023: [mlir][Arith] Add integer range inference analysis.

Yeah, I'm fine with moving forward on this. I don't see anything here that's tied to the arithmetic dialect and that couldn't just be moved to another directory and renamed.

Mon, Apr 25, 3:49 PM · Restricted Project, Restricted Project
Mogball committed rGc4caa90b1523: [mlir][tblgen] Generate builders with inferred return types and unwrapped… (authored by jfurtek).
[mlir][tblgen] Generate builders with inferred return types and unwrapped…
Mon, Apr 25, 12:01 PM · Restricted Project, Restricted Project
Mogball closed D124043: [mlir][tblgen] Generate builders with inferred return types and unwrapped attributes.
Mon, Apr 25, 12:00 PM · Restricted Project, Restricted Project
Mogball committed rGa266a2100012: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes (authored by jfurtek).
[mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes
Mon, Apr 25, 12:00 PM · Restricted Project, Restricted Project
Mogball closed D123880: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
Mon, Apr 25, 12:00 PM · Restricted Project, Restricted Project
Mogball added a comment to D124023: [mlir][Arith] Add integer range inference analysis.

One thing I would love to avoid here, though, is building things very specific and anchored to the arithmetic dialect.

Mon, Apr 25, 11:58 AM · Restricted Project, Restricted Project
Mogball committed rG4e5dee2f30dd: [mlir][ods] Add tablegen field for concise printing of BitEnum attributes (authored by jfurtek).
[mlir][ods] Add tablegen field for concise printing of BitEnum attributes
Mon, Apr 25, 11:49 AM · Restricted Project, Restricted Project
Mogball closed D123871: [mlir][ods] Add tablegen field for concise printing of BitEnum attributes.
Mon, Apr 25, 11:48 AM · Restricted Project, Restricted Project

Sun, Apr 24

Mogball added inline comments to D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..
Sun, Apr 24, 11:57 AM · Restricted Project, Restricted Project
Mogball added a comment to D124023: [mlir][Arith] Add integer range inference analysis.

@krzysz00 A few months back, I had attempted a generic value-range analysis in MLIR (see https://github.com/vaivaswatha/llvm-project/pull/1). While I had (privately) requested for initial design feedback from @rriddle , I couldn't get around to post an official patch on it.

Some notes on my attempt:

  1. I imagined that the analysis, in addition to the basic framework for VRP (value-range-propagation) also will provide transfer functions (i.e., how an operation behaves, given ranges for its input, will provide ranges for its output) for some standard / common operations. Clients of the analysis can extend on this as needed. The interface I have isn't really perfect, but I suppose we can discuss improvements.
  2. Other than the interface design improvements needed, I think all that'll be left to be done is to define transfer functions for as many operations as necessary (I've done it, to demonstrate, for Abs, Add and Mul).

I think we could collaborate on this to have one unified work, picking the best of both. Probably @rriddle can advice best.

Sun, Apr 24, 11:51 AM · Restricted Project, Restricted Project
Mogball accepted D124021: [mlir] Allow data flow analysis of non-control flow branch arguments.
Sun, Apr 24, 11:20 AM · Restricted Project, Restricted Project

Fri, Apr 22

Mogball accepted D124181: [mlir] use side effects in the Transform dialect.
Fri, Apr 22, 9:59 AM · Restricted Project, Restricted Project

Thu, Apr 21

Mogball added inline comments to D124021: [mlir] Allow data flow analysis of non-control flow branch arguments.
Thu, Apr 21, 5:10 PM · Restricted Project, Restricted Project
Mogball added inline comments to D124048: [MLIR] Add option to print users of an operation as comment in the printer.
Thu, Apr 21, 4:58 PM · Restricted Project, Restricted Project
Mogball added a comment to D124181: [mlir] use side effects in the Transform dialect.

Does allowing the reordering of transform operations really make sense if they do not declare all their pattern inputs and outputs? E.g.

Thu, Apr 21, 3:20 PM · Restricted Project, Restricted Project

Wed, Apr 20

Mogball accepted D124007: [mlir] Connect Transform dialect to PDL.
Wed, Apr 20, 11:19 AM · Restricted Project, Restricted Project
Mogball accepted D123917: [mlir] Make `Regions`s `cloneInto` multithread-readable.

Thanks for checking the performance!

Wed, Apr 20, 11:15 AM · Restricted Project, Restricted Project

Tue, Apr 19

Mogball added inline comments to D124007: [mlir] Connect Transform dialect to PDL.
Tue, Apr 19, 3:37 PM · Restricted Project, Restricted Project
Mogball added a comment to D123917: [mlir] Make `Regions`s `cloneInto` multithread-readable.

Have you measured the performance of the new clone to ensure parity? Inlining in TF can get kind of heavy...

Tue, Apr 19, 3:16 PM · Restricted Project, Restricted Project
Mogball added a comment to D124021: [mlir] Allow data flow analysis of non-control flow branch arguments.

You can write a dummy test pass that just prints some text.

Tue, Apr 19, 2:59 PM · Restricted Project, Restricted Project
Mogball removed a reviewer for D116246: Demo fix for misc-unused-parameters (WIP): Mogball.
Tue, Apr 19, 2:50 PM · Restricted Project, Restricted Project
Mogball added a reviewer for D124022: [mlir][Arith] Implement InferIntRangeInterface for arithmetic ops: Mogball.
Tue, Apr 19, 11:53 AM · Restricted Project, Restricted Project
Mogball added inline comments to D124022: [mlir][Arith] Implement InferIntRangeInterface for arithmetic ops.
Tue, Apr 19, 11:53 AM · Restricted Project, Restricted Project
Mogball accepted D124020: [mlir] Adds getUpperBound() to LoopLikeInterface..
Tue, Apr 19, 11:51 AM · Restricted Project, Restricted Project
Mogball added a reviewer for D124020: [mlir] Adds getUpperBound() to LoopLikeInterface.: Mogball.
Tue, Apr 19, 11:51 AM · Restricted Project, Restricted Project
Mogball added a reviewer for D124021: [mlir] Allow data flow analysis of non-control flow branch arguments: Mogball.
Tue, Apr 19, 11:50 AM · Restricted Project, Restricted Project
Mogball added inline comments to D124021: [mlir] Allow data flow analysis of non-control flow branch arguments.
Tue, Apr 19, 11:49 AM · Restricted Project, Restricted Project
Mogball added inline comments to D123917: [mlir] Make `Regions`s `cloneInto` multithread-readable.
Tue, Apr 19, 11:41 AM · Restricted Project, Restricted Project
Mogball added inline comments to D124007: [mlir] Connect Transform dialect to PDL.
Tue, Apr 19, 11:36 AM · Restricted Project, Restricted Project

Mon, Apr 18

Mogball accepted D123664: [mlir][transform] Introduce transform.sequence op.
Mon, Apr 18, 6:14 PM · Restricted Project, Restricted Project
Mogball added inline comments to D123917: [mlir] Make `Regions`s `cloneInto` multithread-readable.
Mon, Apr 18, 6:10 PM · Restricted Project, Restricted Project
Mogball accepted D123880: [mlir][ods] Extend the EnumAttr tablegen class to support BitEnum attributes.
Mon, Apr 18, 6:01 PM · Restricted Project, Restricted Project

Apr 15 2022

Mogball committed rGb1d3faab7a35: [NFC] fix cmake build (authored by Mogball).
[NFC] fix cmake build
Apr 15 2022, 5:57 PM · Restricted Project, Restricted Project
Mogball committed rGfa26c7ff4b5d: [mlir] Refactor LICM into a utility (authored by Mogball).
[mlir] Refactor LICM into a utility
Apr 15 2022, 5:37 PM · Restricted Project, Restricted Project
Mogball committed rG3131f808243a: [mlir] Refactor LICM into a utility (authored by Mogball).
[mlir] Refactor LICM into a utility
Apr 15 2022, 3:07 PM · Restricted Project, Restricted Project
Mogball committed rG3430ae1e7baa: [mlir] Update LICM to support Graph Regions (authored by Mogball).
[mlir] Update LICM to support Graph Regions
Apr 15 2022, 10:30 AM · Restricted Project, Restricted Project
Mogball closed D122465: [mlir] Update LICM to support Graph Regions.
Apr 15 2022, 10:30 AM · Restricted Project, Restricted Project, Restricted Project
Mogball committed rGbed8212157bb: [mlir][ods][NFC] Move enum attribute definitions from OpBase.td to EnumAttr.td (authored by jfurtek).
[mlir][ods][NFC] Move enum attribute definitions from OpBase.td to EnumAttr.td
Apr 15 2022, 9:51 AM · Restricted Project, Restricted Project
Mogball closed D123551: [mlir][ods][NFC] Move enum attribute definitions from OpBase.td to EnumAttr.td.
Apr 15 2022, 9:51 AM · Restricted Project, Restricted Project

Apr 13 2022

Mogball added inline comments to D123664: [mlir][transform] Introduce transform.sequence op.
Apr 13 2022, 10:06 PM · Restricted Project, Restricted Project
Mogball accepted D123135: [mlir] Introduce Transform dialect.

LGTM.

Apr 13 2022, 11:01 AM · Restricted Project, Restricted Project
Mogball committed rG60e34f8dddb4: [mlir][ods] Remove StrEnumAttr (authored by Mogball).
[mlir][ods] Remove StrEnumAttr
Apr 13 2022, 10:49 AM · Restricted Project, Restricted Project
Mogball closed D120834: [mlir][ods] Remove StrEnumAttr.
Apr 13 2022, 10:49 AM · Restricted Project, Restricted Project

Apr 12 2022

Mogball accepted D123412: [mlir][LLVM-IR] Added support for global variable attributes.
Apr 12 2022, 9:39 AM · Restricted Project, Restricted Project

Apr 11 2022

Mogball updated the diff for D122465: [mlir] Update LICM to support Graph Regions.

review comments -- adding some tests

Apr 11 2022, 5:50 PM · Restricted Project, Restricted Project, Restricted Project
Mogball added inline comments to D122465: [mlir] Update LICM to support Graph Regions.
Apr 11 2022, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
Mogball added inline comments to D122465: [mlir] Update LICM to support Graph Regions.
Apr 11 2022, 3:29 PM · Restricted Project, Restricted Project, Restricted Project
Mogball committed rG15a65594c1c0: [mlir][ods] ODS-level Attribute Optimizations (authored by Mogball).
[mlir][ods] ODS-level Attribute Optimizations
Apr 11 2022, 11:34 AM · Restricted Project, Restricted Project
Mogball closed D122430: [mlir][ods] ODS-level Attribute Optimizations.
Apr 11 2022, 11:34 AM · Restricted Project, Restricted Project
Mogball added inline comments to D123412: [mlir][LLVM-IR] Added support for global variable attributes.
Apr 11 2022, 9:52 AM · Restricted Project, Restricted Project