Page MenuHomePhabricator

Mogball (Jeff Niu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 9 2020, 2:16 PM (136 w, 1 d)

Recent Activity

Thu, Mar 16

Mogball committed rG79afa58c2779: [mlir][llvm] Add fastmathFlags to SelectOp (authored by Mogball).
[mlir][llvm] Add fastmathFlags to SelectOp
Thu, Mar 16, 12:58 AM · Restricted Project, Restricted Project
Mogball closed D145829: [mlir][llvm] Add fastmathFlags to SelectOp.
Thu, Mar 16, 12:58 AM · Restricted Project, Restricted Project
Mogball updated the diff for D145829: [mlir][llvm] Add fastmathFlags to SelectOp.

rebase

Thu, Mar 16, 12:56 AM · Restricted Project, Restricted Project

Tue, Mar 14

Mogball updated the diff for D145829: [mlir][llvm] Add fastmathFlags to SelectOp.

add import test

Tue, Mar 14, 11:55 PM · Restricted Project, Restricted Project
Mogball accepted D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard.

amazing

Tue, Mar 14, 11:47 PM · Restricted Project, Restricted Project

Sun, Mar 12

Mogball added a comment to D145829: [mlir][llvm] Add fastmathFlags to SelectOp.

Yep thanks for the suggestion

Sun, Mar 12, 5:13 PM · Restricted Project, Restricted Project

Fri, Mar 10

Mogball requested review of D145829: [mlir][llvm] Add fastmathFlags to SelectOp.
Fri, Mar 10, 2:00 PM · Restricted Project, Restricted Project

Wed, Mar 8

Mogball added inline comments to D144204: [mlir] Reintroduce API for creating operations with a DictionaryAttr.
Wed, Mar 8, 11:56 PM · Restricted Project, Restricted Project

Tue, Mar 7

Mogball added inline comments to D144469: [mlir] Implement test pass for 1:N type conversions..
Tue, Mar 7, 6:48 AM · Restricted Project, Restricted Project

Mon, Mar 6

Mogball added a comment to D144693: [mlir][irdl] Add IRDL registration.

IMO that would make sense to me. Anything to land these changes incrementally.

Mon, Mar 6, 11:51 PM · Restricted Project, Restricted Project
Mogball added a comment to D144693: [mlir][irdl] Add IRDL registration.

This patch seems to be doing a lot of things at once. I would split out registration in mlir-opt from the various IRDL things being added, and make things a bit more incremental, given the IRDL constructs could be tested via a test-pass (for example).

Do you mean removing the MLIROptMain change for another patch, and then test the rest of the patch in a test-pass (I guess I can add features one by one, like first registration of types/attributes, then of operations).

If I'm correct, you are proposing to have a pass similar to the PDL one that register rewrites that are part of the file (with the -test-pdl-bytecode-pass pass). However, I couldn't do something similar with IRDL, since we cannot parse the entire file until the attributes are registered from what I understand.

Is that what you meant? I probably misunderstood something

Mon, Mar 6, 11:43 PM · Restricted Project, Restricted Project
Mogball accepted D144818: Refactor the mlir-opt command line options related to debugging in a helper.

LGTM

Mon, Mar 6, 11:57 AM · Restricted Project, Restricted Project
Mogball added inline comments to D144817: Add a GDB/LLDB interface for interactive debugging of MLIR Actions.
Mon, Mar 6, 11:54 AM · Restricted Project, Restricted Project
Mogball added a comment to D144816: Add tracing for pattern application in a ApplyPatternAction.

LGTM but River mentioned there were some perf issues. Do have a quick capture of the before vs. after time to run a pattern-heavy workload?

Mon, Mar 6, 11:52 AM · Restricted Project, Restricted Project
Mogball added inline comments to D144815: Add a breakpoint manager that matches based on File/Line/Col Locations.
Mon, Mar 6, 11:51 AM · Restricted Project, Restricted Project
Mogball accepted D144814: Add capture of "IRUnits" as context for an MLIR Action.
Mon, Mar 6, 11:45 AM · Restricted Project, Restricted Project
Mogball added inline comments to D144813: Add an Observer for logging actions application to a stream.
Mon, Mar 6, 11:43 AM · Restricted Project, Restricted Project
Mogball accepted D144812: Introduce mlir::tracing::ExecutionContext.
Mon, Mar 6, 11:42 AM · Restricted Project, Restricted Project
Mogball added a comment to D144692: [mlir] Introduce IRDL dialect.

mostly stylistic comments

Mon, Mar 6, 11:36 AM · Restricted Project, Restricted Project
Mogball added inline comments to D144693: [mlir][irdl] Add IRDL registration.
Mon, Mar 6, 11:34 AM · Restricted Project, Restricted Project
Mogball requested changes to D144693: [mlir][irdl] Add IRDL registration.
Mon, Mar 6, 11:30 AM · Restricted Project, Restricted Project
Mogball accepted D144690: [mlir] Add setters for Dynamic[Type|Attr]Definition.
Mon, Mar 6, 11:24 AM · Restricted Project, Restricted Project

Sat, Mar 4

Mogball accepted D145288: [mlir][scf] Relax type requirement on for.

+1 to what Alex said, but otherwise LGT

Sat, Mar 4, 2:11 AM · Restricted Project, Restricted Project

Tue, Feb 28

Mogball added a comment to D144503: [ADT] Allow `llvm::enumerate` to enumerate over multiple ranges.

+1 finally I'm happy to see this

Tue, Feb 28, 8:36 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Feb 23

Mogball added a comment to D144391: [mlir] Complety remove old `fold` API.

FYI there's still mention of this folder API thing in the MLIR docs

Thu, Feb 23, 3:15 PM · Restricted Project, Restricted Project
Mogball accepted D144257: [mlir][IR] Add Iterator template option to IR walkers.
Thu, Feb 23, 3:14 PM · Restricted Project, Restricted Project
Mogball added a comment to D144549: [mlir][IR] Trigger notifyOperationModified for replacements.

please add a test

Thu, Feb 23, 3:13 PM · Restricted Project, Restricted Project

Wed, Feb 22

Mogball committed rG55bc18a7de91: [mlir] Fix typo causing build error (authored by Mogball).
[mlir] Fix typo causing build error
Wed, Feb 22, 2:06 PM · Restricted Project, Restricted Project
Mogball committed rG2cfc66a6fa66: [mlir] Add a SharedSymbolTableCollection class (authored by Mogball).
[mlir] Add a SharedSymbolTableCollection class
Wed, Feb 22, 1:58 PM · Restricted Project, Restricted Project
Mogball closed D144507: [mlir] Add a SharedSymbolTableCollection class.
Wed, Feb 22, 1:57 PM · Restricted Project, Restricted Project
Mogball updated the diff for D144507: [mlir] Add a SharedSymbolTableCollection class.

comments

Wed, Feb 22, 1:57 PM · Restricted Project, Restricted Project

Tue, Feb 21

Mogball accepted D144251: [mlir][arith] Fold on extension of FP constants using arith.extf.
Tue, Feb 21, 11:58 AM · Restricted Project, Restricted Project
Mogball added a comment to D144257: [mlir][IR] Add Iterator template option to IR walkers.

This change overall makes sense to me

Tue, Feb 21, 11:57 AM · Restricted Project, Restricted Project
Mogball requested review of D144507: [mlir] Add a SharedSymbolTableCollection class.
Tue, Feb 21, 10:06 AM · Restricted Project, Restricted Project

Sun, Feb 19

Mogball accepted D144193: [mlir][IR] Trigger notifyOperationRemoved callback for nested ops.
Sun, Feb 19, 12:32 AM · Restricted Project, Restricted Project

Feb 17 2023

Mogball committed rGf25cfd339a80: [mlir] Reintroduce API for creating operations with a DictionaryAttr (authored by Mogball).
[mlir] Reintroduce API for creating operations with a DictionaryAttr
Feb 17 2023, 10:08 AM · Restricted Project, Restricted Project
Mogball closed D144204: [mlir] Reintroduce API for creating operations with a DictionaryAttr.
Feb 17 2023, 10:08 AM · Restricted Project, Restricted Project

Feb 16 2023

Mogball requested review of D144204: [mlir] Reintroduce API for creating operations with a DictionaryAttr.
Feb 16 2023, 10:45 AM · Restricted Project, Restricted Project
Mogball added a comment to D144193: [mlir][IR] Trigger notifyOperationRemoved callback for nested ops.

Is this meant to fix something?

Feb 16 2023, 10:36 AM · Restricted Project, Restricted Project

Feb 15 2023

Mogball accepted D141661: [mlir] Add check for value that might be null..
Feb 15 2023, 10:33 PM · Restricted Project, Restricted Project
Mogball added a comment to D141661: [mlir] Add check for value that might be null..

Please add a test

Feb 15 2023, 9:05 AM · Restricted Project, Restricted Project

Feb 13 2023

Mogball added a comment to D143779: [mlir][arith] Allow to specify `constFoldBinaryOp` result type.

sure

Feb 13 2023, 11:02 AM · Restricted Project, Restricted Project
Mogball accepted D143801: [mlir][arith] Fold selection over constant vector conditions.
Feb 13 2023, 10:43 AM · Restricted Project, Restricted Project
Mogball added inline comments to D143779: [mlir][arith] Allow to specify `constFoldBinaryOp` result type.
Feb 13 2023, 9:56 AM · Restricted Project, Restricted Project
Mogball added inline comments to D143779: [mlir][arith] Allow to specify `constFoldBinaryOp` result type.
Feb 13 2023, 8:55 AM · Restricted Project, Restricted Project
Mogball accepted D143779: [mlir][arith] Allow to specify `constFoldBinaryOp` result type.
Feb 13 2023, 8:54 AM · Restricted Project, Restricted Project
Mogball accepted D143719: [mlir] Execute all requested translations in MlirTranslateMain.

LGTM. mlir-translate is intended first and foremost to be a testing tool. Making it easier to test with makes sense to me.

Feb 13 2023, 8:53 AM · Restricted Project, Restricted Project

Feb 2 2023

Mogball committed rG2fce90938bb5: [mlir][affine] fix affine LICM pass for has effected memory's user (authored by lipracer).
[mlir][affine] fix affine LICM pass for has effected memory's user
Feb 2 2023, 10:25 AM · Restricted Project, Restricted Project
Mogball added a comment to D141106: [mlir][affine] fix affine LICM pass for has effected memory's user.

landed

Feb 2 2023, 10:25 AM · Restricted Project, Restricted Project
Mogball closed D141106: [mlir][affine] fix affine LICM pass for has effected memory's user.
Feb 2 2023, 10:25 AM · Restricted Project, Restricted Project
Mogball added a comment to D143190: [mlir][ods] add mechanism for deprecating an `OpBuilder` in ODS.

Was there a discourse discussion on this? I might've missed it. If there isn't, I'm 100% behind the rationale I think is behind this change, but I would still like to see it discussed.

Feb 2 2023, 10:21 AM · Restricted Project, Restricted Project
Mogball accepted D142952: [mlir][scf] Fix builder of WhileOp with region builder arguments..

I think a unit test would've been more appropriate in this case, but LGTM

Feb 2 2023, 10:19 AM · Restricted Project, Restricted Project

Jan 24 2023

Mogball accepted D142182: [MLIR] Expose LocationAttrs in the C API.
Jan 24 2023, 10:51 PM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2023

Mogball accepted D142272: [mlir] Promote the SubElementInterfaces to a core Attribute/Type construct.

I assume AttrTypeHandler is now the only way to override the walk behaviour for an attribute or type? (And provide it for unusual attributes and types that might be written in C++..)

Jan 20 2023, 10:03 PM · Restricted Project, Restricted Project
Mogball accepted D142147: [mlir][Index] Implement InferIntRangeInterface, re-land.
Jan 20 2023, 9:06 AM · Restricted Project, Restricted Project

Jan 15 2023

Mogball added a comment to D141783: [MLIR] Simplify predicate in Matchers.h, NFC.

nice

Jan 15 2023, 10:34 AM · Restricted Project, Restricted Project
Mogball accepted D140899: [mlir][Index] Implement InferIntRangeInterface.

LGTM, thanks!

Jan 15 2023, 10:33 AM · Restricted Project, Restricted Project
Mogball accepted D141795: [mlir][NFC] Set `useFoldAPI` to `kEmitRawAttributesFolder` value for some dialects missed previously.
Jan 15 2023, 10:33 AM · Restricted Project, Restricted Project

Jan 13 2023

Mogball added a comment to D141661: [mlir] Add check for value that might be null..

I don't understand how this fixes the issue. How are you able to dereference an uninitialized optional?

Jan 13 2023, 12:30 AM · Restricted Project, Restricted Project

Jan 12 2023

Mogball accepted D141635: [mlir][AttrType] Emit unbalanced character errors using the last punctuation used.

nuceu

Jan 12 2023, 2:27 PM · Restricted Project, Restricted Project
Mogball committed rG80246b22a621: [mlir][python] fix python build (authored by Mogball).
[mlir][python] fix python build
Jan 12 2023, 2:18 PM · Restricted Project, Restricted Project
Mogball committed rG1b60f0d73c34: [mlir][ods] Generate inferReturnTypes for ops with TypesMatchWith (authored by Mogball).
[mlir][ods] Generate inferReturnTypes for ops with TypesMatchWith
Jan 12 2023, 1:26 PM · Restricted Project, Restricted Project
Mogball closed D141231: [mlir][ods] Generate inferReturnTypes for ops with TypesMatchWith.
Jan 12 2023, 1:26 PM · Restricted Project, Restricted Project
Mogball updated the diff for D141231: [mlir][ods] Generate inferReturnTypes for ops with TypesMatchWith.

rebase+review comments

Jan 12 2023, 1:26 PM · Restricted Project, Restricted Project
Mogball added inline comments to D141231: [mlir][ods] Generate inferReturnTypes for ops with TypesMatchWith.
Jan 12 2023, 1:18 PM · Restricted Project, Restricted Project
Mogball committed rG4d67b2781731: [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping (authored by Mogball).
[mlir] Add operations to BlockAndValueMapping and rename it to IRMapping
Jan 12 2023, 1:16 PM · Restricted Project, Restricted Project, Restricted Project
Mogball closed D139665: [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping.
Jan 12 2023, 1:16 PM · Restricted Project, Restricted Project, Restricted Project
Mogball updated the diff for D139665: [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping.

rebase

Jan 12 2023, 1:15 PM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2023

Mogball accepted D141502: [mlir][Index][NFC] Migrate index dialect to the new fold API.
Jan 11 2023, 12:08 PM · Restricted Project, Restricted Project
Mogball accepted D141529: [mlir][MemRef][NFC] Migrate MemRef dialect to the new fold API.
Jan 11 2023, 12:08 PM · Restricted Project, Restricted Project
Mogball accepted D141533: [mlir][NFC] Migrate rest of the dialects to the new fold API.

nice

Jan 11 2023, 12:08 PM · Restricted Project, Restricted Project
Mogball updated the summary of D139665: [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping.
Jan 11 2023, 12:07 PM · Restricted Project, Restricted Project, Restricted Project
Mogball updated the diff for D139665: [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping.

review comments and update description with migration instructions

Jan 11 2023, 12:06 PM · Restricted Project, Restricted Project, Restricted Project
Mogball committed rGcf14ef983a49: [mlir][llvm] Add a convenience builder to BrOp (authored by Mogball).
[mlir][llvm] Add a convenience builder to BrOp
Jan 11 2023, 12:04 PM · Restricted Project, Restricted Project
Mogball closed D141522: [mlir][llvm] Add a convenience builder to BrOp.
Jan 11 2023, 12:04 PM · Restricted Project, Restricted Project
Mogball requested review of D141522: [mlir][llvm] Add a convenience builder to BrOp.
Jan 11 2023, 10:04 AM · Restricted Project, Restricted Project

Jan 10 2023

Mogball retitled D139665: [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping from [mlir] Rename BlockAndValueMapping to IRMapping and add ops to [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping.
Jan 10 2023, 9:16 AM · Restricted Project, Restricted Project, Restricted Project
Mogball added reviewers for D139665: [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping: mehdi_amini, jpienaar.
Jan 10 2023, 9:16 AM · Restricted Project, Restricted Project, Restricted Project
Mogball added a comment to D140886: [mlir] Add a new fold API using Generic Adaptors.

There's a build option to disable TableGen warnings. That should work, of course.

Jan 10 2023, 9:03 AM · Restricted Project, Restricted Project
Mogball updated the diff for D141231: [mlir][ods] Generate inferReturnTypes for ops with TypesMatchWith.

fix build

Jan 10 2023, 8:58 AM · Restricted Project, Restricted Project

Jan 9 2023

Mogball updated the diff for D141231: [mlir][ods] Generate inferReturnTypes for ops with TypesMatchWith.

review comments

Jan 9 2023, 5:42 PM · Restricted Project, Restricted Project
Mogball added inline comments to D140899: [mlir][Index] Implement InferIntRangeInterface.
Jan 9 2023, 4:40 PM · Restricted Project, Restricted Project
Mogball committed rG7ed242eecbc7: [mlir][llvm] Don't mark CallIntrinsicOp as Pure (authored by Mogball).
[mlir][llvm] Don't mark CallIntrinsicOp as Pure
Jan 9 2023, 4:21 PM · Restricted Project, Restricted Project
Mogball closed D141332: [mlir][llvm] Don't mark CallIntrinsicOp as Pure.
Jan 9 2023, 4:21 PM · Restricted Project, Restricted Project
Mogball requested review of D141332: [mlir][llvm] Don't mark CallIntrinsicOp as Pure.
Jan 9 2023, 3:52 PM · Restricted Project, Restricted Project
Mogball accepted D141038: [mlir] Avoid crash of UnsignedWhenEquivalent for no integer type..
Jan 9 2023, 12:41 PM · Restricted Project, Restricted Project
Mogball accepted D141296: [mlir][Arith] Fix bug in zero-extension range inference.
Jan 9 2023, 12:40 PM · Restricted Project, Restricted Project
Mogball accepted D141299: [mlir][Index] Add index.mins and index.minu.

thank

Jan 9 2023, 12:39 PM · Restricted Project, Restricted Project
Mogball added inline comments to D141231: [mlir][ods] Generate inferReturnTypes for ops with TypesMatchWith.
Jan 9 2023, 8:49 AM · Restricted Project, Restricted Project

Jan 8 2023

Mogball added inline comments to D141231: [mlir][ods] Generate inferReturnTypes for ops with TypesMatchWith.
Jan 8 2023, 8:12 PM · Restricted Project, Restricted Project
Mogball added a comment to D139665: [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping.

Yup

Jan 8 2023, 7:36 PM · Restricted Project, Restricted Project, Restricted Project
Mogball retitled D139665: [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping from [mlir][transforms] Add a clone utility that maps cloned operations to [mlir] Rename BlockAndValueMapping to IRMapping and add ops.
Jan 8 2023, 2:27 PM · Restricted Project, Restricted Project, Restricted Project
Mogball updated the diff for D139665: [mlir] Add operations to BlockAndValueMapping and rename it to IRMapping.

IRMapping

Jan 8 2023, 2:16 PM · Restricted Project, Restricted Project, Restricted Project
Mogball accepted D141201: [mlir] Print a newline when dumping Type.
Jan 8 2023, 1:32 PM · Restricted Project, Restricted Project
Mogball abandoned D127522: [mlir][test] Shard and reorganize the test dialect.
Jan 8 2023, 1:17 PM · Restricted Project, Restricted Project
Mogball abandoned D127521: [mlir][ods] Allow sharding of op definitions.
Jan 8 2023, 1:16 PM · Restricted Project, Restricted Project
Mogball committed rG496f9a7d8d4b: [mlir][analysis] Add an analysis for preserving symbol tables (authored by Mogball).
[mlir][analysis] Add an analysis for preserving symbol tables
Jan 8 2023, 1:16 PM · Restricted Project, Restricted Project
Mogball closed D139666: [mlir][analysis] Add an analysis for preserving symbol tables.
Jan 8 2023, 1:16 PM · Restricted Project, Restricted Project
Mogball updated the summary of D139666: [mlir][analysis] Add an analysis for preserving symbol tables.
Jan 8 2023, 1:15 PM · Restricted Project, Restricted Project
Mogball updated the diff for D139666: [mlir][analysis] Add an analysis for preserving symbol tables.

rebase

Jan 8 2023, 1:15 PM · Restricted Project, Restricted Project