Page MenuHomePhabricator

eric-k256 (Eric Kunze)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 30 2020, 9:58 AM (125 w, 2 d)

Recent Activity

Fri, Mar 24

eric-k256 added a reviewer for D145738: [TOSA] Loosen folding restrictions for tosa.add,tosa.sub, tosa.mul: rsuderman.

Adding @rsuderman, the author of the existing fold code as a more appropriate reviewer.

Fri, Mar 24, 11:17 AM · Restricted Project, Restricted Project

Wed, Mar 22

eric-k256 accepted D146617: [mlir][tosa] TosaToLinalg: Lower TOSA.Cast via RoundEven according to TOSA spec 0.60.0.

Added Rob as an additional reviewer. As mentioned, this matches with the TOSA specification, and looks like a nice simplification at the same time.

Wed, Mar 22, 3:23 PM · Restricted Project, Restricted Project

Tue, Mar 21

eric-k256 added a comment to D146380: [mlir] Add signed int to TOSA supported types.

Given Rob's comments, I think that the path forward is to get comments from a wider set of people about making the switch to signed/unsigned from signless/signed so we aren't surprising any TOSA dialect users when we get to the point of removing signless support. An RFC on discourse seems to be the right way to do that, along with some time to collect responses. All of the lit tests are going to need to change, which is going to be a big set of changes that need to land. Most of it is mechanical, but still a lot of overhead.

Tue, Mar 21, 3:16 PM · Restricted Project, Restricted Project

Mon, Mar 20

eric-k256 added a comment to D146380: [mlir] Add signed int to TOSA supported types.

As noted in the thread, I want to make sure that we're moving to remove i8 support in the near future, not supporting i8/ui8/si8. As a starting point to the move of i8 -> si8, this change is fine (mod Rob's comment), but it is starting down a path where multiple projects will be affected.

Mon, Mar 20, 1:53 PM · Restricted Project, Restricted Project

Mon, Mar 13

eric-k256 accepted D144784: [mlir][tosa] Add FFT2d operation.

Thanks for checking Rob. Yes, this looks good to me.

Mon, Mar 13, 4:05 PM · Restricted Project, Restricted Project

Thu, Mar 9

eric-k256 added a comment to D145336: [mlir][tosa] Add TOSA f64 type support for const op.

You're right that F64 isn't in any of the TOSA profiles today, which is why I was discouraging it's use in the overall definition of Tosa_Tensor. It's something we look at adding, but it adds significant requirements to any profiles it goes into. It would be good to get a sense of what networks need F64 vs ending up with that type as default. Many systems that support f64 do it at a performance cost against f32, and some systems don't implement it at all. Ideally the tooling would have a way to guide developers to minimize their use of f64 to where it has a significant improvement on results justifying the extra computation cost.

Thu, Mar 9, 3:53 PM · Restricted Project, Restricted Project

Tue, Mar 7

eric-k256 accepted D145336: [mlir][tosa] Add TOSA f64 type support for const op.

Looks reasonable to me, although I don't have merge priveleges.

Tue, Mar 7, 11:46 AM · Restricted Project, Restricted Project

Mon, Mar 6

eric-k256 added a comment to D145336: [mlir][tosa] Add TOSA f64 type support for const op.

This is definitely an improvement, I'm okay with this type, but it reads as only a 64-bit tensor. Perhaps Jacques is better at naming than I am, but I'd go something closer to Tosa_Tensor_Plus_F64, indicating that this is an extension of Tosa_Tensor with F64 (as opposed to I64).

Mon, Mar 6, 5:39 PM · Restricted Project, Restricted Project

Feb 9 2023

eric-k256 added a comment to D142599: [mlir][tosa] Add TOSA f64 type support for cast op.

I don't have commit privileges. @rsuderman or @NatashaKnk, can you take a look?

Feb 9 2023, 10:11 AM · Restricted Project, Restricted Project

Feb 7 2023

eric-k256 added a comment to D143034: [mlir][tosa] Fix segmentation fault in case of folding unranked tensor.

While waiting for the others to review, you might want to remove the extra include.

Feb 7 2023, 4:07 PM · Restricted Project, Restricted Project

Feb 2 2023

eric-k256 accepted D142599: [mlir][tosa] Add TOSA f64 type support for cast op.

Thanks. Looks good to me now.

Feb 2 2023, 10:33 PM · Restricted Project, Restricted Project
eric-k256 added a comment to D142599: [mlir][tosa] Add TOSA f64 type support for cast op.

Can you add a simple check to TosaValidation::runOnOperation that goes into the existing for loop and checks for float64 type, and does a signalPassFailure there? You don't need to check profileType, as f64 isn't in the spec. This pass is for implementations to use to check against the spec, so dialect specific changes that aren't in the spec should be flagged when it is run.

Feb 2 2023, 3:09 PM · Restricted Project, Restricted Project

Jan 26 2023

eric-k256 added a comment to D142599: [mlir][tosa] Add TOSA f64 type support for cast op.

The TOSA specification doesn't support F64, so I think we should be careful in how we expand the data types in the dialect. Adding it has implications for TOSA consumers.

Jan 26 2023, 9:50 AM · Restricted Project, Restricted Project

Dec 15 2022

eric-k256 added a comment to D139739: [mlir] [tosa] Add a pass that partitions TOSA code into kernels that consist of a conv2d or similar anchor op and adjacent elementwise ops..

Decisions on what can be fused are often very hardware specific. I do like that the partitioning is parameterized, so that if I'm understanding properly, any set of ops can be defined as anchor as well as leading/trailing ops to be captured. Is a new function the right destination for these? Have you looked at using the ml_program dialect to capture this as a region? I would imagine the overall structure wouldn't need to change significantly. It's at least an option worth considering.

Dec 15 2022, 4:27 PM · Restricted Project, Restricted Project

Nov 4 2022

eric-k256 added inline comments to D137133: [mlir][TOSA]Add optional attributes to TOSA custom op.
Nov 4 2022, 8:38 AM · Restricted Project, Restricted Project

Nov 3 2022

eric-k256 added inline comments to D137133: [mlir][TOSA]Add optional attributes to TOSA custom op.
Nov 3 2022, 2:43 PM · Restricted Project, Restricted Project

Oct 31 2022

eric-k256 requested review of D137133: [mlir][TOSA]Add optional attributes to TOSA custom op.
Oct 31 2022, 4:05 PM · Restricted Project, Restricted Project

Aug 29 2022

eric-k256 added a comment to D116394: Adopt DimensionListAttr in TOSA op definition (NFC).

This looks nice. Is there something needed before this can be merged? Presumably any user of the tosa dialect that has lit tests would also need their tests to be modified.

Aug 29 2022, 4:51 PM · Restricted Project, Restricted Project

Aug 12 2022

eric-k256 updated the diff for D128683: [MLIR][TOSA] Remove ReluN operator from TOSA dialect.

Rebased change

Aug 12 2022, 1:56 PM · Restricted Project, Restricted Project

Aug 7 2022

eric-k256 added a comment to D128683: [MLIR][TOSA] Remove ReluN operator from TOSA dialect.

Yes, help landing would be appreciated.

Aug 7 2022, 9:44 PM · Restricted Project, Restricted Project

Jul 7 2022

eric-k256 accepted D128630: [MLIR][TOSA] Fix converting tosa.clamp and tosa.relu to linalg.

It looks good to me, although I don't have commit rights, so it might not be all the approvals you need.

Jul 7 2022, 11:17 AM · Restricted Project, Restricted Project

Jun 27 2022

eric-k256 added a comment to D128683: [MLIR][TOSA] Remove ReluN operator from TOSA dialect.

I didn't find any uses of ReluN downstream, it must have been cleaned up already.

Jun 27 2022, 2:22 PM · Restricted Project, Restricted Project
eric-k256 requested review of D128683: [MLIR][TOSA] Remove ReluN operator from TOSA dialect.
Jun 27 2022, 2:15 PM · Restricted Project, Restricted Project
eric-k256 added a comment to D128630: [MLIR][TOSA] Fix converting tosa.clamp and tosa.relu to linalg.

This doesn't directly impact this change, but in the TOSA specification, we've removed the ReluN operator, since it's trivially implementable with Clamp. I will look at removing ReluN from the dialect to line up with the specification.

Jun 27 2022, 1:12 PM · Restricted Project, Restricted Project

Jun 9 2022

eric-k256 updated the diff for D127332: [mlir][tosa] Update TOSA transpose_conv2d to match spec.

Fix padding in the DecomposeTransposeConv passes to be compatible with the new attribute.
Added a testcase to try to catch future problems with padded transpose_conv.

Jun 9 2022, 11:39 AM · Restricted Project, Restricted Project

Jun 8 2022

eric-k256 updated the diff for D127332: [mlir][tosa] Update TOSA transpose_conv2d to match spec.

Fix clang-format issue (clang-format 11 vs. clang-format 10 difference)

Jun 8 2022, 4:11 PM · Restricted Project, Restricted Project
eric-k256 requested review of D127332: [mlir][tosa] Update TOSA transpose_conv2d to match spec.
Jun 8 2022, 12:01 PM · Restricted Project, Restricted Project

Nov 17 2021

eric-k256 accepted D114127: [mlir][tosa] Revert add-0 canonicalization for floating-point.

Thanks for doing this, I think it's the right solution.

Nov 17 2021, 5:04 PM · Restricted Project

Jul 22 2021

eric-k256 accepted D106610: [mlir][tosa] Disable tosa shape verification between operands/results.

Thanks for the clarification and comment.

Jul 22 2021, 6:05 PM · Restricted Project
eric-k256 added inline comments to D106610: [mlir][tosa] Disable tosa shape verification between operands/results.
Jul 22 2021, 5:05 PM · Restricted Project

Jul 16 2021

eric-k256 added a comment to D105845: [mlir][tosa] Shape inference for a few remaining easy cases:.

I don't know the ops that well, I could verify these if interested, but was going to rely on Suraj else :)

Jul 16 2021, 11:59 AM · Restricted Project