Page MenuHomePhabricator

eric-k256 (Eric Kunze)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 30 2020, 9:58 AM (86 w, 5 d)

Recent Activity

Mon, Jun 27

eric-k256 added a comment to D128683: [MLIR][TOSA] Remove ReluN operator from TOSA dialect.

I didn't find any uses of ReluN downstream, it must have been cleaned up already.

Mon, Jun 27, 2:22 PM · Restricted Project, Restricted Project
eric-k256 requested review of D128683: [MLIR][TOSA] Remove ReluN operator from TOSA dialect.
Mon, Jun 27, 2:15 PM · Restricted Project, Restricted Project
eric-k256 added a comment to D128630: [MLIR][TOSA] Fix converting tosa.clamp and tosa.relu to linalg.

This doesn't directly impact this change, but in the TOSA specification, we've removed the ReluN operator, since it's trivially implementable with Clamp. I will look at removing ReluN from the dialect to line up with the specification.

Mon, Jun 27, 1:12 PM · Restricted Project, Restricted Project

Thu, Jun 9

eric-k256 updated the diff for D127332: [mlir][tosa] Update TOSA transpose_conv2d to match spec.

Fix padding in the DecomposeTransposeConv passes to be compatible with the new attribute.
Added a testcase to try to catch future problems with padded transpose_conv.

Thu, Jun 9, 11:39 AM · Restricted Project, Restricted Project

Wed, Jun 8

eric-k256 updated the diff for D127332: [mlir][tosa] Update TOSA transpose_conv2d to match spec.

Fix clang-format issue (clang-format 11 vs. clang-format 10 difference)

Wed, Jun 8, 4:11 PM · Restricted Project, Restricted Project
eric-k256 requested review of D127332: [mlir][tosa] Update TOSA transpose_conv2d to match spec.
Wed, Jun 8, 12:01 PM · Restricted Project, Restricted Project

Nov 17 2021

eric-k256 accepted D114127: [mlir][tosa] Revert add-0 canonicalization for floating-point.

Thanks for doing this, I think it's the right solution.

Nov 17 2021, 5:04 PM · Restricted Project

Jul 22 2021

eric-k256 accepted D106610: [mlir][tosa] Disable tosa shape verification between operands/results.

Thanks for the clarification and comment.

Jul 22 2021, 6:05 PM · Restricted Project
eric-k256 added inline comments to D106610: [mlir][tosa] Disable tosa shape verification between operands/results.
Jul 22 2021, 5:05 PM · Restricted Project

Jul 16 2021

eric-k256 added a comment to D105845: [mlir][tosa] Shape inference for a few remaining easy cases:.

I don't know the ops that well, I could verify these if interested, but was going to rely on Suraj else :)

Jul 16 2021, 11:59 AM · Restricted Project