This is an archive of the discontinued LLVM Phabricator instance.

Differential D148897

Adopt Properties to store operations inherent Attributes in the OpenMP dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 12:05 AM.

Details

Reviewers
rriddle
jpienaar
kiranchandramohan
jdoerfert
nicolasvasilache
Commits
rG643f3775e54e: Adopt Properties to store operations inherent Attributes in the OpenMP dialect
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 12:05 AM
Herald added a reviewer: kiranchandramohan. · View Herald TranscriptApr 21 2023, 12:05 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, sunshaoce, Moerafaat and 23 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 12:05 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptApr 21 2023, 12:05 AM
Herald added a reviewer: nicolasvasilache. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: jplehr, sstefan1, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B227100: Diff 515625.Apr 21 2023, 12:38 AM
mehdi_amini added a parent revision: D148896: Adopt Properties to store operations inherent Attributes in the OpenACC dialect.Apr 21 2023, 9:07 AM
mehdi_amini added a child revision: D148898: Adopt Properties to store operations inherent Attributes in the PDL dialect.
mehdi_amini updated this revision to Diff 515788.Apr 21 2023, 9:31 AM

Rebase

mehdi_amini updated this revision to Diff 516008.Apr 21 2023, 8:22 PM

Rebase

Harbormaster completed remote builds in B227403: Diff 516008.Apr 21 2023, 10:04 PM
kiranchandramohan accepted this revision.Apr 22 2023, 2:46 PM

LGTM.

This revision is now accepted and ready to land.Apr 22 2023, 2:46 PM
mehdi_amini updated this revision to Diff 516262.Apr 23 2023, 10:32 PM

Rebase after improving diagnostic on invalid IR

Harbormaster completed remote builds in B227617: Diff 516262.Apr 23 2023, 11:51 PM
mehdi_amini updated this revision to Diff 516672.Apr 25 2023, 12:20 AM

Rebase

Harbormaster completed remote builds in B227926: Diff 516672.Apr 25 2023, 2:17 AM
This revision was landed with ongoing or failed builds.May 10 2023, 6:54 AM
Closed by commit rG643f3775e54e: Adopt Properties to store operations inherent Attributes in the OpenMP dialect (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG643f3775e54e: Adopt Properties to store operations inherent Attributes in the OpenMP dialect.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
OpenMP/
1 line

Diff 520978

mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td

Show All 22 Lines
include "mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td" include "mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td"
include "mlir/Dialect/OpenMP/OpenMPTypeInterfaces.td" include "mlir/Dialect/OpenMP/OpenMPTypeInterfaces.td"
def OpenMP_Dialect : Dialect { def OpenMP_Dialect : Dialect {
let name = "omp"; let name = "omp";
let cppNamespace = "::mlir::omp"; let cppNamespace = "::mlir::omp";
let dependentDialects = ["::mlir::LLVM::LLVMDialect"]; let dependentDialects = ["::mlir::LLVM::LLVMDialect"];
let useDefaultAttributePrinterParser = 1; let useDefaultAttributePrinterParser = 1;
let usePropertiesForAttributes = 1;
} }
// OmpCommon requires definition of OpenACC_Dialect. // OmpCommon requires definition of OpenACC_Dialect.
include "mlir/Dialect/OpenMP/OmpCommon.td" include "mlir/Dialect/OpenMP/OmpCommon.td"
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// OpenMP Attributes // OpenMP Attributes
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
▲ Show 20 Lines • Show All 1,609 Lines • Show Last 20 Lines