This is an archive of the discontinued LLVM Phabricator instance.

Differential D148892

Adopt Properties to store operations inherent Attributes in the Math dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 12:04 AM.

Details

Reviewers
rriddle
jpienaar
nicolasvasilache
Commits
rG2fe23ffdd38a: Adopt Properties to store operations inherent Attributes in the Math dialect
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 12:04 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 21 2023, 12:04 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 12:04 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 12:04 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B227095: Diff 515620.Apr 21 2023, 12:34 AM
mehdi_amini added a child revision: D148893: Adopt Properties to store operations inherent Attributes in the Memref dialect.Apr 21 2023, 9:03 AM
mehdi_amini added a parent revision: D148891: Adopt Properties to store operations inherent Attributes in the IRDL dialect.
mehdi_amini updated this revision to Diff 515783.Apr 21 2023, 9:30 AM

Rebase

Harbormaster completed remote builds in B227220: Diff 515783.Apr 21 2023, 11:02 AM
mehdi_amini updated this revision to Diff 516003.Apr 21 2023, 8:22 PM

Rebase

Harbormaster completed remote builds in B227398: Diff 516003.Apr 21 2023, 9:46 PM
mehdi_amini updated this revision to Diff 516257.Apr 23 2023, 10:32 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 11:10 PM
This revision is now accepted and ready to land.Apr 23 2023, 11:10 PM
Harbormaster completed remote builds in B227612: Diff 516257.Apr 23 2023, 11:29 PM
mehdi_amini updated this revision to Diff 516667.Apr 25 2023, 12:20 AM

Rebase

Harbormaster completed remote builds in B227921: Diff 516667.Apr 25 2023, 2:05 AM
This revision was landed with ongoing or failed builds.May 9 2023, 5:31 PM
Closed by commit rG2fe23ffdd38a: Adopt Properties to store operations inherent Attributes in the Math dialect (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG2fe23ffdd38a: Adopt Properties to store operations inherent Attributes in the Math dialect.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
Math/
IR/
1 line

Diff 520867

mlir/include/mlir/Dialect/Math/IR/MathBase.td

Show All 24 Lines let description = [{
// Vector elementwise absolute value. // Vector elementwise absolute value.
%f = math.absf %g : vector<4xf32> %f = math.absf %g : vector<4xf32>
// Tensor elementwise absolute value. // Tensor elementwise absolute value.
%x = math.absf %y : tensor<4x?xf8> %x = math.absf %y : tensor<4x?xf8>
``` ```
}]; }];
let hasConstantMaterializer = 1; let hasConstantMaterializer = 1;
let usePropertiesForAttributes = 1;
let dependentDialects = [ let dependentDialects = [
"::mlir::arith::ArithDialect" "::mlir::arith::ArithDialect"
]; ];
} }
#endif // MATH_BASE #endif // MATH_BASE