This is an archive of the discontinued LLVM Phabricator instance.

Differential D148884

Adopt Properties to store operations inherent Attributes in the Bufferization dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 12:03 AM.

Details

Reviewers
rriddle
jpienaar
springerm
nicolasvasilache
Commits
rG47a91a3d6b6a: Adopt Properties to store operations inherent Attributes in the Bufferization…
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 12:03 AM
Herald added a reviewer: springerm. · View Herald TranscriptApr 21 2023, 12:03 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 12:03 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 12:04 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
springerm accepted this revision.Apr 21 2023, 12:10 AM
This revision is now accepted and ready to land.Apr 21 2023, 12:10 AM
Harbormaster completed remote builds in B227087: Diff 515612.Apr 21 2023, 12:35 AM
mehdi_amini added a child revision: D148885: Adopt Properties to store operations inherent Attributes in the Complex dialect.Apr 21 2023, 9:05 AM
mehdi_amini added a parent revision: D148883: Adopt Properties to store operations inherent Attributes in the Async dialect.
mehdi_amini updated this revision to Diff 515775.Apr 21 2023, 9:29 AM

Rebase

Harbormaster completed remote builds in B227212: Diff 515775.Apr 21 2023, 10:48 AM
mehdi_amini updated this revision to Diff 515995.Apr 21 2023, 8:21 PM

Rebase

Harbormaster completed remote builds in B227390: Diff 515995.Apr 21 2023, 9:36 PM
mehdi_amini updated this revision to Diff 516249.Apr 23 2023, 10:32 PM

Rebase after improving diagnostic on invalid IR

Harbormaster completed remote builds in B227604: Diff 516249.Apr 23 2023, 11:23 PM
mehdi_amini updated this revision to Diff 516659.Apr 25 2023, 12:19 AM

Rebase

Harbormaster completed remote builds in B227913: Diff 516659.Apr 25 2023, 1:53 AM
This revision was landed with ongoing or failed builds.May 9 2023, 6:59 AM
Closed by commit rG47a91a3d6b6a: Adopt Properties to store operations inherent Attributes in the Bufferization… (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG47a91a3d6b6a: Adopt Properties to store operations inherent Attributes in the Bufferization….

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
Bufferization/
IR/
1 line

Diff 520683

mlir/include/mlir/Dialect/Bufferization/IR/BufferizationBase.td

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines let extraClassDeclaration = [{
/// BufferDeallocation pass. /// BufferDeallocation pass.
/// ///
/// Note: Only ops with at least one OpResult that bufferizes to a buffer /// Note: Only ops with at least one OpResult that bufferizes to a buffer
/// allocation (as per BufferizableOpInterface) may have this attribute. /// allocation (as per BufferizableOpInterface) may have this attribute.
constexpr const static ::llvm::StringLiteral constexpr const static ::llvm::StringLiteral
kEscapeAttrName = "bufferization.escape"; kEscapeAttrName = "bufferization.escape";
}]; }];
let hasOperationAttrVerify = 1; let hasOperationAttrVerify = 1;
let usePropertiesForAttributes = 1;
} }
#endif // BUFFERIZATION_BASE #endif // BUFFERIZATION_BASE