Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Adopt Properties to store operations inherent Attributes in the Linalg dialect

Authored by mehdi_amini on Apr 13 2023, 9:59 PM.



This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 13 2023, 9:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 9:59 PM
mehdi_amini requested review of this revision.Apr 13 2023, 9:59 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 10:56 PM
This revision is now accepted and ready to land.Apr 23 2023, 10:56 PM
ftynse added a subscriber: ftynse.Apr 24 2023, 12:40 AM
ftynse added inline comments.

Does this test need an update instead?

Add better support for diagnostics in the linalg generic parser

mehdi_amini added inline comments.Apr 24 2023, 11:38 PM

This was more tricky, I had to fix a few things in the parser. But there will be more work needed actually: we have to really separate the inherent attributes from the dictionary of discardable attributes. Right now I left as much as possible backward compatible, please have another look at the changes in mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

This revision was landed with ongoing or failed builds.May 5 2023, 4:58 PM
This revision was automatically updated to reflect the committed changes.