Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Paths

Table of Contentst

Differential D148299

Adopt Properties to store operations inherent Attributes in the Linalg dialect
ClosedPublic
Actions

Authored by mehdi_amini on Apr 13 2023, 9:59 PM.

Tags

Subscribers

View All 31 Subscribers

Details

Reviewers

rriddle
Mogball
jpienaar
nicolasvasilache

Commits

rGf6ac7e3c6d5b: Adopt Properties to store operations inherent Attributes in the Linalg dialect

Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mehdi_amini created this revision.Apr 13 2023, 9:59 PM

Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 9:59 PM

Herald added subscribers: bviyer, hanchung, Moerafaat and 24 others. · View Herald Transcript

mehdi_amini requested review of this revision.Apr 13 2023, 9:59 PM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 13 2023, 9:59 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript

mehdi_amini added a parent revision: D148298: Adopt Properties to store operations inherent Attributes in the Arith dialect.Apr 13 2023, 10:01 PM

mehdi_amini added a child revision: D148300: Adopt Properties to store operations inherent Attributes in the LLVM dialect.

Harbormaster completed remote builds in B225497: Diff 513431.Apr 13 2023, 10:09 PM

rebase

Harbormaster completed remote builds in B227067: Diff 515589.Apr 20 2023, 10:30 PM

Rebase

Harbormaster completed remote builds in B227074: Diff 515597.Apr 20 2023, 11:08 PM

Rebase

Harbormaster completed remote builds in B227204: Diff 515767.Apr 21 2023, 10:29 AM

Rebase

Harbormaster completed remote builds in B227382: Diff 515987.Apr 21 2023, 9:29 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 10:56 PM

This revision is now accepted and ready to land.Apr 23 2023, 10:56 PM

Harbormaster completed remote builds in B227596: Diff 516241.Apr 23 2023, 11:14 PM

ftynse added a subscriber: ftynse.Apr 24 2023, 12:40 AM

ftynse added inline comments.

mlir/test/Dialect/Linalg/named-ops.mlir
166–175	Does this test need an update instead?

Add better support for diagnostics in the linalg generic parser

mehdi_amini added inline comments.Apr 24 2023, 11:38 PM

mlir/test/Dialect/Linalg/named-ops.mlir
166–175	This was more tricky, I had to fix a few things in the parser. But there will be more work needed actually: we have to really separate the inherent attributes from the dictionary of discardable attributes. Right now I left as much as possible backward compatible, please have another look at the changes in `mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp`

Harbormaster completed remote builds in B227893: Diff 516635.Apr 25 2023, 12:01 AM

Rebase

Harbormaster completed remote builds in B227903: Diff 516650.Apr 25 2023, 1:28 AM

This revision was landed with ongoing or failed builds.May 5 2023, 4:58 PM

Closed by commit rGf6ac7e3c6d5b: Adopt Properties to store operations inherent Attributes in the Linalg dialect (authored by mehdi_amini). · Explain Why

This revision was automatically updated to reflect the committed changes.

mehdi_amini added a commit: rGf6ac7e3c6d5b: Adopt Properties to store operations inherent Attributes in the Linalg dialect.

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

Linalg/

IR/

1 line

lib/

Dialect/

Linalg/

IR/

42 lines

test/

Dialect/

Linalg/

10 lines

Diff 520006

mlir/include/mlir/Dialect/Linalg/IR/LinalgBase.td

Loading...

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp

Loading...

mlir/test/Dialect/Linalg/named-ops.mlir

Loading...