This will make them consistent with other overflow-aware nodes.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Can you put the new names in the description? That way once it's commited the new names will be in the commit message.
ADDCARRY/SUBCARRY have been the only overflow-aware nodes for a long time.
UADDO and USUBO are much older than ADDCARRY/SUBCARRY.
llvm/include/llvm/CodeGen/ISDOpcodes.h | ||
---|---|---|
301 | I think too many things got renamed here. The comparison to [US]{ADD,SUB}O matches the rest of the description. |
Thanks, I'll update the description. Do you maybe know the true reason for the discrepancy?
llvm/include/llvm/CodeGen/ISDOpcodes.h | ||
---|---|---|
301 | The comparison with [US]{ADD,SUB}O is inaccurate. I'll revert this part so that this patch does not change the semantics of the comments. |
llvm/lib/Target/SystemZ/SystemZISelLowering.cpp | ||
---|---|---|
4003 | Might make sense, but I'm not sure if the names of these two functions are derived from node names. |
SGTM, do you want to get the input from the target specialists that you update the most (ARM/AMDGPU)?
llvm/lib/Target/SystemZ/SystemZISelLowering.cpp | ||
---|---|---|
4003 | Only a minor suggestion - it shouldn't derail this patch. |
I think too many things got renamed here. The comparison to [US]{ADD,SUB}O matches the rest of the description.