This is an archive of the discontinued LLVM Phabricator instance.

[llvm][AArch64ISelDAGToDAG] support -{start|stop}-{before|after}=aarch64-isel

Authored by nickdesaulniers on Dec 19 2022, 11:43 AM.



Follow a similar pattern as AMDGPUDAGToDAGISel's constructor so that we
can use INITIALIZE_PASS to register a pass. This allows for more fine
grain testability of SelectionDAGISel via:

llc -stop-{before,after}=aarch64-isel


See also:

Diff Detail

Event Timeline

nickdesaulniers requested review of this revision.Dec 19 2022, 11:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2022, 11:43 AM

I think I might just squash this into

I think I might just squash this into

actually, if I rebase this onto, I can drop some of the diffs I just immediately undo there.

  • minor fixup from rebase
  • drop unnecessary getPassName override; no longer necessary
Matt added a subscriber: Matt.Dec 19 2022, 5:09 PM
MaskRay accepted this revision.Dec 20 2022, 3:46 PM
MaskRay added a subscriber: MaskRay.


This allows for more fine grain testability of SelectionDAGISel.

Just be concrete and mention that this makes llc -stop-{before,after}=aarch64-isel work?


Push the shuffling in a separate commit.

This revision is now accepted and ready to land.Dec 20 2022, 3:46 PM
nickdesaulniers marked an inline comment as done.
nickdesaulniers edited the summary of this revision. (Show Details)
  • rebase on pre-committed method declaration sort
This revision was landed with ongoing or failed builds.Dec 21 2022, 1:06 PM
This revision was automatically updated to reflect the committed changes.