Page MenuHomePhabricator

samtebbs (Sam Tebbs)
User

Projects

User does not belong to any projects.

User Details

User Since
May 31 2019, 2:34 AM (15 w, 4 d)

Recent Activity

Fri, Sep 13

samtebbs added a comment to D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags.

+1 :)

Fri, Sep 13, 2:50 AM · Restricted Project
samtebbs committed rG1572b6850957: [ARM] Add support for MVE vmaxv and vminv (authored by samtebbs).
[ARM] Add support for MVE vmaxv and vminv
Fri, Sep 13, 2:13 AM
samtebbs committed rL371827: [ARM] Add support for MVE vmaxv and vminv.
[ARM] Add support for MVE vmaxv and vminv
Fri, Sep 13, 2:13 AM
samtebbs closed D66413: [ARM} Add support for MVE vmaxv and vminv.
Fri, Sep 13, 2:13 AM · Restricted Project

Thu, Sep 12

samtebbs added a comment to D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags.

At this point I am not sure if we should "pollute" the generic MC description with this property, mainly because the ARM backend will be the only user, and it looks like this could be simple target hook switching over the opcodes, like already done in the added unittest. Not pretty, but very simple and effective....
At the same time, there is enough prior art here, adding all sorts of things, so I am in two minds. But I think I would more lean towards a target hook, because it's not very generic/widely used.

Thu, Sep 12, 8:56 AM · Restricted Project
samtebbs updated the diff for D66413: [ARM} Add support for MVE vmaxv and vminv.

Added vminv support

Thu, Sep 12, 2:48 AM · Restricted Project

Wed, Sep 11

samtebbs created D67444: [ARM][MVE] Add invalidForTailPredication to TSFlags.
Wed, Sep 11, 6:36 AM · Restricted Project

Mon, Sep 9

samtebbs updated the diff for D66413: [ARM} Add support for MVE vmaxv and vminv.
Mon, Sep 9, 6:15 AM · Restricted Project
samtebbs updated the diff for D66413: [ARM} Add support for MVE vmaxv and vminv.
Mon, Sep 9, 5:57 AM · Restricted Project
samtebbs added inline comments to D66413: [ARM} Add support for MVE vmaxv and vminv.
Mon, Sep 9, 3:53 AM · Restricted Project
samtebbs added inline comments to D66413: [ARM} Add support for MVE vmaxv and vminv.
Mon, Sep 9, 3:11 AM · Restricted Project

Fri, Sep 6

samtebbs committed rGf1cdd95a2fe7: [ARM] Sink add/mul(shufflevector(insertelement())) for MVE instruction selection (authored by samtebbs).
[ARM] Sink add/mul(shufflevector(insertelement())) for MVE instruction selection
Fri, Sep 6, 9:04 AM
samtebbs committed rL371218: [ARM] Sink add/mul(shufflevector(insertelement())) for MVE instruction selection.
[ARM] Sink add/mul(shufflevector(insertelement())) for MVE instruction selection
Fri, Sep 6, 9:01 AM
samtebbs closed D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Fri, Sep 6, 9:00 AM · Restricted Project
samtebbs added a comment to D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.

Very nice. Oliver went and put together a few patches for mul, add and sub, in https://reviews.llvm.org/D67268 and related. So we now (or soon will) produce the other instruction this can effect. This is good to go I think.

Fri, Sep 6, 8:20 AM · Restricted Project

Thu, Sep 5

samtebbs committed rL371029: Request commit access for samtebbs.
Request commit access for samtebbs
Thu, Sep 5, 1:53 AM

Wed, Sep 4

samtebbs added inline comments to D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Wed, Sep 4, 7:17 AM · Restricted Project
samtebbs updated the diff for D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Wed, Sep 4, 5:59 AM · Restricted Project

Tue, Sep 3

samtebbs updated the diff for D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Tue, Sep 3, 2:06 AM · Restricted Project
samtebbs committed rG8b2df85d023e: [ARM] Select vmla (authored by samtebbs).
[ARM] Select vmla
Tue, Sep 3, 1:19 AM
samtebbs committed rL370704: [ARM] Select vmla.
[ARM] Select vmla
Tue, Sep 3, 1:19 AM
samtebbs closed D66297: [ARM] Select vmla.
Tue, Sep 3, 1:19 AM · Restricted Project

Mon, Sep 2

samtebbs updated the diff for D66413: [ARM} Add support for MVE vmaxv and vminv.
Mon, Sep 2, 6:14 AM · Restricted Project
samtebbs updated the diff for D66297: [ARM] Select vmla.
Mon, Sep 2, 5:55 AM · Restricted Project
samtebbs updated the diff for D66297: [ARM] Select vmla.
Mon, Sep 2, 2:16 AM · Restricted Project

Thu, Aug 29

samtebbs updated the diff for D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Thu, Aug 29, 3:34 AM · Restricted Project
samtebbs updated the diff for D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Thu, Aug 29, 3:29 AM · Restricted Project
samtebbs added inline comments to D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Thu, Aug 29, 2:31 AM · Restricted Project

Wed, Aug 28

samtebbs updated the diff for D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Wed, Aug 28, 9:15 AM · Restricted Project

Fri, Aug 23

samtebbs updated the diff for D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Fri, Aug 23, 7:04 AM · Restricted Project

Thu, Aug 22

samtebbs added a comment to D66519: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32.

Reapplied as https://reviews.llvm.org/rGa69d9d61569b3c882b0b0a2c92dbf125ef64403e

Thu, Aug 22, 5:20 AM · Restricted Project
samtebbs committed rGa69d9d61569b: Reapply: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32 (authored by samtebbs).
Reapply: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32
Thu, Aug 22, 3:32 AM
samtebbs added a reverting change for rGcd53ff6c0df5: Revert r369626 "[ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32": rGa69d9d61569b: Reapply: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32.
Thu, Aug 22, 3:32 AM
samtebbs committed rL369638: Reapply: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32.
Reapply: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32
Thu, Aug 22, 3:32 AM
samtebbs committed rG7c6b229204c0: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32 (authored by samtebbs).
[ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32
Thu, Aug 22, 1:13 AM
samtebbs committed rL369626: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32.
[ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32
Thu, Aug 22, 1:12 AM
samtebbs closed D66519: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32.
Thu, Aug 22, 1:12 AM · Restricted Project

Wed, Aug 21

samtebbs updated the diff for D66519: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32.
Wed, Aug 21, 7:31 AM · Restricted Project
samtebbs added inline comments to D66413: [ARM} Add support for MVE vmaxv and vminv.
Wed, Aug 21, 7:23 AM · Restricted Project
samtebbs created D66519: [ARM] Fix lsrl with a 128/256 bit shift amount or a shift of 32.
Wed, Aug 21, 2:57 AM · Restricted Project

Tue, Aug 20

samtebbs committed rGdcfc2d40d30f: [ARM] Select vaddva (authored by samtebbs).
[ARM] Select vaddva
Tue, Aug 20, 9:35 AM
samtebbs committed rL369404: [ARM] Select vaddva.
[ARM] Select vaddva
Tue, Aug 20, 9:33 AM
samtebbs closed D66410: [ARM] Select vaddva.
Tue, Aug 20, 9:33 AM · Restricted Project
samtebbs added inline comments to D66410: [ARM] Select vaddva.
Tue, Aug 20, 7:47 AM · Restricted Project
samtebbs updated the diff for D66410: [ARM] Select vaddva.
Tue, Aug 20, 7:02 AM · Restricted Project

Mon, Aug 19

samtebbs created D66413: [ARM} Add support for MVE vmaxv and vminv.
Mon, Aug 19, 5:30 AM · Restricted Project
samtebbs created D66410: [ARM] Select vaddva.
Mon, Aug 19, 3:39 AM · Restricted Project
samtebbs committed rGf312c1ecf4bc: [ARM] Add support for MVE vaddv (authored by samtebbs).
[ARM] Add support for MVE vaddv
Mon, Aug 19, 2:39 AM
samtebbs committed rL369245: [ARM] Add support for MVE vaddv.
[ARM] Add support for MVE vaddv
Mon, Aug 19, 2:39 AM
samtebbs closed D66085: [ARM] Add support for MVE vaddv.
Mon, Aug 19, 2:39 AM · Restricted Project

Aug 16 2019

samtebbs updated the diff for D66085: [ARM] Add support for MVE vaddv.
Aug 16 2019, 8:50 AM · Restricted Project
samtebbs added inline comments to D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Aug 16 2019, 7:25 AM · Restricted Project
samtebbs updated the diff for D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Aug 16 2019, 7:24 AM · Restricted Project

Aug 15 2019

samtebbs added a parent revision for D66297: [ARM] Select vmla: D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Aug 15 2019, 8:18 AM · Restricted Project
samtebbs created D66297: [ARM] Select vmla.
Aug 15 2019, 8:18 AM · Restricted Project
samtebbs added a child revision for D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection: D66297: [ARM] Select vmla.
Aug 15 2019, 8:18 AM · Restricted Project
samtebbs created D66295: [ARM] Sink add/mul(shufflevector(insertelement(...), ...), ...) for MVE instruction selection.
Aug 15 2019, 8:15 AM · Restricted Project

Aug 14 2019

samtebbs added a comment to D66085: [ARM] Add support for MVE vaddv.

Context please!

Aug 14 2019, 6:17 AM · Restricted Project
samtebbs updated the diff for D66085: [ARM] Add support for MVE vaddv.
Aug 14 2019, 6:13 AM · Restricted Project

Aug 12 2019

samtebbs updated the diff for D66085: [ARM] Add support for MVE vaddv.
Aug 12 2019, 5:57 AM · Restricted Project
samtebbs created D66085: [ARM] Add support for MVE vaddv.
Aug 12 2019, 5:47 AM · Restricted Project

Aug 8 2019

samtebbs closed D65808: [ARM] Select VFMA.

Committed as https://reviews.llvm.org/rG7ca980edcd76a83320306bafe07978e5db1bed3b

Aug 8 2019, 1:28 AM · Restricted Project
samtebbs committed rG7ca980edcd76: [ARM] Select VFMA (authored by samtebbs).
[ARM] Select VFMA
Aug 8 2019, 1:23 AM
samtebbs committed rL368264: [ARM] Select VFMA.
[ARM] Select VFMA
Aug 8 2019, 1:20 AM

Aug 7 2019

samtebbs updated the diff for D65808: [ARM] Select VFMA.
Aug 7 2019, 6:53 AM · Restricted Project

Aug 6 2019

samtebbs created D65808: [ARM] Select VFMA.
Aug 6 2019, 8:03 AM · Restricted Project

Jun 28 2019

samtebbs committed rGe39e958da36d: [ARM] Add support for the MVE long shift instructions (authored by samtebbs).
[ARM] Add support for the MVE long shift instructions
Jun 28 2019, 8:45 AM
samtebbs committed rL364654: [ARM] Add support for the MVE long shift instructions.
[ARM] Add support for the MVE long shift instructions
Jun 28 2019, 8:45 AM
samtebbs closed D63430: [ARM] Add support for the MVE long shift instructions.
Jun 28 2019, 8:45 AM · Restricted Project

Jun 27 2019

samtebbs committed rG8747c5f48288: [ARM] Fix formatting issue in ARMISelLowering.cpp (authored by samtebbs).
[ARM] Fix formatting issue in ARMISelLowering.cpp
Jun 27 2019, 9:30 AM
samtebbs committed rL364560: [ARM] Fix formatting issue in ARMISelLowering.cpp.
[ARM] Fix formatting issue in ARMISelLowering.cpp
Jun 27 2019, 9:29 AM

Jun 20 2019

samtebbs updated the diff for D63430: [ARM] Add support for the MVE long shift instructions.
Jun 20 2019, 7:07 AM · Restricted Project
samtebbs updated the diff for D63430: [ARM] Add support for the MVE long shift instructions.
Jun 20 2019, 6:58 AM · Restricted Project
samtebbs added inline comments to D63430: [ARM] Add support for the MVE long shift instructions.
Jun 20 2019, 2:06 AM · Restricted Project

Jun 18 2019

samtebbs updated the diff for D63430: [ARM] Add support for the MVE long shift instructions.
Jun 18 2019, 3:35 AM · Restricted Project

Jun 17 2019

samtebbs created D63430: [ARM] Add support for the MVE long shift instructions.
Jun 17 2019, 7:35 AM · Restricted Project