User Details
- User Since
- May 31 2019, 2:34 AM (198 w, 6 d)
Fri, Mar 3
Feb 14 2023
LGTM
Feb 6 2023
Looks great, thank you.
Feb 3 2023
Great change, thank you.
Jan 31 2023
Hi @lebedev.ri , after some more investigation it looks like the regressions are due to this patch breaking canonical loop form and therefore preventing optimisations later on in the pipeline. I don't think that the additional comparisons and selects that come from this transformation are ideal in all cases, either. I've attached a reproducer.
Jan 17 2023
After investigating it looks like the regressions are due to something downstream so I don't want to block this relanding based on that. Thank you for waiting.
Jan 16 2023
Thanks for this, it's looking great, with one small suggestion.
Jan 12 2023
LGTM
Jan 11 2023
Jan 9 2023
Jan 6 2023
Looking good
LGTM with one suggestion.
Jan 5 2023
We've also seen lots of large regressions for a variety of ARM CPUs with the original patch and that weren't fixed by any updates. At the moment it's not clear if downstream changes are to blame so I'll sort out a reproducer as soon as I can.
Dec 20 2022
Cool, that sounds good to me. Nice change and LGTM!
Dec 19 2022
Nice one, LGTM.
LGTM
Dec 7 2022
Nice, LGTM
Nov 17 2022
From my reading an anyext can't guarantee what is put in those extended bits so changing the anyext to a zext seems semantically acceptable to me. If it isn't correct then we'll get some bug reports and it can be fixed!
Nov 10 2022
LGTM
Nov 8 2022
Nice one, LGTM.
Nov 3 2022
Oct 31 2022
LGTM
Oct 10 2022
Thanks
Oct 3 2022
LGTM
Sep 20 2022
Nice change
Looks pretty good to me, but maybe give the other reviewers some time for another look.
LGTM
From the tests it's not immediately clear what is improved. Have you run any benchmarks to see what improves?
Sep 13 2022
Looks pretty good to me. Nice
Aug 5 2022
Aug 2 2022
LGTM
Jul 19 2022
LGTM
Jul 18 2022
Jul 7 2022
LGTM
Good job on catching this oversight. LGTM with a question about a test change.
Jul 4 2022
LGTM now, cheers.
Jul 1 2022
Jun 28 2022
Jun 23 2022
LGTM
Jun 17 2022
Nice one.
Jun 16 2022
Looks good to me. I assume that the test case can't be reduced while retaining the behaviour.
Jun 6 2022
LGTM
lgtm
Jun 1 2022
LGTM! Thanks
May 26 2022
LGTM
May 25 2022
May 19 2022
LGTM
May 6 2022
Looks sensible to me, thanks
May 3 2022
Out of interest, do you have any benchmark results to show how these new costs improves things?
LGTM
Apr 28 2022
Apr 27 2022
LGTM
Apr 26 2022
Looks pretty sensible to me, thanks.
LGTM
Apr 20 2022
LGTM!
Apr 13 2022
Mar 29 2022
Nice one. Looks good to me.
Mar 23 2022
Nice
Mar 10 2022
Sorry for letting this slip through the cracks for so long, looks good to me.
Nice one. LGTM if david has no other comments
Mar 9 2022
LGTM
Jan 27 2022
Ah I see, makes sense. LGTM
LGTM
Dec 14 2021
I'm wondering if this verification could be done for us automatically, because the tablegen operands presumably already check what the immediate is before it's allowed to become a t2_addrmode_i7 etc. If that isn't possible then this LGTM.
Perfect, LGTM
Nice one
Dec 9 2021
LGTM
Is this the kind of constraint that can be baked into the operand type in the instruction's (ins ...) in tablegen?
Nov 26 2021
👍
Nice
Great, LGTM
LGTM
Nov 25 2021
LGTM
LGTM with a couple of changes
Nov 24 2021
Nice
LGTM
Nov 15 2021
Very nice
LGTM with one request
Nov 10 2021
LGTM!