Page MenuHomePhabricator
People samtebbs

samtebbs (Sam Tebbs)
User

Projects

User does not belong to any projects.

User Details

User Since
May 31 2019, 2:34 AM (160 w, 2 d)

Recent Activity
View All

Thu, Jun 23

samtebbs accepted D128426: [AArch64] Convert vector add(ext, ext) into ext(add(ext, ext)).

LGTM

Thu, Jun 23, 8:10 AM · Restricted Project, Restricted Project

Fri, Jun 17

samtebbs accepted D127733: [ARM] Fix MVE gather/scatter merged gep offsets.

Nice one.

Fri, Jun 17, 1:54 AM · Restricted Project, Restricted Project

Thu, Jun 16

samtebbs accepted D127971: [MachinePipeliner] Handle failing constrainRegClass.
Thu, Jun 16, 7:56 AM · Restricted Project, Restricted Project
samtebbs added a comment to D127971: [MachinePipeliner] Handle failing constrainRegClass.

Looks good to me. I assume that the test case can't be reduced while retaining the behaviour.

Thu, Jun 16, 7:56 AM · Restricted Project, Restricted Project

Mon, Jun 6

samtebbs accepted D126782: [AArch64] Look through bitcast when looking for extract_high subvector .

LGTM

Mon, Jun 6, 4:00 AM · Restricted Project, Restricted Project
samtebbs accepted D127087: [AArch64] Generate FADDP from shuffled fadd.

lgtm

Mon, Jun 6, 3:48 AM · Restricted Project, Restricted Project

Wed, Jun 1

samtebbs accepted D126686: [AArch64] Generate ADDP from shuffled add.

LGTM! Thanks

Wed, Jun 1, 6:13 AM · Restricted Project, Restricted Project

May 26 2022

samtebbs accepted D126449: [AArch64] Reuse larger DUP if available.

LGTM

May 26 2022, 2:35 AM · Restricted Project, Restricted Project
samtebbs added inline comments to D126449: [AArch64] Reuse larger DUP if available.
May 26 2022, 1:41 AM · Restricted Project, Restricted Project

May 25 2022

samtebbs abandoned D109001: [AArch64] Fold an sqadd of a sqdmull at lane 0 into an sqdmlal.
May 25 2022, 7:56 AM · Restricted Project, Restricted Project

May 19 2022

samtebbs accepted D125865: [AArch64] Fix zero element TBL indices.

LGTM

May 19 2022, 3:57 AM · Restricted Project, Restricted Project

May 6 2022

samtebbs accepted D125086: [VectorCombine] Attempt to fold select shuffles from reductions.

Looks sensible to me, thanks

May 6 2022, 7:53 AM · Restricted Project, Restricted Project

May 3 2022

samtebbs accepted D124786: [AArch64] Add extra reverse costs..

Out of interest, do you have any benchmark results to show how these new costs improves things?

May 3 2022, 8:15 AM · Restricted Project, Restricted Project
samtebbs accepted D123911: [VectorCombine] Fold shuffle select pattern.

LGTM

May 3 2022, 8:13 AM · Restricted Project, Restricted Project

Apr 28 2022

samtebbs added inline comments to D123911: [VectorCombine] Fold shuffle select pattern.
Apr 28 2022, 2:33 AM · Restricted Project, Restricted Project

Apr 27 2022

samtebbs accepted D123494: [VectorCombine] Find and remove shuffles from commutative reductions.
Apr 27 2022, 8:25 AM · Restricted Project, Restricted Project
samtebbs added a comment to D123494: [VectorCombine] Find and remove shuffles from commutative reductions.

LGTM

Apr 27 2022, 8:25 AM · Restricted Project, Restricted Project

Apr 26 2022

samtebbs added inline comments to D123494: [VectorCombine] Find and remove shuffles from commutative reductions.
Apr 26 2022, 8:08 AM · Restricted Project, Restricted Project
samtebbs accepted D124357: [AArch64] Cost modelling for fptoi_sat.

Looks pretty sensible to me, thanks.

Apr 26 2022, 7:58 AM · Restricted Project, Restricted Project
samtebbs accepted D123414: [AArch64] Break up larger shuffle-masks into legal sizes in getShuffleCost.

LGTM

Apr 26 2022, 3:27 AM · Restricted Project, Restricted Project

Apr 20 2022

samtebbs added inline comments to D123414: [AArch64] Break up larger shuffle-masks into legal sizes in getShuffleCost.
Apr 20 2022, 6:50 AM · Restricted Project, Restricted Project
samtebbs accepted D123409: [AArch64] Use PerfectShuffle costs in AArch64TTIImpl::getShuffleCost.

LGTM!

Apr 20 2022, 6:37 AM · Restricted Project, Restricted Project

Apr 13 2022

samtebbs added inline comments to D123409: [AArch64] Use PerfectShuffle costs in AArch64TTIImpl::getShuffleCost.
Apr 13 2022, 3:15 AM · Restricted Project, Restricted Project
samtebbs added inline comments to D123414: [AArch64] Break up larger shuffle-masks into legal sizes in getShuffleCost.
Apr 13 2022, 3:10 AM · Restricted Project, Restricted Project

Mar 29 2022

samtebbs accepted D122643: [AArch64] Optimize pattern for converting a half word byte swap in a 64-bit input to a rev16 instruction.

Nice one. Looks good to me.

Mar 29 2022, 5:24 AM · Restricted Project, Restricted Project

Mar 23 2022

samtebbs accepted D121137: [AArch64] Lower 3 and 4 sources buildvectors to TBL.

Nice

Mar 23 2022, 9:05 AM · Restricted Project, Restricted Project

Mar 10 2022

samtebbs added inline comments to D119880: [FuncSpec] Support function specialization across multiple arguments..
Mar 10 2022, 2:21 AM · Restricted Project, Restricted Project
samtebbs accepted D119556: [AArch64] Custom lower smaller than legal abd/hadd.

Sorry for letting this slip through the cracks for so long, looks good to me.

Mar 10 2022, 2:18 AM · Restricted Project, Restricted Project
samtebbs accepted D118584: [AArch64] Combine ISD::AND into AArch64ISD::ANDS.

Nice one. LGTM if david has no other comments

Mar 10 2022, 2:16 AM · Restricted Project, Restricted Project
samtebbs added inline comments to D121137: [AArch64] Lower 3 and 4 sources buildvectors to TBL.
Mar 10 2022, 2:12 AM · Restricted Project, Restricted Project

Mar 9 2022

samtebbs accepted D121139: [AArch64] TBL uses zero for out of range elements..

LGTM

Mar 9 2022, 2:29 AM · Restricted Project, Restricted Project
samtebbs added inline comments to D119880: [FuncSpec] Support function specialization across multiple arguments..
Mar 9 2022, 2:19 AM · Restricted Project, Restricted Project

Jan 27 2022

samtebbs added a comment to D117592: [ARM][AArch64] Introduce qrdmlah and qrdmlsh intrinsics.

Ah I see, makes sense. LGTM

Jan 27 2022, 9:12 AM · Restricted Project, Restricted Project
samtebbs added inline comments to D117592: [ARM][AArch64] Introduce qrdmlah and qrdmlsh intrinsics.
Jan 27 2022, 7:16 AM · Restricted Project, Restricted Project
samtebbs accepted D118327: [AArch64] Genereate CCMP from And CSel.

LGTM

Jan 27 2022, 7:09 AM · Restricted Project

Dec 14 2021

samtebbs accepted D114939: [ARM] Verify addressing immediates.
Dec 14 2021, 3:26 AM · Restricted Project
samtebbs added a comment to D114939: [ARM] Verify addressing immediates.

I'm wondering if this verification could be done for us automatically, because the tablegen operands presumably already check what the immediate is before it's allowed to become a t2_addrmode_i7 etc. If that isn't possible then this LGTM.

Dec 14 2021, 3:26 AM · Restricted Project
samtebbs accepted D115185: [ARM] Fold away CMP/CSINC from CMOV.

Perfect, LGTM

Dec 14 2021, 3:20 AM · Restricted Project
samtebbs accepted D115242: [ARM] Handle splats of constants for MVE qr instruction.

Nice one

Dec 14 2021, 3:19 AM · Restricted Project

Dec 9 2021

samtebbs added inline comments to D115242: [ARM] Handle splats of constants for MVE qr instruction.
Dec 9 2021, 9:17 AM · Restricted Project
samtebbs accepted D115188: [ARM] Extend IsCMPZCSINC to handle CMOV.

LGTM

Dec 9 2021, 9:07 AM · Restricted Project
samtebbs added inline comments to D115185: [ARM] Fold away CMP/CSINC from CMOV.
Dec 9 2021, 9:02 AM · Restricted Project
samtebbs added a comment to D114939: [ARM] Verify addressing immediates.

Is this the kind of constraint that can be baked into the operand type in the instruction's (ins ...) in tablegen?

Dec 9 2021, 8:44 AM · Restricted Project

Nov 26 2021

samtebbs accepted D114349: [ARM] CSINC/CSINV patterns from CMOV.

👍

Nov 26 2021, 7:12 AM · Restricted Project
samtebbs accepted D114636: [ARM] Correct range in isLegalAddressImm.

Nice

Nov 26 2021, 7:08 AM · Restricted Project
samtebbs accepted D114449: [ARM] Make v2i1 legal.

Great, LGTM

Nov 26 2021, 7:07 AM · Restricted Project
samtebbs accepted D114380: [ARM] Teach getIntImmCostInst about the cost of saturating fp converts.

LGTM

Nov 26 2021, 7:06 AM · Restricted Project

Nov 25 2021

samtebbs accepted D114455: [ARM] Use v2i1 for MVE and CDE intrinsics.

LGTM

Nov 25 2021, 8:07 AM · Restricted Project, Restricted Project
samtebbs added a comment to D114449: [ARM] Make v2i1 legal.

LGTM with a couple of changes

Nov 25 2021, 8:04 AM · Restricted Project

Nov 24 2021

samtebbs accepted D114360: [ARM] Convert fptoi.sat to fixed point multiply.

Nice

Nov 24 2021, 2:55 AM · Restricted Project
samtebbs accepted D114177: [ARM] Generate VCTP from SETCC.

LGTM

Nov 24 2021, 2:52 AM · Restricted Project

Nov 15 2021

samtebbs accepted D113574: [ARM] Fold floating point select(binop) patterns.

Very nice

Nov 15 2021, 2:14 AM · Restricted Project
samtebbs accepted D113584: [ARM] Fold (fadd x, (vselect c, y, -1.0)) into (vselect c, (fadd x, y), x).

LGTM with one request

Nov 15 2021, 2:11 AM · Restricted Project

Nov 10 2021

samtebbs accepted D112994: [AArch64] Sink splat shuffles to lane index intrinsics.

LGTM!

Nov 10 2021, 6:34 AM · Restricted Project
samtebbs accepted D113297: [AArch64] Allow FP16 vector fixed point converts.

LGTM

Nov 10 2021, 3:05 AM · Restricted Project
samtebbs accepted D113200: [AArch64] Combine vector fptoi.sat(fmul) to fixed point fcvtz.

Very nice

Nov 10 2021, 2:54 AM · Restricted Project
samtebbs added inline comments to D112994: [AArch64] Sink splat shuffles to lane index intrinsics.
Nov 10 2021, 2:39 AM · Restricted Project

Nov 2 2021

samtebbs added inline comments to D112994: [AArch64] Sink splat shuffles to lane index intrinsics.
Nov 2 2021, 3:26 AM · Restricted Project
samtebbs accepted D112922: [ARM] Treat MVE gather add-like-or's like adds .

LGTM with a couple of comments.

Nov 2 2021, 3:20 AM · Restricted Project
samtebbs accepted D112920: [ARM] Push gather/scatter shl index updates out of loops.

LGTM

Nov 2 2021, 3:11 AM · Restricted Project

Oct 14 2021

samtebbs accepted D111787: [AArch64] Improve fptosi.sat vector lowering.

Very nice. LGTM

Oct 14 2021, 6:36 AM · Restricted Project
samtebbs accepted D111236: [AArch64] Improve fptosi.sat lowering.

LGTM

Oct 14 2021, 6:29 AM · Restricted Project

Oct 11 2021

samtebbs added inline comments to D111236: [AArch64] Improve fptosi.sat lowering.
Oct 11 2021, 3:11 AM · Restricted Project

Oct 7 2021

samtebbs added inline comments to D111048: [ARM] Introduce a MQPRCopy.
Oct 7 2021, 6:59 AM · Restricted Project

Oct 5 2021

samtebbs accepted D111048: [ARM] Introduce a MQPRCopy.

Looks good to me, with one more question.

Oct 5 2021, 8:35 AM · Restricted Project

Oct 4 2021

samtebbs abandoned D106261: [ARM][LowOverheadLoops] Allow unpredicated VORRs if the operand def produces zeroed false lanes.

Abandoned in favour of https://reviews.llvm.org/D111048

Oct 4 2021, 6:22 AM · Restricted Project
samtebbs added inline comments to D111048: [ARM] Introduce a MQPRCopy.
Oct 4 2021, 6:21 AM · Restricted Project

Sep 28 2021

samtebbs accepted D110333: [ARM] Add more MVE intrinsics to sink splats to.

Nice one

Sep 28 2021, 4:11 AM · Restricted Project
samtebbs accepted D109360: [ARM] Mark <= -1 immediate constant as cheap.

LGTM

Sep 28 2021, 3:35 AM · Restricted Project

Sep 21 2021

samtebbs accepted D107810: [ARM] Improve detection of fallthough when aligning blocks.

Apologies for taking a long time to get back to you on this! LGTM

Sep 21 2021, 9:23 AM · Restricted Project
samtebbs added inline comments to D109360: [ARM] Mark <= -1 immediate constant as cheap.
Sep 21 2021, 9:22 AM · Restricted Project
samtebbs accepted D109706: [ARM] Allow smaller VMOVL in tail predicated loops.

Nice idea. LGTM

Sep 21 2021, 9:15 AM · Restricted Project

Sep 1 2021

samtebbs accepted D107638: [ARM] Add a tail-predication loop predicate register.

Your comments make sense 👍 LGTM

Sep 1 2021, 9:14 AM · Restricted Project
samtebbs added inline comments to D107810: [ARM] Improve detection of fallthough when aligning blocks.
Sep 1 2021, 9:12 AM · Restricted Project
samtebbs accepted D107865: [ARM] Add MVE lowering for fptosi.sat.

Very nice

Sep 1 2021, 9:08 AM · Restricted Project

Aug 31 2021

samtebbs accepted D107866: [ARM] Add VFP lowering for fptosi.sat.

Nice one

Aug 31 2021, 9:09 AM · Restricted Project
samtebbs accepted D108378: [ARM] Add patterns for store(fptosisat(..)).

LGTM. Sorry for the delay on this one.

Aug 31 2021, 8:50 AM · Restricted Project
samtebbs requested review of D109001: [AArch64] Fold an sqadd of a sqdmull at lane 0 into an sqdmlal.
Aug 31 2021, 8:36 AM · Restricted Project, Restricted Project

Aug 9 2021

samtebbs added inline comments to D106261: [ARM][LowOverheadLoops] Allow unpredicated VORRs if the operand def produces zeroed false lanes.
Aug 9 2021, 5:57 AM · Restricted Project
samtebbs added a comment to D107638: [ARM] Add a tail-predication loop predicate register.

From looking at the changes to some of the tests that should produce tail-predicated loops, none of them get the $noreg replaced with $lr. Isn't that supposed to happen in the VPT optimisation pass, or am I looking in the wrong place?

Aug 9 2021, 5:53 AM · Restricted Project
samtebbs added inline comments to D107638: [ARM] Add a tail-predication loop predicate register.
Aug 9 2021, 5:50 AM · Restricted Project
samtebbs accepted D107642: [ARM] Enable subreg liveness.

Nice work

Aug 9 2021, 5:40 AM · Restricted Project

Aug 3 2021

samtebbs accepted D105589: [ARM] Move the creation of VBICIMM and VORRIMM to lowering.

LGTM

Aug 3 2021, 3:20 AM · Restricted Project

Jul 30 2021

samtebbs accepted D104709: [ARM] Revert WLSTP to DLSTP if the target block is out of range.

Nice one. Looks good to me.

Jul 30 2021, 1:41 AM · Restricted Project

Jul 29 2021

samtebbs added inline comments to D104709: [ARM] Revert WLSTP to DLSTP if the target block is out of range.
Jul 29 2021, 9:08 AM · Restricted Project

Jul 27 2021

samtebbs accepted D106238: [ARM] MVE hadd and rhadd.

Nice one

Jul 27 2021, 9:29 AM · Restricted Project
samtebbs accepted D106569: [ARM] Distribute reductions based on ascending load offset.

Very nice idea and looks good to me other than an possible change I thought of.

Jul 27 2021, 9:19 AM · Restricted Project

Jul 19 2021

samtebbs requested review of D106261: [ARM][LowOverheadLoops] Allow unpredicated VORRs if the operand def produces zeroed false lanes.
Jul 19 2021, 3:44 AM · Restricted Project

Jul 15 2021

samtebbs committed rGff0ef6a51857: [ARM][LowOverheadLoops] Make some stack spills valid for tail predication (authored by samtebbs).
[ARM][LowOverheadLoops] Make some stack spills valid for tail predication
Jul 15 2021, 11:24 AM
samtebbs closed D105443: [ARM][LowOverheadLoops] Make some stack spills valid for tail predication.
Jul 15 2021, 11:24 AM · Restricted Project
samtebbs added inline comments to D105443: [ARM][LowOverheadLoops] Make some stack spills valid for tail predication.
Jul 15 2021, 8:26 AM · Restricted Project
samtebbs updated the diff for D105443: [ARM][LowOverheadLoops] Make some stack spills valid for tail predication.

Check for null pseudo value, change smallptrset size, check for just one memoperand and avoid checking successors when a VSTRW is found.

Jul 15 2021, 8:26 AM · Restricted Project

Jul 14 2021

samtebbs accepted D105686: [ARM] Move add(VMLALVA(A, X, Y), B) to VMLALVA(add(A, B), X, Y).

LGTM

Jul 14 2021, 6:15 AM · Restricted Project
samtebbs accepted D105588: [ARM] Remove PromotedBitwiseVT for NEON types.

Nice, this should make the IR cleaner.

Jul 14 2021, 6:13 AM · Restricted Project

Jul 13 2021

samtebbs added inline comments to D105443: [ARM][LowOverheadLoops] Make some stack spills valid for tail predication.
Jul 13 2021, 9:16 AM · Restricted Project
samtebbs updated the diff for D105443: [ARM][LowOverheadLoops] Make some stack spills valid for tail predication.

Make ValidateMVEStore static, use dyn_cast, check isSpillSlotObjectIndex, make GetFrameIndex return an int, remove the size for the SmallVector and check the size of memoperands.

Jul 13 2021, 9:16 AM · Restricted Project

Jul 12 2021

samtebbs accepted D105814: [ARM] Expand types handled in VQDMULH recognition.

Very nice job

Jul 12 2021, 7:48 AM · Restricted Project
samtebbs updated the diff for D105443: [ARM][LowOverheadLoops] Make some stack spills valid for tail predication.

Break-out code to function, check frame index and rename loop counter.

Jul 12 2021, 7:08 AM · Restricted Project

Jul 8 2021

samtebbs accepted D105090: [ARM] Introduce MVEEXT ISel lowering.

Nice

Jul 8 2021, 1:59 AM · Restricted Project

Jul 7 2021

samtebbs added inline comments to D105443: [ARM][LowOverheadLoops] Make some stack spills valid for tail predication.
Jul 7 2021, 9:27 AM · Restricted Project