User Details
- User Since
- May 31 2019, 2:34 AM (160 w, 2 d)
Thu, Jun 23
LGTM
Fri, Jun 17
Nice one.
Thu, Jun 16
Looks good to me. I assume that the test case can't be reduced while retaining the behaviour.
Mon, Jun 6
LGTM
lgtm
Wed, Jun 1
LGTM! Thanks
May 26 2022
LGTM
May 25 2022
May 19 2022
LGTM
May 6 2022
Looks sensible to me, thanks
May 3 2022
Out of interest, do you have any benchmark results to show how these new costs improves things?
LGTM
Apr 28 2022
Apr 27 2022
LGTM
Apr 26 2022
Looks pretty sensible to me, thanks.
LGTM
Apr 20 2022
LGTM!
Apr 13 2022
Mar 29 2022
Nice one. Looks good to me.
Mar 23 2022
Nice
Mar 10 2022
Sorry for letting this slip through the cracks for so long, looks good to me.
Nice one. LGTM if david has no other comments
Mar 9 2022
LGTM
Jan 27 2022
Ah I see, makes sense. LGTM
LGTM
Dec 14 2021
I'm wondering if this verification could be done for us automatically, because the tablegen operands presumably already check what the immediate is before it's allowed to become a t2_addrmode_i7 etc. If that isn't possible then this LGTM.
Perfect, LGTM
Nice one
Dec 9 2021
LGTM
Is this the kind of constraint that can be baked into the operand type in the instruction's (ins ...) in tablegen?
Nov 26 2021
👍
Nice
Great, LGTM
LGTM
Nov 25 2021
LGTM
LGTM with a couple of changes
Nov 24 2021
Nice
LGTM
Nov 15 2021
Very nice
LGTM with one request
Nov 10 2021
LGTM!
LGTM
Very nice
Nov 2 2021
LGTM with a couple of comments.
LGTM
Oct 14 2021
Very nice. LGTM
LGTM
Oct 11 2021
Oct 7 2021
Oct 5 2021
Looks good to me, with one more question.
Oct 4 2021
Abandoned in favour of https://reviews.llvm.org/D111048
Sep 28 2021
Nice one
LGTM
Sep 21 2021
Apologies for taking a long time to get back to you on this! LGTM
Nice idea. LGTM
Sep 1 2021
Your comments make sense 👍 LGTM
Very nice
Aug 31 2021
Nice one
LGTM. Sorry for the delay on this one.
Aug 9 2021
From looking at the changes to some of the tests that should produce tail-predicated loops, none of them get the $noreg replaced with $lr. Isn't that supposed to happen in the VPT optimisation pass, or am I looking in the wrong place?
Nice work
Aug 3 2021
LGTM
Jul 30 2021
Nice one. Looks good to me.
Jul 29 2021
Jul 27 2021
Nice one
Very nice idea and looks good to me other than an possible change I thought of.
Jul 19 2021
Jul 15 2021
Check for null pseudo value, change smallptrset size, check for just one memoperand and avoid checking successors when a VSTRW is found.
Jul 14 2021
LGTM
Nice, this should make the IR cleaner.
Jul 13 2021
Make ValidateMVEStore static, use dyn_cast, check isSpillSlotObjectIndex, make GetFrameIndex return an int, remove the size for the SmallVector and check the size of memoperands.
Jul 12 2021
Very nice job
Break-out code to function, check frame index and rename loop counter.
Jul 8 2021
Nice