- User Since
- Jan 26 2017, 7:07 AM (155 w, 4 d)
Dec 13 2019
V3: Reinstated and fixed the removed test.
Dec 12 2019
Yes, sorry, I will do the test changes that Matt suggested so this can be approved and landed.
Dec 4 2019
V2: Removed an existing test for the bogus fold.
Dec 3 2019
Dec 2 2019
Nov 27 2019
V2: Sorted includes alphabetically.
No test because by definition it was indeterminate.
Nov 12 2019
Nov 11 2019
V3: Only bail if it is a copy and a partial def, to avoid spurious test changes.
Nov 8 2019
V2: Used modifiesRegister as suggested by Matt.
This is slightly broken for us. See D70005 for a fix.
Nov 7 2019
Oct 29 2019
Sep 30 2019
V2: Better fix that does not accidentally allow pow() transforms.
@foad pointed out that this fix is wrong. TLI saying pow() is not supported means if we find a call to a function called pow() then we don't know its semantics. So I will push a revised fix.
Sep 23 2019
Sep 18 2019
Sep 17 2019
Sep 11 2019
Sep 10 2019
V2: Disable all library functions, not just tan.
Sep 2 2019
Aug 13 2019
Aug 6 2019
Jul 4 2019
Jun 24 2019
Possibly, but our majority use case is to not need the disassembly, and our thinking is that we don't want to change the tool flow between the majority case and the minority case. So can we get this fix in please?
I don't think anyone is a fan of dumpcode. But we're still in the position that the proper disassembler does not support gfx6 or gfx7, and we need to get this particular problem fixed in the short term.
Jun 19 2019
For this bug, whatever we do with a mir test, it is not going to be reliable in failing if the bug is present. Maybe there is a unit testing framework for LiveRangeCalc tests that I could add a test to.
Jun 18 2019
Jun 13 2019
Jun 12 2019
V2: Lit test fix.
V2: Addressed review comments re test.
Jun 11 2019
May 30 2019
V2: Target-specific attribute instead of target feature, as suggested by Stas.
May 29 2019
May 21 2019
LGTM, but I don't think I know the legalization code well enough to approve this.
May 16 2019
Is someone now able to approve this? Eli?
May 14 2019
V4: update_mir_test_checks the test.
May 8 2019
Ping: Could someone approve this please? Thanks.
Hi Samuel. Sorry for the delay; I kind of lost track of this change.