Page MenuHomePhabricator

tpr (Tim Renouf)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 26 2017, 7:07 AM (321 w, 13 h)

Recent Activity

Jan 11 2023

tpr accepted D141379: [AMDGPU] Temporarily disable FeatureBackOffBarrier for GFX11.

LGTM too.

Jan 11 2023, 9:22 AM · Restricted Project, Restricted Project

Jul 12 2022

tpr added a comment to D129566: AMDGPU: Turn off force init 16 input SGPRS for pal.

I'm not suggesting moving it into the same model, but the backend should figure out the user SGPR count given the formal argument list in the IR

Jul 12 2022, 10:47 AM · Restricted Project, Restricted Project

May 4 2022

tpr added reviewers for D124917: BitcodeReader: Avoid bad debug info warnings when stripping: aprantl, chandlerc.
May 4 2022, 5:41 AM · Restricted Project, Restricted Project
tpr requested review of D124917: BitcodeReader: Avoid bad debug info warnings when stripping.
May 4 2022, 5:37 AM · Restricted Project, Restricted Project

Mar 25 2022

tpr accepted D122447: Prevent comparison with wider type in loop condition.

LGTM if clang-format thing is fixed.

Mar 25 2022, 2:45 AM · Restricted Project, Restricted Project

Nov 22 2021

tpr updated subscribers of D114273: [AMDGPU] Do not generate ELF symbols for the local branch target labels.

@tpr does this change break anything in LLPC?

Nov 22 2021, 4:58 AM · Restricted Project

Jul 8 2021

tpr added inline comments to rG8e22539067d9: [IR] Make some pointer element type accesses explicit (NFC).
Jul 8 2021, 4:31 AM

May 6 2021

tpr committed rGab5932ffbd91: [llvm-objdump] Use std::make_unique (authored by tpr).
[llvm-objdump] Use std::make_unique
May 6 2021, 1:11 AM
tpr closed D101822: [llvm-objdump] Use std::make_unique.
May 6 2021, 1:11 AM · Restricted Project
tpr added a comment to D101822: [llvm-objdump] Use std::make_unique.

Previous commit being fixed up: rG1128311a19179ceca799ff0fbc4dd206ab56e560
I will also added that to the commit message.

May 6 2021, 12:42 AM · Restricted Project

May 4 2021

tpr added a reviewer for D101822: [llvm-objdump] Use std::make_unique: dblaikie.
May 4 2021, 2:14 AM · Restricted Project
tpr requested review of D101822: [llvm-objdump] Use std::make_unique.
May 4 2021, 2:12 AM · Restricted Project

Apr 26 2021

tpr committed rG1128311a1917: [AMDGPU][llvm-objdump] Fix memory leak in recent commit (authored by tpr).
[AMDGPU][llvm-objdump] Fix memory leak in recent commit
Apr 26 2021, 10:52 AM
tpr committed rG18adf4bb0d13: [AMDGPU][llvm-objdump] Add lit.local.cfg missing from recent commit (authored by tpr).
[AMDGPU][llvm-objdump] Add lit.local.cfg missing from recent commit
Apr 26 2021, 6:08 AM
tpr committed rG8710eff6c3ba: [MC][AMDGPU][llvm-objdump] Synthesized local labels in disassembly (authored by tpr).
[MC][AMDGPU][llvm-objdump] Synthesized local labels in disassembly
Apr 26 2021, 5:57 AM
tpr closed D101145: [MC][AMDGPU][llvm-objdump] Synthesized local labels in disassembly.
Apr 26 2021, 5:57 AM · Restricted Project

Apr 23 2021

tpr added inline comments to D101145: [MC][AMDGPU][llvm-objdump] Synthesized local labels in disassembly.
Apr 23 2021, 10:24 AM · Restricted Project
tpr updated the diff for D101145: [MC][AMDGPU][llvm-objdump] Synthesized local labels in disassembly.

V2: Extract AMDGPU-add-symbolizer code and my new logic into a separate
function. Only enable new functionality with SymbolizeOperands to bring
it into line with X86 (and stop existing tests failing).

Apr 23 2021, 10:19 AM · Restricted Project
tpr added reviewers for D101145: [MC][AMDGPU][llvm-objdump] Synthesized local labels in disassembly: hoyFB, scott.linder, rochauha.
Apr 23 2021, 1:07 AM · Restricted Project
tpr requested review of D101145: [MC][AMDGPU][llvm-objdump] Synthesized local labels in disassembly.
Apr 23 2021, 1:05 AM · Restricted Project

Mar 31 2021

tpr added a comment to D93125: Update AMDGPU PAL usage documentation.

Please make the commit message a bit more descriptive than just "update".

Mar 31 2021, 12:12 AM · Restricted Project

Mar 30 2021

tpr committed rG083b0f1b40fb: [AMDGPU] Update AMDGPU PAL usage documentation (authored by tpr).
[AMDGPU] Update AMDGPU PAL usage documentation
Mar 30 2021, 12:34 AM

Feb 10 2021

tpr abandoned D96433: llvm cmake: Fix NATIVE build when a toolchain file is already defined.

Abandoning as it is the wrong fix.

Feb 10 2021, 12:08 PM · Restricted Project
tpr added a comment to D96433: llvm cmake: Fix NATIVE build when a toolchain file is already defined.

The NATIVE build is also used for cross-compilation scenarios (e.g. you're building on Windows but targeting Linux, but you still need tools like tablegen to be built targeting Windows), and for those cases, using the same CMAKE_TOOLCHAIN_FILE as the main build is completely incorrect.

What I've done to handle situations like this is set the CROSS_TOOLCHAIN_FLAGS_NATIVE cache variable to include the desired toolchain file for the NATIVE build (and any other desired CMake settings as well). Does that work for you? Something like -DCROSS_TOOLCHAIN_FLAGS_NATIVE="-DCMAKE_TOOLCHAIN_FILE=/path/to/your/toolchain/file" should do the trick.

Feb 10 2021, 12:05 PM · Restricted Project
tpr added a comment to D96433: llvm cmake: Fix NATIVE build when a toolchain file is already defined.

This fix is wrong. I have a test build that went into an infinitely recursive loop of doing NATIVE builds.

Feb 10 2021, 12:04 PM · Restricted Project
tpr added reviewers for D96433: llvm cmake: Fix NATIVE build when a toolchain file is already defined: Flakebi, smeenai, beanz.
Feb 10 2021, 10:09 AM · Restricted Project
tpr requested review of D96433: llvm cmake: Fix NATIVE build when a toolchain file is already defined.
Feb 10 2021, 10:08 AM · Restricted Project

Nov 3 2020

tpr committed rG89d41f3a2b82: [AMDGPU] Add gfx1033 target (authored by tpr).
[AMDGPU] Add gfx1033 target
Nov 3 2020, 8:28 AM
tpr committed rGee3e64262757: [AMDGPU] Add gfx90c target (authored by tpr).
[AMDGPU] Add gfx90c target
Nov 3 2020, 8:28 AM
tpr closed D90447: [AMDGPU] Add gfx1033 target.
Nov 3 2020, 8:28 AM · Restricted Project, Restricted Project
tpr closed D90419: [AMDGPU] Add gfx90c target.
Nov 3 2020, 8:28 AM · Restricted Project, Restricted Project

Nov 1 2020

tpr added inline comments to D90447: [AMDGPU] Add gfx1033 target.
Nov 1 2020, 2:03 PM · Restricted Project, Restricted Project

Oct 30 2020

tpr updated the diff for D90447: [AMDGPU] Add gfx1033 target.

V3: Add missing bits.

Oct 30 2020, 10:40 AM · Restricted Project, Restricted Project
tpr updated the diff for D90447: [AMDGPU] Add gfx1033 target.

V2: Update ELFObjectFile.cpp and elf-header-flags-mach.yaml.

Oct 30 2020, 9:46 AM · Restricted Project, Restricted Project
tpr updated the summary of D90419: [AMDGPU] Add gfx90c target.
Oct 30 2020, 7:07 AM · Restricted Project, Restricted Project
tpr updated the diff for D90419: [AMDGPU] Add gfx90c target.

V3: Listed products. Marked as "xnack enabled".

Oct 30 2020, 7:05 AM · Restricted Project, Restricted Project
tpr added reviewers for D90447: [AMDGPU] Add gfx1033 target: t-tye, rampitec.
Oct 30 2020, 2:05 AM · Restricted Project, Restricted Project
tpr requested review of D90447: [AMDGPU] Add gfx1033 target.
Oct 30 2020, 2:01 AM · Restricted Project, Restricted Project

Oct 29 2020

tpr added a reviewer for D90419: [AMDGPU] Add gfx90c target: t-tye.
Oct 29 2020, 1:15 PM · Restricted Project, Restricted Project
tpr updated the diff for D90419: [AMDGPU] Add gfx90c target.

V2: Fixed copy-o in AMDGPUUsage.rst change.

Oct 29 2020, 1:15 PM · Restricted Project, Restricted Project
tpr requested review of D90419: [AMDGPU] Add gfx90c target.
Oct 29 2020, 1:12 PM · Restricted Project, Restricted Project

Oct 27 2020

tpr abandoned D89459: [AMDGPU] Update ELF machine numbers for newly-added targets.

Abandoning after AMD-internal discussion. We're keeping the elf numbers I originally landed.

Oct 27 2020, 6:46 AM · Restricted Project

Oct 15 2020

tpr added reviewers for D89459: [AMDGPU] Update ELF machine numbers for newly-added targets: t-tye, kzhuravl.
Oct 15 2020, 6:11 AM · Restricted Project
tpr requested review of D89459: [AMDGPU] Update ELF machine numbers for newly-added targets.
Oct 15 2020, 6:10 AM · Restricted Project

Oct 12 2020

tpr accepted D89259: [AMDGPU] Correct processor names for gfx1010 and gfx1011.

LGTM

Oct 12 2020, 12:33 PM · Restricted Project

Oct 10 2020

tpr committed rG666ef0db208b: [AMDGPU] Add gfx602, gfx705, gfx805 targets (authored by tpr).
[AMDGPU] Add gfx602, gfx705, gfx805 targets
Oct 10 2020, 9:22 AM
tpr closed D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets.
Oct 10 2020, 9:22 AM · Restricted Project, Restricted Project

Oct 7 2020

tpr updated the diff for D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets.

V3: AMDGCNGPUs table in TargetParser.cpp needs to be in GPUKind order,

so fix the GPUKind order.
Oct 7 2020, 5:37 AM · Restricted Project, Restricted Project
tpr updated the diff for D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets.

V2: Add clang changes. Put TargetParser list in order.

Oct 7 2020, 2:08 AM · Restricted Project, Restricted Project
tpr added inline comments to D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets.
Oct 7 2020, 1:58 AM · Restricted Project, Restricted Project

Oct 6 2020

tpr added reviewers for D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets: t-tye, kzhuravl, rampitec.
Oct 6 2020, 12:36 PM · Restricted Project, Restricted Project
tpr requested review of D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets.
Oct 6 2020, 12:35 PM · Restricted Project, Restricted Project

Jul 8 2020

tpr added a reviewer for D83372: Fix for memory leak reported by Valgrind: beanz.

+Chris Bieneman

Jul 8 2020, 10:03 AM · Restricted Project

May 27 2020

tpr added a reviewer for D80194: [AMDGPU] Allow PAL to put RO global in .text or .rodata: rampitec.
May 27 2020, 2:07 AM · Restricted Project
tpr added a reviewer for D80194: [AMDGPU] Allow PAL to put RO global in .text or .rodata: s-perron.
May 27 2020, 2:07 AM · Restricted Project
tpr abandoned D80338: [AMDGPU] GFX10 PAL: Only pad with s_code_end in pipeline compilation.

I am abandoning this, because it turns out that it is difficult to reliably detect whether we have a PAL pipeline or a PAL shader compilation. Instead, the LLPC linker will remove the padding, and then adds it back on after concatenating .text sections.

May 27 2020, 2:07 AM · Restricted Project

May 26 2020

tpr added a comment to D80194: [AMDGPU] Allow PAL to put RO global in .text or .rodata.

Ping.

May 26 2020, 3:44 AM · Restricted Project

May 25 2020

tpr updated the diff for D80338: [AMDGPU] GFX10 PAL: Only pad with s_code_end in pipeline compilation.

V2: Review comments: Separate predicate function; early exit on CS.

May 25 2020, 3:10 AM · Restricted Project

May 21 2020

tpr committed rGd13a50882006: [AMDGPU] Fixed incorrect PAL metadata register naming (authored by tpr).
[AMDGPU] Fixed incorrect PAL metadata register naming
May 21 2020, 2:39 PM
tpr committed rGdb16eb33ce43: [MsgPack] Added convenience assignment to MsgPackDocument (authored by tpr).
[MsgPack] Added convenience assignment to MsgPackDocument
May 21 2020, 2:39 PM
tpr closed D80121: [MsgPack] Added convenience assignment to MsgPackDocument.
May 21 2020, 2:39 PM · Restricted Project
tpr closed D78860: [AMDGPU] Fixed incorrect PAL metadata register naming.
May 21 2020, 2:39 PM · Restricted Project
tpr committed rGe79d002309cb: [MsgPack] MsgPackDocument::readFromBlob now merges (authored by tpr).
[MsgPack] MsgPackDocument::readFromBlob now merges
May 21 2020, 1:33 PM
tpr closed D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.
May 21 2020, 1:33 PM · Restricted Project
tpr added inline comments to D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.
May 21 2020, 12:59 PM · Restricted Project
tpr updated the diff for D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.

V5: API change so client can choose whether array merging does merge or append.

May 21 2020, 5:54 AM · Restricted Project
tpr added inline comments to D80338: [AMDGPU] GFX10 PAL: Only pad with s_code_end in pipeline compilation.
May 21 2020, 1:04 AM · Restricted Project

May 20 2020

tpr created D80338: [AMDGPU] GFX10 PAL: Only pad with s_code_end in pipeline compilation.
May 20 2020, 4:33 PM · Restricted Project
tpr added reviewers for D80338: [AMDGPU] GFX10 PAL: Only pad with s_code_end in pipeline compilation: nhaehnle, rampitec.
May 20 2020, 4:33 PM · Restricted Project
tpr updated the diff for D80121: [MsgPack] Added convenience assignment to MsgPackDocument.

V4: Added MapDocNode::erase methods.

May 20 2020, 3:27 PM · Restricted Project
tpr updated the diff for D80194: [AMDGPU] Allow PAL to put RO global in .text or .rodata.

V2: Fixed tests.

May 20 2020, 2:53 PM · Restricted Project

May 19 2020

tpr created D80194: [AMDGPU] Allow PAL to put RO global in .text or .rodata.
May 19 2020, 1:36 AM · Restricted Project
tpr added a reviewer for D80194: [AMDGPU] Allow PAL to put RO global in .text or .rodata: kzhuravl.
May 19 2020, 1:36 AM · Restricted Project
tpr added a reviewer for D80194: [AMDGPU] Allow PAL to put RO global in .text or .rodata: nhaehnle.
May 19 2020, 1:36 AM · Restricted Project

May 18 2020

tpr updated the diff for D80121: [MsgPack] Added convenience assignment to MsgPackDocument.

V3: Added assignment for const char *, otherwise it defaults to using

the bool one rather than the StringRef one.
May 18 2020, 9:39 AM · Restricted Project
tpr added reviewers for D80121: [MsgPack] Added convenience assignment to MsgPackDocument: scott.linder, dineshkb-amd.
May 18 2020, 6:57 AM · Restricted Project
tpr updated the diff for D80121: [MsgPack] Added convenience assignment to MsgPackDocument.

V2: Added tests

May 18 2020, 6:57 AM · Restricted Project
tpr created D80121: [MsgPack] Added convenience assignment to MsgPackDocument.
May 18 2020, 6:57 AM · Restricted Project
tpr added a comment to D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.

With the nil/empty change, there is a change in behavior in that doing a map lookup "map[key]" with a key not previously in the map creates a new map entry that is empty rather than nil. That is more correct, but I have just discovered some code in LLPC relying on the old behavior. I can fix the LLPC code, but is the change in behavior going to cause any HSA problems?

May 18 2020, 4:15 AM · Restricted Project
tpr added inline comments to D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.
May 18 2020, 3:42 AM · Restricted Project
tpr updated the diff for D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.
V4: Addressed review comments:
    * Separated the idea of an empty node from a nil node
    * Made default merge behavior to fail on any conflict
    * Array merging now appends
May 18 2020, 3:42 AM · Restricted Project
tpr added a comment to D78860: [AMDGPU] Fixed incorrect PAL metadata register naming.

Ping

May 18 2020, 1:01 AM · Restricted Project

May 13 2020

tpr added inline comments to D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.
May 13 2020, 1:02 AM · Restricted Project

May 12 2020

tpr added inline comments to D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.
May 12 2020, 11:49 AM · Restricted Project
tpr added a comment to D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.

Dinesh is working on merging metadata in ROCm CompilerSupport using MsgPackDocument, and it fell out that merging YAML metadata was also handled transparently. What is the advantage to doing this via a function pointer passed to readFromBlob? It doesn't seem to save any copies as you still need to be able to compare the nodes; is it just a matter of readability? Would it be reasonable to also add a callback for fromYAML?

May 12 2020, 11:49 AM · Restricted Project

May 11 2020

tpr updated the diff for D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.

V3: Removed unneeded nullptr arg.

May 11 2020, 6:56 AM · Restricted Project

May 10 2020

tpr added a comment to D78860: [AMDGPU] Fixed incorrect PAL metadata register naming.

Ping.

May 10 2020, 2:39 AM · Restricted Project

May 9 2020

tpr updated the diff for D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.

V2: Pass map key to merger function.

May 9 2020, 10:05 AM · Restricted Project
tpr created D79671: [MsgPack] MsgPackDocument::readFromBlob now merges.
May 9 2020, 7:25 AM · Restricted Project
tpr added reviewers for D79671: [MsgPack] MsgPackDocument::readFromBlob now merges: scott.linder, kzhuravl.
May 9 2020, 7:25 AM · Restricted Project

May 1 2020

tpr updated the diff for D78860: [AMDGPU] Fixed incorrect PAL metadata register naming.

V2: Also fixed GS regs. Added test.

May 1 2020, 2:57 AM · Restricted Project

Apr 25 2020

tpr created D78860: [AMDGPU] Fixed incorrect PAL metadata register naming.
Apr 25 2020, 4:44 AM · Restricted Project
tpr added reviewers for D78860: [AMDGPU] Fixed incorrect PAL metadata register naming: dstuttard, rampitec.
Apr 25 2020, 4:44 AM · Restricted Project

Mar 10 2020

tpr added a comment to D75789: [AMDGPU] Allow struct.buffer.*.format intrinsics to accept i32.

I don't know of any reason why it has to be fp. Maybe related to the prehistoric thing where isel used to need something to be fp to put it in a vgpr?

Mar 10 2020, 3:02 AM · Restricted Project

Feb 17 2020

tpr added a comment to D74594: [AMDGPU] Fix some tests that did not specify -mcpu.

This got landed in a slightly different form because of conflicts with other sdiv64 etc tests.

Feb 17 2020, 6:16 AM · Restricted Project
tpr committed rG1e926a9f9c51: [AMDGPU] Fix some tests that did not specify -mcpu (authored by tpr).
[AMDGPU] Fix some tests that did not specify -mcpu
Feb 17 2020, 6:08 AM
tpr closed D74594: [AMDGPU] Fix some tests that did not specify -mcpu.
Feb 17 2020, 6:07 AM · Restricted Project

Feb 14 2020

tpr updated the diff for D74594: [AMDGPU] Fix some tests that did not specify -mcpu.

V2: Also added gfx1010 to memtime test.

Feb 14 2020, 2:30 AM · Restricted Project
tpr added reviewers for D74594: [AMDGPU] Fix some tests that did not specify -mcpu: kzhuravl, rampitec.
Feb 14 2020, 1:47 AM · Restricted Project
tpr created D74594: [AMDGPU] Fix some tests that did not specify -mcpu.
Feb 14 2020, 1:45 AM · Restricted Project