Yes, sorry, I will do the test changes that Matt suggested so this can be approved and landed.

V2: Removed an existing test for the bogus fold.

V2: Sorted includes alphabetically.

In D70783#1762087, @rampitec wrote:

Did the problem manifest in any way?

No test because by definition it was indeterminate.

V3: Only bail if it is a copy and a partial def, to avoid spurious test changes.

V2: Used modifiesRegister as suggested by Matt.

This is slightly broken for us. See D70005 for a fix.

In D69557#1725564, @foad wrote:

In D69557#1725496, @spatel wrote:

Does D69161 cover this change? If so, we could add the test there and fix the problem in 1 step.

I think this bug fix is orthogonal to D69161, which adds new functionality.

V2: Better fix that does not accidentally allow pow() transforms.

@foad pointed out that this fix is wrong. TLI saying pow() is not supported means if we find a call to a function called pow() then we don't know its semantics. So I will push a revised fix.

In D67680#1673252, @arsenm wrote:

LGTM. Can you also add a test for the mad case

V2: Disable all library functions, not just tan.

In D67003#1654339, @cwabbott wrote:

I just noticed that this already came up in D65813 and it does the right thing, it's just waiting review.

Possibly, but our majority use case is to not need the disassembly, and our thinking is that we don't want to change the tool flow between the majority case and the minority case. So can we get this fix in please?

I don't think anyone is a fan of dumpcode. But we're still in the position that the proper disassembler does not support gfx6 or gfx7, and we need to get this particular problem fixed in the short term.

For this bug, whatever we do with a mir test, it is not going to be reliable in failing if the bug is present. Maybe there is a unit testing framework for LiveRangeCalc tests that I could add a test to.

V2: Lit test fix.

V2: Addressed review comments re test.

V2: Target-specific attribute instead of target feature, as suggested by Stas.

LGTM, but I don't think I know the legalization code well enough to approve this.

Is someone now able to approve this? Eli?

V4: update_mir_test_checks the test.

Ping: Could someone approve this please? Thanks.

Hi Samuel. Sorry for the delay; I kind of lost track of this change.