User Details
- User Since
- Jan 26 2017, 7:07 AM (321 w, 13 h)
Jan 11 2023
LGTM too.
Jul 12 2022
I'm not suggesting moving it into the same model, but the backend should figure out the user SGPR count given the formal argument list in the IR
May 4 2022
Mar 25 2022
LGTM if clang-format thing is fixed.
Nov 22 2021
Jul 8 2021
May 6 2021
Previous commit being fixed up: rG1128311a19179ceca799ff0fbc4dd206ab56e560
I will also added that to the commit message.
May 4 2021
Apr 26 2021
Apr 23 2021
V2: Extract AMDGPU-add-symbolizer code and my new logic into a separate
function. Only enable new functionality with SymbolizeOperands to bring
it into line with X86 (and stop existing tests failing).
Mar 31 2021
Mar 30 2021
Feb 10 2021
Abandoning as it is the wrong fix.
This fix is wrong. I have a test build that went into an infinitely recursive loop of doing NATIVE builds.
Nov 3 2020
Nov 1 2020
Oct 30 2020
V3: Add missing bits.
V2: Update ELFObjectFile.cpp and elf-header-flags-mach.yaml.
V3: Listed products. Marked as "xnack enabled".
Oct 29 2020
V2: Fixed copy-o in AMDGPUUsage.rst change.
Oct 27 2020
Abandoning after AMD-internal discussion. We're keeping the elf numbers I originally landed.
Oct 15 2020
Oct 12 2020
LGTM
Oct 10 2020
Oct 7 2020
V3: AMDGCNGPUs table in TargetParser.cpp needs to be in GPUKind order,
so fix the GPUKind order.
V2: Add clang changes. Put TargetParser list in order.
Oct 6 2020
Jul 8 2020
+Chris Bieneman
May 27 2020
I am abandoning this, because it turns out that it is difficult to reliably detect whether we have a PAL pipeline or a PAL shader compilation. Instead, the LLPC linker will remove the padding, and then adds it back on after concatenating .text sections.
May 26 2020
Ping.
May 25 2020
V2: Review comments: Separate predicate function; early exit on CS.
May 21 2020
V5: API change so client can choose whether array merging does merge or append.
May 20 2020
V4: Added MapDocNode::erase methods.
V2: Fixed tests.
May 19 2020
May 18 2020
V3: Added assignment for const char *, otherwise it defaults to using
the bool one rather than the StringRef one.
V2: Added tests
With the nil/empty change, there is a change in behavior in that doing a map lookup "map[key]" with a key not previously in the map creates a new map entry that is empty rather than nil. That is more correct, but I have just discovered some code in LLPC relying on the old behavior. I can fix the LLPC code, but is the change in behavior going to cause any HSA problems?
V4: Addressed review comments: * Separated the idea of an empty node from a nil node * Made default merge behavior to fail on any conflict * Array merging now appends
Ping
May 13 2020
May 12 2020
May 11 2020
V3: Removed unneeded nullptr arg.
May 10 2020
Ping.
May 9 2020
V2: Pass map key to merger function.
May 1 2020
V2: Also fixed GS regs. Added test.
Apr 25 2020
Mar 10 2020
I don't know of any reason why it has to be fp. Maybe related to the prehistoric thing where isel used to need something to be fp to put it in a vgpr?
Feb 17 2020
This got landed in a slightly different form because of conflicts with other sdiv64 etc tests.
Feb 14 2020
V2: Also added gfx1010 to memtime test.