This is an archive of the discontinued LLVM Phabricator instance.

Differential D135365

[RISCV][NFC] Fix unused variable warning.
ClosedPublic

Authored by fakepaper56 on Oct 6 2022, 7:58 AM.

Details

Reviewers
frasercrmck
reames
Commits
rG7329dc0cc3ea: [RISCV][NFC] Fix unused variable warning.

Diff Detail

Event Timeline

fakepaper56 created this revision.Oct 6 2022, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2022, 7:58 AM
Herald added subscribers: sunshaoce, VincentWu, vkmr and 27 others. · View Herald Transcript
fakepaper56 requested review of this revision.Oct 6 2022, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 6 2022, 7:58 AM
Herald added subscribers: llvm-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B190734: Diff 465736.Oct 6 2022, 8:46 AM
frasercrmck added inline comments.Oct 7 2022, 3:43 AM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
4503

I notice in at least one other place we do:

auto VL = getDefaultVLOps(VT, ContainerVT, DL, DAG, Subtarget).second;

would that make sense here?

fakepaper56 added inline comments.Oct 7 2022, 2:47 PM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
4503

Good idea. I think it is better than my method.

fakepaper56 updated this revision to Diff 466196.Oct 7 2022, 2:53 PM

Adopt Fraser's proposal.

reames accepted this revision.Oct 7 2022, 3:42 PM
reames added a subscriber: reames.

LGTM

This revision is now accepted and ready to land.Oct 7 2022, 3:42 PM
Harbormaster completed remote builds in B191032: Diff 466196.Oct 7 2022, 4:01 PM
Closed by commit rG7329dc0cc3ea: [RISCV][NFC] Fix unused variable warning. (authored by fakepaper56). · Explain WhyOct 9 2022, 6:39 AM
This revision was automatically updated to reflect the committed changes.
fakepaper56 added a commit: rG7329dc0cc3ea: [RISCV][NFC] Fix unused variable warning..

Revision Contents

PathSize
llvm/
lib/
Target/
RISCV/
2 lines

Diff 466196

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,493 Lines • ▼ Show 20 LinesSDValue RISCVTargetLowering::lowerSPLAT_VECTOR_PARTS(SDValue Op,
assert(Op.getNumOperands() == 2 && "Unexpected number of operands!"); assert(Op.getNumOperands() == 2 && "Unexpected number of operands!");
SDValue Lo = Op.getOperand(0); SDValue Lo = Op.getOperand(0);
SDValue Hi = Op.getOperand(1); SDValue Hi = Op.getOperand(1);
if (VecVT.isFixedLengthVector()) { if (VecVT.isFixedLengthVector()) {
MVT ContainerVT = getContainerForFixedLengthVector(VecVT); MVT ContainerVT = getContainerForFixedLengthVector(VecVT);
SDLoc DL(Op); SDLoc DL(Op);
auto [Mask, VL] = getDefaultVLOps(VecVT, ContainerVT, DL, DAG, Subtarget); auto VL = getDefaultVLOps(VecVT, ContainerVT, DL, DAG, Subtarget).second;
frasercrmckUnsubmitted
Not Done
ReplyInline Actions

I notice in at least one other place we do:

auto VL = getDefaultVLOps(VT, ContainerVT, DL, DAG, Subtarget).second;

would that make sense here?

frasercrmck: I notice in at least one other place we do: ``` auto VL = getDefaultVLOps(VT, ContainerVT…
fakepaper56AuthorUnsubmitted
Done
ReplyInline Actions

Good idea. I think it is better than my method.

fakepaper56: Good idea. I think it is better than my method.
SDValue Res = SDValue Res =
splatPartsI64WithVL(DL, ContainerVT, SDValue(), Lo, Hi, VL, DAG); splatPartsI64WithVL(DL, ContainerVT, SDValue(), Lo, Hi, VL, DAG);
return convertFromScalableVector(VecVT, Res, DAG, Subtarget); return convertFromScalableVector(VecVT, Res, DAG, Subtarget);
} }
if (isa<ConstantSDNode>(Lo) && isa<ConstantSDNode>(Hi)) { if (isa<ConstantSDNode>(Lo) && isa<ConstantSDNode>(Hi)) {
int32_t LoC = cast<ConstantSDNode>(Lo)->getSExtValue(); int32_t LoC = cast<ConstantSDNode>(Lo)->getSExtValue();
int32_t HiC = cast<ConstantSDNode>(Hi)->getSExtValue(); int32_t HiC = cast<ConstantSDNode>(Hi)->getSExtValue();
▲ Show 20 Lines • Show All 8,474 Lines • Show Last 20 Lines