Page MenuHomePhabricator

[llvm] increase upper bound for size in global structs
Needs ReviewPublic

Authored by OfekShochat on Sep 14 2022, 2:21 AM.

Details

Reviewers
efriedma
Summary

on top of 9b1620a501c1 (Clang, increase upper bound of partially initialized array sizes.) to close 57353.

Diff Detail

Event Timeline

OfekShochat created this revision.Sep 14 2022, 2:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2022, 2:21 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
OfekShochat requested review of this revision.Sep 14 2022, 2:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 14 2022, 2:21 AM

Needs a testcase, maybe in llvm/test/CodeGen/X86.

Oh, sorry. I forgot, will do

Add actual test

Add RUN to test.

efriedma added inline comments.Sep 15 2022, 4:45 PM
llvm/test/CodeGen/X86/big-array-init.ll
2

RUN like is missing a target triple, so it will break if the compiler's default target isn't x86_64. RUN line is missing a FileCheck invocation, so nothing actually examines the CHECK lines. Look at other tests for examples.

Maybe the commit message ("summary") could use a bit more description. I'm not sure what 9b1620a501c1 refers to, and I'm not sure it's relevant.

Since you don't have commit access, I'll commit this for you when it's ready. How do you want to be credited in the "author" field of the git commit? (name+email)

llvm/test/CodeGen/X86/big-array-init.ll
6

Maybe CHECK-NEXT: .size bad_int, 4294967296, to be on the safe side. (The current version of the test would pass on a release build without your patch.)

OfekShochat added a comment.EditedSep 16 2022, 9:58 PM

Ill change it to the name of the commit (its the other patch), the name is OfekShochat and email ofeksh.oss@gmail.com, thanks!

OfekShochat edited the summary of this revision. (Show Details)Sep 16 2022, 9:59 PM

Add check for size.