[llvm] increase upper bound for size in global structs

[OfekShochat]

Summary

on top of 9b1620a501c1 (Clang, increase upper bound of partially initialized array sizes.) to close 57353.

[efriedma]

Needs a testcase, maybe in llvm/test/CodeGen/X86.

[OfekShochat]

Oh, sorry. I forgot, will do

[OfekShochat]

Add test

[OfekShochat]

Add actual test

[OfekShochat]

Add RUN to test.

[efriedma]

llvm/test/CodeGen/X86/big-array-init.ll

2

RUN like is missing a target triple, so it will break if the compiler's default target isn't x86_64. RUN line is missing a FileCheck invocation, so nothing actually examines the CHECK lines. Look at other tests for examples.

[OfekShochat]

Fix run.

[efriedma]

Maybe the commit message ("summary") could use a bit more description. I'm not sure what 9b1620a501c1 refers to, and I'm not sure it's relevant.

Since you don't have commit access, I'll commit this for you when it's ready. How do you want to be credited in the "author" field of the git commit? (name+email)

llvm/test/CodeGen/X86/big-array-init.ll

6

Maybe CHECK-NEXT: .size bad_int, 4294967296, to be on the safe side. (The current version of the test would pass on a release build without your patch.)

[OfekShochat]

Ill change it to the name of the commit (its the other patch), the name is OfekShochat and email [e-mail], thanks!

[OfekShochat]

Add check for size.

[OfekShochat]

@efriedma hello?

llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp

if (unsigned Padding = Size - EmittedSize)
     AP.OutStreamer->emitZeros(Padding);
 }
 
 static void emitGlobalConstantStruct(const DataLayout &DL,
                                      const ConstantStruct *CS, AsmPrinter &AP,
                                      const Constant *BaseCV, uint64_t Offset,
                                      AsmPrinter::AliasMapTy *AliasList) {
   // Print the fields in successive locations. Pad to align if needed!
-  unsigned Size = DL.getTypeAllocSize(CS->getType());
+  uint64_t Size = DL.getTypeAllocSize(CS->getType());
   const StructLayout *Layout = DL.getStructLayout(CS->getType());
   uint64_t SizeSoFar = 0;
   for (unsigned I = 0, E = CS->getNumOperands(); I != E; ++I) {
     const Constant *Field = CS->getOperand(I);
 
     // Print the actual field value.
     emitGlobalConstantImpl(DL, Field, AP, BaseCV, Offset + SizeSoFar,
                            AliasList);

llvm/test/CodeGen/X86/big-array-init.ll

+; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu | FileCheck %s
+
+; CHECK-LABEL: bad_int:
+; CHECK-NEXT: .long 1
+; CHECK-NEXT: .zero 4294967292
+; CHECK-NEXT: .size   bad_int, 4294967296
+@bad_int = global <{ i32, [1073741823 x i32] }> <{ i32 1, [1073741823 x i32] zeroinitializer }>, align 16