@efriedma hello?

@efriedma would you be able to commit this?

Add check for size.

Ill change it to the name of the commit (its the other patch), the name is OfekShochat and email ofeksh.oss@gmail.com, thanks!

Fix run.

Add RUN to test.

Add actual test

Add test

Oh, sorry. I forgot, will do

I created a diff for the AsmPrinter part, its at D133845

Clang, increase upper bound of partially initialized array sizes

hello, solved the issue. it was, quite expectedly, a u64/unsigned problem in parsing, not codegen. no need to refactor this function. I will close this, thanks for the feedback and sorry for the hassle

Yeah. But it's really not clear how it does that, as it gets all the functions from the generated file

yep @eli.friedman. probably gonna scratch this idea, makes more sense to actually tackle the problem itself, which is that getArrayFiller doesnt return anything. trying to actually get to the problem, but its quite hard, Visit's are thrown everywhere, and I cant really look at the problem. tryEmitPrivateForVarInit is called, and then it calls a Visit, which somehow transfers it to VisitInitListExpr. that thing worked just because it worked around that problem, even if not intentionally. though, I think Im closing in onto the problem

hello again, I added two tests, one for llvm and one for clang. how do I run those specifically so I see I didnt do something wrong?

hmm, one problem, seems like nor clang and nor gcc can compile the example in the github issue fully, only to assembly. is there something like c -> llir, llir -> asm checks? in the issue, it did succeed to compile to either llir and asm, just not correctly

hello! thank you so much, Ill do that now, thanks! just a question, what are your guidelines when it comes to commit naming/number etc?

trying to fix the problem. probably going to split this into two patches

its my first time contributing. this is probably very bad and goes against a lot of guidelines, but I wouldnt resist to fix this