Page MenuHomePhabricator

OfekShochat (Ofek Shochat)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2022, 4:48 AM (14 w, 20 h)

Recent Activity

Oct 29 2022

OfekShochat added a comment to D133845: [llvm] increase upper bound for size in global structs.

@efriedma hello?

Oct 29 2022, 5:46 AM · Restricted Project, Restricted Project

Sep 25 2022

OfekShochat added a comment to D133648: Clang, increase upper bound of partially initialized array sizes.

@efriedma would you be able to commit this?

Sep 25 2022, 3:07 AM · Restricted Project, Restricted Project, Restricted Project

Sep 16 2022

OfekShochat updated the diff for D133845: [llvm] increase upper bound for size in global structs.

Add check for size.

Sep 16 2022, 10:01 PM · Restricted Project, Restricted Project
OfekShochat updated the summary of D133845: [llvm] increase upper bound for size in global structs.
Sep 16 2022, 9:59 PM · Restricted Project, Restricted Project
OfekShochat added a comment to D133845: [llvm] increase upper bound for size in global structs.

Ill change it to the name of the commit (its the other patch), the name is OfekShochat and email ofeksh.oss@gmail.com, thanks!

Sep 16 2022, 9:58 PM · Restricted Project, Restricted Project

Sep 15 2022

OfekShochat updated the diff for D133845: [llvm] increase upper bound for size in global structs.

Fix run.

Sep 15 2022, 9:51 PM · Restricted Project, Restricted Project
OfekShochat updated the diff for D133845: [llvm] increase upper bound for size in global structs.

Add RUN to test.

Sep 15 2022, 1:01 AM · Restricted Project, Restricted Project
OfekShochat updated the diff for D133845: [llvm] increase upper bound for size in global structs.

Add actual test

Sep 15 2022, 12:34 AM · Restricted Project, Restricted Project
OfekShochat updated the diff for D133845: [llvm] increase upper bound for size in global structs.

Add test

Sep 15 2022, 12:32 AM · Restricted Project, Restricted Project

Sep 14 2022

OfekShochat added a comment to D133845: [llvm] increase upper bound for size in global structs.

Oh, sorry. I forgot, will do

Sep 14 2022, 12:41 PM · Restricted Project, Restricted Project
OfekShochat added a comment to D133648: Clang, increase upper bound of partially initialized array sizes.

I created a diff for the AsmPrinter part, its at D133845

Sep 14 2022, 2:22 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat requested review of D133845: [llvm] increase upper bound for size in global structs.
Sep 14 2022, 2:21 AM · Restricted Project, Restricted Project

Sep 12 2022

OfekShochat updated the diff for D133648: Clang, increase upper bound of partially initialized array sizes.

Clang, increase upper bound of partially initialized array sizes

Sep 12 2022, 9:11 PM · Restricted Project, Restricted Project, Restricted Project

Sep 10 2022

OfekShochat retitled D133648: Clang, increase upper bound of partially initialized array sizes from [Clang] changing behavior of constant array emission to Clang, increase upper bound of partially initialized array sizes.
Sep 10 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project
OfekShochat requested review of D133648: Clang, increase upper bound of partially initialized array sizes.
Sep 10 2022, 12:55 PM · Restricted Project, Restricted Project, Restricted Project
OfekShochat abandoned D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.
Sep 10 2022, 9:03 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat added a comment to D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.

hello, solved the issue. it was, quite expectedly, a u64/unsigned problem in parsing, not codegen. no need to refactor this function. I will close this, thanks for the feedback and sorry for the hassle

Sep 10 2022, 8:59 AM · Restricted Project, Restricted Project, Restricted Project

Sep 9 2022

OfekShochat added a comment to D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.

Yeah. But it's really not clear how it does that, as it gets all the functions from the generated file

Sep 9 2022, 1:44 PM · Restricted Project, Restricted Project, Restricted Project
OfekShochat updated subscribers of D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.

yep @eli.friedman. probably gonna scratch this idea, makes more sense to actually tackle the problem itself, which is that getArrayFiller doesnt return anything. trying to actually get to the problem, but its quite hard, Visit's are thrown everywhere, and I cant really look at the problem. tryEmitPrivateForVarInit is called, and then it calls a Visit, which somehow transfers it to VisitInitListExpr. that thing worked just because it worked around that problem, even if not intentionally. though, I think Im closing in onto the problem

Sep 9 2022, 10:46 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat added a comment to D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.

hello again, I added two tests, one for llvm and one for clang. how do I run those specifically so I see I didnt do something wrong?

Sep 9 2022, 7:20 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat added a comment to D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.

hmm, one problem, seems like nor clang and nor gcc can compile the example in the github issue fully, only to assembly. is there something like c -> llir, llir -> asm checks? in the issue, it did succeed to compile to either llir and asm, just not correctly

Sep 9 2022, 7:02 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat retitled D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32 from #57353 on github to Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.
Sep 9 2022, 6:51 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat added a comment to D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.

hello! thank you so much, Ill do that now, thanks! just a question, what are your guidelines when it comes to commit naming/number etc?

Sep 9 2022, 6:51 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat added a comment to D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.

trying to fix the problem. probably going to split this into two patches

Sep 9 2022, 6:36 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat added a comment to D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.

its my first time contributing. this is probably very bad and goes against a lot of guidelines, but I wouldnt resist to fix this

Sep 9 2022, 5:42 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat retitled D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32 from [Clang] changing behavior of constant array emission[AsmPrinter] changing Size from unsigned to uint64_t to #57353 on github.
Sep 9 2022, 5:41 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat retitled D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32 from [Clang] changing behavior of constant array emission [AsmPrinter] changing Size from unsigned to uint64_t to [Clang] changing behavior of constant array emission[AsmPrinter] changing Size from unsigned to uint64_t.
Sep 9 2022, 5:40 AM · Restricted Project, Restricted Project, Restricted Project
OfekShochat requested review of D133570: Clang codegen, fixes issue with emitting partially initialized constant arrays larger than 2^32.
Sep 9 2022, 5:38 AM · Restricted Project, Restricted Project, Restricted Project