Page MenuHomePhabricator

[RISCV] Change VECTOR_SPLICE mask operation from expand to promote
ClosedPublic

Authored by Jimerlife on Jun 28 2022, 3:13 AM.

Details

Summary

Before this patch, vector_splice mask operation go through expandVectorSplice. But if Imm >= 0 in vector_splice, tests will crash when it go through expandVectorSplice.
So, I change expand vector_splice mask operation to promote. This patch D94708 has implemented vector_splice promote.

Diff Detail

Event Timeline

Jimerlife created this revision.Jun 28 2022, 3:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 3:13 AM
Jimerlife requested review of this revision.Jun 28 2022, 3:13 AM
Jimerlife edited the summary of this revision. (Show Details)Jun 28 2022, 3:14 AM
reames requested changes to this revision.Jun 28 2022, 1:29 PM
reames added a subscriber: reames.

Please land the new tests, and then rebase so that code changes are visible. (Unless this is fixing a crash, and then please clarify the commit message.)

This revision now requires changes to proceed.Jun 28 2022, 1:29 PM

Please land the new tests, and then rebase so that code changes are visible. (Unless this is fixing a crash, and then please clarify the commit message.)

I created D128778 for precommit test, but I set Imm = -1 in all precommit tests. If Imm >= 0, tests will crash. After precommit test land, I will rebase it and update this patch.

Jimerlife updated this revision to Diff 440828.Jun 28 2022, 8:08 PM
Jimerlife edited the summary of this revision. (Show Details)Jun 28 2022, 8:13 PM
Jimerlife updated this revision to Diff 443114.Jul 7 2022, 7:34 PM

rebase main

This revision was not accepted when it landed; it landed in state Needs Review.Jul 7 2022, 11:26 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.