Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Jimerlife (WangLian)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2022, 6:35 PM (90 w, 2 d)

Recent Activity

Mar 9 2023

Jimerlife added a comment to D145146: [Driver][NFC] Remove some redundant code in Driver.cpp. .

ping...

Mar 9 2023, 6:54 PM · Restricted Project, Restricted Project, Restricted Project
Jimerlife committed rG7c2a3573b696: [Codegen][NFC] Replace 'RegisterRegAlloc::FunctionPassCtor' (authored by Jimerlife).
[Codegen][NFC] Replace 'RegisterRegAlloc::FunctionPassCtor'
Mar 9 2023, 6:32 PM · Restricted Project, Restricted Project
Jimerlife closed D145032: [Codegen][NFC] Replace 'RegisterRegAlloc::FunctionPassCtor' with 'RegisterRegAllocBase<T>::FunctionPassCtor' ..
Mar 9 2023, 6:31 PM · Restricted Project, Restricted Project

Mar 2 2023

Jimerlife requested review of D145146: [Driver][NFC] Remove some redundant code in Driver.cpp. .
Mar 2 2023, 12:56 AM · Restricted Project, Restricted Project, Restricted Project

Mar 1 2023

Jimerlife added a comment to D145032: [Codegen][NFC] Replace 'RegisterRegAlloc::FunctionPassCtor' with 'RegisterRegAllocBase<T>::FunctionPassCtor' ..

Out of curiosity - what motivated this change? Do you have dependent patches you're developing or did a linter recommend it?

Mar 1 2023, 6:46 PM · Restricted Project, Restricted Project

Feb 28 2023

Jimerlife requested review of D145032: [Codegen][NFC] Replace 'RegisterRegAlloc::FunctionPassCtor' with 'RegisterRegAllocBase<T>::FunctionPassCtor' ..
Feb 28 2023, 11:10 PM · Restricted Project, Restricted Project
Jimerlife committed rGbc504e0f0605: [Doc][NFC] Add template type when use MachinePassRegistry. (authored by Jimerlife).
[Doc][NFC] Add template type when use MachinePassRegistry.
Feb 28 2023, 6:38 PM · Restricted Project, Restricted Project
Jimerlife closed D144945: [Doc][NFC] Add template type when use MachinePassRegistry..
Feb 28 2023, 6:37 PM · Restricted Project, Restricted Project
Jimerlife requested review of D144945: [Doc][NFC] Add template type when use MachinePassRegistry..
Feb 28 2023, 12:31 AM · Restricted Project, Restricted Project

Sep 23 2022

Jimerlife accepted D134520: [RISCV] Add and update reverse mask tests, NFC.
Sep 23 2022, 1:02 AM · Restricted Project, Restricted Project

Sep 18 2022

Jimerlife committed rG5ed25e4df6a7: [CUDA][NFC] Rename 'addDeviceDepences' to 'addDeviceDependences' in… (authored by Jimerlife).
[CUDA][NFC] Rename 'addDeviceDepences' to 'addDeviceDependences' in…
Sep 18 2022, 7:43 PM · Restricted Project, Restricted Project
Jimerlife closed D134007: [Clang][CUDA][NFC] Rename 'addDeviceDepences' to 'addDeviceDependences' in DeviceActionBuilder..
Sep 18 2022, 7:43 PM · Restricted Project, Restricted Project, Restricted Project

Sep 15 2022

Jimerlife requested review of D134007: [Clang][CUDA][NFC] Rename 'addDeviceDepences' to 'addDeviceDependences' in DeviceActionBuilder..
Sep 15 2022, 8:03 PM · Restricted Project, Restricted Project, Restricted Project

Aug 29 2022

Jimerlife committed rGe2bb9774b173: [LegalizeTypes] Support widen result for VECTOR_REVERSE. (authored by Jimerlife).
[LegalizeTypes] Support widen result for VECTOR_REVERSE.
Aug 29 2022, 7:02 PM · Restricted Project, Restricted Project
Jimerlife closed D132359: [LegalizeTypes] Support widen result for VECTOR_REVERSE.
Aug 29 2022, 7:01 PM · Restricted Project, Restricted Project
Jimerlife added inline comments to D132359: [LegalizeTypes] Support widen result for VECTOR_REVERSE.
Aug 29 2022, 12:42 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D132359: [LegalizeTypes] Support widen result for VECTOR_REVERSE.

rebase and address comment

Aug 29 2022, 12:40 AM · Restricted Project, Restricted Project

Aug 24 2022

Jimerlife committed rG2887d7786f01: [DAGCombiner] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND. (authored by Jimerlife).
[DAGCombiner] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND.
Aug 24 2022, 8:42 PM · Restricted Project, Restricted Project
Jimerlife closed D132439: [DAGCombiner] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND..
Aug 24 2022, 8:42 PM · Restricted Project, Restricted Project
Jimerlife retitled D132439: [DAGCombiner] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND. from [DAGCombiner][NFC] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND. to [DAGCombiner] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND..
Aug 24 2022, 5:18 AM · Restricted Project, Restricted Project
Jimerlife added a comment to D132439: [DAGCombiner] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND..

Thanks - please can you update the title and summary

Aug 24 2022, 5:10 AM · Restricted Project, Restricted Project
Jimerlife retitled D132439: [DAGCombiner] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND. from [DAGCombiner][NFC] Use isa instead of dyn_cast in visitFP_ROUND. to [DAGCombiner][NFC] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND..
Aug 24 2022, 5:08 AM · Restricted Project, Restricted Project
Jimerlife added inline comments to D132439: [DAGCombiner] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND..
Aug 24 2022, 4:12 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D132439: [DAGCombiner] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND..

address comment

Aug 24 2022, 4:12 AM · Restricted Project, Restricted Project

Aug 23 2022

Jimerlife requested review of D132439: [DAGCombiner] Use FoldConstantArithmetic instead of dyn_cast in visitFP_ROUND..
Aug 23 2022, 12:25 AM · Restricted Project, Restricted Project

Aug 22 2022

Jimerlife requested review of D132359: [LegalizeTypes] Support widen result for VECTOR_REVERSE.
Aug 22 2022, 2:23 AM · Restricted Project, Restricted Project
Jimerlife abandoned D132349: [AArch64][NFC] Merge some common ISD node when setOperationAction.
Aug 22 2022, 1:58 AM · Restricted Project, Restricted Project
Jimerlife added a comment to D132349: [AArch64][NFC] Merge some common ISD node when setOperationAction.

Hi @Jimerlife is there a specific reason why you're refactoring this? This patch may reduce the number of lines of code, but it is arguable whether the new version is more readable or better. Code-refactoring creates merge-problems for people needing to maintain downstream branches, so unless there is a clear benefit to the code it is preferable to keep this to a minimum.

Aug 22 2022, 1:57 AM · Restricted Project, Restricted Project

Aug 21 2022

Jimerlife requested review of D132349: [AArch64][NFC] Merge some common ISD node when setOperationAction.
Aug 21 2022, 11:53 PM · Restricted Project, Restricted Project
Jimerlife committed rG53bc7d5f08c8: [AArch64][NFC] Replace setOperationAction and AddPromotedToType (authored by Jimerlife).
[AArch64][NFC] Replace setOperationAction and AddPromotedToType
Aug 21 2022, 7:13 PM · Restricted Project, Restricted Project
Jimerlife closed D132213: [AArch64][NFC] Replace setOperationAction and AddPromotedToType with setOperationPromotedToType.
Aug 21 2022, 7:13 PM · Restricted Project, Restricted Project

Aug 19 2022

Jimerlife abandoned D132207: Precommit tests for D132206.
Aug 19 2022, 2:02 AM · Restricted Project, Restricted Project
Jimerlife requested review of D132213: [AArch64][NFC] Replace setOperationAction and AddPromotedToType with setOperationPromotedToType.
Aug 19 2022, 1:42 AM · Restricted Project, Restricted Project
Jimerlife added a comment to D132206: [DAGCombiner] Fold vecreduce_xor/or/and(splat_vector(val)) to constant.

XOR will be 0 or val depending on if there are an even number of vector elements.

Can you add some tests for both cases?

Aug 19 2022, 12:25 AM · Restricted Project, Restricted Project
Jimerlife added a comment to D132206: [DAGCombiner] Fold vecreduce_xor/or/and(splat_vector(val)) to constant.

Do you have real world examples of C code where this occurs?

Would this be better to do in InstCombine?

Where are the test deltas?

Aug 19 2022, 12:24 AM · Restricted Project, Restricted Project
Jimerlife updated the summary of D132206: [DAGCombiner] Fold vecreduce_xor/or/and(splat_vector(val)) to constant.
Aug 19 2022, 12:06 AM · Restricted Project, Restricted Project
Jimerlife requested review of D132207: Precommit tests for D132206.
Aug 19 2022, 12:05 AM · Restricted Project, Restricted Project
Jimerlife requested review of D132206: [DAGCombiner] Fold vecreduce_xor/or/and(splat_vector(val)) to constant.
Aug 19 2022, 12:03 AM · Restricted Project, Restricted Project

Aug 18 2022

Jimerlife committed rGfc2b4dfef2f1: [DAGCombiner] Add use check for VSCALE in visitSUB. (authored by Jimerlife).
[DAGCombiner] Add use check for VSCALE in visitSUB.
Aug 18 2022, 7:06 PM · Restricted Project, Restricted Project
Jimerlife closed D132115: [DAGCombiner] Add use check for VSCALE in visitSUB..
Aug 18 2022, 7:06 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D132115: [DAGCombiner] Add use check for VSCALE in visitSUB..

rebase test

Aug 18 2022, 3:07 AM · Restricted Project, Restricted Project
Jimerlife committed rGeeac8944180e: Precommit tests for D132115 (authored by Jimerlife).
Precommit tests for D132115
Aug 18 2022, 2:58 AM · Restricted Project, Restricted Project
Jimerlife closed D132116: Precommit tests for D132115.
Aug 18 2022, 2:58 AM · Restricted Project, Restricted Project
Jimerlife added inline comments to D132116: Precommit tests for D132115.
Aug 18 2022, 2:50 AM · Restricted Project, Restricted Project
Jimerlife added a comment to D132116: Precommit tests for D132115.

If this test is OK, could someone help me to accept this test patch?

Aug 18 2022, 2:27 AM · Restricted Project, Restricted Project
Jimerlife added a comment to D132115: [DAGCombiner] Add use check for VSCALE in visitSUB..

test case?

Aug 18 2022, 2:16 AM · Restricted Project, Restricted Project
Jimerlife requested review of D132116: Precommit tests for D132115.
Aug 18 2022, 2:15 AM · Restricted Project, Restricted Project
Jimerlife requested review of D132115: [DAGCombiner] Add use check for VSCALE in visitSUB..
Aug 18 2022, 2:13 AM · Restricted Project, Restricted Project
Jimerlife committed rG989ebc1783a5: [DAGCombiner][NFC] Tidy up unnecessary brackets in visitADD. (authored by Jimerlife).
[DAGCombiner][NFC] Tidy up unnecessary brackets in visitADD.
Aug 18 2022, 12:55 AM · Restricted Project, Restricted Project
Jimerlife closed D132107: [DAGCombiner][NFC] Tidy up unnecessary brackets in visitADD..
Aug 18 2022, 12:55 AM · Restricted Project, Restricted Project
Jimerlife added a comment to D132107: [DAGCombiner][NFC] Tidy up unnecessary brackets in visitADD..

Can you update the commit message to be a little more descriptive, e.g. [DAGCombiner][NFC] Tidy up unnecessary brackets in visitADD ?

Aug 18 2022, 12:45 AM · Restricted Project, Restricted Project
Jimerlife retitled D132107: [DAGCombiner][NFC] Tidy up unnecessary brackets in visitADD. from [DAGCombiner][NFC] Remove extra brackets. to [DAGCombiner][NFC] Tidy up unnecessary brackets in visitADD..
Aug 18 2022, 12:42 AM · Restricted Project, Restricted Project
Jimerlife added inline comments to D132107: [DAGCombiner][NFC] Tidy up unnecessary brackets in visitADD..
Aug 18 2022, 12:40 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D132107: [DAGCombiner][NFC] Tidy up unnecessary brackets in visitADD..

address comment

Aug 18 2022, 12:38 AM · Restricted Project, Restricted Project
Jimerlife requested review of D132107: [DAGCombiner][NFC] Tidy up unnecessary brackets in visitADD..
Aug 18 2022, 12:29 AM · Restricted Project, Restricted Project

Aug 17 2022

Jimerlife committed rG230e277dfe42: [DAGCombiner][NFC] Merge two if statement into one. (authored by Jimerlife).
[DAGCombiner][NFC] Merge two if statement into one.
Aug 17 2022, 7:13 PM · Restricted Project, Restricted Project
Jimerlife closed D131941: [DAGCombiner][NFC] Merge two if statement into one.
Aug 17 2022, 7:13 PM · Restricted Project, Restricted Project

Aug 16 2022

Jimerlife added inline comments to D131941: [DAGCombiner][NFC] Merge two if statement into one.
Aug 16 2022, 6:55 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D131941: [DAGCombiner][NFC] Merge two if statement into one.

address comment

Aug 16 2022, 6:52 PM · Restricted Project, Restricted Project

Aug 15 2022

Jimerlife updated the summary of D131941: [DAGCombiner][NFC] Merge two if statement into one.
Aug 15 2022, 11:34 PM · Restricted Project, Restricted Project
Jimerlife requested review of D131941: [DAGCombiner][NFC] Merge two if statement into one.
Aug 15 2022, 11:34 PM · Restricted Project, Restricted Project
Jimerlife committed rGfbc4c26e9a7a: [SelectionDAG][NFC] Fix return type when used… (authored by Jimerlife).
[SelectionDAG][NFC] Fix return type when used…
Aug 15 2022, 7:14 PM · Restricted Project, Restricted Project
Jimerlife closed D131870: [SelectionDAG][NFC] Fix return type when used isConstantIntBuildVectorOrConstantInt and isConstantFPBuildVectorOrConstantFP.
Aug 15 2022, 7:14 PM · Restricted Project, Restricted Project

Aug 14 2022

Jimerlife updated the summary of D131870: [SelectionDAG][NFC] Fix return type when used isConstantIntBuildVectorOrConstantInt and isConstantFPBuildVectorOrConstantFP.
Aug 14 2022, 8:25 PM · Restricted Project, Restricted Project
Jimerlife requested review of D131870: [SelectionDAG][NFC] Fix return type when used isConstantIntBuildVectorOrConstantInt and isConstantFPBuildVectorOrConstantFP.
Aug 14 2022, 8:25 PM · Restricted Project, Restricted Project

Aug 11 2022

Jimerlife committed rG061f7ec9facf: [LegalizeTypes][NFC] Use getConstantOperandVal instead of cast constant getvalue (authored by Jimerlife).
[LegalizeTypes][NFC] Use getConstantOperandVal instead of cast constant getvalue
Aug 11 2022, 11:41 PM · Restricted Project, Restricted Project
Jimerlife closed D131642: [LegalizeTypes][NFC] Use getConstantOperandVal instead of cast constant getvalue..
Aug 11 2022, 11:41 PM · Restricted Project, Restricted Project
Jimerlife committed rG130305788891: [LegalizeTypes][NFC] Use dyn_cast instead of isa and cast (authored by Jimerlife).
[LegalizeTypes][NFC] Use dyn_cast instead of isa and cast
Aug 11 2022, 11:19 PM · Restricted Project, Restricted Project
Jimerlife closed D131544: [LegalizeTypes][NFC] Use dyn_cast instead of isa and cast..
Aug 11 2022, 11:19 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D131544: [LegalizeTypes][NFC] Use dyn_cast instead of isa and cast..

update and add const keyword

Aug 11 2022, 9:13 PM · Restricted Project, Restricted Project
Jimerlife added a comment to D131642: [LegalizeTypes][NFC] Use getConstantOperandVal instead of cast constant getvalue..

Only use getConstantOperandVal(Num) API instead of cast<ConstantSDNode>(N->getOperand(Num))->getZExtValue(). If We already have Idx, still keeping origin cast form. Thanks your suggestions @craig.topper @RKSimon.

Aug 11 2022, 8:07 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D131642: [LegalizeTypes][NFC] Use getConstantOperandVal instead of cast constant getvalue..

address comment

Aug 11 2022, 8:03 PM · Restricted Project, Restricted Project
Jimerlife committed rG3b71f1d5abaa: [LegalizeTypes][NFC] Use getConstantOperandAPInt instead of cast constant… (authored by Jimerlife).
[LegalizeTypes][NFC] Use getConstantOperandAPInt instead of cast constant…
Aug 11 2022, 7:22 PM · Restricted Project, Restricted Project
Jimerlife closed D131653: [LegalizeTypes][NFC] Use getConstantOperandAPInt instead of cast constant getAPInt.
Aug 11 2022, 7:22 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D131653: [LegalizeTypes][NFC] Use getConstantOperandAPInt instead of cast constant getAPInt.
Aug 11 2022, 3:03 AM · Restricted Project, Restricted Project

Aug 10 2022

Jimerlife requested review of D131653: [LegalizeTypes][NFC] Use getConstantOperandAPInt instead of cast constant getAPInt.
Aug 10 2022, 11:36 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D131642: [LegalizeTypes][NFC] Use getConstantOperandVal instead of cast constant getvalue..
Aug 10 2022, 8:27 PM · Restricted Project, Restricted Project
Jimerlife requested review of D131642: [LegalizeTypes][NFC] Use getConstantOperandVal instead of cast constant getvalue..
Aug 10 2022, 8:11 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D131544: [LegalizeTypes][NFC] Use dyn_cast instead of isa and cast..

address comment

Aug 10 2022, 6:43 PM · Restricted Project, Restricted Project

Aug 9 2022

Jimerlife requested review of D131544: [LegalizeTypes][NFC] Use dyn_cast instead of isa and cast..
Aug 9 2022, 11:59 PM · Restricted Project, Restricted Project

Aug 4 2022

Jimerlife committed rGb6b0690355cc: [LegalizeTypes][VP] Add split operand support for VP float and integer casting (authored by Jimerlife).
[LegalizeTypes][VP] Add split operand support for VP float and integer casting
Aug 4 2022, 12:53 AM · Restricted Project, Restricted Project
Jimerlife closed D130685: [LegalizeTypes][VP] Add split operand support for VP_FPTOSI/VP_FPTOUI/VP_SITOFP/VP_UITOFP.
Aug 4 2022, 12:53 AM · Restricted Project, Restricted Project

Aug 3 2022

Jimerlife updated the diff for D130685: [LegalizeTypes][VP] Add split operand support for VP_FPTOSI/VP_FPTOUI/VP_SITOFP/VP_UITOFP.

rebase to use new ISD name

Aug 3 2022, 2:56 AM · Restricted Project, Restricted Project

Aug 2 2022

Jimerlife updated the diff for D130685: [LegalizeTypes][VP] Add split operand support for VP_FPTOSI/VP_FPTOUI/VP_SITOFP/VP_UITOFP.

Move VP_SITOFP and VP_UITOFP to line 2728

Aug 2 2022, 2:01 AM · Restricted Project, Restricted Project
Jimerlife committed rGe208bab55fb1: [RISCV][NFC] Use defined variable instead some code. (authored by Jimerlife).
[RISCV][NFC] Use defined variable instead some code.
Aug 2 2022, 1:27 AM · Restricted Project, Restricted Project
Jimerlife closed D130687: [RISCV][NFC] Use defined variable instead some code..
Aug 2 2022, 1:27 AM · Restricted Project, Restricted Project
Jimerlife added inline comments to D130685: [LegalizeTypes][VP] Add split operand support for VP_FPTOSI/VP_FPTOUI/VP_SITOFP/VP_UITOFP.
Aug 2 2022, 1:19 AM · Restricted Project, Restricted Project

Jul 28 2022

Jimerlife requested review of D130687: [RISCV][NFC] Use defined variable instead some code..
Jul 28 2022, 1:06 AM · Restricted Project, Restricted Project
Jimerlife requested review of D130685: [LegalizeTypes][VP] Add split operand support for VP_FPTOSI/VP_FPTOUI/VP_SITOFP/VP_UITOFP.
Jul 28 2022, 12:08 AM · Restricted Project, Restricted Project

Jul 15 2022

Jimerlife committed rGdca821d80a41: [RISCV] Add cost model for vector.reverse mask operation (authored by Jimerlife).
[RISCV] Add cost model for vector.reverse mask operation
Jul 15 2022, 12:00 AM · Restricted Project, Restricted Project

Jul 14 2022

Jimerlife closed D128784: [RISCV] Add cost model for vector.reverse mask operation.
Jul 14 2022, 11:59 PM · Restricted Project, Restricted Project
Jimerlife added a comment to D128784: [RISCV] Add cost model for vector.reverse mask operation.

ping...

Jul 14 2022, 8:01 PM · Restricted Project, Restricted Project

Jul 8 2022

Jimerlife requested review of D129351: [RISCV] Add cost model for vector.splice mask operation.
Jul 8 2022, 12:46 AM · Restricted Project, Restricted Project

Jul 7 2022

Jimerlife committed rG9cfb28d672a3: [RISCV] Change VECTOR_SPLICE mask operation from expand to promote (authored by Jimerlife).
[RISCV] Change VECTOR_SPLICE mask operation from expand to promote
Jul 7 2022, 11:27 PM · Restricted Project, Restricted Project
Jimerlife closed D128717: [RISCV] Change VECTOR_SPLICE mask operation from expand to promote.
Jul 7 2022, 11:26 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D128717: [RISCV] Change VECTOR_SPLICE mask operation from expand to promote.

rebase main

Jul 7 2022, 7:34 PM · Restricted Project, Restricted Project
Jimerlife committed rG99da3115d1f5: [RISCV] Recommit test for D128717 (authored by Jimerlife).
[RISCV] Recommit test for D128717
Jul 7 2022, 7:24 PM · Restricted Project, Restricted Project
Jimerlife added a comment to D128778: [RISCV] Precommit test for D128717.

From https://llvm.org/docs/DeveloperPolicy.html:

  • The commit message for the reverting commit should explain why patch is being reverted.
Jul 7 2022, 7:14 PM · Restricted Project, Restricted Project
Jimerlife added a reverting change for rGb3b37f3ecfd6: [RISCV] Precommit test for D128717: rGab9e8a3a6f28: Revert "[RISCV] Precommit test for D128717".
Jul 7 2022, 6:57 PM · Restricted Project, Restricted Project
Jimerlife committed rGab9e8a3a6f28: Revert "[RISCV] Precommit test for D128717" (authored by Jimerlife).
Revert "[RISCV] Precommit test for D128717"
Jul 7 2022, 6:57 PM · Restricted Project, Restricted Project