Page MenuHomePhabricator

Jimerlife (WangLian)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 5 2022, 6:35 PM (25 w, 6 d)

Recent Activity

Tue, Jun 28

Jimerlife requested review of D128784: [RISCV] Add cost model for vector.reverse mask operation.
Tue, Jun 28, 11:35 PM · Restricted Project, Restricted Project
Jimerlife updated the summary of D128778: [RISCV] Precommit test for D128717.
Tue, Jun 28, 8:23 PM · Restricted Project, Restricted Project
Jimerlife updated the summary of D128717: [RISCV] Change VECTOR_SPLICE mask operation from expand to promote.
Tue, Jun 28, 8:13 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D128717: [RISCV] Change VECTOR_SPLICE mask operation from expand to promote.
Tue, Jun 28, 8:08 PM · Restricted Project, Restricted Project
Jimerlife added a comment to D128717: [RISCV] Change VECTOR_SPLICE mask operation from expand to promote.

Please land the new tests, and then rebase so that code changes are visible. (Unless this is fixing a crash, and then please clarify the commit message.)

Tue, Jun 28, 7:26 PM · Restricted Project, Restricted Project
Jimerlife requested review of D128778: [RISCV] Precommit test for D128717.
Tue, Jun 28, 7:24 PM · Restricted Project, Restricted Project
Jimerlife updated the summary of D128717: [RISCV] Change VECTOR_SPLICE mask operation from expand to promote.
Tue, Jun 28, 3:14 AM · Restricted Project, Restricted Project
Jimerlife requested review of D128717: [RISCV] Change VECTOR_SPLICE mask operation from expand to promote.
Tue, Jun 28, 3:13 AM · Restricted Project, Restricted Project
Jimerlife committed rG96ab083622f5: [RISCV] Support VECTOR_REVERSE mask operation. (authored by Jimerlife).
[RISCV] Support VECTOR_REVERSE mask operation.
Tue, Jun 28, 12:58 AM · Restricted Project, Restricted Project
Jimerlife closed D128627: [RISCV] Support VECTOR_REVERSE mask operation..
Tue, Jun 28, 12:58 AM · Restricted Project, Restricted Project
Jimerlife added a comment to D128627: [RISCV] Support VECTOR_REVERSE mask operation..

LGTM, but can you make sure to post a follow up patch to update cost model please?

Tue, Jun 28, 12:56 AM · Restricted Project, Restricted Project

Mon, Jun 27

Jimerlife requested review of D128627: [RISCV] Support VECTOR_REVERSE mask operation..
Mon, Jun 27, 2:06 AM · Restricted Project, Restricted Project

Thu, Jun 23

Jimerlife committed rG1ce30457c15a: [LegalizeTypes][NFC] Add an assert to WidenVecRes_EXTRACT_SUBVECTOR and adjust… (authored by Jimerlife).
[LegalizeTypes][NFC] Add an assert to WidenVecRes_EXTRACT_SUBVECTOR and adjust…
Thu, Jun 23, 8:07 PM · Restricted Project, Restricted Project
Jimerlife closed D128038: [LegalizeTypes][NFC] Add an assert to WidenVecRes_EXTRACT_SUBVECTOR and adjust some code.
Thu, Jun 23, 8:06 PM · Restricted Project, Restricted Project
Jimerlife committed rG770fe864feb3: [SelectionDAG] Enable WidenVecOp_VECREDUCE for scalable vector (authored by Jimerlife).
[SelectionDAG] Enable WidenVecOp_VECREDUCE for scalable vector
Thu, Jun 23, 7:44 PM · Restricted Project, Restricted Project
Jimerlife closed D128239: [SelectionDAG] Enable WidenVecOp_VECREDUCE for scalable vector.
Thu, Jun 23, 7:44 PM · Restricted Project, Restricted Project

Mon, Jun 20

Jimerlife requested review of D128239: [SelectionDAG] Enable WidenVecOp_VECREDUCE for scalable vector.
Mon, Jun 20, 7:39 PM · Restricted Project, Restricted Project

Sun, Jun 19

Jimerlife committed rGab25e263a99b: [SelectionDAG] Enable WidenVecOp_VECREDUCE_SEQ for scalable vector (authored by Jimerlife).
[SelectionDAG] Enable WidenVecOp_VECREDUCE_SEQ for scalable vector
Sun, Jun 19, 11:31 PM · Restricted Project, Restricted Project
Jimerlife closed D127710: [SelectionDAG] Enable WidenVecOp_VECREDUCE_SEQ for scalable vector.
Sun, Jun 19, 11:31 PM · Restricted Project, Restricted Project

Fri, Jun 17

Jimerlife requested review of D128038: [LegalizeTypes][NFC] Add an assert to WidenVecRes_EXTRACT_SUBVECTOR and adjust some code.
Fri, Jun 17, 2:29 AM · Restricted Project, Restricted Project

Thu, Jun 16

Jimerlife committed rGf2bcf330588b: [LegalizeTypes][NFC] Merge promote SPLAT_VECTOR and promote SCALAR_TO_VECTOR to… (authored by Jimerlife).
[LegalizeTypes][NFC] Merge promote SPLAT_VECTOR and promote SCALAR_TO_VECTOR to…
Thu, Jun 16, 7:44 PM · Restricted Project, Restricted Project
Jimerlife closed D127825: [LegalizeTypes][NFC] Merge promote SPLAT_VECTOR and promote SCALAR_TO_VECTOR to one function.
Thu, Jun 16, 7:44 PM · Restricted Project, Restricted Project
Jimerlife committed rG16215eb9790a: [LegalizeTypes][RISCV][NFC] Modify assert in PromoteIntRes_STEP_VECTOR and add… (authored by Jimerlife).
[LegalizeTypes][RISCV][NFC] Modify assert in PromoteIntRes_STEP_VECTOR and add…
Thu, Jun 16, 7:28 PM · Restricted Project, Restricted Project
Jimerlife closed D127939: [LegalizeTypes][RISCV][NFC] Modify assert in PromoteIntRes_STEP_VECTOR and add some tests for RISCV.
Thu, Jun 16, 7:28 PM · Restricted Project, Restricted Project
Jimerlife committed rG5e16a781bada: [RISCV][NFC][test] Correct a wrong test in vreductions-fp-vp.ll (authored by Jimerlife).
[RISCV][NFC][test] Correct a wrong test in vreductions-fp-vp.ll
Thu, Jun 16, 7:25 PM · Restricted Project, Restricted Project
Jimerlife closed D127946: [RISCV][NFC][test] Correct a wrong test in vreductions-fp-vp.ll.
Thu, Jun 16, 7:24 PM · Restricted Project, Restricted Project
Jimerlife added inline comments to D127939: [LegalizeTypes][RISCV][NFC] Modify assert in PromoteIntRes_STEP_VECTOR and add some tests for RISCV.
Thu, Jun 16, 2:24 AM · Restricted Project, Restricted Project
Jimerlife requested review of D127946: [RISCV][NFC][test] Correct a wrong test in vreductions-fp-vp.ll.
Thu, Jun 16, 1:14 AM · Restricted Project, Restricted Project
Jimerlife added inline comments to D127939: [LegalizeTypes][RISCV][NFC] Modify assert in PromoteIntRes_STEP_VECTOR and add some tests for RISCV.
Thu, Jun 16, 12:48 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D127939: [LegalizeTypes][RISCV][NFC] Modify assert in PromoteIntRes_STEP_VECTOR and add some tests for RISCV.
Thu, Jun 16, 12:47 AM · Restricted Project, Restricted Project
Jimerlife added inline comments to D127939: [LegalizeTypes][RISCV][NFC] Modify assert in PromoteIntRes_STEP_VECTOR and add some tests for RISCV.
Thu, Jun 16, 12:33 AM · Restricted Project, Restricted Project
Jimerlife added inline comments to D127710: [SelectionDAG] Enable WidenVecOp_VECREDUCE_SEQ for scalable vector.
Thu, Jun 16, 12:27 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D127710: [SelectionDAG] Enable WidenVecOp_VECREDUCE_SEQ for scalable vector.

address comment and add test for AArch64 SVE

Thu, Jun 16, 12:25 AM · Restricted Project, Restricted Project

Wed, Jun 15

Jimerlife requested review of D127939: [LegalizeTypes][RISCV][NFC] Modify assert in PromoteIntRes_STEP_VECTOR and add some tests for RISCV.
Wed, Jun 15, 11:12 PM · Restricted Project, Restricted Project
Jimerlife added inline comments to D127710: [SelectionDAG] Enable WidenVecOp_VECREDUCE_SEQ for scalable vector.
Wed, Jun 15, 7:45 AM · Restricted Project, Restricted Project

Tue, Jun 14

Jimerlife requested review of D127825: [LegalizeTypes][NFC] Merge promote SPLAT_VECTOR and promote SCALAR_TO_VECTOR to one function.
Tue, Jun 14, 11:18 PM · Restricted Project, Restricted Project
Jimerlife added inline comments to D127710: [SelectionDAG] Enable WidenVecOp_VECREDUCE_SEQ for scalable vector.
Tue, Jun 14, 7:34 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D127710: [SelectionDAG] Enable WidenVecOp_VECREDUCE_SEQ for scalable vector.

address comment

Tue, Jun 14, 7:30 PM · Restricted Project, Restricted Project
Jimerlife added inline comments to D127710: [SelectionDAG] Enable WidenVecOp_VECREDUCE_SEQ for scalable vector.
Tue, Jun 14, 7:25 PM · Restricted Project, Restricted Project

Mon, Jun 13

Jimerlife requested review of D127710: [SelectionDAG] Enable WidenVecOp_VECREDUCE_SEQ for scalable vector.
Mon, Jun 13, 8:40 PM · Restricted Project, Restricted Project

Thu, Jun 9

Jimerlife committed rG91e31fd2056a: [RISCV][VP] Add fp test of widen and split for vp.setcc (authored by Jimerlife).
[RISCV][VP] Add fp test of widen and split for vp.setcc
Thu, Jun 9, 1:14 AM · Restricted Project, Restricted Project
Jimerlife closed D127079: [RISCV][VP] Add fp test of widen and split for vp.setcc.
Thu, Jun 9, 1:14 AM · Restricted Project, Restricted Project
Jimerlife committed rG362a02dabe7b: [RISCV][test] Add widen STEP_VECTOR tests. (authored by Jimerlife).
[RISCV][test] Add widen STEP_VECTOR tests.
Thu, Jun 9, 12:47 AM · Restricted Project, Restricted Project
Jimerlife closed D127371: [RISCV][test] Add widen STEP_VECTOR tests..
Thu, Jun 9, 12:47 AM · Restricted Project, Restricted Project

Wed, Jun 8

Jimerlife requested review of D127371: [RISCV][test] Add widen STEP_VECTOR tests..
Wed, Jun 8, 6:51 PM · Restricted Project, Restricted Project

Jun 5 2022

Jimerlife requested review of D127079: [RISCV][VP] Add fp test of widen and split for vp.setcc.
Jun 5 2022, 8:20 PM · Restricted Project, Restricted Project
Jimerlife committed rG20cf77f776b1: [LegalizeTypes][VP] Add widen and split support for vp.fptrunc and vp.fpext (authored by Jimerlife).
[LegalizeTypes][VP] Add widen and split support for vp.fptrunc and vp.fpext
Jun 5 2022, 7:28 PM · Restricted Project, Restricted Project
Jimerlife closed D126439: [LegalizeTypes][VP] Add widen and split support for vp.fptrunc and vp.fpext.
Jun 5 2022, 7:28 PM · Restricted Project, Restricted Project
Jimerlife added inline comments to D126439: [LegalizeTypes][VP] Add widen and split support for vp.fptrunc and vp.fpext.
Jun 5 2022, 7:22 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D126439: [LegalizeTypes][VP] Add widen and split support for vp.fptrunc and vp.fpext.

address comment

Jun 5 2022, 7:20 PM · Restricted Project, Restricted Project

May 29 2022

Jimerlife committed rG967ef4ad0afc: [NFC][VP] Fix llvm.vp.merge intrinsic Expansion in LangRef (authored by Jimerlife).
[NFC][VP] Fix llvm.vp.merge intrinsic Expansion in LangRef
May 29 2022, 6:48 PM · Restricted Project, Restricted Project
Jimerlife closed D126457: [NFC][VP] Fix llvm.vp.merge intrinsic Expansion in LangRef.
May 29 2022, 6:48 PM · Restricted Project, Restricted Project

May 26 2022

Jimerlife requested review of D126457: [NFC][VP] Fix llvm.vp.merge intrinsic Expansion in LangRef.
May 26 2022, 3:30 AM · Restricted Project, Restricted Project
Jimerlife abandoned D126448: [NFC][LegalizeTypes][VP] Refactor code in SplitRes_Select.
May 26 2022, 3:21 AM · Restricted Project, Restricted Project
Jimerlife added a comment to D126448: [NFC][LegalizeTypes][VP] Refactor code in SplitRes_Select.

I don't understand the motivation for this change. LLVM coding guidelines encourage using early returns.

May 26 2022, 3:21 AM · Restricted Project, Restricted Project
Jimerlife requested review of D126448: [NFC][LegalizeTypes][VP] Refactor code in SplitRes_Select.
May 26 2022, 12:01 AM · Restricted Project, Restricted Project

May 25 2022

Jimerlife requested review of D126439: [LegalizeTypes][VP] Add widen and split support for vp.fptrunc and vp.fpext.
May 25 2022, 7:54 PM · Restricted Project, Restricted Project
Jimerlife committed rG8aa6b05deb2a: [LegalizeTypes][VP] Add widen and split support for VP_TRUNCATE (authored by Jimerlife).
[LegalizeTypes][VP] Add widen and split support for VP_TRUNCATE
May 25 2022, 7:04 PM · Restricted Project, Restricted Project
Jimerlife closed D125950: [LegalizeTypes][VP] Add widen and split support for VP_TRUNCATE.
May 25 2022, 7:03 PM · Restricted Project, Restricted Project

May 24 2022

Jimerlife added inline comments to D125950: [LegalizeTypes][VP] Add widen and split support for VP_TRUNCATE.
May 24 2022, 7:38 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125950: [LegalizeTypes][VP] Add widen and split support for VP_TRUNCATE.

rebase and address comment

May 24 2022, 7:34 PM · Restricted Project, Restricted Project
Jimerlife abandoned D126275: [LegalizeTypes][VP] Add integer promote support for vp.gather and vp.scatter.
May 24 2022, 6:42 PM · Restricted Project, Restricted Project
Jimerlife committed rGbe84f91f87a7: [LegalizeTypes][VP] Fix OpNo in WidenVecOp_VP_SCATTER (authored by Jimerlife).
[LegalizeTypes][VP] Fix OpNo in WidenVecOp_VP_SCATTER
May 24 2022, 12:39 AM · Restricted Project, Restricted Project
Jimerlife closed D126276: [LegalizeTypes][VP] Fix OpNo in WidenVecOp_VP_SCATTER.
May 24 2022, 12:38 AM · Restricted Project, Restricted Project
Jimerlife added inline comments to D126275: [LegalizeTypes][VP] Add integer promote support for vp.gather and vp.scatter.
May 24 2022, 12:34 AM · Restricted Project, Restricted Project

May 23 2022

Jimerlife requested review of D126276: [LegalizeTypes][VP] Fix OpNo in WidenVecOp_VP_SCATTER.
May 23 2022, 11:34 PM · Restricted Project, Restricted Project
Jimerlife requested review of D126275: [LegalizeTypes][VP] Add integer promote support for vp.gather and vp.scatter.
May 23 2022, 11:13 PM · Restricted Project, Restricted Project

May 20 2022

Jimerlife added inline comments to D125950: [LegalizeTypes][VP] Add widen and split support for VP_TRUNCATE.
May 20 2022, 12:05 AM · Restricted Project, Restricted Project

May 19 2022

Jimerlife updated the diff for D125950: [LegalizeTypes][VP] Add widen and split support for VP_TRUNCATE.

rebase and address comment

May 19 2022, 11:52 PM · Restricted Project, Restricted Project
Jimerlife committed rG530bab1f93da: [RISCV][SelectionDAG] Support VECREDUCE_ADD mask operation (authored by Jimerlife).
[RISCV][SelectionDAG] Support VECREDUCE_ADD mask operation
May 19 2022, 2:57 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125206: [RISCV][SelectionDAG] Support VECREDUCE_ADD mask operation.

update for re-landed

May 19 2022, 2:55 AM · Restricted Project, Restricted Project
Jimerlife abandoned D125310: [AArch64][RISCV][SelectionDAG] Support VECREDUCE_ADD mask operations.
May 19 2022, 1:07 AM · Restricted Project, Restricted Project
Jimerlife added a comment to D125310: [AArch64][RISCV][SelectionDAG] Support VECREDUCE_ADD mask operations.

Given this all started by the revert of D125206 and the reason it was reverted has now been resolved, perhaps you should just re-land D125206?

May 19 2022, 1:07 AM · Restricted Project, Restricted Project
Jimerlife committed rGf035068bb3cf: [LegalizeVectorTypes][VP] Add widen and split support for VP_SETCC (authored by Jimerlife).
[LegalizeVectorTypes][VP] Add widen and split support for VP_SETCC
May 19 2022, 12:54 AM · Restricted Project, Restricted Project
Jimerlife closed D125446: [LegalizeVectorTypes][VP] Add widen and split support for VP_SETCC.
May 19 2022, 12:54 AM · Restricted Project, Restricted Project
Jimerlife committed rGbbc6834e2635: [LegalizeTypes][VP] Add integer promotions support for VP_TRUNCATE (authored by Jimerlife).
[LegalizeTypes][VP] Add integer promotions support for VP_TRUNCATE
May 19 2022, 12:38 AM · Restricted Project, Restricted Project
Jimerlife closed D125739: [LegalizeTypes][VP] Add integer promotions support for VP_TRUNCATE.
May 19 2022, 12:38 AM · Restricted Project, Restricted Project
Jimerlife committed rG993070d11f16: [LegalizeTypes][VP][NFC] Use an if and two returns instead of ?: operator (authored by Jimerlife).
[LegalizeTypes][VP][NFC] Use an if and two returns instead of ?: operator
May 19 2022, 12:21 AM · Restricted Project, Restricted Project
Jimerlife closed D125858: [LegalizeTypes][VP][NFC] Use an if and two returns instead of ?: operator.
May 19 2022, 12:21 AM · Restricted Project, Restricted Project
Jimerlife requested review of D125950: [LegalizeTypes][VP] Add widen and split support for VP_TRUNCATE.
May 19 2022, 12:16 AM · Restricted Project, Restricted Project

May 18 2022

Jimerlife requested review of D125858: [LegalizeTypes][VP][NFC] Use an if and two returns instead of ?: operator.
May 18 2022, 12:49 AM · Restricted Project, Restricted Project

May 17 2022

Jimerlife added a comment to D125310: [AArch64][RISCV][SelectionDAG] Support VECREDUCE_ADD mask operations.

Please go ahead and land the new tests, and then rebase so that changes in codegen are visible in review. Also, please rebase over the mentioned Aarch64 review. The test diff there currently looks like a regression because you haven't stacked the changes which was confusing at first.

The submission comment needs improved to describe what this is actually doing.

The patch seems generally reasonable. Once the above are done, should be an easy LGTM.

Thanks for your advice. After I rebased main, this patch no longer affect AArch64 tests.

May 17 2022, 11:53 PM · Restricted Project, Restricted Project
Jimerlife added inline comments to D125446: [LegalizeVectorTypes][VP] Add widen and split support for VP_SETCC.
May 17 2022, 7:03 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125446: [LegalizeVectorTypes][VP] Add widen and split support for VP_SETCC.

rebase and address comment

May 17 2022, 7:02 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125525: [LegalizeTypes][VP] Add integer promotion support for VP_SIGN_EXTEND and VP_ZERO_EXTEND.
May 17 2022, 2:38 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125525: [LegalizeTypes][VP] Add integer promotion support for VP_SIGN_EXTEND and VP_ZERO_EXTEND.
May 17 2022, 2:15 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125525: [LegalizeTypes][VP] Add integer promotion support for VP_SIGN_EXTEND and VP_ZERO_EXTEND.
May 17 2022, 2:06 AM · Restricted Project, Restricted Project
Jimerlife added inline comments to D125446: [LegalizeVectorTypes][VP] Add widen and split support for VP_SETCC.
May 17 2022, 1:38 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125446: [LegalizeVectorTypes][VP] Add widen and split support for VP_SETCC.
May 17 2022, 1:36 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125739: [LegalizeTypes][VP] Add integer promotions support for VP_TRUNCATE.
May 17 2022, 12:46 AM · Restricted Project, Restricted Project
Jimerlife added inline comments to D125739: [LegalizeTypes][VP] Add integer promotions support for VP_TRUNCATE.
May 17 2022, 12:22 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125739: [LegalizeTypes][VP] Add integer promotions support for VP_TRUNCATE.

Address comments

May 17 2022, 12:20 AM · Restricted Project, Restricted Project

May 16 2022

Jimerlife retitled D125739: [LegalizeTypes][VP] Add integer promotions support for VP_TRUNCATE from [LegalizeTypes][VP] Add promotions for VP_TRUNCATE to [LegalizeTypes][VP] Add integer promotions support for VP_TRUNCATE.
May 16 2022, 8:22 PM · Restricted Project, Restricted Project
Jimerlife requested review of D125739: [LegalizeTypes][VP] Add integer promotions support for VP_TRUNCATE.
May 16 2022, 8:05 PM · Restricted Project, Restricted Project
Jimerlife added a comment to D125310: [AArch64][RISCV][SelectionDAG] Support VECREDUCE_ADD mask operations.

Please go ahead and land the new tests, and then rebase so that changes in codegen are visible in review. Also, please rebase over the mentioned Aarch64 review. The test diff there currently looks like a regression because you haven't stacked the changes which was confusing at first.

The submission comment needs improved to describe what this is actually doing.

The patch seems generally reasonable. Once the above are done, should be an easy LGTM.

May 16 2022, 7:20 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125310: [AArch64][RISCV][SelectionDAG] Support VECREDUCE_ADD mask operations.

rebase main. After D125605 landed, this patch will no longer negatively affect AArch64 code generation.

May 16 2022, 7:08 PM · Restricted Project, Restricted Project
Jimerlife added inline comments to D125446: [LegalizeVectorTypes][VP] Add widen and split support for VP_SETCC.
May 16 2022, 12:31 AM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125446: [LegalizeVectorTypes][VP] Add widen and split support for VP_SETCC.

add splitOp and splitRes for vp.setcc

May 16 2022, 12:30 AM · Restricted Project, Restricted Project

May 15 2022

Jimerlife added inline comments to D125310: [AArch64][RISCV][SelectionDAG] Support VECREDUCE_ADD mask operations.
May 15 2022, 7:35 PM · Restricted Project, Restricted Project
Jimerlife updated the diff for D125310: [AArch64][RISCV][SelectionDAG] Support VECREDUCE_ADD mask operations.

address comment

May 15 2022, 7:34 PM · Restricted Project, Restricted Project