This is an archive of the discontinued LLVM Phabricator instance.

[clang][AArc64][SVE] Add support for comparison operators on SVE types
ClosedPublic

Authored by DavidTruby on Mar 24 2022, 7:59 AM.

Details

Summary

Comparison operators on SVE types return a signed integer vector
of the same width as the incoming SVE type. This matches the existing
behaviour for NEON types.

Diff Detail

Event Timeline

DavidTruby created this revision.Mar 24 2022, 7:59 AM
Herald added a project: Restricted Project. · View Herald Transcript
DavidTruby requested review of this revision.Mar 24 2022, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 7:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
peterwaller-arm accepted this revision.Mar 30 2022, 2:16 AM

LGTM, looks like the formatter might have hit some lines you didn't intend to change -- if it's not too invasive perhaps worth a seperate NFC patch to format the file?

clang/lib/Sema/SemaExpr.cpp
13084–13091

Unintended whitespace changes?

This revision is now accepted and ready to land.Mar 30 2022, 2:16 AM
Matt added a subscriber: Matt.Mar 31 2022, 9:29 AM