Page MenuHomePhabricator

[RISCV] SMUL_LOHI/UMUL_LOHI should expand for RVV.
ClosedPublic

Authored by craig.topper on Fri, Nov 5, 4:02 PM.

Details

Summary

These and MULHS/MULHU both default to Legal. Targets need to set
the ones they don't support to Expand.

I think MULHS/MULHU likely has priority in most places so this
change probably isn't directly testable. I found it while looking
at disabling MULHS/MULHU for nxvXi64 as required for Zve64x.

Diff Detail

Event Timeline

craig.topper created this revision.Fri, Nov 5, 4:02 PM
craig.topper requested review of this revision.Fri, Nov 5, 4:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Nov 5, 4:02 PM
Herald added a subscriber: MaskRay. · View Herald Transcript

Do we want to do the same for fixed-length vectors?

Do we want to do the same for fixed-length vectors?

Fixed length vectors has a loop that sets every opcode to Expand.

frasercrmck accepted this revision.Mon, Nov 8, 8:40 AM

Do we want to do the same for fixed-length vectors?

Fixed length vectors has a loop that sets every opcode to Expand.

So we do, my bad. LGTM.

This revision is now accepted and ready to land.Mon, Nov 8, 8:40 AM
This revision was automatically updated to reflect the committed changes.