Page MenuHomePhabricator
Differential D108999

[RISCV][VP] Custom lower VP_STORE and VP_LOAD
ClosedPublic
Actions

Authored by frasercrmck on Aug 31 2021, 8:01 AM.

Details

Reviewers
craig.topper
HsiangKai
rogfer01
evandro
Commits
rGa823bdf3ab78: [RISCV][VP] Custom lower VP_STORE and VP_LOAD
Summary

This patch adds support for the vector-predicated VP_STORE and
VP_LOAD nodes. We do this in the same way we lower MSTORE and
MLOAD: to regular load/store instructions via intrinsics.

One necessary change was made to SelectionDAGLegalize so that
VP_STORE nodes' operation actions are taken from the stored "value"
operands, in the same vein as STORE or MSTORE.

Diff Detail

Unit TestsFailed
View All

TimeTest
12,420 msx64 debian > libarcher.races::task-taskwait-nested.c
Script: -- : 'RUN: at line 13'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests -I /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/runtime/src -L /var/lib/buildkite-agent/builds/llvm-project/build/lib -Wl,-rpath,/var/lib/buildkite-agent/builds/llvm-project/build/lib /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/task-taskwait-nested.c -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/task-taskwait-nested.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/deflake.bash /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/task-taskwait-nested.c.tmp 2>&1 | tee /var/lib/buildkite-agent/builds/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/task-taskwait-nested.c.tmp.log | /var/lib/buildkite-agent/builds/llvm-project/build/./bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/openmp/tools/archer/tests/races/task-taskwait-nested.c

Event Timeline

frasercrmck created this revision.Aug 31 2021, 8:01 AM
Herald added subscribers: vkmr, rogfer01, evandro and 24 others. · View Herald TranscriptAug 31 2021, 8:01 AM
frasercrmck requested review of this revision.Aug 31 2021, 8:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2021, 8:01 AM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
frasercrmck added a parent revision: D108987: [RISCV][VP] Custom lower VP_SCATTER and VP_GATHER.Aug 31 2021, 8:02 AM
Harbormaster completed remote builds in B121934: Diff 369700.Aug 31 2021, 8:02 AM
frasercrmck added reviewers: craig.topper, HsiangKai, rogfer01, evandro.Aug 31 2021, 8:03 AM
frasercrmck retitled this revision from [RISCV] Custom lower VP_STORE and VP_LOAD to [RISCV][VP] Custom lower VP_STORE and VP_LOAD.
frasercrmck updated this revision to Diff 369705.Aug 31 2021, 8:11 AM
  • rebase
Harbormaster completed remote builds in B121938: Diff 369705.Aug 31 2021, 8:54 AM
rogfer01 accepted this revision.Sep 1 2021, 11:23 PM

LGTM. Thanks @frasercrmck !

This revision is now accepted and ready to land.Sep 1 2021, 11:23 PM
frasercrmck updated this revision to Diff 370212.Sep 2 2021, 2:50 AM
  • remove IsVP in a similar vein to D108987
Harbormaster completed remote builds in B122268: Diff 370212.Sep 2 2021, 3:26 AM
frasercrmck updated this revision to Diff 370885.Sep 6 2021, 3:43 AM
  • rebase
  • use common MemSDNode base
Harbormaster completed remote builds in B122740: Diff 370885.Sep 6 2021, 4:23 AM
craig.topper accepted this revision.Sep 6 2021, 10:28 AM

LGTM

This revision was landed with ongoing or failed builds.Sep 7 2021, 3:03 AM
Closed by commit rGa823bdf3ab78: [RISCV][VP] Custom lower VP_STORE and VP_LOAD (authored by frasercrmck). · Explain Why
This revision was automatically updated to reflect the committed changes.
frasercrmck added a commit: rGa823bdf3ab78: [RISCV][VP] Custom lower VP_STORE and VP_LOAD.
craig.topper mentioned this in D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.Sep 7 2021, 1:20 PM

Revision Contents
Changeset List

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
5 lines
Target/
RISCV/
4 lines
109 lines
test/
CodeGen/
RISCV/
rvv/
257 lines
257 lines
341 lines
341 lines

Diff 369705

View Options

llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

Loading...
View Options

llvm/lib/Target/RISCV/RISCVISelLowering.h

Loading...
View Options

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Loading...
View Options

llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vpload.ll

Loading...
View Options

llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vpstore.ll

Loading...
View Options

llvm/test/CodeGen/RISCV/rvv/vpload.ll

Loading...
View Options

llvm/test/CodeGen/RISCV/rvv/vpstore.ll

Loading...