Page MenuHomePhabricator

hussainjk (Hussain Kadhem)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 11 2019, 11:36 AM (137 w, 3 d)

Recent Activity

Sep 10 2021

hussainjk updated the diff for D109379: Implementation of PPC lowering for vp_load/vp_store with no mask.

Fixed tests incorrectly using zeroinitializer instead of undef for %evl, causing it to be ignored.

Sep 10 2021, 8:13 PM · Restricted Project
hussainjk updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..

More fixes to the length-only scalarization, and added tests using the Power8 target for this scalarization.

Sep 10 2021, 6:52 PM · Restricted Project, Restricted Project, Restricted Project
hussainjk updated the diff for D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.

Addressing review comments.

Sep 10 2021, 11:03 AM · Restricted Project, Restricted Project
hussainjk added inline comments to D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.
Sep 10 2021, 10:48 AM · Restricted Project, Restricted Project
hussainjk updated the diff for D109584: [VP] Implementing expansion pass for VP load and store..

Fixing errors that were introduced from rebasing.

Sep 10 2021, 10:29 AM · Restricted Project, Restricted Project, Restricted Project
hussainjk updated the summary of D109584: [VP] Implementing expansion pass for VP load and store..
Sep 10 2021, 2:00 AM · Restricted Project, Restricted Project, Restricted Project
hussainjk requested review of D109584: [VP] Implementing expansion pass for VP load and store..
Sep 10 2021, 1:58 AM · Restricted Project, Restricted Project, Restricted Project

Sep 9 2021

hussainjk retitled D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE from Integer type legalization for vp_load and vp_store. to type legalization for vp_load and vp_store..
Sep 9 2021, 11:32 PM · Restricted Project, Restricted Project
hussainjk updated the diff for D109379: Implementation of PPC lowering for vp_load/vp_store with no mask.

Expanded LIT tests with a lot more cases, including vector splitting.

Sep 9 2021, 11:31 PM · Restricted Project
hussainjk updated the diff for D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.

More assertion fixes.

Sep 9 2021, 11:22 PM · Restricted Project, Restricted Project
hussainjk updated the diff for D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.

Addressing review comments.

Sep 9 2021, 10:15 PM · Restricted Project, Restricted Project
hussainjk updated the diff for D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.

Added more legalization to this patch rather than putting it into another patch. Added another form of getLoadVP that was needed by the legalization. Expanded tests to cover vector splitting.

Sep 9 2021, 9:56 PM · Restricted Project, Restricted Project
hussainjk updated the diff for D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.

Adding tests using RISCV lowering

Sep 9 2021, 10:54 AM · Restricted Project, Restricted Project
hussainjk updated the diff for D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.

Fixing some miner logic issues.

Sep 9 2021, 10:51 AM · Restricted Project, Restricted Project

Sep 8 2021

hussainjk updated the diff for D109379: Implementation of PPC lowering for vp_load/vp_store with no mask.

Putting back accidentally-deleted test file.

Sep 8 2021, 2:48 PM · Restricted Project
hussainjk updated the diff for D109379: Implementation of PPC lowering for vp_load/vp_store with no mask.

Fixing some arc errors when making the patch.

Sep 8 2021, 2:25 PM · Restricted Project

Sep 7 2021

hussainjk added reviewers for D109417: Cost model for VPMemory operations on PowerPC.: bmahjour, nemanjai, simoll.
Sep 7 2021, 9:35 PM · Restricted Project
hussainjk requested review of D109417: Cost model for VPMemory operations on PowerPC..
Sep 7 2021, 9:34 PM · Restricted Project
hussainjk added reviewers for D109416: getVPMemoryOpCost interface: simoll, craig.topper.
Sep 7 2021, 9:32 PM · Restricted Project
hussainjk requested review of D109416: getVPMemoryOpCost interface.
Sep 7 2021, 9:30 PM · Restricted Project
hussainjk added a comment to D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.

Tests?

Sep 7 2021, 12:57 PM · Restricted Project, Restricted Project
hussainjk updated the diff for D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.

Addressing review comments.

Sep 7 2021, 12:48 PM · Restricted Project, Restricted Project
hussainjk added reviewers for D109379: Implementation of PPC lowering for vp_load/vp_store with no mask: bmahjour, nemanjai, simoll.
Sep 7 2021, 10:37 AM · Restricted Project
hussainjk requested review of D109379: Implementation of PPC lowering for vp_load/vp_store with no mask.
Sep 7 2021, 10:36 AM · Restricted Project
hussainjk added reviewers for D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE: simoll, frasercrmck, bmahjour.
Sep 7 2021, 10:29 AM · Restricted Project, Restricted Project
hussainjk requested review of D109377: [SelectionDAG] Support integer promotion for VP_LOAD and VP_STORE.
Sep 7 2021, 10:27 AM · Restricted Project, Restricted Project

Aug 30 2021

hussainjk added a comment to D105871: implementation of sdag support for VP memory intrinsics.

@simoll Do you mind merging this one in as well?

Aug 30 2021, 11:28 AM · Restricted Project, Restricted Project
hussainjk retitled D105871: implementation of sdag support for VP memory intrinsics from implementation of sdag support for vp load/store/gather/scatter. to implementation of sdag support for VP memory intrinsics.
Aug 30 2021, 11:26 AM · Restricted Project, Restricted Project
hussainjk retitled D105871: implementation of sdag support for VP memory intrinsics from Followup to D99355: implementation of sdag support for vp load/store/gather/scatter. to implementation of sdag support for vp load/store/gather/scatter..
Aug 30 2021, 11:25 AM · Restricted Project, Restricted Project
hussainjk updated the diff for D105871: implementation of sdag support for VP memory intrinsics.

Addressing review comment.

Aug 30 2021, 11:22 AM · Restricted Project, Restricted Project

Aug 27 2021

hussainjk updated the diff for D105871: implementation of sdag support for VP memory intrinsics.

Addressing review comments.

Aug 27 2021, 10:04 AM · Restricted Project, Restricted Project

Aug 18 2021

hussainjk added a comment to D105871: implementation of sdag support for VP memory intrinsics.

@simoll @frasercrmck All the mentioned tests are now passing, and I don't think there are any other outstanding issues. Are we good to accept and merge?

Aug 18 2021, 9:15 AM · Restricted Project, Restricted Project

Aug 16 2021

hussainjk updated the diff for D105871: implementation of sdag support for VP memory intrinsics.

Addressing review comments.

Aug 16 2021, 12:18 PM · Restricted Project, Restricted Project

Aug 12 2021

hussainjk updated the diff for D105871: implementation of sdag support for VP memory intrinsics.

Addressing review comments.

Aug 12 2021, 10:39 AM · Restricted Project, Restricted Project

Aug 10 2021

hussainjk updated the diff for D105871: implementation of sdag support for VP memory intrinsics.

Addressing reviews: adding some missing cases for predicated gather/scatter.

Aug 10 2021, 6:43 PM · Restricted Project, Restricted Project

Aug 3 2021

hussainjk updated the diff for D105871: implementation of sdag support for VP memory intrinsics.

Addressing review comments: extending SDBuilder::VisitVectorPredicationIntrinsic.

Aug 3 2021, 10:20 AM · Restricted Project, Restricted Project

Jul 29 2021

hussainjk updated the diff for D105871: implementation of sdag support for VP memory intrinsics.

Addressing review comments: updating sdnodes with indexing, expanding, compressing support; bringing in line with load/store sdnodes.

Jul 29 2021, 10:54 PM · Restricted Project, Restricted Project

Jul 27 2021

hussainjk added a comment to D105871: implementation of sdag support for VP memory intrinsics.

This patch also needs to extend SelectionDAGBuilder to custom-build the "mem" nodes from the intrinsics. Otherwise we won't be creating the SDNodes correctly, e.g. there'll be an invalid MachineMemOperand.

Jul 27 2021, 7:00 PM · Restricted Project, Restricted Project

Jul 12 2021

hussainjk added reviewers for D105871: implementation of sdag support for VP memory intrinsics: simoll, craig.topper, vkmr.
Jul 12 2021, 10:36 PM · Restricted Project, Restricted Project
hussainjk requested review of D105871: implementation of sdag support for VP memory intrinsics.
Jul 12 2021, 10:31 PM · Restricted Project, Restricted Project

Jun 30 2021

hussainjk added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

One more thing: title & summary do not reflect what's in the patch anymore. Please update those too.

Jun 30 2021, 8:52 AM · Restricted Project, Restricted Project
hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

addressing review comments

Jun 30 2021, 8:40 AM · Restricted Project, Restricted Project

Jun 29 2021

hussainjk added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

I rebased, fixed some failing unit tests, and extended VPIntrinsic::getDeclarationForParams to handle memory intrins. Not sure if I got arc to properly pick everything up.

Jun 29 2021, 3:17 PM · Restricted Project, Restricted Project
hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

rebasing

Jun 29 2021, 3:14 PM · Restricted Project, Restricted Project
hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

rebasing

Jun 29 2021, 3:11 PM · Restricted Project, Restricted Project
hussainjk requested review of D105157: Fixed unit test typo in declarations..
Jun 29 2021, 3:09 PM · Restricted Project

Jun 10 2021

hussainjk added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

I don't have commit access. Can someone commit this please?

Jun 10 2021, 2:32 PM · Restricted Project, Restricted Project
hussainjk added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

I believe I've addressed everything now.

Jun 10 2021, 10:25 AM · Restricted Project, Restricted Project
hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

addressing review comments

Jun 10 2021, 9:50 AM · Restricted Project, Restricted Project

Jun 8 2021

hussainjk added inline comments to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..
Jun 8 2021, 10:24 AM · Restricted Project, Restricted Project
hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

addressing review comments

Jun 8 2021, 10:22 AM · Restricted Project, Restricted Project

May 27 2021

hussainjk added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

I had a thought about alignment. Do we have a plan on how to deal with unaligned accesses?

Not yet

The other non-VP masked intrinsics are scalarized by the ScalarizeMaskedMemIntrin pass and regular loads and stores are handled by -- I believe -- LegalizeDAG.

Maybe vp can piggyback on ScalarizeMaskedMemIntrin for unaligned access expansion.

It already will piggyback on ScalarizeMaskedMemIntrin for scalarization, so that should be straightforward to put into the followup VP-mem-expansion patch.

May 27 2021, 10:02 AM · Restricted Project, Restricted Project

May 25 2021

hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Addressing review comments.

May 25 2021, 10:34 AM · Restricted Project, Restricted Project

May 18 2021

hussainjk added inline comments to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..
May 18 2021, 9:53 AM · Restricted Project, Restricted Project

May 17 2021

hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Addressing review comments.

May 17 2021, 7:28 AM · Restricted Project, Restricted Project

Apr 1 2021

hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Various code review fixes.

Apr 1 2021, 8:55 AM · Restricted Project, Restricted Project
hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Reverted some SDNode bits.

Apr 1 2021, 8:09 AM · Restricted Project, Restricted Project

Mar 25 2021

hussainjk updated subscribers of D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..
Mar 25 2021, 11:01 AM · Restricted Project, Restricted Project
hussainjk requested review of D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..
Mar 25 2021, 10:56 AM · Restricted Project, Restricted Project

Aug 27 2020

hussainjk requested review of D86693: Implementation of variable-length load/store intrinsics.
Aug 27 2020, 2:47 AM · Restricted Project

Mar 30 2020

hussainjk abandoned D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..
Mar 30 2020, 11:24 AM · Restricted Project

Jan 22 2020

hussainjk added a reviewer for D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic.: kamaub.
Jan 22 2020, 9:09 AM · Restricted Project
hussainjk added a comment to D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..

@nemanjai I amended the description with some detail on the work I will be using this in, as discussed. LMK if it should be more detailed.

Jan 22 2020, 8:12 AM · Restricted Project
hussainjk added inline comments to D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..
Jan 22 2020, 8:12 AM · Restricted Project
hussainjk updated the summary of D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..
Jan 22 2020, 8:02 AM · Restricted Project

Jan 3 2020

hussainjk added a comment to D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..

I realize that without any uses of these functions, we can't really add a test case. However, can we at least get a description of why this is useful in the middle end if this patch won't add any users of these functions?

Generally, I am a bit apprehensive about adding functions without callers if we don't have a clear roadmap to when/how these will be used.

Jan 3 2020, 4:57 PM · Restricted Project

Dec 17 2019

hussainjk added a reviewer for D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic.: nemanjai.
Dec 17 2019, 1:09 PM · Restricted Project

Dec 12 2019

hussainjk added a comment to D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..

ping

Dec 12 2019, 8:23 AM · Restricted Project

Nov 11 2019

hussainjk added inline comments to D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..
Nov 11 2019, 10:19 PM · Restricted Project
hussainjk added reviewers for D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic.: hiraditya, greened.
Nov 11 2019, 9:32 PM · Restricted Project
hussainjk created D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..
Nov 11 2019, 9:09 PM · Restricted Project