Page MenuHomePhabricator

hussainjk (Hussain Kadhem)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 11 2019, 11:36 AM (83 w, 5 d)

Recent Activity

Thu, Jun 10

hussainjk added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

I don't have commit access. Can someone commit this please?

Thu, Jun 10, 2:32 PM · Restricted Project, Restricted Project
hussainjk added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

I believe I've addressed everything now.

Thu, Jun 10, 10:25 AM · Restricted Project, Restricted Project
hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

addressing review comments

Thu, Jun 10, 9:50 AM · Restricted Project, Restricted Project

Tue, Jun 8

hussainjk added inline comments to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..
Tue, Jun 8, 10:24 AM · Restricted Project, Restricted Project
hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

addressing review comments

Tue, Jun 8, 10:22 AM · Restricted Project, Restricted Project

Thu, May 27

hussainjk added a comment to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

I had a thought about alignment. Do we have a plan on how to deal with unaligned accesses?

Not yet

The other non-VP masked intrinsics are scalarized by the ScalarizeMaskedMemIntrin pass and regular loads and stores are handled by -- I believe -- LegalizeDAG.

Maybe vp can piggyback on ScalarizeMaskedMemIntrin for unaligned access expansion.

It already will piggyback on ScalarizeMaskedMemIntrin for scalarization, so that should be straightforward to put into the followup VP-mem-expansion patch.

Thu, May 27, 10:02 AM · Restricted Project, Restricted Project

Tue, May 25

hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Addressing review comments.

Tue, May 25, 10:34 AM · Restricted Project, Restricted Project

May 18 2021

hussainjk added inline comments to D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..
May 18 2021, 9:53 AM · Restricted Project, Restricted Project

May 17 2021

hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Addressing review comments.

May 17 2021, 7:28 AM · Restricted Project, Restricted Project

Apr 1 2021

hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Various code review fixes.

Apr 1 2021, 8:55 AM · Restricted Project, Restricted Project
hussainjk updated the diff for D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..

Reverted some SDNode bits.

Apr 1 2021, 8:09 AM · Restricted Project, Restricted Project

Mar 25 2021

hussainjk updated subscribers of D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..
Mar 25 2021, 11:01 AM · Restricted Project, Restricted Project
hussainjk requested review of D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter..
Mar 25 2021, 10:56 AM · Restricted Project, Restricted Project

Aug 27 2020

hussainjk requested review of D86693: Implementation of variable-length load/store intrinsics.
Aug 27 2020, 2:47 AM · Restricted Project

Mar 30 2020

hussainjk abandoned D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..
Mar 30 2020, 11:24 AM · Restricted Project

Jan 22 2020

hussainjk added a reviewer for D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic.: kamaub.
Jan 22 2020, 9:09 AM · Restricted Project
hussainjk added a comment to D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..

@nemanjai I amended the description with some detail on the work I will be using this in, as discussed. LMK if it should be more detailed.

Jan 22 2020, 8:12 AM · Restricted Project
hussainjk added inline comments to D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..
Jan 22 2020, 8:12 AM · Restricted Project
hussainjk updated the summary of D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..
Jan 22 2020, 8:02 AM · Restricted Project

Jan 3 2020

hussainjk added a comment to D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..

I realize that without any uses of these functions, we can't really add a test case. However, can we at least get a description of why this is useful in the middle end if this patch won't add any users of these functions?

Generally, I am a bit apprehensive about adding functions without callers if we don't have a clear roadmap to when/how these will be used.

Jan 3 2020, 4:57 PM · Restricted Project

Dec 17 2019

hussainjk added a reviewer for D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic.: nemanjai.
Dec 17 2019, 1:09 PM · Restricted Project

Dec 12 2019

hussainjk added a comment to D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..

ping

Dec 12 2019, 8:23 AM · Restricted Project

Nov 11 2019

hussainjk added inline comments to D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..
Nov 11 2019, 10:19 PM · Restricted Project
hussainjk added reviewers for D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic.: hiraditya, greened.
Nov 11 2019, 9:32 PM · Restricted Project
hussainjk created D70108: [TTI] Added TTI pass queries for max load/store-per-memory-intrinsic..
Nov 11 2019, 9:09 PM · Restricted Project