This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Make use of DAG.getNeutralElement in lowerVECREDUCE to avoid repeating the same list of constants. NFC
ClosedPublic

Authored by craig.topper on Mar 5 2021, 5:35 PM.

Diff Detail

Event Timeline

craig.topper created this revision.Mar 5 2021, 5:35 PM
craig.topper requested review of this revision.Mar 5 2021, 5:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2021, 5:35 PM
Herald added a subscriber: MaskRay. · View Herald Transcript
khchen added inline comments.Mar 6 2021, 5:22 PM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
2425

maybe the function name should be changed because it does not get IdentityVal now?

craig.topper added inline comments.Mar 6 2021, 5:23 PM
llvm/lib/Target/RISCV/RISCVISelLowering.cpp
2425

Oops. Thanks!

Rename function

khchen accepted this revision.Mar 7 2021, 6:39 PM

LGTM.

This revision is now accepted and ready to land.Mar 7 2021, 6:39 PM
frasercrmck accepted this revision.Mar 8 2021, 1:03 AM

LGTM. Good to know that function exists

This revision was landed with ongoing or failed builds.Mar 8 2021, 9:17 AM
This revision was automatically updated to reflect the committed changes.