Page MenuHomePhabricator

[X86] Add User Interrupts(UINTR) instructions
ClosedPublic

Authored by tianqing on Oct 13 2020, 1:27 AM.

Diff Detail

Event Timeline

tianqing created this revision.Oct 13 2020, 1:27 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 13 2020, 1:27 AM
tianqing requested review of this revision.Oct 13 2020, 1:27 AM
craig.topper added inline comments.Oct 18 2020, 7:18 PM
llvm/lib/Target/X86/X86InstrInfo.td
320

I think this should have SDNPSideEffect to match the intrinsic and to prevent reordering with CLUI/STUI in MachineIR since the TESTUI instruction will inherit properties from X86testui being used in its pattern.

You need to add test for macro UINTR in clang/test/Preprocessor/predefined-arch-macros.c for SapphireRapids.

llvm/docs/ReleaseNotes.rst
121–122

Maybe need add to Clang release notes too.

tianqing updated this revision to Diff 299317.Oct 20 2020, 3:02 AM

Address review comments.

craig.topper retitled this revision from [X86] Add user-level interrupt instructions to [X86] Add User Interrupts(UINTR) instructions.Oct 20 2020, 7:23 PM
This revision is now accepted and ready to land.Oct 20 2020, 7:28 PM
This revision was landed with ongoing or failed builds.Oct 22 2020, 2:33 AM
This revision was automatically updated to reflect the committed changes.