Page MenuHomePhabricator

[WebAssembly] Add section names for some DWARF5 sections
ClosedPublic

Authored by dschuff on Feb 14 2020, 3:31 PM.

Details

Summary

Addresses PR44728 but no tests because I've not yet made any attempt to verify
correctness of the debug info.

Diff Detail

Event Timeline

dschuff created this revision.Feb 14 2020, 3:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2020, 3:31 PM
sbc100 accepted this revision.Feb 14 2020, 3:38 PM
This revision is now accepted and ready to land.Feb 14 2020, 3:38 PM

Please add a test - even if it doesn't verify the correctness of the DWARF, as much as I dislike a "this does anything other than crash" test, it sounds like that's what you care about here?

This revision was automatically updated to reflect the committed changes.

Yes, that's really all I'm after here.
While I've got your attention, do you have any advice about best practices for debug info tests?
It seems like in this case kind of the minimal thing would be to take an existing small debug info test (which in many cases are clang-generated), switch the debug info version metadata tag to 5 and run it through llc. Or is there some simpler thing?

Yes, that's really all I'm after here.
While I've got your attention, do you have any advice about best practices for debug info tests?
It seems like in this case kind of the minimal thing would be to take an existing small debug info test (which in many cases are clang-generated), switch the debug info version metadata tag to 5 and run it through llc. Or is there some simpler thing?

Nah, that sounds about right to me. (if you're generating a new test yourself, you can pass -gdwarf-5 to get the IR in DWARFv5 mode from the start rather than hand-editing)