Page MenuHomePhabricator

aardappel (Wouter van Oortmerssen)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 9 2018, 11:57 AM (225 w, 5 d)

Recent Activity

Mar 21 2022

aardappel accepted D122134: [WebAssembly] Always emit functype directives for defined functions.

Nice.. not sure why at the time I thought this was sufficient to do for external decls only..

Mar 21 2022, 10:24 AM · Restricted Project, Restricted Project

Feb 28 2022

aardappel added a comment to D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get.

I see my comment has not been addressed yet.

Feb 28 2022, 11:08 AM · Restricted Project, Restricted Project

Feb 22 2022

aardappel committed rG2368f18eb305: [WebAssembly] Fixed AsmPrinter not emitting .functype for intrinsics (authored by aardappel).
[WebAssembly] Fixed AsmPrinter not emitting .functype for intrinsics
Feb 22 2022, 4:15 PM
aardappel closed D120365: [WebAssembly] Fixed AsmPrinter not emitting .functype for intrinsics.
Feb 22 2022, 4:14 PM · Restricted Project
aardappel updated the diff for D120365: [WebAssembly] Fixed AsmPrinter not emitting .functype for intrinsics.

Further test reduction

Feb 22 2022, 4:12 PM · Restricted Project
aardappel updated the diff for D120365: [WebAssembly] Fixed AsmPrinter not emitting .functype for intrinsics.

Reduced test, and added asm roundtrip test

Feb 22 2022, 4:05 PM · Restricted Project
aardappel added a comment to D120365: [WebAssembly] Fixed AsmPrinter not emitting .functype for intrinsics.
Feb 22 2022, 3:48 PM · Restricted Project
aardappel requested review of D120365: [WebAssembly] Fixed AsmPrinter not emitting .functype for intrinsics.
Feb 22 2022, 3:48 PM · Restricted Project
aardappel added inline comments to D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get.
Feb 22 2022, 11:56 AM · Restricted Project, Restricted Project
aardappel closed D119794: [WebAssembly] Allow .data shorthand for .section .data.0,"",@.

Forgot the Differential Revision: , it has been pushed to main.

Feb 22 2022, 10:28 AM · Restricted Project
aardappel committed rGd657c6893f9b: [WebAssembly] Allow .data shorthand for .section .data,"",@ (authored by aardappel).
[WebAssembly] Allow .data shorthand for .section .data,"",@
Feb 22 2022, 10:27 AM
aardappel added a comment to D119794: [WebAssembly] Allow .data shorthand for .section .data.0,"",@.

This fixes https://github.com/llvm/llvm-project/issues/42472 btw

Feb 22 2022, 10:25 AM · Restricted Project
aardappel updated the diff for D119794: [WebAssembly] Allow .data shorthand for .section .data.0,"",@.

Addressed comment

Feb 22 2022, 10:22 AM · Restricted Project

Feb 14 2022

aardappel requested review of D119794: [WebAssembly] Allow .data shorthand for .section .data.0,"",@.
Feb 14 2022, 3:56 PM · Restricted Project

Jan 24 2022

aardappel accepted D118082: [clang][Driver] use DWARF4 for wasm.
Jan 24 2022, 3:28 PM · Restricted Project

Dec 15 2021

aardappel accepted D115748: [WebAssembly] Fix typechecking for else MCInst.

thanks for the fix!

Dec 15 2021, 11:04 AM · Restricted Project

Nov 22 2021

aardappel added a comment to D113809: [MachO] Fix struct size assertion.

I tried, but this will take me longer to set up, which I can't do right now. I may be able to return to this later if I am still blocked by it.

Nov 22 2021, 11:29 AM · Restricted Project, Restricted Project

Nov 18 2021

aardappel added a comment to D113809: [MachO] Fix struct size assertion.

It's local.

Nov 18 2021, 3:19 PM · Restricted Project, Restricted Project
aardappel added a comment to D113809: [MachO] Fix struct size assertion.

(it is apparently 128).

Nov 18 2021, 2:47 PM · Restricted Project, Restricted Project
aardappel added a comment to D113809: [MachO] Fix struct size assertion.

This assert is failing on VS2019 x64

Nov 18 2021, 2:39 PM · Restricted Project, Restricted Project

Nov 8 2021

aardappel committed rG62eeb3e57edd: [WebAssembly] fix __stack_pointer being added to .debug_aranges (authored by aardappel).
[WebAssembly] fix __stack_pointer being added to .debug_aranges
Nov 8 2021, 4:31 PM
aardappel closed D113438: [WebAssembly] fix __stack_pointer being added to .debug_aranges.

This has landed, not sure why Phabricator doesn't notice..

Nov 8 2021, 4:16 PM · Restricted Project
aardappel committed rG4a0c89a6cf8f: [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses (authored by aardappel).
[WebAssembly] Fix fixBrTableIndex removing instruction without checking uses
Nov 8 2021, 3:54 PM
aardappel closed D113230: [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses.
Nov 8 2021, 3:54 PM · Restricted Project
aardappel requested review of D113438: [WebAssembly] fix __stack_pointer being added to .debug_aranges.
Nov 8 2021, 3:32 PM · Restricted Project
aardappel added inline comments to D113230: [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses.
Nov 8 2021, 12:30 PM · Restricted Project
aardappel updated the diff for D113230: [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses.

Simplified using use_nodbg_empty

Nov 8 2021, 12:29 PM · Restricted Project

Nov 4 2021

aardappel added a comment to D113230: [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses.

There might be a more elegant way to test if an instruction still has users for its def/reg, anyone know?

Nov 4 2021, 5:26 PM · Restricted Project
aardappel requested review of D113230: [WebAssembly] Fix fixBrTableIndex removing instruction without checking uses.
Nov 4 2021, 5:23 PM · Restricted Project
aardappel committed rGa320f877cec6: [WebAssembly] Fix debug locations for ExplicitLocals pass (authored by aardappel).
[WebAssembly] Fix debug locations for ExplicitLocals pass
Nov 4 2021, 11:39 AM
aardappel closed D113208: [WebAssembly] Fix debug locations for ExplicitLocals pass (#2).
Nov 4 2021, 11:38 AM · Restricted Project
aardappel requested review of D113208: [WebAssembly] Fix debug locations for ExplicitLocals pass (#2).
Nov 4 2021, 11:20 AM · Restricted Project
aardappel added inline comments to D112370: [BasicAA] Use index size instead of pointer size.
Nov 4 2021, 9:45 AM · Restricted Project

Nov 1 2021

aardappel committed rGac65366485d4: [WebAssembly] support "return" and unreachable code in asm type checker (authored by aardappel).
[WebAssembly] support "return" and unreachable code in asm type checker
Nov 1 2021, 3:43 PM
aardappel closed D112953: [WebAssembly] support "return" and unreachable code in asm type checker.
Nov 1 2021, 3:43 PM · Restricted Project
aardappel updated the diff for D112953: [WebAssembly] support "return" and unreachable code in asm type checker.

Removed unrelated fix and formatting

Nov 1 2021, 3:40 PM · Restricted Project
aardappel added inline comments to D112964: [WebAssembly] Disable test that doesn't work on Windows.
Nov 1 2021, 3:36 PM · Restricted Project
aardappel added inline comments to D112964: [WebAssembly] Disable test that doesn't work on Windows.
Nov 1 2021, 3:34 PM · Restricted Project
aardappel requested review of D112964: [WebAssembly] Disable test that doesn't work on Windows.
Nov 1 2021, 2:46 PM · Restricted Project
aardappel added inline comments to D112953: [WebAssembly] support "return" and unreachable code in asm type checker.
Nov 1 2021, 1:42 PM · Restricted Project
aardappel requested review of D112953: [WebAssembly] support "return" and unreachable code in asm type checker.
Nov 1 2021, 1:11 PM · Restricted Project

Oct 28 2021

aardappel committed rGa66451ebbe45: [WebAssembly] Fix debug locations for ExplicitLocals pass (authored by aardappel).
[WebAssembly] Fix debug locations for ExplicitLocals pass
Oct 28 2021, 12:36 PM
aardappel closed D112487: [WebAssembly] Fix debug locations for ExplicitLocals pass.
Oct 28 2021, 12:36 PM · Restricted Project

Oct 25 2021

aardappel added a comment to D112487: [WebAssembly] Fix debug locations for ExplicitLocals pass.

As for the changes to DW_AT_low/high_pc the code generated for this test is:

Oct 25 2021, 2:06 PM · Restricted Project
aardappel requested review of D112487: [WebAssembly] Fix debug locations for ExplicitLocals pass.
Oct 25 2021, 2:02 PM · Restricted Project
aardappel committed rG5694dbccc3c8: [WebAssembly] support Memory64 in target_features section (authored by aardappel).
[WebAssembly] support Memory64 in target_features section
Oct 25 2021, 9:32 AM
aardappel closed D112266: [WebAssembly] support Memory64 in target_features section.
Oct 25 2021, 9:32 AM · Restricted Project

Oct 21 2021

aardappel requested review of D112266: [WebAssembly] support Memory64 in target_features section.
Oct 21 2021, 1:47 PM · Restricted Project

Sep 8 2021

aardappel added a comment to D109202: [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass.

Apologies for pushing this to main, I did not see there was no "accepted" status yet, though did check with @dschuff offline that he was ok with this patch as-is.

Sep 8 2021, 10:51 AM · Restricted Project
aardappel committed rGa99fb86c6556: [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass (authored by aardappel).
[WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass
Sep 8 2021, 10:48 AM
aardappel closed D109202: [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass.
Sep 8 2021, 10:48 AM · Restricted Project
aardappel added a comment to D109202: [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass.

Yes, it must always be run just before AsmPrinter.

Sep 8 2021, 10:09 AM · Restricted Project
aardappel added a comment to D109202: [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass.

@aeubanks looked up the use of this pass, and the comments next to its usage say:

Sep 8 2021, 9:36 AM · Restricted Project

Sep 2 2021

aardappel added a comment to D109202: [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass.

Also there is no MachineModule.. MachineModuleInfo is the closest thing.. that may explain why there's no MachineModulePass. The code to obtain MachineModuleInfo is a bit clumsy though, but I've seen other passes use it this way too.

Sep 2 2021, 4:56 PM · Restricted Project
aardappel added a comment to D109202: [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass.

Well.. yes :) The code runs, and unlike before, causes all symbols for all functions to be collected before MCLowering.
It passes all existing tests that expect __stack_pointer, and the new test fails without this patch because the .globaltype is not emitted, much like in the reported bug.
Do you recommend anyone to add to this review to see if I am not committing a grave LLVM-no-no?

Sep 2 2021, 4:26 PM · Restricted Project
aardappel requested review of D109202: [WebAssembly] Change WebAssemblyMCLowerPrePass to ModulePass.
Sep 2 2021, 3:45 PM · Restricted Project

Jul 19 2021

aardappel committed rG670944fb20b2: [WebAssembly] Support R_WASM_MEMORY_ADDR_TLS_SLEB64 for wasm64 (authored by aardappel).
[WebAssembly] Support R_WASM_MEMORY_ADDR_TLS_SLEB64 for wasm64
Jul 19 2021, 10:23 AM
aardappel closed D106096: [WebAssembly] Support R_WASM_MEMORY_ADDR_TLS_SLEB64 for wasm64.
Jul 19 2021, 10:23 AM · Restricted Project
aardappel accepted D103557: [WebAssembly] Generate R_WASM_FUNCTION_OFFSET relocs in debuginfo sections.
Jul 19 2021, 10:17 AM · Restricted Project

Jul 15 2021

aardappel updated the diff for D106096: [WebAssembly] Support R_WASM_MEMORY_ADDR_TLS_SLEB64 for wasm64.

Fix type error; Fix original test had addr & value swapped for i32.store (discovered by the asm type checker in the 64-bit version :)

Jul 15 2021, 1:53 PM · Restricted Project
aardappel requested review of D106096: [WebAssembly] Support R_WASM_MEMORY_ADDR_TLS_SLEB64 for wasm64.
Jul 15 2021, 1:37 PM · Restricted Project
aardappel committed rG4157b6033d09: [WebAssembly] Fixed LLD generation of 64-bit __wasm_apply_data_relocs (authored by aardappel).
[WebAssembly] Fixed LLD generation of 64-bit __wasm_apply_data_relocs
Jul 15 2021, 10:02 AM
aardappel closed D105863: [WebAssembly] Fixed LLD generation of 64-bit __wasm_apply_data_relocs.
Jul 15 2021, 10:02 AM · Restricted Project
aardappel updated the diff for D105863: [WebAssembly] Fixed LLD generation of 64-bit __wasm_apply_data_relocs.

factored out repeating use of is64

Jul 15 2021, 10:01 AM · Restricted Project

Jul 12 2021

aardappel requested review of D105863: [WebAssembly] Fixed LLD generation of 64-bit __wasm_apply_data_relocs.
Jul 12 2021, 6:05 PM · Restricted Project
aardappel committed rGb568c11b4090: [WebAssembly] Fixed LLD generation of 64-bit __wasm_init_memory (authored by aardappel).
[WebAssembly] Fixed LLD generation of 64-bit __wasm_init_memory
Jul 12 2021, 3:27 PM
aardappel closed D105849: [WebAssembly] Fixed LLD generation of 64-bit __wasm_init_memory.
Jul 12 2021, 3:26 PM · Restricted Project
aardappel requested review of D105849: [WebAssembly] Fixed LLD generation of 64-bit __wasm_init_memory.
Jul 12 2021, 3:13 PM · Restricted Project
aardappel committed rG1689d14ed1b8: [WebAssembly] fix typo in range check for Asm locals (authored by aardappel).
[WebAssembly] fix typo in range check for Asm locals
Jul 12 2021, 1:08 PM

Jul 9 2021

aardappel committed rGf3e6c3f327c2: [WebAssembly] Fixed 2 warnings in Asm Type Checker (authored by aardappel).
[WebAssembly] Fixed 2 warnings in Asm Type Checker
Jul 9 2021, 2:39 PM
aardappel committed rG156cb8d5ca67: [WebAssembly] fix broken tools/llvm-symbolizer/wasm-basic.s test (authored by aardappel).
[WebAssembly] fix broken tools/llvm-symbolizer/wasm-basic.s test
Jul 9 2021, 2:31 PM
aardappel committed rG9647a6f719ee: [WebAssembly] Added initial type checker to MC Assembler (authored by aardappel).
[WebAssembly] Added initial type checker to MC Assembler
Jul 9 2021, 2:08 PM
aardappel closed D104945: [WebAssembly] Added initial type checker to MC Assembler.
Jul 9 2021, 2:08 PM · Restricted Project
aardappel added a comment to D104945: [WebAssembly] Added initial type checker to MC Assembler.

Ok, I can land this as-is, with the few warts it has. Might be easier to address things in followups given the size.

Jul 9 2021, 11:49 AM · Restricted Project
aardappel updated the diff for D104945: [WebAssembly] Added initial type checker to MC Assembler.

Addressed code review.

Jul 9 2021, 10:34 AM · Restricted Project
aardappel added inline comments to D104945: [WebAssembly] Added initial type checker to MC Assembler.
Jul 9 2021, 10:29 AM · Restricted Project

Jun 28 2021

aardappel added inline comments to D104945: [WebAssembly] Added initial type checker to MC Assembler.
Jun 28 2021, 3:38 PM · Restricted Project
aardappel updated the diff for D104945: [WebAssembly] Added initial type checker to MC Assembler.

Addressed most of sbc code review

Jun 28 2021, 2:07 PM · Restricted Project
aardappel added inline comments to D104945: [WebAssembly] Added initial type checker to MC Assembler.
Jun 28 2021, 2:03 PM · Restricted Project

Jun 25 2021

aardappel added a comment to D104945: [WebAssembly] Added initial type checker to MC Assembler.

This is a first version that passes all (modified) tests. There is still a few things wrong with this, but I thought I'd get some feedback on this direction as it stands.

Jun 25 2021, 12:45 PM · Restricted Project
aardappel requested review of D104945: [WebAssembly] Added initial type checker to MC Assembler.
Jun 25 2021, 12:43 PM · Restricted Project

May 20 2021

aardappel committed rG3a293cbf13a2: [WebAssembly] Fix PIC/GOT codegen for wasm64 (authored by aardappel).
[WebAssembly] Fix PIC/GOT codegen for wasm64
May 20 2021, 10:02 AM
aardappel closed D101784: [WebAssembly] Fix PIC/GOT codegen for wasm64.
May 20 2021, 10:01 AM · Restricted Project
aardappel updated the diff for D101784: [WebAssembly] Fix PIC/GOT codegen for wasm64.

reworked test for .s format and rebasing

May 20 2021, 10:01 AM · Restricted Project

May 10 2021

aardappel updated the diff for D101784: [WebAssembly] Fix PIC/GOT codegen for wasm64.

fixed --check-prefixes

May 10 2021, 9:32 AM · Restricted Project

May 6 2021

aardappel updated the diff for D101784: [WebAssembly] Fix PIC/GOT codegen for wasm64.

Addressed code review.

May 6 2021, 4:29 PM · Restricted Project
aardappel added inline comments to D101784: [WebAssembly] Fix PIC/GOT codegen for wasm64.
May 6 2021, 4:20 PM · Restricted Project
aardappel accepted D101985: [WebAssembly] Support Emscripten EH/SjLj in Wasm64.
May 6 2021, 11:44 AM · Restricted Project

May 3 2021

aardappel requested review of D101784: [WebAssembly] Fix PIC/GOT codegen for wasm64.
May 3 2021, 12:54 PM · Restricted Project
aardappel added a comment to D101736: [WebAssembly] Allow DBG_VALUE after terminator in MachineVerifier.

Yes, this makes sense to me. Another way to put it is that our br_if has the side effect of forcing termination of a "register" lifetime, which is uncommon.

May 3 2021, 9:58 AM · Restricted Project

Apr 22 2021

aardappel accepted D100995: [WebAssembly] Put utility functions in Utils directory (NFC).

Thanks for doing this, was sorely needed :)

Apr 22 2021, 11:08 AM · Restricted Project

Apr 8 2021

aardappel committed rG04e9cd09c888: [WebAssembly] Fix for PIC external symbol ISEL (authored by aardappel).
[WebAssembly] Fix for PIC external symbol ISEL
Apr 8 2021, 12:08 PM
aardappel closed D99904: [WebAssembly] Fix for PIC external symbol ISEL.
Apr 8 2021, 12:08 PM · Restricted Project
aardappel added inline comments to D99904: [WebAssembly] Fix for PIC external symbol ISEL.
Apr 8 2021, 12:05 PM · Restricted Project

Apr 5 2021

aardappel requested review of D99904: [WebAssembly] Fix for PIC external symbol ISEL.
Apr 5 2021, 4:06 PM · Restricted Project

Mar 26 2021

aardappel accepted D99410: [WebAssembly] Fix incorrect DW_TAG_pointer_type size in test.

Thanks, that would make sense, since this test was probably adapted from the 32-bit version.

Mar 26 2021, 11:02 AM · Restricted Project

Mar 8 2021

aardappel added a comment to D96659: [WebAssembly] Add new relocation for location relative data.

I can land it.. let me pull it in locally and run tests to be sure.

Mar 8 2021, 10:13 AM · Restricted Project

Mar 1 2021

aardappel committed rGa0f4526836a7: [WebAssembly] Fix split-dwarf not emitting DW_OP_WASM_location correctly (authored by aardappel).
[WebAssembly] Fix split-dwarf not emitting DW_OP_WASM_location correctly
Mar 1 2021, 11:54 AM
aardappel closed D97564: [WebAssembly] Fix split-dwarf not emitting DW_OP_WASM_location correctly.
Mar 1 2021, 11:53 AM · Restricted Project
aardappel added inline comments to D97564: [WebAssembly] Fix split-dwarf not emitting DW_OP_WASM_location correctly.
Mar 1 2021, 11:52 AM · Restricted Project