- User Since
- Mar 9 2018, 11:57 AM (290 w, 1 d)
Mar 21 2022
Nice.. not sure why at the time I thought this was sufficient to do for external decls only..
Feb 28 2022
I see my comment has not been addressed yet.
Feb 22 2022
Further test reduction
Reduced test, and added asm roundtrip test
Forgot the Differential Revision: , it has been pushed to main.
This fixes https://github.com/llvm/llvm-project/issues/42472 btw
Feb 14 2022
Jan 24 2022
Dec 15 2021
thanks for the fix!
Nov 22 2021
I tried, but this will take me longer to set up, which I can't do right now. I may be able to return to this later if I am still blocked by it.
Nov 18 2021
(it is apparently 128).
This assert is failing on VS2019 x64
Nov 8 2021
This has landed, not sure why Phabricator doesn't notice..
Simplified using use_nodbg_empty
Nov 4 2021
There might be a more elegant way to test if an instruction still has users for its def/reg, anyone know?
Nov 1 2021
Removed unrelated fix and formatting
Oct 28 2021
Oct 25 2021
As for the changes to DW_AT_low/high_pc the code generated for this test is:
Oct 21 2021
Sep 8 2021
Apologies for pushing this to main, I did not see there was no "accepted" status yet, though did check with @dschuff offline that he was ok with this patch as-is.
Yes, it must always be run just before AsmPrinter.
@aeubanks looked up the use of this pass, and the comments next to its usage say:
Sep 2 2021
Also there is no MachineModule.. MachineModuleInfo is the closest thing.. that may explain why there's no MachineModulePass. The code to obtain MachineModuleInfo is a bit clumsy though, but I've seen other passes use it this way too.
Well.. yes :) The code runs, and unlike before, causes all symbols for all functions to be collected before MCLowering.
It passes all existing tests that expect __stack_pointer, and the new test fails without this patch because the .globaltype is not emitted, much like in the reported bug.
Do you recommend anyone to add to this review to see if I am not committing a grave LLVM-no-no?
Jul 19 2021
Jul 15 2021
Fix type error; Fix original test had addr & value swapped for i32.store (discovered by the asm type checker in the 64-bit version :)
factored out repeating use of is64
Jul 12 2021
Jul 9 2021
Ok, I can land this as-is, with the few warts it has. Might be easier to address things in followups given the size.
Addressed code review.
Jun 28 2021
Addressed most of sbc code review
Jun 25 2021
This is a first version that passes all (modified) tests. There is still a few things wrong with this, but I thought I'd get some feedback on this direction as it stands.
May 20 2021
reworked test for .s format and rebasing
May 10 2021
May 6 2021
Addressed code review.
May 3 2021
Yes, this makes sense to me. Another way to put it is that our br_if has the side effect of forcing termination of a "register" lifetime, which is uncommon.
Apr 22 2021
Thanks for doing this, was sorely needed :)
Apr 8 2021
Apr 5 2021
Mar 26 2021
Thanks, that would make sense, since this test was probably adapted from the 32-bit version.
Mar 8 2021
I can land it.. let me pull it in locally and run tests to be sure.