Page MenuHomePhabricator

aardappel (Wouter van Oortmerssen)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 9 2018, 11:57 AM (80 w, 19 h)

Recent Activity

Tue, Sep 3

aardappel committed rL370790: Request commit access for aardappel.
Request commit access for aardappel
Tue, Sep 3, 10:25 AM

Aug 19 2019

aardappel accepted D66434: [WebAssembly][MC] Allow empty assembly functions.
Aug 19 2019, 12:00 PM · Restricted Project

Aug 1 2019

aardappel committed rG7fee93ed59fd: [WebAssembly] Fixed relocation errors having no location. (authored by aardappel).
[WebAssembly] Fixed relocation errors having no location.
Aug 1 2019, 2:36 PM
aardappel committed rL367619: [WebAssembly] Fixed relocation errors having no location..
[WebAssembly] Fixed relocation errors having no location.
Aug 1 2019, 2:35 PM
aardappel closed D65602: [WebAssembly] Fixed relocation errors having no location..
Aug 1 2019, 2:35 PM · Restricted Project
aardappel created D65602: [WebAssembly] Fixed relocation errors having no location..
Aug 1 2019, 12:56 PM · Restricted Project
aardappel committed rG87af0b191150: [WebAssembly] Assembler/InstPrinter: support call_indirect type index. (authored by aardappel).
[WebAssembly] Assembler/InstPrinter: support call_indirect type index.
Aug 1 2019, 11:10 AM
aardappel committed rL367590: [WebAssembly] Assembler/InstPrinter: support call_indirect type index..
[WebAssembly] Assembler/InstPrinter: support call_indirect type index.
Aug 1 2019, 11:09 AM
aardappel closed D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index..
Aug 1 2019, 11:09 AM · Restricted Project
aardappel updated the diff for D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index..

Fixed tail-call-encodings.s test

Aug 1 2019, 11:07 AM · Restricted Project
aardappel updated the diff for D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index..

Added return_call_indirect

Aug 1 2019, 10:44 AM · Restricted Project

Jul 26 2019

aardappel updated the summary of D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index..
Jul 26 2019, 5:16 PM · Restricted Project
aardappel added a comment to D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index..

@sbc100 @aheejin and others: code has been reworked and is much more elegant.. no more hacks.

Jul 26 2019, 5:11 PM · Restricted Project
aardappel updated the diff for D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index..

Reworked to use inline signatures.

Jul 26 2019, 5:07 PM · Restricted Project

Jul 15 2019

aardappel committed rG292e21d8bce4: [WebAssembly] Assembler: support special floats: infinity / nan (authored by aardappel).
[WebAssembly] Assembler: support special floats: infinity / nan
Jul 15 2019, 3:16 PM
aardappel committed rL366139: [WebAssembly] Assembler: support special floats: infinity / nan.
[WebAssembly] Assembler: support special floats: infinity / nan
Jul 15 2019, 3:14 PM
aardappel closed D64770: [WebAssembly] Assembler: support special floats: infinity / nan.
Jul 15 2019, 3:14 PM · Restricted Project
aardappel created D64770: [WebAssembly] Assembler: support special floats: infinity / nan.
Jul 15 2019, 1:53 PM · Restricted Project
aardappel committed rGb2a0745e2d5e: [WebAssembly] Assembler: recognize .init_array as data section. (authored by aardappel).
[WebAssembly] Assembler: recognize .init_array as data section.
Jul 15 2019, 11:37 AM
aardappel committed rL366104: [WebAssembly] Assembler: recognize .init_array as data section..
[WebAssembly] Assembler: recognize .init_array as data section.
Jul 15 2019, 11:37 AM
aardappel closed D64602: [WebAssembly] Assembler: recognize .init_array as data section..
Jul 15 2019, 11:37 AM · Restricted Project
aardappel created D64758: [WebAssembly] Assembler/InstPrinter: support call_indirect type index..
Jul 15 2019, 10:12 AM · Restricted Project

Jul 12 2019

aardappel committed rGd8ddf839505a: [WebAssembly] refactored utilities to not depend on MachineInstr (authored by aardappel).
[WebAssembly] refactored utilities to not depend on MachineInstr
Jul 12 2019, 3:10 PM
aardappel committed rL365965: [WebAssembly] refactored utilities to not depend on MachineInstr.
[WebAssembly] refactored utilities to not depend on MachineInstr
Jul 12 2019, 3:10 PM
aardappel closed D64643: [WebAssembly] refactored utilities to not depend on MachineInstr (NFC).
Jul 12 2019, 3:10 PM · Restricted Project
aardappel updated the diff for D64643: [WebAssembly] refactored utilities to not depend on MachineInstr (NFC).

Moved functions to MCTargetDesc to be available to all.

Jul 12 2019, 3:06 PM · Restricted Project
aardappel added a comment to D64643: [WebAssembly] refactored utilities to not depend on MachineInstr (NFC).

Most of the functions are only called once or twice, so adding overloads is not worth it, I think.
I think its cleaner for them to work on generic opcodes, irrespective of where those are stored.

Jul 12 2019, 2:44 PM · Restricted Project
aardappel retitled D64643: [WebAssembly] refactored utilities to not depend on MachineInstr (NFC) from [WebAssembly] refactored utilities to not depend on MachineInstr to [WebAssembly] refactored utilities to not depend on MachineInstr (NFC).
Jul 12 2019, 2:41 PM · Restricted Project
aardappel updated the diff for D64602: [WebAssembly] Assembler: recognize .init_array as data section..

Added test.

Jul 12 2019, 10:18 AM · Restricted Project
aardappel created D64643: [WebAssembly] refactored utilities to not depend on MachineInstr (NFC).
Jul 12 2019, 9:37 AM · Restricted Project

Jul 11 2019

aardappel created D64602: [WebAssembly] Assembler: recognize .init_array as data section..
Jul 11 2019, 3:26 PM · Restricted Project
aardappel committed rGa617967d6877: [WebAssembly] Assembler: support negative float constants. (authored by aardappel).
[WebAssembly] Assembler: support negative float constants.
Jul 11 2019, 11:21 AM
aardappel committed rL365802: [WebAssembly] Assembler: support negative float constants..
[WebAssembly] Assembler: support negative float constants.
Jul 11 2019, 11:18 AM
aardappel closed D64367: [WebAssembly] Assembler: support negative float constants..
Jul 11 2019, 11:18 AM · Restricted Project

Jul 8 2019

aardappel created D64367: [WebAssembly] Assembler: support negative float constants..
Jul 8 2019, 2:03 PM · Restricted Project
aardappel committed rG81db9f543ceb: [WebAssembly] tablegen: distinguish float/int immediate operands. (authored by aardappel).
[WebAssembly] tablegen: distinguish float/int immediate operands.
Jul 8 2019, 9:59 AM
aardappel committed rL365351: [WebAssembly] tablegen: distinguish float/int immediate operands..
[WebAssembly] tablegen: distinguish float/int immediate operands.
Jul 8 2019, 9:58 AM
aardappel closed D64039: [WebAssembly] tablegen: distinguish float/int immediate operands..
Jul 8 2019, 9:58 AM · Restricted Project

Jul 1 2019

aardappel added inline comments to D64039: [WebAssembly] tablegen: distinguish float/int immediate operands..
Jul 1 2019, 5:27 PM · Restricted Project
aardappel updated the diff for D64039: [WebAssembly] tablegen: distinguish float/int immediate operands..

added test

Jul 1 2019, 2:57 PM · Restricted Project
aardappel added a comment to D64039: [WebAssembly] tablegen: distinguish float/int immediate operands..

We don't have "error" tests for any other illegal operand possibilities, but sure, added a test.

Jul 1 2019, 2:57 PM · Restricted Project
aardappel created D64039: [WebAssembly] tablegen: distinguish float/int immediate operands..
Jul 1 2019, 2:37 PM · Restricted Project

Jun 28 2019

aardappel committed rG319c87d94fd5: [WebAssembly] Assembler: support .int16/32/64 directives. (authored by aardappel).
[WebAssembly] Assembler: support .int16/32/64 directives.
Jun 28 2019, 3:21 PM
aardappel committed rL364689: [WebAssembly] Assembler: support .int16/32/64 directives..
[WebAssembly] Assembler: support .int16/32/64 directives.
Jun 28 2019, 3:21 PM
aardappel closed D63959: [WebAssembly] Assembler: support .int16/32/64 directives..
Jun 28 2019, 3:21 PM · Restricted Project
aardappel committed rG35bcba4fae8a: [WebAssembly] Allow @object in .type directives. (authored by aardappel).
[WebAssembly] Allow @object in .type directives.
Jun 28 2019, 2:56 PM
aardappel committed rL364688: [WebAssembly] Allow @object in .type directives..
[WebAssembly] Allow @object in .type directives.
Jun 28 2019, 2:56 PM
aardappel closed D63955: [WebAssembly] Allow @object in .type directives..
Jun 28 2019, 2:56 PM · Restricted Project
aardappel created D63959: [WebAssembly] Assembler: support .int16/32/64 directives..
Jun 28 2019, 2:52 PM · Restricted Project
aardappel created D63955: [WebAssembly] Allow @object in .type directives..
Jun 28 2019, 1:48 PM · Restricted Project
aardappel committed rGfc222e23cae5: [WebAssembly] Assembler: Allow offsets and p2align in symbol load. (authored by aardappel).
[WebAssembly] Assembler: Allow offsets and p2align in symbol load.
Jun 28 2019, 1:35 PM
aardappel committed rL364682: [WebAssembly] Assembler: Allow offsets and p2align in symbol load..
[WebAssembly] Assembler: Allow offsets and p2align in symbol load.
Jun 28 2019, 1:31 PM
aardappel closed D63951: [WebAssembly] Assembler: Allow offsets and p2align in symbol load..
Jun 28 2019, 1:31 PM · Restricted Project
aardappel committed rG597ba1800869: [WebAssembly] Assembler: Improve section parsing. (authored by aardappel).
[WebAssembly] Assembler: Improve section parsing.
Jun 28 2019, 1:31 PM
aardappel committed rL364681: [WebAssembly] Assembler: Improve section parsing..
[WebAssembly] Assembler: Improve section parsing.
Jun 28 2019, 1:31 PM
aardappel closed D63947: [WebAssembly] Assembler: Improve section parsing..
Jun 28 2019, 1:30 PM · Restricted Project
aardappel created D63951: [WebAssembly] Assembler: Allow offsets and p2align in symbol load..
Jun 28 2019, 11:59 AM · Restricted Project
aardappel added inline comments to D63947: [WebAssembly] Assembler: Improve section parsing..
Jun 28 2019, 11:50 AM · Restricted Project
aardappel created D63947: [WebAssembly] Assembler: Improve section parsing..
Jun 28 2019, 11:35 AM · Restricted Project
aardappel committed rG633d222d30b0: [WebAssembly] Added visibility and ident directives to WasmAsmParser. (authored by aardappel).
[WebAssembly] Added visibility and ident directives to WasmAsmParser.
Jun 28 2019, 9:52 AM
aardappel committed rL364658: [WebAssembly] Added visibility and ident directives to WasmAsmParser..
[WebAssembly] Added visibility and ident directives to WasmAsmParser.
Jun 28 2019, 9:52 AM
aardappel closed D63901: [WebAssembly] Added visibility and ident directives to WasmAsmParser..
Jun 28 2019, 9:51 AM · Restricted Project
aardappel updated the diff for D63901: [WebAssembly] Added visibility and ident directives to WasmAsmParser..

Removed "protected" and fixed indentation in tests.

Jun 28 2019, 9:50 AM · Restricted Project
aardappel added inline comments to D63901: [WebAssembly] Added visibility and ident directives to WasmAsmParser..
Jun 28 2019, 9:50 AM · Restricted Project

Jun 27 2019

aardappel added a comment to D63901: [WebAssembly] Added visibility and ident directives to WasmAsmParser..

Reviewers: the code parsing these directives is from ELFAsmParser. We decided in the past that WASM should have its own container format parser, since it is a very different format from ELF, but copying code is never fun. Any suggestions here? Inherit from ELFAsmParser or take it as a member (may have unintended consequences). Pull into new base class for both (ELF people may not be happy with that). Or just ignore it?

Jun 27 2019, 2:52 PM · Restricted Project
aardappel created D63901: [WebAssembly] Added visibility and ident directives to WasmAsmParser..
Jun 27 2019, 2:49 PM · Restricted Project
aardappel accepted D63898: [WebAssembly] Enable an atomic.notify MC test.

Remove not in the summary?

Jun 27 2019, 2:16 PM · Restricted Project
aardappel added inline comments to D63633: [WebAssembly] Fix p2align in assembler..
Jun 27 2019, 2:07 PM · Restricted Project
aardappel added a comment to D63747: [WebAssembly] AsmParser: better atomic inst detection.

@aheejin Ah sorry, somehow missed that.

Jun 27 2019, 2:06 PM · Restricted Project
aardappel committed rGbfd3f694805d: [WebAssembly] AsmParser: better atomic inst detection (authored by aardappel).
[WebAssembly] AsmParser: better atomic inst detection
Jun 27 2019, 11:59 AM
aardappel committed rL364576: [WebAssembly] AsmParser: better atomic inst detection.
[WebAssembly] AsmParser: better atomic inst detection
Jun 27 2019, 11:59 AM
aardappel closed D63747: [WebAssembly] AsmParser: better atomic inst detection.
Jun 27 2019, 11:59 AM · Restricted Project
aardappel committed rG6b3f56b65fa1: [WebAssembly] Fix p2align in assembler. (authored by aardappel).
[WebAssembly] Fix p2align in assembler.
Jun 27 2019, 11:14 AM
aardappel committed rL364570: [WebAssembly] Fix p2align in assembler..
[WebAssembly] Fix p2align in assembler.
Jun 27 2019, 11:13 AM
aardappel closed D63633: [WebAssembly] Fix p2align in assembler..
Jun 27 2019, 11:13 AM · Restricted Project
aardappel added inline comments to D63633: [WebAssembly] Fix p2align in assembler..
Jun 27 2019, 10:19 AM · Restricted Project

Jun 24 2019

aardappel created D63747: [WebAssembly] AsmParser: better atomic inst detection.
Jun 24 2019, 5:38 PM · Restricted Project
aardappel added inline comments to D63633: [WebAssembly] Fix p2align in assembler..
Jun 24 2019, 4:31 PM · Restricted Project
aardappel updated the diff for D63633: [WebAssembly] Fix p2align in assembler..

Atomics only use default alignment.

Jun 24 2019, 4:31 PM · Restricted Project
aardappel accepted D63737: [WebAssembly] Remove catch_all from AsmParser.
Jun 24 2019, 4:08 PM · Restricted Project
aardappel updated the diff for D63633: [WebAssembly] Fix p2align in assembler..

clang-format

Jun 24 2019, 11:38 AM · Restricted Project
aardappel added inline comments to D63633: [WebAssembly] Fix p2align in assembler..
Jun 24 2019, 11:38 AM · Restricted Project

Jun 20 2019

aardappel created D63633: [WebAssembly] Fix p2align in assembler..
Jun 20 2019, 4:56 PM · Restricted Project

Mar 7 2019

aardappel added a comment to D58956: [WebAssembly] Remove tabs in tests (NFC).

It would be awesome if we could somehow force tabs to be errors, frankly. Or is there some other automatic way to detect them? Or show them in code review?

Mar 7 2019, 10:36 AM · Restricted Project

Mar 4 2019

aardappel committed rGf3feb6adb919: [WebAssembly] Add support for data sections in the assembler. (authored by aardappel).
[WebAssembly] Add support for data sections in the assembler.
Mar 4 2019, 9:18 AM
aardappel committed rL355321: [WebAssembly] Add support for data sections in the assembler..
[WebAssembly] Add support for data sections in the assembler.
Mar 4 2019, 9:17 AM
aardappel closed D58660: [WebAssembly] Add support for data sections in the assembler..
Mar 4 2019, 9:17 AM · Restricted Project

Feb 28 2019

aardappel updated the diff for D58660: [WebAssembly] Add support for data sections in the assembler..

Addressed code review.

Feb 28 2019, 5:33 PM · Restricted Project
aardappel added inline comments to D58660: [WebAssembly] Add support for data sections in the assembler..
Feb 28 2019, 2:36 PM · Restricted Project

Feb 25 2019

aardappel added a comment to D58660: [WebAssembly] Add support for data sections in the assembler..

Note to reviewers: this is a pretty minimal set of directives so far, if you have any opinions which others are vital to add in this patch, let me know :)

Feb 25 2019, 5:46 PM · Restricted Project
aardappel created D58660: [WebAssembly] Add support for data sections in the assembler..
Feb 25 2019, 5:44 PM · Restricted Project

Feb 19 2019

aardappel committed rG8a28ce1a123a: [WebAssembly] Fixed disassembler not knowing about OPERAND_EVENT (authored by aardappel).
[WebAssembly] Fixed disassembler not knowing about OPERAND_EVENT
Feb 19 2019, 4:56 PM
aardappel committed rL354416: [WebAssembly] Fixed disassembler not knowing about OPERAND_EVENT.
[WebAssembly] Fixed disassembler not knowing about OPERAND_EVENT
Feb 19 2019, 4:56 PM
aardappel closed D58414: [WebAssembly] Fixed disassembler not knowing about OPERAND_EVENT.
Feb 19 2019, 4:56 PM · Restricted Project
aardappel created D58414: [WebAssembly] Fixed disassembler not knowing about OPERAND_EVENT.
Feb 19 2019, 3:40 PM · Restricted Project
aardappel accepted D58337: [WebAssembly] Fix load/store name detection for atomic instructions.
Feb 19 2019, 9:35 AM · Restricted Project
aardappel added inline comments to D58315: [WebAssembly] Add .shared_memory directive.
Feb 19 2019, 9:28 AM · Restricted Project

Feb 11 2019

aardappel added inline comments to D57938: [WebAssembly] Update MC for bulk memory.
Feb 11 2019, 11:25 AM · Restricted Project

Feb 7 2019

aardappel committed rG0d9f3f7f953e: [WebAssembly] Fixed Disassembler ignoring endian swap on big endian. (authored by aardappel).
[WebAssembly] Fixed Disassembler ignoring endian swap on big endian.
Feb 7 2019, 5:45 PM
aardappel committed rL353496: [WebAssembly] Fixed Disassembler ignoring endian swap on big endian..
[WebAssembly] Fixed Disassembler ignoring endian swap on big endian.
Feb 7 2019, 5:45 PM