Page MenuHomePhabricator

aardappel (Wouter van Oortmerssen)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 9 2018, 11:57 AM (121 w, 2 d)

Recent Activity

Fri, Jul 3

aardappel added a comment to D83106: [WebAssembly] 64-bit memory limits.

@sbc100 any suggestion for which test would be best to add a 64-bit version of? Most important thing is to ensure LLD is outputting 64-bit memory limits

Fri, Jul 3, 8:01 PM · Restricted Project

Thu, Jul 2

aardappel added a comment to D83106: [WebAssembly] 64-bit memory limits.

Not much happening here, other than updating the memory limits writing. Probably needs an LLD specific test, @sbc100 ?

Thu, Jul 2, 5:50 PM · Restricted Project
aardappel created D83106: [WebAssembly] 64-bit memory limits.
Thu, Jul 2, 5:50 PM · Restricted Project
aardappel added inline comments to D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill.
Thu, Jul 2, 4:45 PM · Restricted Project
aardappel updated the diff for D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill.

Removed unused init/drop intrinsics instead of trying to make them work for wasm64.
Also testing bulk-memory-encoding.s

Thu, Jul 2, 4:45 PM · Restricted Project
aardappel added inline comments to D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill.
Thu, Jul 2, 2:03 PM · Restricted Project

Mon, Jun 29

aardappel added a comment to D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill.

@tlively I have no idea if my changes in IntrinsicsWebAssembly.td make sense, they merely pass the tests ;) please advise.

Mon, Jun 29, 4:39 PM · Restricted Project
aardappel created D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill.
Mon, Jun 29, 4:39 PM · Restricted Project

Thu, Jun 25

aardappel committed rGb9a539c01084: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals (authored by aardappel).
[WebAssembly] Adding 64-bit versions of __stack_pointer and other globals
Thu, Jun 25, 4:24 PM
aardappel closed D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals.
Thu, Jun 25, 4:24 PM · Restricted Project, Restricted Project
aardappel updated the diff for D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals.

types & variables in InputChunks.cpp

Thu, Jun 25, 3:51 PM · Restricted Project, Restricted Project
aardappel updated the diff for D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals.
  • Fixed ISEL for FrameIndex
  • Fixed 64-bit conditions in branches (thanks @aheejin!)
  • Made the FrameIndex generation code in WebAssemblyRegisterInfo work.
  • Made userstack.ll and stack-alignment.ll pass in wasm64.
  • Code review fixes.
Thu, Jun 25, 2:11 PM · Restricted Project, Restricted Project

Mon, Jun 22

aardappel added a comment to D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals.

@dschuff still working on it, it uncovered some issues (as it should :)

Mon, Jun 22, 5:12 PM · Restricted Project, Restricted Project
aardappel added a comment to D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals.

I'll likely fork userstack.ll since the majority of lines need changes.

Mon, Jun 22, 9:39 AM · Restricted Project, Restricted Project

Thu, Jun 18

aardappel added a comment to D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals.

This is a first iteration, probably needs more tests :) I was thinking of forking userstack.ll since it has most __stack_pointer tests, but I am not sure if it's that useful. Needs a test that uses the new wasm-ld flag. Opinions welcome.

Thu, Jun 18, 3:54 PM · Restricted Project, Restricted Project
aardappel updated the diff for D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals.
Thu, Jun 18, 3:54 PM · Restricted Project, Restricted Project
aardappel created D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals.
Thu, Jun 18, 3:54 PM · Restricted Project, Restricted Project

Mon, Jun 15

aardappel added inline comments to D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.
Mon, Jun 15, 10:59 AM · Restricted Project
aardappel added inline comments to D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.
Mon, Jun 15, 10:55 AM · Restricted Project
aardappel committed rG3b29376e3fca: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs (authored by aardappel).
[WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs
Mon, Jun 15, 10:24 AM
aardappel closed D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.
Mon, Jun 15, 10:24 AM · Restricted Project
aardappel updated the diff for D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.

Made dedicated supportsWasm64/resolveWasm64 rather than sharing the Wasm32 versions.

Mon, Jun 15, 10:23 AM · Restricted Project
aardappel updated the diff for D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.

Rebased against previous commit

Mon, Jun 15, 9:49 AM · Restricted Project
aardappel added a comment to D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.

Thanks for the tips. Though frankly in this case I should have tried to make this commit independent, since significant changes in the other one made rebasing a mess.

Mon, Jun 15, 9:47 AM · Restricted Project
aardappel committed rGd9e0bbd17b0e: [WebAssembly] Adding 64-bit versions of all load & store ops. (authored by aardappel).
[WebAssembly] Adding 64-bit versions of all load & store ops.
Mon, Jun 15, 8:42 AM
aardappel closed D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..
Mon, Jun 15, 8:41 AM · Restricted Project

Fri, Jun 12

aardappel added inline comments to D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.
Fri, Jun 12, 6:15 PM · Restricted Project
aardappel updated the diff for D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

Added HasAddr32|64 to all the patterns.

Fri, Jun 12, 4:34 PM · Restricted Project
aardappel added inline comments to D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..
Fri, Jun 12, 4:34 PM · Restricted Project
aardappel added a comment to D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.

@sbc100 Like I said, I think these silent truncations by using explicit types are a maintenance problem which the guidelines mention.

Fri, Jun 12, 2:49 PM · Restricted Project
aardappel updated the diff for D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

80-column wrapping

Fri, Jun 12, 1:42 PM · Restricted Project
aardappel added inline comments to D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..
Fri, Jun 12, 1:42 PM · Restricted Project
aardappel updated the diff for D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

Refactored atomic patterns

Fri, Jun 12, 12:35 PM · Restricted Project
aardappel added a comment to D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.

as for auto, indeed its says "Use auto if and only if it makes the code more readable or easier to maintain". That was exactly my point when I mentioned "The reason I replaced these with auto is we had a bunch of spots where we had unnecessary truncation because of a uint32_t var = exp that results in a 64-bit value. Using auto avoids these problems, now, and with future changes."

Fri, Jun 12, 11:26 AM · Restricted Project
aardappel added inline comments to D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..
Fri, Jun 12, 11:26 AM · Restricted Project
aardappel updated the diff for D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.

Changed init expr to use all union types, and added code to check for opcode.
Other misc code review.
Fixed linker error due to tablegen adding both generated functions to same #ifdef :(
clang-format

Fri, Jun 12, 10:19 AM · Restricted Project
aardappel added inline comments to D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.
Fri, Jun 12, 10:19 AM · Restricted Project

Thu, Jun 11

aardappel created D81704: [WebAssembly] Adding 64-bit version of R_WASM_MEMORY_ADDR_* relocs.
Thu, Jun 11, 5:39 PM · Restricted Project

Mon, Jun 8

aardappel added inline comments to D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..
Mon, Jun 8, 12:08 PM · Restricted Project
aardappel updated the diff for D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

Added HasAddr64 to patterns, and made it default for instructions.

Mon, Jun 8, 9:56 AM · Restricted Project
aardappel added a comment to D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

@aheejin yes, this is part of the triple, much like x86 vs x64. That structure was already in place before I started.

Mon, Jun 8, 9:56 AM · Restricted Project

Jun 4 2020

aardappel added inline comments to D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..
Jun 4 2020, 5:41 PM · Restricted Project
aardappel updated the diff for D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

Removed one more datalayout

Jun 4 2020, 9:20 AM · Restricted Project
aardappel added inline comments to D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..
Jun 4 2020, 9:20 AM · Restricted Project

Jun 1 2020

aardappel updated the diff for D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

Made several tests pass under wasm64!

Jun 1 2020, 5:54 PM · Restricted Project
aardappel updated the diff for D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

Fixed test

Jun 1 2020, 12:25 PM · Restricted Project

May 29 2020

aardappel updated the diff for D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

it builds!

May 29 2020, 4:57 PM · Restricted Project
aardappel updated the diff for D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

fixed all type errors + more missing atomics

May 29 2020, 1:40 PM · Restricted Project
aardappel updated the diff for D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..

finished initial tablegen changes

May 29 2020, 12:00 PM · Restricted Project

May 28 2020

aardappel created D80769: [WebAssembly] Adding 64-bit versions of all load & store ops..
May 28 2020, 5:05 PM · Restricted Project
aardappel accepted D80512: [MC] Changes to help improve target specific symbol disassembly.
May 28 2020, 12:05 PM · Restricted Project

May 21 2020

aardappel added a comment to D80019: [WebAssembly] Fixed debugloc in DebugFixup pass.

Yes, likely.
Either way, I generally don't think such a small change needs a follow-up commit.

May 21 2020, 4:49 PM · Restricted Project
aardappel added inline comments to D80361: [lld][WebAssembly] Convert some lld tests to assembly.
May 21 2020, 2:38 PM · Restricted Project
aardappel accepted D80361: [lld][WebAssembly] Convert some lld tests to assembly.

Wow, impressive! Not sure if I am the best person to guarantee this tests the same things as the IR tests did, though.

May 21 2020, 12:27 PM · Restricted Project

May 18 2020

aardappel committed rG10e2e7de0c0c: [WebAssembly] iterate stack in DebugFixup from the top. (authored by aardappel).
[WebAssembly] iterate stack in DebugFixup from the top.
May 18 2020, 8:35 AM
aardappel closed D80045: [WebAssembly] iterate stack in DebugFixup from the top..
May 18 2020, 8:34 AM · Restricted Project

May 15 2020

aardappel added inline comments to D80019: [WebAssembly] Fixed debugloc in DebugFixup pass.
May 15 2020, 5:56 PM · Restricted Project
aardappel created D80045: [WebAssembly] iterate stack in DebugFixup from the top..
May 15 2020, 4:19 PM · Restricted Project
aardappel added a comment to D79428: [WebAssembly] Added Debug Fixup pass.

@aheejin Apologies if you think I ignored your comments, I feel I responded to all of them, though maybe I could have responded earlier (I wanted to first bring up your point about adjacency in the debugging subgroup meeting yesterday).

May 15 2020, 3:47 PM · Restricted Project
aardappel added a comment to D79428: [WebAssembly] Added Debug Fixup pass.

@sbc100 @paolosev that crash was just fixed here: https://reviews.llvm.org/D80019

May 15 2020, 11:24 AM · Restricted Project
aardappel committed rG62efd1eca201: [WebAssembly] Fixed debugloc in DebugFixup pass (authored by aardappel).
[WebAssembly] Fixed debugloc in DebugFixup pass
May 15 2020, 10:53 AM
aardappel closed D80019: [WebAssembly] Fixed debugloc in DebugFixup pass.
May 15 2020, 10:52 AM · Restricted Project
aardappel updated the diff for D80019: [WebAssembly] Fixed debugloc in DebugFixup pass.

Added differential revision to commit

May 15 2020, 10:51 AM · Restricted Project
aardappel added a comment to D80019: [WebAssembly] Fixed debugloc in DebugFixup pass.

@dschuff not sure what the actual code looks like, this is part of the Bullet3 tests that failed.

May 15 2020, 10:51 AM · Restricted Project
aardappel created D80019: [WebAssembly] Fixed debugloc in DebugFixup pass.
May 15 2020, 10:18 AM · Restricted Project

May 14 2020

aardappel closed D79428: [WebAssembly] Added Debug Fixup pass.

Landed: https://github.com/llvm/llvm-project/commit/2b7fe0863ac3c076797404f90b49cee696af0564
(forgot to add phabricator url to commit)

May 14 2020, 2:08 PM · Restricted Project
aardappel committed rG2b7fe0863ac3: [WebAssembly] Added Debug Fixup pass (authored by aardappel).
[WebAssembly] Added Debug Fixup pass
May 14 2020, 1:37 PM
aardappel updated the diff for D79428: [WebAssembly] Added Debug Fixup pass.

forgot 1 .back() reference + clang-format

May 14 2020, 1:03 PM · Restricted Project
aardappel updated the diff for D79428: [WebAssembly] Added Debug Fixup pass.

Allowed DBG_VALUE for stackified regs to appear anywhere between its def-use.

May 14 2020, 1:03 PM · Restricted Project
aardappel added inline comments to D79428: [WebAssembly] Added Debug Fixup pass.
May 14 2020, 12:30 PM · Restricted Project
aardappel added inline comments to D79428: [WebAssembly] Added Debug Fixup pass.
May 14 2020, 12:30 PM · Restricted Project
aardappel updated the diff for D79428: [WebAssembly] Added Debug Fixup pass.

addressed aheejin's last comments.

May 14 2020, 11:23 AM · Restricted Project
aardappel added inline comments to D79428: [WebAssembly] Added Debug Fixup pass.
May 14 2020, 11:23 AM · Restricted Project

May 8 2020

aardappel updated the diff for D79428: [WebAssembly] Added Debug Fixup pass.

Improved test

May 8 2020, 12:20 PM · Restricted Project

May 7 2020

aardappel updated the diff for D79428: [WebAssembly] Added Debug Fixup pass.

DBG_VALUE $noreg now on pop of stackified reg.

May 7 2020, 5:55 PM · Restricted Project
aardappel added inline comments to D79428: [WebAssembly] Added Debug Fixup pass.
May 7 2020, 5:55 PM · Restricted Project
aardappel abandoned D48985: [WebAssembly] Converted to stack based instructions in MC..

Obsolete, fixed elsewhere since.

May 7 2020, 3:46 PM · Restricted Project
aardappel abandoned D51182: [WebAssembly] Added default stack-only instruction mode for MC..

Obsolete, fixed elsewhere since.

May 7 2020, 3:46 PM · Restricted Project
aardappel abandoned D78818: [WebAssembly] Fix debug_value's when registers are stackified..

This patch abandoned in favor of the approach in https://reviews.llvm.org/D79428

May 7 2020, 3:46 PM · Restricted Project
aardappel closed D77353: [WebAssembly] Add DW_OP_WASM_location_int.

This has already landed.

May 7 2020, 3:46 PM · debug-info, Restricted Project

May 5 2020

aardappel created D79428: [WebAssembly] Added Debug Fixup pass.
May 5 2020, 9:41 AM · Restricted Project

Apr 30 2020

aardappel added inline comments to D79137: [WebAssmebly] Add support for defined wasm globals in MC and lld.
Apr 30 2020, 2:00 PM · Restricted Project
aardappel accepted D79137: [WebAssmebly] Add support for defined wasm globals in MC and lld.
Apr 30 2020, 12:21 PM · Restricted Project
aardappel added inline comments to D79137: [WebAssmebly] Add support for defined wasm globals in MC and lld.
Apr 30 2020, 9:02 AM · Restricted Project

Apr 27 2020

aardappel added a comment to D78818: [WebAssembly] Fix debug_value's when registers are stackified..

@aheejin thanks for the comments! As you say, given that stackifying happens across multiple passes, it may be that the approach here is going to be too clumsy/fragile. I am going to first see if a solution that works at or just before MC lowering can work instead, that way all the stackifying changes can remain as they are.

Apr 27 2020, 4:11 PM · Restricted Project

Apr 24 2020

aardappel added a comment to D78818: [WebAssembly] Fix debug_value's when registers are stackified..

Uploading this for early feedback to see if this goes the right direction.

Apr 24 2020, 10:48 AM · Restricted Project
aardappel created D78818: [WebAssembly] Fix debug_value's when registers are stackified..
Apr 24 2020, 10:48 AM · Restricted Project

Apr 16 2020

aardappel committed rGcbf99e0fbab5: [WebAssembly] Fix faulty logic in verifyRelocTargets (authored by aardappel).
[WebAssembly] Fix faulty logic in verifyRelocTargets
Apr 16 2020, 6:24 PM
aardappel added a comment to D77353: [WebAssembly] Add DW_OP_WASM_location_int.

@saugustine thanks, pushed a fix.

Apr 16 2020, 6:23 PM · debug-info, Restricted Project
aardappel committed rG3eaeebec959e: [WebAssembly] Fix WasmEmitter link error. (authored by aardappel).
[WebAssembly] Fix WasmEmitter link error.
Apr 16 2020, 5:51 PM
aardappel committed rG7bf4248521f1: [WebAssembly] fixed target index strings in DebugInfo test (authored by aardappel).
[WebAssembly] fixed target index strings in DebugInfo test
Apr 16 2020, 5:18 PM
aardappel committed rG48139ebc3a1a: [WebAssembly] Add int32 DW_OP_WASM_location variant (authored by aardappel).
[WebAssembly] Add int32 DW_OP_WASM_location variant
Apr 16 2020, 4:45 PM
aardappel updated the diff for D77353: [WebAssembly] Add DW_OP_WASM_location_int.

updated target index string descriptions

Apr 16 2020, 4:43 PM · debug-info, Restricted Project
aardappel added a comment to D77353: [WebAssembly] Add DW_OP_WASM_location_int.

@sbc100 I'm a fan of small and focussed commits, but not a fan of new functionality without any uses/tests. Given that this commit is not particularly big, I vote to keep it together.

Apr 16 2020, 3:04 PM · debug-info, Restricted Project
aardappel updated the diff for D77353: [WebAssembly] Add DW_OP_WASM_location_int.

Made values more consistently unsigned thru-out.

Apr 16 2020, 1:55 PM · debug-info, Restricted Project
aardappel added a comment to D77353: [WebAssembly] Add DW_OP_WASM_location_int.

Ok, will try to make it more consistently unsigned, given that down the line they will be stored as unsigned anyway. But its still messy, given that at least thru one path they arrive as this TargetIndexLocation which is signed.
Made it explicit in the comments for TargetIndex that these are meant to be unsigned.

Apr 16 2020, 1:55 PM · debug-info, Restricted Project
aardappel updated the diff for D77353: [WebAssembly] Add DW_OP_WASM_location_int.

Changed encoding to use Yury's variadic WasmLocationArg type.

Apr 16 2020, 1:23 PM · debug-info, Restricted Project
aardappel added a comment to D77353: [WebAssembly] Add DW_OP_WASM_location_int.

@yurydelendik one thing about your patch: the variadic argument was previously declared as SignedSizeLEB and emitted with emitSigned, yet your new code reads it as getULEB128 and stores it in an array of uint64_t (which we can't change since its shared code). It doesn't matter much for the current use case, but we might want to be consistent about this storing signed or unsigned values? I see value in it being signed for future use cases, but given the existing DWARFExpression code it may well have to be unsigned.

Apr 16 2020, 12:50 PM · debug-info, Restricted Project
aardappel added a comment to D77353: [WebAssembly] Add DW_OP_WASM_location_int.

@dschuff @paolosev thanks for the feedback, seems we have some consensus on going forward with the single variadic tag. I'll merge in Yury's changes.

Apr 16 2020, 9:27 AM · debug-info, Restricted Project

Apr 13 2020

aardappel updated subscribers of D77353: [WebAssembly] Add DW_OP_WASM_location_int.

@paolosev you may have an opinion on this, given that you're already working with this data as well?

Apr 13 2020, 12:25 PM · debug-info, Restricted Project