This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Delete relOff from TargetInfo::writePLT
ClosedPublic

Authored by MaskRay on Dec 14 2019, 6:07 PM.

Details

Summary

This change only affects EM_386. relOff can be computed from index
easily, so it is unnecessarily passed as a parameter.

Both in.plt and in.iplt entries are written by writePLT. For in.iplt,
the instruction push reloc_offset will change because index is now
different. Fortunately, this does not matter because push; jmp is only
used by PLT. IPLT does not need the code sequence.

Diff Detail

Event Timeline

MaskRay created this revision.Dec 14 2019, 6:07 PM
ruiu accepted this revision.Dec 15 2019, 10:13 PM

LGTM

This revision is now accepted and ready to land.Dec 15 2019, 10:13 PM
grimar accepted this revision.Dec 16 2019, 12:02 AM

LGTM

MaskRay updated this revision to Diff 234109.Dec 16 2019, 11:09 AM
MaskRay edited the summary of this revision. (Show Details)

Update description

This revision was automatically updated to reflect the committed changes.