Page MenuHomePhabricator

[Attributor] Deduce "no-return" function attribute
Needs ReviewPublic

Authored by jdoerfert on Mar 28 2019, 8:09 PM.

Details

Summary

Deduce the "no-return" attribute for functions.

Impact on the statistics (-stats) for LLVM-TS + Spec2006, both no-return functions are in SPEC2006/perlbench:

CHANGED: attributor                   NumAttributesValidFixpoint             25385 ->      26069 (    +2.695%)                                                                                 
  ADDED: attributor                   NumFnNoReturn                            n/a ->          2
CHANGED: prune-eh                     NumUnreach                               499 ->        510 (    +2.204%)

Event Timeline

jdoerfert created this revision.Mar 28 2019, 8:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2019, 8:09 PM
jdoerfert updated this revision to Diff 192920.Mar 29 2019, 2:48 PM

Minor adjustment to prior patches

jdoerfert edited the summary of this revision. (Show Details)Apr 1 2019, 8:23 AM
jdoerfert updated this revision to Diff 193117.Apr 1 2019, 9:55 AM

Minor changes

xbolva00 added inline comments.
llvm/lib/Transforms/IPO/Attributor.cpp
774

llvm::all_of?

jdoerfert marked an inline comment as done.Apr 1 2019, 11:03 AM
jdoerfert added inline comments.
llvm/lib/Transforms/IPO/Attributor.cpp
774

I can change that, it'll probably appear again in other patches for now.

sanjoy removed a reviewer: sanjoy.Apr 1 2019, 11:06 AM