[Attributor] Deduce "no-return" function attribute
Changes PlannedPublic
Actions

Authored by jdoerfert on Mar 28 2019, 8:09 PM.

Details

Reviewers

homerdin
hfinkel
fedor.sergeev
spatel
nlopes
nicholas
reames

Summary

Deduce the "no-return" attribute for functions.

Impact on the statistics (-stats) for LLVM-TS + Spec2006, both no-return functions are in SPEC2006/perlbench:

CHANGED: attributor                   NumAttributesValidFixpoint             25385 ->      26069 (    +2.695%)                                                                                 
  ADDED: attributor                   NumFnNoReturn                            n/a ->          2
CHANGED: prune-eh                     NumUnreach                               499 ->        510 (    +2.204%)

Diff Detail

Repository

rG LLVM Github Monorepo

Build Status

Buildable 29908
Build 29907: arc lint + arc unit

Event Timeline

jdoerfert created this revision.Mar 28 2019, 8:09 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2019, 8:09 PM

Herald added subscribers: bollu, hiraditya. · View Herald Transcript

jdoerfert added a parent revision: D59918: [Attributor] Pass infrastructure and fixpoint framework.Mar 28 2019, 8:09 PM

Harbormaster completed remote builds in B29796: Diff 192773.Mar 28 2019, 8:09 PM

jdoerfert added a parent revision: D59919: [Attributor] Deduce "returned" argument attribute.Mar 28 2019, 8:09 PM

jdoerfert added a parent revision: D60012: [Attributor] Introduce bit-encodings for abstract states.Mar 29 2019, 2:45 PM

Minor adjustment to prior patches

Harbormaster completed remote builds in B29849: Diff 192920.Mar 29 2019, 2:49 PM

jdoerfert edited the summary of this revision. (Show Details)Apr 1 2019, 8:23 AM

Minor changes

Harbormaster completed remote builds in B29908: Diff 193117.Apr 1 2019, 9:55 AM

xbolva00 added a subscriber: xbolva00.Apr 1 2019, 10:19 AM

xbolva00 added inline comments.

llvm/lib/Transforms/IPO/Attributor.cpp
774	llvm::all_of?

jdoerfert marked an inline comment as done.Apr 1 2019, 11:03 AM

jdoerfert added inline comments.

llvm/lib/Transforms/IPO/Attributor.cpp
774	I can change that, it'll probably appear again in other patches for now.

sanjoy removed a reviewer: sanjoy.Apr 1 2019, 11:06 AM

uenoku added a child revision: D63046: [Attributor] Deduce "willreturn" function attribute.Jun 10 2019, 6:24 AM

I'll update this one after AAIsDead is available (see D64162).

jdoerfert removed a child revision: D63046: [Attributor] Deduce "willreturn" function attribute.Wed, Jul 10, 7:19 PM

sstefan1 added a subscriber: sstefan1.Tue, Jul 16, 9:31 AM

Revision Contents
Changeset List

			Path	Packages
M			llvm/lib/Transforms/IPO/Attributor.cpp (153 lines)
M			llvm/test/Transforms/FunctionAttrs/arg_nocapture.ll (5 lines)
M			llvm/test/Transforms/FunctionAttrs/arg_returned.ll (7 lines)
M			llvm/test/Transforms/FunctionAttrs/fn_noreturn.ll (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	192773	5443cd7		Mar 28 2019, 8:08 PM	★	★
Diff 2	192920	d0c6a5a	Minor adjustment to prior patches	Mar 29 2019, 2:48 PM	★	★
Diff 3	193117	8536d27	Minor changes	Apr 1 2019, 9:55 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
0447db5f36f3	1f91734333ea	8536d2705565	Johannes Doerfert	[Attributor] Deduce "no-return" function attribute (Show More…)	Mar 27 2019, 5:20 PM

Status	Author	Revision
Closed	uenoku	D63372 Use "willreturn" function attribute in isGuaranteedToTransferExecutionToSuccessor
Needs Review	jdoerfert	D60073 [Attributor] Enable backwards propagation from callback callees.
Needs Review	jdoerfert	D60072 [Attributor] Deduce "no-capture" attributes for call site arguments
Needs Review	jdoerfert	D60078 [FunctionAttrs] Remove old "no-capture" and memory behavior argument deduction
Needs Review	jdoerfert	D60077 [Attributor] Deduce memory location function attributes
Needs Review	jdoerfert	D60076 [Attributor] Deduce memory behavior function attributes
Needs Review	jdoerfert	D59980 [Attributor] Deduce memory behavior argument attributes
Needs Review	jdoerfert	D59922 [Attributor] Deduce "no-capture" argument attribute
Abandoned	jdoerfert	D59979 [Attributor][NFC] Add helper functions to deal wit bit-encodings
Needs Review	jdoerfert	D60075 [FunctionAttrs] Remove post order "no-recurse" attribute deduction
Closed	uenoku	D63046 [Attributor] Deduce "willreturn" function attribute
Closed	uenoku	D62801 Add "willreturn" function attribute
Abandoned	jdoerfert	D60074 [Attributor] Deduce "no-recurse" function attribute
Needs Review	jdoerfert	D59920 [FunctionAttrs] Remove old "returned" argument deduction
Closed	uenoku	D63604 [Attributor] Deduce "nonnull" attribute
Changes Planned	jdoerfert	D59978 [Attributor] Deduce "no-return" function attribute
Closed	jdoerfert	D59919 [Attributor] Deduce "returned" argument attribute
Closed	jdoerfert	D59917 [SelectionDAG][FIX] Allow "returned" arguments to be bit-casted
Closed	jdoerfert	D60012 [Attributor] Introduce bit-encodings for abstract states
Closed	jdoerfert	D59918 [Attributor] Pass infrastructure and fixpoint framework
Closed	jdoerfert	D59903 [NFC][FnAttrs] Stress tests for attribute deduction