Page MenuHomePhabricator

uenoku (Hideto Ueno)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2019, 5:25 AM (27 w, 5 d)

Recent Activity

Mon, Sep 16

uenoku committed rG30d86f1858db: [Attributor] Use Alias Analysis in noalias callsite argument deduction (authored by uenoku).
[Attributor] Use Alias Analysis in noalias callsite argument deduction
Mon, Sep 16, 11:53 PM
uenoku committed rL372075: [Attributor] Use Alias Analysis in noalias callsite argument deduction.
[Attributor] Use Alias Analysis in noalias callsite argument deduction
Mon, Sep 16, 11:52 PM
uenoku closed D67604: [Attributor] Use Alias Analysis in noalias callsite argument deduction.
Mon, Sep 16, 11:52 PM · Restricted Project
uenoku updated the diff for D67604: [Attributor] Use Alias Analysis in noalias callsite argument deduction.

Hoist

Mon, Sep 16, 11:23 PM · Restricted Project
uenoku committed rG3bb5cbc20b57: [Attributor] Create helper struct for handling analysis getters (authored by uenoku).
[Attributor] Create helper struct for handling analysis getters
Mon, Sep 16, 10:46 PM
uenoku committed rL372072: [Attributor] Create helper struct for handling analysis getters.
[Attributor] Create helper struct for handling analysis getters
Mon, Sep 16, 10:43 PM
uenoku closed D67603: [Attributor] Create helper struct for handling analysis getters.
Mon, Sep 16, 10:43 PM · Restricted Project
uenoku added inline comments to D67604: [Attributor] Use Alias Analysis in noalias callsite argument deduction.
Mon, Sep 16, 5:52 AM · Restricted Project
uenoku updated the diff for D67603: [Attributor] Create helper struct for handling analysis getters.

Pass FAM to AnalysisGetter.

Mon, Sep 16, 12:55 AM · Restricted Project

Sun, Sep 15

uenoku created D67604: [Attributor] Use Alias Analysis in noalias callsite argument deduction.
Sun, Sep 15, 11:01 PM · Restricted Project
uenoku added a comment to D67384: [Attributor] Deduce memory behavior.

Overall, I think the logic is sound.

Sun, Sep 15, 9:42 PM · Restricted Project
uenoku updated the summary of D67603: [Attributor] Create helper struct for handling analysis getters.
Sun, Sep 15, 8:47 PM · Restricted Project
uenoku added a reviewer for D67603: [Attributor] Create helper struct for handling analysis getters: sstefan1.
Sun, Sep 15, 8:45 PM · Restricted Project
uenoku created D67603: [Attributor] Create helper struct for handling analysis getters.
Sun, Sep 15, 8:45 PM · Restricted Project

Wed, Sep 11

uenoku committed rG1d68ed8c24e3: [Attributor] Implement "noalias" callsite argument deduction (authored by uenoku).
[Attributor] Implement "noalias" callsite argument deduction
Wed, Sep 11, 12:01 AM

Tue, Sep 10

uenoku committed rL371590: [Attributor] Implement "noalias" callsite argument deduction.
[Attributor] Implement "noalias" callsite argument deduction
Tue, Sep 10, 11:59 PM
uenoku closed D67286: [Attributor] Implement "noalias" callsite argument deduction.
Tue, Sep 10, 11:59 PM · Restricted Project
uenoku committed rG373676465787: [Attributor][Fix] Manifest nocapture only in CSArgument or Argument (authored by uenoku).
[Attributor][Fix] Manifest nocapture only in CSArgument or Argument
Tue, Sep 10, 11:52 PM
uenoku committed rL371589: [Attributor][Fix] Manifest nocapture only in CSArgument or Argument.
[Attributor][Fix] Manifest nocapture only in CSArgument or Argument
Tue, Sep 10, 11:52 PM
uenoku closed D67342: [Attributor][Fix] Manifest nocapture only in CSArgument or Argument.
Tue, Sep 10, 11:52 PM · Restricted Project
uenoku accepted D67231: [Attributor][Fix] Use right type to replace expressions.

LGTM.

Tue, Sep 10, 1:28 AM · Restricted Project
uenoku added a comment to D67342: [Attributor][Fix] Manifest nocapture only in CSArgument or Argument.

Test missing.

Yes, test is missing but I think test is not necessary. If we query whether a callsite retured value is captured in the scope and the value has nocapture, this kind of error will be raised.

Tue, Sep 10, 1:20 AM · Restricted Project

Mon, Sep 9

uenoku added inline comments to D67286: [Attributor] Implement "noalias" callsite argument deduction.
Mon, Sep 9, 2:53 AM · Restricted Project
uenoku updated the diff for D67286: [Attributor] Implement "noalias" callsite argument deduction.

Remove nocapture related change

Mon, Sep 9, 2:44 AM · Restricted Project
uenoku created D67342: [Attributor][Fix] Manifest nocapture only in CSArgument or Argument.
Mon, Sep 9, 2:18 AM · Restricted Project

Sat, Sep 7

uenoku updated the diff for D67286: [Attributor] Implement "noalias" callsite argument deduction.

Add test

Sat, Sep 7, 8:17 AM · Restricted Project
uenoku committed rGf2b9dc4758e6: [Attributor] ValueSimplify Abstract Attribute (authored by uenoku).
[Attributor] ValueSimplify Abstract Attribute
Sat, Sep 7, 12:06 AM
uenoku committed rL371291: [Attributor] ValueSimplify Abstract Attribute.
[Attributor] ValueSimplify Abstract Attribute
Sat, Sep 7, 12:01 AM
uenoku closed D66967: [Attributor] ValueSimplify Abstract Attribute.
Sat, Sep 7, 12:01 AM · Restricted Project

Fri, Sep 6

uenoku updated the diff for D66967: [Attributor] ValueSimplify Abstract Attribute.

Minor update.

Fri, Sep 6, 11:52 PM · Restricted Project
uenoku added inline comments to D67286: [Attributor] Implement "noalias" callsite argument deduction.
Fri, Sep 6, 11:11 AM · Restricted Project
uenoku added a comment to D67272: [Attributor] Add NoCaptureCallSiteArgument in default.

Do we really need this? I mean, you can query the information and the attribute is created on-demand, right?

On second thought, it makes sense to have it so I'm fine with this but still would like to know the answer to the question above.

Fri, Sep 6, 10:45 AM · Restricted Project
uenoku added inline comments to D66967: [Attributor] ValueSimplify Abstract Attribute.
Fri, Sep 6, 10:18 AM · Restricted Project
uenoku added inline comments to D67286: [Attributor] Implement "noalias" callsite argument deduction.
Fri, Sep 6, 9:18 AM · Restricted Project
uenoku created D67286: [Attributor] Implement "noalias" callsite argument deduction.
Fri, Sep 6, 9:13 AM · Restricted Project
uenoku created D67272: [Attributor] Add NoCaptureCallSiteArgument in default.
Fri, Sep 6, 6:06 AM · Restricted Project
uenoku added inline comments to D66967: [Attributor] ValueSimplify Abstract Attribute.
Fri, Sep 6, 1:38 AM · Restricted Project

Thu, Sep 5

uenoku added a comment to D66967: [Attributor] ValueSimplify Abstract Attribute.

Change to return the original value when in the pessimistic state.

Did this change the test?

Thu, Sep 5, 12:09 PM · Restricted Project
uenoku added inline comments to D66967: [Attributor] ValueSimplify Abstract Attribute.
Thu, Sep 5, 12:02 PM · Restricted Project
uenoku updated the diff for D66967: [Attributor] ValueSimplify Abstract Attribute.

Change to return the original value when in the pessimistic state.

Thu, Sep 5, 11:57 AM · Restricted Project
uenoku added inline comments to D66967: [Attributor] ValueSimplify Abstract Attribute.
Thu, Sep 5, 1:31 AM · Restricted Project

Tue, Sep 3

uenoku updated the diff for D66967: [Attributor] ValueSimplify Abstract Attribute.

Address comment and add test for undef.

Tue, Sep 3, 10:22 PM · Restricted Project
uenoku accepted D67115: [Attributor] Deal more explicit with non-exact definitions.
Tue, Sep 3, 9:21 PM · Restricted Project
uenoku added a comment to D67115: [Attributor] Deal more explicit with non-exact definitions.

LGTM

Tue, Sep 3, 9:21 PM · Restricted Project
uenoku added inline comments to D66967: [Attributor] ValueSimplify Abstract Attribute.
Tue, Sep 3, 10:06 AM · Restricted Project
uenoku updated the diff for D66967: [Attributor] ValueSimplify Abstract Attribute.

Address comment. Add simple test for phi and select.

Tue, Sep 3, 10:01 AM · Restricted Project
uenoku added inline comments to D66967: [Attributor] ValueSimplify Abstract Attribute.
Tue, Sep 3, 9:23 AM · Restricted Project

Mon, Sep 2

uenoku accepted D59922: [Attributor] Deduce "no-capture" argument attribute.

I think the logic is sound. It looks good to me.

Mon, Sep 2, 4:28 AM · Restricted Project, Restricted Project
uenoku accepted D66833: [Attributor] Use the delete API for liveness.

LGTM

Mon, Sep 2, 3:35 AM · Restricted Project

Sun, Sep 1

uenoku added inline comments to D66967: [Attributor] ValueSimplify Abstract Attribute.
Sun, Sep 1, 7:20 AM · Restricted Project
uenoku updated the diff for D66967: [Attributor] ValueSimplify Abstract Attribute.

Address comment

Sun, Sep 1, 7:13 AM · Restricted Project

Fri, Aug 30

uenoku added inline comments to D66967: [Attributor] ValueSimplify Abstract Attribute.
Fri, Aug 30, 7:26 AM · Restricted Project
uenoku updated the diff for D66967: [Attributor] ValueSimplify Abstract Attribute.

Address comment and refactor.

Fri, Aug 30, 7:15 AM · Restricted Project
uenoku committed rG6381b143f6cc: [Attributor] Implement AANoAliasCallSiteArgument initialization (authored by uenoku).
[Attributor] Implement AANoAliasCallSiteArgument initialization
Fri, Aug 30, 3:02 AM
uenoku committed rL370456: [Attributor] Implement AANoAliasCallSiteArgument initialization.
[Attributor] Implement AANoAliasCallSiteArgument initialization
Fri, Aug 30, 3:02 AM
uenoku closed D66927: [Attributor] Implement AANoAliasCallSiteArgument initialization.
Fri, Aug 30, 3:02 AM · Restricted Project

Thu, Aug 29

uenoku accepted D66914: [Attributor] Look at internal functions only on-demand.

LGTM

Thu, Aug 29, 11:58 AM · Restricted Project
uenoku added reviewers for D59922: [Attributor] Deduce "no-capture" argument attribute: uenoku, sstefan1.
Thu, Aug 29, 11:51 AM · Restricted Project, Restricted Project
uenoku added inline comments to D66927: [Attributor] Implement AANoAliasCallSiteArgument initialization.
Thu, Aug 29, 11:39 AM · Restricted Project
uenoku added a comment to D66967: [Attributor] ValueSimplify Abstract Attribute.

First prototype of value simplify attribute is here. I'll add additional test later.

Thu, Aug 29, 11:29 AM · Restricted Project
uenoku created D66967: [Attributor] ValueSimplify Abstract Attribute.
Thu, Aug 29, 11:27 AM · Restricted Project
uenoku added inline comments to D66833: [Attributor] Use the delete API for liveness.
Thu, Aug 29, 8:16 AM · Restricted Project
uenoku accepted D66781: [Attributor] Use existing function information for the call site.

LGTM

Thu, Aug 29, 8:16 AM · Restricted Project
uenoku accepted D66913: [Attributor] Use the whitelist for attributes consistently.

LGTM

Thu, Aug 29, 7:53 AM · Restricted Project
uenoku added inline comments to D66913: [Attributor] Use the whitelist for attributes consistently.
Thu, Aug 29, 12:18 AM · Restricted Project
uenoku created D66927: [Attributor] Implement AANoAliasCallSiteArgument initialization.
Thu, Aug 29, 12:11 AM · Restricted Project

Wed, Aug 28

uenoku committed rGcbab334e403b: [Attributor] Deduce "noalias" attribute (authored by uenoku).
[Attributor] Deduce "noalias" attribute
Wed, Aug 28, 10:52 PM
uenoku committed rL370295: [Attributor] Deduce "noalias" attribute.
[Attributor] Deduce "noalias" attribute
Wed, Aug 28, 10:51 PM
uenoku closed D66207: [Attributor] Deduce "noalias" attribute.
Wed, Aug 28, 10:51 PM · Restricted Project
uenoku added inline comments to D66914: [Attributor] Look at internal functions only on-demand.
Wed, Aug 28, 10:34 PM · Restricted Project
uenoku accepted D66922: [Attributor] Manifest load/store alignment generally.

LGTM

Wed, Aug 28, 10:29 PM · Restricted Project
uenoku updated the diff for D66207: [Attributor] Deduce "noalias" attribute.

Fix.

Wed, Aug 28, 9:59 PM · Restricted Project
uenoku updated the diff for D66207: [Attributor] Deduce "noalias" attribute.

Minor update

Wed, Aug 28, 9:48 PM · Restricted Project
uenoku updated the diff for D66207: [Attributor] Deduce "noalias" attribute.

Address comment

Wed, Aug 28, 9:39 PM · Restricted Project
uenoku set the repository for D66207: [Attributor] Deduce "noalias" attribute to rG LLVM Github Monorepo.
Wed, Aug 28, 10:27 AM · Restricted Project
uenoku added inline comments to D66207: [Attributor] Deduce "noalias" attribute.
Wed, Aug 28, 7:49 AM · Restricted Project
uenoku added inline comments to D66207: [Attributor] Deduce "noalias" attribute.
Wed, Aug 28, 4:31 AM · Restricted Project
uenoku updated the diff for D66207: [Attributor] Deduce "noalias" attribute.

Rebase and add test.

Wed, Aug 28, 4:25 AM · Restricted Project

Mon, Aug 26

uenoku committed rG8dad6157fbe7: [ValueTracking] Add AllowNonInbounds parameter to… (authored by uenoku).
[ValueTracking] Add AllowNonInbounds parameter to…
Mon, Aug 26, 11:39 PM
uenoku committed rL370016: [ValueTracking] Add AllowNonInbounds parameter to….
[ValueTracking] Add AllowNonInbounds parameter to…
Mon, Aug 26, 11:39 PM
uenoku committed rL370015: [Attributor] Clamp operator to extend known state.
[Attributor] Clamp operator to extend known state
Mon, Aug 26, 11:11 PM
uenoku committed rGc395c9172fcb: [Attributor] Clamp operator to extend known state (authored by uenoku).
[Attributor] Clamp operator to extend known state
Mon, Aug 26, 11:08 PM
uenoku closed D66635: [Attributor] Clamp operator to extend known state.
Mon, Aug 26, 11:08 PM · Restricted Project
uenoku added a comment to D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.

I still think we should try to look only at (transitive) uses of the associated value instead of visiting all instructions and figuring out for each if it is interesting. You know what I mean?

Tracking transitive uses is also good to me but I'm not sure there is an API to (efficiently) determine whether use of the associated value belongs to the context. Isn't it same to iterator over the instructions in the context?

Mon, Aug 26, 9:23 PM · Restricted Project
uenoku abandoned D66753: [MustExec] Add simple backward support to MustBeExecutedContextExplorer.

This is not (a stripped down version of) the code in D64975 which does the same thing, correct?

Mon, Aug 26, 11:01 AM · Restricted Project
uenoku accepted D66757: [Attributor] Adjust and test the iteration bound of tests.

LGTM

Mon, Aug 26, 10:56 AM · Restricted Project
uenoku created D66753: [MustExec] Add simple backward support to MustBeExecutedContextExplorer.
Mon, Aug 26, 10:25 AM · Restricted Project
uenoku updated the diff for D65860: [Attributor] Add LoopInfo to InformationCache and improve willreturn deduction.

Address comment

Mon, Aug 26, 5:01 AM · Restricted Project

Sun, Aug 25

uenoku updated the diff for D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.

Apply to call site argument or floating value also.

Sun, Aug 25, 11:08 PM · Restricted Project

Fri, Aug 23

uenoku updated the diff for D66645: [Attributor] Add helper class to compose two structured deduction..

Minor update.

Fri, Aug 23, 11:34 PM · Restricted Project
uenoku added a child revision for D66635: [Attributor] Clamp operator to extend known state: D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.
Fri, Aug 23, 11:19 PM · Restricted Project
uenoku edited parent revisions for D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer, added: 2; removed: 1.
Fri, Aug 23, 11:19 PM · Restricted Project
uenoku added a child revision for D66645: [Attributor] Add helper class to compose two structured deduction.: D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.
Fri, Aug 23, 11:19 PM · Restricted Project
uenoku removed a child revision for D65186: [MustExec] Add a generic "must-be-executed-context" explorer: D65402: [Attributor][MustExec] Deduce dereferenceable and nonnull attribute using MustBeExecutedContextExplorer.
Fri, Aug 23, 11:19 PM · Restricted Project
uenoku accepted D66558: [Attributor] Deal with shrinking dereferenceability in a loop.

LGTM

Fri, Aug 23, 8:53 AM · Restricted Project
uenoku added a comment to D66567: [Attributor] Manifest alignment in load and store instructions.

LGTM

Fri, Aug 23, 8:51 AM · Restricted Project
uenoku accepted D66567: [Attributor] Manifest alignment in load and store instructions.
Fri, Aug 23, 8:51 AM · Restricted Project
uenoku created D66645: [Attributor] Add helper class to compose two structured deduction..
Fri, Aug 23, 5:32 AM · Restricted Project
uenoku created D66635: [Attributor] Clamp operator to extend known state.
Fri, Aug 23, 3:05 AM · Restricted Project

Thu, Aug 22

Herald added a project to D50125: [FunctionAttrs] Annotate function arguments with call site information: Restricted Project.
Thu, Aug 22, 10:06 AM · Restricted Project