Page MenuHomePhabricator

homerdin (Brian Homerding)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 9 2017, 1:55 PM (113 w, 4 d)

Recent Activity

Jul 8 2019

homerdin committed rG498687bff2b4: Add, and infer, a nofree function attribute (authored by homerdin).
Add, and infer, a nofree function attribute
Jul 8 2019, 9:35 AM
homerdin committed rL365345: Add, and infer, a nofree function attribute.
Add, and infer, a nofree function attribute
Jul 8 2019, 9:34 AM
homerdin committed rGe6ba22542f28: Add nofree attribute to CodeGenOpenCL/convergent.cl test (authored by homerdin).
Add nofree attribute to CodeGenOpenCL/convergent.cl test
Jul 8 2019, 9:26 AM
homerdin committed rL365341: Add nofree attribute to CodeGenOpenCL/convergent.cl test.
Add nofree attribute to CodeGenOpenCL/convergent.cl test
Jul 8 2019, 9:24 AM
homerdin committed rGb4b21d807e4f: Add, and infer, a nofree function attribute (authored by homerdin).
Add, and infer, a nofree function attribute
Jul 8 2019, 9:02 AM
homerdin committed rL365336: Add, and infer, a nofree function attribute.
Add, and infer, a nofree function attribute
Jul 8 2019, 8:58 AM
homerdin closed D49165: Add, and infer, a nofree function attribute.
Jul 8 2019, 8:58 AM · Restricted Project

Jun 17 2019

homerdin updated the diff for D49165: Add, and infer, a nofree function attribute.

I moved the logic for library functions to inferLibFuncAttributes, added a note to TargetLibraryInfo.def and updated the tests

Jun 17 2019, 10:29 AM · Restricted Project
homerdin added a comment to D49165: Add, and infer, a nofree function attribute.

@uenoku Sure. I'm working on moving the logic for library functions to inferLibFuncAttributes, but I can add that in later.

Jun 17 2019, 7:28 AM · Restricted Project

Jun 12 2019

homerdin updated the diff for D49165: Add, and infer, a nofree function attribute.

Rebased

Jun 12 2019, 1:08 PM · Restricted Project
homerdin commandeered D49165: Add, and infer, a nofree function attribute.

Going to rebase this.

Jun 12 2019, 1:08 PM · Restricted Project

Jun 10 2019

homerdin added inline comments to D43314: [lit] - Allow 1 test to report multiple micro-test results to provide support for microbenchmarks..
Jun 10 2019, 7:30 AM · Restricted Project

May 13 2019

homerdin added a comment to D61673: Fixed creation of aliases in Windows build.

Hi. I'm seeing a cmake failure now, it looks like the last parenthesis was dropped. LIBDIR})"), LIBDIR})"

May 13 2019, 9:53 AM · Restricted Project, Restricted Project

Apr 4 2019

homerdin committed rT357704: [test-suite] Update test-suite microbenchmarks to use JSON (fix bug 41327).
[test-suite] Update test-suite microbenchmarks to use JSON (fix bug 41327)
Apr 4 2019, 8:12 AM
homerdin committed rL357704: [test-suite] Update test-suite microbenchmarks to use JSON (fix bug 41327).
[test-suite] Update test-suite microbenchmarks to use JSON (fix bug 41327)
Apr 4 2019, 8:12 AM

Apr 3 2019

homerdin created D60205: [test-suite] Update test-suite microbenchmarks to use JSON (fix bug 41327).
Apr 3 2019, 8:14 AM

Jan 28 2019

homerdin committed rT352375: [test-suite] Adding CoMD Proxy App.
[test-suite] Adding CoMD Proxy App
Jan 28 2019, 7:48 AM
homerdin committed rL352375: [test-suite] Adding CoMD Proxy App.
[test-suite] Adding CoMD Proxy App
Jan 28 2019, 7:18 AM

Dec 21 2018

homerdin committed rT349925: [test-suite] Revert rL349493 (Adding CoMD Proxy App).
[test-suite] Revert rL349493 (Adding CoMD Proxy App)
Dec 21 2018, 9:05 AM
homerdin committed rL349925: [test-suite] Revert rL349493 (Adding CoMD Proxy App).
[test-suite] Revert rL349493 (Adding CoMD Proxy App)
Dec 21 2018, 9:05 AM
homerdin added a reverting change for rL349493: [test-suite] Adding CoMD Proxy App: rL349925: [test-suite] Revert rL349493 (Adding CoMD Proxy App).
Dec 21 2018, 9:05 AM
homerdin committed rT349922: [test-suite] Adding CoMD Proxy App.
[test-suite] Adding CoMD Proxy App
Dec 21 2018, 8:41 AM
homerdin committed rL349922: [test-suite] Adding CoMD Proxy App.
[test-suite] Adding CoMD Proxy App
Dec 21 2018, 8:34 AM

Dec 18 2018

homerdin committed rT349507: [test-suite] Revert rL349493 (Adding CoMD Proxy App).
[test-suite] Revert rL349493 (Adding CoMD Proxy App)
Dec 18 2018, 8:56 AM
homerdin added a reverting change for rL349493: [test-suite] Adding CoMD Proxy App: rL349507: [test-suite] Revert rL349493 (Adding CoMD Proxy App).
Dec 18 2018, 8:56 AM
homerdin committed rL349507: [test-suite] Revert rL349493 (Adding CoMD Proxy App).
[test-suite] Revert rL349493 (Adding CoMD Proxy App)
Dec 18 2018, 8:56 AM
homerdin committed rT349505: [test-suite] Adding CoMD Proxy App.
[test-suite] Adding CoMD Proxy App
Dec 18 2018, 8:19 AM
homerdin committed rL349505: [test-suite] Adding CoMD Proxy App.
[test-suite] Adding CoMD Proxy App
Dec 18 2018, 8:18 AM
homerdin committed rT349493: [test-suite] Adding CoMD Proxy App.
[test-suite] Adding CoMD Proxy App
Dec 18 2018, 7:26 AM
homerdin committed rL349493: [test-suite] Adding CoMD Proxy App.
[test-suite] Adding CoMD Proxy App
Dec 18 2018, 7:25 AM
homerdin closed D55726: [test-suite] Adding CoMD Proxy App.
Dec 18 2018, 7:25 AM

Dec 15 2018

homerdin added inline comments to D55726: [test-suite] Adding CoMD Proxy App.
Dec 15 2018, 8:06 AM
homerdin updated the diff for D55726: [test-suite] Adding CoMD Proxy App.

Thanks for the review!

Dec 15 2018, 7:54 AM

Dec 14 2018

homerdin created D55726: [test-suite] Adding CoMD Proxy App.
Dec 14 2018, 3:01 PM

Nov 14 2018

homerdin added a comment to D53565: Configure only needed part of test-suite during running subtests.

I would definitely like to be able to specify a specific subset of the test-suite, however I'd try to avoid an additional control macro if we can extend the current ones.

Nov 14 2018, 8:49 AM

Oct 17 2018

homerdin added inline comments to D53030: [MicroBenchmark] Add initial LoopInterchange test/benchmark..
Oct 17 2018, 7:16 AM

Sep 13 2018

homerdin added a child revision for D48386: [clang] Mark libm functions writeonly when we care about errno: D52042: [PartiallyInlineLibCalls] Remove WriteOnly attribute before adding ReadNone.
Sep 13 2018, 8:58 AM
homerdin added a parent revision for D52042: [PartiallyInlineLibCalls] Remove WriteOnly attribute before adding ReadNone: D48386: [clang] Mark libm functions writeonly when we care about errno.
Sep 13 2018, 8:58 AM
homerdin created D52042: [PartiallyInlineLibCalls] Remove WriteOnly attribute before adding ReadNone.
Sep 13 2018, 8:57 AM

Sep 12 2018

homerdin updated the diff for D46313: [clang] Add WriteOnly attribute.

Added additional tests and addressed the inline comments

Sep 12 2018, 2:28 PM

Sep 5 2018

homerdin added a comment to D48388: [EarlyCSE] Understand WriteOnly function calls in EarlyCSE with MSSA.

@xbolva00
I ended up not adding a helper function after looking at the existing ones because it won't simplify the code. To follow the current pattern for the helper functions:

Sep 5 2018, 7:51 AM
homerdin updated the diff for D48388: [EarlyCSE] Understand WriteOnly function calls in EarlyCSE with MSSA.

Fixed indentation, added a test and expanded the summary to explain the difference between early-cse and early-cse-memssa.

Sep 5 2018, 7:45 AM

Aug 31 2018

homerdin added inline comments to D51465: Revamp test-suite documentation.
Aug 31 2018, 10:37 AM

Aug 30 2018

homerdin accepted D51465: Revamp test-suite documentation.

Thanks for working on this! LGTM

Aug 30 2018, 2:55 PM

Aug 29 2018

homerdin updated the diff for D48386: [clang] Mark libm functions writeonly when we care about errno.

Rebased and updated to use new name for WriteOnly attribute.

Aug 29 2018, 1:40 PM
homerdin updated the diff for D46313: [clang] Add WriteOnly attribute.

Rebased. Updated wording in documentation

Aug 29 2018, 8:30 AM

Aug 23 2018

homerdin committed rL340537: [FunctionAttrs] Infer WriteOnly Function Attribute.
[FunctionAttrs] Infer WriteOnly Function Attribute
Aug 23 2018, 8:06 AM
homerdin closed D48387: [FunctionAttrs] Infer WriteOnly Function Attribute .
Aug 23 2018, 8:06 AM

Aug 21 2018

homerdin accepted D51020: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++.

LGTM. Thanks for fixing this

Aug 21 2018, 7:08 AM

Aug 1 2018

homerdin added inline comments to D46313: [clang] Add WriteOnly attribute.
Aug 1 2018, 2:13 PM
homerdin updated the diff for D46313: [clang] Add WriteOnly attribute.

I've added some additional test including semantic tests.

Aug 1 2018, 2:06 PM

Jul 30 2018

homerdin committed rL338302: [test-suite] Removing Rodinia from Makefile build due to buildbot failures..
[test-suite] Removing Rodinia from Makefile build due to buildbot failures.
Jul 30 2018, 1:42 PM
homerdin committed rT338302: [test-suite] Removing Rodinia from Makefile build due to buildbot failures..
[test-suite] Removing Rodinia from Makefile build due to buildbot failures.
Jul 30 2018, 1:42 PM
homerdin committed rT338289: [test-suite] Add Makefile for Rodinia Benchmarks.
[test-suite] Add Makefile for Rodinia Benchmarks
Jul 30 2018, 12:09 PM
homerdin committed rL338289: [test-suite] Add Makefile for Rodinia Benchmarks.
[test-suite] Add Makefile for Rodinia Benchmarks
Jul 30 2018, 12:07 PM

Jul 27 2018

homerdin committed rL338169: [test-suite] Add srad kernel from Rodinia Benchmark.
[test-suite] Add srad kernel from Rodinia Benchmark
Jul 27 2018, 2:44 PM
homerdin committed rT338169: [test-suite] Add srad kernel from Rodinia Benchmark.
[test-suite] Add srad kernel from Rodinia Benchmark
Jul 27 2018, 2:44 PM
homerdin closed D49891: [test-suite] Added srad kernel from Rodinia Benchmark.
Jul 27 2018, 2:44 PM
homerdin closed D49891: [test-suite] Added srad kernel from Rodinia Benchmark.
Jul 27 2018, 2:44 PM
homerdin committed rT338168: [test-suite] Add hotspot kernel from Rodinia Benchmark.
[test-suite] Add hotspot kernel from Rodinia Benchmark
Jul 27 2018, 2:40 PM
homerdin committed rL338168: [test-suite] Add hotspot kernel from Rodinia Benchmark.
[test-suite] Add hotspot kernel from Rodinia Benchmark
Jul 27 2018, 2:40 PM
homerdin closed D49894: [test-suite] Added hotspot kernel from Rodinia Benchmark.
Jul 27 2018, 2:40 PM
homerdin committed rT338167: [test-suite] Add common files required by kernels of Rodinia Benchmark.
[test-suite] Add common files required by kernels of Rodinia Benchmark
Jul 27 2018, 2:35 PM
homerdin committed rL338167: [test-suite] Add common files required by kernels of Rodinia Benchmark.
[test-suite] Add common files required by kernels of Rodinia Benchmark
Jul 27 2018, 2:35 PM
homerdin added a reverting change for rT338163: [test-suite] Add common files required by kernels of Rodinia Benchmark: rT338166: [test-suite] revert rT338163 (Add common files required by kernels of Rodinia….
Jul 27 2018, 2:25 PM
homerdin committed rL338166: [test-suite] revert rT338163 (Add common files required by kernels of Rodinia….
[test-suite] revert rT338163 (Add common files required by kernels of Rodinia…
Jul 27 2018, 2:25 PM
homerdin committed rT338166: [test-suite] revert rT338163 (Add common files required by kernels of Rodinia….
[test-suite] revert rT338163 (Add common files required by kernels of Rodinia…
Jul 27 2018, 2:25 PM
homerdin committed rL338163: [test-suite] Add common files required by kernels of Rodinia Benchmark.
[test-suite] Add common files required by kernels of Rodinia Benchmark
Jul 27 2018, 1:45 PM
homerdin committed rT338163: [test-suite] Add common files required by kernels of Rodinia Benchmark.
[test-suite] Add common files required by kernels of Rodinia Benchmark
Jul 27 2018, 1:45 PM
homerdin closed D49896: [test-suite] Added common files requred by kernels of Rodinia Benchmark.
Jul 27 2018, 1:45 PM

Jul 26 2018

homerdin added inline comments to D49503: [test-suite] Add Image Processing Kernels Using Benchmark Library: Dither Algorithms.
Jul 26 2018, 11:42 AM

Jul 25 2018

homerdin updated the diff for D48386: [clang] Mark libm functions writeonly when we care about errno.

Unified the blocks that add WriteOnly and Const attributes

Jul 25 2018, 3:02 PM
homerdin added a parent revision for D48386: [clang] Mark libm functions writeonly when we care about errno: D46313: [clang] Add WriteOnly attribute.
Jul 25 2018, 2:29 PM
homerdin added a child revision for D46313: [clang] Add WriteOnly attribute: D48386: [clang] Mark libm functions writeonly when we care about errno.
Jul 25 2018, 2:29 PM
homerdin updated the diff for D46313: [clang] Add WriteOnly attribute.

Updated documentation

Jul 25 2018, 2:27 PM
homerdin updated the diff for D48387: [FunctionAttrs] Infer WriteOnly Function Attribute .

Fixed typos and added assertion

Jul 25 2018, 2:23 PM
homerdin updated the diff for D48388: [EarlyCSE] Understand WriteOnly function calls in EarlyCSE with MSSA.

Avoiding two dyn_cast.

Jul 25 2018, 2:17 PM

Jun 26 2018

homerdin committed rT335611: [test-suite] Using Google Benchmark Library on Harris Kernel.
[test-suite] Using Google Benchmark Library on Harris Kernel
Jun 26 2018, 8:12 AM
homerdin committed rL335611: [test-suite] Using Google Benchmark Library on Harris Kernel.
[test-suite] Using Google Benchmark Library on Harris Kernel
Jun 26 2018, 8:12 AM
homerdin closed D47675: [test-suite][RFC] Using Google Benchmark Library on Harris Kernel.
Jun 26 2018, 8:12 AM

Jun 25 2018

homerdin added inline comments to D47675: [test-suite][RFC] Using Google Benchmark Library on Harris Kernel.
Jun 25 2018, 11:43 AM

Jun 20 2018

homerdin created D48388: [EarlyCSE] Understand WriteOnly function calls in EarlyCSE with MSSA.
Jun 20 2018, 12:24 PM
homerdin created D48387: [FunctionAttrs] Infer WriteOnly Function Attribute .
Jun 20 2018, 12:16 PM
homerdin updated the diff for D46313: [clang] Add WriteOnly attribute.

Sorry about the slow turn around. I've updated the documentation to be clearer about this attribute's use.

Jun 20 2018, 12:06 PM
homerdin created D48386: [clang] Mark libm functions writeonly when we care about errno.
Jun 20 2018, 12:06 PM

Jun 18 2018

homerdin committed rL334974: [test-suite] Corrections for MiniGMG.
[test-suite] Corrections for MiniGMG
Jun 18 2018, 12:21 PM
homerdin committed rT334974: [test-suite] Corrections for MiniGMG.
[test-suite] Corrections for MiniGMG
Jun 18 2018, 12:20 PM
homerdin committed rT334954: [test-suite] Corrections for MiniGMG.
[test-suite] Corrections for MiniGMG
Jun 18 2018, 9:45 AM
homerdin committed rL334954: [test-suite] Corrections for MiniGMG.
[test-suite] Corrections for MiniGMG
Jun 18 2018, 9:01 AM
homerdin closed D47484: [test-suite] Corrections for MiniGMG.
Jun 18 2018, 9:00 AM

Jun 6 2018

homerdin committed rT334097: [test-suite] Enable MicroBenchmarks by default and enable benchmark library to….
[test-suite] Enable MicroBenchmarks by default and enable benchmark library to…
Jun 6 2018, 7:14 AM
homerdin committed rL334097: [test-suite] Enable MicroBenchmarks by default and enable benchmark library to….
[test-suite] Enable MicroBenchmarks by default and enable benchmark library to…
Jun 6 2018, 7:11 AM

Jun 1 2018

homerdin added inline comments to D47644: [test-suite] Added backprop kernel from Rodinia Benchmark.
Jun 1 2018, 1:51 PM
homerdin added a comment to D47644: [test-suite] Added backprop kernel from Rodinia Benchmark.

We can't rely on the stdlib rand() when verifying. You can include an implementation to use (eg MultiSource/Benchmarks/DOE-ProxyApps-C/miniAMR/glibc_compat_rand) so the output can be verified.

Jun 1 2018, 1:47 PM

May 31 2018

homerdin updated the diff for D47484: [test-suite] Corrections for MiniGMG.

I had removed the periods after getting a FP Comparison failed, not a numeric difference between '.' and '.' " error. They were not the issue and I have added them back in.

May 31 2018, 7:09 AM

May 29 2018

homerdin created D47484: [test-suite] Corrections for MiniGMG.
May 29 2018, 9:24 AM
homerdin updated the diff for D46267: [test-suite] Enable MicroBenchmarks by default.

Added a definition that will prevent the benchmark library from building cxx03_test which will fail when using c++11.

May 29 2018, 7:07 AM

May 24 2018

homerdin committed rL333194: [test-suite] Revert rL333184 (Enable MicroBenchmarks by default and enable….
[test-suite] Revert rL333184 (Enable MicroBenchmarks by default and enable…
May 24 2018, 8:39 AM
homerdin added a reverting change for rL333184: [test-suite] Enable MicroBenchmarks by default and enable benchmark library to…: rL333194: [test-suite] Revert rL333184 (Enable MicroBenchmarks by default and enable….
May 24 2018, 8:39 AM
homerdin committed rT333194: [test-suite] Revert rL333184 (Enable MicroBenchmarks by default and enable….
[test-suite] Revert rL333184 (Enable MicroBenchmarks by default and enable…
May 24 2018, 8:39 AM