This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Cleanups in CORE-V (xcv) extensions
ClosedPublic

Authored by simoncook on Jul 14 2023, 3:07 AM.

Details

Summary

This is a mostly NFC change cleaning up and clarifying components of the
in-tree CORE-V (xcv*) extensions following discussions on the remaining
extensions.

This makes the following changes to the xcbitmanip and xcvmac support:

  1. Add missing extensions from RISCVISAInfo, such that they can be supported in clang's -march option.
  2. Clarify the extension version number is 1.0.0 in documentation.
  3. Clarify the extensions are by OpenHW Group, and the capitilization of the CORE-V extension family.
  4. Add CORE-V to extension name in RISCVFeatures, both to be consistent with other vendors, and also better distinguish e.g. CORE-V bit manipulation vs RISC-V's standard Zb extensions.

Diff Detail

Unit TestsFailed

Event Timeline

simoncook created this revision.Jul 14 2023, 3:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 3:07 AM
simoncook requested review of this revision.Jul 14 2023, 3:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2023, 3:07 AM
asb added a comment.Jul 14 2023, 4:02 AM

The fact this slipped through without an entry in RISCVISAInfo suggests we were missing test coverage in attribute-arch.s and/or attributes.ll for the emitted extension version. Your changes so far all LGTM, but please take a look at those tests. Thanks!

simoncook updated this revision to Diff 540376.Jul 14 2023, 5:29 AM

Add missing extension version tests

This revision is now accepted and ready to land.Jul 14 2023, 9:40 AM
asb accepted this revision.Jul 14 2023, 9:45 AM

LGTM too, thanks.

This revision was landed with ongoing or failed builds.Jul 14 2023, 10:23 AM
This revision was automatically updated to reflect the committed changes.