CMP(A,C)||CMP(B,C) => CMP(MIN/MAX(A,B), C)
CMP(A,C)&&CMP(B,C) => CMP(MIN/MAX(A,B), C)
This first patch handles integer types.
Paths
| Differential D153502
[DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns ClosedPublic Authored by kmitropoulou on Jun 21 2023, 11:40 PM.
Details Summary CMP(A,C)||CMP(B,C) => CMP(MIN/MAX(A,B), C) This first patch handles integer types.
Diff Detail
Event TimelineComment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns as follows: ` CMP(A,C)||CMP(B,C) => CMP(MIN/MAX(A,B), C) CMP(A,C)&&CMP(B,C) => CMP(MIN/MAX(A,B), C) ` This first patch handles integer types. kmitropoulou retitled this revision from [DAGCombiner] Change `foldAndOrOfSETCC()` to optimize and/or patterns as follows: ``` CMP(A,C)||CMP(B,C) => CMP(MIN/MAX(A,B), C) CMP(A,C)&&CMP(B,C) => CMP(MIN/MAX(A,B), C) ``` This first patch handles integer types. to [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns .Jun 21 2023, 11:47 PM kmitropoulou retitled this revision from [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns to [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns. Comment ActionsUpdating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns
Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns craig.topper added inline comments.
Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns kmitropoulou added inline comments.
Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns
Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns kmitropoulou added a parent revision: D153479: [NFC] Tests for future commit in DAGCombiner.Jun 26 2023, 5:12 PM
Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns kmitropoulou added inline comments.
kmitropoulou marked 7 inline comments as done. Comment ActionsUpdating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns
This revision is now accepted and ready to land.Jul 14 2023, 7:48 PM Comment Actions Updating D153502: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns This revision was landed with ongoing or failed builds.Jul 17 2023, 5:14 PM Closed by commit rG4c42ab1199e9: [DAGCombiner] Change foldAndOrOfSETCC() to optimize and/or patterns (authored by kmitropoulou). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 541280 llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
llvm/test/CodeGen/AArch64/vecreduce-bool.ll
llvm/test/CodeGen/AMDGPU/combine-cond-add-sub.ll
llvm/test/CodeGen/AMDGPU/combine_andor_with_cmps.ll
llvm/test/CodeGen/PowerPC/setcc-logic.ll
llvm/test/CodeGen/RISCV/zbb-cmp-combine.ll
llvm/test/CodeGen/X86/movmsk-cmp.ll
|
Remove comma after "Replace"