Page MenuHomePhabricator

ilya (Ilya Mirsky)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 26 2019, 8:48 AM (52 w, 13 h)

Recent Activity

Mar 13 2020

ilya added a comment to D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.

One last kind ping

Mar 13 2020, 7:58 PM · Restricted Project

Feb 17 2020

ilya added a comment to D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.

Ping

Feb 17 2020, 6:25 AM · Restricted Project

Jan 21 2020

ilya added inline comments to D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.
Jan 21 2020, 10:10 AM · Restricted Project

Jan 14 2020

ilya added inline comments to D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.
Jan 14 2020, 2:55 PM · Restricted Project
ilya updated the diff for D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.

Address rsmith's comments.

Jan 14 2020, 2:45 PM · Restricted Project

Jan 6 2020

ilya added a comment to D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.

Kind ping

Jan 6 2020, 10:06 AM · Restricted Project

Dec 23 2019

ilya added a comment to D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.

Implemented @riccibruno's and @rsmith's comments.
While I agree with the general notion about the flaws with the current implementation, I feel that the more major refactoring proposed in this review is out of the scope of this minor fix.

Dec 23 2019, 4:41 PM · Restricted Project
ilya updated the diff for D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.
  1. Refactor CheckArrayAccess() to take AllowPastTheEnd parameter to avoid a false positive array out-of-bounds warning for &(cond ? arr1[N] : arr2[N]).
  2. Use IgnoreParenCasts() instead of IgnoreParenImpCasts() in CheckArrayAccess() to avoid false negatives when explicit cast is involved.
Dec 23 2019, 4:32 PM · Restricted Project
ilya added a comment to D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.

These are not the only AST nodes representing cast expressions (there is also CXXFunctionalCastExpr, ...). What about replacing the IgnoreParenImpCasts() above by IgnoreParenCasts() ? Incidentally doing this uncovers another test (Parser/cxx-ambig-decl-expr.cpp ) where this diagnostic is triggered.

Dec 23 2019, 1:19 PM · Restricted Project
ilya updated the diff for D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token.

Doxygen format the documentation.

Dec 23 2019, 9:43 AM · Restricted Project, Restricted Project
ilya added a comment to D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token.

@aaron.ballman, thanks for reviewing. Do you mind submitting this, as I don't have commit access?

Dec 23 2019, 9:36 AM · Restricted Project, Restricted Project
ilya updated the diff for D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token.

Update LexerUtils.h documentation.

Dec 23 2019, 9:26 AM · Restricted Project, Restricted Project

Dec 19 2019

ilya retitled D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item from [Sema] NFC: Remove trailing spaces and fix a typo in a test file to [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.
Dec 19 2019, 9:33 AM · Restricted Project
ilya created D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item.
Dec 19 2019, 9:23 AM · Restricted Project

Dec 18 2019

ilya added reviewers for D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token: aaron.ballman, alexfh, alexfh_.
Dec 18 2019, 9:41 AM · Restricted Project, Restricted Project
ilya updated the diff for D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token.

Fix documentation in LexerUtils.h

Dec 18 2019, 9:32 AM · Restricted Project, Restricted Project
ilya created D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token.
Dec 18 2019, 9:22 AM · Restricted Project, Restricted Project

Dec 10 2019

ilya added a comment to D69764: [clang-format] Add East/West Const fixer capability.

I think this would likely make everything much more complicated, but perhaps we should think about this for the configuration at least now so we future proof ourselves.

Dec 10 2019, 10:00 AM · Restricted Project, Restricted Project

Dec 9 2019

ilya added a comment to D69764: [clang-format] Add East/West Const fixer capability.

I like the functionality, but am slightly opposed to using "east/west" terminology -- that's not a ubiquitous phrase and it takes a bit of thinking before it makes sense. I think "left/right" is likely to be more universally understood.

Also, should this apply to other qualifiers like volatile or restrict? If so, the name ConstStyle should probably be CVQualifierStyle or something else.

+1.
In addition to volatile and restrict, in my organization we'd also be interested in applying this to address space qualifiers (custom keywords added in our downstream fork). Can this be generalized to accept a map of qualifier keywords and its desired orientation?

Could you give me an example of what you mean?

Dec 9 2019, 3:30 PM · Restricted Project, Restricted Project
ilya added a comment to D69764: [clang-format] Add East/West Const fixer capability.

I like the functionality, but am slightly opposed to using "east/west" terminology -- that's not a ubiquitous phrase and it takes a bit of thinking before it makes sense. I think "left/right" is likely to be more universally understood.

Also, should this apply to other qualifiers like volatile or restrict? If so, the name ConstStyle should probably be CVQualifierStyle or something else.

Dec 9 2019, 12:34 PM · Restricted Project, Restricted Project