Page MenuHomePhabricator

iabg-sc (Ilya Andreev)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 6 2022, 7:58 AM (13 w, 22 h)

Recent Activity

Thu, Nov 24

iabg-sc added a comment to D134277: [RISCV] Combine comparison and logic ops..

Hi!
Could you please review?

Thu, Nov 24, 4:07 AM · Restricted Project, Restricted Project

Thu, Nov 10

iabg-sc updated the diff for D134277: [RISCV] Combine comparison and logic ops..

Rebased to upstream

Thu, Nov 10, 6:01 AM · Restricted Project, Restricted Project

Nov 1 2022

iabg-sc added a comment to D134277: [RISCV] Combine comparison and logic ops..

Hi!
Could you please review?

Nov 1 2022, 2:12 AM · Restricted Project, Restricted Project

Oct 20 2022

iabg-sc updated the diff for D134277: [RISCV] Combine comparison and logic ops..

Removed unnecessary checks. Fixed typos.

Oct 20 2022, 5:07 AM · Restricted Project, Restricted Project
iabg-sc added inline comments to D134277: [RISCV] Combine comparison and logic ops..
Oct 20 2022, 3:20 AM · Restricted Project, Restricted Project

Oct 13 2022

iabg-sc added a comment to D134277: [RISCV] Combine comparison and logic ops..

Thanks for the suggestions. Here is the patch with fixes mentioned before.

Oct 13 2022, 8:23 AM · Restricted Project, Restricted Project
iabg-sc updated the diff for D134277: [RISCV] Combine comparison and logic ops..

Comparison operations are checked via bit fields.
SDNodes were removed. Now all actions only on SDValues.
Some cosmetic changes.

Oct 13 2022, 8:19 AM · Restricted Project, Restricted Project

Oct 11 2022

iabg-sc added a comment to D134277: [RISCV] Combine comparison and logic ops..

Hi!
Could you please review?

Oct 11 2022, 1:48 AM · Restricted Project, Restricted Project

Oct 4 2022

iabg-sc added a comment to D134277: [RISCV] Combine comparison and logic ops..

@asb, @craig.topper, @reames could you please review?

Oct 4 2022, 1:57 AM · Restricted Project, Restricted Project

Sep 27 2022

iabg-sc added inline comments to D134277: [RISCV] Combine comparison and logic ops..
Sep 27 2022, 3:40 AM · Restricted Project, Restricted Project

Sep 22 2022

iabg-sc added reviewers for D134277: [RISCV] Combine comparison and logic ops.: asb, craig.topper, reames.
Sep 22 2022, 5:08 AM · Restricted Project, Restricted Project
iabg-sc updated the diff for D134277: [RISCV] Combine comparison and logic ops..

comment about float support was removed

Sep 22 2022, 5:06 AM · Restricted Project, Restricted Project
iabg-sc updated the diff for D134277: [RISCV] Combine comparison and logic ops..

'.' was removed from commit message

Sep 22 2022, 5:03 AM · Restricted Project, Restricted Project
iabg-sc retitled D134277: [RISCV] Combine comparison and logic ops. from [RISCV] Combining comparison and logic ops. to [RISCV] Combine comparison and logic ops..
Sep 22 2022, 4:03 AM · Restricted Project, Restricted Project
iabg-sc updated the diff for D134277: [RISCV] Combine comparison and logic ops..

Floating point operands are not supported. Typos fix.

Sep 22 2022, 4:00 AM · Restricted Project, Restricted Project
iabg-sc retitled D134277: [RISCV] Combine comparison and logic ops. from [RISCV][test] Combining comparison and logic ops. #17574 to [RISCV] Combining comparison and logic ops..
Sep 22 2022, 3:04 AM · Restricted Project, Restricted Project

Sep 20 2022

iabg-sc updated the diff for D134277: [RISCV] Combine comparison and logic ops..

Fix commit message

Sep 20 2022, 5:48 AM · Restricted Project, Restricted Project
iabg-sc requested review of D134277: [RISCV] Combine comparison and logic ops..
Sep 20 2022, 5:41 AM · Restricted Project, Restricted Project

Sep 8 2022

iabg-sc updated the summary of D133417: [RISCV] Added optimization patterns with Zbb extension.
Sep 8 2022, 2:57 AM · Restricted Project, Restricted Project
iabg-sc added a comment to D133417: [RISCV] Added optimization patterns with Zbb extension.

This patch specific for RISCV. There is no guarantee that min/max will work faster than two comparisons on other archs.
I am not sure how count of the instructions can be increased as pattern explicitly specifies changes from three instructions to two (or three) instructions. Could you please give an example?
xori can be optimized later, but it requires more complex analysis than I suggest in this patch.
Right now I am trying to write self-expanding patterns in TableGen to support most cases.

Sep 8 2022, 2:52 AM · Restricted Project, Restricted Project

Sep 7 2022

iabg-sc updated the summary of D133417: [RISCV] Added optimization patterns with Zbb extension.
Sep 7 2022, 5:24 AM · Restricted Project, Restricted Project
iabg-sc requested review of D133417: [RISCV] Added optimization patterns with Zbb extension.
Sep 7 2022, 5:18 AM · Restricted Project, Restricted Project