Similar to x86.
RISCV legalizing setgt to setlt, so this fold excludes setult,setlt,setule.
For setoeq, may not be the expected
https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/RISCV/float-br-fcmp.ll#L122
Details
Details
- Reviewers
craig.topper asb
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/CodeGen/RISCV/half-select-fcmp.ll | ||
---|---|---|
877 | Here's the regression, which looks easy to fix |
llvm/lib/Target/RISCV/RISCVISelLowering.cpp | ||
---|---|---|
10328 | getSetCCInverse expects the VT of the setcc operands not the VT of the result. This is needed to tell the difference between floating point and integer comparisons. |
Comment Actions
I'm pretty sure a lot of the changes from this patch are miscompiles due to using integer inversion for FP.
Comment Actions
After I changed it correctly and found that this patch is not needed anymore, thanks for review.
getSetCCInverse expects the VT of the setcc operands not the VT of the result. This is needed to tell the difference between floating point and integer comparisons.