This is an archive of the discontinued LLVM Phabricator instance.

[clang][CodeGen] Break up TargetInfo.cpp [7/8]
ClosedPublic

Authored by barannikov88 on May 9 2023, 11:33 AM.

Details

Summary

Wrap calls to XXXTargetCodeGenInfo constructors into factory functions.
This allows moving implementations of TargetCodeGenInfo to dedicated cpp
files without a change.

Diff Detail

Event Timeline

barannikov88 created this revision.May 9 2023, 11:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2023, 11:33 AM
barannikov88 added a comment.EditedMay 9 2023, 12:19 PM

Currently, the functions just forward their arguments to the constructors (*), but I think more stuff
should be pushed into them from createTargetCodeGenInfo. This is left for target maintainers.

Implementations of the added functions will be distributed across *.cpp files in the next commit.

(*) Calls to isStructReturnInRegABI (PPC and X86) were moved because these methods are not
accessible from other TUs.

This revision is now accepted and ready to land.Jun 5 2023, 11:12 AM
This revision was landed with ongoing or failed builds.Jun 16 2023, 9:15 PM
This revision was automatically updated to reflect the committed changes.