This is an archive of the discontinued LLVM Phabricator instance.

[clang][CodeGen] Break up TargetInfo.cpp [1/8]
ClosedPublic

Authored by barannikov88 on Apr 12 2023, 2:26 AM.

Details

Summary

CCState is a helper class originally used by the x86 implementation
but has since been abused by other implementations.
Remove this dependency by implementing customized versions of the class
for implementations that need such functionality.

Diff Detail

Event Timeline

barannikov88 created this revision.Apr 12 2023, 2:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 2:26 AM
Herald added a subscriber: pengfei. · View Herald Transcript
barannikov88 published this revision for review.Apr 12 2023, 3:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 3:34 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
efriedma accepted this revision.Apr 27 2023, 11:20 AM
efriedma added a subscriber: efriedma.

LGTM

This revision is now accepted and ready to land.Apr 27 2023, 11:20 AM
MaskRay accepted this revision.May 2 2023, 3:47 PM
barannikov88 retitled this revision from [clang][CodeGen] Break up TargetInfo.cpp [1/6] to [clang][CodeGen] Break up TargetInfo.cpp [1/7].May 9 2023, 12:18 AM
barannikov88 retitled this revision from [clang][CodeGen] Break up TargetInfo.cpp [1/7] to [clang][CodeGen] Break up TargetInfo.cpp [1/8].May 9 2023, 11:30 AM

Sergei, feel free to start landing patches like this one that were already approved. You don't need the entire sequence to be approved first.

Sergei, feel free to start landing patches like this one that were already approved. You don't need the entire sequence to be approved first.

Ah, OK! I thought it is required.

This revision was landed with ongoing or failed builds.May 19 2023, 1:55 PM
This revision was automatically updated to reflect the committed changes.