This patch supports FCLASS.S, FCLASS.H and FCLASS.D.
Details
Diff Detail
- Repository
 - rG LLVM Github Monorepo
 
Event Timeline
Can you add double and half to this patch? Doesn't seem like it would require very much additional code.
| llvm/lib/Target/RISCV/RISCVISelLowering.cpp | ||
|---|---|---|
| 4216 | Please put this in a separate function. We need to stop putting so much code into this switch.  | |
| llvm/lib/Target/RISCV/RISCVInstrInfo.h | ||
| 278 | Can you reverse the order here so we start with the least significant bit first.  | |
| llvm/lib/Target/RISCV/RISCVInstrInfoF.td | ||
| 33 | Don't use f32 here, you're going to need to change it for double and half. Just use SDTCisFP<1>  | |
| llvm/lib/Target/RISCV/RISCVInstrInfo.h | ||
|---|---|---|
| 269 | Use static constexpr  | |
| llvm/lib/Target/RISCV/RISCVInstrInfo.h | ||
|---|---|---|
| 269 | I think you lost the unsigned?  | |
| llvm/test/CodeGen/RISCV/float-intrinsics.ll | ||
|---|---|---|
| 1546 | clasee?  | |
| llvm/test/CodeGen/RISCV/float-intrinsics.ll | ||
|---|---|---|
| 1546 | I don't think you fixed all the tests?  | |
isnotfinite_fpclasee -> isnotfinite_fpclass
Re-update, I don't know why I didn't modify it correctly just now
| llvm/test/CodeGen/RISCV/float-intrinsics.ll | ||
|---|---|---|
| 1580 | No vector tests  | |
| llvm/test/CodeGen/RISCV/float-intrinsics.ll | ||
|---|---|---|
| 1580 | Thanks. This patch does not involve vectors, I will write another patch for vector support.  | |
Please put this in a separate function. We need to stop putting so much code into this switch.