This is an archive of the discontinued LLVM Phabricator instance.

[NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

Authored by SBallantyne on Jan 23 2023, 3:37 AM.



This patch moves the Debug Options to llvm/Frontend so that it can be shared by Flang as well.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 3:37 AM
Herald added a subscriber: sunshaoce. · View Herald Transcript
kiranchandramohan requested review of this revision.Jan 23 2023, 3:37 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 23 2023, 3:37 AM
SBallantyne commandeered this revision.Mar 24 2023, 10:26 AM
SBallantyne added a reviewer: kiranchandramohan.
SBallantyne added a subscriber: SBallantyne.

Setting this revision as base for adding debug flag to avoid adding additional dependencies on clang.

Clang format

LGTM. This refactoring helps share code between Clang and Flang. Please wait a couple of days before submitting.

Additional notes in support of approval:
-> The llvm community approved @jdoerfert 's proposal for llvm/lib/Frontend as a common directory for sharing code between multiple frontends.
-> In general the flang community would like to have the Flang driver independent of Clang. I believe the Clang project is fine with this as OKed in a reply to a previous RFC (

This revision is now accepted and ready to land.Mar 27 2023, 4:05 AM

Remove references to non existing import

awarzynski accepted this revision.Mar 27 2023, 7:17 AM

LGTM, thanks! As @kiranchandramohan points out, this is in line with the overall direction that we agreed on a while back.

This change will very likely affect various downstream consumers - it would be helpful to advertise this with a PSA on Discourse.

This revision was landed with ongoing or failed builds.Mar 29 2023, 5:02 AM
This revision was automatically updated to reflect the committed changes.