Page MenuHomePhabricator

SBallantyne (Sacha Ballantyne)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2023, 5:12 AM (18 w, 5 d)

Recent Activity

Apr 6 2023

SBallantyne retitled D147542: [llvm] Allow strided acceses to be grouped together for memory checks in loop accesses analysis from WIP [llvm] Allow strided acceses to be grouped together for memory checks in loop accesses analysis to [llvm] Allow strided acceses to be grouped together for memory checks in loop accesses analysis.
Apr 6 2023, 6:43 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D147542: [llvm] Allow strided acceses to be grouped together for memory checks in loop accesses analysis.

Add opt test

Apr 6 2023, 6:25 AM · Restricted Project, Restricted Project

Apr 4 2023

SBallantyne updated the summary of D147542: [llvm] Allow strided acceses to be grouped together for memory checks in loop accesses analysis.
Apr 4 2023, 9:23 AM · Restricted Project, Restricted Project
SBallantyne requested review of D147542: [llvm] Allow strided acceses to be grouped together for memory checks in loop accesses analysis.
Apr 4 2023, 9:20 AM · Restricted Project, Restricted Project
SBallantyne committed rGa7bb8e273f43: [Flang] Change fir.divc to perform library call rather than generate inline… (authored by SBallantyne).
[Flang] Change fir.divc to perform library call rather than generate inline…
Apr 4 2023, 9:09 AM · Restricted Project, Restricted Project
SBallantyne closed D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..
Apr 4 2023, 9:09 AM · Restricted Project, Restricted Project
SBallantyne added inline comments to D141306: Add loop-versioning pass to improve unit-stride.
Apr 4 2023, 8:56 AM · Restricted Project, Restricted Project

Apr 3 2023

SBallantyne updated the diff for D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..

Update to move half float to inline instead of library call as compiler-rt doesn't currently support divhc3. This may be added at some point as this currently causes errors for clang when libgcc is not available, see this issue: https://github.com/llvm/llvm-project/issues/61914

Apr 3 2023, 9:19 AM · Restricted Project, Restricted Project

Mar 29 2023

SBallantyne committed rGe2b7424d0666: [Flang] Add debug flag to enable current debug information pass (authored by SBallantyne).
[Flang] Add debug flag to enable current debug information pass
Mar 29 2023, 5:22 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne closed D146814: [Flang] Add debug flag to enable current debug information pass.
Mar 29 2023, 5:21 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne committed rGab49747f9d67: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang (authored by kiranchandramohan).
[NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang
Mar 29 2023, 5:02 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne closed D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang.
Mar 29 2023, 5:02 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D146814: [Flang] Add debug flag to enable current debug information pass.

Clang format

Mar 29 2023, 4:30 AM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2023

SBallantyne added inline comments to D146814: [Flang] Add debug flag to enable current debug information pass.
Mar 28 2023, 8:27 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D146814: [Flang] Add debug flag to enable current debug information pass.

Update style to mach style guidelines

Mar 28 2023, 8:27 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne added a comment to D146814: [Flang] Add debug flag to enable current debug information pass.
Mar 28 2023, 6:39 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D146814: [Flang] Add debug flag to enable current debug information pass.

Fix case issue. As for tests for debug information being generated, these are already covered by various tests in flang/tests/Transforms, namely debug-line-table.fir, debug-line-table-existing.fir etc.
While the tests are invoked through fir-opt instead of a flang flag, it is the same pass that is verified to be run in the tests added so is covered.

Mar 28 2023, 5:38 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D146814: [Flang] Add debug flag to enable current debug information pass.

Add common function addDebugKindInfo, update warning message

Mar 28 2023, 3:38 AM · Restricted Project, Restricted Project, Restricted Project

Mar 27 2023

SBallantyne added a comment to D146814: [Flang] Add debug flag to enable current debug information pass.

What's the overall design goal here? 100% consistency with Clang? Could this be documented?

Mar 27 2023, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D146814: [Flang] Add debug flag to enable current debug information pass.

Add test for invalid debug-info-kind and address other review comments

Mar 27 2023, 7:49 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang.

Remove references to non existing import

Mar 27 2023, 6:05 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D146814: [Flang] Add debug flag to enable current debug information pass.

Update tests to check for warning at higher debug levels, as well as amend warning message

Mar 27 2023, 3:24 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D146814: [Flang] Add debug flag to enable current debug information pass.

Add test to check that debug pass is run and not run with appropriate flags

Mar 27 2023, 2:28 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D146814: [Flang] Add debug flag to enable current debug information pass.

Attempt 2 to add previous work as stacked patch

Mar 27 2023, 2:03 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang.

Clang format

Mar 27 2023, 1:56 AM · Restricted Project, Restricted Project, Restricted Project

Mar 24 2023

SBallantyne updated the diff for D146814: [Flang] Add debug flag to enable current debug information pass.

Add dependence on D142347 and update references to clang::codegenoptions to llvm::codegenoptions

Mar 24 2023, 11:03 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang.

Rebase

Mar 24 2023, 10:26 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne commandeered D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang.

Setting this revision as base for adding debug flag to avoid adding additional dependencies on clang.

Mar 24 2023, 10:26 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne requested review of D146814: [Flang] Add debug flag to enable current debug information pass.
Mar 24 2023, 8:10 AM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2023

SBallantyne added a comment to D141306: Add loop-versioning pass to improve unit-stride.

LGTM, but someone else should approve. Only comment is that the fir test is currently called loop-versioing.fir. Should probably be loop-versioning.fir?

Mar 15 2023, 8:21 AM · Restricted Project, Restricted Project

Mar 13 2023

SBallantyne added inline comments to D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..
Mar 13 2023, 6:29 AM · Restricted Project, Restricted Project

Mar 10 2023

SBallantyne updated the diff for D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..

Add test to check for generating library call or generating inline code

Mar 10 2023, 9:52 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..

Formatting

Mar 10 2023, 9:19 AM · Restricted Project, Restricted Project
SBallantyne requested review of D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..
Mar 10 2023, 9:18 AM · Restricted Project, Restricted Project

Mar 9 2023

SBallantyne committed rG1b0ec3981c7e: [Flang] Give fir.if RegionBranchOpInterface (authored by SBallantyne).
[Flang] Give fir.if RegionBranchOpInterface
Mar 9 2023, 4:20 AM · Restricted Project, Restricted Project
SBallantyne closed D145165: [Flang] Give fir.if RegionBranchOpInterface.
Mar 9 2023, 4:19 AM · Restricted Project, Restricted Project, Restricted Project

Mar 8 2023

SBallantyne updated the diff for D145165: [Flang] Give fir.if RegionBranchOpInterface.

Remove change to scf

Mar 8 2023, 9:11 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D145165: [Flang] Give fir.if RegionBranchOpInterface.

Remove redundant getNumRegionInvocations from scf.if and fir.if

Mar 8 2023, 9:07 AM · Restricted Project, Restricted Project, Restricted Project

Mar 6 2023

SBallantyne updated the diff for D145165: [Flang] Give fir.if RegionBranchOpInterface.

Clang format has changed in between patches, appease it

Mar 6 2023, 3:24 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D145165: [Flang] Give fir.if RegionBranchOpInterface.

Amend test name, add RecursiveMemoryEffects trait and limit fir.if to 1 else region

Mar 6 2023, 1:58 AM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2023

SBallantyne added inline comments to D145165: [Flang] Give fir.if RegionBranchOpInterface.
Mar 2 2023, 8:30 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D145165: [Flang] Give fir.if RegionBranchOpInterface.

Add scf.if test back

Mar 2 2023, 8:30 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne updated the diff for D145165: [Flang] Give fir.if RegionBranchOpInterface.

Cleanup changes

Mar 2 2023, 7:39 AM · Restricted Project, Restricted Project, Restricted Project
SBallantyne requested review of D145165: [Flang] Give fir.if RegionBranchOpInterface.
Mar 2 2023, 7:35 AM · Restricted Project, Restricted Project, Restricted Project

Feb 28 2023

SBallantyne committed rG242bb0b65249: [flang] Fix a bug with simplified minloc that treated logicals with even values… (authored by SBallantyne).
[flang] Fix a bug with simplified minloc that treated logicals with even values…
Feb 28 2023, 9:16 AM · Restricted Project, Restricted Project
SBallantyne closed D144974: [flang] Fix a bug with simplified minloc that treated logicals with even values > 1 as 0.
Feb 28 2023, 9:15 AM · Restricted Project, Restricted Project
SBallantyne requested review of D144974: [flang] Fix a bug with simplified minloc that treated logicals with even values > 1 as 0.
Feb 28 2023, 8:19 AM · Restricted Project, Restricted Project
SBallantyne committed rG79dccded6900: [flang] Change COUNT intrinsic to support different kind logicals (authored by SBallantyne).
[flang] Change COUNT intrinsic to support different kind logicals
Feb 28 2023, 4:27 AM · Restricted Project, Restricted Project
SBallantyne closed D144867: [flang] Change COUNT intrinsic to support different kind logicals.
Feb 28 2023, 4:26 AM · Restricted Project, Restricted Project

Feb 27 2023

SBallantyne accepted D144874: [Flang][OpenMP] NFC: Change a few message/comments to fit 80chars Changes are all in the OpenMP semantic checks file..
Feb 27 2023, 8:25 AM · Restricted Project, Restricted Project
SBallantyne added a comment to D144874: [Flang][OpenMP] NFC: Change a few message/comments to fit 80chars Changes are all in the OpenMP semantic checks file..

LGTM

Feb 27 2023, 8:19 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D144867: [flang] Change COUNT intrinsic to support different kind logicals.

Appease clang format

Feb 27 2023, 6:37 AM · Restricted Project, Restricted Project
SBallantyne requested review of D144867: [flang] Change COUNT intrinsic to support different kind logicals.
Feb 27 2023, 5:51 AM · Restricted Project, Restricted Project
SBallantyne committed rG614cd721e1c3: [Flang] Add Minloc to simplify intrinsics pass (authored by SBallantyne).
[Flang] Add Minloc to simplify intrinsics pass
Feb 27 2023, 3:37 AM · Restricted Project, Restricted Project
SBallantyne closed D144103: [Flang] Add Minloc to simplify intrinsics pass.
Feb 27 2023, 3:37 AM · Restricted Project, Restricted Project

Feb 22 2023

SBallantyne updated the diff for D144103: [Flang] Add Minloc to simplify intrinsics pass.

Change findBoxDef and findMaskDef to use a common method findDef

Feb 22 2023, 8:11 AM · Restricted Project, Restricted Project

Feb 20 2023

SBallantyne updated the diff for D144103: [Flang] Add Minloc to simplify intrinsics pass.

Update fir tests to match new generated code and change naming scheme to avoid confusing logical ranks

Feb 20 2023, 4:51 AM · Restricted Project, Restricted Project
SBallantyne added inline comments to D144103: [Flang] Add Minloc to simplify intrinsics pass.
Feb 20 2023, 2:15 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D144103: [Flang] Add Minloc to simplify intrinsics pass.

Fix an issue where input arrays containing only huge(i) would return 0 instead of 1.

Feb 20 2023, 2:14 AM · Restricted Project, Restricted Project

Feb 16 2023

SBallantyne updated the diff for D144103: [Flang] Add Minloc to simplify intrinsics pass.

Style changes and some small improvements

Feb 16 2023, 3:36 AM · Restricted Project, Restricted Project

Feb 15 2023

SBallantyne updated the diff for D144103: [Flang] Add Minloc to simplify intrinsics pass.

Minor bug fix to avoid using uninitialised variables in for loops

Feb 15 2023, 9:45 AM · Restricted Project, Restricted Project
SBallantyne updated the summary of D144103: [Flang] Add Minloc to simplify intrinsics pass.
Feb 15 2023, 7:02 AM · Restricted Project, Restricted Project
SBallantyne requested review of D144103: [Flang] Add Minloc to simplify intrinsics pass.
Feb 15 2023, 6:58 AM · Restricted Project, Restricted Project

Feb 13 2023

SBallantyne added inline comments to D143899: [Flang] Fix for Any/All simplification to properly propogate the inital value.
Feb 13 2023, 9:26 AM · Restricted Project, Restricted Project
SBallantyne added a comment to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

The following code has a regression. Output from this code is now T; the output should be F.

integer z(0,5)        ! integer z(0) is ok
print*, any(z .ne. 1) ! should be false
end

F18 clause 16.9.13 ANY (MASK) or ANY (MASK, DIM), paragraph 5, Result Value Case(i) addresses the case of a zero-size argument:

The result of ANY (MASK) has the value true if any element of MASK is true and has the value false if no elements are true or if MASK has size zero.

The test is ok if the declaration of array z is changed to z(0). The code may need a more general check for the array size.

Feb 13 2023, 3:20 AM · Restricted Project, Restricted Project
SBallantyne added reviewers for D143899: [Flang] Fix for Any/All simplification to properly propogate the inital value: Leporacanthicus, kiranchandramohan, vdonaldson.
Feb 13 2023, 3:19 AM · Restricted Project, Restricted Project
SBallantyne requested review of D143899: [Flang] Fix for Any/All simplification to properly propogate the inital value.
Feb 13 2023, 3:16 AM · Restricted Project, Restricted Project

Feb 8 2023

SBallantyne added inline comments to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.
Feb 8 2023, 2:56 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

Fix Typo

Feb 8 2023, 2:55 AM · Restricted Project, Restricted Project

Feb 7 2023

SBallantyne added inline comments to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.
Feb 7 2023, 6:35 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

Change to add proper support for different kinds of logical

Feb 7 2023, 6:32 AM · Restricted Project, Restricted Project

Feb 6 2023

SBallantyne updated the diff for D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

Fix failing tests by changing two lines

Feb 6 2023, 7:10 AM · Restricted Project, Restricted Project
SBallantyne added inline comments to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.
Feb 6 2023, 2:42 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

Change genBody for All to check for zero rather than one

Feb 6 2023, 2:29 AM · Restricted Project, Restricted Project

Feb 2 2023

SBallantyne updated the diff for D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

Minor change to fir test names to make them unique

Feb 2 2023, 7:09 AM · Restricted Project, Restricted Project

Feb 1 2023

SBallantyne added inline comments to D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.
Feb 1 2023, 4:01 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

Refactor to reduce code copy-paste, other minor changes

Feb 1 2023, 4:01 AM · Restricted Project, Restricted Project

Jan 31 2023

SBallantyne updated the diff for D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.

Fix test/lower/array-derived.f90 fir test and minor changes to style

Jan 31 2023, 7:43 AM · Restricted Project, Restricted Project
SBallantyne requested review of D142977: [Flang] Add Any and All intrinsics to simplify intrinsics pass.
Jan 31 2023, 5:52 AM · Restricted Project, Restricted Project

Jan 30 2023

SBallantyne updated the summary of D142877: [flang] Fix simplify intrinsic for count not checking for rank = 0 properly.
Jan 30 2023, 3:31 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D142877: [flang] Fix simplify intrinsic for count not checking for rank = 0 properly.

Fix minor issue with tests.

Jan 30 2023, 3:22 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D142877: [flang] Fix simplify intrinsic for count not checking for rank = 0 properly.

Add test and comment

Jan 30 2023, 2:26 AM · Restricted Project, Restricted Project
SBallantyne requested review of D142877: [flang] Fix simplify intrinsic for count not checking for rank = 0 properly.
Jan 30 2023, 1:55 AM · Restricted Project, Restricted Project

Jan 27 2023

SBallantyne updated the diff for D142209: [flang] Add Count to simplified intrinsics.

Remove uneeded mlir::twine{}

Jan 27 2023, 5:54 AM · Restricted Project, Restricted Project

Jan 26 2023

SBallantyne added inline comments to D142209: [flang] Add Count to simplified intrinsics.
Jan 26 2023, 3:41 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D142209: [flang] Add Count to simplified intrinsics.

Fix zero64/one64 values being swapped around

Jan 26 2023, 3:41 AM · Restricted Project, Restricted Project
SBallantyne added inline comments to D142209: [flang] Add Count to simplified intrinsics.
Jan 26 2023, 3:13 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D142209: [flang] Add Count to simplified intrinsics.

Change naming scheme to not include fast math strings in logical functions

Jan 26 2023, 2:43 AM · Restricted Project, Restricted Project

Jan 25 2023

SBallantyne added inline comments to D142209: [flang] Add Count to simplified intrinsics.
Jan 25 2023, 5:37 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D142209: [flang] Add Count to simplified intrinsics.

Change to test for 0 in simplified count rather than add logicals

Jan 25 2023, 5:32 AM · Restricted Project, Restricted Project

Jan 24 2023

SBallantyne added inline comments to D142209: [flang] Add Count to simplified intrinsics.
Jan 24 2023, 3:28 AM · Restricted Project, Restricted Project

Jan 23 2023

SBallantyne added inline comments to D142209: [flang] Add Count to simplified intrinsics.
Jan 23 2023, 4:24 AM · Restricted Project, Restricted Project
SBallantyne updated the diff for D142209: [flang] Add Count to simplified intrinsics.

Minor changes to formating and documentation

Jan 23 2023, 4:24 AM · Restricted Project, Restricted Project

Jan 20 2023

SBallantyne updated the summary of D142209: [flang] Add Count to simplified intrinsics.
Jan 20 2023, 7:11 AM · Restricted Project, Restricted Project
SBallantyne requested review of D142209: [flang] Add Count to simplified intrinsics.
Jan 20 2023, 6:35 AM · Restricted Project, Restricted Project