Page MenuHomePhabricator

awarzynski (Andrzej Warzynski)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2020, 4:57 AM (108 w, 3 d)

Recent Activity

Thu, May 19

awarzynski added a comment to D125788: [flang][driver] Rename `flang-new` as `flang`.

Summary updated :)

Thu, May 19, 10:57 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated the summary of D125788: [flang][driver] Rename `flang-new` as `flang`.
Thu, May 19, 10:48 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski committed rGe601b2a15427: [flang][driver] Add support for generating executables on MacOSX/Darwin (authored by awarzynski).
[flang][driver] Add support for generating executables on MacOSX/Darwin
Thu, May 19, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski closed D125628: [flang][driver] Add support for generating executables on MacOSX/Darwin.
Thu, May 19, 7:49 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski committed rGf82062550374: [flang][driver] Make driver accept `-module-dir<value>` (authored by awarzynski).
[flang][driver] Make driver accept `-module-dir<value>`
Thu, May 19, 4:14 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski closed D125957: [flang][driver] Make driver accept `-module-dir<value>`.
Thu, May 19, 4:14 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski requested review of D125957: [flang][driver] Make driver accept `-module-dir<value>`.
Thu, May 19, 2:40 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated the diff for D125788: [flang][driver] Rename `flang-new` as `flang`.

Update documentation

Thu, May 19, 2:07 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 18

awarzynski updated subscribers of D125832: [flang] Rename `flang` as `flang-to-external-fc`.
Wed, May 18, 7:39 AM · Restricted Project, Restricted Project
awarzynski retitled D125832: [flang] Rename `flang` as `flang-to-external-fc` from [flang] Rename `flang` as `flang-to-gfortran` to [flang] Rename `flang` as `flang-to-external-fc`.
Wed, May 18, 7:39 AM · Restricted Project, Restricted Project
awarzynski updated the summary of D125788: [flang][driver] Rename `flang-new` as `flang`.
Wed, May 18, 7:38 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated the diff for D125788: [flang][driver] Rename `flang-new` as `flang`.

I will also make this change depend on https://reviews.llvm.org/D125832

Wed, May 18, 7:38 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated subscribers of D125796: [fortran] Use flang-to-external-fc instead of flang.

Makes sense (just need to update flang-to-gfortran to flang-to-external-fc and wait for D125832 to be merged. Thanks for doing this!

Wed, May 18, 7:33 AM · Restricted Project
awarzynski updated the diff for D125832: [flang] Rename `flang` as `flang-to-external-fc`.

Suggested by kiranchandramohan in https://reviews.llvm.org/D125788

Wed, May 18, 7:30 AM · Restricted Project, Restricted Project
awarzynski added a comment to D125788: [flang][driver] Rename `flang-new` as `flang`.

Sounds good to me. https://reviews.llvm.org/D125796 for the bot side, let me know if/when the first half of the change goes in.

Wed, May 18, 7:19 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 17

awarzynski requested review of D125832: [flang] Rename `flang` as `flang-to-external-fc`.
Tue, May 17, 12:41 PM · Restricted Project, Restricted Project
awarzynski added a comment to D125788: [flang][driver] Rename `flang-new` as `flang`.

Can we expect the current flang-new, soon to be flang to also cope with these tests (I have no expectations myself here, fine if not) or should we move the bots to use flang-to-gfortran?

Tue, May 17, 8:05 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski abandoned D124848: [flang] Make the bash script print short info whenever used.

Abandoning in favor of https://reviews.llvm.org/D125788 :)

Tue, May 17, 7:25 AM · Restricted Project, Restricted Project
awarzynski added reviewers for D125788: [flang][driver] Rename `flang-new` as `flang`: DavidSpickett, richard.barton.arm.
Tue, May 17, 7:24 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski requested review of D125788: [flang][driver] Rename `flang-new` as `flang`.
Tue, May 17, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski accepted D125672: [flang][Runtime] Use proper prototypes in Fortran_main. NFCI.

Makes sense to me, thanks!

Tue, May 17, 6:06 AM · Restricted Project, Restricted Project

Mon, May 16

awarzynski accepted D124846: [flang][driver] Support reading response files.

Thanks for the updates, LGTM!

Mon, May 16, 2:07 AM · Restricted Project, Restricted Project

Sun, May 15

awarzynski committed rGea18987094ef: [flang][nfc] Fix driver method names overridden by the plugins (authored by awarzynski).
[flang][nfc] Fix driver method names overridden by the plugins
Sun, May 15, 10:59 AM · Restricted Project, Restricted Project
awarzynski requested review of D125628: [flang][driver] Add support for generating executables on MacOSX/Darwin.
Sun, May 15, 5:13 AM · Restricted Project, Restricted Project, Restricted Project

Sat, May 14

awarzynski committed rG1e462fafdf8b: [flang][driver] Switch to the MLIR coding style in the driver (nfc) (authored by awarzynski).
[flang][driver] Switch to the MLIR coding style in the driver (nfc)
Sat, May 14, 3:31 AM · Restricted Project, Restricted Project
awarzynski closed D125007: [flang][driver] Switch to the MLIR coding style in the driver.
Sat, May 14, 3:31 AM · Restricted Project, Restricted Project

Fri, May 13

awarzynski accepted D124759: [flang] Install Fortran_main library.

Thank you both!

Fri, May 13, 8:48 AM · Restricted Project, Restricted Project
awarzynski added a comment to D124759: [flang] Install Fortran_main library.

Thank you @dpalermo , you are a ⭐ ! This way we can have a much less intrusive solution, which is fantastic :)

Fri, May 13, 1:36 AM · Restricted Project, Restricted Project

Thu, May 12

awarzynski added a comment to D124759: [flang] Install Fortran_main library.

Hi @rovka & @dpalermo, thanks for working on this!

Thu, May 12, 4:31 AM · Restricted Project, Restricted Project

Mon, May 9

awarzynski updated subscribers of D122654: [doc] Improve clang auto-generated help.

Thanks for jumping in!

Mon, May 9, 6:41 AM · Restricted Project, Restricted Project

Fri, May 6

awarzynski updated the diff for D125007: [flang][driver] Switch to the MLIR coding style in the driver.

Add missing clang-format config files, re-format accordingly

Fri, May 6, 1:54 AM · Restricted Project, Restricted Project
awarzynski added a comment to D124846: [flang][driver] Support reading response files.
  • Added a note about the @ syntax to the commit message (I hope that's what you had in mind, if not let me know!)
Fri, May 6, 1:45 AM · Restricted Project, Restricted Project
awarzynski committed rGa65afce731c2: [flang][driver] Add support for -save-temps (authored by awarzynski).
[flang][driver] Add support for -save-temps
Fri, May 6, 1:42 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski closed D124669: [flang][driver] Add support for -save-temps.
Fri, May 6, 1:41 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 5

awarzynski added a comment to D124669: [flang][driver] Add support for -save-temps.

Pre-merge CI is 🍏 . If there are no new comments, I'd like to merge this tomorrow.

Thu, May 5, 11:26 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski committed rGc12ef70d2b0a: [flang][driver] Add missing parentheses in an assert (authored by awarzynski).
[flang][driver] Add missing parentheses in an assert
Thu, May 5, 11:03 AM · Restricted Project, Restricted Project
awarzynski closed D125027: [flang][driver] Add missing parentheses in an assert.
Thu, May 5, 11:03 AM · Restricted Project, Restricted Project
awarzynski requested review of D125027: [flang][driver] Add missing parentheses in an assert.
Thu, May 5, 11:02 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D124669: [flang][driver] Add support for -save-temps.

Mark the tests as unsupported on Windows

Thu, May 5, 9:54 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski committed rGbb0aa574e7d6: [flang] Fix triple in a couple of driver tests (authored by awarzynski).
[flang] Fix triple in a couple of driver tests
Thu, May 5, 9:45 AM · Restricted Project, Restricted Project
awarzynski updated the summary of D125007: [flang][driver] Switch to the MLIR coding style in the driver.
Thu, May 5, 9:02 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D125007: [flang][driver] Switch to the MLIR coding style in the driver.

Rebase

Thu, May 5, 8:57 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D124669: [flang][driver] Add support for -save-temps.

Rebase on top of main

Thu, May 5, 8:27 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski committed rGb9f3b7f89a4c: [flang][driver] Add support for consuming LLVM IR/BC files (authored by awarzynski).
[flang][driver] Add support for consuming LLVM IR/BC files
Thu, May 5, 8:12 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski closed D124667: [flang][driver] Add support for consuming LLVM IR/BC files.
Thu, May 5, 8:12 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski committed rGbb177edc44f4: [flang][driver] Re-organise the code-gen actions (nfc) (authored by awarzynski).
[flang][driver] Re-organise the code-gen actions (nfc)
Thu, May 5, 7:07 AM · Restricted Project, Restricted Project
awarzynski closed D124665: [flang][driver] Re-organise the code-gen actions (nfc).
Thu, May 5, 7:06 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D124665: [flang][driver] Re-organise the code-gen actions (nfc).
Thu, May 5, 6:22 AM · Restricted Project, Restricted Project
awarzynski updated the summary of D125007: [flang][driver] Switch to the MLIR coding style in the driver.
Thu, May 5, 5:39 AM · Restricted Project, Restricted Project
awarzynski requested review of D125007: [flang][driver] Switch to the MLIR coding style in the driver.
Thu, May 5, 5:32 AM · Restricted Project, Restricted Project

Wed, May 4

awarzynski added inline comments to D124669: [flang][driver] Add support for -save-temps.
Wed, May 4, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated the diff for D124669: [flang][driver] Add support for -save-temps.

Fix typos as per comments from @rovka, thanks!

Wed, May 4, 9:05 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated the diff for D124667: [flang][driver] Add support for consuming LLVM IR/BC files.

Rebase on top of main

Wed, May 4, 8:59 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated the diff for D124665: [flang][driver] Re-organise the code-gen actions (nfc).

Rebase on top of main

Wed, May 4, 8:55 AM · Restricted Project, Restricted Project
awarzynski added a comment to D124848: [flang] Make the bash script print short info whenever used.

Thanks for the review, @ekieri !

Wed, May 4, 8:47 AM · Restricted Project, Restricted Project
awarzynski accepted D124837: [Flang] Lower Unstructured do loops.

Makes sense, thank you!

Wed, May 4, 7:46 AM · Restricted Project, Restricted Project
awarzynski accepted D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.

LGTM :) @schweitz, does this work for you?

Wed, May 4, 6:48 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski committed rG02fb5b771d7f: [flang][driver] Define the default frontend driver triple (authored by awarzynski).
[flang][driver] Define the default frontend driver triple
Wed, May 4, 5:02 AM · Restricted Project, Restricted Project
awarzynski closed D124664: [flang][driver] Define the default frontend driver triple.
Wed, May 4, 5:02 AM · Restricted Project, Restricted Project
awarzynski added a comment to D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.

Ping?

Wed, May 4, 4:58 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a comment to D124846: [flang][driver] Support reading response files.

Thanks for working on this! I would appreciate a note about the command line semantics for response files. IIUC (based on the tests file), one just needs to prepend the filename with @, but I couldn't find any documentation.

Wed, May 4, 4:23 AM · Restricted Project, Restricted Project
awarzynski accepted D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

I am tempted to merge this now and handle any other updates as other patches as we find them instead of holding this up any longer. Any objections @awarzynski ?

Wed, May 4, 4:19 AM · Restricted Project, Restricted Project

Tue, May 3

awarzynski updated the diff for D124669: [flang][driver] Add support for -save-temps.

Fix failing test

Tue, May 3, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated the diff for D124669: [flang][driver] Add support for -save-temps.

Add a test, restore white-space in Options.td

Tue, May 3, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated the diff for D124667: [flang][driver] Add support for consuming LLVM IR/BC files.

Add an assert, make some editorial changes in comments

Tue, May 3, 6:24 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a comment to D124667: [flang][driver] Add support for consuming LLVM IR/BC files.

Thanks for the review @rovka!

Tue, May 3, 6:18 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a comment to D124848: [flang] Make the bash script print short info whenever used.

Based on https://github.com/llvm/llvm-project/issues/53420#issuecomment-1115969047, I feel that it would be very helpful to make the purpose of flang a bit clearer. WDYT?

Tue, May 3, 5:50 AM · Restricted Project, Restricted Project
awarzynski requested review of D124848: [flang] Make the bash script print short info whenever used.
Tue, May 3, 5:24 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D124665: [flang][driver] Re-organise the code-gen actions (nfc).

Address comments from Diana

Tue, May 3, 3:24 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D124665: [flang][driver] Re-organise the code-gen actions (nfc).
Tue, May 3, 3:22 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D124664: [flang][driver] Define the default frontend driver triple.
Tue, May 3, 2:11 AM · Restricted Project, Restricted Project
awarzynski added a comment to D124664: [flang][driver] Define the default frontend driver triple.

LGTM, just a small suggestion: Could you add a note about the missing tests (that (and why) they are in D124667) to the commit message?

Tue, May 3, 2:11 AM · Restricted Project, Restricted Project
awarzynski updated the summary of D124664: [flang][driver] Define the default frontend driver triple.
Tue, May 3, 2:01 AM · Restricted Project, Restricted Project
awarzynski updated the summary of D124664: [flang][driver] Define the default frontend driver triple.
Tue, May 3, 2:01 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D124664: [flang][driver] Define the default frontend driver triple.

Update the comment in "CompilerInvocation.cpp"

Tue, May 3, 1:56 AM · Restricted Project, Restricted Project
awarzynski added a comment to D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error.

Thanks for seeing this through!

Tue, May 3, 1:18 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D124367: [docs] Improve documentation around CMAKE_BUILD_TYPE.
Tue, May 3, 1:13 AM · Restricted Project, Restricted Project

Sun, May 1

awarzynski added inline comments to D124669: [flang][driver] Add support for -save-temps.
Sun, May 1, 8:51 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a comment to D124665: [flang][driver] Re-organise the code-gen actions (nfc).

@unterumarmung , thanks for taking a look!

Sun, May 1, 8:34 AM · Restricted Project, Restricted Project
awarzynski added a comment to D124610: [OpenMP] Support operation conversion to LLVM for threadprivate directive.
  1. Without OpenMP, the following test case still fails.
  integer, save, pointer :: x
    x = 1
end
$ flang-new test.f90
error: loc("./atomic-read.f90":2:29): 'llvm.mlir.global' op initializer region type '!llvm.ptr<struct<(ptr<i32>, i64, i32, i8, i8, i8, i8)>>' does not match global type '!llvm.struct<(ptr<i32>, i64, i32, i8, i8, i8, i8)>'
error: Lowering to LLVM IR failed
error: loc("./atomic-read.f90":2:29): cannot be converted to LLVM IR: missing `LLVMTranslationDialectInterface` registration for dialect for op: builtin.unrealized_conversion_cast
error: loc("./atomic-read.f90":2:29): unemittable constant value
error: failed to create the LLVM module

@schweitz @jeanPerier Any idea what's going on here?

Sun, May 1, 7:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Apr 29

awarzynski requested review of D124669: [flang][driver] Add support for -save-temps.
Fri, Apr 29, 5:07 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski requested review of D124667: [flang][driver] Add support for consuming LLVM IR/BC files.
Fri, Apr 29, 3:50 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a comment to D124665: [flang][driver] Re-organise the code-gen actions (nfc).

@rovka That's a bit "bolder" change compared to what you suggested in https://reviews.llvm.org/D123211. WDYT?

Fri, Apr 29, 2:48 AM · Restricted Project, Restricted Project
awarzynski requested review of D124665: [flang][driver] Re-organise the code-gen actions (nfc).
Fri, Apr 29, 2:43 AM · Restricted Project, Restricted Project
awarzynski requested review of D124664: [flang][driver] Define the default frontend driver triple.
Fri, Apr 29, 2:38 AM · Restricted Project, Restricted Project

Thu, Apr 28

awarzynski added a comment to D124610: [OpenMP] Support operation conversion to LLVM for threadprivate directive.

@peixin Many thanks for extracting this into a separate patch. The end goal is much clearer now :)

Thu, Apr 28, 8:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
awarzynski added a comment to D124226: [flang][OpenMP] Support lowering parse-tree to MLIR for threadprivate directive.

@awarzynski Thanks for the suggestions. Let's move this discussion to D124610. I would like to push forward this patch for only lowering work so that we can move on other OpenMP works based on this patch.

Thu, Apr 28, 6:26 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a comment to D124226: [flang][OpenMP] Support lowering parse-tree to MLIR for threadprivate directive.

I look through the tests under flang/test/Driver, but adding OpenMP integration tests there seems not appropriate.

Thu, Apr 28, 4:07 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski committed rGdcb2ddd6c925: [flang][driver] Fix spelling (nfc) (authored by awarzynski).
[flang][driver] Fix spelling (nfc)
Thu, Apr 28, 3:38 AM · Restricted Project, Restricted Project

Apr 27 2022

awarzynski committed rGd902dd011c94: [flang][driver] NFC: Make code more in line with LLVM style (authored by awarzynski).
[flang][driver] NFC: Make code more in line with LLVM style
Apr 27 2022, 2:21 AM · Restricted Project, Restricted Project
awarzynski closed D124245: [flang][driver] NFC: Make code more in line with LLVM style.
Apr 27 2022, 2:20 AM · Restricted Project, Restricted Project

Apr 26 2022

awarzynski added a comment to D124245: [flang][driver] NFC: Make code more in line with LLVM style.

Thanks for taking a look, @ekieri !

Apr 26 2022, 9:55 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D124245: [flang][driver] NFC: Make code more in line with LLVM style.

Address Emil's nits.

Apr 26 2022, 9:50 AM · Restricted Project, Restricted Project
awarzynski added a comment to D124277: [Flang] Initial lowering of the Fortran Do loop.

These tests were present in fir-dev in their initial form. Near the end is exactly where it becomes harder to be sure everything is upstreamed if there is lots of noise in the diffs.

Apr 26 2022, 9:11 AM · Restricted Project, Restricted Project
awarzynski accepted D124277: [Flang] Initial lowering of the Fortran Do loop.

Thanks for the updates @kiranchandramohan , the tests are so much easier to follow now!

Apr 26 2022, 8:20 AM · Restricted Project, Restricted Project
awarzynski added a comment to D124226: [flang][OpenMP] Support lowering parse-tree to MLIR for threadprivate directive.

@awarzynski Thanks for the explanations. Good to hear someone has the strong reason to make the test cases standard. It is also more reasonable for me to give one descriptive file name.

threadprivate-different-types.f90 doesn't represent its true intention. I will use threadprivate-real-logical-complex-derivedtype.f90 if no one opposes the long file name. Will also fix other file names.

Apr 26 2022, 7:31 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a comment to D124226: [flang][OpenMP] Support lowering parse-tree to MLIR for threadprivate directive.

(like loop.f90 in D124277).

https://reviews.llvm.org/D124277#3473895. Andrzej prefers multiple files. Everyone has their own preference :).

Apr 26 2022, 2:16 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a comment to D124277: [Flang] Initial lowering of the Fortran Do loop.

I'm not sure I follow this. Kiran's patch is for the conversion of Fortran loops to FIR. It isn't about exercising FIR's DoLoopOp.

Apr 26 2022, 12:58 AM · Restricted Project, Restricted Project

Apr 25 2022

awarzynski added a comment to D124277: [Flang] Initial lowering of the Fortran Do loop.

It's great to see do loop finally making its way into LLVM main, thanks for working on this @kiranchandramohan !

Apr 25 2022, 10:59 AM · Restricted Project, Restricted Project
awarzynski committed rG97a32d3e43fe: [flang][driver] Add support for generating executables (authored by awarzynski).
[flang][driver] Add support for generating executables
Apr 25 2022, 5:02 AM · Restricted Project, Restricted Project, Restricted Project