Page MenuHomePhabricator

awarzynski (Andrzej Warzynski)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2020, 4:57 AM (50 w, 1 d)

Recent Activity

Today

awarzynski added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Wed, Apr 14, 6:58 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Wed, Apr 14, 4:29 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..
Wed, Apr 14, 2:33 AM · Restricted Project, Restricted Project
awarzynski added a comment to D100442: [flang][msvc] Fix compilation of RuntimeGtest tests..

Thank you for submitting this @MehdiChinoune ! I'm a bit confused - what's specific about MSVC here and in the failure that you are seeing?

Wed, Apr 14, 1:32 AM · Restricted Project, Restricted Project
awarzynski added a reviewer for D100442: [flang][msvc] Fix compilation of RuntimeGtest tests.: ashermancinelli.
Wed, Apr 14, 1:19 AM · Restricted Project, Restricted Project

Yesterday

awarzynski added a reviewer for D100309: [flang] Update the remaining tests to use the new driver when enabled: Leporacanthicus.
Tue, Apr 13, 7:52 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D100309: [flang] Update the remaining tests to use the new driver when enabled.

Add one missing test

Tue, Apr 13, 6:06 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D100309: [flang] Update the remaining tests to use the new driver when enabled.

Rebase on top of main

Tue, Apr 13, 5:58 AM · Restricted Project, Restricted Project
awarzynski committed rG808a5a2534cd: [flang][driver] Remove `%flang-new` from the LIT configuration (authored by awarzynski).
[flang][driver] Remove `%flang-new` from the LIT configuration
Tue, Apr 13, 3:56 AM
awarzynski closed D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.
Tue, Apr 13, 3:55 AM · Restricted Project, Restricted Project
awarzynski committed rG4217e6bf95f5: [flang] Fix a test (use %s instead of $s) (authored by awarzynski).
[flang] Fix a test (use %s instead of $s)
Tue, Apr 13, 3:04 AM
awarzynski closed D100301: [flang] Fix a test (use %s instead of $s).
Tue, Apr 13, 3:04 AM · Restricted Project, Restricted Project
awarzynski accepted D99614: [flang] Update list-input test to use GTest.

I typically use static to reduce the number of initializations

Tue, Apr 13, 3:00 AM · Restricted Project, Restricted Project

Mon, Apr 12

awarzynski added a comment to D100309: [flang] Update the remaining tests to use the new driver when enabled.

Apologies for sending such a chunky patch. Please let me know if you see a good way to split this.

Mon, Apr 12, 10:34 AM · Restricted Project, Restricted Project
awarzynski added reviewers for D100309: [flang] Update the remaining tests to use the new driver when enabled: tskeith, kiranktp, arnamoy10, SouraVX, AMDChirag, kiranchandramohan.
Mon, Apr 12, 10:31 AM · Restricted Project, Restricted Project
awarzynski requested review of D100309: [flang] Update the remaining tests to use the new driver when enabled.
Mon, Apr 12, 8:25 AM · Restricted Project, Restricted Project
awarzynski added reviewers for D100301: [flang] Fix a test (use %s instead of $s): arnamoy10, ashermancinelli, SouraVX, klausler, kiranchandramohan, AMDChirag.
Mon, Apr 12, 5:41 AM · Restricted Project, Restricted Project
awarzynski requested review of D100301: [flang] Fix a test (use %s instead of $s).
Mon, Apr 12, 5:38 AM · Restricted Project, Restricted Project
awarzynski added a comment to D99614: [flang] Update list-input test to use GTest.

Thank you for addressing my comments @ashermancinelli, this looks really good! One general question, why make everything static? Is there any technical benefit? I feel that it reduces readability a bit. If it's not needed, I suggest removing it.

Mon, Apr 12, 3:37 AM · Restricted Project, Restricted Project

Fri, Apr 9

awarzynski updated the diff for D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.

Continue debugging debug-measure-parse-tree.f90

Fri, Apr 9, 7:51 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.

Try to diagnose debug-measure-parse-tree.f90

Fri, Apr 9, 6:21 AM · Restricted Project, Restricted Project
awarzynski added a comment to D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.

The new driver is still called flang-new

I presume eventually next step would be replace that as well ?

Fri, Apr 9, 5:11 AM · Restricted Project, Restricted Project
awarzynski added a comment to D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.

LGTM. Thanks for the patch! and congratulations on the milestone of bringing experimental driver to mainline!

Fri, Apr 9, 4:05 AM · Restricted Project, Restricted Project
awarzynski updated the summary of D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.
Fri, Apr 9, 4:01 AM · Restricted Project, Restricted Project
awarzynski added reviewers for D100174: [flang][driver] Remove `%flang-new` from the LIT configuration: arnamoy10, AMDChirag, SouraVX, kiranktp, ashermancinelli, tskeith, kiranchandramohan, CarolineConcatto.
Fri, Apr 9, 3:57 AM · Restricted Project, Restricted Project
awarzynski requested review of D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.
Fri, Apr 9, 3:54 AM · Restricted Project, Restricted Project

Thu, Apr 8

awarzynski added a comment to D99353: [driver] Make `clang` warn rather then error on `flang` options.

I've just send an RFC for this change to cfe-dev: https://lists.llvm.org/pipermail/cfe-dev/2021-April/067981.html.

Thu, Apr 8, 8:01 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D99353: [driver] Make `clang` warn rather then error on `flang` options.

Refine comments, remove code for aliases (which didn't work anyway)

Thu, Apr 8, 6:07 AM · Restricted Project, Restricted Project
awarzynski committed rG4b273b198265: [flang][nfc] Rename some test files (authored by awarzynski).
[flang][nfc] Rename some test files
Thu, Apr 8, 3:09 AM
awarzynski added a comment to D99645: [flang][driver] Add debug options not requiring semantic checks.

LGTM.

Might be good to have a test for fdebug-dump-parse-tree-no-sema.

Thu, Apr 8, 2:45 AM · Restricted Project, Restricted Project
awarzynski committed rGe81b3401177a: [flang][driver] Add debug options not requiring semantic checks (authored by awarzynski).
[flang][driver] Add debug options not requiring semantic checks
Thu, Apr 8, 2:45 AM
awarzynski closed D99645: [flang][driver] Add debug options not requiring semantic checks.
Thu, Apr 8, 2:45 AM · Restricted Project, Restricted Project

Wed, Apr 7

awarzynski added a comment to D99353: [driver] Make `clang` warn rather then error on `flang` options.

Btw, how important are these aliases for you?

It's just not obvious from flang --help that this is an alias for -ffixed-line-length-132 (or the other way around). I only learned that by looking at LLVM source.

Wed, Apr 7, 8:53 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D99645: [flang][driver] Add debug options not requiring semantic checks.
Wed, Apr 7, 8:39 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D99645: [flang][driver] Add debug options not requiring semantic checks.

Add DocBrief descriptions in Options.td

Wed, Apr 7, 8:29 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D99645: [flang][driver] Add debug options not requiring semantic checks.
Wed, Apr 7, 6:22 AM · Restricted Project, Restricted Project
awarzynski committed rG85b86c6f43ab: [flang][driver] Fix `-fdebug-dump-provenance` (authored by awarzynski).
[flang][driver] Fix `-fdebug-dump-provenance`
Wed, Apr 7, 6:16 AM
awarzynski closed D98847: [flang][driver] Fix `-fdebug-dump-provenance`.
Wed, Apr 7, 6:15 AM · Restricted Project, Restricted Project
awarzynski added a comment to D99292: [flang][driver] Add support for `-cpp/-nocpp`.

As there have been no new comments and this patch has already been accepted, I decided to merge it without waiting for more reviews. Please leave post-commit comments if I missed anything and I will address them. Thank you all for reviewing!

Wed, Apr 7, 6:04 AM · Restricted Project, Restricted Project
awarzynski committed rGb83a4450c216: [flang][driver] Add support for `-cpp/-nocpp` (authored by awarzynski).
[flang][driver] Add support for `-cpp/-nocpp`
Wed, Apr 7, 6:02 AM
awarzynski closed D99292: [flang][driver] Add support for `-cpp/-nocpp`.
Wed, Apr 7, 6:02 AM · Restricted Project, Restricted Project
awarzynski added a comment to D99614: [flang] Update list-input test to use GTest.

Hi @ashermancinelli , many thanks for this patch. All tests from the original file are covered and there are also some new tests!

Wed, Apr 7, 3:25 AM · Restricted Project, Restricted Project

Tue, Apr 6

awarzynski added a comment to D99892: [flang] Improve constant folding for type parameter inquiries.

@awarzynski or @kiranchandramohan , can you please verify that this now builds with shared libraries?

Tue, Apr 6, 1:24 PM · Restricted Project, Restricted Project
awarzynski added inline comments to D99645: [flang][driver] Add debug options not requiring semantic checks.
Tue, Apr 6, 10:44 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D99645: [flang][driver] Add debug options not requiring semantic checks.

Remove unused variable

Tue, Apr 6, 10:43 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D99645: [flang][driver] Add debug options not requiring semantic checks.
Tue, Apr 6, 10:36 AM · Restricted Project, Restricted Project
awarzynski updated the summary of D99645: [flang][driver] Add debug options not requiring semantic checks.
Tue, Apr 6, 10:35 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D99645: [flang][driver] Add debug options not requiring semantic checks.

Update f18.cpp and driver-help.f90 to improve testing

Tue, Apr 6, 9:56 AM · Restricted Project, Restricted Project
awarzynski added a comment to D99892: [flang] Improve constant folding for type parameter inquiries.

@PeteSteinfeld I have reverted this patch since I could not find a quick fix.
https://reviews.llvm.org/rGb7ef804807855e607da3eba221c1fc59e27f778e

Tue, Apr 6, 2:21 AM · Restricted Project, Restricted Project

Mon, Apr 5

awarzynski added a reviewer for D99353: [driver] Make `clang` warn rather then error on `flang` options: ashermancinelli.
Mon, Apr 5, 9:33 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D99353: [driver] Make `clang` warn rather then error on `flang` options.
Mon, Apr 5, 9:22 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D99353: [driver] Make `clang` warn rather then error on `flang` options.

Add more reviewers and remove unrelated changes (apologies for the noise!)

Mon, Apr 5, 9:21 AM · Restricted Project, Restricted Project
awarzynski added reviewers for D99353: [driver] Make `clang` warn rather then error on `flang` options: modocache, atanasyan, hans, kiranchandramohan, arnamoy10, tskeith, SouraVX.
Mon, Apr 5, 9:08 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D99353: [driver] Make `clang` warn rather then error on `flang` options.

Refine the behaviour when using diag options and add tests

Mon, Apr 5, 9:00 AM · Restricted Project, Restricted Project
awarzynski added a comment to D99353: [driver] Make `clang` warn rather then error on `flang` options.

Hi @protze.joachim , thank you for testing this so thoroughly!

Mon, Apr 5, 8:52 AM · Restricted Project, Restricted Project
awarzynski accepted D98657: [flang][driver] Add options for -Werror.

LGTM, thank you for addressing my comments!

Mon, Apr 5, 7:32 AM · Restricted Project

Thu, Apr 1

awarzynski committed rGdc14e89a1fab: [flang] Move .f77 to the list of fixed-form file extensions (authored by awarzynski).
[flang] Move .f77 to the list of fixed-form file extensions
Thu, Apr 1, 6:30 AM
awarzynski closed D99494: [flang] Move .f77 to the list of fixed-form file extension.
Thu, Apr 1, 6:30 AM · Restricted Project, Restricted Project
awarzynski updated the summary of D99292: [flang][driver] Add support for `-cpp/-nocpp`.
Thu, Apr 1, 6:11 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D99292: [flang][driver] Add support for `-cpp/-nocpp`.
Thu, Apr 1, 6:10 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D99292: [flang][driver] Add support for `-cpp/-nocpp`.

Update comments

Thu, Apr 1, 6:09 AM · Restricted Project, Restricted Project

Wed, Mar 31

awarzynski updated the summary of D99645: [flang][driver] Add debug options not requiring semantic checks.
Wed, Mar 31, 2:56 AM · Restricted Project, Restricted Project
awarzynski added reviewers for D99645: [flang][driver] Add debug options not requiring semantic checks: arnamoy10, tskeith, AMDChirag, kiranchandramohan, kiranktp, ashermancinelli, MatsPetersson.
Wed, Mar 31, 2:52 AM · Restricted Project, Restricted Project
awarzynski updated the summary of D99645: [flang][driver] Add debug options not requiring semantic checks.
Wed, Mar 31, 2:50 AM · Restricted Project, Restricted Project
awarzynski requested review of D99645: [flang][driver] Add debug options not requiring semantic checks.
Wed, Mar 31, 2:45 AM · Restricted Project, Restricted Project

Tue, Mar 30

awarzynski accepted D99518: [flang][driver] Modify the existing test cases that use -Mstandard in f18, to use -pedantic and %flang_fc1 to share with the new driver.

Thank you for working on this! I would be tempted to make this patch depend on https://reviews.llvm.org/D98657. It's up to you.

Tue, Mar 30, 9:27 AM · Restricted Project, Restricted Project
awarzynski added a comment to D98657: [flang][driver] Add options for -Werror.

I really like how you split your tests into two files:

  • werror_scan.f captures warning generated by the prescanner
  • werror.f captures warnings from the semantic analysis

In every case you added multiple RUN lines to make sure that the behavior is consistent across multiple actions. I think that that's very useful. Ideally, we'd have one central switch for turning warnings into errors and this would be unnecessary. But we're not there yet. In the meantime, could you add a comment explaining why multiple RUN lines are used?

Tue, Mar 30, 9:22 AM · Restricted Project
awarzynski added a comment to D99573: Remove Cmake compiler arguments..

With this change the corresponding configurations will depend on the worker's internal set-up to use the desired compiler. IMO that's totally fine, provided that:

  • linaro-aarch64-flang-latest-clang picks at least clang-11, and
  • linaro-aarch64-flang-latest-gcc picks at least gcc-10.

But it is hard for me to review/check this without knowing the configuration of your workers. I'll defer to @maxim-kuvyrkov .

We set compiler for various bot configurations at https://git.linaro.org/ci/dockerfiles.git/tree/tcwg-base/tcwg-llvmbot/run.sh#n61 .

Personally I think that using CMake variables makes the configuration easier to reason about. Perhaps that's just implementation detail?

We have experimented with this, and using CMake variables ...
... made it hard to experiment with new compiler versions for periodic updates
... made it tricky to use ccache consistently, especially for 2-stage builds.
So we decided to use rely on default cmake behavior of picking up /usr/local/bin/cc and /usr/local/bin/c++ for the compilers, and point these wrappers to specific compiler we want to use.

Tue, Mar 30, 6:52 AM
awarzynski added a comment to D99573: Remove Cmake compiler arguments..

With this change the corresponding configurations will depend on the worker's internal set-up to use the desired compiler. IMO that's totally fine, provided that:

  • linaro-aarch64-flang-latest-clang picks at least clang-11, and
  • linaro-aarch64-flang-latest-gcc picks at least gcc-10.
Tue, Mar 30, 5:13 AM

Mon, Mar 29

awarzynski added inline comments to D99292: [flang][driver] Add support for `-cpp/-nocpp`.
Mon, Mar 29, 12:00 PM · Restricted Project, Restricted Project
awarzynski updated the diff for D99292: [flang][driver] Add support for `-cpp/-nocpp`.

Make sure that -cpp\-nocpp controls command line macro definitions too

Mon, Mar 29, 11:58 AM · Restricted Project, Restricted Project
awarzynski committed rGe8515ca8478f: [flang] Update output format test to use GTest (authored by ashermancinelli).
[flang] Update output format test to use GTest
Mon, Mar 29, 9:19 AM
awarzynski closed D98303: [flang] Update output format test to use GTest.
Mon, Mar 29, 9:19 AM · Restricted Project, Restricted Project
awarzynski accepted D99336: [flang][driver] Add default intrinsic module path in f18.

With this patch we can share more tests between the drivers and their behavior with respect to module paths becomes more consistent. Great to see this, thank you @arnamoy10 !

Mon, Mar 29, 3:58 AM · Restricted Project, Restricted Project
awarzynski updated the summary of D99494: [flang] Move .f77 to the list of fixed-form file extension.
Mon, Mar 29, 3:45 AM · Restricted Project, Restricted Project
awarzynski requested review of D99494: [flang] Move .f77 to the list of fixed-form file extension.
Mon, Mar 29, 3:43 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D99292: [flang][driver] Add support for `-cpp/-nocpp`.

Address PR comments + updated comments + rebase

Mon, Mar 29, 3:32 AM · Restricted Project, Restricted Project
awarzynski added a comment to D95460: [flang][driver] Add forced form flags and -ffixed-line-length.

Interestingly, GCC does not _error_ when using gfortran flags:

$ gcc -ffree-form file.c
cc1: warning: command line option ‘-ffree-form’ is valid for Fortran but not for C

I've implemented similar behavior for Clang in https://reviews.llvm.org/D99353. Please, could you take a look and see whether that solves your problem?

Mon, Mar 29, 2:39 AM · Restricted Project, Restricted Project

Sun, Mar 28

awarzynski accepted D98303: [flang] Update output format test to use GTest.

LGTM, thank you for working on this! I've left a couple of comments, but these are [nit]s (feel free to ignore!).

Sun, Mar 28, 12:52 PM · Restricted Project, Restricted Project

Thu, Mar 25

awarzynski committed rGfcf629d76a49: [flang][driver] Fix typos and inconsistent comments (nfc) (authored by awarzynski).
[flang][driver] Fix typos and inconsistent comments (nfc)
Thu, Mar 25, 12:02 PM
awarzynski added a reviewer for D99353: [driver] Make `clang` warn rather then error on `flang` options: protze.joachim.
Thu, Mar 25, 10:27 AM · Restricted Project, Restricted Project
awarzynski updated subscribers of D99353: [driver] Make `clang` warn rather then error on `flang` options.

I've not had a chance to add tests yet. I will add them shortly.

Thu, Mar 25, 10:27 AM · Restricted Project, Restricted Project
awarzynski requested review of D99353: [driver] Make `clang` warn rather then error on `flang` options.
Thu, Mar 25, 10:24 AM · Restricted Project, Restricted Project
awarzynski added reviewers for D99292: [flang][driver] Add support for `-cpp/-nocpp`: SouraVX, richard.barton.arm.
Thu, Mar 25, 7:29 AM · Restricted Project, Restricted Project
awarzynski added a comment to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..

I made a trivial fix to get the builds to pass.
https://reviews.llvm.org/rG502f27e66fd9fe44cd45ec5acae3e18f15f2d8c6

Thu, Mar 25, 6:09 AM · Restricted Project, Restricted Project

Wed, Mar 24

awarzynski updated the summary of D98847: [flang][driver] Fix `-fdebug-dump-provenance`.
Wed, Mar 24, 12:26 PM · Restricted Project, Restricted Project
awarzynski added reviewers for D99292: [flang][driver] Add support for `-cpp/-nocpp`: tskeith, klausler, kiranchandramohan, AMDChirag, kiranktp, sameeranjoshi, arnamoy10, ashermancinelli.
Wed, Mar 24, 12:25 PM · Restricted Project, Restricted Project
awarzynski added inline comments to D99292: [flang][driver] Add support for `-cpp/-nocpp`.
Wed, Mar 24, 12:24 PM · Restricted Project, Restricted Project
awarzynski updated the diff for D98847: [flang][driver] Fix `-fdebug-dump-provenance`.

Rebase on top of D99292

Wed, Mar 24, 12:22 PM · Restricted Project, Restricted Project
awarzynski requested review of D99292: [flang][driver] Add support for `-cpp/-nocpp`.
Wed, Mar 24, 12:21 PM · Restricted Project, Restricted Project
awarzynski added a comment to D98657: [flang][driver] Add options for -Werror.

I see that -Werror changes the behavior of the driver in 5 different places. I would hope to see 5 new tests to verify each case.

Wed, Mar 24, 8:51 AM · Restricted Project
awarzynski accepted D97119: [flang][driver] Add options for -std=f2018.

Thank you for updating this @arnamoy10!

Wed, Mar 24, 8:22 AM · Restricted Project, Restricted Project
awarzynski accepted D99264: Remove 'release' and 'aarch64' tags from Flang builders..

Thank you for updating this!

Wed, Mar 24, 8:12 AM
awarzynski added a comment to D99264: Remove 'release' and 'aarch64' tags from Flang builders..

Removing the release tags makes a lot of sense - the semantics of it mean "test the release branch only" (added here).

Wed, Mar 24, 7:26 AM

Tue, Mar 23

awarzynski committed rG2f8e614df883: [flang][cmake] Fix variable reference (${var} instead of var) (authored by awarzynski).
[flang][cmake] Fix variable reference (${var} instead of var)
Tue, Mar 23, 9:06 AM
awarzynski committed rGaf8056889ac9: [flang][cmake] Improve how CLANG_DIR is handled (authored by awarzynski).
[flang][cmake] Improve how CLANG_DIR is handled
Tue, Mar 23, 8:16 AM
awarzynski closed D99088: [flang][cmake] Improve how CLANG_DIR is handled.
Tue, Mar 23, 8:16 AM · Restricted Project, Restricted Project
awarzynski accepted D98787: Add Clang dependency for new Flang driver in out-of-tree builder..

No no, I hacked it manually to include that change. It is certainly still necessary.

Tue, Mar 23, 7:30 AM
awarzynski added a comment to D99088: [flang][cmake] Improve how CLANG_DIR is handled.

One quick question. Otherwise looks good.

Tue, Mar 23, 7:22 AM · Restricted Project, Restricted Project
awarzynski retitled D99088: [flang][cmake] Improve how CLANG_DIR is handled from [flang][cmake] Make sure that CLANG_DIR is an absolute path to [flang][cmake] Improve how CLANG_DIR is handled.
Tue, Mar 23, 7:19 AM · Restricted Project, Restricted Project