Page MenuHomePhabricator

awarzynski (Andrzej Warzynski)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2020, 4:57 AM (25 w, 3 d)

Recent Activity

Yesterday

awarzynski added inline comments to D90048: [flang][OpenMP] Upstream lowering of OpenMP `Flush` construct.
Fri, Oct 23, 8:26 AM · Restricted Project, Restricted Project

Thu, Oct 22

awarzynski added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Ping

Thu, Oct 22, 4:04 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a reviewer for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O: richard.barton.arm.
Thu, Oct 22, 4:04 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Oct 21

awarzynski added a comment to D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC).

Thank you all for you comments! Please find my replies below. I've picked 4 main points raised here.

Wed, Oct 21, 9:46 AM · Restricted Project

Tue, Oct 20

awarzynski added a comment to D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more..

Hi @oneraynyday ! This looks very interesting - thanks for uploading! I've only quickly skimmed through. Two high level points:

  • Have you considered sending an RFC to cfe-dev regarding this tool? I think that it would be a great way of attracting peoples attention. More importantly, should we add another tool to clang-tools-extra?
  • Tthis is a rather large patch - could you split it into separate chunks? Otherwise it's quite tricky to review.
Tue, Oct 20, 1:17 PM · Restricted Project, Restricted Project
awarzynski edited reviewers for D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC), added: MaskRay, tra, rnk, hans; removed: jdoerfert.
Tue, Oct 20, 12:51 PM · Restricted Project
awarzynski requested review of D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC).
Tue, Oct 20, 8:43 AM · Restricted Project

Mon, Oct 19

awarzynski updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Apply fix to unit test that got lost in the previous patch, simplify C input file

Mon, Oct 19, 10:34 AM · Restricted Project, Restricted Project
awarzynski added inline comments to D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.
Mon, Oct 19, 10:24 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Address PR comments, make clearer separation between option types, simplify/fix tests

Mon, Oct 19, 10:16 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Simplify the API for creating output files

Mon, Oct 19, 6:14 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Oct 16

awarzynski retitled D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction from [Flang][Driver]Add PrintPreprocessedInput action `-E` to [Flang][Driver] Add PrintPreprocessed FrontendAction.
Fri, Oct 16, 7:57 AM · Restricted Project, Restricted Project
awarzynski commandeered D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Since @CarolineConcatto has recently moved to a different project, I am assigning this to myself and will be responding to the future review comments. Thank you for all the effort @CarolineConcatto !

Fri, Oct 16, 7:53 AM · Restricted Project, Restricted Project
awarzynski updated the diff for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction.

Rebase + refector the unit test

Fri, Oct 16, 7:51 AM · Restricted Project, Restricted Project

Thu, Oct 15

awarzynski added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

I've added more reviewers for the Clang side of this patch. I choose people who most recently changed the functions/files that this patch modifies. Any input much appreciated! For more context regarding Clang changes: http://lists.llvm.org/pipermail/cfe-dev/2020-October/066953.html

Thu, Oct 15, 10:16 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added reviewers for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O: rnk, hans, bkramer, yamaguchi.
Thu, Oct 15, 10:14 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski updated the diff for D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Address PR comments, clang-format, rebase

Thu, Oct 15, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski commandeered D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

Thank you for reviewing @SouraVX! I'm just about to submit an updated patch with the requested changes.

Thu, Oct 15, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski accepted D89452: [flang] Fix build with BUILD_SHARED_LIBS=ON.

Thanks for testing so extensively! LGTM!

Thu, Oct 15, 3:57 AM · Restricted Project
awarzynski accepted D89452: [flang] Fix build with BUILD_SHARED_LIBS=ON.
Thu, Oct 15, 2:34 AM · Restricted Project
awarzynski added a comment to D89452: [flang] Fix build with BUILD_SHARED_LIBS=ON.

Thank you for fixing this so quickly @serge-sans-paille , that's much appreciated!

Thu, Oct 15, 2:34 AM · Restricted Project

Wed, Oct 14

awarzynski added a comment to D87893: [flang] Make flang build compatible with LLVM dylib.

The CMake error for flang-new is now fixed, but I'm no longer able to build Flang with BUILD_SHARED_LIBS=On. @serge-sans-paille , have you tested that configuration? I'm struggling to find a fix.

Wed, Oct 14, 2:56 PM · Restricted Project
awarzynski committed rG42e89ab2a668: [flang] Fix CMake bug in the definition of flang-new (authored by awarzynski).
[flang] Fix CMake bug in the definition of flang-new
Wed, Oct 14, 11:25 AM
awarzynski closed D89403: [flang] Fix CMake bug in the definition of flang-new.
Wed, Oct 14, 11:25 AM · Restricted Project
awarzynski updated the diff for D89403: [flang] Fix CMake bug in the definition of flang-new.

Revert accidental and unnecessary change

Wed, Oct 14, 9:50 AM · Restricted Project
awarzynski added reviewers for D89403: [flang] Fix CMake bug in the definition of flang-new: serge-sans-paille, DavidTruby.
Wed, Oct 14, 9:49 AM · Restricted Project
awarzynski added a comment to D87893: [flang] Make flang build compatible with LLVM dylib.

@serge-sans-paille Thank you for working on this! Sadly the Flang buildbot is unhappy again:http://lab.llvm.org:8014/#/builders/109/builds/35. I'm guessing that you didn't test with -DFLANG_BUILD_NEW_DRIVER=ON?

IIUC, the add_flang_tool macro needs fixing/updating. I'll take a look and submit something. Perhaps I'll need to revert the changes in flang/tools/flang-driver/CMakeLists.txt. in the interim.

Wed, Oct 14, 9:49 AM · Restricted Project
awarzynski requested review of D89403: [flang] Fix CMake bug in the definition of flang-new.
Wed, Oct 14, 9:48 AM · Restricted Project
awarzynski added a comment to D87893: [flang] Make flang build compatible with LLVM dylib.

@serge-sans-paille Thank you for working on this! Sadly the Flang buildbot is unhappy again:http://lab.llvm.org:8014/#/builders/109/builds/35. I'm guessing that you didn't test with -DFLANG_BUILD_NEW_DRIVER=ON?

Wed, Oct 14, 7:22 AM · Restricted Project

Mon, Oct 12

awarzynski added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

@reviewers A note regarding the changes in Clang.

Mon, Oct 12, 2:26 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Oct 9

awarzynski committed rGdcd9be43e5c7: [mlir] Fix shared libs build (authored by awarzynski).
[mlir] Fix shared libs build
Fri, Oct 9, 8:40 AM
awarzynski closed D89111: [mlir] Fix shared libs build.
Fri, Oct 9, 8:39 AM · Restricted Project
awarzynski added a comment to D89111: [mlir] Fix shared libs build.

Sorry for breaking the bot :-/

Fri, Oct 9, 8:05 AM · Restricted Project
awarzynski added reviewers for D89111: [mlir] Fix shared libs build: serge-sans-paille, mehdi_amini.
Fri, Oct 9, 3:01 AM · Restricted Project
awarzynski added a comment to D88846: [mlir] Improve LLVM shlib support.

Hi @serge-sans-paille, thanks for working on this!

Fri, Oct 9, 3:01 AM · Restricted Project
awarzynski requested review of D89111: [mlir] Fix shared libs build.
Fri, Oct 9, 2:58 AM · Restricted Project
awarzynski committed rZORG6414deadea40: flang-aarch64: Refine the number of parallel jobs (authored by awarzynski).
flang-aarch64: Refine the number of parallel jobs
Fri, Oct 9, 12:29 AM
awarzynski closed D89030: flang-aarch64: Refine the number of parallel jobs.
Fri, Oct 9, 12:29 AM

Thu, Oct 8

awarzynski added a comment to D88767: Show register names in DWARF unwind info..

@clayborg Our Flang-AArch64 buildbots have been failing due to this: http://lab.llvm.org:8011/#/builders/34/builds/13. Please, could this be either reverted or the other patch merged? Thanks!

I didn't see any failures on the llvm buildbots that email me when they fail. The other patch will be merged as soon as accepted. Should be tomorrow morning.

Thanks! I think that the buildbot master was restarted recently and hence our worker wasn't able to generate an accurate blamelist. Otherwise everything seems fine.

Fixed with https://reviews.llvm.org/D88940. Let me know if this fixes things on your end!

Thu, Oct 8, 1:38 AM · Restricted Project
awarzynski added a reviewer for D89030: flang-aarch64: Refine the number of parallel jobs: CarolineConcatto.
Thu, Oct 8, 1:35 AM
awarzynski requested review of D89030: flang-aarch64: Refine the number of parallel jobs.
Thu, Oct 8, 1:34 AM

Wed, Oct 7

awarzynski added a comment to D88767: Show register names in DWARF unwind info..

@clayborg Our Flang-AArch64 buildbots have been failing due to this: http://lab.llvm.org:8011/#/builders/34/builds/13. Please, could this be either reverted or the other patch merged? Thanks!

I didn't see any failures on the llvm buildbots that email me when they fail. The other patch will be merged as soon as accepted. Should be tomorrow morning.

Wed, Oct 7, 1:30 AM · Restricted Project
awarzynski added a comment to D88767: Show register names in DWARF unwind info..

I made a patch to fix buildbots that don't compile in certain architectures with https://reviews.llvm.org/D88940

Wed, Oct 7, 12:52 AM · Restricted Project

Tue, Oct 6

awarzynski committed rZORGbd6fa0d220a9: flang-aarch64-ubuntu-clang-build: increase the number of parellel jobs (authored by awarzynski).
flang-aarch64-ubuntu-clang-build: increase the number of parellel jobs
Tue, Oct 6, 5:27 AM
awarzynski closed D88874: flang-aarch64-ubuntu-clang-build: increase the number of parellel jobs.
Tue, Oct 6, 5:27 AM
awarzynski added a reviewer for D88874: flang-aarch64-ubuntu-clang-build: increase the number of parellel jobs: CarolineConcatto.
Tue, Oct 6, 1:00 AM
awarzynski requested review of D88874: flang-aarch64-ubuntu-clang-build: increase the number of parellel jobs.
Tue, Oct 6, 1:00 AM
awarzynski committed rZORG90d5e81834d1: flang-aarch64-ubuntu-clang: Refine the set-up for `-WError` (authored by awarzynski).
flang-aarch64-ubuntu-clang: Refine the set-up for `-WError`
Tue, Oct 6, 12:56 AM
awarzynski closed D88811: flang-aarch64-ubuntu-clang: Refine the set-up for `-WError`.
Tue, Oct 6, 12:56 AM
awarzynski committed rG25692b7765e2: [flang][NFC] Remove redundant `;` (authored by awarzynski).
[flang][NFC] Remove redundant `;`
Tue, Oct 6, 12:47 AM

Mon, Oct 5

awarzynski committed rG8d51d37e0628: [flang] Introduce DiagnosticConsumer classes in libflangFrontend (authored by awarzynski).
[flang] Introduce DiagnosticConsumer classes in libflangFrontend
Mon, Oct 5, 9:51 AM
awarzynski closed D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.
Mon, Oct 5, 9:51 AM · Restricted Project
awarzynski added a reviewer for D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction: sameeranjoshi.
Mon, Oct 5, 2:36 AM · Restricted Project, Restricted Project
awarzynski added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Ping :)

Mon, Oct 5, 2:10 AM · Restricted Project
awarzynski updated the summary of D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.
Mon, Oct 5, 2:08 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

LGTM, thanks for working on this!

Mon, Oct 5, 2:07 AM · Restricted Project, Restricted Project, Restricted Project
awarzynski added a reviewer for D88811: flang-aarch64-ubuntu-clang: Refine the set-up for `-WError`: CarolineConcatto.
Mon, Oct 5, 1:05 AM
awarzynski requested review of D88811: flang-aarch64-ubuntu-clang: Refine the set-up for `-WError`.
Mon, Oct 5, 1:05 AM

Sat, Oct 3

awarzynski committed rG35a2a042ddd1: [flang][NFC] Fix build errors for clang-10 (authored by awarzynski).
[flang][NFC] Fix build errors for clang-10
Sat, Oct 3, 7:10 AM
awarzynski closed D88723: [flang] Fix build errors for clang-10.
Sat, Oct 3, 7:10 AM · Restricted Project, Restricted Project
awarzynski added a comment to D88723: [flang] Fix build errors for clang-10.

@tskeith Thank you for the heads up. Updated accordingly and merged!

Sat, Oct 3, 7:05 AM · Restricted Project, Restricted Project

Fri, Oct 2

awarzynski added reviewers for D88723: [flang] Fix build errors for clang-10: klausler, clementval, sscalpone, DavidTruby.
Fri, Oct 2, 2:03 AM · Restricted Project, Restricted Project
awarzynski updated subscribers of D88723: [flang] Fix build errors for clang-10.

For reference:
@clementval: https://reviews.llvm.org/D87389

/home/flang/temp/llvm-project/flang/lib/Lower/OpenACC.cpp:102:32: error: unused variable 'argTy' [-Werror,-Wunused-variable]
    llvm::ArrayRef<mlir::Type> argTy;
                               ^
1 error generated.
Fri, Oct 2, 2:02 AM · Restricted Project, Restricted Project
awarzynski requested review of D88723: [flang] Fix build errors for clang-10.
Fri, Oct 2, 1:56 AM · Restricted Project, Restricted Project

Thu, Oct 1

awarzynski added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

@CarolineConcatto thank you again for working on this! The structure is good, but IMHO this patch could be polished a bit more. Overall:

  • could you make sure that this patch does not change the output from clang -help?
  • doxygen comments are consistent
  • unittests are a bit better documentated (what and why is tested?)
  • use llvm/Support/FileSystem.h instead of <filesystem>

More comments inline. Otherwise, I think that this is almost ready :)

Thu, Oct 1, 12:33 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 29

awarzynski committed rG6199219bbd82: [mlir] Fix shared libs build (authored by awarzynski).
[mlir] Fix shared libs build
Tue, Sep 29, 6:31 AM
awarzynski closed D88484: [mlir] Fix shared libs build.
Tue, Sep 29, 6:31 AM · Restricted Project
awarzynski added a comment to D88484: [mlir] Fix shared libs build.

https://reviews.llvm.org/D88351 has caused our Flang buildbots to start failing:

These buildbots are not in production yet (still connected to the staging master), so no notifications are sent.

Tue, Sep 29, 6:28 AM · Restricted Project
awarzynski added reviewers for D88484: [mlir] Fix shared libs build: mehdi_amini, kiranchandramohan.
Tue, Sep 29, 6:24 AM · Restricted Project
awarzynski requested review of D88484: [mlir] Fix shared libs build.
Tue, Sep 29, 6:23 AM · Restricted Project

Mon, Sep 28

awarzynski updated the diff for D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Address the remaining PR comments, fix test

Mon, Sep 28, 10:06 AM · Restricted Project
awarzynski added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Do you know if there are any bots configured to handle out-of-tree changes?
That might be helpful to avoid configuration differences and test OFT patches.

Mon, Sep 28, 10:04 AM · Restricted Project

Fri, Sep 25

awarzynski committed rG6f10998ad806: [flang][driver] Add missing dependency (shared library builds, NFC) (authored by awarzynski).
[flang][driver] Add missing dependency (shared library builds, NFC)
Fri, Sep 25, 1:57 AM

Thu, Sep 24

awarzynski committed rGb9a2837f1617: [flang][driver] Add missing dependency (shared library builds, NFC) (authored by awarzynski).
[flang][driver] Add missing dependency (shared library builds, NFC)
Thu, Sep 24, 1:13 PM
awarzynski added inline comments to D88219: [flang][driver] Remove unnecessary includes in the unittest.
Thu, Sep 24, 5:21 AM · Restricted Project
awarzynski updated the diff for D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Rebase on top of master

Thu, Sep 24, 5:15 AM · Restricted Project
awarzynski committed rG10c94d8cf876: [flang][driver] Remove unnecessary includes in the unittest (NFC) (authored by awarzynski).
[flang][driver] Remove unnecessary includes in the unittest (NFC)
Thu, Sep 24, 5:05 AM
awarzynski closed D88219: [flang][driver] Remove unnecessary includes in the unittest.
Thu, Sep 24, 5:05 AM · Restricted Project
awarzynski added a comment to D88219: [flang][driver] Remove unnecessary includes in the unittest.

LGTM, perhaps put NFC in the commit message?

Thu, Sep 24, 5:04 AM · Restricted Project
awarzynski added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

@sameeranjoshi Regarding <filesystem>, please see https://reviews.llvm.org/D88219. Sadly we missed that when adding that test, sorry!

Thu, Sep 24, 5:02 AM · Restricted Project
awarzynski added reviewers for D88219: [flang][driver] Remove unnecessary includes in the unittest: CarolineConcatto, sameeranjoshi.
Thu, Sep 24, 5:00 AM · Restricted Project
awarzynski requested review of D88219: [flang][driver] Remove unnecessary includes in the unittest.
Thu, Sep 24, 4:59 AM · Restricted Project

Sep 24 2020

awarzynski added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

@sameeranjoshi Apologies, I missed some of your comments.

Sep 24 2020, 2:23 AM · Restricted Project
awarzynski committed rG27da2875070a: [flang][NFC] Fix CMake variable name in README.md (authored by awarzynski).
[flang][NFC] Fix CMake variable name in README.md
Sep 24 2020, 1:43 AM
awarzynski committed rG2f90e01a963a: [flang][driver] Add missing dependency in CMake files (authored by awarzynski).
[flang][driver] Add missing dependency in CMake files
Sep 24 2020, 1:33 AM
awarzynski closed D88110: [flang][driver] Add missing dependency in CMake files.
Sep 24 2020, 1:33 AM · Restricted Project
awarzynski committed rG99edb9b79c46: [flang][driver] Fix options flag in the frontend driver (authored by awarzynski).
[flang][driver] Fix options flag in the frontend driver
Sep 24 2020, 12:45 AM
awarzynski closed D88108: [flang][driver] Fix options flang in the frontend driver.
Sep 24 2020, 12:45 AM · Restricted Project

Sep 23 2020

awarzynski added a comment to D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Thank you for reviewing! I think that I've addressed all your comments.. Please see the updated patch.

Sep 23 2020, 9:57 AM · Restricted Project
awarzynski updated the diff for D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend.

Move code from Fortran to Fortran::frontend namespace, address PR comments

Sep 23 2020, 9:56 AM · Restricted Project

Sep 22 2020

awarzynski added reviewers for D88110: [flang][driver] Add missing dependency in CMake files: CarolineConcatto, sameeranjoshi.
Sep 22 2020, 11:43 AM · Restricted Project
awarzynski requested review of D88110: [flang][driver] Add missing dependency in CMake files.
Sep 22 2020, 11:42 AM · Restricted Project
awarzynski added reviewers for D88108: [flang][driver] Fix options flang in the frontend driver: CarolineConcatto, sameeranjoshi.
Sep 22 2020, 11:10 AM · Restricted Project
awarzynski requested review of D88108: [flang][driver] Fix options flang in the frontend driver.
Sep 22 2020, 11:10 AM · Restricted Project
awarzynski added a comment to D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O.

@CarolineConcatto , thank you for this patch! It implements some really important functionality and IMO the overall structure is solid.

Sep 22 2020, 10:19 AM · Restricted Project, Restricted Project, Restricted Project

Sep 21 2020

awarzynski committed rG4eae6fc95f95: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage (authored by awarzynski).
[clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage
Sep 21 2020, 1:42 AM
awarzynski closed D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage.
Sep 21 2020, 1:42 AM · Restricted Project
awarzynski added a comment to D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage.

Thanks for reviewing @sanwou01 ! No new comments, so I'll submit as is.

Sep 21 2020, 1:41 AM · Restricted Project

Sep 17 2020

awarzynski added reviewers for D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage: rsmith, christof, sanwou01, snnw.
Sep 17 2020, 1:14 AM · Restricted Project
awarzynski requested review of D87816: [clang] Fix incorrect call to TextDiagnostic::printDiagnosticMessage.
Sep 17 2020, 1:10 AM · Restricted Project