- User Since
- Apr 28 2020, 4:57 AM (152 w, 11 h)
Thanks for implementing this, LGTM!
Thanks for the explanation! Still looking good apart from the function names ;)
LGTM, thanks for working on this! (please fix the name in CommonArgs.h before landing this)
Address Cullen's comments
Thanks for the review @c-rhodes , sending updates shortly.
Thanks for the updates! A few more pointers, but nothing major.
Thanks for the updates, mostly looks good. Just a couple of extra questions about the test coverage.
LGTM, thanks! As @kiranchandramohan points out, this is in line with the overall direction that we agreed on a while back.
What's the overall design goal here? 100% consistency with Clang? Could this be documented?
Fix Toy examples builds
Sun, Mar 26
Fri, Mar 24
Thanks for submitting this! Please add tests for -g and all variants of -gline-tables-only.
Thu, Mar 23
Address Diego's comments
This is a very nice patch, thanks for working on this! A few final nits, but feel free to ignore. LGTM
Wed, Mar 22
A few more comments, but mostly nits. Btw, is this patch sufficient to generate code for AMDGPU? Or, put differently, what's the level of support atm?
Really nice to see some shared code being elevated out of Clang into LLVM, thanks!
Tue, Mar 21
Thanks for the updates!
Mon, Mar 20
Sun, Mar 19
LGTM, thanks for improving this!
Sat, Mar 18
We already have an error message, so print it as well.
Fri, Mar 17
Could you add some tests?
Thu, Mar 16
LGTM, thanks for working on this! Would be great for somebody with a bit more experience with offloading to OK this as well :) @tschuett or perhaps @jhuber6 ?
Thanks for checking - something for a TODO list!
Thanks! Would replacing llvm-readelf -h with llvm-objdump -f also work? I'd rather avoid new dependencies if possible.
Wed, Mar 15
Please add tests ;)
Tue, Mar 14
Thanks for improving these improvements @vzakhari !
Mon, Mar 13
LGTM, thanks for contributing!
Fix the issue of .o file generated by Flang with Flags info is 0x0 under RISC-V.
Why does "flang/test/Driver/target-features.f90" list all RISC-V features? Why not use https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/target-cpu-features.f90 instead?
Sat, Mar 11
I'd move these tests to flang/test/Driver/supported-suffices. That would help documenting what these tests actual check for. Also, one could be tempted to test for other suffices and then it would be nice to keep them in one place. Ta!
Wed, Mar 8
Tue, Mar 7
Address PR comments
Mon, Mar 6
Fri, Mar 3
Thank you very much @awarzynski for suggesting them that was a great help.
Thu, Mar 2
LGTM, many thanks for working on this!
After this patch:
Wed, Mar 1
Refine how contiguous loads are identified
Tue, Feb 28
@bkramer , sorry about this issue and thanks for reverting!
Feb 23 2023
Feb 22 2023
Feb 21 2023
LGTM, thanks for seeing this through! :)