There are a few advantages of using CMAKE_INSTALL_LIBDIR in place of
LLVM_LIBDIR_SUFFIX:
- it's a standard flag, no need to support an extra cmake configuration
- it has sane defaults, and picks lib64 instead of lib on some systems (including Fedora)
Paths
| Differential D137337
Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR Needs ReviewPublic Authored by serge-sans-paille on Nov 3 2022, 7:21 AM.
Details Summary There are a few advantages of using CMAKE_INSTALL_LIBDIR in place of
Diff Detail Event TimelineHerald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript Herald added subscribers: libc-commits, libcxx-commits, Moerafaat and 30 others. · View Herald Transcript Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript Herald added subscribers: llvm-commits, openmp-commits, lldb-commits and 7 others. · View Herald Transcript
Comment Actions Can you verify if projects enabled by LLVM_ENABLE_RUNTIMES (not LLVM_ENABLE_PROJECTS) will still be installed properly, aka in LLVM's lib directory?
compnerd added inline comments.
barannikov88 added inline comments.
Comment Actions For libc++ we like to clean up the review queue for the GitHub PR transition. Is there still interest on working on this patch? If so would it be possible to finish it before the Phabricator is changed to read only mode?
Revision Contents
Diff 472945 bolt/CMakeLists.txt
bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in
bolt/lib/RuntimeLibs/RuntimeLibrary.cpp
bolt/runtime/CMakeLists.txt
clang/CMakeLists.txt
clang/cmake/caches/Android-stage2.cmake
clang/cmake/caches/Android.cmake
clang/cmake/modules/AddClang.cmake
clang/cmake/modules/CMakeLists.txt
clang/include/clang/Config/config.h.cmake
clang/lib/Driver/Driver.cpp
clang/lib/Driver/ToolChains/CommonArgs.cpp
clang/lib/Headers/CMakeLists.txt
clang/runtime/CMakeLists.txt
clang/tools/libclang/CMakeLists.txt
clang/tools/scan-build-py/CMakeLists.txt
cmake/Modules/GNUInstallPackageDir.cmake
compiler-rt/cmake/Modules/CompilerRTAIXUtils.cmake
compiler-rt/cmake/Modules/CompilerRTUtils.cmake
compiler-rt/cmake/base-config-ix.cmake
compiler-rt/docs/BuildingCompilerRT.rst
flang/CMakeLists.txt
flang/cmake/modules/AddFlang.cmake
flang/cmake/modules/CMakeLists.txt
libc/lib/CMakeLists.txt
libcxx/CMakeLists.txt
libcxx/docs/BuildingLibcxx.rst
libcxxabi/CMakeLists.txt
libunwind/CMakeLists.txt
libunwind/docs/BuildingLibunwind.rst
lld/CMakeLists.txt
lld/cmake/modules/AddLLD.cmake
lld/cmake/modules/CMakeLists.txt
lldb/cmake/modules/AddLLDB.cmake
lldb/cmake/modules/LLDBGenerateConfig.cmake
lldb/cmake/modules/LLDBStandalone.cmake
lldb/source/API/CMakeLists.txt
lldb/test/CMakeLists.txt
lldb/tools/intel-features/CMakeLists.txt
lldb/utils/lldb-dotest/CMakeLists.txt
llvm/CMakeLists.txt
llvm/cmake/modules/AddLLVM.cmake
llvm/cmake/modules/AddOCaml.cmake
llvm/cmake/modules/CMakeLists.txt
llvm/cmake/modules/LLVMConfig.cmake.in
llvm/docs/CMake.rst
llvm/docs/ReleaseNotes.rst
llvm/tools/llvm-config/BuildVariables.inc.in
llvm/tools/llvm-config/llvm-config.cpp
llvm/utils/gn/secondary/llvm/tools/llvm-config/BUILD.gn
mlir/CMakeLists.txt
mlir/cmake/modules/AddMLIR.cmake
mlir/cmake/modules/AddMLIRPython.cmake
mlir/cmake/modules/CMakeLists.txt
mlir/test/CMakeLists.txt
openmp/CMakeLists.txt
openmp/README.rst
openmp/libompd/src/CMakeLists.txt
openmp/libomptarget/DeviceRTL/CMakeLists.txt
openmp/libomptarget/plugins-nextgen/CMakeLists.txt
openmp/libomptarget/plugins-nextgen/cuda/CMakeLists.txt
openmp/libomptarget/plugins/CMakeLists.txt
openmp/libomptarget/plugins/amdgpu/CMakeLists.txt
openmp/libomptarget/plugins/cuda/CMakeLists.txt
openmp/libomptarget/plugins/remote/src/CMakeLists.txt
openmp/libomptarget/plugins/ve/CMakeLists.txt
openmp/libomptarget/src/CMakeLists.txt
openmp/runtime/src/CMakeLists.txt
openmp/tools/Modules/CMakeLists.txt
openmp/tools/archer/CMakeLists.txt
polly/cmake/CMakeLists.txt
|
The prefix must remain LLVM_*
In other components accordingly