Page MenuHomePhabricator

sebastian-ne (Sebastian Neubauer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 27 2020, 1:17 AM (73 w, 20 h)

Recent Activity

Today

sebastian-ne committed rG4684cd543cfa: [NFC] Fix typo (authored by sebastian-ne).
[NFC] Fix typo
Mon, Jun 21, 6:00 AM
sebastian-ne updated the diff for D103326: [GlobalISel] Add combine for PTR_ADD with regbanks.

I now added two helper function in CombinerHelper,
getRegBankId returns an Optional<unsigned> for a register and
setRegBankId sets such an optional bank to a register (or does nothing it it’s None).

Mon, Jun 21, 5:47 AM · Restricted Project
sebastian-ne committed rGbbd7424402c7: [AMDGPU] Fix linking with shared libraries (authored by sebastian-ne).
[AMDGPU] Fix linking with shared libraries
Mon, Jun 21, 2:12 AM

Mon, Jun 7

sebastian-ne committed rG96e1fcb1e005: [AMDGPU] Use s_add_i32 for address additions (authored by sebastian-ne).
[AMDGPU] Use s_add_i32 for address additions
Mon, Jun 7, 7:10 AM
sebastian-ne closed D103322: [AMDGPU] Use s_add_i32 for address additions.
Mon, Jun 7, 7:10 AM · Restricted Project

Fri, Jun 4

sebastian-ne updated the diff for D103326: [GlobalISel] Add combine for PTR_ADD with regbanks.

Fix most inline review comments

Fri, Jun 4, 7:49 AM · Restricted Project
sebastian-ne added inline comments to D103636: [AMDGPU][IndirectCalls] Fix register usage propagation for indirect/external calls.
Fri, Jun 4, 7:46 AM · Restricted Project

Fri, May 28

sebastian-ne added a comment to D103322: [AMDGPU] Use s_add_i32 for address additions.

This allows to convert the add instruction to s_addk_i32

Nice. (But perhaps we should be able to convert s_add_u32 -> s_addk_i32 if scc is dead?)

Fri, May 28, 10:05 AM · Restricted Project
sebastian-ne requested review of D103326: [GlobalISel] Add combine for PTR_ADD with regbanks.
Fri, May 28, 9:19 AM · Restricted Project
sebastian-ne requested review of D103322: [AMDGPU] Use s_add_i32 for address additions.
Fri, May 28, 8:38 AM · Restricted Project
sebastian-ne committed rG690f5b7a0128: [AMDGPU] Fix function calls with flat scratch (authored by sebastian-ne).
[AMDGPU] Fix function calls with flat scratch
Fri, May 28, 2:33 AM
sebastian-ne committed rG6133b60a27fe: [AMDGPU] Precommit test (authored by sebastian-ne).
[AMDGPU] Precommit test
Fri, May 28, 2:33 AM
sebastian-ne closed D103166: [AMDGPU] Fix function calls with flat scratch.
Fri, May 28, 2:33 AM · Restricted Project

Thu, May 27

sebastian-ne updated the diff for D103166: [AMDGPU] Fix function calls with flat scratch.

Does globalisel handle this?

Thu, May 27, 9:36 AM · Restricted Project
sebastian-ne committed rG0bb60dbe34e4: [AMDGPU][GlobalISel] Allow amdgpu_gfx calling conv (authored by sebastian-ne).
[AMDGPU][GlobalISel] Allow amdgpu_gfx calling conv
Thu, May 27, 1:49 AM
sebastian-ne closed D103183: [AMDGPU][GlobalISel] Allow amdgpu_gfx calling conv.
Thu, May 27, 1:49 AM · Restricted Project

Wed, May 26

sebastian-ne requested review of D103183: [AMDGPU][GlobalISel] Allow amdgpu_gfx calling conv.
Wed, May 26, 9:54 AM · Restricted Project
sebastian-ne committed rGea91a8cbab93: [AMDGPU][NFC] Remove non-existing function header (authored by sebastian-ne).
[AMDGPU][NFC] Remove non-existing function header
Wed, May 26, 9:21 AM
sebastian-ne committed rGfcd32d62c067: [AMDGPU] Fix function pointer argument bug in AMDGPU Propagate Attributes pass. (authored by jweightman).
[AMDGPU] Fix function pointer argument bug in AMDGPU Propagate Attributes pass.
Wed, May 26, 7:40 AM
sebastian-ne closed D101847: [AMDGPU] Fix function pointer argument bug in AMDGPU Propagate Attributes pass..
Wed, May 26, 7:40 AM · Restricted Project, Restricted Project
sebastian-ne requested review of D103166: [AMDGPU] Fix function calls with flat scratch.
Wed, May 26, 7:13 AM · Restricted Project

May 11 2021

sebastian-ne added a comment to D102177: [AMDGPU][RFC] Improve sgpr function arguments.

We have another proposal we were working on to rearrange these a bit differently. We need to account for a few more inputs in the layout

As long as this remains in GFX land, we should be fine with it because our new proposal is for compute only (as of now).

May 11 2021, 4:36 AM · Restricted Project

May 10 2021

sebastian-ne requested review of D102177: [AMDGPU][RFC] Improve sgpr function arguments.
May 10 2021, 9:18 AM · Restricted Project

May 7 2021

sebastian-ne committed rG13c0316239dc: [AMDGPU] Restrict immediate scratch offsets (authored by sebastian-ne).
[AMDGPU] Restrict immediate scratch offsets
May 7 2021, 6:01 AM
sebastian-ne closed D101292: [AMDGPU] Restrict immediate scratch offsets.
May 7 2021, 6:01 AM · Restricted Project
sebastian-ne added a comment to D101312: [Utils] Do not remove comments in llc test script.

I guess it is fine for MIR tests because they only use CHECK lines instead of CHECK-NEXT lines.

May 7 2021, 2:51 AM · Restricted Project
sebastian-ne updated the diff for D101292: [AMDGPU] Restrict immediate scratch offsets.

Fix typo.
Friendly ping for review

May 7 2021, 2:27 AM · Restricted Project
sebastian-ne committed rG98e5ede60499: [AMDGPU] Serialize MFInfo::ScavengeFI (authored by sebastian-ne).
[AMDGPU] Serialize MFInfo::ScavengeFI
May 7 2021, 2:15 AM
sebastian-ne closed D101367: [AMDGPU] Serialize MFInfo::ScavengeFI.
May 7 2021, 2:15 AM · Restricted Project
sebastian-ne added a comment to D101312: [Utils] Do not remove comments in llc test script.

friendly ping for review

May 7 2021, 1:10 AM · Restricted Project

May 6 2021

sebastian-ne updated the diff for D101367: [AMDGPU] Serialize MFInfo::ScavengeFI.

Return error instead of failing assert for non-existing frame index.

May 6 2021, 8:17 AM · Restricted Project

May 4 2021

sebastian-ne added inline comments to D101620: [AMDGPU][Disassembler] Adjust img instruction address field if a16 present.
May 4 2021, 8:50 AM · Restricted Project
sebastian-ne added a comment to D101578: [Attributor] Add AAExecutionDomainInfo interface to OpenMPOpt.

Hi,
The added test llvm/test/Transforms/OpenMP/single_threaded_execution.ll fails in release builds when assertions are disabled.
You probably need to add ; REQUIRES: asserts like it is done in llvm/test/CodeGen/Mips/brind-tailcall.ll.

May 4 2021, 5:05 AM · Restricted Project

May 3 2021

sebastian-ne updated the diff for D101367: [AMDGPU] Serialize MFInfo::ScavengeFI.

Add two tests to check invalid frame indices.

May 3 2021, 1:58 AM · Restricted Project
sebastian-ne committed rGc0c8548b7068: [AMDGPU] Do not annotate features for graphics (authored by sebastian-ne).
[AMDGPU] Do not annotate features for graphics
May 3 2021, 1:34 AM
sebastian-ne closed D101534: [AMDGPU] Do not annotate features for graphics.
May 3 2021, 1:34 AM · Restricted Project

Apr 30 2021

sebastian-ne updated the diff for D101367: [AMDGPU] Serialize MFInfo::ScavengeFI.

This is rougher than I would hope. This isn't a simple integer, it's a frame index. I would hope there would be some syntax to indicate this, and some validation that it is a valid frame object. There's no frame info here at all. e.g. I would expect a string here that looks like a frame index as it appears in an operand

Apr 30 2021, 12:34 PM · Restricted Project
sebastian-ne updated the diff for D101292: [AMDGPU] Restrict immediate scratch offsets.

I added a table and edited the feature descriptions. I hope this is more in line with what you expected.

Apr 30 2021, 11:00 AM · Restricted Project
sebastian-ne updated the diff for D101312: [Utils] Do not remove comments in llc test script.

I'm trying to understand the functionality you want to achieve. Doesn't using different prefixes avoid merging already? The test does not seem to exercise your extensions.

Apr 30 2021, 10:53 AM · Restricted Project
sebastian-ne updated the diff for D101534: [AMDGPU] Do not annotate features for graphics.

Good point, added comments to the test.

Apr 30 2021, 2:12 AM · Restricted Project

Apr 29 2021

sebastian-ne updated the diff for D101534: [AMDGPU] Do not annotate features for graphics.

Add comment

Apr 29 2021, 11:30 AM · Restricted Project
sebastian-ne added inline comments to D101534: [AMDGPU] Do not annotate features for graphics.
Apr 29 2021, 8:52 AM · Restricted Project
sebastian-ne requested review of D101534: [AMDGPU] Do not annotate features for graphics.
Apr 29 2021, 6:52 AM · Restricted Project
sebastian-ne committed rG9569d5ba0269: [AMDGPU] Allow buildSpillLoadStore in empty bb (authored by sebastian-ne).
[AMDGPU] Allow buildSpillLoadStore in empty bb
Apr 29 2021, 3:54 AM
sebastian-ne closed D101356: [AMDGPU] Allow buildSpillLoadStore in empty bb.
Apr 29 2021, 3:54 AM · Restricted Project

Apr 27 2021

sebastian-ne requested review of D101367: [AMDGPU] Serialize MFInfo::ScavengeFI.
Apr 27 2021, 7:43 AM · Restricted Project
sebastian-ne updated the diff for D101312: [Utils] Do not remove comments in llc test script.

Add test

Apr 27 2021, 6:14 AM · Restricted Project
sebastian-ne requested review of D101356: [AMDGPU] Allow buildSpillLoadStore in empty bb.
Apr 27 2021, 5:02 AM · Restricted Project

Apr 26 2021

sebastian-ne requested review of D101312: [Utils] Do not remove comments in llc test script.
Apr 26 2021, 11:03 AM · Restricted Project
sebastian-ne committed rG9579af2bd7f3: [AMDGPU] Fix autogenerated wwm-reserved-spill.ll (authored by sebastian-ne).
[AMDGPU] Fix autogenerated wwm-reserved-spill.ll
Apr 26 2021, 10:09 AM
sebastian-ne updated the diff for D101292: [AMDGPU] Restrict immediate scratch offsets.

Mention 4-alignment in the bug description.

Apr 26 2021, 8:52 AM · Restricted Project
sebastian-ne committed rGfcc40d9c17d9: [AMDGPU] Use MapVector for WWMReservedRegs (authored by sebastian-ne).
[AMDGPU] Use MapVector for WWMReservedRegs
Apr 26 2021, 8:43 AM
sebastian-ne closed D101299: [AMDGPU] Use MapVector for WWMReservedRegs.
Apr 26 2021, 8:43 AM · Restricted Project
sebastian-ne requested review of D101299: [AMDGPU] Use MapVector for WWMReservedRegs.
Apr 26 2021, 8:23 AM · Restricted Project
sebastian-ne added inline comments to D101292: [AMDGPU] Restrict immediate scratch offsets.
Apr 26 2021, 7:18 AM · Restricted Project
sebastian-ne added a comment to D101292: [AMDGPU] Restrict immediate scratch offsets.

Summary says:

"gfx10 works only with aligned negative offsets, but not with aligned negative offsets."

Presumably one of those should say "unaligned"?

Apr 26 2021, 6:52 AM · Restricted Project
sebastian-ne updated the summary of D101292: [AMDGPU] Restrict immediate scratch offsets.
Apr 26 2021, 6:52 AM · Restricted Project
sebastian-ne requested review of D101292: [AMDGPU] Restrict immediate scratch offsets.
Apr 26 2021, 6:42 AM · Restricted Project

Apr 23 2021

sebastian-ne added a comment to D99429: [AMDGPU] Save WWM registers in functions.

Thanks, resubmitted with -mtriple instead of -march.

Apr 23 2021, 9:17 AM · Restricted Project
sebastian-ne committed rG3366d8115366: [AMDGPU] Save WWM registers in functions (authored by sebastian-ne).
[AMDGPU] Save WWM registers in functions
Apr 23 2021, 9:16 AM
sebastian-ne added a reverting change for rG91464c30bfcf: [AMDGPU] Save WWM registers in functions: rG22d99cb63f96: Revert "[AMDGPU] Save WWM registers in functions".
Apr 23 2021, 7:39 AM
sebastian-ne committed rG22d99cb63f96: Revert "[AMDGPU] Save WWM registers in functions" (authored by sebastian-ne).
Revert "[AMDGPU] Save WWM registers in functions"
Apr 23 2021, 7:39 AM
sebastian-ne added a reverting change for D99429: [AMDGPU] Save WWM registers in functions: rG22d99cb63f96: Revert "[AMDGPU] Save WWM registers in functions".
Apr 23 2021, 7:39 AM · Restricted Project
sebastian-ne committed rG91464c30bfcf: [AMDGPU] Save WWM registers in functions (authored by sebastian-ne).
[AMDGPU] Save WWM registers in functions
Apr 23 2021, 7:10 AM
sebastian-ne closed D99429: [AMDGPU] Save WWM registers in functions.
Apr 23 2021, 7:10 AM · Restricted Project
sebastian-ne updated the diff for D99429: [AMDGPU] Save WWM registers in functions.

Friendly ping for review.
The previous comments are all fixed, the code should be quite obvious now.

Apr 23 2021, 5:02 AM · Restricted Project
sebastian-ne accepted D100960: [AMDGPU] Fix typo in implicit operand lists.
Apr 23 2021, 4:30 AM · Restricted Project

Apr 21 2021

sebastian-ne added a comment to D100960: [AMDGPU] Fix typo in implicit operand lists.

Wow, how did you find that? The test changes look good to me.

Apr 21 2021, 9:37 AM · Restricted Project

Apr 20 2021

sebastian-ne committed rG4897effb1415: [AMDGPU] Add TransVALU to gfx10 (authored by sebastian-ne).
[AMDGPU] Add TransVALU to gfx10
Apr 20 2021, 6:35 AM
sebastian-ne closed D100123: [AMDGPU] Add TransVALU to gfx10.
Apr 20 2021, 6:34 AM · Restricted Project
sebastian-ne added a comment to D100123: [AMDGPU] Add TransVALU to gfx10.

What about other models?

Apr 20 2021, 6:34 AM · Restricted Project

Apr 15 2021

sebastian-ne committed rG7842e1725e80: [AMDGPU] Fix large return values with amdgpu_gfx (authored by sebastian-ne).
[AMDGPU] Fix large return values with amdgpu_gfx
Apr 15 2021, 6:05 AM
sebastian-ne closed D100543: [AMDGPU] Fix large return values with amdgpu_gfx.
Apr 15 2021, 6:05 AM · Restricted Project
sebastian-ne requested review of D100543: [AMDGPU] Fix large return values with amdgpu_gfx.
Apr 15 2021, 3:56 AM · Restricted Project

Apr 14 2021

sebastian-ne committed rG929edd4375a4: [AMDGPU] Mark scavenged SGPR as used (authored by sebastian-ne).
[AMDGPU] Mark scavenged SGPR as used
Apr 14 2021, 5:55 AM
sebastian-ne closed D100461: [AMDGPU] Mark scavenged SGPR as used.
Apr 14 2021, 5:55 AM · Restricted Project
sebastian-ne accepted D100406: [AMDGPU] Factor out SelectSAddrFI().
Apr 14 2021, 3:58 AM · Restricted Project
sebastian-ne requested review of D100461: [AMDGPU] Mark scavenged SGPR as used.
Apr 14 2021, 3:36 AM · Restricted Project

Apr 13 2021

sebastian-ne updated the diff for D99429: [AMDGPU] Save WWM registers in functions.

Rebased again

Apr 13 2021, 7:28 AM · Restricted Project

Apr 12 2021

sebastian-ne committed rG6cc91adf1e61: [AMDGPU] Kill temporary register after restoring (authored by sebastian-ne).
[AMDGPU] Kill temporary register after restoring
Apr 12 2021, 5:22 AM
sebastian-ne closed D100295: [AMDGPU] Kill temporary register after restoring.
Apr 12 2021, 5:22 AM · Restricted Project
sebastian-ne requested review of D100295: [AMDGPU] Kill temporary register after restoring.
Apr 12 2021, 3:35 AM · Restricted Project
sebastian-ne committed rG7a8e65dd3dfa: [AMDGPU] Fix ubsan error (authored by sebastian-ne).
[AMDGPU] Fix ubsan error
Apr 12 2021, 3:15 AM
sebastian-ne committed rGb76c2a6c2b97: [AMDGPU] Fix saving fp and bp (authored by sebastian-ne).
[AMDGPU] Fix saving fp and bp
Apr 12 2021, 2:54 AM
sebastian-ne committed rGca3bae94c469: [AMDGPU] Autogenerate test. NFC (authored by sebastian-ne).
[AMDGPU] Autogenerate test. NFC
Apr 12 2021, 2:54 AM
sebastian-ne closed D96869: [AMDGPU] Fix saving fp and bp.
Apr 12 2021, 2:54 AM · Restricted Project
sebastian-ne committed rG32bc9a9bc314: [AMDGPU] Unify spill code (authored by sebastian-ne).
[AMDGPU] Unify spill code
Apr 12 2021, 2:24 AM
sebastian-ne closed D99269: [AMDGPU] Unify spill code.
Apr 12 2021, 2:24 AM · Restricted Project
sebastian-ne committed rGf9a8c6a0e505: [AMDGPU] Save VGPR of whole wave when spilling (authored by sebastian-ne).
[AMDGPU] Save VGPR of whole wave when spilling
Apr 12 2021, 2:12 AM
sebastian-ne closed D96336: [AMDGPU] Save VGPR of whole wave when spilling.
Apr 12 2021, 2:12 AM · Restricted Project

Apr 9 2021

sebastian-ne committed rGcc7add52986b: [AMDGPU] Use SIInstrFlags for flat variants. NFC (authored by sebastian-ne).
[AMDGPU] Use SIInstrFlags for flat variants. NFC
Apr 9 2021, 3:35 AM
sebastian-ne closed D99743: [AMDGPU] Use enum for flat variants. NFC.
Apr 9 2021, 3:34 AM · Restricted Project
sebastian-ne added inline comments to D99743: [AMDGPU] Use enum for flat variants. NFC.
Apr 9 2021, 2:49 AM · Restricted Project
sebastian-ne added inline comments to D99269: [AMDGPU] Unify spill code.
Apr 9 2021, 2:45 AM · Restricted Project
sebastian-ne updated the diff for D99269: [AMDGPU] Unify spill code.

Add assert to buildSpillLoadStore.

Apr 9 2021, 2:45 AM · Restricted Project
sebastian-ne updated the diff for D99743: [AMDGPU] Use enum for flat variants. NFC.

Rebased to drop Is from bit names and removed now unneeed include.

Apr 9 2021, 2:32 AM · Restricted Project
sebastian-ne committed rGba217b465532: [RegisterScavenging] Add asserts for better errors (authored by sebastian-ne).
[RegisterScavenging] Add asserts for better errors
Apr 9 2021, 2:26 AM
sebastian-ne closed D100109: [RegisterScavenging] Add asserts for better errors.
Apr 9 2021, 2:26 AM · Restricted Project
sebastian-ne committed rG36138db116a8: [AMDGPU] IsFlatScratch/Global -> FlatScratch/Global (authored by sebastian-ne).
[AMDGPU] IsFlatScratch/Global -> FlatScratch/Global
Apr 9 2021, 2:22 AM
sebastian-ne closed D100108: [AMDGPU] IsFlatScratch/Global -> FlatScratch/Global.
Apr 9 2021, 2:22 AM · Restricted Project