- User Since
- Jan 27 2020, 1:17 AM (73 w, 20 h)
I now added two helper function in CombinerHelper,
getRegBankId returns an Optional<unsigned> for a register and
setRegBankId sets such an optional bank to a register (or does nothing it it’s None).
Mon, Jun 7
Fri, Jun 4
Fix most inline review comments
Fri, May 28
This allows to convert the add instruction to s_addk_i32
Nice. (But perhaps we should be able to convert s_add_u32 -> s_addk_i32 if scc is dead?)
Thu, May 27
Wed, May 26
May 11 2021
May 10 2021
May 7 2021
I guess it is fine for MIR tests because they only use CHECK lines instead of CHECK-NEXT lines.
Friendly ping for review
friendly ping for review
May 6 2021
Return error instead of failing assert for non-existing frame index.
May 4 2021
The added test llvm/test/Transforms/OpenMP/single_threaded_execution.ll fails in release builds when assertions are disabled.
You probably need to add ; REQUIRES: asserts like it is done in llvm/test/CodeGen/Mips/brind-tailcall.ll.
May 3 2021
Add two tests to check invalid frame indices.
Apr 30 2021
This is rougher than I would hope. This isn't a simple integer, it's a frame index. I would hope there would be some syntax to indicate this, and some validation that it is a valid frame object. There's no frame info here at all. e.g. I would expect a string here that looks like a frame index as it appears in an operand
I added a table and edited the feature descriptions. I hope this is more in line with what you expected.
Good point, added comments to the test.
Apr 29 2021
Apr 27 2021
Apr 26 2021
Mention 4-alignment in the bug description.
Apr 23 2021
Thanks, resubmitted with -mtriple instead of -march.
Friendly ping for review.
The previous comments are all fixed, the code should be quite obvious now.
Apr 21 2021
Wow, how did you find that? The test changes look good to me.
Apr 20 2021
What about other models?
Apr 15 2021
Apr 14 2021
Apr 13 2021
Apr 12 2021
Apr 9 2021
Add assert to buildSpillLoadStore.
Rebased to drop Is from bit names and removed now unneeed include.