Page MenuHomePhabricator

sebastian-ne (Sebastian Neubauer)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 27 2020, 1:17 AM (50 w, 5 d)

Recent Activity

Yesterday

sebastian-ne requested review of D94768: [AMDGPU] Implement mir parseCustomPseudoSourceValue.
Fri, Jan 15, 5:14 AM · Restricted Project

Tue, Jan 12

sebastian-ne committed rG6a195491b602: [AMDGPU] Fix failing assert with scratch ST mode (authored by sebastian-ne).
[AMDGPU] Fix failing assert with scratch ST mode
Tue, Jan 12, 12:54 AM
sebastian-ne closed D94406: [AMDGPU] Fix failing assert with scratch ST mode.
Tue, Jan 12, 12:54 AM · Restricted Project

Mon, Jan 11

sebastian-ne updated the diff for D94406: [AMDGPU] Fix failing assert with scratch ST mode.

Add test case for clausing two flat scratch instructions with constant adresses.

Mon, Jan 11, 6:47 AM · Restricted Project
sebastian-ne updated the diff for D94406: [AMDGPU] Fix failing assert with scratch ST mode.

Your formulation is definitely better.

Mon, Jan 11, 6:31 AM · Restricted Project
sebastian-ne updated the diff for D94406: [AMDGPU] Fix failing assert with scratch ST mode.

I think the intention was that getMemOperandsWithOffsetWidth should return false if no base operands were found (perhaps MachineScheduler could assert this?)

Mon, Jan 11, 6:13 AM · Restricted Project
sebastian-ne requested review of D94406: [AMDGPU] Fix failing assert with scratch ST mode.
Mon, Jan 11, 5:30 AM · Restricted Project

Wed, Dec 23

sebastian-ne committed rG221fdedc6926: [AMDGPU][GlobalISel] Fold flat vgpr + constant addresses (authored by sebastian-ne).
[AMDGPU][GlobalISel] Fold flat vgpr + constant addresses
Wed, Dec 23, 2:05 AM
sebastian-ne closed D93692: [AMDGPU][GlobalISel] Fold flat vgpr + constant addresses.
Wed, Dec 23, 2:05 AM · Restricted Project

Tue, Dec 22

sebastian-ne requested review of D93692: [AMDGPU][GlobalISel] Fold flat vgpr + constant addresses.
Tue, Dec 22, 5:35 AM · Restricted Project
sebastian-ne accepted D93670: [AMDGPU][GlobalISel] GlobalISel for flat scratch.

Looks good to me

Tue, Dec 22, 4:59 AM · Restricted Project
sebastian-ne accepted D93501: [AMDGPU] Folding of FI operand with flat scratch.
Tue, Dec 22, 3:53 AM · Restricted Project

Dec 16 2020

sebastian-ne committed rG409a2f0f9e48: [AMDGPU] Allow no saddr for global addtid insts (authored by sebastian-ne).
[AMDGPU] Allow no saddr for global addtid insts
Dec 16 2020, 1:02 AM
sebastian-ne closed D93288: [AMDGPU] Allow no saddr for global addtid insts.
Dec 16 2020, 1:02 AM · Restricted Project

Dec 15 2020

sebastian-ne committed rG91445979be0a: [AMDGPU] Unify flat offset logic (authored by sebastian-ne).
[AMDGPU] Unify flat offset logic
Dec 15 2020, 6:04 AM
sebastian-ne closed D93287: [AMDGPU] Unify flat offset logic.
Dec 15 2020, 6:04 AM · Restricted Project
sebastian-ne committed rG7898803c6384: [AMDGPU][NFC] Add more global_atomic_cmpswap tests (authored by sebastian-ne).
[AMDGPU][NFC] Add more global_atomic_cmpswap tests
Dec 15 2020, 5:54 AM
sebastian-ne requested review of D93288: [AMDGPU] Allow no saddr for global addtid insts.
Dec 15 2020, 2:20 AM · Restricted Project
sebastian-ne requested review of D93287: [AMDGPU] Unify flat offset logic.
Dec 15 2020, 1:54 AM · Restricted Project

Dec 14 2020

sebastian-ne committed rG5733167f54a5: [AMDGPU] Mark amdgpu_gfx functions as module entry function (authored by sebastian-ne).
[AMDGPU] Mark amdgpu_gfx functions as module entry function
Dec 14 2020, 1:44 AM
sebastian-ne closed D92946: [AMDGPU] Mark amdgpu_gfx functions as module entry function.
Dec 14 2020, 1:44 AM · Restricted Project

Dec 11 2020

sebastian-ne added inline comments to D93067: [AMDGPU] Use multi-dword flat scratch for spilling.
Dec 11 2020, 1:53 AM · Restricted Project
sebastian-ne updated the diff for D92946: [AMDGPU] Mark amdgpu_gfx functions as module entry function.

Change comments to differentiate between calls from hardware and calls from other functions.
I hope this is more clear than “driver”.

Dec 11 2020, 1:22 AM · Restricted Project

Dec 10 2020

sebastian-ne updated the diff for D92946: [AMDGPU] Mark amdgpu_gfx functions as module entry function.

Makes sense, thanks

Dec 10 2020, 3:51 AM · Restricted Project

Dec 9 2020

sebastian-ne requested review of D92946: [AMDGPU] Mark amdgpu_gfx functions as module entry function.
Dec 9 2020, 9:30 AM · Restricted Project

Nov 25 2020

sebastian-ne committed rGedd675643d5f: [AMDGPU] Emit stack frame size in metadata (authored by sebastian-ne).
[AMDGPU] Emit stack frame size in metadata
Nov 25 2020, 7:49 AM
sebastian-ne closed D90036: [AMDGPU] Emit stack frame size in metadata.
Nov 25 2020, 7:48 AM · Restricted Project
sebastian-ne added a comment to D90036: [AMDGPU] Emit stack frame size in metadata.

ping

Nov 25 2020, 1:51 AM · Restricted Project

Nov 20 2020

sebastian-ne committed rG7a18bdb350e4: [AMDGPU] Implement flat scratch init for pal (authored by sebastian-ne).
[AMDGPU] Implement flat scratch init for pal
Nov 20 2020, 2:15 AM
sebastian-ne closed D91701: [AMDGPU] Implement flat scratch init for pal.
Nov 20 2020, 2:14 AM · Restricted Project

Nov 19 2020

sebastian-ne added inline comments to D91701: [AMDGPU] Implement flat scratch init for pal.
Nov 19 2020, 10:17 AM · Restricted Project
sebastian-ne updated the diff for D91701: [AMDGPU] Implement flat scratch init for pal.

Reformat BuildMI

Nov 19 2020, 9:08 AM · Restricted Project
sebastian-ne added inline comments to D91701: [AMDGPU] Implement flat scratch init for pal.
Nov 19 2020, 4:40 AM · Restricted Project

Nov 18 2020

sebastian-ne updated the diff for D90036: [AMDGPU] Emit stack frame size in metadata.

Thank you for the reviews.
Emit metadata for all functions, not only amdgpu_gfx.

Nov 18 2020, 9:31 AM · Restricted Project
sebastian-ne committed rG72ccec1bbc98: [AMDGPU] Fix v3f16 interaction with image store workaround (authored by sebastian-ne).
[AMDGPU] Fix v3f16 interaction with image store workaround
Nov 18 2020, 9:21 AM
sebastian-ne closed D90847: [AMDGPU] Fix v3f16 interaction with image store workaround.
Nov 18 2020, 9:21 AM · Restricted Project
sebastian-ne added a comment to D90036: [AMDGPU] Emit stack frame size in metadata.

Friendly ping for review

Nov 18 2020, 8:33 AM · Restricted Project
sebastian-ne added a comment to D90847: [AMDGPU] Fix v3f16 interaction with image store workaround.

Friendly ping for review

Nov 18 2020, 8:32 AM · Restricted Project
sebastian-ne updated the diff for D91701: [AMDGPU] Implement flat scratch init for pal.

Remove superfluous implicit defs.

Nov 18 2020, 7:39 AM · Restricted Project
sebastian-ne requested review of D91701: [AMDGPU] Implement flat scratch init for pal.
Nov 18 2020, 5:32 AM · Restricted Project

Nov 11 2020

sebastian-ne accepted D91110: [AMDGPU] Remove scratch rsrc from spill pseudos.

Thanks, LGTM from my side. Looks quite clean and passed short Vulkan CTS testing.

Nov 11 2020, 9:33 AM · Restricted Project

Nov 10 2020

sebastian-ne added inline comments to D90847: [AMDGPU] Fix v3f16 interaction with image store workaround.
Nov 10 2020, 9:04 AM · Restricted Project
sebastian-ne retitled D90847: [AMDGPU] Fix v3f16 interaction with image store workaround from [AMDGPU] Enable more v3f16 tests, NFC to [AMDGPU] Fix v3f16 interaction with image store workaround.
Nov 10 2020, 8:58 AM · Restricted Project
sebastian-ne updated the diff for D90847: [AMDGPU] Fix v3f16 interaction with image store workaround.

Fix wrong register counts.

Nov 10 2020, 8:57 AM · Restricted Project
sebastian-ne updated the diff for D90036: [AMDGPU] Emit stack frame size in metadata.

Rebase and add test with multiple allocations.

Nov 10 2020, 5:17 AM · Restricted Project

Nov 9 2020

sebastian-ne committed rGa022b1ccd8d8: [AMDGPU] Add amdgpu_gfx calling convention (authored by sebastian-ne).
[AMDGPU] Add amdgpu_gfx calling convention
Nov 9 2020, 7:52 AM
sebastian-ne closed D88540: [AMDGPU] Add amdgpu_gfx calling convention.
Nov 9 2020, 7:52 AM · Restricted Project

Nov 5 2020

sebastian-ne requested review of D90847: [AMDGPU] Fix v3f16 interaction with image store workaround.
Nov 5 2020, 6:12 AM · Restricted Project
sebastian-ne updated the diff for D88540: [AMDGPU] Add amdgpu_gfx calling convention.

Fixed a bug for GlobalISel and add tests.
Thanks for pushing for tests Matt.

Nov 5 2020, 3:52 AM · Restricted Project

Nov 4 2020

sebastian-ne committed rG31a0b2834f88: [AMDGPU] Fix iterating in SIFixSGPRCopies (authored by sebastian-ne).
[AMDGPU] Fix iterating in SIFixSGPRCopies
Nov 4 2020, 9:43 AM
sebastian-ne closed D90596: [AMDGPU] Fix iterating in SIFixSGPRCopies.
Nov 4 2020, 9:43 AM · Restricted Project
sebastian-ne added inline comments to D90596: [AMDGPU] Fix iterating in SIFixSGPRCopies.
Nov 4 2020, 9:36 AM · Restricted Project
sebastian-ne committed rG1124bf4ab777: [AMDGPU] Set rsrc1 flags for graphics shaders (authored by sebastian-ne).
[AMDGPU] Set rsrc1 flags for graphics shaders
Nov 4 2020, 3:27 AM
sebastian-ne committed rG76313288cd7d: [AMDGPU] Fix ieee mode default value (authored by sebastian-ne).
[AMDGPU] Fix ieee mode default value
Nov 4 2020, 3:27 AM
sebastian-ne closed D89399: [AMDGPU] Set rsrc1 flags for graphics shaders.
Nov 4 2020, 3:27 AM · Restricted Project
sebastian-ne closed D89388: [AMDGPU] Fix ieee mode default value.
Nov 4 2020, 3:27 AM · Restricted Project
sebastian-ne updated the diff for D90596: [AMDGPU] Fix iterating in SIFixSGPRCopies.

Return new basic block from SIInstrInfo functions.

Nov 4 2020, 2:11 AM · Restricted Project
sebastian-ne added inline comments to D88540: [AMDGPU] Add amdgpu_gfx calling convention.
Nov 4 2020, 1:05 AM · Restricted Project

Nov 3 2020

sebastian-ne updated the diff for D89399: [AMDGPU] Set rsrc1 flags for graphics shaders.

Switch from if to switch.

Nov 3 2020, 5:35 AM · Restricted Project
sebastian-ne added inline comments to D90596: [AMDGPU] Fix iterating in SIFixSGPRCopies.
Nov 3 2020, 5:13 AM · Restricted Project

Nov 2 2020

sebastian-ne requested review of D90596: [AMDGPU] Fix iterating in SIFixSGPRCopies.
Nov 2 2020, 4:56 AM · Restricted Project

Oct 28 2020

sebastian-ne committed rG09c73456837a: [AMDGPU] Precommit tests for D89388 and D89399, NFC (authored by sebastian-ne).
[AMDGPU] Precommit tests for D89388 and D89399, NFC
Oct 28 2020, 8:59 AM

Oct 27 2020

sebastian-ne committed rG673f2f702b03: msgpack: Improve error for empty node (authored by sebastian-ne).
msgpack: Improve error for empty node
Oct 27 2020, 5:06 AM

Oct 26 2020

sebastian-ne committed rGa094b4fa4b7f: [AMDGPU] Emit new pal metadata by default (authored by sebastian-ne).
[AMDGPU] Emit new pal metadata by default
Oct 26 2020, 2:16 AM
sebastian-ne closed D90035: [AMDGPU] Emit new pal metadata by default.
Oct 26 2020, 2:16 AM · Restricted Project

Oct 21 2020

sebastian-ne committed rG5290f50e44b6: [AMDGPU] Fix off by one in assert (authored by sebastian-ne).
[AMDGPU] Fix off by one in assert
Oct 21 2020, 3:46 AM
sebastian-ne closed D89804: [AMDGPU] Fix off by one in assert.
Oct 21 2020, 3:46 AM · Restricted Project

Oct 16 2020

sebastian-ne committed rGdd3f7a494af9: [AMDGPU] Add a message to an assert (authored by sebastian-ne).
[AMDGPU] Add a message to an assert
Oct 16 2020, 4:03 AM

Oct 15 2020

sebastian-ne committed rG0ff4bc38ab08: [AMDGPU] Add objdump invalid metadata testcase (authored by sebastian-ne).
[AMDGPU] Add objdump invalid metadata testcase
Oct 15 2020, 2:17 AM
sebastian-ne closed D89375: [AMDGPU] Add objdump invalid metadata testcase.
Oct 15 2020, 2:17 AM · Restricted Project

Oct 12 2020

sebastian-ne committed rGc2216d796aab: [AMDGPU] Print metadata on error (authored by sebastian-ne).
[AMDGPU] Print metadata on error
Oct 12 2020, 8:22 AM
sebastian-ne closed D89243: [AMDGPU] Print metadata on error.
Oct 12 2020, 8:22 AM · Restricted Project
sebastian-ne committed rG7f2a641aad28: [AMDGPU] Insert waterfall loops for divergent calls (authored by sebastian-ne).
[AMDGPU] Insert waterfall loops for divergent calls
Oct 12 2020, 8:17 AM
sebastian-ne closed D88291: [AMDGPU] Insert waterfall loops for divergent calls.
Oct 12 2020, 8:16 AM · Restricted Project

Oct 8 2020

sebastian-ne committed rGf53b43c00a07: [AMDGPU] Use isLegalMUBUFImmOffset more (authored by sebastian-ne).
[AMDGPU] Use isLegalMUBUFImmOffset more
Oct 8 2020, 5:32 AM
sebastian-ne closed D88961: [AMDGPU] Use isLegalMUBUFImmOffset more.
Oct 8 2020, 5:32 AM · Restricted Project

Oct 6 2020

sebastian-ne committed rGb4264210f2b2: [AMDGPU] Remove SIInstrInfo::calculateLDSSpillAddress (authored by sebastian-ne).
[AMDGPU] Remove SIInstrInfo::calculateLDSSpillAddress
Oct 6 2020, 9:45 AM
sebastian-ne closed D88904: [AMDGPU] Remove SIInstrInfo::calculateLDSSpillAddress.
Oct 6 2020, 9:45 AM · Restricted Project
sebastian-ne committed rG9fc535f987b4: [AMDGPU] Fix gcc warnings (authored by sebastian-ne).
[AMDGPU] Fix gcc warnings
Oct 6 2020, 2:01 AM
sebastian-ne closed D88876: [AMDGPU] Fix gcc warnings.
Oct 6 2020, 2:01 AM · Restricted Project

Oct 5 2020

sebastian-ne committed rG6a089ce0e40a: [AMDGPU] Use tablegen for argument indices (authored by sebastian-ne).
[AMDGPU] Use tablegen for argument indices
Oct 5 2020, 3:03 AM
sebastian-ne closed D86270: [AMDGPU] Use tablegen for argument indices.
Oct 5 2020, 3:02 AM · Restricted Project

Sep 24 2020

sebastian-ne committed rG6f7cd16d2971: [AMDGPU] Fix v3f16 handling for getresinfo (authored by sebastian-ne).
[AMDGPU] Fix v3f16 handling for getresinfo
Sep 24 2020, 7:15 AM
sebastian-ne closed D88206: [AMDGPU] Fix v3f16 handling for getresinfo.
Sep 24 2020, 7:15 AM · Restricted Project

Sep 23 2020

sebastian-ne added a reverting change for rGca907bfb57d8: [AMDGPU] Insert waitcnt after returning from call: rGa343b9b03277: Revert "[AMDGPU] Insert waitcnt after returning from call".
Sep 23 2020, 8:18 AM
sebastian-ne committed rGa343b9b03277: Revert "[AMDGPU] Insert waitcnt after returning from call" (authored by sebastian-ne).
Revert "[AMDGPU] Insert waitcnt after returning from call"
Sep 23 2020, 8:18 AM
sebastian-ne added a reverting change for D87674: [AMDGPU] Insert waitcnt after returning from call: rGa343b9b03277: Revert "[AMDGPU] Insert waitcnt after returning from call".
Sep 23 2020, 8:18 AM · Restricted Project
sebastian-ne committed rGca907bfb57d8: [AMDGPU] Insert waitcnt after returning from call (authored by sebastian-ne).
[AMDGPU] Insert waitcnt after returning from call
Sep 23 2020, 3:19 AM
sebastian-ne closed D87674: [AMDGPU] Insert waitcnt after returning from call.
Sep 23 2020, 3:18 AM · Restricted Project

Sep 16 2020

sebastian-ne committed rG833b3b0d3a2f: [AMDGPU] Add v3f16/v3i16 support to SDag (authored by sebastian-ne).
[AMDGPU] Add v3f16/v3i16 support to SDag
Sep 16 2020, 8:21 AM
sebastian-ne closed D84420: [AMDGPU] Add v3f16/v3i16 support to SDag.
Sep 16 2020, 8:20 AM · Restricted Project

Sep 11 2020

sebastian-ne committed rGf2bb4b88550a: [docs] Fix typos (authored by YangZhihui).
[docs] Fix typos
Sep 11 2020, 8:58 AM
sebastian-ne closed D87356: [docs] Fix typos.
Sep 11 2020, 8:58 AM · Restricted Project

Aug 20 2020

sebastian-ne committed rGb8d199477820: [AMDGPU] Add A16/G16 to InstCombine (authored by sebastian-ne).
[AMDGPU] Add A16/G16 to InstCombine
Aug 20 2020, 1:52 AM
sebastian-ne closed D85887: [AMDGPU] Add A16/G16 to InstCombine.
Aug 20 2020, 1:52 AM · Restricted Project

Aug 17 2020

sebastian-ne accepted D85845: AMDGPU/GlobalISel: Fix using readfirstlane with ballot intrinsics.

This looks better than what was there before, thanks.

Aug 17 2020, 6:24 AM · Restricted Project

Aug 14 2020

sebastian-ne committed rG9aa0ff77bdc7: [AMDGPU] Enable .rodata for amdpal os (authored by sebastian-ne).
[AMDGPU] Enable .rodata for amdpal os
Aug 14 2020, 12:06 AM
sebastian-ne closed D85895: [AMDGPU] Enable .rodata for amdpal os.
Aug 14 2020, 12:06 AM · Restricted Project

Aug 13 2020

sebastian-ne committed rGca227d73e10a: [AMDGPU] Fix typo. NFC (authored by sebastian-ne).
[AMDGPU] Fix typo. NFC
Aug 13 2020, 1:42 AM

Jul 23 2020

sebastian-ne committed rG896679733d74: [AMDGPU] Fix typo. NFC (authored by sebastian-ne).
[AMDGPU] Fix typo. NFC
Jul 23 2020, 8:01 AM