Page MenuHomePhabricator

sylvestre.ledru (Sylvestre Ledru)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2013, 1:12 AM (358 w, 1 d)

Recent Activity

Tue, Jan 14

sylvestre.ledru added a comment to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

I run the new check on LibreOffice codebase with the option CharTypdefsToIgnore = "sal_Int8".
The check produced 32 findings.

Tue, Jan 14, 12:55 AM · Restricted Project, Restricted Project

Fri, Jan 10

sylvestre.ledru committed rG68cd283f3b07: clang-tidy doc: unbreak the CI (authored by sylvestre.ledru).
clang-tidy doc: unbreak the CI
Fri, Jan 10, 1:29 PM
sylvestre.ledru committed rGfaeeb71a1734: clang-tidy doc: Refresh the list of checkers and polish the script (authored by sylvestre.ledru).
clang-tidy doc: Refresh the list of checkers and polish the script
Fri, Jan 10, 1:11 PM
sylvestre.ledru committed rGf3db1aad2796: MakeUniqueCheck.cpp: explicit the fact that there is an autofix for this checker (authored by sylvestre.ledru).
MakeUniqueCheck.cpp: explicit the fact that there is an autofix for this checker
Fri, Jan 10, 1:11 PM
sylvestre.ledru added a comment to D68720: Support -fstack-clash-protection for x86.

@craig.topper do you think there is a chance that this change could be part of clang-10 ?
Thanks

Fri, Jan 10, 8:30 AM · Restricted Project, Restricted Project

Thu, Jan 9

sylvestre.ledru committed rGb38d0d5bdb35: clang-tidy doc - remove the widths (authored by sylvestre.ledru).
clang-tidy doc - remove the widths
Thu, Jan 9, 11:13 PM
sylvestre.ledru committed rG0c195ef7c62d: phab doc: Replace or remove references to svn (authored by sylvestre.ledru).
phab doc: Replace or remove references to svn
Thu, Jan 9, 1:32 PM
sylvestre.ledru committed rGdbfc516d1f16: phab doc: also document 'arc land' (authored by sylvestre.ledru).
phab doc: also document 'arc land'
Thu, Jan 9, 1:23 PM
sylvestre.ledru committed rG004ae200a5a8: phab doc: remove the svn section (authored by sylvestre.ledru).
phab doc: remove the svn section
Thu, Jan 9, 1:23 PM
sylvestre.ledru committed rGc348a2674b57: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix (authored by sylvestre.ledru).
[clang-tidy] Refresh the add_new_check.py now that we use a table + autofix
Thu, Jan 9, 1:13 PM
sylvestre.ledru closed D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.
Thu, Jan 9, 1:13 PM · Restricted Project, Restricted Project
sylvestre.ledru added inline comments to D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.
Thu, Jan 9, 1:13 PM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D71082: Allow system header to provide their own implementation of some builtin.

@serge-sans-paille any blocker for this to land? Would be great to have it in version 10. Thanks

Thu, Jan 9, 6:37 AM · Restricted Project
sylvestre.ledru added a comment to D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.

Thanks for this, Also how would you feel about adding a parameter to the script that could create alias definitions in much the same way?

Thu, Jan 9, 1:40 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.

It finds some stuff that I missed in the list :)

Thu, Jan 9, 1:40 AM · Restricted Project, Restricted Project

Wed, Jan 8

sylvestre.ledru updated the diff for D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.

Fix some rst warnings

Wed, Jan 8, 3:37 PM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.

arf, arc..

Wed, Jan 8, 3:28 PM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.

remove artifcats

Wed, Jan 8, 3:28 PM · Restricted Project, Restricted Project
sylvestre.ledru created D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.
Wed, Jan 8, 3:28 PM · Restricted Project, Restricted Project

Sun, Jan 5

sylvestre.ledru added a comment to D72217: [clang-tidy] Added readability-qualified-auto check.

side note when creating this, the add_new_check.py file hasn't been updated in relation to this commit https://github.com/llvm/llvm-project/commit/d2c9c9157b0528436d3b9f5e22c872f0ee6509a2. This results in a malformed rst file. In this patch I have just manually set it up correctly, but a fix will need to be made for the add_new_check.py

Sun, Jan 5, 10:03 AM · Restricted Project, Restricted Project

Wed, Jan 1

sylvestre.ledru committed rG773667b8c20d: clang-tidy doc: Remove severities as they don't make consensus (authored by sylvestre.ledru).
clang-tidy doc: Remove severities as they don't make consensus
Wed, Jan 1, 6:43 AM
sylvestre.ledru closed D72049: clang-tidy doc: Remove severities as they don't make consensus.
Wed, Jan 1, 6:43 AM · Restricted Project
sylvestre.ledru added a reviewer for D72049: clang-tidy doc: Remove severities as they don't make consensus: aaron.ballman.
Wed, Jan 1, 4:03 AM · Restricted Project
sylvestre.ledru added a comment to D71963: clang-tidy doc: Add the severities description.

@aaron.ballman done in https://reviews.llvm.org/D72049

Wed, Jan 1, 4:03 AM · Restricted Project
sylvestre.ledru created D72049: clang-tidy doc: Remove severities as they don't make consensus.
Wed, Jan 1, 4:03 AM · Restricted Project

Tue, Dec 31

sylvestre.ledru abandoned D71963: clang-tidy doc: Add the severities description.

ok, thanks!
I will remove them tomorrow or the next day.

Tue, Dec 31, 11:29 AM · Restricted Project
sylvestre.ledru added a comment to D71963: clang-tidy doc: Add the severities description.

OK, do you want me to prepare a patch to remove the severities?
or to update the values using another list?

Tue, Dec 31, 10:30 AM · Restricted Project
sylvestre.ledru added a comment to D71963: clang-tidy doc: Add the severities description.

I may have missed this in prior discussions, and if so, I'm sorry -- but why are we taking CodeChecker as the model for this?

Tue, Dec 31, 9:21 AM · Restricted Project
sylvestre.ledru committed rGe8c9110b56b5: clang-tidy doc: modernize-make-unique has an autofix (authored by sylvestre.ledru).
clang-tidy doc: modernize-make-unique has an autofix
Tue, Dec 31, 3:00 AM
sylvestre.ledru added a comment to D36051: Move from a long list of checkers to tables.

Thanks. Fixed in https://github.com/llvm/llvm-project/commit/e8c9110b56b516a22b41e95e347bc141814ab87c

Tue, Dec 31, 3:00 AM · Restricted Project
sylvestre.ledru added a comment to D36051: Move from a long list of checkers to tables.

@malcolm.parsons really? Oh, where is it implemented?
https://github.com/llvm/llvm-project/blob/61504079515f76ca094bb836c4d53b41064220d6/clang-tools-extra/clang-tidy/modernize/MakeUniqueCheck.cpp
I didn't see it here

Tue, Dec 31, 1:58 AM · Restricted Project

Mon, Dec 30

sylvestre.ledru requested changes to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

[Gnu toolchain]
maybe this can be removed in the title?

Mon, Dec 30, 2:52 PM · Restricted Project

Sun, Dec 29

sylvestre.ledru added a comment to D71963: clang-tidy doc: Add the severities description.

I do agree that they are subjective and not perfect.

Sun, Dec 29, 3:25 AM · Restricted Project

Sat, Dec 28

sylvestre.ledru added inline comments to D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check.
Sat, Dec 28, 9:39 AM · Restricted Project
sylvestre.ledru added inline comments to D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check.
Sat, Dec 28, 9:39 AM · Restricted Project
sylvestre.ledru created D71963: clang-tidy doc: Add the severities description.
Sat, Dec 28, 9:34 AM · Restricted Project
sylvestre.ledru added inline comments to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.
Sat, Dec 28, 1:29 AM · Restricted Project, Restricted Project

Thu, Dec 26

sylvestre.ledru added inline comments to D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check.
Thu, Dec 26, 2:24 PM · Restricted Project

Wed, Dec 25

sylvestre.ledru added inline comments to D70876: [clang-tidy] Add spuriously-wake-up-functions check.
Wed, Dec 25, 2:56 AM · Restricted Project, Restricted Project

Tue, Dec 24

sylvestre.ledru committed rG2026d7b80a1a: VariableName doc: fix the link to the mozilla doc (authored by sylvestre.ledru).
VariableName doc: fix the link to the mozilla doc
Tue, Dec 24, 4:42 AM
GitHub <noreply@github.com> committed rG95b69a7082ab: mlir README.md: Fix the syntax (authored by sylvestre.ledru).
mlir README.md: Fix the syntax
Tue, Dec 24, 4:33 AM
sylvestre.ledru committed rG8131c0483682: doc: Document that extra-arg/extra-arg-before can be used several times (authored by sylvestre.ledru).
doc: Document that extra-arg/extra-arg-before can be used several times
Tue, Dec 24, 4:15 AM
sylvestre.ledru committed rGc96c606b85c6: clang-doc remove trailing whitespaces (authored by sylvestre.ledru).
clang-doc remove trailing whitespaces
Tue, Dec 24, 4:15 AM

Mon, Dec 23

sylvestre.ledru added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

Is this failure expected?
https://bugs.llvm.org/show_bug.cgi?id=44370

Mon, Dec 23, 3:00 PM · Restricted Project, Restricted Project
sylvestre.ledru committed rGd2c9c9157b05: Move from a long list of checkers to tables (authored by sylvestre.ledru).
Move from a long list of checkers to tables
Mon, Dec 23, 9:45 AM
sylvestre.ledru closed D36051: Move from a long list of checkers to tables.
Mon, Dec 23, 9:45 AM · Restricted Project

Sat, Dec 21

sylvestre.ledru committed rG7ece0ee3dd7c: features.html: Remove some old info (authored by sylvestre.ledru).
features.html: Remove some old info
Sat, Dec 21, 1:56 AM
sylvestre.ledru committed rGa0ce6155734e: clang is now under the apache2 license (authored by sylvestre.ledru).
clang is now under the apache2 license
Sat, Dec 21, 1:56 AM
sylvestre.ledru committed rG384a287a9999: Remove a gcc 4.9 comparison as it doesn't make sense (authored by sylvestre.ledru).
Remove a gcc 4.9 comparison as it doesn't make sense
Sat, Dec 21, 1:56 AM

Fri, Dec 20

sylvestre.ledru updated the summary of D36051: Move from a long list of checkers to tables.
Fri, Dec 20, 3:38 PM · Restricted Project
sylvestre.ledru retitled D36051: Move from a long list of checkers to tables from [clang-tidy] List the checkers with autofix to Move from a long list of checkers to tables.
Fri, Dec 20, 3:38 PM · Restricted Project
sylvestre.ledru added a reviewer for D36051: Move from a long list of checkers to tables: Eugene.Zelenko.
Fri, Dec 20, 1:37 PM · Restricted Project
sylvestre.ledru updated the diff for D36051: Move from a long list of checkers to tables.

alias => aliases

Fri, Dec 20, 1:37 PM · Restricted Project
sylvestre.ledru updated the diff for D36051: Move from a long list of checkers to tables.

Fix a rst warning + update the clang link "Clang Static Analyzer"

Fri, Dec 20, 9:49 AM · Restricted Project
sylvestre.ledru added a comment to D36051: Move from a long list of checkers to tables.

I am a little bit conflicted about the Severity column. While I know our people put a great deal of effort into keeping this classification sane, what was put into CodeChecker is, at the end of the day, a pretty arbitrary classification.

Fri, Dec 20, 9:09 AM · Restricted Project
sylvestre.ledru updated the diff for D36051: Move from a long list of checkers to tables.

Add a comment about codechecker

Fri, Dec 20, 8:59 AM · Restricted Project
sylvestre.ledru added a comment to D36051: Move from a long list of checkers to tables.

But please, let's make that table heading nice. Severity is capitalised, name is not, "has an autofix" sounds weird... Maybe "offers fixes" instead?

Fri, Dec 20, 6:48 AM · Restricted Project
sylvestre.ledru added a comment to D36051: Move from a long list of checkers to tables.

May be also split table by checks groups?

Fri, Dec 20, 6:48 AM · Restricted Project
sylvestre.ledru updated the diff for D36051: Move from a long list of checkers to tables.

Remove artifacts

Fri, Dec 20, 6:48 AM · Restricted Project
sylvestre.ledru updated the diff for D36051: Move from a long list of checkers to tables.

Polish the column titles

Fri, Dec 20, 6:38 AM · Restricted Project
sylvestre.ledru added a comment to D36051: Move from a long list of checkers to tables.


here is the result

Fri, Dec 20, 2:58 AM · Restricted Project
sylvestre.ledru updated the diff for D36051: Move from a long list of checkers to tables.

Move to the table idea... Two years after :)

Fri, Dec 20, 2:02 AM · Restricted Project
sylvestre.ledru abandoned D71745: clang-tidy doc: Move from a long list of checkers to tables.

Done here:
https://reviews.llvm.org/D36051

Fri, Dec 20, 2:02 AM · Restricted Project
sylvestre.ledru created D71745: clang-tidy doc: Move from a long list of checkers to tables.
Fri, Dec 20, 2:02 AM · Restricted Project

Thu, Dec 19

sylvestre.ledru committed rGdac98cfa03e9: Fix the links to clang analyzers checkers (authored by sylvestre.ledru).
Fix the links to clang analyzers checkers
Thu, Dec 19, 1:32 PM
sylvestre.ledru committed rG918d39397223: Fix some typos in the clang-tools-extra doc (authored by sylvestre.ledru).
Fix some typos in the clang-tools-extra doc
Thu, Dec 19, 1:24 PM

Dec 9 2019

sylvestre.ledru added a comment to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.

affects positively its performance.

Dec 9 2019, 5:08 AM · Restricted Project, Restricted Project

Dec 8 2019

sylvestre.ledru committed rGa05d7c278ee2: Fix typo in the AST Matcher Reference doc Closes: #54 (authored by sylvestre.ledru).
Fix typo in the AST Matcher Reference doc Closes: #54
Dec 8 2019, 7:18 AM

Dec 1 2019

sylvestre.ledru added a comment to D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default.

@kristina can we land this patch ? Thanks

Dec 1 2019, 4:30 AM · Restricted Project

Nov 21 2019

sylvestre.ledru added inline comments to D70460: export.sh: Fetch sources from GitHub instead of SVN.
Nov 21 2019, 12:36 AM · Restricted Project

Nov 16 2019

sylvestre.ledru added a comment to D6920: [clang-format] Add SpaceBeforeBrackets.

Would be nice to add this to the release notes too ;)

Nov 16 2019, 5:52 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru committed rG9b40a7f3bf71: Remove +x permission on some files (authored by sylvestre.ledru).
Remove +x permission on some files
Nov 16 2019, 5:48 AM
sylvestre.ledru committed rGd4819fe0ec10: Remove +x permission on clang/lib/Format/Format.cpp (authored by sylvestre.ledru).
Remove +x permission on clang/lib/Format/Format.cpp
Nov 16 2019, 5:48 AM
sylvestre.ledru committed rG114f3e5b08af: Fix a build failure with perf: Add a missing include to… (authored by sylvestre.ledru).
Fix a build failure with perf: Add a missing include to…
Nov 16 2019, 5:48 AM
sylvestre.ledru added a comment to D6920: [clang-format] Add SpaceBeforeBrackets.

fyi, +x permissions was added to clang/lib/Format/Format.cpp
I reverted the change in a4a7c1259e8a8f2d11fa29686a6c2834948c1358

Nov 16 2019, 5:47 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru committed rG42effc106966: Add support of the next Ubuntu (Ubuntu 20.04 - Focal Fossa) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 20.04 - Focal Fossa)
Nov 16 2019, 3:23 AM

Nov 11 2019

MyDeveloperDay awarded rG152e83fc59af: clang-format: fix a typo introduced by the previous change a Like token.
Nov 11 2019, 2:35 PM
sylvestre.ledru committed rG152e83fc59af: clang-format: fix a typo introduced by the previous change (authored by sylvestre.ledru).
clang-format: fix a typo introduced by the previous change
Nov 11 2019, 12:58 PM

Nov 8 2019

sylvestre.ledru committed rG3a3255a22398: clang-format: refresh the list of options (authored by sylvestre.ledru).
clang-format: refresh the list of options
Nov 8 2019, 2:43 PM
sylvestre.ledru committed rG4c44fd3de374: clang-format: Add to the release notes the new --dry-run/-n option (authored by sylvestre.ledru).
clang-format: Add to the release notes the new --dry-run/-n option
Nov 8 2019, 2:34 PM

Nov 7 2019

sylvestre.ledru added a comment to D68720: Support -fstack-clash-protection for x86.

@sylvestre.ledru did the testing and benchmarking on firefox (see https://bugzilla.mozilla.org/show_bug.cgi?id=1588710#c12), everything seems ok, let's move forward?

Nov 7 2019, 2:07 PM · Restricted Project, Restricted Project

Oct 31 2019

sylvestre.ledru added a comment to D69435: [clang-tidy] New checker performance-trivially-destructible-check.

Thanks!

Oct 31 2019, 7:32 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D69435: [clang-tidy] New checker performance-trivially-destructible-check.

Did you see some significant perf improvements for Chromium?

Oct 31 2019, 1:34 AM · Restricted Project, Restricted Project

Oct 24 2019

sylvestre.ledru added inline comments to D68720: Support -fstack-clash-protection for x86.
Oct 24 2019, 8:12 AM · Restricted Project, Restricted Project

Oct 20 2019

sylvestre.ledru added a comment to D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible.

More dynamic, less static isn't always a good thing. It saves disk space at the expense of performance. The option that controls this is CLANG_LINK_CLANG_DYLIB, which is mentioned in the clang 9.0 release notes.

Oct 20 2019, 6:23 AM · Restricted Project

Oct 19 2019

sylvestre.ledru committed rG751e0bb6af33: Explicit in the doc the current list of projects (with easy copy and paste) (authored by sylvestre.ledru).
Explicit in the doc the current list of projects (with easy copy and paste)
Oct 19 2019, 2:55 AM
sylvestre.ledru committed rG963e0d6755cd: Make it clear in the doc that 'all' in LLVM_ENABLE_PROJECTS does install ALL… (authored by sylvestre.ledru).
Make it clear in the doc that 'all' in LLVM_ENABLE_PROJECTS does install ALL…
Oct 19 2019, 2:28 AM

Oct 18 2019

sylvestre.ledru closed D69190: Remove Safecode from the homepage.
Oct 18 2019, 12:30 PM
sylvestre.ledru created D69190: Remove Safecode from the homepage.
Oct 18 2019, 12:12 PM
sylvestre.ledru added a comment to D68720: Support -fstack-clash-protection for x86.

You should also probably document the arg in
clang/docs/ClangCommandLineReference.rst
we have -fstack-protector-strong & co in the doc

Oct 18 2019, 2:52 AM · Restricted Project, Restricted Project

Oct 15 2019

sylvestre.ledru added a comment to D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy.

In that function https://github.com/llvm/llvm-project/blob/5fd467feb813e9999efe3558da434cb038213582/clang/cmake/modules/AddClang.cmake#L180

Oct 15 2019, 6:09 AM · Restricted Project
sylvestre.ledru added a comment to D68554: [clang-format] Proposal for clang-format to give compiler style warnings.

@MyDeveloperDay I think it should be added to the release notes. it is a great new changes for clang format (it would have made my life at Mozilla much easier ;)

Oct 15 2019, 4:44 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru added a comment to D63932: [GlobalDCE] Dead Virtual Function Elimination.

@ostannard Maybe you could add that to the release notes? Thanks

Oct 15 2019, 12:00 AM · Restricted Project, Restricted Project

Oct 14 2019

sylvestre.ledru accepted D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy.

Thanks
It fixed my problem.

Oct 14 2019, 11:09 PM · Restricted Project
sylvestre.ledru added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

It now shows for the llvm toolchain: http://llvm.org/reports/scan-build/

Oct 14 2019, 1:42 AM · Restricted Project, Restricted Project

Oct 12 2019

sylvestre.ledru committed rG4644e9a50a4f: remove an useless allocation found by scan-build - the new Dead nested… (authored by sylvestre.ledru).
remove an useless allocation found by scan-build - the new Dead nested…
Oct 12 2019, 8:28 AM

Oct 11 2019

sylvestre.ledru added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

I added it to the release notes here : https://reviews.llvm.org/rC374593
I am wondering if the option( WarnForDeadNestedAssignments ) to disable it is really necessary?
I haven't seen any false positive while deadstore has some.

Oct 11 2019, 1:37 PM · Restricted Project, Restricted Project
sylvestre.ledru committed rG9bea4ec28cdf: Release notes: Add the option WarnForDeadNestedAssignments https://reviews.llvm. (authored by sylvestre.ledru).
Release notes: Add the option WarnForDeadNestedAssignments https://reviews.llvm.
Oct 11 2019, 1:36 PM

Oct 9 2019

sylvestre.ledru added a comment to D68710: Remove time-trace message as it is inconsistent style.

besides that, I think we should do it; thanks :)

Oct 9 2019, 9:40 AM · Restricted Project
sylvestre.ledru added inline comments to D68710: Remove time-trace message as it is inconsistent style.
Oct 9 2019, 9:31 AM · Restricted Project