Page MenuHomePhabricator

sylvestre.ledru (Sylvestre Ledru)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2013, 1:12 AM (523 w, 3 d)

Recent Activity

Feb 2 2023

sylvestre.ledru committed rW4594a3df4cd3: Update url to ACM system award recipients (authored by Darren Kavanagh <dkav@users.noreply.github.com>).
Update url to ACM system award recipients
Feb 2 2023, 2:38 PM · Restricted Project

Jan 29 2023

sylvestre.ledru committed rG4430e69fbdf5: flang: remove the hardcoded 15 from the release notes (authored by sylvestre.ledru).
flang: remove the hardcoded 15 from the release notes
Jan 29 2023, 1:15 PM · Restricted Project, Restricted Project
sylvestre.ledru closed D142835: flang: remove the hardcoded 15 from the release notes.
Jan 29 2023, 1:15 PM · Restricted Project, Restricted Project
sylvestre.ledru committed rW1d125cf05e25: Users.html: Update URL for Huawei's BiSheng compiler (authored by bryanpkc).
Users.html: Update URL for Huawei's BiSheng compiler
Jan 29 2023, 12:32 PM · Restricted Project
sylvestre.ledru requested review of D142835: flang: remove the hardcoded 15 from the release notes.
Jan 29 2023, 1:11 AM · Restricted Project, Restricted Project

Jan 26 2023

sylvestre.ledru committed rG1b9fbc81ff15: [extract_symbols.py] Filter out more symbols for MSVC (authored by glandium).
[extract_symbols.py] Filter out more symbols for MSVC
Jan 26 2023, 12:28 PM · Restricted Project, Restricted Project
sylvestre.ledru closed D142431: [extract_symbols.py] Filter out more symbols for MSVC.
Jan 26 2023, 12:28 PM · Restricted Project, Restricted Project
sylvestre.ledru committed rG7c7e215f0e2b: flang: fix a copy and paste mistake (authored by sylvestre.ledru).
flang: fix a copy and paste mistake
Jan 26 2023, 12:19 AM · Restricted Project, Restricted Project
sylvestre.ledru closed D142488: flang: fix a copy and paste mistake.
Jan 26 2023, 12:19 AM · Restricted Project, Restricted Project
sylvestre.ledru added a reviewer for D142488: flang: fix a copy and paste mistake: sscalpone.
Jan 26 2023, 12:05 AM · Restricted Project, Restricted Project

Jan 24 2023

sylvestre.ledru requested review of D142488: flang: fix a copy and paste mistake.
Jan 24 2023, 9:24 AM · Restricted Project, Restricted Project

Jan 18 2023

sylvestre.ledru added a comment to D138931: [OpenMP] Support kernel record and replay.

it doesn't build on i386:
https://github.com/llvm/llvm-project/issues/60121

Jan 18 2023, 2:11 AM · Restricted Project, Restricted Project

Jan 12 2023

sylvestre.ledru added a comment to D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too.

thanks. reverting is fine :)

Jan 12 2023, 9:20 AM · Restricted Project, Restricted Project

Jan 10 2023

sylvestre.ledru committed rG9f3081dc6fe8: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too (authored by sylvestre.ledru).
build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too
Jan 10 2023, 12:02 PM · Restricted Project, Restricted Project
sylvestre.ledru closed D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too.
Jan 10 2023, 12:02 PM · Restricted Project, Restricted Project

Jan 9 2023

sylvestre.ledru added a comment to D141208: libc++: bring back the unsigned in the return type in wcstoull_l.

@philnik Sorry but we don't really have a way to know who is the "libc++ team". I don't know if @brad is part of it or not

Jan 9 2023, 1:26 AM · Restricted Project, Restricted Project

Jan 8 2023

sylvestre.ledru committed rGfc87452916c0: libc++: bring back the unsigned in the return type in wcstoull_l (authored by sylvestre.ledru).
libc++: bring back the unsigned in the return type in wcstoull_l
Jan 8 2023, 3:29 AM · Restricted Project, Restricted Project
sylvestre.ledru closed D141208: libc++: bring back the unsigned in the return type in wcstoull_l.
Jan 8 2023, 3:29 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D141208: libc++: bring back the unsigned in the return type in wcstoull_l.

Sorry about that.

Jan 8 2023, 3:27 AM · Restricted Project, Restricted Project

Jan 7 2023

sylvestre.ledru requested review of D141208: libc++: bring back the unsigned in the return type in wcstoull_l.
Jan 7 2023, 3:39 PM · Restricted Project, Restricted Project

Jan 6 2023

sylvestre.ledru committed rG8e20cb6bb8d0: flang: break the build on 32bit systems (authored by sylvestre.ledru).
flang: break the build on 32bit systems
Jan 6 2023, 8:14 AM · Restricted Project, Restricted Project
sylvestre.ledru closed D141132: flang: break the build on a 32bits system.
Jan 6 2023, 8:14 AM · Restricted Project, Restricted Project
sylvestre.ledru committed rGf7bd4ef7b0ac: Doc: improve the flang readme page (authored by sylvestre.ledru).
Doc: improve the flang readme page
Jan 6 2023, 8:10 AM · Restricted Project, Restricted Project
sylvestre.ledru closed D141126: Doc: improve the flang readme page.
Jan 6 2023, 8:09 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D141132: flang: break the build on a 32bits system.

Improve the wording

Jan 6 2023, 7:01 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D141126: Doc: improve the flang readme page.

wording improvements

Jan 6 2023, 6:59 AM · Restricted Project, Restricted Project
sylvestre.ledru requested review of D141132: flang: break the build on a 32bits system.
Jan 6 2023, 6:32 AM · Restricted Project, Restricted Project
sylvestre.ledru requested review of D141126: Doc: improve the flang readme page.
Jan 6 2023, 5:20 AM · Restricted Project, Restricted Project

Jan 5 2023

sylvestre.ledru updated the diff for D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too.

add the missing {}

Jan 5 2023, 6:16 AM · Restricted Project, Restricted Project
sylvestre.ledru requested review of D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too.
Jan 5 2023, 5:59 AM · Restricted Project, Restricted Project

Dec 16 2022

sylvestre.ledru added a comment to D138389: [OpenMP][libomptarget] Add AMDGPU NextGen plugin with asynchronous behavior.

Seems that it caused this problem:
https://github.com/llvm/llvm-project/issues/59543

Dec 16 2022, 2:46 AM · Restricted Project, Restricted Project

Nov 24 2022

sylvestre.ledru added a comment to D137854: libclc: Use cmake files instead of llvm-config.

maybe add this to the release notes ?
thanks

Nov 24 2022, 7:48 AM · Restricted Project, Restricted Project

Nov 13 2022

sylvestre.ledru added inline comments to D137898: [Docs] Add Documentation on (Thin)LTO + PGO Build Configs.
Nov 13 2022, 11:39 PM · Restricted Project, Restricted Project
sylvestre.ledru accepted D137899: [Docs] Add Documentation on BOLT Build Configs.
Nov 13 2022, 12:56 AM · Restricted Project, Restricted Project
sylvestre.ledru accepted D137898: [Docs] Add Documentation on (Thin)LTO + PGO Build Configs.

much better, thanks

Nov 13 2022, 12:55 AM · Restricted Project, Restricted Project

Nov 11 2022

sylvestre.ledru accepted D137880: [Docs] Minor Fixups in Advanced Builds Documentation.

thanks for caring for the doc!

Nov 11 2022, 11:47 PM · Restricted Project, Restricted Project
sylvestre.ledru committed rGa77a02aa5794: consistency: use spaces instead of tabs (authored by sylvestre.ledru).
consistency: use spaces instead of tabs
Nov 11 2022, 8:36 AM · Restricted Project, Restricted Project

Nov 10 2022

sylvestre.ledru added a comment to rG858ded9cba11: workflows: Use sccache to speed up CI builds.

to close the loop, stage 2 wasn't cached by sccache because sccache is doing an hash of the clang binary
and my clang binary contained the timestamp + git hash (making it different everything)
I documented this in sccache:
https://github.com/mozilla/sccache/blob/main/docs/Caching.md

Nov 10 2022, 3:30 AM · Restricted Project

Nov 5 2022

sylvestre.ledru committed rGd1829c308da9: Add support of the next Ubuntu (Ubuntu 23.04 - Lunar Lobster) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 23.04 - Lunar Lobster)
Nov 5 2022, 2:37 PM · Restricted Project, Restricted Project

Nov 3 2022

sylvestre.ledru added a comment to D125860: [clang] Only use major version in resource dir.

i hope not too many people rely on it.
LGTM but please add it to the release notes

Nov 3 2022, 9:16 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru added a comment to D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR.

Maybe add it to the release notes?

Nov 3 2022, 7:48 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 24 2022

sylvestre.ledru added a comment to rG858ded9cba11: workflows: Use sccache to speed up CI builds.

OK, thanks :)
It seems that it is a stage1 regular build, no?

Oct 24 2022, 7:23 AM · Restricted Project

Oct 23 2022

sylvestre.ledru committed rG86e57e66da93: [InstCombine] Bail out of casting calls when a conversion from/to byval is… (authored by glandium).
[InstCombine] Bail out of casting calls when a conversion from/to byval is…
Oct 23 2022, 12:50 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D135738: [InstCombine] Bail out of casting calls when a conversion from/to byval is involved..

Just did!

Oct 23 2022, 12:50 AM · Restricted Project, Restricted Project
sylvestre.ledru closed D135738: [InstCombine] Bail out of casting calls when a conversion from/to byval is involved..
Oct 23 2022, 12:50 AM · Restricted Project, Restricted Project

Oct 22 2022

sylvestre.ledru updated the summary of D135553: [sanitizer] Update struct_kernel_stat_sz for mips32 and mipsn32.
Oct 22 2022, 11:24 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to rG858ded9cba11: workflows: Use sccache to speed up CI builds.

@tstellar did you look at the caching results?
does it cache almost everything?

Oct 22 2022, 1:15 AM · Restricted Project

Oct 21 2022

sylvestre.ledru added a comment to D136424: Update links to googletest documentation.

I am sure the doc has plenty of other issues!

Oct 21 2022, 10:23 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D136424: Update links to googletest documentation.

yeah, happy to do that if the author wants :)

Oct 21 2022, 5:10 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D136424: Update links to googletest documentation.

oh, crappy, i forgot to update the author of the patch :(
really sorry about that... :(

Oct 21 2022, 4:57 AM · Restricted Project, Restricted Project
sylvestre.ledru committed rGb814d85e5b9d: Update links to googletest documentation (authored by sylvestre.ledru).
Update links to googletest documentation
Oct 21 2022, 4:56 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D136424: Update links to googletest documentation.

pushed

Oct 21 2022, 4:56 AM · Restricted Project, Restricted Project
sylvestre.ledru closed D136424: Update links to googletest documentation.
Oct 21 2022, 4:56 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D136424: Update links to googletest documentation.

np, let me land this for you

Oct 21 2022, 4:53 AM · Restricted Project, Restricted Project
sylvestre.ledru accepted D136424: Update links to googletest documentation.

Thanks for carrying about the doc!

Oct 21 2022, 12:53 AM · Restricted Project, Restricted Project

Oct 18 2022

sylvestre.ledru accepted D136092: [CMake] Add Python script to generate version script symbol exports.

LGTM

Oct 18 2022, 4:59 AM · Restricted Project, Restricted Project
sylvestre.ledru added inline comments to D136092: [CMake] Add Python script to generate version script symbol exports.
Oct 18 2022, 12:03 AM · Restricted Project, Restricted Project

Oct 7 2022

sylvestre.ledru committed rW4640fa67672d: reference bolt from the homepage (authored by sylvestre.ledru).
reference bolt from the homepage
Oct 7 2022, 8:30 AM · Restricted Project
sylvestre.ledru committed rGedbde15f46ca: Fix typos - show in the binary (authored by sylvestre.ledru).
Fix typos - show in the binary
Oct 7 2022, 6:57 AM · Restricted Project, Restricted Project

Oct 6 2022

sylvestre.ledru committed rGd3b0e745e8a3: [CodeView] Avoid NULL deref of Scope (authored by glandium).
[CodeView] Avoid NULL deref of Scope
Oct 6 2022, 11:35 PM · Restricted Project, Restricted Project
sylvestre.ledru closed D134616: [CodeView] Avoid NULL deref of Scope.
Oct 6 2022, 11:35 PM · Restricted Project, Restricted Project

Sep 13 2022

sylvestre.ledru added inline comments to D133771: Add a "Potentially Breaking Changes" section to the Clang release notes.
Sep 13 2022, 8:16 AM · Restricted Project, Restricted Project
sylvestre.ledru committed rGcd20a1828605: Revert "[clang, llvm] Add __declspec(safebuffers), support it in CodeView" (authored by sylvestre.ledru).
Revert "[clang, llvm] Add __declspec(safebuffers), support it in CodeView"
Sep 13 2022, 1:54 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru added a reverting change for rGab56719acd98: [clang, llvm] Add __declspec(safebuffers), support it in CodeView: rGcd20a1828605: Revert "[clang, llvm] Add __declspec(safebuffers), support it in CodeView".
Sep 13 2022, 1:54 AM · Restricted Project, Restricted Project, Restricted Project

Aug 16 2022

sylvestre.ledru committed rG8f555a52e033: [cmake] Fix tablegen exports (authored by nikic).
[cmake] Fix tablegen exports
Aug 16 2022, 5:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru closed D131565: [cmake] Fix tablegen exports.
Aug 16 2022, 5:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 10 2022

sylvestre.ledru accepted D131590: Fixed page title for abseil-no-internal-dependencies check documentation.
Aug 10 2022, 10:14 AM · Restricted Project, Restricted Project

Aug 9 2022

sylvestre.ledru added a comment to D131477: [openmp] Fix enumeration build issue for openmp library .

thanks!

Aug 9 2022, 4:01 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values.

We have this error in OpenMP:
https://github.com/llvm/llvm-project/issues/57022

Aug 9 2022, 1:48 AM · Restricted Project, Restricted Project

Aug 1 2022

sylvestre.ledru committed rG556c422de1c3: clang-tidy doc: fix some typos (authored by sylvestre.ledru).
clang-tidy doc: fix some typos
Aug 1 2022, 10:06 AM · Restricted Project, Restricted Project
sylvestre.ledru committed rG37047a26731a: misc-const-correctness: fix the link to readability-isolate-declaration (authored by sylvestre.ledru).
misc-const-correctness: fix the link to readability-isolate-declaration
Aug 1 2022, 9:53 AM · Restricted Project, Restricted Project

Jul 28 2022

sylvestre.ledru added a comment to D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs.

Same, it broke apt.llvm.org

Jul 28 2022, 12:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 4 2022

sylvestre.ledru added a comment to D125918: [LV] Improve register pressure estimate at high VFs.

it introduced a regression here:

Jul 4 2022, 6:51 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

@pengfei I am not convinced it is an issue on my side. I don't have anything particular in this area and using a stage2 build system.

Jul 4 2022, 3:59 AM · Restricted Project, Restricted Project, Restricted Project

Jul 3 2022

sylvestre.ledru added a comment to D129049: [clang] Fix gcc-6 compilation error. (NFC).

thanks
I will retrigger the CI

Jul 3 2022, 2:00 PM · Restricted Project, Restricted Project

Jul 2 2022

sylvestre.ledru added a comment to D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI.

Same as in https://reviews.llvm.org/D114099
It breaks the build on ubuntu bionic, Hirsute, etc on amd64:

Jul 2 2022, 4:07 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag: Restricted Project.

Sorry, i missed your questions

Jul 2 2022, 3:45 AM · Restricted Project, Restricted Project

Jun 8 2022

sylvestre.ledru committed rWadb1f6f001c0: 2022 EuroLLVM happened (authored by sylvestre.ledru).
2022 EuroLLVM happened
Jun 8 2022, 2:32 AM · Restricted Project

May 30 2022

sylvestre.ledru accepted D126672: [Driver] Add multiarch path for RISC-V.

LGTM

May 30 2022, 11:30 PM · Restricted Project, Restricted Project

May 24 2022

sylvestre.ledru committed rG1e2b746390e3: Revert "[TableGen] Remove code beads" (authored by sylvestre.ledru).
Revert "[TableGen] Remove code beads"
May 24 2022, 5:20 AM · Restricted Project, Restricted Project
sylvestre.ledru added a reverting change for rGf50be3d21808: [TableGen] Remove code beads: rG1e2b746390e3: Revert "[TableGen] Remove code beads".
May 24 2022, 5:20 AM · Restricted Project, Restricted Project

May 23 2022

sylvestre.ledru committed rG6f4dc5dae605: Add support of the next Ubuntu (Ubuntu 22.10 - Kinetic Kudu) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 22.10 - Kinetic Kudu)
May 23 2022, 4:52 AM · Restricted Project, Restricted Project
sylvestre.ledru committed rGa02000611a8f: Add support of the next Debian (Debian 13 - Trixie) (authored by sylvestre.ledru).
Add support of the next Debian (Debian 13 - Trixie)
May 23 2022, 4:52 AM · Restricted Project, Restricted Project

May 22 2022

sylvestre.ledru added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

@bzcheeseman FYI, this is breaking the build with gcc 6 (for Debian stretch)
if you are aware of a simple fix, it would be appreciated
See https://github.com/llvm/llvm-project/issues/55626

May 22 2022, 9:49 AM · Restricted Project, Restricted Project

May 1 2022

sylvestre.ledru committed rGee4ac3a856a6: doc: update of the adv build doc now that clang is in tree too (authored by sylvestre.ledru).
doc: update of the adv build doc now that clang is in tree too
May 1 2022, 2:00 PM · Restricted Project, Restricted Project

Mar 10 2022

sylvestre.ledru committed rG54d7fde46e8a: llvm-ifs doc: Replace a utf-8 char by a more classic one (authored by sylvestre.ledru).
llvm-ifs doc: Replace a utf-8 char by a more classic one
Mar 10 2022, 1:45 PM · Restricted Project

Feb 22 2022

sylvestre.ledru added inline comments to D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON.
Feb 22 2022, 12:34 AM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2022

sylvestre.ledru added a comment to D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path.

Could you please stop with the pings? and chat directly ? (It seems that you are colleagues?!)

Feb 15 2022, 2:23 PM · Restricted Project, Restricted Project

Feb 12 2022

sylvestre.ledru added a comment to D7982: [clang-tidy] Add readability-duplicate-include check.

Thanks for this, it found 74 occurrences of this in the firefox code base
https://hg.mozilla.org/mozilla-central/rev/b07f125d09fd

Feb 12 2022, 7:36 AM · Restricted Project

Feb 8 2022

sylvestre.ledru committed rGed76de7d9e69: README: Point to the discourse & discord forums (authored by sylvestre.ledru).
README: Point to the discourse & discord forums
Feb 8 2022, 1:41 PM
sylvestre.ledru closed D119279: README: Point to the discourse & discord forums.
Feb 8 2022, 1:41 PM · Restricted Project
sylvestre.ledru added inline comments to D119279: README: Point to the discourse & discord forums.
Feb 8 2022, 1:40 PM · Restricted Project
sylvestre.ledru updated the diff for D119279: README: Point to the discourse & discord forums.

Add IRC

Feb 8 2022, 1:39 PM · Restricted Project
sylvestre.ledru requested review of D119279: README: Point to the discourse & discord forums.
Feb 8 2022, 12:56 PM · Restricted Project
sylvestre.ledru committed rGf2c2e924e73a: Fix a typo (occured => occurred) (authored by sylvestre.ledru).
Fix a typo (occured => occurred)
Feb 8 2022, 12:35 PM
sylvestre.ledru added a comment to D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON.

Log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console

Feb 8 2022, 1:20 AM · Restricted Project
sylvestre.ledru added a comment to D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON.

Debian is still broken with this patch on -14:

lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to 'inflateInit2_' lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to 'inflate' lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to 'inflateEnd'
Feb 8 2022, 1:19 AM · Restricted Project

Feb 3 2022

sylvestre.ledru added a comment to D112940: Add a tool for diffing instruction count + stack size remarks.

if this isn't the case, it would be nice to add this to the release notes :)

Feb 3 2022, 12:17 AM · Restricted Project

Feb 2 2022

sylvestre.ledru committed rGb4bb622fc94a: Also document -arch as -arch is mac specific (authored by sylvestre.ledru).
Also document -arch as -arch is mac specific
Feb 2 2022, 7:24 AM
sylvestre.ledru closed D60380: Also document -arch as -arch is mac specific.
Feb 2 2022, 7:23 AM · Restricted Project