Page MenuHomePhabricator

sylvestre.ledru (Sylvestre Ledru)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2013, 1:12 AM (394 w, 6 d)

Recent Activity

Mon, Sep 21

sylvestre.ledru added a comment to D75791: [clang-format] Added new option IndentExternBlock.

@MarcusJohnson91 I know it is confusing but we don't use the Mozilla coding style. We are using the Google style.

Mon, Sep 21, 11:52 PM · Restricted Project, Restricted Project, Restricted Project

Sun, Sep 20

sylvestre.ledru added a comment to D75791: [clang-format] Added new option IndentExternBlock.

Any chance this changes could have caused this regression https://bugs.llvm.org/show_bug.cgi?id=47589 ?

Sun, Sep 20, 3:24 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru added a comment to D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`.
Sun, Sep 20, 3:11 AM · Restricted Project, Restricted Project

Thu, Sep 17

sylvestre.ledru added a comment to D87758: Provide a hook to customize missing library error handling.

I am sure you are planning to do it but please don't forget the release notes and the documentation.

Thu, Sep 17, 5:34 AM

Wed, Sep 16

sylvestre.ledru added a comment to D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`.

Thanks for this checker. FYI, it found (at least) 3 defects in Firefox code:
https://hg.mozilla.org/mozilla-central/rev/651e68f628d0

Wed, Sep 16, 3:26 AM · Restricted Project, Restricted Project

Wed, Sep 9

sylvestre.ledru added a comment to D87187: [Driver] Perform Linux distribution detection just once.

I guess it isn't possible to write tests for this?

Wed, Sep 9, 11:30 PM · Restricted Project

Jul 8 2020

sylvestre.ledru committed rGbbea4d5e6b82: clang: Don't show a trailing space with --version when not built from the repo (authored by sylvestre.ledru).
clang: Don't show a trailing space with --version when not built from the repo
Jul 8 2020, 5:02 AM
sylvestre.ledru closed D83386: clang: Don't show a trailing space with --version when not built from the repo.
Jul 8 2020, 5:02 AM · Restricted Project
Herald added a project to D83386: clang: Don't show a trailing space with --version when not built from the repo: Restricted Project.
Jul 8 2020, 4:46 AM · Restricted Project

Jun 22 2020

sylvestre.ledru accepted D81932: [clang-tidy] Improved accuracy of check list updater script.

Excellent, thanks :)

Jun 22 2020, 1:01 AM · Restricted Project

Jun 19 2020

sylvestre.ledru added a comment to D75284: [Sphinx] Adjust for source_parsers deprecation in Sphinx 3.0 .

it breaks the build on Debian stable (and probably some Ubuntu LTS). With sphinx 1.8.4
Could you please revert the change ?

Jun 19 2020, 6:59 AM · Restricted Project

Jun 18 2020

sylvestre.ledru added a comment to D76012: [OpenMP][Tool] Header-only multiplexing of OMPT tools.

@protze.joachim @jdoerfert ompt-multiplex.h is installed by default in /usr/include/
others opemp headers are installed in /usr/include/openmp/

Jun 18 2020, 4:18 AM · Restricted Project
sylvestre.ledru added a comment to D76012: [OpenMP][Tool] Header-only multiplexing of OMPT tools.

maybe this improvement should be added to the release notes too ?

Jun 18 2020, 4:18 AM · Restricted Project
sylvestre.ledru resigned from D66390: [PATCH] [llvm] [Support] Update license on ConvertUTF.* per upstream license change.

I would like to see that happening but I am not a lawyer and important enough person in the project to make such call.

Jun 18 2020, 4:18 AM · Restricted Project
sylvestre.ledru accepted D78867: [docs] avoid 'arc land' command.

works for me
I like "arc land" but I am not opposed to changing the doc

Jun 18 2020, 3:46 AM · Restricted Project
sylvestre.ledru resigned from D34083: fix crash on thumb backend, only visit first and last operands of GEP on ConstantHoisting.
Jun 18 2020, 3:46 AM · Restricted Project
sylvestre.ledru accepted D75284: [Sphinx] Adjust for source_parsers deprecation in Sphinx 3.0 .

thanks!

Jun 18 2020, 3:46 AM · Restricted Project

Jun 4 2020

sylvestre.ledru added a comment to D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function.

@zequanwu could you please update the release notes? thanks
https://github.com/llvm/llvm-project/blob/master/clang/docs/ReleaseNotes.rst

Jun 4 2020, 8:11 AM · Restricted Project

May 29 2020

sylvestre.ledru committed rGa3418631e8aa: libclc: update website url (authored by davidak <davidak@users.noreply.github.com>).
libclc: update website url
May 29 2020, 12:30 AM
sylvestre.ledru committed rGca467542eecf: [CMake] Pass CLANG_VENDOR variables into later stages (authored by sylvestre.ledru).
[CMake] Pass CLANG_VENDOR variables into later stages
May 29 2020, 12:30 AM

May 28 2020

sylvestre.ledru added inline comments to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.
May 28 2020, 6:30 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project.

Well done!

May 28 2020, 5:57 AM · Restricted Project, Restricted Project

May 18 2020

sylvestre.ledru committed rGdbb034947cc1: Add support of the next Ubuntu (Ubuntu 20.10 - Groovy Gorilla) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 20.10 - Groovy Gorilla)
May 18 2020, 11:57 PM

May 13 2020

sylvestre.ledru updated subscribers of rG13a633b438b6: [gcov] Delete CC1 option -coverage-no-function-names-in-data.

Can you point to me how Firefox uses -Xclang -coverage-no-function-names-in-data? Debian code search does not reveal anything.

May 13 2020, 10:17 AM
sylvestre.ledru updated subscribers of rG13a633b438b6: [gcov] Delete CC1 option -coverage-no-function-names-in-data.
May 13 2020, 4:48 AM
sylvestre.ledru added a comment to rG13a633b438b6: [gcov] Delete CC1 option -coverage-no-function-names-in-data.

@MaskRay Please don't land such patch without review.

May 13 2020, 4:48 AM

May 10 2020

sylvestre.ledru added a comment to D78052: add_new_check.py: Update of the template to add an autofix section.

has been reverted

May 10 2020, 4:47 AM · Restricted Project
sylvestre.ledru reopened D78052: add_new_check.py: Update of the template to add an autofix section.
May 10 2020, 4:47 AM · Restricted Project
sylvestre.ledru reopened D77983: clang-tidy doc: add a note for every checker with an autofix.

has been reverted

May 10 2020, 4:47 AM · Restricted Project
sylvestre.ledru committed rGa832fc4b0c1e: Revert two patches, not ready to be shared (authored by sylvestre.ledru).
Revert two patches, not ready to be shared
May 10 2020, 2:40 AM
sylvestre.ledru added a reverting change for rGdc0f79ea5b99: clang-tidy doc: add a note for checkers with an autofix: rGa832fc4b0c1e: Revert two patches, not ready to be shared.
May 10 2020, 2:40 AM
sylvestre.ledru added a reverting change for rGf97f92e5b0fd: add_new_check.py: Update of the template to add an autofix section: rGa832fc4b0c1e: Revert two patches, not ready to be shared.
May 10 2020, 2:40 AM
sylvestre.ledru committed rGb0828135dbe3: clang-tidy doc: Fix the syntax to use rst list type (authored by sylvestre.ledru).
clang-tidy doc: Fix the syntax to use rst list type
May 10 2020, 2:39 AM
sylvestre.ledru committed rGf97f92e5b0fd: add_new_check.py: Update of the template to add an autofix section (authored by sylvestre.ledru).
add_new_check.py: Update of the template to add an autofix section
May 10 2020, 2:39 AM
sylvestre.ledru committed rGdc0f79ea5b99: clang-tidy doc: add a note for checkers with an autofix (authored by sylvestre.ledru).
clang-tidy doc: add a note for checkers with an autofix
May 10 2020, 2:39 AM
sylvestre.ledru closed D77983: clang-tidy doc: add a note for every checker with an autofix.
May 10 2020, 2:39 AM · Restricted Project
sylvestre.ledru closed D78052: add_new_check.py: Update of the template to add an autofix section.
May 10 2020, 2:39 AM · Restricted Project
sylvestre.ledru added a comment to D78052: add_new_check.py: Update of the template to add an autofix section.

@alexfh ping ? :)

May 10 2020, 2:39 AM · Restricted Project
sylvestre.ledru added a comment to D77983: clang-tidy doc: add a note for every checker with an autofix.

@alexfh ping

May 10 2020, 2:39 AM · Restricted Project

May 1 2020

sylvestre.ledru committed rG68e89c5b9603: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu Add… (authored by sthibaul).
[Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu Add…
May 1 2020, 3:37 AM
sylvestre.ledru committed rGc298e5a02292: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu (authored by sthibaul).
[Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu
May 1 2020, 3:13 AM

Apr 28 2020

sylvestre.ledru added a comment to D78867: [docs] avoid 'arc land' command.

are you sure? D<revision> worked for me in the past

Apr 28 2020, 1:34 AM · Restricted Project

Apr 27 2020

sylvestre.ledru accepted D78909: [clang-format] NFC clang-format the clang-format sources.
Apr 27 2020, 4:15 AM · Restricted Project, Restricted Project

Apr 25 2020

sylvestre.ledru added a comment to D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions.

FYI, in Mozilla build of clang-format, we reverted this change.
It was causing more issues than fixes.
https://bugzilla.mozilla.org/show_bug.cgi?id=1629853

Apr 25 2020, 2:37 AM · Restricted Project, Restricted Project, Restricted Project

Apr 24 2020

sylvestre.ledru accepted D78807: Fix gendered documentation.

thanks!

Apr 24 2020, 5:54 AM · Restricted Project, Restricted Project

Apr 23 2020

sylvestre.ledru accepted D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.
Apr 23 2020, 1:34 AM · Restricted Project, Restricted Project

Apr 18 2020

sylvestre.ledru added a comment to D77983: clang-tidy doc: add a note for every checker with an autofix.

@alexfh ping

Apr 18 2020, 4:18 AM · Restricted Project
sylvestre.ledru added a comment to D78052: add_new_check.py: Update of the template to add an autofix section.

@alexfh ping ? :)

Apr 18 2020, 4:18 AM · Restricted Project

Apr 17 2020

sylvestre.ledru added a comment to D78332: Fix interaction of static plugins with -DLLVM_LINK_LLVM_DYLIB=ON..

The cmake configure is fixed, thanks.
Running a full build now

Apr 17 2020, 1:02 AM · Restricted Project

Apr 16 2020

sylvestre.ledru updated subscribers of D76866: Enable new passmanager plugin support for LTO..

@eli.friedman @serge-sans-paille
Looks like it caused:
https://bugs.llvm.org/show_bug.cgi?id=45571
breaking builds on Debian & Ubuntu

Apr 16 2020, 2:14 AM · Restricted Project

Apr 14 2020

sylvestre.ledru added a comment to D74669: [clang-tidy] New check: bugprone-suspicious-include.

Firefox uses a unified build model. For better performances in the binary, the C++ files are compiled as the same time from a single file (ex: Unified_cpp_netwerk_base3.cpp) which will include the .cpp files.

Apr 14 2020, 4:45 AM · Restricted Project, Restricted Project

Apr 13 2020

sylvestre.ledru updated the diff for D77983: clang-tidy doc: add a note for every checker with an autofix.

Doing it by hand. @alexfh please let me know if you would be ok with it
(I will do it by hand)

Apr 13 2020, 2:07 PM · Restricted Project
sylvestre.ledru created D78052: add_new_check.py: Update of the template to add an autofix section.
Apr 13 2020, 1:34 PM · Restricted Project
sylvestre.ledru added a comment to D77983: clang-tidy doc: add a note for every checker with an autofix.

Makes sense.
I will give it a try :)
thanks

Apr 13 2020, 7:29 AM · Restricted Project
sylvestre.ledru updated the diff for D77983: clang-tidy doc: add a note for every checker with an autofix.

2 spaces instead of 4

Apr 13 2020, 2:07 AM · Restricted Project

Apr 12 2020

sylvestre.ledru created D77983: clang-tidy doc: add a note for every checker with an autofix.
Apr 12 2020, 4:33 PM · Restricted Project
sylvestre.ledru added a reviewer for D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`: pfultz2.
Apr 12 2020, 3:11 AM · Restricted Project, Restricted Project
sylvestre.ledru added a reviewer for D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`: lebedev.ri.
Apr 12 2020, 3:11 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

LGTM! thanks

Apr 12 2020, 3:11 AM · Restricted Project, Restricted Project

Apr 11 2020

sylvestre.ledru added a comment to D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`.

please add this to the release notes too :)
something like "new option -allow-enabling-alpha-checkers added to run-clang-tidy to enable alpha checkers"

Apr 11 2020, 11:43 AM · Restricted Project, Restricted Project

Apr 10 2020

sylvestre.ledru added inline comments to D76471: Remap the target SDK directory to the host SDK directory.
Apr 10 2020, 2:08 AM · Restricted Project

Apr 7 2020

sylvestre.ledru added a comment to D77574: [OpenMP] Fix layering problem with FrontendOpenMP.

@lebedev.ri @jdoerfert Looks like it might have caused:
https://bugs.llvm.org/show_bug.cgi?id=45453

Apr 7 2020, 1:03 AM · Restricted Project

Apr 6 2020

sylvestre.ledru added a comment to D68554: [clang-format] Proposal for clang-format to give compiler style warnings.

I reported a small issue here: https://bugs.llvm.org/show_bug.cgi?id=45441

Apr 6 2020, 1:36 AM · Restricted Project, Restricted Project, Restricted Project

Apr 4 2020

sylvestre.ledru added a comment to D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments.

You used codespell for this?
Thanks

Apr 4 2020, 3:40 AM · Restricted Project, Restricted Project

Apr 1 2020

sylvestre.ledru committed rGc6a65bb93f21: clagn-tidy/doc: Add a link to readability-static-accessed-through-instance from… (authored by sylvestre.ledru).
clagn-tidy/doc: Add a link to readability-static-accessed-through-instance from…
Apr 1 2020, 8:15 AM
sylvestre.ledru added a comment to D75171: [Analyzer] Fix for incorrect use of container and iterator checkers.

@baloghadamsoftware @Szelethus it would be great to have the name of the checkers in the error message
The error is "error: checker cannot be enabled with analyzer option 'aggressive-binary-operation-simplification' == false"
and I had to look at this patch to understand that it is about iterator

Apr 1 2020, 1:40 AM · Restricted Project

Mar 30 2020

sylvestre.ledru added a comment to rGa75f8d98d7ac: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some….

Could you please have a look to this regression:
https://bugs.llvm.org/show_bug.cgi?id=45357

Mar 30 2020, 8:03 AM

Mar 27 2020

sylvestre.ledru added a comment to D76952: Add mention of advantages of `arc` in the Phabricator doc..

Thanks for the doc update :)

Mar 27 2020, 2:16 PM · Restricted Project
sylvestre.ledru accepted D76952: Add mention of advantages of `arc` in the Phabricator doc..
Mar 27 2020, 2:16 PM · Restricted Project

Mar 25 2020

sylvestre.ledru committed rG4b428e8f18c7: Convert old python3 cgi method into the new html one (authored by Gianfranco Costamagna <costamagnagianfranco@yahoo.it>).
Convert old python3 cgi method into the new html one
Mar 25 2020, 2:40 PM
sylvestre.ledru closed D76126: Convert old python3 cgi method into the new html one.
Mar 25 2020, 2:39 PM · Restricted Project

Mar 22 2020

sylvestre.ledru committed rG72fd1033ea57: Doc: Links should use https (authored by sylvestre.ledru).
Doc: Links should use https
Mar 22 2020, 3:02 PM
sylvestre.ledru committed rG986051749cb1: doc: use the right url to bugzilla (authored by sylvestre.ledru).
doc: use the right url to bugzilla
Mar 22 2020, 3:02 PM
sylvestre.ledru committed rGea4ec1720806: update of the llvm doc: we moved to git (authored by sylvestre.ledru).
update of the llvm doc: we moved to git
Mar 22 2020, 3:01 PM
sylvestre.ledru committed rG2476548dd5ff: clang/release notes: s/Subversion/git/ (authored by sylvestre.ledru).
clang/release notes: s/Subversion/git/
Mar 22 2020, 2:29 PM
sylvestre.ledru committed rG7cfd5de61b81: clang/release notes: s/Subversion/git/ (authored by sylvestre.ledru).
clang/release notes: s/Subversion/git/
Mar 22 2020, 2:29 PM

Mar 13 2020

sylvestre.ledru created D76126: Convert old python3 cgi method into the new html one.
Mar 13 2020, 5:06 AM · Restricted Project
sylvestre.ledru updated the summary of D76126: Convert old python3 cgi method into the new html one.
Mar 13 2020, 5:06 AM · Restricted Project

Mar 11 2020

sylvestre.ledru updated the diff for D75985: clangd doc: Show a test case for clangd with some commands.

fix some typo + desc

Mar 11 2020, 9:37 AM · Restricted Project
sylvestre.ledru added a comment to D75985: clangd doc: Show a test case for clangd with some commands.

Good question :)
I have been wearing two hats here.

Mar 11 2020, 9:37 AM · Restricted Project
sylvestre.ledru updated the diff for D75985: clangd doc: Show a test case for clangd with some commands.

Add a link to the doc

Mar 11 2020, 5:44 AM · Restricted Project
sylvestre.ledru created D75985: clangd doc: Show a test case for clangd with some commands.
Mar 11 2020, 5:44 AM · Restricted Project

Mar 5 2020

sylvestre.ledru committed rG50eedc134a21: clang-format release notes: Document the improvement with the… (authored by sylvestre.ledru).
clang-format release notes: Document the improvement with the…
Mar 5 2020, 1:12 PM
sylvestre.ledru added a comment to D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions.

@hans done here: https://github.com/llvm/llvm-project/commit/50eedc134a219ef6d2345e4efc5471a2e3824223 :)

Mar 5 2020, 1:12 PM · Restricted Project, Restricted Project, Restricted Project

Mar 1 2020

sylvestre.ledru updated subscribers of D72911: clang-format: fix spacing in `operator const char*()`.

@krasimir @MyDeveloperDay @hans Looks like it is a regression from https://reviews.llvm.org/D72911
and the fix isn't in 10.0rc2.
Should we take it?

Mar 1 2020, 2:27 PM · Restricted Project
sylvestre.ledru updated subscribers of D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions.

@MyDeveloperDay @hans what about adding this to the release notes?
I was trying clang-format 10 on Firefox code base and I noticed this change which isn't documented in
https://prereleases.llvm.org/10.0.0/rc1/tools/clang/docs/ReleaseNotes.html#clang-format
(I can do it if you want)

Mar 1 2020, 2:21 PM · Restricted Project, Restricted Project, Restricted Project

Feb 17 2020

sylvestre.ledru committed rG7ae1347fb259: clang analyzer: Fix the webpage rendering (authored by sylvestre.ledru).
clang analyzer: Fix the webpage rendering
Feb 17 2020, 1:06 AM

Feb 6 2020

sylvestre.ledru added a comment to D68720: Support -fstack-clash-protection for x86.

Any plans to merge this feature to 10 release?

Feb 6 2020, 10:29 AM · Restricted Project, Restricted Project

Feb 1 2020

sylvestre.ledru committed rG2eb80a99a2c6: Make StringRef's std::string conversion operator explicit The build is currenly… (authored by sylvestre.ledru).
Make StringRef's std::string conversion operator explicit The build is currenly…
Feb 1 2020, 7:08 AM

Jan 14 2020

sylvestre.ledru added a comment to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.

I run the new check on LibreOffice codebase with the option CharTypdefsToIgnore = "sal_Int8".
The check produced 32 findings.

Jan 14 2020, 12:55 AM · Restricted Project, Restricted Project

Jan 10 2020

sylvestre.ledru committed rG68cd283f3b07: clang-tidy doc: unbreak the CI (authored by sylvestre.ledru).
clang-tidy doc: unbreak the CI
Jan 10 2020, 1:29 PM
sylvestre.ledru committed rGfaeeb71a1734: clang-tidy doc: Refresh the list of checkers and polish the script (authored by sylvestre.ledru).
clang-tidy doc: Refresh the list of checkers and polish the script
Jan 10 2020, 1:11 PM
sylvestre.ledru committed rGf3db1aad2796: MakeUniqueCheck.cpp: explicit the fact that there is an autofix for this checker (authored by sylvestre.ledru).
MakeUniqueCheck.cpp: explicit the fact that there is an autofix for this checker
Jan 10 2020, 1:11 PM
sylvestre.ledru added a comment to D68720: Support -fstack-clash-protection for x86.

@craig.topper do you think there is a chance that this change could be part of clang-10 ?
Thanks

Jan 10 2020, 8:30 AM · Restricted Project, Restricted Project

Jan 9 2020

sylvestre.ledru committed rGb38d0d5bdb35: clang-tidy doc - remove the widths (authored by sylvestre.ledru).
clang-tidy doc - remove the widths
Jan 9 2020, 11:13 PM
sylvestre.ledru committed rG0c195ef7c62d: phab doc: Replace or remove references to svn (authored by sylvestre.ledru).
phab doc: Replace or remove references to svn
Jan 9 2020, 1:32 PM
sylvestre.ledru committed rGdbfc516d1f16: phab doc: also document 'arc land' (authored by sylvestre.ledru).
phab doc: also document 'arc land'
Jan 9 2020, 1:23 PM
sylvestre.ledru committed rG004ae200a5a8: phab doc: remove the svn section (authored by sylvestre.ledru).
phab doc: remove the svn section
Jan 9 2020, 1:23 PM
sylvestre.ledru committed rGc348a2674b57: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix (authored by sylvestre.ledru).
[clang-tidy] Refresh the add_new_check.py now that we use a table + autofix
Jan 9 2020, 1:13 PM
sylvestre.ledru closed D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.
Jan 9 2020, 1:13 PM · Restricted Project, Restricted Project