Page MenuHomePhabricator

sylvestre.ledru (Sylvestre Ledru)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2013, 1:12 AM (481 w, 18 h)

Recent Activity

Tue, May 24

sylvestre.ledru committed rG1e2b746390e3: Revert "[TableGen] Remove code beads" (authored by sylvestre.ledru).
Revert "[TableGen] Remove code beads"
Tue, May 24, 5:20 AM · Restricted Project, Restricted Project
sylvestre.ledru added a reverting change for rGf50be3d21808: [TableGen] Remove code beads: rG1e2b746390e3: Revert "[TableGen] Remove code beads".
Tue, May 24, 5:20 AM · Restricted Project, Restricted Project

Mon, May 23

sylvestre.ledru committed rG6f4dc5dae605: Add support of the next Ubuntu (Ubuntu 22.10 - Kinetic Kudu) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 22.10 - Kinetic Kudu)
Mon, May 23, 4:52 AM · Restricted Project, Restricted Project
sylvestre.ledru committed rGa02000611a8f: Add support of the next Debian (Debian 13 - Trixie) (authored by sylvestre.ledru).
Add support of the next Debian (Debian 13 - Trixie)
Mon, May 23, 4:52 AM · Restricted Project, Restricted Project

Sun, May 22

sylvestre.ledru added a comment to D123901: [LLVM][Casting.h] Update dyn_cast machinery to provide more control over how the casting is performed..

@bzcheeseman FYI, this is breaking the build with gcc 6 (for Debian stretch)
if you are aware of a simple fix, it would be appreciated
See https://github.com/llvm/llvm-project/issues/55626

Sun, May 22, 9:49 AM · Restricted Project, Restricted Project

Sun, May 1

sylvestre.ledru committed rGee4ac3a856a6: doc: update of the adv build doc now that clang is in tree too (authored by sylvestre.ledru).
doc: update of the adv build doc now that clang is in tree too
Sun, May 1, 2:00 PM · Restricted Project, Restricted Project

Mar 10 2022

sylvestre.ledru committed rG54d7fde46e8a: llvm-ifs doc: Replace a utf-8 char by a more classic one (authored by sylvestre.ledru).
llvm-ifs doc: Replace a utf-8 char by a more classic one
Mar 10 2022, 1:45 PM · Restricted Project

Feb 22 2022

sylvestre.ledru added inline comments to D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON.
Feb 22 2022, 12:34 AM · Restricted Project, Restricted Project, Restricted Project

Feb 15 2022

sylvestre.ledru added a comment to D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path.

Could you please stop with the pings? and chat directly ? (It seems that you are colleagues?!)

Feb 15 2022, 2:23 PM · Restricted Project

Feb 12 2022

sylvestre.ledru added a comment to D7982: [clang-tidy] Add readability-duplicate-include check.

Thanks for this, it found 74 occurrences of this in the firefox code base
https://hg.mozilla.org/mozilla-central/rev/b07f125d09fd

Feb 12 2022, 7:36 AM · Restricted Project

Feb 8 2022

sylvestre.ledru committed rGed76de7d9e69: README: Point to the discourse & discord forums (authored by sylvestre.ledru).
README: Point to the discourse & discord forums
Feb 8 2022, 1:41 PM
sylvestre.ledru closed D119279: README: Point to the discourse & discord forums.
Feb 8 2022, 1:41 PM · Restricted Project
sylvestre.ledru added inline comments to D119279: README: Point to the discourse & discord forums.
Feb 8 2022, 1:40 PM · Restricted Project
sylvestre.ledru updated the diff for D119279: README: Point to the discourse & discord forums.

Add IRC

Feb 8 2022, 1:39 PM · Restricted Project
sylvestre.ledru requested review of D119279: README: Point to the discourse & discord forums.
Feb 8 2022, 12:56 PM · Restricted Project
sylvestre.ledru committed rGf2c2e924e73a: Fix a typo (occured => occurred) (authored by sylvestre.ledru).
Fix a typo (occured => occurred)
Feb 8 2022, 12:35 PM
sylvestre.ledru added a comment to D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON.

Log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console

Feb 8 2022, 1:20 AM · Restricted Project
sylvestre.ledru added a comment to D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON.

Debian is still broken with this patch on -14:

lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to 'inflateInit2_' lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to 'inflate' lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to 'inflateEnd'
Feb 8 2022, 1:19 AM · Restricted Project

Feb 3 2022

sylvestre.ledru added a comment to D112940: Add a tool for diffing instruction count + stack size remarks.

if this isn't the case, it would be nice to add this to the release notes :)

Feb 3 2022, 12:17 AM · Restricted Project

Feb 2 2022

sylvestre.ledru committed rGb4bb622fc94a: Also document -arch as -arch is mac specific (authored by sylvestre.ledru).
Also document -arch as -arch is mac specific
Feb 2 2022, 7:24 AM
sylvestre.ledru closed D60380: Also document -arch as -arch is mac specific.
Feb 2 2022, 7:23 AM · Restricted Project
sylvestre.ledru updated the diff for D60380: Also document -arch as -arch is mac specific.

add .

Feb 2 2022, 7:21 AM · Restricted Project
sylvestre.ledru updated the diff for D60380: Also document -arch as -arch is mac specific.

Take in account Serge's comment

Feb 2 2022, 7:19 AM · Restricted Project

Jan 27 2022

sylvestre.ledru committed rGfd71493ff060: Add missing namespace to PPCLinux.cpp (authored by glandium).
Add missing namespace to PPCLinux.cpp
Jan 27 2022, 12:27 AM
sylvestre.ledru closed D118211: Add missing namespace to PPCLinux.cpp.
Jan 27 2022, 12:26 AM · Restricted Project

Jan 19 2022

sylvestre.ledru added a comment to D114722: [LLDB] Fix Python GIL-not-held issues.

Seems that it broke apt.llvm.org on ubuntu bionic with Python 3.6:
I reported this issue: https://github.com/llvm/llvm-project/issues/53291

Jan 19 2022, 1:51 AM · Restricted Project

Dec 31 2021

sylvestre.ledru accepted D116429: Do not install MLIR Object libraries used for assembling the C API (NFC).

thanks
I am doing an ugly rm -rf to remove them after install ;)

Dec 31 2021, 1:55 AM · Restricted Project

Dec 16 2021

sylvestre.ledru committed rG427f6e11e68a: [lldb][docs] Update instructions for building libc++ (authored by torarnv).
[lldb][docs] Update instructions for building libc++
Dec 16 2021, 7:51 AM
sylvestre.ledru closed D115877: [lldb][docs] Update instructions for building libc++.
Dec 16 2021, 7:51 AM · Restricted Project
sylvestre.ledru added a comment to D115877: [lldb][docs] Update instructions for building libc++.

I will push it for you. What do you want to use as full name + email ?

Dec 16 2021, 7:47 AM · Restricted Project
sylvestre.ledru accepted D115877: [lldb][docs] Update instructions for building libc++.

LGTM, thanks!

Dec 16 2021, 7:39 AM · Restricted Project
sylvestre.ledru accepted D115852: Passthrough LLVM_USE_LLD LLVM_USE_LINKER into runtimes.

Excellent, thanks

Dec 16 2021, 4:48 AM · Restricted Project

Dec 15 2021

sylvestre.ledru added a comment to D115812: Support LLVM_USE_LINKER and LLVM_ENABLE_LLD in compiler-rt.

Doesn't fix the issue https://github.com/llvm/llvm-project/issues/42339

[ 44%] Linking CXX shared library /root/llvm-project/build-llvm/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.hwasan.so
cd /root/llvm-project/build-llvm/runtimes/runtimes-bins/compiler-rt/lib/hwasan && /usr/bin/cmake -E cmake_link_script CMakeFiles/clang_rt.hwasan-dynamic-x86_64.dir/link.txt --verbose=1
/root/llvm-project/build-llvm/./bin/clang++ --target=x86_64-unknown-linux-gnu -fPIC  -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wall -std=c++14 -Wno-unused-parameter -g  -m64 -nodefaultlibs -Wl,-z,text -nostdlib++ -Wl,--version-script,/root/llvm-project/build-llvm/runtimes/runtimes-bins/compiler-rt/lib/hwasan/clang_rt.hwasan-dynamic-x86_64.vers -Wl,-rpath-link,/root/llvm-project/build-llvm/./lib   -Wl,-z,defs -Wl,-z,nodelete -shared -Wl,-soname,libclang_rt.hwasan.so -o /root/llvm-project/build-llvm/lib/clang/14.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.hwasan.so CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_allocator.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_allocation_functions.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_dynamic_shadow.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_exceptions.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_fuchsia.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_globals.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_interceptors.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_interceptors_vfork.S.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_linux.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_memintrinsics.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_poisoning.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_report.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_setjmp_aarch64.S.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_setjmp_x86_64.S.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_tag_mismatch_aarch64.S.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_thread.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_thread_list.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_type_test.cpp.o CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan_new_delete.cpp.o ../interception/CMakeFiles/RTInterception.x86_64.dir/interception_linux.cpp.o ../interception/CMakeFiles/RTInterception.x86_64.dir/interception_mac.cpp.o ../interception/CMakeFiles/RTInterception.x86_64.dir/interception_win.cpp.o ../interception/CMakeFiles/RTInterception.x86_64.dir/interception_type_test.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_allocator.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_common.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_deadlock_detector1.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_deadlock_detector2.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_errno.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_file.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_flags.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_flag_parser.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_fuchsia.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_libc.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_libignore.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_linux.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_linux_s390.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_mac.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_mutex.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_netbsd.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_platform_limits_freebsd.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_platform_limits_linux.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_platform_limits_netbsd.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_platform_limits_posix.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_platform_limits_solaris.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_posix.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_printf.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_procmaps_common.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_procmaps_bsd.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_procmaps_fuchsia.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_procmaps_linux.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_procmaps_mac.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_procmaps_solaris.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_solaris.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_stoptheworld_fuchsia.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_stoptheworld_mac.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_suppressions.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_tls_get_addr.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_thread_registry.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_type_traits.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_win.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_termination.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonLibc.x86_64.dir/sanitizer_common_libcdep.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonLibc.x86_64.dir/sanitizer_allocator_checks.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonLibc.x86_64.dir/sanitizer_linux_libcdep.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonLibc.x86_64.dir/sanitizer_mac_libcdep.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonLibc.x86_64.dir/sanitizer_posix_libcdep.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonLibc.x86_64.dir/sanitizer_stoptheworld_linux_libcdep.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonLibc.x86_64.dir/sanitizer_stoptheworld_netbsd_libcdep.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonCoverage.x86_64.dir/sancov_flags.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonCoverage.x86_64.dir/sanitizer_coverage_fuchsia.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonCoverage.x86_64.dir/sanitizer_coverage_libcdep_new.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonCoverage.x86_64.dir/sanitizer_coverage_win_sections.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_allocator_report.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_chained_origin_depot.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_stack_store.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_stackdepot.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_stacktrace.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_stacktrace_libcdep.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_stacktrace_printer.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_stacktrace_sparc.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_symbolizer.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_symbolizer_libbacktrace.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_symbolizer_libcdep.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_symbolizer_mac.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_symbolizer_markup.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_symbolizer_posix_libcdep.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_symbolizer_report.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_symbolizer_win.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_unwind_linux_libcdep.cpp.o ../sanitizer_common/CMakeFiles/RTSanitizerCommonSymbolizer.x86_64.dir/sanitizer_unwind_win.cpp.o ../ubsan/CMakeFiles/RTUbsan.x86_64.dir/ubsan_diag.cpp.o ../ubsan/CMakeFiles/RTUbsan.x86_64.dir/ubsan_init.cpp.o ../ubsan/CMakeFiles/RTUbsan.x86_64.dir/ubsan_flags.cpp.o ../ubsan/CMakeFiles/RTUbsan.x86_64.dir/ubsan_handlers.cpp.o ../ubsan/CMakeFiles/RTUbsan.x86_64.dir/ubsan_monitor.cpp.o ../ubsan/CMakeFiles/RTUbsan.x86_64.dir/ubsan_value.cpp.o ../ubsan/CMakeFiles/RTUbsan_cxx.x86_64.dir/ubsan_handlers_cxx.cpp.o ../ubsan/CMakeFiles/RTUbsan_cxx.x86_64.dir/ubsan_type_hash.cpp.o ../ubsan/CMakeFiles/RTUbsan_cxx.x86_64.dir/ubsan_type_hash_itanium.cpp.o ../ubsan/CMakeFiles/RTUbsan_cxx.x86_64.dir/ubsan_type_hash_win.cpp.o CMakeFiles/RTHwasan_dynamic_version_script_dummy.x86_64.dir/dummy.cpp.o -Wl,-rpath,"\$ORIGIN/../lib:/root/llvm-project/build-llvm/./lib" -lstdc++ -lgcc_s -lc -ldl -lrt -lm -lpthread 
/usr/bin/ld: CMakeFiles/RTHwasan_dynamic.x86_64.dir/hwasan.cpp.o: relocation R_X86_64_PC32 against undefined symbol `__ehdr_start' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: nonrepresentable section on output
Dec 15 2021, 2:26 PM · Restricted Project

Dec 14 2021

sylvestre.ledru added a comment to D115664: [OpenMP][libomp] Fix compile errors with new KMP_HW_SUBSET changes.

it fixed the build issue!

Dec 14 2021, 5:43 AM · Restricted Project

Dec 13 2021

sylvestre.ledru committed rG9769340905d0: [OpenMP][libomp] Fix compile errors with new KMP_HW_SUBSET changes (authored by jlpeyton).
[OpenMP][libomp] Fix compile errors with new KMP_HW_SUBSET changes
Dec 13 2021, 11:33 PM
sylvestre.ledru added a comment to D115664: [OpenMP][libomp] Fix compile errors with new KMP_HW_SUBSET changes.

I pushed it to unbreak the arm64 builds

Dec 13 2021, 11:33 PM · Restricted Project
sylvestre.ledru closed D115664: [OpenMP][libomp] Fix compile errors with new KMP_HW_SUBSET changes.
Dec 13 2021, 11:33 PM · Restricted Project
sylvestre.ledru added a comment to D115664: [OpenMP][libomp] Fix compile errors with new KMP_HW_SUBSET changes.

looks good to me. please land this asap as it is breaking arm64.
see:
https://github.com/llvm/llvm-project/issues/52668

Dec 13 2021, 3:12 PM · Restricted Project

Dec 11 2021

sylvestre.ledru accepted D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie.
Dec 11 2021, 10:21 AM · Restricted Project, Restricted Project

Nov 29 2021

sylvestre.ledru committed rGd96f92ff16ed: fix typos in comments (authored by Zhuo Zhang <imzhuo@foxmail.com>).
fix typos in comments
Nov 29 2021, 5:07 AM

Nov 24 2021

sylvestre.ledru added a reviewer for D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie: serge-sans-paille.
Nov 24 2021, 4:44 AM · Restricted Project, Restricted Project

Nov 23 2021

sylvestre.ledru added a comment to D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path.

I am not sure why you are pinging this review often?! Maybe chat with people who gave you feedback before directly?!

Nov 23 2021, 5:26 AM · Restricted Project
sylvestre.ledru resigned from D95114: HowToReleaseLLVM: Add annual release schedule template.
Nov 23 2021, 5:20 AM · Restricted Project
sylvestre.ledru added a comment to D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie.

Maybe add it to the release notes too?

Nov 23 2021, 5:18 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag.

Actually, it breaks on all Debian.
Could you please revert it?

Nov 23 2021, 4:46 AM · Restricted Project
sylvestre.ledru added a comment to D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag.

Full log:
https://llvm-jenkins.debian.net/view/Debian%20sid/job/llvm-toolchain-binaries/architecture=amd64,distribution=unstable,label=amd64/104/consoleFull

Nov 23 2021, 4:43 AM · Restricted Project
sylvestre.ledru added a comment to D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag.

As mentioned in
https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b#commitcomment-60741407

Nov 23 2021, 4:42 AM · Restricted Project

Oct 26 2021

sylvestre.ledru requested review of D112519: parallel-libs: remove some artifacts.
Oct 26 2021, 12:41 AM · Restricted Project, Restricted Project

Oct 23 2021

sylvestre.ledru committed rGa709787cd988: Add support of the next Ubuntu (Ubuntu 22.04 - Jammy Jellyfish) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 22.04 - Jammy Jellyfish)
Oct 23 2021, 2:57 PM
sylvestre.ledru added a comment to D102872: Fix lldb-server build failure on mips.

Maybe it would be better to disable the binary completely (in cmake) for unsupported architectures instead?

Oct 23 2021, 1:38 AM · Restricted Project

Oct 22 2021

sylvestre.ledru committed rGfd5e3f36f218: Replace references to Makefile.sphinx (authored by sylvestre.ledru).
Replace references to Makefile.sphinx
Oct 22 2021, 6:32 AM
sylvestre.ledru closed D112299: Replace references to Makefile.sphinx.
Oct 22 2021, 6:32 AM · Restricted Project, Restricted Project
sylvestre.ledru requested review of D112299: Replace references to Makefile.sphinx.
Oct 22 2021, 2:17 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D112030: [docs] Remove Makefile.sphinx files.

Adjustment made on my side:
https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/commit/daf38c1634954d9aad7a1393eef0828c57f41a53

Oct 22 2021, 2:09 AM · Restricted Project, Restricted Project, Restricted Project

Oct 20 2021

sylvestre.ledru accepted D112030: [docs] Remove Makefile.sphinx files.

I don't need any time, please land it when you want, I will adjust later :)

Oct 20 2021, 1:53 PM · Restricted Project, Restricted Project, Restricted Project

Oct 18 2021

sylvestre.ledru added a comment to D112030: [docs] Remove Makefile.sphinx files.

I am using them but I can move to sphinx calls.

Oct 18 2021, 1:44 PM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

This change caused libclc to fail to build on old ubuntu (using llvm-spir 10.0.0-1)
See:
https://bugs.llvm.org/show_bug.cgi?id=52200

Oct 18 2021, 6:31 AM · Restricted Project
sylvestre.ledru added a comment to rGc773f6501dba: [NFC] Remove Block-ABI-Apple.txt.

This way:

make -f Makefile.sphinx
Oct 18 2021, 6:20 AM
sylvestre.ledru added a comment to rGc773f6501dba: [NFC] Remove Block-ABI-Apple.txt.

@xgupta maybe it was a NFC but you still broke some CI like apt.llvm.org

Oct 18 2021, 5:59 AM
sylvestre.ledru committed rGcbf778a592fa: Remove also Block-ABI-Apple.txt from the Makefile (authored by sylvestre.ledru).
Remove also Block-ABI-Apple.txt from the Makefile
Oct 18 2021, 5:56 AM

Oct 16 2021

sylvestre.ledru added a comment to D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux.

I agree with @lebedev.ri : it is causing significant regressions which aren't trivial to debug for someone building firefox

Oct 16 2021, 5:53 AM · Restricted Project, Restricted Project

Oct 10 2021

sylvestre.ledru committed rGb07ea8a967c5: clang release notes: improve the wording (authored by sylvestre.ledru).
clang release notes: improve the wording
Oct 10 2021, 1:26 PM
sylvestre.ledru added a comment to D111215: clang release notes: document the -Wbool-operation improvement.

@Quuxplusone fixed, thanks

Oct 10 2021, 1:26 PM · Restricted Project
sylvestre.ledru committed rG9c8f950a0400: clang release notes: document the -Wbool-operation improvement (authored by sylvestre.ledru).
clang release notes: document the -Wbool-operation improvement
Oct 10 2021, 12:29 PM
sylvestre.ledru closed D111215: clang release notes: document the -Wbool-operation improvement.
Oct 10 2021, 12:28 PM · Restricted Project

Oct 6 2021

sylvestre.ledru updated the diff for D111215: clang release notes: document the -Wbool-operation improvement.

add "which have side effects"

Oct 6 2021, 3:08 AM · Restricted Project
sylvestre.ledru added a comment to D111215: clang release notes: document the -Wbool-operation improvement.

@xbolva00 sorry but you would like

Oct 6 2021, 3:03 AM · Restricted Project
sylvestre.ledru updated the diff for D111215: clang release notes: document the -Wbool-operation improvement.

Take in account the comment

Oct 6 2021, 2:54 AM · Restricted Project
sylvestre.ledru added a comment to D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects.

It found a few issues on Firefox:
https://bugzilla.mozilla.org/show_bug.cgi?id=1734285

Oct 6 2021, 2:41 AM · Restricted Project
sylvestre.ledru requested review of D111215: clang release notes: document the -Wbool-operation improvement.
Oct 6 2021, 2:39 AM · Restricted Project

Oct 4 2021

sylvestre.ledru committed rGc788bea24355: libc++: document in the release notes that a C++20 compiler is expected (authored by sylvestre.ledru).
libc++: document in the release notes that a C++20 compiler is expected
Oct 4 2021, 10:03 AM
sylvestre.ledru closed D111043: libc++: document in the release notes that a C++20 compiler is expected.
Oct 4 2021, 10:03 AM · Restricted Project
sylvestre.ledru added a comment to D110338: [libc++] Require a C++20 capable compiler..

For the release notes:
https://reviews.llvm.org/D111043

Oct 4 2021, 2:10 AM · Restricted Project
sylvestre.ledru requested review of D111043: libc++: document in the release notes that a C++20 compiler is expected.
Oct 4 2021, 2:10 AM · Restricted Project

Sep 30 2021

sylvestre.ledru added a comment to D110338: [libc++] Require a C++20 capable compiler..

12 will be merged into 13 and then snapshot :)

Sep 30 2021, 5:09 AM · Restricted Project

Sep 28 2021

sylvestre.ledru added a comment to D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path.

just to make sure I understand, it will also update the install or "just" the dumpmachine option ?

Sep 28 2021, 3:18 PM · Restricted Project
sylvestre.ledru added a comment to D110338: [libc++] Require a C++20 capable compiler..

Yeah, it is ongoing work but it will take a few more days/weeks
here is the work:
https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/merge_requests/73

Sep 28 2021, 2:12 PM · Restricted Project
sylvestre.ledru added a comment to D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux.

if you are talking about apt.llvm.org, I think I fixed most of the issues now.

Sep 28 2021, 10:48 AM · Restricted Project, Restricted Project

Sep 26 2021

sylvestre.ledru accepted D110521: Make analyze-cc path discovery sensible to symlinks.

thanks!

Sep 26 2021, 11:32 PM · Restricted Project

Sep 25 2021

sylvestre.ledru added a comment to D89013: [libcxx] Support per-target __config_site in per-target runtime build.

@phosek
It was probably my fault (mix of different in-tree / out of tree builds)
Quick question, why the path to __config_site contains this triple
x86_64-pc-linux-gnu
(in /usr/lib/llvm-14/include/x86_64-pc-linux-gnu/c++/v1/__config_site)
when it is usually:
x86_64-linux-gnu
(does not contain -pc)
thanks?

Sep 25 2021, 3:50 AM · Restricted Project, Restricted Project, Restricted Project

Sep 23 2021

sylvestre.ledru added a comment to D89013: [libcxx] Support per-target __config_site in per-target runtime build.

How was the toolchain in /home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot-14~++20210922093928+5da21338bcd0/build-llvm built?

Sep 23 2021, 2:06 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru added a comment to D89013: [libcxx] Support per-target __config_site in per-target runtime build.

Building with this patch Debian packages is failing with:

Sep 23 2021, 12:58 AM · Restricted Project, Restricted Project, Restricted Project
sylvestre.ledru committed rG08ef24f6abdf: Wrap xar/xar.h include in extern "C" block (authored by glandium).
Wrap xar/xar.h include in extern "C" block
Sep 23 2021, 12:38 AM
sylvestre.ledru closed D110224: Wrap xar/xar.h include in extern "C" block.
Sep 23 2021, 12:37 AM · Restricted Project, Restricted Project

Sep 21 2021

sylvestre.ledru accepted D110134: [debuginfo-test][cross-project-tests] Release note for new project name.

I don't have a strong opinion :)

Sep 21 2021, 1:47 AM · Restricted Project
sylvestre.ledru abandoned D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes.

https://github.com/llvm/llvm-project/blob/release/13.x/clang/docs/ReleaseNotes.rst#new-compiler-flags

Sep 21 2021, 1:46 AM · Restricted Project
sylvestre.ledru added a comment to D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes.

it landed

Sep 21 2021, 1:46 AM · Restricted Project
sylvestre.ledru committed rGeccd477ce312: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables (authored by sylvestre.ledru).
Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables
Sep 21 2021, 1:45 AM
sylvestre.ledru closed D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables.
Sep 21 2021, 1:45 AM · Restricted Project
sylvestre.ledru updated the diff for D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables.

Rebase of the patch

Sep 21 2021, 1:44 AM · Restricted Project
sylvestre.ledru closed D109023: libclang: Document the soname change in the release notes.

it landed

Sep 21 2021, 1:41 AM · Restricted Project
sylvestre.ledru added inline comments to D110134: [debuginfo-test][cross-project-tests] Release note for new project name.
Sep 21 2021, 1:39 AM · Restricted Project

Sep 19 2021

sylvestre.ledru committed rGb7ec8f3dcbcd: llvm/cmake: fix a typo (authored by sylvestre.ledru).
llvm/cmake: fix a typo
Sep 19 2021, 3:18 AM

Sep 18 2021

sylvestre.ledru committed rG8919e7b251f3: llvm doc: remove the old reference to subversion and add a link to the GH repo… (authored by sylvestre.ledru).
llvm doc: remove the old reference to subversion and add a link to the GH repo…
Sep 18 2021, 3:46 AM
sylvestre.ledru committed rG23763dd7c9ea: llvm doc: subversion isn't necessary in this example (authored by sylvestre.ledru).
llvm doc: subversion isn't necessary in this example
Sep 18 2021, 3:46 AM
sylvestre.ledru added a comment to D95339: [RFC][test] Adapt debug-info lit framework for more general purposes - part 1.

I pushed this small change to adjust the doc https://github.com/llvm/llvm-project/commit/2790498178b4bb7c8594c936d512410d55b91d98

Sep 18 2021, 12:57 AM · Restricted Project
sylvestre.ledru committed rG2790498178b4: Adjust the doc after the renaming of debuginfo-tests => cross-project-tests (authored by sylvestre.ledru).
Adjust the doc after the renaming of debuginfo-tests => cross-project-tests
Sep 18 2021, 12:56 AM

Sep 12 2021

sylvestre.ledru accepted D109659: Fix scan-build-py executable lookup path.

LGTM, thanks

Sep 12 2021, 7:34 AM · Restricted Project

Sep 11 2021

sylvestre.ledru added a comment to D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes.

To land in the 13.x branch

Sep 11 2021, 12:38 AM · Restricted Project
sylvestre.ledru requested review of D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes.
Sep 11 2021, 12:37 AM · Restricted Project