sylvestre.ledru (Sylvestre Ledru)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2013, 1:12 AM (272 w, 2 d)

Recent Activity

Apr 9 2018

sylvestre.ledru edited reviewers for D45454: Make __gcov_flush visible outside a shared library, added: marco-c; removed: sylvestre.ledru.
Apr 9 2018, 11:55 PM

Mar 29 2018

sylvestre.ledru updated the diff for D41808: Rename clang link from clang-X.Y to clang-X.

Add to the release notes

Mar 29 2018, 3:03 AM
sylvestre.ledru updated the diff for D41869: Rename llvm library from libLLVM-X.Y to libLLVM-X.

Add to the release notes

Mar 29 2018, 2:44 AM

Mar 21 2018

sylvestre.ledru added a reviewer for D41869: Rename llvm library from libLLVM-X.Y to libLLVM-X: hans.
Mar 21 2018, 3:42 AM
sylvestre.ledru added a reviewer for D41808: Rename clang link from clang-X.Y to clang-X: hans.
Mar 21 2018, 3:42 AM

Mar 20 2018

sylvestre.ledru updated the diff for D41808: Rename clang link from clang-X.Y to clang-X.
Mar 20 2018, 4:14 AM
sylvestre.ledru added a reviewer for D41869: Rename llvm library from libLLVM-X.Y to libLLVM-X: dim.
Mar 20 2018, 1:52 AM

Mar 17 2018

sylvestre.ledru abandoned D30863: [clang-format] make docs/tools/{dump_format_style.py,dump_ast_matchers.py} flake8 compliant.

Looks like it doesn't interest anyone to use coding style on it.

Mar 17 2018, 6:41 AM
sylvestre.ledru updated the diff for D41869: Rename llvm library from libLLVM-X.Y to libLLVM-X.

With llvm-config

Mar 17 2018, 6:34 AM

Mar 8 2018

sylvestre.ledru added a comment to D42624: [clang-tidy] Add a utility Matcher to match the next statement within a statement sequence.

@aaron.ballman Hello, Do you think it is ready to land? Thanks

Mar 8 2018, 12:54 AM · Restricted Project

Feb 26 2018

sylvestre.ledru added a reviewer for D43630: [Driver] Fix search paths on x32: rnk.
Feb 26 2018, 8:51 AM

Feb 12 2018

sylvestre.ledru accepted D42593: GCC compatibility: Ignore -fstack-clash-protection.

Looks good, thanks.

Feb 12 2018, 4:35 AM

Jan 18 2018

sylvestre.ledru updated the diff for D41869: Rename llvm library from libLLVM-X.Y to libLLVM-X.

More things to update (the library name too)

Jan 18 2018, 11:47 AM

Jan 12 2018

sylvestre.ledru updated the diff for D41869: Rename llvm library from libLLVM-X.Y to libLLVM-X.
Jan 12 2018, 10:16 AM

Jan 9 2018

sylvestre.ledru created D41869: Rename llvm library from libLLVM-X.Y to libLLVM-X.
Jan 9 2018, 9:05 AM

Jan 7 2018

sylvestre.ledru added a reviewer for D41808: Rename clang link from clang-X.Y to clang-X: dlj.
Jan 7 2018, 12:22 PM
sylvestre.ledru created D41808: Rename clang link from clang-X.Y to clang-X.
Jan 7 2018, 8:15 AM

Jan 6 2018

sylvestre.ledru added a comment to D41538: [analyzer] Fix some checker's output plist not containing the checker name #2.

It missed the 6.0 branching. Will you try to get it on this branch?
Thanks

Jan 6 2018, 3:51 AM

Dec 21 2017

sylvestre.ledru added a comment to D40610: Flush gcda files before unlocking them.

I added two more reviewers as we would like to get that in trunk before 6.0 branches.

Dec 21 2017, 1:34 AM
sylvestre.ledru added reviewers for D40610: Flush gcda files before unlocking them: rnk, void.
Dec 21 2017, 1:34 AM
sylvestre.ledru added a comment to D38124: Hide some symbols to avoid a crash on shutdown when using code coverage.

I added two more reviewers as we would like to get that in trunk before 6.0 branches.

Dec 21 2017, 1:33 AM · Restricted Project
sylvestre.ledru added reviewers for D38124: Hide some symbols to avoid a crash on shutdown when using code coverage: rnk, void.
Dec 21 2017, 1:32 AM · Restricted Project

Dec 5 2017

sylvestre.ledru added a comment to D40827: [clang-format] Releasenotes for rL319024 : Add option to group multiple #include blocks when sorting includes.

Done!
btw, you should probably request commit permissions ;)

Dec 5 2017, 1:26 AM
sylvestre.ledru updated the summary of D40827: [clang-format] Releasenotes for rL319024 : Add option to group multiple #include blocks when sorting includes.
Dec 5 2017, 1:21 AM
sylvestre.ledru accepted D40827: [clang-format] Releasenotes for rL319024 : Add option to group multiple #include blocks when sorting includes.
Dec 5 2017, 12:15 AM

Dec 4 2017

sylvestre.ledru added a comment to rL319024: [clang-format] Add option to group multiple #include blocks when sorting….

This could be added to the release notes, don't you think?

Dec 4 2017, 1:12 PM

Nov 28 2017

sylvestre.ledru updated the diff for D40453: Add the nvidia-cuda-toolkit Debian package path to search path.
Nov 28 2017, 1:44 PM
sylvestre.ledru updated the diff for D40453: Add the nvidia-cuda-toolkit Debian package path to search path.
Nov 28 2017, 1:30 PM

Nov 27 2017

sylvestre.ledru added a comment to D40453: Add the nvidia-cuda-toolkit Debian package path to search path.

Debian packages don't update the PATH and we are aiming at providing packages working out of the box.

Nov 27 2017, 9:48 AM

Nov 25 2017

sylvestre.ledru created D40453: Add the nvidia-cuda-toolkit Debian package path to search path.
Nov 25 2017, 1:25 AM

Nov 23 2017

sylvestre.ledru added a comment to D38124: Hide some symbols to avoid a crash on shutdown when using code coverage.

@davidxl David, is that ok with you? Can you sign off this change? Thanks

Nov 23 2017, 10:50 PM · Restricted Project

Nov 8 2017

sylvestre.ledru added a comment to D38124: Hide some symbols to avoid a crash on shutdown when using code coverage.

please thank Marco :)

Nov 8 2017, 6:12 AM · Restricted Project
sylvestre.ledru updated the diff for D38124: Hide some symbols to avoid a crash on shutdown when using code coverage.
Nov 8 2017, 5:55 AM · Restricted Project

Nov 7 2017

sylvestre.ledru closed D39717: Always use prctl(PR_SET_PTRACER).
Nov 7 2017, 11:25 PM
sylvestre.ledru updated the summary of D39717: Always use prctl(PR_SET_PTRACER).
Nov 7 2017, 11:25 PM
sylvestre.ledru added a reviewer for D39717: Always use prctl(PR_SET_PTRACER): eugenis.
Nov 7 2017, 1:11 AM

Oct 24 2017

sylvestre.ledru added a comment to D39246: Fix LLVM_LINK_LLVM_DYLIB build (pr35053).

This fixed the issue, thanks!

Oct 24 2017, 11:56 AM

Oct 20 2017

sylvestre.ledru edited reviewers for D28462: clang-format: Add new style option AlignConsecutiveMacros, added: klimek; removed: sylvestre.ledru.
Oct 20 2017, 12:43 AM · Restricted Project

Oct 15 2017

sylvestre.ledru added a comment to D38678: [Sema] Warn about unused variables if we can constant evaluate the initializer..

For the record, this found 5 actual useless variables in Firefox code.

Oct 15 2017, 11:11 AM

Oct 11 2017

sylvestre.ledru added a comment to D37979: ClangFormat - Add one space in inline empty function that can be wrapped on a single line. .

I also see lots of code that uses {}? Thus, it seems like the code base is not very strict, and going either way enforced with clang-format will be nicer?
https://dxr.mozilla.org/mozilla-central/search?q=%22+%7B%7D&redirect=true

Indeed, this is why we are working on enforcing that.
This patch is one of the last change to match exactly our coding style. This is why Andi wrote it.

Oct 11 2017, 11:56 PM

Sep 28 2017

sylvestre.ledru closed D38186: Add the new -Wnull-pointer-arithmetic warnings to the release notes.
Sep 28 2017, 1:02 AM · Restricted Project
sylvestre.ledru abandoned D38346: Add the new -Wnull-pointer-arithmetic warnings to the release notes.
Sep 28 2017, 1:02 AM
sylvestre.ledru accepted D38186: Add the new -Wnull-pointer-arithmetic warnings to the release notes.

Thanks, it makes sense!
Landed in r314387

Sep 28 2017, 1:02 AM · Restricted Project
sylvestre.ledru created D38346: Add the new -Wnull-pointer-arithmetic warnings to the release notes.
Sep 28 2017, 12:59 AM

Sep 26 2017

sylvestre.ledru closed D38224: Don't move llvm.localescape outside the entry block in the GCOV profiling pass.
Sep 26 2017, 3:30 PM
sylvestre.ledru updated the summary of D38224: Don't move llvm.localescape outside the entry block in the GCOV profiling pass.
Sep 26 2017, 3:30 PM

Sep 25 2017

sylvestre.ledru closed D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON.
Sep 25 2017, 7:10 AM
sylvestre.ledru added a comment to D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON.

For the record, this is the same approach as in https://reviews.llvm.org/rL240104

Sep 25 2017, 5:03 AM
sylvestre.ledru created D38228: Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON.
Sep 25 2017, 5:03 AM
sylvestre.ledru added a reviewer for D38224: Don't move llvm.localescape outside the entry block in the GCOV profiling pass: rnk.
Sep 25 2017, 5:03 AM
sylvestre.ledru added a reviewer for D38223: Disable gcov instrumentation of functions using funclet-based exception handling: rnk.
Sep 25 2017, 5:03 AM

Sep 22 2017

sylvestre.ledru created D38186: Add the new -Wnull-pointer-arithmetic warnings to the release notes.
Sep 22 2017, 12:41 PM · Restricted Project
sylvestre.ledru added a comment to D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc.

For the record, Firefox was using this trick. This patch is breaking a ci build (clang trunk + warning as errors)
More information here: https://bugzilla.mozilla.org/show_bug.cgi?id=1402362

Sep 22 2017, 9:02 AM

Sep 21 2017

sylvestre.ledru created D38124: Hide some symbols to avoid a crash on shutdown when using code coverage.
Sep 21 2017, 2:05 AM · Restricted Project

Sep 13 2017

sylvestre.ledru closed D37795: SplitEmptyFunction should be true in the Mozilla coding style.
Sep 13 2017, 1:04 PM
sylvestre.ledru created D37795: SplitEmptyFunction should be true in the Mozilla coding style.
Sep 13 2017, 1:00 AM

Sep 7 2017

sylvestre.ledru closed D37531: Add an usage example of BreakBeforeBraces.
Sep 7 2017, 5:11 AM
sylvestre.ledru closed D37558: Refresh the clang format options doc with the recent changes.
Sep 7 2017, 5:11 AM
sylvestre.ledru created D37558: Refresh the clang format options doc with the recent changes.
Sep 7 2017, 3:09 AM
sylvestre.ledru updated the diff for D37531: Add an usage example of BreakBeforeBraces.

Thanks. I need more coffee.

Sep 7 2017, 3:07 AM

Sep 6 2017

sylvestre.ledru created D37531: Add an usage example of BreakBeforeBraces.
Sep 6 2017, 1:33 PM

Sep 5 2017

sylvestre.ledru added a comment to rL312125: clang-format: Add preprocessor directive indentation.

Added in the 6.0 release notes in r312535

Sep 5 2017, 6:58 AM

Aug 30 2017

sylvestre.ledru added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Any news on this?
cc @djasper

Aug 30 2017, 2:24 AM · Restricted Project

Aug 12 2017

sylvestre.ledru closed D34824: clang-format: add an option -verbose to list the files being processed.
Aug 12 2017, 8:16 AM · Restricted Project
sylvestre.ledru reopened D34824: clang-format: add an option -verbose to list the files being processed.

actually, arc commit never landed this change :(

Aug 12 2017, 8:14 AM · Restricted Project

Jul 30 2017

sylvestre.ledru added a comment to D36051: [clang-tidy] List the checkers with autofix.

Good ideas guys. I will try to update list.rst to a table with the extra information.

Jul 30 2017, 6:42 AM

Jul 29 2017

sylvestre.ledru created D36051: [clang-tidy] List the checkers with autofix.
Jul 29 2017, 2:48 PM

Jul 19 2017

sylvestre.ledru added a comment to D35331: [Solaris] enable --whole-archive for shared-library build, disable --version-script for Solaris-ld.

done in revision r308490

Jul 19 2017, 9:09 AM
sylvestre.ledru closed D35331: [Solaris] enable --whole-archive for shared-library build, disable --version-script for Solaris-ld.
Jul 19 2017, 9:04 AM

Jul 18 2017

sylvestre.ledru added a comment to D35331: [Solaris] enable --whole-archive for shared-library build, disable --version-script for Solaris-ld.

I am not owner of this code but this seems reasonable if solaris doesn't support this option.

Jul 18 2017, 1:07 PM
sylvestre.ledru closed D34824: clang-format: add an option -verbose to list the files being processed.
Jul 18 2017, 12:23 PM · Restricted Project
sylvestre.ledru updated the diff for D34824: clang-format: add an option -verbose to list the files being processed.

Fixed, thanks for spotting the mistake.
Looks like we could improve the testsuite as my mistake hasn't been catched.

Jul 18 2017, 6:29 AM · Restricted Project

Jul 17 2017

sylvestre.ledru closed D35462: Also add the option -no-pie (like -nopie).
Jul 17 2017, 11:55 PM

Jul 16 2017

sylvestre.ledru created D35462: Also add the option -no-pie (like -nopie).
Jul 16 2017, 8:34 AM

Jul 15 2017

sylvestre.ledru added inline comments to D34824: clang-format: add an option -verbose to list the files being processed.
Jul 15 2017, 10:38 AM · Restricted Project
sylvestre.ledru updated the diff for D34824: clang-format: add an option -verbose to list the files being processed.
Jul 15 2017, 10:37 AM · Restricted Project

Jul 13 2017

sylvestre.ledru added inline comments to D34824: clang-format: add an option -verbose to list the files being processed.
Jul 13 2017, 12:26 PM · Restricted Project

Jul 11 2017

sylvestre.ledru added a comment to D34824: clang-format: add an option -verbose to list the files being processed.

is that ok @djasper ?

Jul 11 2017, 10:40 AM · Restricted Project

Jul 5 2017

sylvestre.ledru added inline comments to D34824: clang-format: add an option -verbose to list the files being processed.
Jul 5 2017, 7:46 AM · Restricted Project

Jul 1 2017

sylvestre.ledru updated the diff for D34824: clang-format: add an option -verbose to list the files being processed.
Jul 1 2017, 8:22 AM · Restricted Project

Jun 29 2017

sylvestre.ledru created D34824: clang-format: add an option -verbose to list the files being processed.
Jun 29 2017, 11:22 AM · Restricted Project

Jun 22 2017

sylvestre.ledru created D34537: Move vmkit in the ProjectsWithLLVM section.
Jun 22 2017, 2:41 PM

Jun 21 2017

sylvestre.ledru added a comment to D23976: Disable the common parts for the sanitizer tools on kfreebsd.

@kcc Do you know who could review that? Thanks

Jun 21 2017, 1:09 PM
sylvestre.ledru added a comment to D30863: [clang-format] make docs/tools/{dump_format_style.py,dump_ast_matchers.py} flake8 compliant.

@klimek ping?

Jun 21 2017, 1:08 PM

Jun 12 2017

sylvestre.ledru closed D34110: Same expressions on both sides of the return.
Jun 12 2017, 11:54 AM
sylvestre.ledru created D34110: Same expressions on both sides of the return.
Jun 12 2017, 11:35 AM

May 6 2017

sylvestre.ledru added a comment to D32922: [Polly][CMake] Introduce POLLY_BUNDLED_JSONCPP..

Looks good!

May 6 2017, 5:31 AM · Restricted Project

Apr 18 2017

sylvestre.ledru added a comment to D30863: [clang-format] make docs/tools/{dump_format_style.py,dump_ast_matchers.py} flake8 compliant.

Manuel, ping?

Apr 18 2017, 12:44 AM

Apr 17 2017

sylvestre.ledru closed D31524: Add a linker script to version LLVM symbols.
Apr 17 2017, 2:04 PM
sylvestre.ledru updated the summary of D31524: Add a linker script to version LLVM symbols.
Apr 17 2017, 1:57 PM
sylvestre.ledru added a comment to D31524: Add a linker script to version LLVM symbols.

Can you elaborate on what you mean by this? Do you mean LLVM_5.0 doesn't depend on LLVM_4.0?

Apr 17 2017, 1:29 PM
sylvestre.ledru added a comment to D31524: Add a linker script to version LLVM symbols.

ping? (FYI, Debian packages are shipping with this change, so will Ubuntu)

Apr 17 2017, 1:21 PM

Apr 11 2017

sylvestre.ledru added inline comments to D31860: Add more examples to clang tidy checkers.
Apr 11 2017, 9:41 AM · Restricted Project
sylvestre.ledru added a comment to D30863: [clang-format] make docs/tools/{dump_format_style.py,dump_ast_matchers.py} flake8 compliant.

Manuel, is that ok with you?

Apr 11 2017, 9:16 AM
sylvestre.ledru closed D31929: Fix Logical vs. bitwise operator in HexagonInstrInfo.cpp.
Apr 11 2017, 9:16 AM
sylvestre.ledru closed D31862: docs/clang-tidy/tools/dump_check_docs.py: Remove deprecated script.
Apr 11 2017, 9:15 AM
sylvestre.ledru closed D31928: Simplify the code and remove dead code.
Apr 11 2017, 1:34 AM
sylvestre.ledru created D31929: Fix Logical vs. bitwise operator in HexagonInstrInfo.cpp.
Apr 11 2017, 12:43 AM
sylvestre.ledru created D31928: Simplify the code and remove dead code.
Apr 11 2017, 12:28 AM
sylvestre.ledru closed D31860: Add more examples to clang tidy checkers.
Apr 11 2017, 12:23 AM · Restricted Project