Page MenuHomePhabricator

sylvestre.ledru (Sylvestre Ledru)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2013, 1:12 AM (331 w, 6 d)

Recent Activity

Tue, Jul 16

sylvestre.ledru committed rG116e58e2929d: remove a duplicate declaration (authored by sylvestre.ledru).
remove a duplicate declaration
Tue, Jul 16, 5:07 AM
sylvestre.ledru committed rGeea828054d37: Document the LLVM_ENABLE_BINDINGS option (authored by sylvestre.ledru).
Document the LLVM_ENABLE_BINDINGS option
Tue, Jul 16, 5:02 AM
Herald added a project to D42026: Allow the llvm bindings to be disabled: Restricted Project.

I took the liberty to add the option to the cmake doc
https://reviews.llvm.org/rL366204

Tue, Jul 16, 5:02 AM · Restricted Project

Mon, Jul 15

sylvestre.ledru committed rG56799837a41b: Update __VERSION__ to remove the hardcoded 4.2.1 version (authored by sylvestre.ledru).
Update __VERSION__ to remove the hardcoded 4.2.1 version
Mon, Jul 15, 10:48 AM
sylvestre.ledru abandoned D64062: Remove __VERSION__.
Mon, Jul 15, 10:47 AM · Restricted Project, Restricted Project
sylvestre.ledru created D64740: Use the ConvertUTF.cpp from breakpad which is under a compatible license And reintegrate our custom changes.
Mon, Jul 15, 6:50 AM · Restricted Project

Sun, Jul 14

sylvestre.ledru committed rG8f1d7d1c55c7: consistency in the release notes (authored by sylvestre.ledru).
consistency in the release notes
Sun, Jul 14, 11:26 AM
sylvestre.ledru added a comment to D64278: Rename libclang_shared to libclang-cpp.

@beanz By the way, maybe we should add this in the 9 release notes?
Thanks

Sun, Jul 14, 6:36 AM · Restricted Project, Restricted Project
sylvestre.ledru added a reviewer for D60380: Also document -arch as -arch is mac specific: tstellar.
Sun, Jul 14, 2:59 AM · Restricted Project
sylvestre.ledru updated the diff for D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

Implement the change (just update VERSION)

Sun, Jul 14, 2:59 AM · Restricted Project, Restricted Project
sylvestre.ledru requested review of D64062: Remove __VERSION__.
Sun, Jul 14, 1:42 AM · Restricted Project, Restricted Project

Fri, Jul 12

sylvestre.ledru committed rG21a92a8a559b: This reverts commit 632a36bfcfc8273c1861f04ff6758d863c47c784. (authored by sylvestre.ledru).
This reverts commit 632a36bfcfc8273c1861f04ff6758d863c47c784.
Fri, Jul 12, 11:31 PM
sylvestre.ledru reopened D64062: Remove __VERSION__.

@rnk looks like it is too risky to remove it.
What about changing it from

Fri, Jul 12, 11:31 PM · Restricted Project, Restricted Project
sylvestre.ledru accepted D64687: [clang] Revert "Remove __VERSION__".

I went ahead and committed your revert in r365992. Thanks!

Fri, Jul 12, 11:30 PM · Restricted Project
sylvestre.ledru added a comment to D64062: Remove __VERSION__.

Thanks @rnk :)

Fri, Jul 12, 2:49 PM · Restricted Project, Restricted Project
sylvestre.ledru committed rG603580216f0a: Remove __VERSION__ (authored by sylvestre.ledru).
Remove __VERSION__
Fri, Jul 12, 2:46 PM
sylvestre.ledru added a comment to D64062: Remove __VERSION__.

@rnk Should be good this time :)

Fri, Jul 12, 6:43 AM · Restricted Project, Restricted Project
sylvestre.ledru retitled D64062: Remove __VERSION__ from Remove both -dumpversion and __VERSION__ to Remove __VERSION__.
Fri, Jul 12, 6:43 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D64062: Remove __VERSION__.

Actually remove it

Fri, Jul 12, 6:15 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D64062: Remove __VERSION__.

Keep -dumpversion

Fri, Jul 12, 6:11 AM · Restricted Project, Restricted Project

Thu, Jul 11

sylvestre.ledru added a comment to D64062: Remove __VERSION__.
In D64062#1581290, @rnk wrote:

Perhaps we should just remove __VERSION__ and keep -dumpversion.

Thu, Jul 11, 2:48 PM · Restricted Project, Restricted Project
sylvestre.ledru committed rG76b26550e9b9: Rename libclang_shared to libclang-cpp (authored by sylvestre.ledru).
Rename libclang_shared to libclang-cpp
Thu, Jul 11, 2:44 PM

Wed, Jul 10

sylvestre.ledru added a comment to D64062: Remove __VERSION__.

@rnk Works for you?
I would like to land that before the 9 branch. Thanks

Wed, Jul 10, 11:33 PM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D64278: Rename libclang_shared to libclang-cpp.

I would like to land that before the 9 branch. @tstellar do you sign off on this change? Thanks

Wed, Jul 10, 11:33 PM · Restricted Project, Restricted Project

Tue, Jul 9

sylvestre.ledru updated the diff for D64062: Remove __VERSION__.

Update of the release note.
thanks to @rnk for the suggestion

Tue, Jul 9, 2:26 AM · Restricted Project, Restricted Project
sylvestre.ledru committed rG0adbe77566d3: Remove trailing whitespaces in the Language Extensions doc (authored by sylvestre.ledru).
Remove trailing whitespaces in the Language Extensions doc
Tue, Jul 9, 1:53 AM
sylvestre.ledru committed rGb2a549d7cf9a: Add AlignConsecutiveMacros to the clang release notes (authored by sylvestre.ledru).
Add AlignConsecutiveMacros to the clang release notes
Tue, Jul 9, 1:46 AM
sylvestre.ledru added a comment to D64278: Rename libclang_shared to libclang-cpp.

@beanz works for you?

Tue, Jul 9, 1:46 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

Sure, done in r365445
thanks for your work!

Tue, Jul 9, 1:46 AM · Restricted Project, Restricted Project

Mon, Jul 8

sylvestre.ledru added a comment to D28462: clang-format: Add new style option AlignConsecutiveMacros.

@VelocityRa could you please add it to the release notes?
https://github.com/llvm-mirror/clang/blob/master/docs/ReleaseNotes.rst
I can commit the change if you need

Mon, Jul 8, 11:53 PM · Restricted Project, Restricted Project

Sat, Jul 6

sylvestre.ledru added a comment to D64062: Remove __VERSION__.

@rnk is it good for you ?

Sat, Jul 6, 6:10 AM · Restricted Project, Restricted Project
sylvestre.ledru created D64278: Rename libclang_shared to libclang-cpp.
Sat, Jul 6, 12:32 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the summary of D64278: Rename libclang_shared to libclang-cpp.
Sat, Jul 6, 12:32 AM · Restricted Project, Restricted Project

Tue, Jul 2

sylvestre.ledru added a comment to D64062: Remove __VERSION__.

This isn't firefox per say but thirdparty apps.
If you feel confident, sure, we can land that and see what happens :)

Tue, Jul 2, 1:58 PM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

Actually, not sure it is a good idea to remove them: https://reviews.llvm.org/D64062#1566460

Tue, Jul 2, 5:56 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D64062: Remove __VERSION__.

Actually, I don't think removing -dumpversion is a great idea. it will remove the capability of clang to be a dropped in replacement.

Tue, Jul 2, 5:36 AM · Restricted Project, Restricted Project
sylvestre.ledru created D64062: Remove __VERSION__.
Tue, Jul 2, 12:36 AM · Restricted Project, Restricted Project

Sun, Jun 30

sylvestre.ledru added a comment to D61909: Add Clang shared library with C++ exports.

For now, it isn't part of the debian packaging.
https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/blob/snapshot/debian/rules#L563
it is removed as packaging phase as I have been told it isn't ready.

Sun, Jun 30, 10:39 AM · Restricted Project

Thu, Jun 27

sylvestre.ledru added a comment to D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

@rnk how do you feel about removing both? I can take care of that if you want

Thu, Jun 27, 12:54 AM · Restricted Project, Restricted Project

Wed, Jun 26

sylvestre.ledru added a comment to D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

@dexonsmith ping?

Wed, Jun 26, 2:46 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D63810: Change the default arm-linux-gnueabihf target to armv7.

If accepted, I will of course update the release notes

Wed, Jun 26, 1:31 AM · Restricted Project
sylvestre.ledru updated the summary of D63810: Change the default arm-linux-gnueabihf target to armv7.
Wed, Jun 26, 1:31 AM · Restricted Project
sylvestre.ledru created D63810: Change the default arm-linux-gnueabihf target to armv7.
Wed, Jun 26, 1:28 AM · Restricted Project

Fri, Jun 21

sylvestre.ledru added a comment to D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined.

FYI, I had similar patches for Linux/Debian packaging.
Thanks!

Fri, Jun 21, 6:31 AM · Restricted Project, Restricted Project, Restricted Project

Jun 14 2019

sylvestre.ledru committed rG0f15ba98f57d: add a missing parenthese in the clang doc (authored by sylvestre.ledru).
add a missing parenthese in the clang doc
Jun 14 2019, 4:31 AM

Jun 11 2019

sylvestre.ledru added a comment to D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

I will wait for @dexonsmith 's opinion

Jun 11 2019, 12:18 AM · Restricted Project, Restricted Project

Jun 8 2019

sylvestre.ledru added inline comments to D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.
Jun 8 2019, 11:47 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

fix rst syntax

Jun 8 2019, 10:58 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

Fix the typo (thanks hubert)

Jun 8 2019, 8:20 AM · Restricted Project, Restricted Project
sylvestre.ledru committed rG375297f38fe8: fix a typo unavaliable=>unavailable (authored by sylvestre.ledru).
fix a typo unavaliable=>unavailable
Jun 8 2019, 8:05 AM
sylvestre.ledru updated the diff for D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

update of the release notes

Jun 8 2019, 8:05 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.

Btw, what about this code

// Currently claim to be compatible with GCC 4.2.1-5621, but only if we're
// not compiling for MSVC compatibility
Builder.defineMacro("__GNUC_MINOR__", "2");
Builder.defineMacro("__GNUC_PATCHLEVEL__", "1");
Builder.defineMacro("__GNUC__", "4");

?

Jun 8 2019, 8:05 AM · Restricted Project, Restricted Project
sylvestre.ledru added a reviewer for D60380: Also document -arch as -arch is mac specific: rnk.
Jun 8 2019, 7:44 AM · Restricted Project
sylvestre.ledru abandoned D59702: Unbreak the build of compiler-rt on Linux/mips64el.

indeed, closing

Jun 8 2019, 7:44 AM · Restricted Project, Restricted Project
sylvestre.ledru abandoned D60379: Make precompiled headers reproducible.

yeah
thanks

Jun 8 2019, 7:44 AM · Restricted Project
sylvestre.ledru created D63048: Update __VERSION__ to remove the hardcoded 4.2.1 version.
Jun 8 2019, 7:41 AM · Restricted Project, Restricted Project

May 21 2019

sylvestre.ledru added inline comments to D61909: Add Clang shared library with C++ exports.
May 21 2019, 11:56 PM · Restricted Project

May 18 2019

sylvestre.ledru added a comment to D61909: Add Clang shared library with C++ exports.

@beanz Great doc, thanks! I will see what I could use for Debian/Ubuntu packages (as we have a lot users and packages organized in a specific way, it isn't always easy to make huge changes)

May 18 2019, 1:33 AM · Restricted Project

May 17 2019

sylvestre.ledru added a comment to D61909: Add Clang shared library with C++ exports.

ok, it should probably be installed in that case (it is currently in usr/lib/llvm-9/lib/libclang_shared.so.9 )
by the way, the name of lib isn't super explicit :/

May 17 2019, 11:21 AM · Restricted Project
sylvestre.ledru added a comment to D61909: Add Clang shared library with C++ exports.

@beanz @tstellar
I am wondering what to do wrt apt.llvm.org
should it be part of libclang or create a libclang++ package
what do you think?

May 17 2019, 11:14 AM · Restricted Project

May 16 2019

sylvestre.ledru added a comment to rL360753: Replace assert with static_assert here applicable..

This change is breaking the build on i386 stage2 build.
https://llvm-jenkins.debian.net/job/llvm-toolchain-trusty-binaries/architecture=i386,distribution=trusty/1941/consoleFull

May 16 2019, 4:46 AM
sylvestre.ledru added a comment to rL360825: [mips] Always use _LARGEFILE_SOURCE / _FILE_OFFSET_BITS for building MIPS 32-bit.

Thanks, I reported:
https://bugs.llvm.org/show_bug.cgi?id=41894
to have it in 8.0.1

May 16 2019, 12:27 AM

May 1 2019

sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

@atanasyan, I tried with

May 1 2019, 5:07 AM · Restricted Project, Restricted Project

Apr 27 2019

sylvestre.ledru added a comment to D58573: [analyzer] Move UninitializedObjectChecker out of alpha.

I took the liberty to add that in the release notes of clang
https://reviews.llvm.org/rG5f163c7e2e62

Apr 27 2019, 2:10 AM · Restricted Project

Apr 26 2019

sylvestre.ledru committed rG5f163c7e2e62: Add to the release notes the fact that UninitializedObject checker is now… (authored by sylvestre.ledru).
Add to the release notes the fact that UninitializedObject checker is now…
Apr 26 2019, 2:45 PM

Apr 19 2019

sylvestre.ledru committed rG5505ad34dbdd: Debian: Add two missing version code in sid (authored by sylvestre.ledru).
Debian: Add two missing version code in sid
Apr 19 2019, 6:47 AM
sylvestre.ledru committed rG54a93a33ee64: Add support of the future Debian (Debian 11 - Bullseye) https://wiki.debian. (authored by sylvestre.ledru).
Add support of the future Debian (Debian 11 - Bullseye) https://wiki.debian.
Apr 19 2019, 6:47 AM
sylvestre.ledru committed rG454014199ddf: Add support of the next Ubuntu (Ubuntu 19.10 - Eoan EANIMAL) (authored by sylvestre.ledru).
Add support of the next Ubuntu (Ubuntu 19.10 - Eoan EANIMAL)
Apr 19 2019, 6:44 AM

Apr 16 2019

sylvestre.ledru abandoned D60360: Dump the minimal version of cmake 3.5.0.

As you wish.
People who might encounter the same issue will (hopefully) find this review

Apr 16 2019, 5:54 AM · Restricted Project
sylvestre.ledru added a comment to D60360: Dump the minimal version of cmake 3.5.0.

I didn't look at the details. It was failing with 3.4, upgrading to 3.5 address the issue.

Apr 16 2019, 5:02 AM · Restricted Project

Apr 8 2019

sylvestre.ledru added a comment to D60379: Make precompiled headers reproducible.

To be clear, this isn't about format stability and distributing but making sure that two same runs of clang produces the same output.

Apr 8 2019, 12:51 PM · Restricted Project
sylvestre.ledru added a reviewer for D60360: Dump the minimal version of cmake 3.5.0: stephenkelly.
Apr 8 2019, 7:58 AM · Restricted Project
sylvestre.ledru added a comment to D60379: Make precompiled headers reproducible.

I won't have time to write the test for that (and would not know where to start). I am just the messenger :)

Apr 8 2019, 1:36 AM · Restricted Project
sylvestre.ledru updated the summary of D60379: Make precompiled headers reproducible.
Apr 8 2019, 1:33 AM · Restricted Project

Apr 7 2019

sylvestre.ledru created D60380: Also document -arch as -arch is mac specific.
Apr 7 2019, 3:11 PM · Restricted Project
sylvestre.ledru created D60379: Make precompiled headers reproducible.
Apr 7 2019, 3:09 PM · Restricted Project

Apr 6 2019

sylvestre.ledru updated the summary of D60360: Dump the minimal version of cmake 3.5.0.
Apr 6 2019, 12:12 AM · Restricted Project

Apr 5 2019

sylvestre.ledru created D60360: Dump the minimal version of cmake 3.5.0.
Apr 5 2019, 11:51 PM · Restricted Project

Apr 3 2019

sylvestre.ledru added a comment to D60115: Adding 'CLion integration' to clang-format doc.

You are welcome, thanks for your contribution!

Apr 3 2019, 2:06 AM · Restricted Project
sylvestre.ledru committed rGacab05feeeb5: Adding 'CLion integration' to clang-format doc (authored by sylvestre.ledru).
Adding 'CLion integration' to clang-format doc
Apr 3 2019, 1:55 AM
sylvestre.ledru updated the summary of D60115: Adding 'CLion integration' to clang-format doc.
Apr 3 2019, 1:54 AM · Restricted Project
sylvestre.ledru added a comment to D60115: Adding 'CLion integration' to clang-format doc.

Sure, i will do it for you

Apr 3 2019, 1:54 AM · Restricted Project
sylvestre.ledru accepted D60115: Adding 'CLion integration' to clang-format doc.

works for me, thanks

Apr 3 2019, 12:53 AM · Restricted Project

Apr 2 2019

sylvestre.ledru added inline comments to D60115: Adding 'CLion integration' to clang-format doc.
Apr 2 2019, 1:28 AM · Restricted Project

Mar 31 2019

sylvestre.ledru committed rG7fb58e98f547: Spelling correction for docs for cppcoreguidelines-owning-memory (authored by sylvestre.ledru).
Spelling correction for docs for cppcoreguidelines-owning-memory
Mar 31 2019, 2:54 PM
sylvestre.ledru added a comment to D60050: Spelling correction for docs for cppcoreguidelines-owning-memory.

If you have permissions on the repo, no need for a review for such change!

Mar 31 2019, 2:33 PM · Restricted Project, Restricted Project, Restricted Project

Mar 26 2019

sylvestre.ledru committed rG90dbbdbc95ca: update the release notes after the change of 'clang -dumpversion' (authored by sylvestre.ledru).
update the release notes after the change of 'clang -dumpversion'
Mar 26 2019, 2:48 AM

Mar 25 2019

sylvestre.ledru committed rGa199a9ba40c7: clang -dumpversion returns 4.2.1 for legacy reason, update it (authored by sylvestre.ledru).
clang -dumpversion returns 4.2.1 for legacy reason, update it
Mar 25 2019, 11:07 AM
sylvestre.ledru updated the diff for D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

Remove the empty directories

Mar 25 2019, 11:03 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

Improve the test (thanks rnk)

Mar 25 2019, 11:03 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.

@rnk btw, do you think it should be added to the clang release notes?

Mar 25 2019, 11:03 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

Debian testing
you can see the full log here:
https://buildd.debian.org/status/fetch.php?pkg=llvm-toolchain-8&arch=mips64el&ver=1%3A8~%2Brc5-1&stamp=1552412165&raw=0

Mar 25 2019, 7:54 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

I agree that 104 looks strange... but it worked.
As I said, I am no expert in mips64el. :/

Mar 25 2019, 7:47 AM · Restricted Project, Restricted Project
sylvestre.ledru added a comment to D59702: Unbreak the build of compiler-rt on Linux/mips64el.

@atanasyan ok with you?

Mar 25 2019, 6:47 AM · Restricted Project, Restricted Project

Mar 23 2019

sylvestre.ledru committed rGd53135767de5: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format. (authored by sylvestre.ledru).
Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.
Mar 23 2019, 10:59 AM
sylvestre.ledru added a reviewer for D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it: rnk.
Mar 23 2019, 10:59 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the summary of D56803: clang -dumpversion returns 4.2.1 for legacy reason, update it.
Mar 23 2019, 10:59 AM · Restricted Project, Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Try again

Mar 23 2019, 10:55 AM · Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Remove unrelated changes

Mar 23 2019, 10:52 AM · Restricted Project
sylvestre.ledru updated the diff for D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`.

Svn version

Mar 23 2019, 10:48 AM · Restricted Project