Page MenuHomePhabricator

Ericson2314 (John Ericson)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2018, 2:30 PM (219 w, 19 h)

Recent Activity

Thu, May 26

Ericson2314 accepted D126466: [libunwind][CMake] Fix name of LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG.

Thanks for catching! I suspect this might explain why some of the refactors @phosek and I were doing before did not work.

Thu, May 26, 7:21 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 25

Ericson2314 added inline comments to D126308: cmake: use llvm dir variables for clang/utils/hmaptool.
Wed, May 25, 1:29 PM · Restricted Project, Restricted Project

Apr 20 2022

Ericson2314 accepted D124072: [doc] [cmake] Fix a typo in examples for the cmake directory docs. NFC..

Oh hah! Thanks for catching.

Apr 20 2022, 10:57 AM · Restricted Project, Restricted Project

Apr 15 2022

Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.

Thanks for doing these comments! That is the sort of thing I wanted for this.

Apr 15 2022, 6:28 PM · Restricted Project, Restricted Project

Mar 30 2022

Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.

Also, how about all this code goes to kmp_affinity.h? Then we dodge the problem entirely.

Mar 30 2022, 1:08 PM · Restricted Project, Restricted Project
Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.

@tianshilei1992 Oh sorry you were talking about https://cmake.org/cmake/help/latest/prop_tgt/INTERFACE_INCLUDE_DIRECTORIES.html#prop_tgt:INTERFACE_INCLUDE_DIRECTORIES that behavior right? Specific to when target_link_library is used to depend on a target and not, say, an external preexisting library file.

Mar 30 2022, 12:56 PM · Restricted Project, Restricted Project
Ericson2314 accepted D122667: llvm14 patch: hwloc include directory for libompd.

Hmm. Do you have docs for this, I would like for you to be right? https://cmake.org/cmake/help/latest/command/target_link_libraries.html only mentions macOS framework includes.

Mar 30 2022, 12:07 PM · Restricted Project, Restricted Project
Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.

Ah, but add_dependency doesn't have a private version. OK, fine.

Mar 30 2022, 11:34 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.

We can land this simple one now, but I really don't like doing stop-gap fixes on development branches instead of fixing the underlying issue. The fact of the matter is, if tech debt isn't fixed as prompted by bugs, it usually never gets fixed at all.

Mar 30 2022, 11:28 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.

Looks like kmp,h is not installed. OK this will call for something fancier.

Mar 30 2022, 10:06 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.

@tianshilei1992 is right. Basically the older CMake stuff like include_directories only worked by side effects, and therefore is impossible to use correctly and modulary and is just generally terrible. the new target stuff is much better, and actually allows tracking who depends on what.

Mar 30 2022, 9:50 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.
Mar 30 2022, 9:45 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.

@s-sajid-ali Thanks! Your call, but might you want to make the other ones target_include_directories(..., PRIVATE) while you are at it?

Mar 30 2022, 8:44 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.
 $ git grep hwloc.h
openmp/README.rst:  ``hwloc.h`` in ``${LIBOMP_HWLOC_INSTALL_DIR}/include`` and the library in
openmp/runtime/cmake/config-ix.cmake:  check_include_file(hwloc.h LIBOMP_HAVE_HWLOC_H)
openmp/runtime/src/kmp.h:#include "hwloc.h"

was useful to me.

Mar 30 2022, 8:04 AM · Restricted Project, Restricted Project

Mar 29 2022

Ericson2314 added a comment to D122667: llvm14 patch: hwloc include directory for libompd.

LIBOMP_INCLUDE_DIR is a weird name because aren't we building libomp? That should be a directory were headers are build/installed not where they are gotten from. For hermetic builds, the distinction of locations to read vs locations to write is very important.

Mar 29 2022, 10:33 AM · Restricted Project, Restricted Project

Mar 18 2022

Ericson2314 added a comment to D121972: Add cmake/ to release tarballs via concatenation.

git archive --help says:

Mar 18 2022, 12:27 PM · Restricted Project, Restricted Project

Feb 22 2022

Ericson2314 accepted D120269: [lld] Require C++14 in LLD standalone build.
Feb 22 2022, 12:23 PM · Restricted Project
Ericson2314 added a comment to D120269: [lld] Require C++14 in LLD standalone build.

I wanted to check this is syntactically identical to Clang's, so we had a clear pattern going forward.

Feb 22 2022, 12:22 PM · Restricted Project

Feb 19 2022

Ericson2314 added a comment to D117973: [cmake] Support custom package install paths.

Could one of you review this?

Feb 19 2022, 12:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore.

Could one of you review this?

Feb 19 2022, 12:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 3 2022

Ericson2314 committed rGe0eeae9a4470: [lld][clang][cmake] Clean up a few things (authored by Ericson2314).
[lld][clang][cmake] Clean up a few things
Feb 3 2022, 12:01 PM
Ericson2314 closed D118792: [lld][clang][cmake] Clean up a few things.
Feb 3 2022, 12:01 PM · Restricted Project

Feb 2 2022

Ericson2314 added a comment to D116492: [lld] Deprecate using llvm-config to detect llvm installation.

@nikic I have tried to address your concerns in https://reviews.llvm.org/D118792

Feb 2 2022, 7:41 AM · Restricted Project, Restricted Project
Ericson2314 requested review of D118792: [lld][clang][cmake] Clean up a few things.
Feb 2 2022, 7:40 AM · Restricted Project
Ericson2314 added a comment to D116492: [lld] Deprecate using llvm-config to detect llvm installation.

Would it be possible to share a complete new-style cmake invocation that is supposed to work?

Feb 2 2022, 7:25 AM · Restricted Project, Restricted Project

Jan 29 2022

Ericson2314 requested review of D118546: [llvm][cmake] Shore up `llvm_check_linker_flags`..
Jan 29 2022, 4:08 PM · Restricted Project
Ericson2314 added a comment to D117833: [compiler-rt][libunwind][runtimes] Recategorize `llvm_check_linker_flag` langs.

Hmm, might these errors be legitimate?

Jan 29 2022, 4:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG368c54b81a86: [openmp][cmake] `CMAKE_INSTALL_BINDIR` usage should not be quoted (authored by Ericson2314).
[openmp][cmake] `CMAKE_INSTALL_BINDIR` usage should not be quoted
Jan 29 2022, 3:53 PM
Ericson2314 closed D118528: [openmp][cmake] `CMAKE_INSTALL_BINDIR` usage should not be quoted.
Jan 29 2022, 3:52 PM · Restricted Project
Ericson2314 updated the summary of D118528: [openmp][cmake] `CMAKE_INSTALL_BINDIR` usage should not be quoted.
Jan 29 2022, 3:52 PM · Restricted Project
Ericson2314 added a comment to D118528: [openmp][cmake] `CMAKE_INSTALL_BINDIR` usage should not be quoted.

Oh yes oops. It had the \${CMAKE_INSTALL_PREFIX}/ before, so I just put that back right the way it was.

Jan 29 2022, 10:43 AM · Restricted Project
Ericson2314 updated the diff for D118528: [openmp][cmake] `CMAKE_INSTALL_BINDIR` usage should not be quoted.

Fix more properly

Jan 29 2022, 10:43 AM · Restricted Project

Jan 28 2022

Ericson2314 added a comment to D117436: Move LLVM Proposal to doc directory, create index.

https://lab.llvm.org/buildbot/#/builders/30/builds/16850 this is causing a build failure because llvm/docs/GettingInvolved.rst still links the old proposal.

Jan 28 2022, 10:22 PM · Restricted Project, Restricted Project
Ericson2314 updated the diff for D117833: [compiler-rt][libunwind][runtimes] Recategorize `llvm_check_linker_flag` langs.

Rebase to retrigger CI now that parent landed

Jan 28 2022, 10:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG7017e6c9cfd2: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for… (authored by Ericson2314).
[cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for…
Jan 28 2022, 10:07 PM
Ericson2314 closed D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.
Jan 28 2022, 10:07 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D118528: [openmp][cmake] `CMAKE_INSTALL_BINDIR` usage should not be quoted.

Oops changed too much

Jan 28 2022, 10:04 PM · Restricted Project
Ericson2314 added inline comments to D117945: [openmp][cmake] Use `GNUInstallDirs` to support custom installation dirs.
Jan 28 2022, 10:01 PM · Restricted Project
Ericson2314 requested review of D118528: [openmp][cmake] `CMAKE_INSTALL_BINDIR` usage should not be quoted.
Jan 28 2022, 10:01 PM · Restricted Project

Jan 26 2022

Ericson2314 added a comment to D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

I'd update this change to move llvm/cmake/modules/LLVMCheckLinkerFlag.cmake to cmake/Modules/CheckLinkerFlag.cmake

Jan 26 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 25 2022

Ericson2314 added a comment to D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

@phosek does that reasoning check out to you?

Jan 25 2022, 12:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 24 2022

Ericson2314 added a comment to D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

What's the reason for keeping both functions instead of changing llvm_check_linker_flag to use CMAKE_REQUIRED_FLAGS?

Jan 24 2022, 12:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG0a3d946e7bb4: [libc][cmake] Make `add_tablegen` calls match others (authored by Ericson2314).
[libc][cmake] Make `add_tablegen` calls match others
Jan 24 2022, 10:37 AM
Ericson2314 closed D117979: [libc][cmake] Make `add_tablegen` calls match others.
Jan 24 2022, 10:36 AM · Restricted Project

Jan 23 2022

Ericson2314 retitled D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore from WIP: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore to [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore.
Jan 23 2022, 2:20 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 22 2022

Ericson2314 requested review of D117979: [libc][cmake] Make `add_tablegen` calls match others.
Jan 22 2022, 10:28 PM · Restricted Project
Ericson2314 requested review of D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore.
Jan 22 2022, 10:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 requested review of D117973: [cmake] Support custom package install paths.
Jan 22 2022, 4:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG7c16647c3676: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation… (authored by Ericson2314).
[clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation…
Jan 22 2022, 12:57 PM
Ericson2314 closed D99484: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs..
Jan 22 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D99484: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs..

Alright, this is the last bit (except for D101070 which evidently caused the issues), looking good.

Jan 22 2022, 12:56 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 retitled D99484: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs. from [cmake] Use `GNUInstallDirs` to support custom installation dirs. to [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs..
Jan 22 2022, 10:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D99484: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs..

Trim down, now that many parts have been landed already

Jan 22 2022, 10:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG0a6b4258ab0e: [openmp][cmake] Use `GNUInstallDirs` to support custom installation dirs (authored by Ericson2314).
[openmp][cmake] Use `GNUInstallDirs` to support custom installation dirs
Jan 22 2022, 10:06 AM
Ericson2314 closed D117945: [openmp][cmake] Use `GNUInstallDirs` to support custom installation dirs.
Jan 22 2022, 10:05 AM · Restricted Project
Ericson2314 added a comment to D117945: [openmp][cmake] Use `GNUInstallDirs` to support custom installation dirs.

This part, too, checks out. Landing next.

Jan 22 2022, 10:05 AM · Restricted Project
Ericson2314 updated the diff for D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

Fix more issues

Jan 22 2022, 10:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 21 2022

Ericson2314 requested review of D117945: [openmp][cmake] Use `GNUInstallDirs` to support custom installation dirs.
Jan 21 2022, 11:00 PM · Restricted Project
Ericson2314 updated the diff for D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

Fix includes

Jan 21 2022, 10:29 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D117833: [compiler-rt][libunwind][runtimes] Recategorize `llvm_check_linker_flag` langs.
  1. Updating D117833: [compiler-rt][libunwind][runtimes] Recategorize llvm_check_linker_flag langs #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

rebase after last round changed

Jan 21 2022, 7:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.
Jan 21 2022, 6:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 retitled D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm from [cmake] Deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm to [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.
Jan 21 2022, 6:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

Restore compromise a bit more

Jan 21 2022, 6:55 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.
Jan 21 2022, 6:43 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

Fix and simplify CMAKE_REQUIRED_DEFINITIONS

Jan 21 2022, 6:41 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D117833: [compiler-rt][libunwind][runtimes] Recategorize `llvm_check_linker_flag` langs.

rebase on top of new version of D117537

Jan 21 2022, 5:20 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.
Jan 21 2022, 5:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

New attempt splitting the difference between last 2

Jan 21 2022, 4:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 reopened D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.
Jan 21 2022, 4:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG10d0d8c0c1db: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs (authored by Ericson2314).
[clang][cmake] Use `GNUInstallDirs` to support custom installation dirs
Jan 21 2022, 3:58 PM
Ericson2314 closed D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs.
Jan 21 2022, 3:58 PM · Restricted Project, Restricted Project
Ericson2314 added a comment to D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs.

I will land this next as part of my great D99484 bisect. Now that I have in fact found the issue, I am more confident this part, which is analogous to all the parts that have gone in fine, is harmless.

Jan 21 2022, 3:56 PM · Restricted Project, Restricted Project
Ericson2314 added a comment to D117815: [compiler-rt][cmake] Use HandleOutOfTreeLLVM like libcxx and friends.

Thanks @dalteny for investigating. @phosek if you remember https://reviews.llvm.org/rG6e3946c9f558adfddfd98a51721baccd8b17bb85 the TODO you put in there about the compiler-rt build having to be standalone seems related.

Jan 21 2022, 2:49 PM · Restricted Project

Jan 20 2022

Ericson2314 updated the diff for D117419: [clang][cmake] Use `GNUInstallDirs` to support custom installation dirs.

Remove the LLVM part, which is now D101070, and furthermore known to cause issues.

Jan 20 2022, 6:54 PM · Restricted Project, Restricted Project
Ericson2314 reopened D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs..

This seems to be the part of D99484 that wasn't working.

Jan 20 2022, 6:51 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a reverting change for rG58580e922a69: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.: rGd93a11c138bb: Revert "[llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.".
Jan 20 2022, 6:50 PM
Ericson2314 committed rGd93a11c138bb: Revert "[llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs." (authored by Ericson2314).
Revert "[llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs."
Jan 20 2022, 6:50 PM
Ericson2314 added a reverting change for D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.: rGd93a11c138bb: Revert "[llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.".
Jan 20 2022, 6:49 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 retitled D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm from [cmake] Duplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm to [cmake] Deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.
Jan 20 2022, 6:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG58580e922a69: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs. (authored by Ericson2314).
[llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs.
Jan 20 2022, 6:11 PM
Ericson2314 closed D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs..
Jan 20 2022, 6:11 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs..

Continuing my bisect of D99484 (since this change was in there at the time it was approved, but failing) I will land this one next.

Jan 20 2022, 6:09 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 retitled D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs. from Make `llvm_install_symlink` robust with respect to absolute dirs. to [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs..
Jan 20 2022, 6:08 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

I have been auto-emailed with some build failures, but they seem unrelated (see https://reviews.llvm.org/rG60f61918795b91f3fc9d310bc0957b75783f826b) so haven't taken any action doing a revert yet.

Jan 20 2022, 4:19 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added inline comments to rG60f61918795b: [SLP] Extract formBundle helper for readability [NFC].
Jan 20 2022, 4:17 PM
Ericson2314 added a comment to D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

Perhaps the difference betwen CMAKE_EXE_LINKER_FLAGS and CMAKE_REQUIRED_FLAGS is important? Also, if it is not possible to link until these libraries are built (e.g. in a cross setting) maybe I am not sure what happens.

Jan 20 2022, 4:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs..
Jan 20 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D101070: [llvm][cmake] Make `llvm_install_symlink` robust to absolute dirs..

Much simpler now

Jan 20 2022, 2:21 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 requested review of D117833: [compiler-rt][libunwind][runtimes] Recategorize `llvm_check_linker_flag` langs.
Jan 20 2022, 1:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG4af11272f57a: [cmake] Duplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and… (authored by Ericson2314).
[cmake] Duplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and…
Jan 20 2022, 1:19 PM
Ericson2314 closed D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.
Jan 20 2022, 1:18 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG8c9f62ea90c7: [compiler-rt][cmake] Use HandleOutOfTreeLLVM like libcxx and friends (authored by Ericson2314).
[compiler-rt][cmake] Use HandleOutOfTreeLLVM like libcxx and friends
Jan 20 2022, 1:18 PM
Ericson2314 closed D117815: [compiler-rt][cmake] Use HandleOutOfTreeLLVM like libcxx and friends.
Jan 20 2022, 1:17 PM · Restricted Project
Ericson2314 added a comment to D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

@phosek I agree with your fixing what language to do each flag, but do note I was purposely matching the existing dubious categorizations. Might it be better to first land this as-is, and then make a separate patch to clean up the languages?

Jan 20 2022, 11:39 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 requested review of D117815: [compiler-rt][cmake] Use HandleOutOfTreeLLVM like libcxx and friends.
Jan 20 2022, 11:07 AM · Restricted Project
Ericson2314 committed rGdf31ff1b29bc: [cmake] Make include(GNUInstallDirs) always below project(..) (authored by Ericson2314).
[cmake] Make include(GNUInstallDirs) always below project(..)
Jan 20 2022, 10:59 AM
Ericson2314 closed D117639: [cmake] Make include(GNUInstallDirs) always below project(..).
Jan 20 2022, 10:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 19 2022

Ericson2314 updated the diff for D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

Fix STREQUAL which is actually infix

Jan 19 2022, 11:20 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D117537: [cmake] Partially deduplicate `{llvm,compiler_rt}_check_linker_flag` for runtime libs and llvm.

Fix remaining missing C/CXX arguments

Jan 19 2022, 4:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D117639: [cmake] Make include(GNUInstallDirs) always below project(..).

Rebase after D117617 landed

Jan 19 2022, 2:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project