Page MenuHomePhabricator

Ericson2314 (John Ericson)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2018, 2:30 PM (261 w, 3 d)

Recent Activity

Dec 9 2022

Ericson2314 added inline comments to D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR.
Dec 9 2022, 8:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 7 2022

Ericson2314 updated the summary of D133890: [CMake] Do these replacements to make use of D132608.
Nov 7 2022, 8:05 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D133890: [CMake] Do these replacements to make use of D132608.
Nov 7 2022, 8:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D133890: [CMake] Do these replacements to make use of D132608.

Rebase, rename variables

Nov 7 2022, 8:03 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D132608: [CMake] Clean up CMake binary dir handling.

I have done the deduping @phosek requested, and changed the variable names from CMAKE_* to LLVMPROJ_* which hopefully satisfies everyone's criteria. Happy with other non LLVM_ options too.

Nov 7 2022, 7:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D132608: [CMake] Clean up CMake binary dir handling.
Nov 7 2022, 7:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D132608: [CMake] Clean up CMake binary dir handling.

Dedup code, rename variables

Nov 7 2022, 7:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 requested changes to D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected.
Nov 7 2022, 5:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected.

This change introduces a lot of conditional code, that is not necessary. This change also uses CLANG_ outside clang/ which is messy. and confusing. Please clean up.

Nov 7 2022, 5:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too.
Nov 7 2022, 5:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 4 2022

Ericson2314 added inline comments to D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR.
Nov 4 2022, 11:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 2 2022

Ericson2314 accepted D137224: clang/cmake: Simplify lit detection for standalone builds.

LGTM. I also can't see why it would act differently.

Nov 2 2022, 10:53 AM · Restricted Project, Restricted Project

Oct 4 2022

Ericson2314 added a comment to D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro.

Thanks @MaskRay that's good to know.

Oct 4 2022, 12:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D134936: [cmake] Export `LLVM_ENABLE_LTO`..

If each project used a separate ${project_upper}_ENABLE_LTO I would be more comfortable with this.

Oct 4 2022, 9:56 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D134936: [cmake] Export `LLVM_ENABLE_LTO`..

Do we care about LLVM itself being built with LTO, or various runtime libs being built with LTO? LLVMConfig.cmake should *just* be about LLVM itself.

Oct 4 2022, 9:52 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D132480: [llvm] Remove libcxx, libcxxabi and libunwind from supported LLVM_ENABLE_PROJECTS.

@ldionne Yeah that sort of thing is what I suspected. I am thinking maybe it isn't so bad that these projects can be built this way. IMO it should be permissible to combine any two CMake projects together if they are just to be built in parallel without any dependencies between them.

Oct 4 2022, 7:10 AM · Restricted Project, Restricted Project, Restricted Project

Sep 20 2022

Ericson2314 added a comment to D132480: [llvm] Remove libcxx, libcxxabi and libunwind from supported LLVM_ENABLE_PROJECTS.

If we try to build docs with LLVM_ENABLE_RUNTIMES might it try to bootstrap them, wasting effort?

Sep 20 2022, 2:13 PM · Restricted Project, Restricted Project, Restricted Project

Sep 14 2022

Ericson2314 added a comment to D132608: [CMake] Clean up CMake binary dir handling.

@tianshilei1992 that is a fair point. I would be open to calling them something else.

Sep 14 2022, 8:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added inline comments to D132608: [CMake] Clean up CMake binary dir handling.
Sep 14 2022, 2:16 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too.

Rebase, fix some issues (by the looks of it)

Sep 14 2022, 2:08 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 requested review of D133890: [CMake] Do these replacements to make use of D132608.
Sep 14 2022, 12:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D132608: [CMake] Clean up CMake binary dir handling.

Fix misspelled variable CLANG_CURRENT_SOURCE_DIR -> CLANG_SOURCE_DIR

Sep 14 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG3a1c81e32739: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314).
[CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better…
Sep 14 2022, 12:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 closed D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.
Sep 14 2022, 12:49 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D132608: [CMake] Clean up CMake binary dir handling.

Fix typo in compiler-rt

Sep 14 2022, 8:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG154db06ce0d6: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314).
[CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better…
Sep 14 2022, 7:59 AM · Restricted Project, Restricted Project
Ericson2314 closed D133828: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 1.
Sep 14 2022, 7:58 AM · Restricted Project, Restricted Project, Restricted Project

Sep 13 2022

Ericson2314 added a reviewer for D133828: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 1: sebastian-ne.
Sep 13 2022, 10:19 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D132608: [CMake] Clean up CMake binary dir handling.
Sep 13 2022, 10:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added inline comments to D132608: [CMake] Clean up CMake binary dir handling.
Sep 13 2022, 10:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D132608: [CMake] Clean up CMake binary dir handling.

Rebase, avoid sed

Sep 13 2022, 10:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.

I think I fixed the issue: I was confusing /lib stemming from lib subdirs in the source and /lib stemming from building things in a lib directory that will later be installed also to a lib directory. It is just the latter case that uses the suffix, and so just the latter case will be so seded.

Sep 13 2022, 9:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.

Require LLVM_LIBDIR_SUFFIX in the sed

Sep 13 2022, 9:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.
Sep 13 2022, 9:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 retitled D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2 from [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited to [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.
Sep 13 2022, 8:43 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.

Rebase on top of D133828

Sep 13 2022, 8:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D133828: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 1.
Sep 13 2022, 8:40 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 requested review of D133828: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 1.
Sep 13 2022, 8:39 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 reopened D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.
Sep 13 2022, 8:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 accepted D132480: [llvm] Remove libcxx, libcxxabi and libunwind from supported LLVM_ENABLE_PROJECTS.

OK. As long as we don't forget about it :).

Sep 13 2022, 7:37 PM · Restricted Project, Restricted Project, Restricted Project

Sep 11 2022

Ericson2314 added inline comments to D132526: [libcxxabi] Unbreak `LLVM_ENABLE_RUNTIMES=libcxxabi` build v2.
Sep 11 2022, 12:30 PM · Restricted Project, Restricted Project
Ericson2314 added a comment to D132480: [llvm] Remove libcxx, libcxxabi and libunwind from supported LLVM_ENABLE_PROJECTS.

In D132324 I also removed the hack in clang/lib/Driver/ToolChains/Linux.cpp, I think you want to do that too?

Sep 11 2022, 12:19 PM · Restricted Project, Restricted Project, Restricted Project

Aug 30 2022

Ericson2314 accepted D131490: [libclc] Quote addition of CLC/LLAsm flags.

Might it be better to stort as a CMake list internally and then convert at only when used?

Aug 30 2022, 1:07 PM · Restricted Project, Restricted Project

Aug 29 2022

Ericson2314 added a comment to D132883: [cmake] Don't include symlinks to tools in Build-all when `LLVM_BUILD_TOOLS` is off.

I need to review more but I am suspicious of this exact fix before we are looking up a LLVM-specific env inside what I think is a reusable project also useable by downstream projects.

Aug 29 2022, 1:20 PM · Restricted Project, Restricted Project

Aug 25 2022

Ericson2314 added a reverting change for rGad8c34bc3089: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better…: rG34fe6ddce11e: Revert "[CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are….
Aug 25 2022, 8:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG34fe6ddce11e: Revert "[CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are… (authored by Ericson2314).
Revert "[CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are…
Aug 25 2022, 8:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a reverting change for D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2: rG34fe6ddce11e: Revert "[CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are….
Aug 25 2022, 8:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.

Let's just revert this. I'll do it later today if no one beats me to it.

Aug 25 2022, 6:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 24 2022

Ericson2314 requested review of D132608: [CMake] Clean up CMake binary dir handling.
Aug 24 2022, 2:21 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.

Whew, thanks!

Aug 24 2022, 10:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.

https://lab.llvm.org/buildbot#builders/13/builds/24958 I am worried this failure is not spurious?

Aug 24 2022, 9:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rGad8c34bc3089: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better… (authored by Ericson2314).
[CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better…
Aug 24 2022, 7:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 closed D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.
Aug 24 2022, 7:14 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added inline comments to D132526: [libcxxabi] Unbreak `LLVM_ENABLE_RUNTIMES=libcxxabi` build v2.
Aug 24 2022, 7:12 AM · Restricted Project, Restricted Project
Ericson2314 updated the diff for D132526: [libcxxabi] Unbreak `LLVM_ENABLE_RUNTIMES=libcxxabi` build v2.

Fix bugs

Aug 24 2022, 7:11 AM · Restricted Project, Restricted Project

Aug 23 2022

Ericson2314 requested review of D132526: [libcxxabi] Unbreak `LLVM_ENABLE_RUNTIMES=libcxxabi` build v2.
Aug 23 2022, 8:37 PM · Restricted Project, Restricted Project
Ericson2314 committed rG4c5114250bb7: [Polly] Don't use `llvm-config` anymore (in CMake sad path) (authored by Ericson2314).
[Polly] Don't use `llvm-config` anymore (in CMake sad path)
Aug 23 2022, 7:47 PM · Restricted Project
Ericson2314 closed D132314: [Polly] Don't use `llvm-config` anymore (in CMake sad path).
Aug 23 2022, 7:47 PM · Restricted Project, Restricted Project
Ericson2314 accepted D132478: [runtimes][NFC] Colocate handling of LLVM_ENABLE_PROJECTS and LLVM_ENABLE_RUNTIMES.
Aug 23 2022, 4:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D132478: [runtimes][NFC] Colocate handling of LLVM_ENABLE_PROJECTS and LLVM_ENABLE_RUNTIMES.

Ah right, runtimes/ and llvm/runtimes are the two ways that remain per the plan.

Aug 23 2022, 4:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added reviewers for D132314: [Polly] Don't use `llvm-config` anymore (in CMake sad path): sebastian-ne, beanz.
Aug 23 2022, 3:16 PM · Restricted Project, Restricted Project
Ericson2314 retitled D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2 from [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}` to [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited.
Aug 23 2022, 3:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added inline comments to D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.
Aug 23 2022, 3:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.

Convert CMAKE_CFG_INTDIR as @sebastian-ne suggests, also .../bin

Aug 23 2022, 3:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D132478: [runtimes][NFC] Colocate handling of LLVM_ENABLE_PROJECTS and LLVM_ENABLE_RUNTIMES.

So this is in preparation for LLVM_DEFAULT_RUNTIMES in llvm/CMakeLists.txt doing a runtimes/ instead of llvm/runtimes/ build (among other changes)?

Aug 23 2022, 1:48 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 accepted D132479: [runtimes] Shrink the set of runtimes included in the bootstrapping build by default.
Aug 23 2022, 1:45 PM · Restricted Project, Restricted Project
Ericson2314 accepted D132471: [compiler-rt] Use LLVM_ENABLE_RUNTIMES instead of LLVM_ENABLE_PROJECTS in the symbolizer.

Code looks good.

Aug 23 2022, 7:39 AM · Restricted Project, Restricted Project
Ericson2314 abandoned D132411: [libcxxabi] Unbreak `LLVM_ENABLE_PROJECTS=libcxxabi` build.

Abandoning because the plan is to revert and because @ldionne is skeptical building libc++ without libc++abi ought to be supported anyways.

Aug 23 2022, 7:36 AM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 added inline comments to D132411: [libcxxabi] Unbreak `LLVM_ENABLE_PROJECTS=libcxxabi` build.
Aug 23 2022, 7:34 AM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D132411: [libcxxabi] Unbreak `LLVM_ENABLE_PROJECTS=libcxxabi` build.

Fix more things for posterity

Aug 23 2022, 7:33 AM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.

That sounds good to me too.

Aug 23 2022, 7:13 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added inline comments to D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.
Aug 23 2022, 7:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the diff for D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.

Redo sed mandating ending on word boundary

Aug 23 2022, 7:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 accepted D132454: [llvm][Cmake] Expand "all" in LLVM_ENABLE_PROJECTS before other checks.
Aug 23 2022, 2:31 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D132298: [libcxxabi][cmake] Allow building without libcxx again.

Thanks for that sleuthing, @kadircet.

Aug 23 2022, 2:30 AM · Restricted Project, Restricted Project

Aug 22 2022

Ericson2314 added a comment to D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.

https://reviews.llvm.org/D132411 should fix the issue @aaron.ballman mentioned.

Aug 22 2022, 1:22 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 requested review of D132411: [libcxxabi] Unbreak `LLVM_ENABLE_PROJECTS=libcxxabi` build.
Aug 22 2022, 1:21 PM · Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.

https://reviews.llvm.org/rZORG3a209ca6c1b9 This is what I had started doing. but I am not sure it is a very good solution. I think I might write a discourse post with my thoughts.

Aug 22 2022, 7:58 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 added a comment to D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.

I did a "soft revert" in rG952f90b72b3546d6b6b038d410f07ce520c59b48 which makes it a non-fatal error so everything keeps on working, but I can do a real revert too if that is preferred.

Aug 22 2022, 7:48 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 21 2022

Ericson2314 committed rZORG3a209ca6c1b9: WIP try to separate runtimes vs projects for docs (authored by Ericson2314).
WIP try to separate runtimes vs projects for docs
Aug 21 2022, 10:38 AM · Restricted Project
Ericson2314 added a comment to D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.

In 952f90b72b3546d6b6b038d410f07ce520c59b48 I relented and made it a non-fatal error until the remaining jobs are figured out.

Aug 21 2022, 6:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG952f90b72b35: [CMake] Weaken 176db3b3ab25ff8a9b2405f50ef5a8bd9304a6d5 (authored by Ericson2314).
[CMake] Weaken 176db3b3ab25ff8a9b2405f50ef5a8bd9304a6d5
Aug 21 2022, 6:01 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.

Ah I see email about sphinx jobs defined out of tree :/ I will take a look at that, see if it is easy to fix.

Aug 21 2022, 5:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rGe6a0800532bb: [libcxxabi][cmake] Allow building without libcxx again (authored by Ericson2314).
[libcxxabi][cmake] Allow building without libcxx again
Aug 21 2022, 5:23 AM · Restricted Project
Ericson2314 closed D132298: [libcxxabi][cmake] Allow building without libcxx again.
Aug 21 2022, 5:23 AM · Restricted Project, Restricted Project
Ericson2314 added a comment to D132298: [libcxxabi][cmake] Allow building without libcxx again.

The legacy build is no longer CI'd so the one failure here is no longer an issue.

Aug 21 2022, 5:22 AM · Restricted Project, Restricted Project
Ericson2314 retitled D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS` from [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS` to [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.
Aug 21 2022, 5:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG176db3b3ab25: [RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS` (authored by Ericson2314).
[RFC] Remove support for building C++ with `LLVM_ENABLE_PROJECTS`
Aug 21 2022, 5:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 closed D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.
Aug 21 2022, 5:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 20 2022

Ericson2314 updated the diff for D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.

Do the rename @phosek suggested

Aug 20 2022, 7:45 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 updated the summary of D132298: [libcxxabi][cmake] Allow building without libcxx again.
Aug 20 2022, 7:41 PM · Restricted Project, Restricted Project
Ericson2314 updated the diff for D132298: [libcxxabi][cmake] Allow building without libcxx again.

Use target_include_directories

Aug 20 2022, 7:39 PM · Restricted Project, Restricted Project
Ericson2314 added inline comments to D132298: [libcxxabi][cmake] Allow building without libcxx again.
Aug 20 2022, 7:36 PM · Restricted Project, Restricted Project
Ericson2314 added a comment to D132298: [libcxxabi][cmake] Allow building without libcxx again.

Ah I would have to check both lists to support the legacy case. Ew.

Aug 20 2022, 6:56 PM · Restricted Project, Restricted Project
Ericson2314 requested review of D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`.
Aug 20 2022, 6:54 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 requested review of D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2.
Aug 20 2022, 3:39 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 requested review of D132314: [Polly] Don't use `llvm-config` anymore (in CMake sad path).
Aug 20 2022, 2:41 PM · Restricted Project, Restricted Project
Ericson2314 added a comment to D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro.

OK Thanks @thakis --- I was confused why the last GN fixup added but didn't remove lines. That clears it up!

Aug 20 2022, 1:05 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Ericson2314 committed rG90dcdc4b6e7d: [bolt][llvm][cmake] Use `CMAKE_INSTALL_LIBDIR` too (authored by Ericson2314).
[bolt][llvm][cmake] Use `CMAKE_INSTALL_LIBDIR` too
Aug 20 2022, 10:08 AM · Restricted Project, Restricted Project
Ericson2314 closed D132297: [bolt][llvm][cmake] Use `CMAKE_INSTALL_LIBDIR` too.
Aug 20 2022, 10:08 AM · Restricted Project, Restricted Project