This is an archive of the discontinued LLVM Phabricator instance.

[docs] Update compiler-rt/CODE_OWNERS.TXT
ClosedPublic

Authored by vitalybuka on Oct 10 2022, 2:06 PM.

Diff Detail

Event Timeline

vitalybuka created this revision.Oct 10 2022, 2:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2022, 2:06 PM
vitalybuka requested review of this revision.Oct 10 2022, 2:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2022, 2:06 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka added 1 blocking reviewer(s): compnerd.
vitalybuka added a reviewer: dberris.
vitalybuka added a reviewer: pcc.
kcc accepted this revision.Oct 10 2022, 2:08 PM
kcc added a subscriber: kcc.

LGTM, thanks!

vitalybuka added a reviewer: lhames.
vitalybuka added a reviewer: tejohnson.
vitalybuka added a reviewer: cryptoad.
vitalybuka added a reviewer: hctim.

fix mitchp@google.com

phosek added inline comments.
compiler-rt/CODE_OWNERS.TXT
22–25

This should be updated since we no longer have the Makefile build. What we should have instead is the CMake build, and we need to figure out who the best owner is. I'd volunteer for that one unless there's someone else who is interested in owning the build.

32

Would it be possible to use my Google email?

59–61

Is this still accurate? Most of the profile runtime changes in the last few years have been reviewed by either @davidxl or @vsk so I'd suggest them as owners.

This file is quite outdated.
Please confirm if you want to be here, removed or suggest other owners.

Replace make with cmake build owner

vitalybuka marked an inline comment as done.

fix email

vitalybuka marked an inline comment as done.Oct 10 2022, 2:21 PM
vitalybuka added inline comments.
compiler-rt/CODE_OWNERS.TXT
22–25

Thank you!

This is bare minimum, so other suggestions are welcome.

phosek accepted this revision.Oct 10 2022, 2:25 PM

LGTM

Bill Wendling -> David Li

vitalybuka marked an inline comment as done.Oct 10 2022, 2:29 PM
vitalybuka added inline comments.
compiler-rt/CODE_OWNERS.TXT
59–61

@davidxl or @vsk Does either of you, or both, want to be on this list?

tejohnson accepted this revision.Oct 10 2022, 2:31 PM

LGTM for MemProf

dvyukov accepted this revision.Oct 11 2022, 1:40 AM
lhames accepted this revision.Oct 11 2022, 11:19 AM

LGTM for ORC.

MaskRay accepted this revision.Oct 11 2022, 11:32 AM
MaskRay added subscribers: browneee, MaskRay.

Thanks for updating the long outdated file. Generally looks good to me as a watcher of various components in compiler-rt.

  • Dean Michael Berris's email address needs a change.
  • Will @browneee be a good candidate for Data Flow Sanitizer owner as well? Note that it's fine to have a library to have more than one owner in some cases.

sounds fine to me.

compnerd accepted this revision.Oct 11 2022, 7:42 PM
pcc added a comment.Oct 19 2022, 5:19 PM

Will @browneee be a good candidate for Data Flow Sanitizer owner as well? Note that it's fine to have a library to have more than one owner in some cases.

I think it would be appropriate for him to be the sole owner. I no longer work on DFSan.

vitalybuka marked an inline comment as done.

reviewed changes

This revision is now accepted and ready to land.Oct 19 2022, 5:28 PM
This revision was landed with ongoing or failed builds.Oct 19 2022, 5:29 PM
This revision was automatically updated to reflect the committed changes.