Page MenuHomePhabricator

browneee (Andrew)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2019, 7:05 PM (107 w, 4 d)

Recent Activity

Mon, Nov 8

browneee added inline comments to D113328: [msan] Block signals in MsanThread::Init.
Mon, Nov 8, 2:37 PM · Unknown Object (Project)

Oct 28 2021

browneee added a comment to D103745: [dfsan] Add full fast8 support.

Sorry, I was thinking/describing fast-16 to fast-8.

Oct 28 2021, 3:24 PM · Restricted Project, Restricted Project, Unknown Object (Project)
browneee updated subscribers of D103745: [dfsan] Add full fast8 support.

@gbalats @stephan.yichao.zhao Hello sorry for the late comment but I wonder what was the reason behind this change (changing taint label representation from 16-bit to 8-bit-fast only). Do we have any discussion thread from llvm-dev regarding this? Thanks!

Oct 28 2021, 2:51 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Oct 10 2021

browneee updated the diff for D111522: [DFSan] Fix flakey release_shadow_space.c accounting for Origin chains..

Reduce estimate for origin chain size.

Oct 10 2021, 11:26 PM · Unknown Object (Project)
browneee added inline comments to D111522: [DFSan] Fix flakey release_shadow_space.c accounting for Origin chains..
Oct 10 2021, 11:25 PM · Unknown Object (Project)
browneee added inline comments to D111522: [DFSan] Fix flakey release_shadow_space.c accounting for Origin chains..
Oct 10 2021, 11:18 PM · Unknown Object (Project)
browneee requested review of D111522: [DFSan] Fix flakey release_shadow_space.c accounting for Origin chains..
Oct 10 2021, 11:15 PM · Unknown Object (Project)

Oct 8 2021

browneee committed rG007d98f520ca: [DFSan] Fix warning: getArgsFunctionType defined but not used (authored by browneee).
[DFSan] Fix warning: getArgsFunctionType defined but not used
Oct 8 2021, 11:59 AM
browneee committed rG61ec2148c5a6: [DFSan] Remove -dfsan-args-abi support in favor of TLS. (authored by browneee).
[DFSan] Remove -dfsan-args-abi support in favor of TLS.
Oct 8 2021, 11:19 AM
browneee closed D111097: [DFSan] Remove -dfsan-args-abi support in favor of TLS..
Oct 8 2021, 11:19 AM · Restricted Project, Unknown Object (Project)
browneee updated the diff for D111097: [DFSan] Remove -dfsan-args-abi support in favor of TLS..

Fix unnecessary variable.

Oct 8 2021, 11:01 AM · Restricted Project, Unknown Object (Project)
browneee added a reviewer for D111097: [DFSan] Remove -dfsan-args-abi support in favor of TLS.: morehouse.
Oct 8 2021, 10:36 AM · Restricted Project, Unknown Object (Project)

Oct 5 2021

browneee updated the diff for D111097: [DFSan] Remove -dfsan-args-abi support in favor of TLS..

Rebase.

Oct 5 2021, 9:43 AM · Restricted Project, Unknown Object (Project)

Oct 4 2021

browneee updated the diff for D111097: [DFSan] Remove -dfsan-args-abi support in favor of TLS..

Rebase.

Oct 4 2021, 5:01 PM · Restricted Project, Unknown Object (Project)
browneee updated the diff for D111097: [DFSan] Remove -dfsan-args-abi support in favor of TLS..

Fix build.

Oct 4 2021, 4:08 PM · Restricted Project, Unknown Object (Project)
browneee requested review of D111097: [DFSan] Remove -dfsan-args-abi support in favor of TLS..
Oct 4 2021, 1:33 PM · Restricted Project, Unknown Object (Project)

Sep 30 2021

browneee committed rGd81723c99bda: [DFSan] Optimize code for writing to shadow. Move SetShadow to namespace. (authored by browneee).
[DFSan] Optimize code for writing to shadow. Move SetShadow to namespace.
Sep 30 2021, 12:43 PM
browneee closed D110733: [DFSan] Optimize code for writing to shadow. Move SetShadow to namespace..
Sep 30 2021, 12:42 PM · Unknown Object (Project)

Sep 29 2021

browneee requested review of D110733: [DFSan] Optimize code for writing to shadow. Move SetShadow to namespace..
Sep 29 2021, 10:22 AM · Unknown Object (Project)

Sep 17 2021

browneee committed rGc533b88a6dc9: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a… (authored by browneee).
[DFSan] Add force_zero_label abilist option to DFSan. This can be used as a…
Sep 17 2021, 12:58 PM
browneee closed D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting..
Sep 17 2021, 12:58 PM · Restricted Project, Restricted Project, Unknown Object (Project)
browneee updated the diff for D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting..

Update comments.

Sep 17 2021, 10:21 AM · Restricted Project, Restricted Project, Unknown Object (Project)
browneee updated the diff for D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting..

Rebase

Sep 17 2021, 10:15 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Sep 16 2021

browneee updated the diff for D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting..

Docs

Sep 16 2021, 2:12 PM · Restricted Project, Restricted Project, Unknown Object (Project)
browneee updated the diff for D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting..

Address review comments.

Sep 16 2021, 1:00 PM · Restricted Project, Restricted Project, Unknown Object (Project)
browneee added a comment to D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting..

The motivation for this change is to remove taint in functions which write out their return data...

Sep 16 2021, 10:23 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Sep 15 2021

browneee requested review of D109847: [DFSan] Add force_zero_label abilist option to DFSan. This can be used as a work-around for overtainting..
Sep 15 2021, 1:02 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Aug 31 2021

browneee committed rGbefb38448431: [DFSan][NFC] Fix comment formatting. (authored by browneee).
[DFSan][NFC] Fix comment formatting.
Aug 31 2021, 3:37 PM

Aug 24 2021

browneee committed rG76777b216b48: [DFSan] Add wrapper for getentropy(). (authored by browneee).
[DFSan] Add wrapper for getentropy().
Aug 24 2021, 3:11 PM
browneee closed D108604: [DFSan] Add wrapper for getentropy()..
Aug 24 2021, 3:11 PM · Unknown Object (Project)
browneee updated the diff for D108604: [DFSan] Add wrapper for getentropy()..

Address comment.

Aug 24 2021, 3:09 PM · Unknown Object (Project)

Aug 23 2021

browneee requested review of D108604: [DFSan] Add wrapper for getentropy()..
Aug 23 2021, 7:53 PM · Unknown Object (Project)

Jul 22 2021

browneee added a comment to D106594: [dfsan] Make warn_unimplemented off by default.

This makes issues silent by default.

Jul 22 2021, 2:35 PM · Unknown Object (Project)

Jun 29 2021

browneee accepted D105128: [dfsan] Expose dfsan_get_track_origins to get origin tracking status.
Jun 29 2021, 1:29 PM · Restricted Project, Unknown Object (Project)
browneee added inline comments to D105128: [dfsan] Expose dfsan_get_track_origins to get origin tracking status.
Jun 29 2021, 12:37 PM · Restricted Project, Unknown Object (Project)

Jun 25 2021

browneee committed rG45f6d5522f8d: [DFSan] Change shadow and origin memory layouts to match MSan. (authored by browneee).
[DFSan] Change shadow and origin memory layouts to match MSan.
Jun 25 2021, 5:01 PM
browneee closed D104896: [DFSan] Change shadow and origin memory layouts to match MSan..
Jun 25 2021, 5:01 PM · Restricted Project, Unknown Object (Project), Restricted Project
browneee updated the diff for D104896: [DFSan] Change shadow and origin memory layouts to match MSan..

Addressed comments.

Jun 25 2021, 11:06 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jun 24 2021

browneee requested review of D104896: [DFSan] Change shadow and origin memory layouts to match MSan..
Jun 24 2021, 10:30 PM · Restricted Project, Unknown Object (Project), Restricted Project

Jun 21 2021

browneee committed rG759e79776792: [DFSan][NFC] Refactor Origin Address Alignment code. (authored by browneee).
[DFSan][NFC] Refactor Origin Address Alignment code.
Jun 21 2021, 2:53 PM
browneee closed D104565: [DFSan][NFC] Refactor Origin Address Alignment code..
Jun 21 2021, 2:53 PM · Unknown Object (Project)
browneee updated the diff for D104565: [DFSan][NFC] Refactor Origin Address Alignment code..

Rebase to head.

Jun 21 2021, 11:05 AM · Unknown Object (Project)

Jun 18 2021

browneee requested review of D104565: [DFSan][NFC] Refactor Origin Address Alignment code..
Jun 18 2021, 12:31 PM · Unknown Object (Project)
browneee committed rG14407332de61: [DFSan] Cleanup code for platforms other than Linux x86_64. (authored by browneee).
[DFSan] Cleanup code for platforms other than Linux x86_64.
Jun 18 2021, 11:22 AM
browneee closed D104481: [DFSan] Cleanup code for platforms other than Linux x86_64..
Jun 18 2021, 11:22 AM · Restricted Project, Unknown Object (Project)

Jun 17 2021

browneee updated the diff for D104481: [DFSan] Cleanup code for platforms other than Linux x86_64..

Remove unused runtime global variable.

Jun 17 2021, 4:14 PM · Restricted Project, Unknown Object (Project)
browneee updated the diff for D104481: [DFSan] Cleanup code for platforms other than Linux x86_64..

Fix build.

Jun 17 2021, 2:56 PM · Restricted Project, Unknown Object (Project)
browneee reopened D104481: [DFSan] Cleanup code for platforms other than Linux x86_64..
Jun 17 2021, 2:56 PM · Restricted Project, Unknown Object (Project)
browneee added a reverting change for rG8441b993bdba: [DFSan] Cleanup code for platforms other than Linux x86_64.: rG39295e92f7f9: Revert "[DFSan] Cleanup code for platforms other than Linux x86_64.".
Jun 17 2021, 2:20 PM
browneee committed rG39295e92f7f9: Revert "[DFSan] Cleanup code for platforms other than Linux x86_64." (authored by browneee).
Revert "[DFSan] Cleanup code for platforms other than Linux x86_64."
Jun 17 2021, 2:20 PM
browneee added a reverting change for D104481: [DFSan] Cleanup code for platforms other than Linux x86_64.: rG39295e92f7f9: Revert "[DFSan] Cleanup code for platforms other than Linux x86_64.".
Jun 17 2021, 2:20 PM · Restricted Project, Unknown Object (Project)
browneee committed rG8441b993bdba: [DFSan] Cleanup code for platforms other than Linux x86_64. (authored by browneee).
[DFSan] Cleanup code for platforms other than Linux x86_64.
Jun 17 2021, 2:09 PM
browneee closed D104481: [DFSan] Cleanup code for platforms other than Linux x86_64..
Jun 17 2021, 2:09 PM · Restricted Project, Unknown Object (Project)
browneee requested review of D104481: [DFSan] Cleanup code for platforms other than Linux x86_64..
Jun 17 2021, 12:14 PM · Restricted Project, Unknown Object (Project)

Jun 15 2021

browneee committed rGe652d991699f: [DFSan][NFC] Fix shadowing variable name. (authored by browneee).
[DFSan][NFC] Fix shadowing variable name.
Jun 15 2021, 10:59 PM
browneee committed rGaf93157625ef: [DFSan] Handle landingpad inst explicitly as zero shadow. (authored by browneee).
[DFSan] Handle landingpad inst explicitly as zero shadow.
Jun 15 2021, 6:30 PM
browneee closed D104266: [DFSan] Handle landingpad inst explicitly as zero shadow..
Jun 15 2021, 6:30 PM · Restricted Project
browneee updated the diff for D104266: [DFSan] Handle landingpad inst explicitly as zero shadow..

Updated comments.

Jun 15 2021, 6:12 PM · Restricted Project
browneee updated the diff for D104266: [DFSan] Handle landingpad inst explicitly as zero shadow..

Updating comments.

Jun 15 2021, 1:19 PM · Restricted Project
browneee added inline comments to D104266: [DFSan] Handle landingpad inst explicitly as zero shadow..
Jun 15 2021, 12:32 PM · Restricted Project

Jun 14 2021

browneee requested review of D104266: [DFSan] Handle landingpad inst explicitly as zero shadow..
Jun 14 2021, 2:35 PM · Restricted Project

Jun 7 2021

browneee accepted D103745: [dfsan] Add full fast8 support.
Jun 7 2021, 4:14 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Jun 2 2021

browneee committed rG70804f2a2f7b: Fix dfsan handling of musttail calls. (authored by browneee).
Fix dfsan handling of musttail calls.
Jun 2 2021, 11:39 AM
browneee closed D103542: Fix dfsan handling of musttail calls..
Jun 2 2021, 11:39 AM · Restricted Project
browneee updated the diff for D103542: Fix dfsan handling of musttail calls..

Fix review comments.

Jun 2 2021, 11:29 AM · Restricted Project
browneee added a reviewer for D103542: Fix dfsan handling of musttail calls.: stephan.yichao.zhao.
Jun 2 2021, 11:04 AM · Restricted Project
browneee requested review of D103542: Fix dfsan handling of musttail calls..
Jun 2 2021, 11:03 AM · Restricted Project

Jan 29 2021

browneee added inline comments to D95642: [dfsan] Clean TLS after sigaction callbacks.
Jan 29 2021, 10:46 AM · Unknown Object (Project)

Apr 30 2020

browneee added inline comments to D79214: [ADT] Fix SmallVector unused template instantiation on 32-bit systems..
Apr 30 2020, 6:07 PM · Restricted Project
browneee committed rGa1bd5cd539f9: [NFC] Add include cstdint for SIZE_MAX. (authored by browneee).
[NFC] Add include cstdint for SIZE_MAX.
Apr 30 2020, 5:39 PM
browneee committed rGd96c7f413f35: Revert "Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit… (authored by browneee).
Revert "Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit…
Apr 30 2020, 5:39 PM
browneee added a reverting change for rGac2635e457d5: Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit systems.": rGd96c7f413f35: Revert "Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit….
Apr 30 2020, 5:39 PM
browneee committed rGac2635e457d5: Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit systems." (authored by browneee).
Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit systems."
Apr 30 2020, 4:44 PM
browneee added a reverting change for rG25e2e92297e2: [ADT] Fix SmallVector unused template instantiation on 32-bit systems.: rGac2635e457d5: Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit systems.".
Apr 30 2020, 4:44 PM
browneee committed rG25e2e92297e2: [ADT] Fix SmallVector unused template instantiation on 32-bit systems. (authored by browneee).
[ADT] Fix SmallVector unused template instantiation on 32-bit systems.
Apr 30 2020, 4:40 PM
browneee closed D79214: [ADT] Fix SmallVector unused template instantiation on 32-bit systems..
Apr 30 2020, 4:40 PM · Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

https://reviews.llvm.org/D79214

Apr 30 2020, 3:38 PM · Restricted Project, Restricted Project
browneee created D79214: [ADT] Fix SmallVector unused template instantiation on 32-bit systems..
Apr 30 2020, 3:38 PM · Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

@browneee Looks like LLVM already defines LLVM_PTR_SIZE as a more portable version of __SIZEOF_POINTER__.

Apr 30 2020, 1:26 PM · Restricted Project, Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Thanks for the tips, MaskRay.

Apr 30 2020, 11:47 AM · Restricted Project, Restricted Project

Apr 27 2020

browneee committed rGdda3c19a3618: ADT: SmallVector size/capacity use word-size integers when elements are small (authored by browneee).
ADT: SmallVector size/capacity use word-size integers when elements are small
Apr 27 2020, 2:02 PM

Apr 24 2020

browneee added inline comments to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.
Apr 24 2020, 10:09 PM · Restricted Project, Restricted Project
browneee reopened D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.
Apr 24 2020, 9:37 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Change uintptr_t to uint64_t to ensure this does not instantiate the same template twice on platforms where uintptr_t is equivalent to uint32_t.

Apr 24 2020, 9:37 PM · Restricted Project, Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Reverted in 5cb4c3776a34d48e43d9118921d2191aee0e3d21

Apr 24 2020, 8:02 PM · Restricted Project, Restricted Project
browneee added a reverting change for rGb5f0eae1dc3c: ADT: SmallVector size/capacity use word-size integers when elements are small: rG5cb4c3776a34: Revert "ADT: SmallVector size/capacity use word-size integers when elements are….
Apr 24 2020, 7:30 PM
browneee committed rG5cb4c3776a34: Revert "ADT: SmallVector size/capacity use word-size integers when elements are… (authored by browneee).
Revert "ADT: SmallVector size/capacity use word-size integers when elements are…
Apr 24 2020, 7:30 PM
browneee closed D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Comitted: b5f0eae1dc3c09c020cdf9d07238dec9acdacf5f

Apr 24 2020, 7:30 PM · Restricted Project, Restricted Project
browneee committed rGb5f0eae1dc3c: ADT: SmallVector size/capacity use word-size integers when elements are small (authored by browneee).
ADT: SmallVector size/capacity use word-size integers when elements are small
Apr 24 2020, 6:59 PM
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.
  • Change SizeTypeMax to a static constexpr function.
  • Fix comment typos.
  • Add comment to alert others to possible performance loss if that function is moved to the header.
Apr 24 2020, 3:12 PM · Restricted Project, Restricted Project
browneee retitled D77621: ADT: SmallVector size/capacity use word-size integers when elements are small from Change BitcodeWriter buffer to std::vector instead of SmallVector. to ADT: SmallVector size/capacity use word-size integers when elements are small.
Apr 24 2020, 12:26 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Switch back to size and capacity type conditionally larger approach (appologies for the noise here).

Apr 24 2020, 12:26 PM · Restricted Project, Restricted Project

Apr 23 2020

browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

I resubmitted the report_fatal_error checks again under D77601

Apr 23 2020, 11:21 AM · Restricted Project, Restricted Project

Apr 22 2020

browneee retitled D77621: ADT: SmallVector size/capacity use word-size integers when elements are small from ADT: SmallVector size & capacity use word-size integers when elements are small. to Change BitcodeWriter buffer to std::vector instead of SmallVector..
Apr 22 2020, 11:18 PM · Restricted Project, Restricted Project
browneee updated the summary of D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.
Apr 22 2020, 11:18 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Switch approach back to std::vector change.

Apr 22 2020, 10:46 PM · Restricted Project, Restricted Project

Apr 21 2020

browneee added a comment to D77601: Make SmallVector assert if it cannot grow..

Incorporated into https://reviews.llvm.org/D77621 (because this is not submitted yet, and that change now moves this code).

Based on this comment I thought you'd abandoned this patch...

Apr 21 2020, 6:57 PM · Restricted Project
browneee committed rGa30e7ea88e75: Make SmallVector assert if it cannot grow. (authored by browneee).
Make SmallVector assert if it cannot grow.
Apr 21 2020, 6:25 PM
browneee closed D77601: Make SmallVector assert if it cannot grow..

Landed as a30e7ea88e75568feed020aedae73c52de888835

Apr 21 2020, 6:25 PM · Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Thanks for the revert explanation and notes, nikic.

Apr 21 2020, 4:17 PM · Restricted Project, Restricted Project