Page MenuHomePhabricator

browneee (Andrew)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2019, 7:05 PM (54 w, 5 d)

Recent Activity

Apr 30 2020

browneee added inline comments to D79214: [ADT] Fix SmallVector unused template instantiation on 32-bit systems..
Apr 30 2020, 6:07 PM · Restricted Project
browneee committed rGa1bd5cd539f9: [NFC] Add include cstdint for SIZE_MAX. (authored by browneee).
[NFC] Add include cstdint for SIZE_MAX.
Apr 30 2020, 5:39 PM
browneee committed rGd96c7f413f35: Revert "Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit… (authored by browneee).
Revert "Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit…
Apr 30 2020, 5:39 PM
browneee added a reverting change for rGac2635e457d5: Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit systems.": rGd96c7f413f35: Revert "Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit….
Apr 30 2020, 5:39 PM
browneee committed rGac2635e457d5: Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit systems." (authored by browneee).
Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit systems."
Apr 30 2020, 4:44 PM
browneee added a reverting change for rG25e2e92297e2: [ADT] Fix SmallVector unused template instantiation on 32-bit systems.: rGac2635e457d5: Revert "[ADT] Fix SmallVector unused template instantiation on 32-bit systems.".
Apr 30 2020, 4:44 PM
browneee committed rG25e2e92297e2: [ADT] Fix SmallVector unused template instantiation on 32-bit systems. (authored by browneee).
[ADT] Fix SmallVector unused template instantiation on 32-bit systems.
Apr 30 2020, 4:40 PM
browneee closed D79214: [ADT] Fix SmallVector unused template instantiation on 32-bit systems..
Apr 30 2020, 4:40 PM · Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

https://reviews.llvm.org/D79214

Apr 30 2020, 3:38 PM · Restricted Project, Restricted Project
browneee created D79214: [ADT] Fix SmallVector unused template instantiation on 32-bit systems..
Apr 30 2020, 3:38 PM · Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

@browneee Looks like LLVM already defines LLVM_PTR_SIZE as a more portable version of __SIZEOF_POINTER__.

Apr 30 2020, 1:26 PM · Restricted Project, Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Thanks for the tips, MaskRay.

Apr 30 2020, 11:47 AM · Restricted Project, Restricted Project

Apr 27 2020

browneee committed rGdda3c19a3618: ADT: SmallVector size/capacity use word-size integers when elements are small (authored by browneee).
ADT: SmallVector size/capacity use word-size integers when elements are small
Apr 27 2020, 2:02 PM

Apr 24 2020

browneee added inline comments to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.
Apr 24 2020, 10:09 PM · Restricted Project, Restricted Project
browneee reopened D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.
Apr 24 2020, 9:37 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Change uintptr_t to uint64_t to ensure this does not instantiate the same template twice on platforms where uintptr_t is equivalent to uint32_t.

Apr 24 2020, 9:37 PM · Restricted Project, Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Reverted in 5cb4c3776a34d48e43d9118921d2191aee0e3d21

Apr 24 2020, 8:02 PM · Restricted Project, Restricted Project
browneee added a reverting change for rGb5f0eae1dc3c: ADT: SmallVector size/capacity use word-size integers when elements are small: rG5cb4c3776a34: Revert "ADT: SmallVector size/capacity use word-size integers when elements are….
Apr 24 2020, 7:30 PM
browneee committed rG5cb4c3776a34: Revert "ADT: SmallVector size/capacity use word-size integers when elements are… (authored by browneee).
Revert "ADT: SmallVector size/capacity use word-size integers when elements are…
Apr 24 2020, 7:30 PM
browneee closed D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Comitted: b5f0eae1dc3c09c020cdf9d07238dec9acdacf5f

Apr 24 2020, 7:30 PM · Restricted Project, Restricted Project
browneee committed rGb5f0eae1dc3c: ADT: SmallVector size/capacity use word-size integers when elements are small (authored by browneee).
ADT: SmallVector size/capacity use word-size integers when elements are small
Apr 24 2020, 6:59 PM
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.
  • Change SizeTypeMax to a static constexpr function.
  • Fix comment typos.
  • Add comment to alert others to possible performance loss if that function is moved to the header.
Apr 24 2020, 3:12 PM · Restricted Project, Restricted Project
browneee retitled D77621: ADT: SmallVector size/capacity use word-size integers when elements are small from Change BitcodeWriter buffer to std::vector instead of SmallVector. to ADT: SmallVector size/capacity use word-size integers when elements are small.
Apr 24 2020, 12:26 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Switch back to size and capacity type conditionally larger approach (appologies for the noise here).

Apr 24 2020, 12:26 PM · Restricted Project, Restricted Project

Apr 23 2020

browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

I resubmitted the report_fatal_error checks again under D77601

Apr 23 2020, 11:21 AM · Restricted Project, Restricted Project

Apr 22 2020

browneee retitled D77621: ADT: SmallVector size/capacity use word-size integers when elements are small from ADT: SmallVector size & capacity use word-size integers when elements are small. to Change BitcodeWriter buffer to std::vector instead of SmallVector..
Apr 22 2020, 11:18 PM · Restricted Project, Restricted Project
browneee updated the summary of D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.
Apr 22 2020, 11:18 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Switch approach back to std::vector change.

Apr 22 2020, 10:46 PM · Restricted Project, Restricted Project

Apr 21 2020

browneee added a comment to D77601: Make SmallVector assert if it cannot grow..

Incorporated into https://reviews.llvm.org/D77621 (because this is not submitted yet, and that change now moves this code).

Based on this comment I thought you'd abandoned this patch...

Apr 21 2020, 6:57 PM · Restricted Project
browneee committed rGa30e7ea88e75: Make SmallVector assert if it cannot grow. (authored by browneee).
Make SmallVector assert if it cannot grow.
Apr 21 2020, 6:25 PM
browneee closed D77601: Make SmallVector assert if it cannot grow..

Landed as a30e7ea88e75568feed020aedae73c52de888835

Apr 21 2020, 6:25 PM · Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Thanks for the revert explanation and notes, nikic.

Apr 21 2020, 4:17 PM · Restricted Project, Restricted Project
browneee updated the diff for D77601: Make SmallVector assert if it cannot grow..

Rebase to head.

Apr 21 2020, 4:16 PM · Restricted Project
browneee updated the diff for D77601: Make SmallVector assert if it cannot grow..

Update. Add check to SmallVectorTemplateBase<T, TriviallyCopyable>::grow too.

Apr 21 2020, 10:14 AM · Restricted Project
browneee reclaimed D77601: Make SmallVector assert if it cannot grow..
Apr 21 2020, 10:14 AM · Restricted Project

Apr 17 2020

browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Rebase to latest HEAD.

Apr 17 2020, 3:55 PM · Restricted Project, Restricted Project

Apr 15 2020

browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Rebase to latest HEAD.

Apr 15 2020, 2:55 PM · Restricted Project, Restricted Project

Apr 13 2020

browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

GIT_COMMITTER_NAME=Andrew Browne
GIT_COMMITTER_EMAIL=browneee@google.com

Apr 13 2020, 10:56 PM · Restricted Project, Restricted Project
browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

I'm open to suggestions to resolve the clang tidy naming warnings. I would prefer to leave grow_pod the same, to minimize changes.

Apr 13 2020, 3:53 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Rename SizeMax() to SizeTypeMax(). Fix max_size().

Apr 13 2020, 3:47 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Changed SizeMax to static constexpr function.
Changed static asserts.

Apr 13 2020, 11:52 AM · Restricted Project, Restricted Project

Apr 11 2020

browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Address comments from dblaikie.

Apr 11 2020, 2:56 PM · Restricted Project, Restricted Project

Apr 10 2020

browneee retitled D77621: ADT: SmallVector size/capacity use word-size integers when elements are small from Change BitcodeWriter buffer to std::vector instead of SmallVector. to ADT: SmallVector size & capacity use word-size integers when elements are small..
Apr 10 2020, 12:53 PM · Restricted Project, Restricted Project
browneee abandoned D77601: Make SmallVector assert if it cannot grow..

Incorporated into https://reviews.llvm.org/D77621 (because this is not submitted yet, and that change now moves this code).

Apr 10 2020, 11:12 AM · Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Change to suggested approach: size and capacity type conditionally larger for small element types.

Apr 10 2020, 11:11 AM · Restricted Project, Restricted Project

Apr 9 2020

browneee added a comment to D77601: Make SmallVector assert if it cannot grow..

I am not a committer, please submit for me.

Apr 9 2020, 10:18 AM · Restricted Project

Apr 7 2020

browneee added a comment to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

This is thanks to a commit of mine that shaved a word off of SmallVector. Some options to consider:

  1. Revert to word-size integers (size_t? uintptr_t?) for Size and Capacity for small-enough types. Could be just if sizeof(T)==1. Or maybe just for char and unsigned char.
  2. Revert my patch entirely and go back to words (these used to be void*).
  3. (Your patch, stop using SmallVector<char>.)

I think I would prefer some variation of (1) over (3).

Apr 7 2020, 10:50 PM · Restricted Project, Restricted Project
browneee added inline comments to D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.
Apr 7 2020, 10:18 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Fix formatting.

Apr 7 2020, 9:46 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Build fixes in additional projects.

Apr 7 2020, 7:04 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Fix build errors. Missed -DLLVM_ENABLE_PROJECTS in previous local test builds.

Apr 7 2020, 4:54 PM · Restricted Project, Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Fix more build errors.

Apr 7 2020, 3:16 PM · Restricted Project, Restricted Project
browneee updated the diff for D77601: Make SmallVector assert if it cannot grow..

Add "report a " to comments.

Apr 7 2020, 1:03 PM · Restricted Project
browneee updated the diff for D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.

Fix build.

Apr 7 2020, 1:03 PM · Restricted Project, Restricted Project

Apr 6 2020

browneee created D77621: ADT: SmallVector size/capacity use word-size integers when elements are small.
Apr 6 2020, 7:38 PM · Restricted Project, Restricted Project
browneee added inline comments to D77601: Make SmallVector assert if it cannot grow..
Apr 6 2020, 6:33 PM · Restricted Project
browneee updated the diff for D77601: Make SmallVector assert if it cannot grow..

Added function comment on grow_pod.

Apr 6 2020, 6:33 PM · Restricted Project
browneee created D77601: Make SmallVector assert if it cannot grow..
Apr 6 2020, 3:48 PM · Restricted Project

Nov 18 2019

browneee added a comment to D70195: Fix error message missed in commit dde589389fcb8b5098f7a47f1b781b27d29a0cac..

I am not a committer, please submit for me.

Nov 18 2019, 1:06 PM · Restricted Project

Nov 15 2019

browneee updated the diff for D70195: Fix error message missed in commit dde589389fcb8b5098f7a47f1b781b27d29a0cac..

Moved constant to ModuleSummaryIndex as suggested. Now shared between BitcodeReader.cpp and BitcodeWriter.cpp.

Nov 15 2019, 4:35 PM · Restricted Project

Nov 13 2019

browneee created D70195: Fix error message missed in commit dde589389fcb8b5098f7a47f1b781b27d29a0cac..
Nov 13 2019, 11:27 AM · Restricted Project
browneee added reviewers for D70195: Fix error message missed in commit dde589389fcb8b5098f7a47f1b781b27d29a0cac.: tejohnson, evgeny777.
Nov 13 2019, 11:27 AM · Restricted Project