Page MenuHomePhabricator

browneee (Andrew)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 12 2019, 7:05 PM (174 w, 5 d)

Recent Activity

Thu, Mar 2

browneee added inline comments to D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower.
Thu, Mar 2, 9:10 AM · Restricted Project, Restricted Project

Feb 10 2023

browneee accepted D143701: [NFC] convert compiler-rt/lib/dfsan/scripts/build-libc-list.py to python3 syntax.
Feb 10 2023, 1:04 AM · Restricted Project, Restricted Project

Feb 7 2023

browneee added inline comments to D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower.
Feb 7 2023, 8:02 AM · Restricted Project, Restricted Project

Feb 3 2023

browneee added inline comments to D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower.
Feb 3 2023, 3:53 AM · Restricted Project, Restricted Project

Feb 2 2023

browneee added inline comments to D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower.
Feb 2 2023, 4:52 AM · Restricted Project, Restricted Project

Jan 17 2023

browneee added inline comments to D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower.
Jan 17 2023, 12:35 AM · Restricted Project, Restricted Project

Jan 11 2023

browneee added a comment to D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower.

Please send separate changes one by one (e.g. first patch would be for strsep alone and would include several functions of implementation __dfsw_strsep + __dfso_strsep + test code for this).

Jan 11 2023, 2:32 PM · Restricted Project, Restricted Project

Jan 10 2023

browneee requested changes to D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower.

Hello! Thank you for the patch.

Jan 10 2023, 6:10 PM · Restricted Project, Restricted Project

Jan 3 2023

browneee accepted D140797: [dfsan] Remove injectMetadataGlobals.
Jan 3 2023, 8:56 AM · Restricted Project, Restricted Project

Dec 29 2022

browneee added a comment to D140770: [dfsan] Support Linux AArch64.

Copying maps from MSan LGTM.

Dec 29 2022, 11:39 PM · Restricted Project, Restricted Project, Restricted Project
browneee abandoned D140743: [DFSan] Fix overuse of REQUIRES: in tests..

Abandon due to D140744 being submitted.

Dec 29 2022, 2:44 PM · Restricted Project, Restricted Project, Restricted Project

Dec 28 2022

browneee updated the diff for D140743: [DFSan] Fix overuse of REQUIRES: in tests..

Fix other line number.

Dec 28 2022, 3:50 PM · Restricted Project, Restricted Project, Restricted Project
browneee updated the diff for D140743: [DFSan] Fix overuse of REQUIRES: in tests..

Fix updated line numbers in test.

Dec 28 2022, 2:25 PM · Restricted Project, Restricted Project, Restricted Project
browneee requested review of D140743: [DFSan] Fix overuse of REQUIRES: in tests..
Dec 28 2022, 1:39 PM · Restricted Project, Restricted Project, Restricted Project
browneee added a comment to D140690: [compiler-rt][dfsan] Enable loongarch64 and add test support.

We notice that DFSan is a work in progress, currently under development for x86_64 Linux. So maybe we can defer the change until DFSan development is finished and there is a use case on loongarch64?

Dec 28 2022, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
browneee accepted D140689: [DFSan] Add `zeroext` attribute for callbacks with 8bit shadow variable arguments.
Dec 28 2022, 12:55 AM · Restricted Project, Restricted Project

Dec 27 2022

browneee added a comment to D140690: [compiler-rt][dfsan] Enable loongarch64 and add test support.

Who will use DFSan on loongarch64?

Dec 27 2022, 10:25 AM · Restricted Project, Restricted Project, Restricted Project
browneee added inline comments to D140689: [DFSan] Add `zeroext` attribute for callbacks with 8bit shadow variable arguments.
Dec 27 2022, 10:17 AM · Restricted Project, Restricted Project

Dec 12 2022

browneee committed rGded9f398c77e: Fix 5bb06c7cce6bdcffb3ced29fa733c0dbb1b63c41 build on windows. (authored by browneee).
Fix 5bb06c7cce6bdcffb3ced29fa733c0dbb1b63c41 build on windows.
Dec 12 2022, 1:24 AM · Restricted Project, Restricted Project

Dec 11 2022

browneee committed rG5bb06c7cce6b: [DFSan] Add callback that allows to track which function tainted data reaches. (authored by browneee).
[DFSan] Add callback that allows to track which function tainted data reaches.
Dec 11 2022, 11:10 PM · Restricted Project, Restricted Project, Restricted Project
browneee closed D139543: [DFSan] Add callback that allows to track which function tainted data reaches.
Dec 11 2022, 11:10 PM · Restricted Project, Restricted Project, Restricted Project

Dec 9 2022

browneee accepted D139543: [DFSan] Add callback that allows to track which function tainted data reaches.

Test failures look unrelated, but rebasing might make it green again.

Dec 9 2022, 12:36 PM · Restricted Project, Restricted Project, Restricted Project

Dec 8 2022

browneee added inline comments to D139543: [DFSan] Add callback that allows to track which function tainted data reaches.
Dec 8 2022, 9:53 AM · Restricted Project, Restricted Project, Restricted Project

Dec 7 2022

browneee added inline comments to D139543: [DFSan] Add callback that allows to track which function tainted data reaches.
Dec 7 2022, 10:35 AM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2022

browneee accepted D136308: [docs] Update compiler-rt/CODE_OWNERS.TXT.
Oct 19 2022, 8:06 PM · Restricted Project, Restricted Project

Sep 12 2022

browneee accepted D133685: [DFSan] Don't crash with the legacy pass manager.
Sep 12 2022, 10:07 AM · Restricted Project, Restricted Project

Sep 2 2022

browneee committed rG64529eb2917c: [DFSan] Increase size of buffer to fix possibly-flakey test. (authored by browneee).
[DFSan] Increase size of buffer to fix possibly-flakey test.
Sep 2 2022, 5:53 PM · Restricted Project, Restricted Project
browneee closed D133227: [DFSan] Increase size of buffer to fix possibly-flakey test..
Sep 2 2022, 5:52 PM · Restricted Project, Restricted Project
browneee updated the diff for D133227: [DFSan] Increase size of buffer to fix possibly-flakey test..

Fix formatting.

Sep 2 2022, 3:29 PM · Restricted Project, Restricted Project
browneee updated the diff for D133227: [DFSan] Increase size of buffer to fix possibly-flakey test..

Switch large stack allocation to use malloc.

Sep 2 2022, 2:32 PM · Restricted Project, Restricted Project
browneee updated the diff for D133227: [DFSan] Increase size of buffer to fix possibly-flakey test..

Increasing size and adding comment.

Sep 2 2022, 12:35 PM · Restricted Project, Restricted Project
browneee requested review of D133227: [DFSan] Increase size of buffer to fix possibly-flakey test..
Sep 2 2022, 12:13 PM · Restricted Project, Restricted Project

Aug 22 2022

browneee committed rG065d2e1d8bc8: [DFSan] Fix handling of libAtomic external functions. (authored by browneee).
[DFSan] Fix handling of libAtomic external functions.
Aug 22 2022, 4:05 PM · Restricted Project, Restricted Project, Restricted Project
browneee closed D132070: [DFSan] Fix handling of libAtomic external functions..
Aug 22 2022, 4:04 PM · Restricted Project, Restricted Project, Restricted Project
browneee updated the diff for D132070: [DFSan] Fix handling of libAtomic external functions..

Fix const.

Aug 22 2022, 4:04 PM · Restricted Project, Restricted Project, Restricted Project
browneee updated the diff for D132070: [DFSan] Fix handling of libAtomic external functions..

Rebase.

Aug 22 2022, 2:14 PM · Restricted Project, Restricted Project, Restricted Project
browneee updated the diff for D132070: [DFSan] Fix handling of libAtomic external functions..

Fix formatting.

Aug 22 2022, 9:29 AM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2022

browneee added a reviewer for D132070: [DFSan] Fix handling of libAtomic external functions.: vitalybuka.
Aug 17 2022, 2:43 PM · Restricted Project, Restricted Project, Restricted Project
browneee updated the diff for D132070: [DFSan] Fix handling of libAtomic external functions..

Add missing test file.

Aug 17 2022, 2:41 PM · Restricted Project, Restricted Project, Restricted Project
browneee requested review of D132070: [DFSan] Fix handling of libAtomic external functions..
Aug 17 2022, 2:28 PM · Restricted Project, Restricted Project, Restricted Project

Jun 8 2022

browneee committed rGc7689fd552cd: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node. (authored by browneee).
[Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.
Jun 8 2022, 9:59 AM · Restricted Project, Restricted Project, Restricted Project
browneee closed D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node..
Jun 8 2022, 9:58 AM · Restricted Project, Restricted Project, Restricted Project
browneee updated the diff for D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node..

Added release notes and fixed variable naming.

Jun 8 2022, 9:51 AM · Restricted Project, Restricted Project, Restricted Project

Jun 7 2022

browneee added a comment to D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node..

Bump

Jun 7 2022, 9:41 AM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2022

browneee added reviewers for D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.: erichkeane, aaron.ballman, MitalAshok.
Jun 3 2022, 2:00 PM · Restricted Project, Restricted Project, Restricted Project
browneee added inline comments to D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node..
Jun 3 2022, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
browneee updated the diff for D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node..

Formatting.

Jun 3 2022, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
browneee added a comment to D126851: [MSAN] add dn_expand intercept..

I am aware of this breakage: https://lab.llvm.org/buildbot/#/builders/77/builds/18273

I will push a fix shortly.

Jun 3 2022, 11:13 AM · Restricted Project, Restricted Project
browneee updated the diff for D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node..

Remove auto used under clang/. Format.

Jun 3 2022, 11:10 AM · Restricted Project, Restricted Project, Restricted Project

Jun 2 2022

browneee added a comment to D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node..

More details on the bug: https://reviews.llvm.org/D125802#3551305

Jun 2 2022, 10:01 PM · Restricted Project, Restricted Project, Restricted Project
browneee added a comment to D126937: Fix memleak in VarTemplateSpecializationDecl.

I was also looking into fixing this: https://reviews.llvm.org/D126944

Jun 2 2022, 10:00 PM · Restricted Project, Restricted Project, Restricted Project
browneee requested review of D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node..
Jun 2 2022, 9:59 PM · Restricted Project, Restricted Project, Restricted Project

Jun 1 2022

browneee added a comment to D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits.

It looks like the leak is rooted at the allocation here:
https://github.com/llvm/llvm-project/blob/1a155ee7de3b62a2fabee86fb470a1554fadc54d/clang/lib/Sema/SemaTemplateInstantiateDecl.cpp#L3857

Jun 1 2022, 5:29 PM · Restricted Project, Restricted Project
browneee committed rZORGebf22b99c70b: Use force checkout so that local files do not cause failure. (authored by browneee).
Use force checkout so that local files do not cause failure.
Jun 1 2022, 1:42 PM · Restricted Project
browneee closed D126820: Use force checkout so that local files do not cause failure..
Jun 1 2022, 1:42 PM · Restricted Project
browneee added a comment to D126820: Use force checkout so that local files do not cause failure..

Going to push without review to repair this buildbot ASAP: https://lab.llvm.org/buildbot/#/builders/168

Jun 1 2022, 1:41 PM · Restricted Project
browneee updated the diff for D126820: Use force checkout so that local files do not cause failure..

Add -f on the second checkout command.

Jun 1 2022, 1:27 PM · Restricted Project
browneee requested review of D126820: Use force checkout so that local files do not cause failure..
Jun 1 2022, 1:24 PM · Restricted Project
browneee added inline comments to D125802: Fix std::has_unique_object_representations for _BitInt types with padding bits.
Jun 1 2022, 1:02 PM · Restricted Project, Restricted Project
browneee committed rG31d12df3b938: [DFSan] Remove deprecated flag from build-libc-list.py (authored by browneee).
[DFSan] Remove deprecated flag from build-libc-list.py
Jun 1 2022, 11:01 AM · Restricted Project, Restricted Project
browneee closed D126429: [DFSan] Remove deprecated flag from build-libc-list.py.
Jun 1 2022, 11:00 AM · Restricted Project, Restricted Project

May 31 2022

browneee committed rG15d5db276c9b: [DFSan] build-libc-list.py no longer provides a list of default files. (authored by browneee).
[DFSan] build-libc-list.py no longer provides a list of default files.
May 31 2022, 11:27 AM · Restricted Project, Restricted Project
browneee closed D126430: [DFSan] build-libc-list.py no longer provides a list of default files..
May 31 2022, 11:27 AM · Restricted Project, Restricted Project

May 25 2022

browneee requested review of D126430: [DFSan] build-libc-list.py no longer provides a list of default files..
May 25 2022, 3:55 PM · Restricted Project, Restricted Project
browneee requested review of D126429: [DFSan] Remove deprecated flag from build-libc-list.py.
May 25 2022, 3:54 PM · Restricted Project, Restricted Project

May 24 2022

browneee committed rGb2b0322a8114: [DFSan] Add option to specify individual library files, and an option to exit… (authored by browneee).
[DFSan] Add option to specify individual library files, and an option to exit…
May 24 2022, 4:16 PM · Restricted Project, Restricted Project
browneee closed D126336: [DFSan] Add option to specify individual library files, and an option to exit with an error code if any library file was not found..
May 24 2022, 4:16 PM · Restricted Project, Restricted Project
browneee requested review of D126336: [DFSan] Add option to specify individual library files, and an option to exit with an error code if any library file was not found..
May 24 2022, 3:21 PM · Restricted Project, Restricted Project

Apr 27 2022

browneee added a comment to D124594: [LegacyPM] Remove DataFlowSanitizerLegacyPass.

I know this is currently used in at least one other place:
https://github.com/tensorflow/tensorflow/blob/dde12a690476650573a0ef3f8f681271a2016224/tensorflow/compiler/xla/service/cpu/compiler_functor.cc#L111

Apr 27 2022, 10:31 PM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

browneee committed rG204c12eef9e1: [DFSan] Print an error before calling null extern_weak functions, incase dfsan… (authored by browneee).
[DFSan] Print an error before calling null extern_weak functions, incase dfsan…
Apr 19 2022, 5:03 PM · Restricted Project, Restricted Project, Restricted Project
browneee closed D124051: [DFSan] Print an error before calling null extern_weak functions, incase dfsan instrumentation optimized out a null check..
Apr 19 2022, 5:02 PM · Restricted Project, Restricted Project, Restricted Project
browneee requested review of D124051: [DFSan] Print an error before calling null extern_weak functions, incase dfsan instrumentation optimized out a null check..
Apr 19 2022, 3:46 PM · Restricted Project, Restricted Project, Restricted Project

Apr 14 2022

browneee committed rGcddcf2170ae8: [DFSan] Avoid replacing uses of functions in comparisions. (authored by browneee).
[DFSan] Avoid replacing uses of functions in comparisions.
Apr 14 2022, 2:15 PM · Restricted Project, Restricted Project
browneee closed D123701: [DFSan] Avoid replacing uses of functions in comparisions..
Apr 14 2022, 2:15 PM · Restricted Project, Restricted Project
browneee updated the diff for D123701: [DFSan] Avoid replacing uses of functions in comparisions..

Rebase

Apr 14 2022, 11:26 AM · Restricted Project, Restricted Project

Apr 13 2022

browneee requested review of D123701: [DFSan] Avoid replacing uses of functions in comparisions..
Apr 13 2022, 11:50 AM · Restricted Project, Restricted Project

Apr 5 2022

browneee committed rG5748219fd2ce: [DFSan] Add dfsan-combine-taint-lookup-table option as work around for (authored by browneee).
[DFSan] Add dfsan-combine-taint-lookup-table option as work around for
Apr 5 2022, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
browneee closed D122787: [DFSan] Add dfsan-combine-taint-lookup-table option as work around for false negatives when dfsan-combine-pointer-labels-on-load=0 and dfsan-combine-offset-labels-on-gep=0 miss data flows through lookup tables..
Apr 5 2022, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
browneee added inline comments to D122787: [DFSan] Add dfsan-combine-taint-lookup-table option as work around for false negatives when dfsan-combine-pointer-labels-on-load=0 and dfsan-combine-offset-labels-on-gep=0 miss data flows through lookup tables..
Apr 5 2022, 11:06 AM · Restricted Project, Restricted Project, Restricted Project
browneee updated the diff for D122787: [DFSan] Add dfsan-combine-taint-lookup-table option as work around for false negatives when dfsan-combine-pointer-labels-on-load=0 and dfsan-combine-offset-labels-on-gep=0 miss data flows through lookup tables..

Fix extra braces.

Apr 5 2022, 11:05 AM · Restricted Project, Restricted Project, Restricted Project
browneee removed a reviewer for D122787: [DFSan] Add dfsan-combine-taint-lookup-table option as work around for false negatives when dfsan-combine-pointer-labels-on-load=0 and dfsan-combine-offset-labels-on-gep=0 miss data flows through lookup tables.: kda.
Apr 5 2022, 10:45 AM · Restricted Project, Restricted Project, Restricted Project
browneee added a reviewer for D122787: [DFSan] Add dfsan-combine-taint-lookup-table option as work around for false negatives when dfsan-combine-pointer-labels-on-load=0 and dfsan-combine-offset-labels-on-gep=0 miss data flows through lookup tables.: kda.
Apr 5 2022, 10:45 AM · Restricted Project, Restricted Project, Restricted Project

Apr 4 2022

browneee added a comment to D122251: [lit] Use sharding for GoogleTest format.

This re-land seems to have broken this buildbot: https://lab.llvm.org/buildbot/#/builders/169

Apr 4 2022, 10:35 AM · Restricted Project, Restricted Project
browneee updated the diff for D122787: [DFSan] Add dfsan-combine-taint-lookup-table option as work around for false negatives when dfsan-combine-pointer-labels-on-load=0 and dfsan-combine-offset-labels-on-gep=0 miss data flows through lookup tables..

Rebase

Apr 4 2022, 10:21 AM · Restricted Project, Restricted Project, Restricted Project

Mar 31 2022

browneee updated the diff for D122787: [DFSan] Add dfsan-combine-taint-lookup-table option as work around for false negatives when dfsan-combine-pointer-labels-on-load=0 and dfsan-combine-offset-labels-on-gep=0 miss data flows through lookup tables..

Rebase.

Mar 31 2022, 1:51 PM · Restricted Project, Restricted Project, Restricted Project
browneee requested review of D122787: [DFSan] Add dfsan-combine-taint-lookup-table option as work around for false negatives when dfsan-combine-pointer-labels-on-load=0 and dfsan-combine-offset-labels-on-gep=0 miss data flows through lookup tables..
Mar 31 2022, 12:15 AM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

browneee added inline comments to D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions.
Mar 29 2022, 2:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 14 2022

browneee committed rGdbf8c00b09d4: [DFSan] Remove trampolines to unblock opaque pointers. (Reland with fix) (authored by browneee).
[DFSan] Remove trampolines to unblock opaque pointers. (Reland with fix)
Mar 14 2022, 4:04 PM · Restricted Project
browneee added a reverting change for rG84af90336fed: [DFSan] Remove trampolines to unblock opaque pointers.: rGedc33fa56954: Revert "[DFSan] Remove trampolines to unblock opaque pointers.".
Mar 14 2022, 1:48 PM · Restricted Project
browneee committed rGedc33fa56954: Revert "[DFSan] Remove trampolines to unblock opaque pointers." (authored by browneee).
Revert "[DFSan] Remove trampolines to unblock opaque pointers."
Mar 14 2022, 1:48 PM · Restricted Project
browneee added a reverting change for D121250: [DFSan] Remove trampolines to unblock opaque pointers.: rGedc33fa56954: Revert "[DFSan] Remove trampolines to unblock opaque pointers.".
Mar 14 2022, 1:48 PM · Restricted Project, Restricted Project, Restricted Project
browneee committed rG84af90336fed: [DFSan] Remove trampolines to unblock opaque pointers. (authored by browneee).
[DFSan] Remove trampolines to unblock opaque pointers.
Mar 14 2022, 1:42 PM · Restricted Project
browneee closed D121250: [DFSan] Remove trampolines to unblock opaque pointers..
Mar 14 2022, 1:41 PM · Restricted Project, Restricted Project, Restricted Project
browneee updated the diff for D121250: [DFSan] Remove trampolines to unblock opaque pointers..

Rebase.

Mar 14 2022, 10:37 AM · Restricted Project, Restricted Project, Restricted Project
browneee committed rG18564095a707: [DFSan] Remove use of setarch in dfsan test. (authored by browneee).
[DFSan] Remove use of setarch in dfsan test.
Mar 14 2022, 10:04 AM · Restricted Project
browneee closed D121439: [DFSan] Remove use of setarch in dfsan test..
Mar 14 2022, 10:04 AM · Restricted Project, Restricted Project

Mar 10 2022

browneee requested review of D121439: [DFSan] Remove use of setarch in dfsan test..
Mar 10 2022, 6:59 PM · Restricted Project, Restricted Project

Mar 8 2022

browneee committed rG12bfea58b8ff: [DFSan] Fix several bugs in dfsan custom callbacks test. (authored by browneee).
[DFSan] Fix several bugs in dfsan custom callbacks test.
Mar 8 2022, 2:27 PM · Restricted Project
browneee closed D121249: [DFSan] Fix several bugs in dfsan custom callbacks test..
Mar 8 2022, 2:27 PM · Restricted Project, Restricted Project
browneee added inline comments to D121250: [DFSan] Remove trampolines to unblock opaque pointers..
Mar 8 2022, 1:36 PM · Restricted Project, Restricted Project, Restricted Project