- User Since
- Apr 27 2015, 11:17 AM (172 w, 6 d)
Fri, Aug 17
A few comments/questions.
Thu, Aug 16
Remove extraneous commented line.
Tue, Aug 14
Mon, Aug 13
That new DITemplateValueParameter type doesn't look correct to me.
Fri, Aug 10
No objections from the gold plugin side, but like Hans I don't feel I know much about all the implications. Perhaps wait for the answer on the binutils thread first, but if they can't remove the dlclose there then this seems ok to me.
Sorry for the late reply - I am just today back from vacation and catching up. This LGTM, but as Steven noted, please add a description to the commit message.
Sun, Jul 29
Sat, Jul 28
Thu, Jul 26
LGTM with one minor comment nit below. See if pcc has any more comments though.
Wed, Jul 25
Code change looks fine, but please reduce the test case. - there's a lot of stuff there that likely isn't needed to reproduce.
Mon, Jul 23
Jul 20 2018
Jul 19 2018
Fix test comments
Jul 18 2018
Jul 17 2018
This would be useful for my own analysis of missed inlines. A few nits.
Jul 16 2018
Awesome, thanks! This was future work that we didn't have the bandwidth to address. A few comments/suggestions:
Jul 13 2018
Remove extraneous change to test that snuck in
Address comments: fix header and test comments.
Jul 12 2018
I'd like Peter to comment on the code changes, but note that the two failures are gold issues that have been fixed in binutils (https://bugs.llvm.org/show_bug.cgi?id=36166).
Jul 11 2018
Jul 10 2018
Rework based on discussion