- User Since
- Apr 27 2015, 11:17 AM (142 w, 2 d)
Fri, Jan 12
The same handling occurs for regular LTO (setting LinkerRedefined to WeakAny only when prevailing). Is this a problem there? If not, why? Answering my own question perhaps, but I guess this is because in the ThinLTO case we end up importing bar2 and therefore promoting it to external linkage instead of leaving it alone which would cause it to be internalized?
Sorry for the delay! I have one big concern below. Will look at the code that does the graph emission next, I've only skimmed that part.
Tue, Jan 9
Mon, Jan 8
Tue, Jan 2
Fri, Dec 29
Thu, Dec 28
Fri, Dec 22
LGTM assuming the answer to my question below is "yes". =)
Thanks this looks much nicer. Question below about the handling of the Optional though.
LGTM with one minor comment nit.
Thu, Dec 21
Thanks! Couple suggestions.
Wed, Dec 20
Tue, Dec 19
Dec 18 2017
Just a couple of minor comments - thanks for adding the test. With those fixed it looks good from my perspective, but please wait for labath to sign off.
Dec 15 2017
ping - Peter, would you be able to take a look at the changes?
Nice! This looks very useful. What exactly does the python script do? I suppose the script must have been used to create the attached .png graph, since it has GV names and not GUIDs?
Add a test? You can use llvm-lto to trigger this legacy interface - although it looks like no support was added to llvm-lto to invoke this interface. It should be straightforward to add that (see where it calls setCacheDir).
Dec 14 2017
Simplify test case
Dec 13 2017
Dec 12 2017
Dec 11 2017
Dec 6 2017
Dec 1 2017
Nov 30 2017
LGTM - I assume the modified test fails without the patch? I can't tell from looking at it whether it anon would have dead constant users.
Nov 22 2017
Nov 20 2017
Remove ModuleID and source_filename
Simplify the test case as much as possible
Nov 14 2017