Page MenuHomePhabricator

tejohnson (Teresa Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 27 2015, 11:17 AM (246 w, 4 d)

Recent Activity

Yesterday

tejohnson updated the diff for D71913: [LTO/WPD] Enable aggressive WPD under LTO option.

Rebase

Thu, Jan 16, 12:08 PM · Restricted Project, Restricted Project
tejohnson updated the diff for D71911: [ThinLTO] Summarize vcall_visibility metadata.

Rebase

Thu, Jan 16, 12:08 PM · Restricted Project, Restricted Project
tejohnson updated the diff for D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables.

Rebase

Thu, Jan 16, 11:58 AM · Restricted Project, Restricted Project
tejohnson accepted D72818: [GlobalsModRef] Add invalidate method.

LGTM. Thanks for the explanation.

Thu, Jan 16, 10:03 AM · Restricted Project
tejohnson added a comment to D72818: [GlobalsModRef] Add invalidate method.

Not a bug fix, but a prerequisite for a change I'm working on for the new pass manager, requiring all passes to have an invalidate method.
I sent it for review to get another pair of eyes on the invalidate implementation in case I missed something.

Thu, Jan 16, 9:44 AM · Restricted Project
tejohnson added inline comments to D71913: [LTO/WPD] Enable aggressive WPD under LTO option.
Thu, Jan 16, 9:16 AM · Restricted Project, Restricted Project
tejohnson added a comment to D71911: [ThinLTO] Summarize vcall_visibility metadata.

I think this has to be rebased - I see multiple failures when trying to apply

Thu, Jan 16, 6:19 AM · Restricted Project, Restricted Project

Wed, Jan 15

tejohnson accepted D72547: [llvm] Make new pass manager's OptimizationLevel a class.

One thing to consider changing/removing in the summary is this comment:
"For example, (enum) "Level > 1" captures not only O2 and O3, but also Os, and Oz."
since that is actually correct (Os/Oz should be included in Level>1 as they are O2).

Wed, Jan 15, 10:05 PM · Restricted Project, Restricted Project
tejohnson added a comment to D72818: [GlobalsModRef] Add invalidate method.

Is this a bugfix and should there be a test case?

Wed, Jan 15, 9:59 PM · Restricted Project
tejohnson committed rG76b92cc7c1fa: Fix bot by adjusting wildcard matching (authored by tejohnson).
Fix bot by adjusting wildcard matching
Wed, Jan 15, 8:40 AM
tejohnson committed rG24a00ef24041: Restore "[ThinLTO] Add additional ThinLTO pipeline testing with new PM" (authored by tejohnson).
Restore "[ThinLTO] Add additional ThinLTO pipeline testing with new PM"
Wed, Jan 15, 7:35 AM

Tue, Jan 14

tejohnson added a comment to D72624: [WIP] TargetMachine Hook for Module Metadata.

From an LTO perspective, this seems fine for the reasons we discussed here. I looked through the patch and have a few comments.

Tue, Jan 14, 6:38 PM · Restricted Project, Restricted Project, Restricted Project
tejohnson added a comment to D72547: [llvm] Make new pass manager's OptimizationLevel a class.

Overall I like this approach.

Tue, Jan 14, 5:05 PM · Restricted Project, Restricted Project
tejohnson added a comment to D72624: [WIP] TargetMachine Hook for Module Metadata.

(just a general comment that this code review should be only in service of the design discussion happening on llvm-dev - please don't approve/commit this without closing out the design discussion there if there are actionable conclusions from this review)

Tue, Jan 14, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
tejohnson added a comment to D72624: [WIP] TargetMachine Hook for Module Metadata.

Thank you for your feedback! It has been very helpful.

I'm not sure if ThinLTOCodeGenerator.cpp and LTOBackend.cpp were intentionally left out due to the LTO concerns mentioned in the description?

Mostly left out because I wasn't sure how to attack them. I've got an update to this patch which I'm testing right now and it looks much better. I will post that imminently.

Note if we are just passing in the Module and updating the TM based on that, it wouldn't hit the threading issue I mentioned in D72245, but neither would you get the proper aggregation/checking across ThinLTO'ed modules.

Ok, right, so I think I know what else this patch needs to do. At the moment, I think the ModFlagBehavior for module flags are not being checked during ThinLTO. I think this is something that has to be checked for compatibility in ThinLTOCodeGenerator::addModule (like the triple is checked for compatibility).

Tue, Jan 14, 1:38 PM · Restricted Project, Restricted Project, Restricted Project
tejohnson updated the diff for D71913: [LTO/WPD] Enable aggressive WPD under LTO option.

Address comments

Tue, Jan 14, 11:11 AM · Restricted Project, Restricted Project
tejohnson added inline comments to D71913: [LTO/WPD] Enable aggressive WPD under LTO option.
Tue, Jan 14, 11:11 AM · Restricted Project, Restricted Project
tejohnson committed rG2cefb93951cc: [ThinLTO/WPD] Remove an overly-aggressive assert (authored by tejohnson).
[ThinLTO/WPD] Remove an overly-aggressive assert
Tue, Jan 14, 11:03 AM
tejohnson closed D72648: [ThinLTO/WPD] Remove an overly-aggressive assert.
Tue, Jan 14, 11:02 AM · Restricted Project
tejohnson committed rG7dc4bbf8ab31: [ThinLTO] Handle variable with twice promoted name (Rust) (authored by tejohnson).
[ThinLTO] Handle variable with twice promoted name (Rust)
Tue, Jan 14, 10:55 AM
tejohnson closed D72711: [ThinLTO] Handle variable with twice promoted name (Rust).
Tue, Jan 14, 10:55 AM · Restricted Project
tejohnson updated the diff for D72711: [ThinLTO] Handle variable with twice promoted name (Rust).

Address comments

Tue, Jan 14, 10:54 AM · Restricted Project
tejohnson accepted D70404: [ThinLTO] Always import constants.

LGTM

Tue, Jan 14, 9:36 AM · Restricted Project
tejohnson added a comment to D70404: [ThinLTO] Always import constants.

Can you re-upload the latest with context? It isn't available and therefore I can't compare the last two diffs.

Tue, Jan 14, 8:50 AM · Restricted Project
tejohnson created D72711: [ThinLTO] Handle variable with twice promoted name (Rust).
Tue, Jan 14, 8:21 AM · Restricted Project

Mon, Jan 13

tejohnson accepted D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files.

LGTM. One more request for a comment below that I forgot to add earlier.

Mon, Jan 13, 4:50 PM · Restricted Project
tejohnson added a comment to D71040: [ThinLTO/WPD] Fix index-based WPD for alias vtables.

Could you possibly try check-all or check-llvm? This problem was occuring in the LLVM unit tests.

This did work. We have two vftable aliases with external linkage, that's why assertion fires. They're both attached to comdat, so there are no link errors.
May be just remove assertion?

This appears to be an unrelated issue then, and should probably be fixed in a separate patch. Can this one be approved and go in, and I'll make sure I can repro and then fix this one?

Mon, Jan 13, 2:11 PM · Restricted Project
tejohnson created D72648: [ThinLTO/WPD] Remove an overly-aggressive assert.
Mon, Jan 13, 2:11 PM · Restricted Project
tejohnson committed rG31441a3e0078: [ThinLTO/WPD] Fix index-based WPD for alias vtables (authored by tejohnson).
[ThinLTO/WPD] Fix index-based WPD for alias vtables
Mon, Jan 13, 1:43 PM
tejohnson closed D71040: [ThinLTO/WPD] Fix index-based WPD for alias vtables.
Mon, Jan 13, 1:43 PM · Restricted Project
tejohnson added inline comments to D71040: [ThinLTO/WPD] Fix index-based WPD for alias vtables.
Mon, Jan 13, 1:15 PM · Restricted Project
tejohnson added inline comments to D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata.
Mon, Jan 13, 12:28 PM · Restricted Project, Restricted Project
tejohnson committed rGd0aad9f56e15: [LTO] Constify lto::Config reference passed to backends (NFC) (authored by tejohnson).
[LTO] Constify lto::Config reference passed to backends (NFC)
Mon, Jan 13, 12:28 PM
tejohnson added inline comments to D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files.
Mon, Jan 13, 12:18 PM · Restricted Project
tejohnson committed rG6288f86e870c: Revert "[ThinLTO] Add additional ThinLTO pipeline testing with new PM" (authored by tejohnson).
Revert "[ThinLTO] Add additional ThinLTO pipeline testing with new PM"
Mon, Jan 13, 11:22 AM
tejohnson added a reverting change for rG2af97be8027a: [ThinLTO] Add additional ThinLTO pipeline testing with new PM: rG6288f86e870c: Revert "[ThinLTO] Add additional ThinLTO pipeline testing with new PM".
Mon, Jan 13, 11:22 AM
tejohnson committed rGcb988a858abb: Add a couple of missed wildcards in debug-pass-manager output checking (authored by tejohnson).
Add a couple of missed wildcards in debug-pass-manager output checking
Mon, Jan 13, 10:54 AM
tejohnson committed rG7aed43b60739: Hopefully last fix for bot failures (authored by tejohnson).
Hopefully last fix for bot failures
Mon, Jan 13, 10:35 AM
tejohnson committed rG292562c0046c: Try number 2 for fixing bot failures (authored by tejohnson).
Try number 2 for fixing bot failures
Mon, Jan 13, 10:16 AM
tejohnson added a comment to D72624: [WIP] TargetMachine Hook for Module Metadata.

I'm not sure if ThinLTOCodeGenerator.cpp and LTOBackend.cpp were intentionally left out due to the LTO concerns mentioned in the description?

Mon, Jan 13, 9:57 AM · Restricted Project, Restricted Project, Restricted Project
tejohnson committed rGbb2e5f5e4542: Fix tests for builtbot failures (authored by tejohnson).
Fix tests for builtbot failures
Mon, Jan 13, 9:28 AM
tejohnson added inline comments to D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata.
Mon, Jan 13, 8:41 AM · Restricted Project, Restricted Project
tejohnson committed rG2af97be8027a: [ThinLTO] Add additional ThinLTO pipeline testing with new PM (authored by tejohnson).
[ThinLTO] Add additional ThinLTO pipeline testing with new PM
Mon, Jan 13, 8:32 AM
tejohnson closed D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM.
Mon, Jan 13, 8:31 AM · Restricted Project, Restricted Project
tejohnson added a comment to D70404: [ThinLTO] Always import constants.

Sorry for the delay, I lost track of this one.

Mon, Jan 13, 8:12 AM · Restricted Project
tejohnson added inline comments to D72245: [PoC][RISCV][LTO] Pass target-abi via module flag metadata.
Mon, Jan 13, 7:44 AM · Restricted Project, Restricted Project

Fri, Jan 10

tejohnson added a comment to D72523: [remark][diagnostics] Using clang diagnostic handler for IR input files.

Thanks for fixing this missing -Rpass support!

Fri, Jan 10, 6:46 PM · Restricted Project
tejohnson added a comment to D72547: [llvm] Make new pass manager's OptimizationLevel a class.

I just have a few high level comments from looking through it just now. The summary needs a fix since Os/Oz are in fact O2 so OptLevel > 1 was not doing the wrong thing.

Fri, Jan 10, 5:47 PM · Restricted Project, Restricted Project
tejohnson updated the diff for D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM.

Implement suggestion.

Fri, Jan 10, 4:53 PM · Restricted Project, Restricted Project
tejohnson added a comment to D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM.
In D72538#1815074, @wmi wrote:

The additional pipeline testing will catch any future pass change to the pipeline. A related but separate question is do we have a way to check whether there is any other missing pass in thinlto newpm similar as that in D72386?

Fri, Jan 10, 4:53 PM · Restricted Project, Restricted Project
tejohnson updated the diff for D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM.

Remove some cruft

Fri, Jan 10, 1:48 PM · Restricted Project, Restricted Project
tejohnson created D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM.
Fri, Jan 10, 1:38 PM · Restricted Project, Restricted Project

Thu, Jan 9

tejohnson accepted D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend.

A few minor suggestions for comment tweaks, but lgtm otherwise.

Thu, Jan 9, 4:51 PM · Restricted Project, Restricted Project
tejohnson added inline comments to D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend.
Thu, Jan 9, 2:19 PM · Restricted Project, Restricted Project
tejohnson added a comment to D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend.

Thanks! Looks pretty good, I just have a few comments and questions.

Thu, Jan 9, 1:41 PM · Restricted Project, Restricted Project

Wed, Jan 8

tejohnson committed rG43f938eddc8a: LTOVisibility.rst: fix up syntax in example (authored by tejohnson).
LTOVisibility.rst: fix up syntax in example
Wed, Jan 8, 11:45 AM
tejohnson closed D70765: LTOVisibility.rst: fix up syntax in example.
Wed, Jan 8, 11:45 AM · Restricted Project, Restricted Project
tejohnson added a comment to D70765: LTOVisibility.rst: fix up syntax in example.

Typically the author commits the patch, unless they don't have commit access and request the reviewer to commit for them, but I don't see a request for that here.

Thanks, Teresa. I indeed do not have commit access (so far as I know or can tell, anyway), so please consider this comment to be such a request.

Wed, Jan 8, 9:52 AM · Restricted Project, Restricted Project
tejohnson added a comment to D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend.
In D72386#1810284, @wmi wrote:

Teresa, do we have existing tests where I can add some check to see if some passes are executed for the lld and gold plugin changes?

Wed, Jan 8, 9:33 AM · Restricted Project, Restricted Project
tejohnson added a comment to D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend.

Thinking through this some more - this patch fixes the distributed ThinLTO backend case, but not the in-process ThinLTO case. For that, both lld and gold plugin will need to set this up. And since they don't have the clang options, they will just need to set to some reasonable default, probably either hardwired on like in the old PM or set based on the CGOptLevel they set from linker options. However, they both default to -O2 unless a special plugin or lld linker option is set, so we'd probably want to enable these passes there at O2+.

Wed, Jan 8, 8:37 AM · Restricted Project, Restricted Project
tejohnson added a comment to D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend.

I think the old PM has some issues as well, although more in the opposite direction. The code in LTOBackend.cpp:runOldPMPasses is simply hardcoding loop and slp vectorization flags to true, but presumably should use whatever is passed through the lto Config as well. Not sure about LoopsInterleaved, ah looks like it is set to the value of the internal option which is enabled by default. That and DisableUnrollLoops should also use whatever is passed through here (similar to how they are set in clang BackendUtil.cpp when configuring the old PM).

Wed, Jan 8, 6:53 AM · Restricted Project, Restricted Project

Tue, Jan 7

tejohnson added a comment to D71040: [ThinLTO/WPD] Fix index-based WPD for alias vtables.

Could you possibly try check-all or check-llvm? This problem was occuring in the LLVM unit tests.

This did work. We have two vftable aliases with external linkage, that's why assertion fires. They're both attached to comdat, so there are no link errors.
May be just remove assertion?

Tue, Jan 7, 11:41 AM · Restricted Project
tejohnson added a comment to D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++.

AFAIU here is a coarse plan of what needs to happen

Tue, Jan 7, 9:55 AM · Restricted Project, Restricted Project

Mon, Jan 6

tejohnson added a comment to D70765: LTOVisibility.rst: fix up syntax in example.

I hate to bother anyone, but can this go ahead and get merged? :) thanks

Mon, Jan 6, 7:38 AM · Restricted Project, Restricted Project
tejohnson updated subscribers of D71710: [instrinsics] Add @llvm.memcpy.inline instrinsics.

Can someone else have a look and approve this patch?

Mon, Jan 6, 7:20 AM · Restricted Project

Sun, Dec 29

tejohnson updated the diff for D71911: [ThinLTO] Summarize vcall_visibility metadata.

Attempt to fix patch to not include parent revision changes

Sun, Dec 29, 9:30 AM · Restricted Project, Restricted Project
tejohnson updated the diff for D71911: [ThinLTO] Summarize vcall_visibility metadata.

Implement suggested name change.

Sun, Dec 29, 9:29 AM · Restricted Project, Restricted Project

Fri, Dec 27

tejohnson added a comment to D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables.

Looks good at first sight. Do you have linker patch for me to try this out?

Fri, Dec 27, 6:37 AM · Restricted Project, Restricted Project

Thu, Dec 26

tejohnson created D71913: [LTO/WPD] Enable aggressive WPD under LTO option.
Thu, Dec 26, 11:55 AM · Restricted Project, Restricted Project
tejohnson added a child revision for D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables: D71913: [LTO/WPD] Enable aggressive WPD under LTO option.
Thu, Dec 26, 11:55 AM · Restricted Project, Restricted Project
tejohnson added a child revision for D71911: [ThinLTO] Summarize vcall_visibility metadata: D71913: [LTO/WPD] Enable aggressive WPD under LTO option.
Thu, Dec 26, 11:55 AM · Restricted Project, Restricted Project
tejohnson created D71911: [ThinLTO] Summarize vcall_visibility metadata.
Thu, Dec 26, 9:38 AM · Restricted Project, Restricted Project
tejohnson added a child revision for D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables: D71911: [ThinLTO] Summarize vcall_visibility metadata.
Thu, Dec 26, 9:38 AM · Restricted Project, Restricted Project
tejohnson added inline comments to D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables.
Thu, Dec 26, 9:10 AM · Restricted Project, Restricted Project
tejohnson created D71907: [WPD/VFE] Always emit vcall_visibility metadata for -fwhole-program-vtables.
Thu, Dec 26, 8:50 AM · Restricted Project, Restricted Project

Dec 17 2019

tejohnson accepted D71608: [ThinLTO] Show preserved symbols in DOT files.

lgtm

Dec 17 2019, 8:10 PM · Restricted Project

Dec 16 2019

tejohnson committed rG878ab6df033d: [TLI] Support for per-Function TLI that overrides available libfuncs (authored by tejohnson).
[TLI] Support for per-Function TLI that overrides available libfuncs
Dec 16 2019, 9:21 AM
tejohnson closed D67923: [TLI] Support for per-Function TLI that overrides available libfuncs.
Dec 16 2019, 9:20 AM · Restricted Project, Restricted Project
tejohnson updated the diff for D67923: [TLI] Support for per-Function TLI that overrides available libfuncs.

Address comments

Dec 16 2019, 9:20 AM · Restricted Project, Restricted Project

Dec 13 2019

tejohnson added a comment to D69732: [WIP][LTO] Apply SamplePGO pipeline tunes for ThinLTO pre-link to full LTO.

Given the performance improvements here, I'd like to develop this patch further.

In D69732#1784290, @ormris wrote:
Ping @tejohnson

@ormris, I think that since @tejohnson originally suggested that someone with more interest in full LTO performance pick this up (and she specifically suggested you or me), then you can feel free to take this over.

Dec 13 2019, 9:45 PM · Restricted Project, Restricted Project
tejohnson added a comment to D67923: [TLI] Support for per-Function TLI that overrides available libfuncs.

Please take a look. This is now updated to reflect the commit of D71193, which translated the options to the new attributes. I also removed some comments that I realized didn't make sense, as we need to keep a baseline availability array on the base TLII since that is set based on the architecture. We simply override this for no-builtin* attributes on the function. I removed the code from clang that was setting up the availability array based on the options, and all tests pass.

Dec 13 2019, 11:37 AM · Restricted Project, Restricted Project
tejohnson updated the diff for D67923: [TLI] Support for per-Function TLI that overrides available libfuncs.

Update after D71193 committed, converting -fno-builtin* options to attributes.

Dec 13 2019, 11:37 AM · Restricted Project, Restricted Project
tejohnson updated the summary of D67923: [TLI] Support for per-Function TLI that overrides available libfuncs.
Dec 13 2019, 11:37 AM · Restricted Project, Restricted Project

Dec 12 2019

tejohnson committed rGc8e0bb3b2c24: [LTO] Support for embedding bitcode section during LTO (authored by tejohnson).
[LTO] Support for embedding bitcode section during LTO
Dec 12 2019, 3:55 PM
tejohnson closed D68213: [LTO] Support for embedding bitcode section during LTO.
Dec 12 2019, 3:55 PM · Restricted Project, Restricted Project
tejohnson added a comment to D68213: [LTO] Support for embedding bitcode section during LTO.

Thanks again for you reviews! Since I do not have commit rights, I would be grateful if someone could push it for me.

Dec 12 2019, 8:14 AM · Restricted Project, Restricted Project
tejohnson accepted D71193: [clang] Turn -fno-builtin flag into an IR Attribute.
Dec 12 2019, 8:04 AM · Restricted Project
tejohnson added inline comments to D71193: [clang] Turn -fno-builtin flag into an IR Attribute.
Dec 12 2019, 7:36 AM · Restricted Project

Dec 11 2019

tejohnson added a comment to D71193: [clang] Turn -fno-builtin flag into an IR Attribute.

This LGTM, although I have a couple of questions that are orthogonal to this patch and shouldn't block it. Please wait to see if @aaron.ballman has any more comments.

Dec 11 2019, 10:30 AM · Restricted Project
tejohnson accepted D68213: [LTO] Support for embedding bitcode section during LTO.

LGTM with a few small suggestions before you commit.

Dec 11 2019, 9:54 AM · Restricted Project, Restricted Project

Dec 10 2019

tejohnson added inline comments to D68213: [LTO] Support for embedding bitcode section during LTO.
Dec 10 2019, 11:04 AM · Restricted Project, Restricted Project
tejohnson added a comment to D68213: [LTO] Support for embedding bitcode section during LTO.

It seems reasonable to support this from LTO since it provides analogous support to what is available via clang without LTO. @pcc what do you think?

Dec 10 2019, 6:38 AM · Restricted Project, Restricted Project

Dec 6 2019

tejohnson committed rGc8e36862f594: [WPD] Remove unused parameter (NFC) (authored by tejohnson).
[WPD] Remove unused parameter (NFC)
Dec 6 2019, 1:20 PM

Dec 5 2019

tejohnson committed rG54a3c2a81e1a: [ThinLTO] Add option to disable readonly/writeonly attribute propagation (authored by tejohnson).
[ThinLTO] Add option to disable readonly/writeonly attribute propagation
Dec 5 2019, 4:35 PM
tejohnson closed D70984: [ThinLTO] Add option to disable readonly/writeonly attribute propagation.
Dec 5 2019, 4:35 PM · Restricted Project
tejohnson updated the diff for D70984: [ThinLTO] Add option to disable readonly/writeonly attribute propagation.

Address comments

Dec 5 2019, 1:03 PM · Restricted Project
tejohnson added inline comments to D70984: [ThinLTO] Add option to disable readonly/writeonly attribute propagation.
Dec 5 2019, 1:03 PM · Restricted Project

Dec 4 2019

tejohnson created D71040: [ThinLTO/WPD] Fix index-based WPD for alias vtables.
Dec 4 2019, 6:05 PM · Restricted Project
tejohnson added inline comments to D69452: [ThinLTO/WPD] Fix index-based WPD for available_externally vtables.
Dec 4 2019, 6:05 PM · Restricted Project
tejohnson committed rGe420c0c78eb0: [ThinLTO] Fix importing of writeonly variables in distributed ThinLTO (authored by tejohnson).
[ThinLTO] Fix importing of writeonly variables in distributed ThinLTO
Dec 4 2019, 3:08 PM