- User Since
- Apr 27 2015, 11:17 AM (199 w, 4 d)
Sat, Feb 16
LGTM except for place noted below where I disagree with a change made earlier. Will let @davidxl chime in if he disagrees with me or has any other comments.
LGTM, but wait for @davidxl to do final approval since I'm not sure his last comments addressed.
Needs a test.
Thu, Feb 14
Decided to take a different approach for now.
Wed, Feb 13
Mon, Feb 11
The original change predates my involvement with LLVM, but it sounds like the only reason was just cleanup since it wasn't used elsewhere. I don't see any issue with adding this interface (similar to how we have exposed both parseIR and parseIRFile).
Fri, Feb 8
Overall it looks ok to me, but I'd like Chandler to comment regarding the preferred way to do this with the new PM, since we don't tend to use booleans there in the PassBuilder to control passes. Is it preferable to instead use a new function attribute instead of boolean flags on the PMs (e.g. the way -fno-inline is handled)?
Thu, Feb 7
Wed, Feb 6
Tue, Feb 5
Handle exported symbols correctly
Mon, Feb 4
Ugh sorry for committing before your LGTM - I saw the LGTM come in from you on the other patch but committed this one instead! Will leave it since you subsequently LGTM'ed.
Fri, Feb 1
Restore a couple of new tests that were lost when I updated the patch last.
Address suggestion: move error checking to LTO.cpp
Thu, Jan 31
Wed, Jan 30
Mostly minor comments inline. But still missing tests. Needs testing via new gold-plugin and opt options. Should also add options to llvm-lto2 to enable testing the LTOBackend path without needing gold or any other specific linker.
Tue, Jan 29
Mon, Jan 28
Fri, Jan 25
Two clarifications below:
Use an abbrev id in the bitcode for the new TYPE_ID_METADATA records.
This makes them a bit more compact.
Ping on review plus some numbers and a small improvement that I will upload shortly.
Use any_of as suggested in comments.
Thu, Jan 24
Jan 23 2019
LGTM with suggestion about cutting down test.
Jan 18 2019
Jan 17 2019
Reverted in r351455.
This was a mistaken commit, reverting!
Jan 16 2019
Bunch of mostly nit suggestions about names and commenting, and a few questions. I like the improved profile action expression.
Jan 15 2019
I noticed that this file is out of sync with the llvm version already, which you are also fixing here. Can you go ahead and commit just the sync with the current llvm head version now as an NFC change so that this patch is just the new changes?
Jan 11 2019
Update patch to reflect changes at head.
I just stumbled on this patch - sorry for the late review! I thought this was already in. A few comments and a question below. Also, presumably this should be done for the old PM as well?