Page MenuHomePhabricator

dvyukov (Dmitry Vyukov)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 6 2012, 2:31 AM (494 w, 1 d)

Recent Activity

Fri, May 20

dvyukov added a comment to D110552: tsan: add lock free stack pattern test.

I think there may be some flakes and the best way to address it for now may be adding a constraint to not run it on PPC.

Fri, May 20, 9:34 AM · Restricted Project, Restricted Project
dvyukov committed rG5deca650fdba: tsan: add lock free stack pattern test (authored by alexey-katranov).
tsan: add lock free stack pattern test
Fri, May 20, 4:36 AM · Restricted Project, Restricted Project
dvyukov closed D110552: tsan: add lock free stack pattern test.
Fri, May 20, 4:36 AM · Restricted Project, Restricted Project
dvyukov added a comment to D110552: tsan: add lock free stack pattern test.

This felt through the cracks, sorry.
The change looks reasonably good to me and I guess it's not good to do nitpicking after such long delay.
I've run clang-format on this, rebased and run tests (passed).

Fri, May 20, 4:35 AM · Restricted Project, Restricted Project
dvyukov accepted D110552: tsan: add lock free stack pattern test.
Fri, May 20, 4:34 AM · Restricted Project, Restricted Project

Tue, May 17

dvyukov added a comment to D125762: [tsan] Fix the longjmp sp slot on FreeBSD AArch64.

I don't have any objections.

Tue, May 17, 4:52 AM · Restricted Project, Restricted Project

Tue, May 3

dvyukov added a comment to D124507: tsan: model atomic read for failing CAS.

Yes, debug versions of compare_exchange.cpp and atomic_norace2.cpp hang with:

Tue, May 3, 5:56 AM · Restricted Project, Restricted Project
dvyukov added a comment to D124832: sanitizer: support GCC's fallthrough attribute.

If this is a new warning, maybe reordering these will help:

Tue, May 3, 4:44 AM · Restricted Project, Restricted Project
dvyukov accepted D124828: tsan: fix GCC warnings.
Tue, May 3, 3:49 AM · Restricted Project, Restricted Project
dvyukov accepted D124838: tsan: fix deadlock in libbacktrace.
Tue, May 3, 3:48 AM · Restricted Project, Restricted Project
dvyukov added inline comments to D124828: tsan: fix GCC warnings.
Tue, May 3, 2:19 AM · Restricted Project, Restricted Project
dvyukov accepted D124829: sanitizer: use pragma clang conditionally.
Tue, May 3, 2:15 AM · Restricted Project, Restricted Project
dvyukov accepted D124832: sanitizer: support GCC's fallthrough attribute.
Tue, May 3, 2:14 AM · Restricted Project, Restricted Project

Mon, May 2

dvyukov added a comment to D124507: tsan: model atomic read for failing CAS.

sanitizer-x86_64-linux-autoconf failed:

Mon, May 2, 4:39 AM · Restricted Project, Restricted Project
dvyukov added a comment to D124507: tsan: model atomic read for failing CAS.

I've merged this. In few weeks it will pass more extensive testing, if there will be unforeseen issues, I will revert this. But at least we will know on what code it fails and add a test.

Mon, May 2, 3:59 AM · Restricted Project, Restricted Project
dvyukov committed rG2fec52a40261: tsan: model atomic read for failing CAS (authored by dvyukov).
tsan: model atomic read for failing CAS
Mon, May 2, 3:58 AM · Restricted Project, Restricted Project
dvyukov closed D124507: tsan: model atomic read for failing CAS.
Mon, May 2, 3:58 AM · Restricted Project, Restricted Project

Apr 27 2022

dvyukov committed rG16baf59c6d0b: tsan: avoid false positives related to epoll (authored by dvyukov).
tsan: avoid false positives related to epoll
Apr 27 2022, 8:00 AM · Restricted Project, Restricted Project
dvyukov closed D124518: tsan: avoid false positives related to epoll.
Apr 27 2022, 8:00 AM · Restricted Project, Restricted Project
dvyukov requested review of D124518: tsan: avoid false positives related to epoll.
Apr 27 2022, 3:51 AM · Restricted Project, Restricted Project
dvyukov added a comment to D124507: tsan: model atomic read for failing CAS.

This is tricky, I am not 100% sure (1) it's the right thing to do, (2) that destruction safety problem (see the comment) will hit us or not (maybe there are some other cases I don't see).

Apr 27 2022, 1:40 AM · Restricted Project, Restricted Project
dvyukov added a comment to D124507: tsan: model atomic read for failing CAS.

This is tricky, I am not 100% sure (1) it's the right thing to do, (2) that destruction safety problem (see the comment) will hit us or not (maybe there are some other cases I don't see).

Apr 27 2022, 1:37 AM · Restricted Project, Restricted Project
dvyukov requested review of D124507: tsan: model atomic read for failing CAS.
Apr 27 2022, 1:34 AM · Restricted Project, Restricted Project

Apr 25 2022

dvyukov accepted D124390: [compiler-rt][NFC] Inclusive language: remove use of sanity check/test.
Apr 25 2022, 7:52 AM · Restricted Project, Restricted Project

Apr 1 2022

dvyukov committed rGea624e697bbe: sanitizer_common: add Mutex::TryLock (authored by dvyukov).
sanitizer_common: add Mutex::TryLock
Apr 1 2022, 8:56 AM · Restricted Project, Restricted Project
dvyukov closed D122905: sanitizer_common: add Mutex::TryLock.
Apr 1 2022, 8:56 AM · Restricted Project, Restricted Project
dvyukov committed rGabc51fac0959: sanitizer_common: expose max_address from LoadedModule (authored by dvyukov).
sanitizer_common: expose max_address from LoadedModule
Apr 1 2022, 8:56 AM · Restricted Project, Restricted Project
dvyukov closed D122906: sanitizer_common: expose max_address from LoadedModule.
Apr 1 2022, 8:56 AM · Restricted Project, Restricted Project
dvyukov requested review of D122906: sanitizer_common: expose max_address from LoadedModule.
Apr 1 2022, 7:38 AM · Restricted Project, Restricted Project
dvyukov requested review of D122905: sanitizer_common: add Mutex::TryLock.
Apr 1 2022, 7:33 AM · Restricted Project, Restricted Project

Mar 24 2022

dvyukov committed rG1d4d2cceda82: [TSan] Add a runtime flag to print full thread creation stacks up to the main… (authored by dvyukov).
[TSan] Add a runtime flag to print full thread creation stacks up to the main…
Mar 24 2022, 9:31 AM · Restricted Project
dvyukov closed D122131: [TSan] Add a runtime flag to print full thread creation stacks up to the main thread.
Mar 24 2022, 9:30 AM · Restricted Project, Restricted Project

Mar 22 2022

dvyukov accepted D122131: [TSan] Add a runtime flag to print full thread creation stacks up to the main thread.
Mar 22 2022, 1:25 AM · Restricted Project, Restricted Project
dvyukov added inline comments to D122131: [TSan] Add a runtime flag to print full thread creation stacks up to the main thread.
Mar 22 2022, 12:38 AM · Restricted Project, Restricted Project

Mar 21 2022

dvyukov added a comment to D122131: [TSan] Add a runtime flag to print full thread creation stacks up to the main thread.

clang-format: please reformat the code

Mar 21 2022, 7:18 AM · Restricted Project, Restricted Project

Mar 18 2022

dvyukov committed rG9e66e5872c4a: tsan: print signal num in errno spoiling reports (authored by dvyukov).
tsan: print signal num in errno spoiling reports
Mar 18 2022, 8:12 AM · Restricted Project
dvyukov closed D121979: tsan: print signal num in errno spoiling reports.
Mar 18 2022, 8:12 AM · Restricted Project, Restricted Project
dvyukov added inline comments to D121979: tsan: print signal num in errno spoiling reports.
Mar 18 2022, 2:32 AM · Restricted Project, Restricted Project
dvyukov added inline comments to D121979: tsan: print signal num in errno spoiling reports.
Mar 18 2022, 2:23 AM · Restricted Project, Restricted Project

Mar 17 2022

dvyukov updated the diff for D121979: tsan: print signal num in errno spoiling reports.

fixed code style

Mar 17 2022, 11:30 PM · Restricted Project, Restricted Project
dvyukov requested review of D121979: tsan: print signal num in errno spoiling reports.
Mar 17 2022, 11:28 PM · Restricted Project, Restricted Project
dvyukov accepted D121910: [Instruction] Introduce getAtomicSyncScopeID().
Mar 17 2022, 6:46 AM · Restricted Project, Restricted Project

Mar 10 2022

dvyukov committed rG66298e1c54fc: tsan: fix another false positive related to open/close (authored by dvyukov).
tsan: fix another false positive related to open/close
Mar 10 2022, 8:03 AM · Restricted Project
dvyukov closed D121363: tsan: fix another false positive related to open/close.
Mar 10 2022, 8:02 AM · Restricted Project, Restricted Project
dvyukov requested review of D121363: tsan: fix another false positive related to open/close.
Mar 10 2022, 2:20 AM · Restricted Project, Restricted Project

Mar 8 2022

dvyukov accepted D121207: [compiler-rt][mips] Fix the condition to include sanitizer_atomic_clang_mips.h.
Mar 8 2022, 11:36 PM · Restricted Project, Restricted Project
dvyukov committed rGf831d6fc800c: tsan: fix false positive during fd close (authored by dvyukov).
tsan: fix false positive during fd close
Mar 8 2022, 1:41 AM · Restricted Project
dvyukov closed D121143: tsan: fix false positive during fd close.
Mar 8 2022, 1:41 AM · Restricted Project, Restricted Project
dvyukov added inline comments to D121143: tsan: fix false positive during fd close.
Mar 8 2022, 1:39 AM · Restricted Project, Restricted Project

Mar 7 2022

dvyukov requested review of D121143: tsan: fix false positive during fd close.
Mar 7 2022, 11:43 AM · Restricted Project, Restricted Project

Feb 17 2022

dvyukov accepted D120050: tsan: Add a missing disable_sanitizer_instrumentation attribute.
Feb 17 2022, 6:25 AM · Restricted Project

Feb 12 2022

dvyukov added inline comments to D119546: sanitizer_common: make internal/external headers compatible.
Feb 12 2022, 1:19 AM · Restricted Project

Feb 11 2022

dvyukov committed rG54e96ac835f2: hwasan: fix up includes (authored by dvyukov).
hwasan: fix up includes
Feb 11 2022, 11:41 AM
dvyukov closed D119570: hwasan: fix up includes.
Feb 11 2022, 11:41 AM · Restricted Project
dvyukov added a comment to D119546: sanitizer_common: make internal/external headers compatible.

Hi, I've mailed D119570 to fix this. Thanks for reporting.

Feb 11 2022, 11:40 AM · Restricted Project
dvyukov requested review of D119570: hwasan: fix up includes.
Feb 11 2022, 11:39 AM · Restricted Project
dvyukov committed rG595d340dceca: sanitizer_common: make internal/external headers compatible (authored by dvyukov).
sanitizer_common: make internal/external headers compatible
Feb 11 2022, 10:40 AM
dvyukov closed D119546: sanitizer_common: make internal/external headers compatible.
Feb 11 2022, 10:39 AM · Restricted Project
dvyukov added a comment to D119546: sanitizer_common: make internal/external headers compatible.

Note, __sanitizer_sandbox_arguments seems unused, i.e. I don't see any of its members used anywhere?

Can we just delete that struct completely from everywhere and just change the "args" to a void* everywhere?

Is this used in a non-LLVM codebase for something?

Feb 11 2022, 9:00 AM · Restricted Project
dvyukov added a comment to D119546: sanitizer_common: make internal/external headers compatible.

PTAL

Feb 11 2022, 8:21 AM · Restricted Project
dvyukov updated the diff for D119546: sanitizer_common: make internal/external headers compatible.

removed the interface header from sanitizer_common.h

Feb 11 2022, 8:20 AM · Restricted Project
dvyukov added inline comments to D119546: sanitizer_common: make internal/external headers compatible.
Feb 11 2022, 7:17 AM · Restricted Project
dvyukov requested review of D119546: sanitizer_common: make internal/external headers compatible.
Feb 11 2022, 7:16 AM · Restricted Project
dvyukov added a comment to D119417: [TSan][NFC] fixup for comment of Shadow.

Is there any paper about the Relacy'08 algorithm? I only found your relacy github repo

Feb 11 2022, 1:54 AM · Restricted Project
dvyukov added a comment to D119417: [TSan][NFC] fixup for comment of Shadow.

BTW, AFAIK tsan v2 uses pure happen-befores similar to FastTrack(PLDI'09), Is there any change in v3, are we still use this algorithm ?

Feb 11 2022, 1:05 AM · Restricted Project
dvyukov added a comment to D119417: [TSan][NFC] fixup for comment of Shadow.

but rtl-old should be deleted now.

Hi @dvyukov, Is there any plan when rtl-old will be deleted, right now ? If so, I won't commit this patch.

Feb 11 2022, 1:03 AM · Restricted Project
dvyukov updated subscribers of D119417: [TSan][NFC] fixup for comment of Shadow.
Feb 11 2022, 1:02 AM · Restricted Project

Feb 10 2022

dvyukov accepted D119417: [TSan][NFC] fixup for comment of Shadow.

I don't mind this change, but rtl-old should be deleted now.

Feb 10 2022, 1:38 AM · Restricted Project

Feb 7 2022

dvyukov accepted D119034: [TSan] Handle FreeBSD specific indirection of libpthread functions.
Feb 7 2022, 12:38 AM · Restricted Project

Feb 4 2022

dvyukov added inline comments to D119034: [TSan] Handle FreeBSD specific indirection of libpthread functions.
Feb 4 2022, 11:27 PM · Restricted Project
dvyukov accepted D118970: [msan] Guard FP_XSTATE_MAGIC1 usage with SANITIZER_GLIBC.
Feb 4 2022, 1:14 AM · Restricted Project

Feb 3 2022

dvyukov committed rG4f3f4d672254: sanitizer_common: fix __sanitizer_get_module_and_offset_for_pc signature… (authored by dvyukov).
sanitizer_common: fix __sanitizer_get_module_and_offset_for_pc signature…
Feb 3 2022, 10:41 AM
dvyukov closed D118910: sanitizer_common: fix __sanitizer_get_module_and_offset_for_pc signature mismatch.
Feb 3 2022, 10:41 AM · Restricted Project
dvyukov requested review of D118910: sanitizer_common: fix __sanitizer_get_module_and_offset_for_pc signature mismatch.
Feb 3 2022, 7:44 AM · Restricted Project

Jan 29 2022

dvyukov accepted D118024: [sanitizer_common] Use atomic builtin in sanitizer_atomic_clang.h.
Jan 29 2022, 6:10 AM · Restricted Project

Jan 27 2022

dvyukov added inline comments to D118024: [sanitizer_common] Use atomic builtin in sanitizer_atomic_clang.h.
Jan 27 2022, 11:04 PM · Restricted Project

Jan 7 2022

dvyukov committed rGd7986bf0111e: scudo: fix thread-safety macro name (authored by dvyukov).
scudo: fix thread-safety macro name
Jan 7 2022, 9:28 AM
dvyukov closed D116818: scudo: fix thread-safety macro name.
Jan 7 2022, 9:28 AM · Restricted Project
dvyukov added a comment to D116652: sanitizer_common: prefix thread-safety macros with SANITIZER_.

Landed D116818 to fix this. Thanks for the report.

Jan 7 2022, 9:28 AM · Restricted Project
dvyukov requested review of D116818: scudo: fix thread-safety macro name.
Jan 7 2022, 9:27 AM · Restricted Project
dvyukov committed rG765921de5b8c: sanitizer_common: prefix thread-safety macros with SANITIZER_ (authored by dvyukov).
sanitizer_common: prefix thread-safety macros with SANITIZER_
Jan 7 2022, 6:11 AM
dvyukov closed D116652: sanitizer_common: prefix thread-safety macros with SANITIZER_.
Jan 7 2022, 6:11 AM · Restricted Project
dvyukov added inline comments to D116652: sanitizer_common: prefix thread-safety macros with SANITIZER_.
Jan 7 2022, 5:59 AM · Restricted Project
dvyukov updated the diff for D116652: sanitizer_common: prefix thread-safety macros with SANITIZER_.

fixed lint warnings

Jan 7 2022, 5:59 AM · Restricted Project
dvyukov added a comment to D116208: msan: account for AVX state when unpoison ucontext_t.

Hi Paul,

Jan 7 2022, 5:55 AM · Restricted Project
dvyukov abandoned D113996: sanitizer_common: add HashMap class.
Jan 7 2022, 5:42 AM · Restricted Project

Jan 5 2022

dvyukov committed rG38f69eb77edb: msan: mark test as x86-specific (authored by dvyukov).
msan: mark test as x86-specific
Jan 5 2022, 4:41 AM
dvyukov closed D116653: msan: mark test as x86-specific.
Jan 5 2022, 4:41 AM · Restricted Project
dvyukov requested review of D116653: msan: mark test as x86-specific.
Jan 5 2022, 4:40 AM · Restricted Project
dvyukov added inline comments to D116208: msan: account for AVX state when unpoison ucontext_t.
Jan 5 2022, 4:37 AM · Restricted Project
dvyukov requested review of D116652: sanitizer_common: prefix thread-safety macros with SANITIZER_.
Jan 5 2022, 4:36 AM · Restricted Project
dvyukov committed rG395f737c338c: msan: check that ucontext_t is initialized on signal return (authored by dvyukov).
msan: check that ucontext_t is initialized on signal return
Jan 5 2022, 4:21 AM
dvyukov added inline comments to D116208: msan: account for AVX state when unpoison ucontext_t.
Jan 5 2022, 4:21 AM · Restricted Project
dvyukov committed rG1298273e8206: msan: account for AVX state when unpoison ucontext_t (authored by dvyukov).
msan: account for AVX state when unpoison ucontext_t
Jan 5 2022, 4:21 AM
dvyukov closed D116209: msan: check that ucontext_t is initialized on signal return.
Jan 5 2022, 4:20 AM · Restricted Project
dvyukov closed D116208: msan: account for AVX state when unpoison ucontext_t.
Jan 5 2022, 4:20 AM · Restricted Project

Dec 31 2021

dvyukov updated the diff for D116209: msan: check that ucontext_t is initialized on signal return.

rebased

Dec 31 2021, 1:01 AM · Restricted Project
dvyukov added inline comments to D116209: msan: check that ucontext_t is initialized on signal return.
Dec 31 2021, 1:01 AM · Restricted Project
dvyukov added a comment to D116208: msan: account for AVX state when unpoison ucontext_t.

PTAL

Dec 31 2021, 12:54 AM · Restricted Project
dvyukov updated the diff for D116208: msan: account for AVX state when unpoison ucontext_t.

fixed issues pointed by comments and rebased

Dec 31 2021, 12:53 AM · Restricted Project