Page MenuHomePhabricator

cryptoad (Kostya Kortchinsky)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2016, 2:57 PM (245 w, 4 d)

Recent Activity

Fri, Jan 15

cryptoad added a comment to D94830: [GWP-ASan] Add 'user requested' size and fix Scudo..

Is there some test that can be added that would find a regression?

Fri, Jan 15, 2:54 PM · Restricted Project

Mon, Jan 11

cryptoad added inline comments to D94362: [scudo][standalone] Enable death tests on Fuchsia.
Mon, Jan 11, 11:31 AM · Restricted Project

Sat, Jan 9

cryptoad requested review of D94362: [scudo][standalone] Enable death tests on Fuchsia.
Sat, Jan 9, 8:40 AM · Restricted Project

Fri, Jan 8

cryptoad accepted D93731: scudo: Support memory tagging in the secondary allocator..

It all seems to be working.
I'll have to work on the EXPECT_DEATH aspect as a follow up.

Fri, Jan 8, 1:08 PM · Restricted Project
cryptoad accepted D94117: [GWP-ASan] Minor refactor of optional components..

Compiles and tests pass on Fuchsia.
The changes themselves look good to me.

Fri, Jan 8, 12:05 PM · Restricted Project
cryptoad added inline comments to D94117: [GWP-ASan] Minor refactor of optional components..
Fri, Jan 8, 11:01 AM · Restricted Project
cryptoad added inline comments to D93731: scudo: Support memory tagging in the secondary allocator..
Fri, Jan 8, 7:59 AM · Restricted Project

Thu, Jan 7

cryptoad added inline comments to D93731: scudo: Support memory tagging in the secondary allocator..
Thu, Jan 7, 8:54 AM · Restricted Project
cryptoad added a comment to D93731: scudo: Support memory tagging in the secondary allocator..

There seems to be something wrong on Fuchsia with it, regular processes are crashing. Looking into this.

Thu, Jan 7, 8:34 AM · Restricted Project

Wed, Jan 6

cryptoad added a comment to D93731: scudo: Support memory tagging in the secondary allocator..
In D93731#2482877, @pcc wrote:

It's ready to go in if you don't mind me breaking Fuchsia. Otherwise I can wait for a Fuchsia implementation of setMemoryPermission() from you.

Wed, Jan 6, 4:35 PM · Restricted Project
cryptoad added a comment to D93731: scudo: Support memory tagging in the secondary allocator..
In D93731#2482877, @pcc wrote:

It's ready to go in if you don't mind me breaking Fuchsia. Otherwise I can wait for a Fuchsia implementation of setMemoryPermission() from you.

Wed, Jan 6, 1:12 PM · Restricted Project
cryptoad added a comment to D93731: scudo: Support memory tagging in the secondary allocator..

Is this still WIP like the title says?

Wed, Jan 6, 1:00 PM · Restricted Project
cryptoad abandoned D94104: [scudo][standalone] Fix build for Fuchsia.

Roland committed his change for the issue, this is no longer needed.

Wed, Jan 6, 8:25 AM · Restricted Project

Tue, Jan 5

cryptoad accepted D94108: scudo: Fix compilation for non-Linux aarch64.

Let's go with yours, better comments/whitespaces.

Tue, Jan 5, 12:31 PM · Restricted Project
cryptoad accepted D94105: [scudo] [android] Use ELF TLS on Android API >= 30..

Thanks Mitch! Looks reasonable to me.

Tue, Jan 5, 11:37 AM · Restricted Project
cryptoad requested review of D94104: [scudo][standalone] Fix build for Fuchsia.
Tue, Jan 5, 11:17 AM · Restricted Project

Dec 18 2020

cryptoad accepted D93513: scudo: Remove ANDROID_EXPERIMENTAL_MTE macro..
Dec 18 2020, 9:59 AM · Restricted Project

Dec 17 2020

cryptoad accepted D93437: scudo: Adjust test to use correct check for primary allocations..
Dec 17 2020, 10:08 AM · Restricted Project
cryptoad committed rG1dbf2c96bce9: [scudo][standalone] Allow the release of smaller sizes (authored by cryptoad).
[scudo][standalone] Allow the release of smaller sizes
Dec 17 2020, 10:02 AM
cryptoad closed D93141: [scudo][standalone] Allow the release of smaller sizes.
Dec 17 2020, 10:02 AM · Restricted Project

Dec 14 2020

cryptoad updated the diff for D93141: [scudo][standalone] Allow the release of smaller sizes.

... and remove the unused field in the 32-bit primary. Sorry.

Dec 14 2020, 10:25 AM · Restricted Project
cryptoad updated the diff for D93141: [scudo][standalone] Allow the release of smaller sizes.

Correct copy/paste error in the 32-bit primary (!= => ==)

Dec 14 2020, 9:46 AM · Restricted Project

Dec 11 2020

cryptoad requested review of D93141: [scudo][standalone] Allow the release of smaller sizes.
Dec 11 2020, 2:05 PM · Restricted Project

Dec 10 2020

cryptoad accepted D93056: [scudo] [standalone] [NFC] clang-format code..
Dec 10 2020, 11:43 AM · Restricted Project
cryptoad committed rG3f70987b352c: [scudo][standalone] Small changes to the fastpath (authored by cryptoad).
[scudo][standalone] Small changes to the fastpath
Dec 10 2020, 10:26 AM
cryptoad closed D92689: [scudo][standalone] Small changes to the fastpath.
Dec 10 2020, 10:26 AM · Restricted Project

Dec 9 2020

cryptoad added a comment to D92689: [scudo][standalone] Small changes to the fastpath.

Anything I can help address to move forward?

Dec 9 2020, 1:48 PM · Restricted Project

Dec 4 2020

cryptoad updated the summary of D92689: [scudo][standalone] Small changes to the fastpath.
Dec 4 2020, 2:48 PM · Restricted Project
cryptoad updated the diff for D92689: [scudo][standalone] Small changes to the fastpath.

Correct > to >=.

Dec 4 2020, 2:46 PM · Restricted Project
cryptoad added inline comments to D92689: [scudo][standalone] Small changes to the fastpath.
Dec 4 2020, 2:45 PM · Restricted Project
cryptoad requested review of D92689: [scudo][standalone] Small changes to the fastpath.
Dec 4 2020, 2:08 PM · Restricted Project

Dec 3 2020

cryptoad added a comment to D91824: [scudo] Avoid polluting the TLS slot used by libc-scudo.
In D91824#2426891, @pcc wrote:

I think @cferris was asking whether old scudo was still being used by asan/hwasan. To which the answer is "no" I believe, the sanitizers have their own independent copy of the allocator.

Just to wrap up the threads here, the consensus is that all the non-standalone stuff under compiler-rt/scudo/* should simply be deleted? (along with their tests?)

Dec 3 2020, 2:41 PM · Restricted Project

Dec 2 2020

cryptoad committed rG0a09c1cc9dcb: [scudo][standalone] Add missing va_end() in ScopedString::append (authored by cryptoad).
[scudo][standalone] Add missing va_end() in ScopedString::append
Dec 2 2020, 4:11 PM
cryptoad closed D92383: [scudo][standalone] Add missing va_end() in ScopedString::append.
Dec 2 2020, 4:11 PM · Restricted Project
cryptoad added a comment to D92383: [scudo][standalone] Add missing va_end() in ScopedString::append.

Do you need me to commit this?

Dec 2 2020, 11:09 AM · Restricted Project
cryptoad committed rGc904c32b9c92: [GWP-ASan] Fix flaky test on Fuchsia (authored by cryptoad).
[GWP-ASan] Fix flaky test on Fuchsia
Dec 2 2020, 9:01 AM
cryptoad closed D92415: [GWP-ASan] Fix flaky test on Fuchsia.
Dec 2 2020, 9:01 AM · Restricted Project

Dec 1 2020

cryptoad updated the diff for D92415: [GWP-ASan] Fix flaky test on Fuchsia.

Updating the CL with another proposed fix: reseting the TLS data in
the uninit function called by the tests.

Dec 1 2020, 2:39 PM · Restricted Project
cryptoad requested review of D92415: [GWP-ASan] Fix flaky test on Fuchsia.
Dec 1 2020, 11:46 AM · Restricted Project
cryptoad abandoned D92413: Argument dependent lookup with class argument is recursing into base classes that haven't been instantiated. This is generating an assertion in DeclTemplate.h. Fix for Bug25668..

This is an arc fail on my side

Dec 1 2020, 11:26 AM · Restricted Project
cryptoad requested review of D92413: Argument dependent lookup with class argument is recursing into base classes that haven't been instantiated. This is generating an assertion in DeclTemplate.h. Fix for Bug25668..
Dec 1 2020, 11:19 AM · Restricted Project
cryptoad accepted D92383: [scudo][standalone] Add missing va_end() in ScopedString::append.

Thank you, good catch!!

Dec 1 2020, 7:58 AM · Restricted Project

Nov 23 2020

cryptoad updated subscribers of D91824: [scudo] Avoid polluting the TLS slot used by libc-scudo.
In D91824#2409331, @pcc wrote:

Can we not just drop support for Android in non-standalone Scudo? As far as I know it is only being used (if at all) on a limited set of platforms which does not include Android.

Nov 23 2020, 8:28 AM · Restricted Project

Nov 18 2020

cryptoad committed rG5556616b5b52: [GWP-ASan] Port tests to Fuchsia (authored by cryptoad).
[GWP-ASan] Port tests to Fuchsia
Nov 18 2020, 1:36 PM
cryptoad closed D91575: [GWP-ASan] Port tests to Fuchsia.
Nov 18 2020, 1:36 PM · Restricted Project

Nov 16 2020

cryptoad requested review of D91575: [GWP-ASan] Port tests to Fuchsia.
Nov 16 2020, 3:34 PM · Restricted Project
cryptoad committed rGf0703cb1b24b: [scudo][standalone] Correct min/max region indices (authored by cryptoad).
[scudo][standalone] Correct min/max region indices
Nov 16 2020, 12:43 PM
cryptoad closed D91106: [scudo][standalone] Correct min/max region indices.
Nov 16 2020, 12:43 PM · Restricted Project

Nov 14 2020

cryptoad updated the diff for D91106: [scudo][standalone] Correct min/max region indices.

Addressing review comments.

Nov 14 2020, 10:45 AM · Restricted Project

Nov 12 2020

cryptoad added a comment to D91106: [scudo][standalone] Correct min/max region indices.

Ping please!

Nov 12 2020, 7:55 AM · Restricted Project

Nov 10 2020

cryptoad updated the diff for D91106: [scudo][standalone] Correct min/max region indices.

Further simplify the release function.

Nov 10 2020, 8:56 AM · Restricted Project

Nov 9 2020

cryptoad requested review of D91106: [scudo][standalone] Correct min/max region indices.
Nov 9 2020, 3:15 PM · Restricted Project

Nov 6 2020

cryptoad committed rGc95598904633: [scudo][standalone] Simplify populateFreelist (authored by cryptoad).
[scudo][standalone] Simplify populateFreelist
Nov 6 2020, 9:45 AM
cryptoad closed D90700: [scudo][standalone] Simplify populateFreelist.
Nov 6 2020, 9:44 AM · Restricted Project

Nov 5 2020

cryptoad accepted D90814: scudo: Don't memset previously released cached pages in the secondary allocator..
Nov 5 2020, 7:35 AM · Restricted Project

Nov 4 2020

cryptoad updated the diff for D90700: [scudo][standalone] Simplify populateFreelist.

And another, sorry for the back & forth, getting numbers as they come.

Nov 4 2020, 1:40 PM · Restricted Project
cryptoad updated the diff for D90700: [scudo][standalone] Simplify populateFreelist.

Restoring a couple of UNLIKELY in the loops.

Nov 4 2020, 1:20 PM · Restricted Project

Nov 3 2020

cryptoad updated the diff for D90700: [scudo][standalone] Simplify populateFreelist.

Changing some lines around.

Nov 3 2020, 6:30 PM · Restricted Project
cryptoad updated the diff for D90700: [scudo][standalone] Simplify populateFreelist.

Re-add a comment that got removed.

Nov 3 2020, 11:51 AM · Restricted Project
cryptoad requested review of D90700: [scudo][standalone] Simplify populateFreelist.
Nov 3 2020, 11:22 AM · Restricted Project

Nov 2 2020

cryptoad committed rGb3420adf5a84: [scudo][standalone] Code tidying (NFC) (authored by cryptoad).
[scudo][standalone] Code tidying (NFC)
Nov 2 2020, 4:01 PM
cryptoad closed D90649: [scudo][standalone] Code tidying (NFC).
Nov 2 2020, 4:01 PM · Restricted Project
cryptoad requested review of D90649: [scudo][standalone] Code tidying (NFC).
Nov 2 2020, 2:27 PM · Restricted Project
cryptoad committed rG98fe39df939e: [GWP-ASan] Stub out backtrace/signal functions on Fuchsia (authored by cryptoad).
[GWP-ASan] Stub out backtrace/signal functions on Fuchsia
Nov 2 2020, 1:50 PM
cryptoad closed D90537: [GWP-ASan] Stub out backtrace/signal functions on Fuchsia.
Nov 2 2020, 1:50 PM · Restricted Project
cryptoad updated the diff for D90537: [GWP-ASan] Stub out backtrace/signal functions on Fuchsia.

Addressing Mitch's request.

Nov 2 2020, 12:46 PM · Restricted Project

Oct 31 2020

cryptoad requested review of D90537: [GWP-ASan] Stub out backtrace/signal functions on Fuchsia.
Oct 31 2020, 11:09 AM · Restricted Project
cryptoad committed rG63ad0876567d: [GWP-ASan] Fuchsia specific mapping & utilities functions (authored by cryptoad).
[GWP-ASan] Fuchsia specific mapping & utilities functions
Oct 31 2020, 10:23 AM
cryptoad closed D90483: [GWP-ASan] Fuchsia specific mapping & utilities functions.
Oct 31 2020, 10:23 AM · Restricted Project

Oct 30 2020

cryptoad added inline comments to D90483: [GWP-ASan] Fuchsia specific mapping & utilities functions.
Oct 30 2020, 9:25 PM · Restricted Project
cryptoad updated the diff for D90483: [GWP-ASan] Fuchsia specific mapping & utilities functions.

Addressing Roland's comments.

Oct 30 2020, 9:21 PM · Restricted Project
cryptoad updated the diff for D90483: [GWP-ASan] Fuchsia specific mapping & utilities functions.

Couple of small fixes.

Oct 30 2020, 10:51 AM · Restricted Project
cryptoad requested review of D90483: [GWP-ASan] Fuchsia specific mapping & utilities functions.
Oct 30 2020, 10:44 AM · Restricted Project

Oct 29 2020

cryptoad committed rG3591721ada99: [GWP-ASan] Add mutexes for Fuchsia (authored by cryptoad).
[GWP-ASan] Add mutexes for Fuchsia
Oct 29 2020, 3:51 PM
cryptoad closed D90351: [GWP-ASan] Add mutexes for Fuchsia.
Oct 29 2020, 3:51 PM · Restricted Project
cryptoad updated the diff for D90351: [GWP-ASan] Add mutexes for Fuchsia.

Addressing review comments.

Oct 29 2020, 2:45 PM · Restricted Project

Oct 28 2020

cryptoad added a comment to D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is).

Thank you for all your work!
IIRC everything was working except as you point out some of the very Unixy tests.
Is your build creating a clang_rt.scudo_cxx library that also needs to be link as well? The C++ specific interceptors usually end up in a separate library that is not linked into the straight C programs, which is the most likely culprit for not having new/delete be intercepted.

Oct 28 2020, 4:21 PM · Restricted Project, Restricted Project, Restricted Project
cryptoad requested review of D90351: [GWP-ASan] Add mutexes for Fuchsia.
Oct 28 2020, 4:04 PM · Restricted Project
cryptoad committed rG90678f65ae47: [GWP-ASan] Abstract the thread local variables access (authored by cryptoad).
[GWP-ASan] Abstract the thread local variables access
Oct 28 2020, 3:07 PM
cryptoad closed D90195: [GWP-ASan] Abstract the thread local variables access.
Oct 28 2020, 3:06 PM · Restricted Project
cryptoad updated the diff for D90195: [GWP-ASan] Abstract the thread local variables access.

Adding stdint.h to try and quell some clang-tidy warnings.

Oct 28 2020, 10:54 AM · Restricted Project
cryptoad added inline comments to D90195: [GWP-ASan] Abstract the thread local variables access.
Oct 28 2020, 10:51 AM · Restricted Project
cryptoad updated the diff for D90195: [GWP-ASan] Abstract the thread local variables access.

Address review comments.

Oct 28 2020, 8:31 AM · Restricted Project

Oct 26 2020

cryptoad requested review of D90195: [GWP-ASan] Abstract the thread local variables access.
Oct 26 2020, 2:54 PM · Restricted Project
cryptoad committed rG612e02ee8c3e: [GWP-ASan] Refactor memory mapping functions (authored by cryptoad).
[GWP-ASan] Refactor memory mapping functions
Oct 26 2020, 1:32 PM
cryptoad closed D89993: [GWP-ASan] Refactor memory mapping functions.
Oct 26 2020, 1:32 PM · Restricted Project
cryptoad updated the diff for D89993: [GWP-ASan] Refactor memory mapping functions.

clang-format a file that was missed.

Oct 26 2020, 9:35 AM · Restricted Project
cryptoad updated the diff for D89993: [GWP-ASan] Refactor memory mapping functions.

Addressing review comments:

  • tried to strike a middle ground between name suggestions, settled on: `void *reserveGuardedPool(size_t Size);

void allocateInGuardedPool(void *Ptr, size_t Size) const;
void deallocateInGuardedPool(void *Ptr, size_t Size) const;
void unreserveGuardedPool();`

  • added comments and clarifications about API contracts
  • used anonymous namespace instead of static
Oct 26 2020, 8:11 AM · Restricted Project

Oct 22 2020

cryptoad updated the diff for D89993: [GWP-ASan] Refactor memory mapping functions.

Correcting a potential conversion warning.

Oct 22 2020, 4:11 PM · Restricted Project
cryptoad requested review of D89993: [GWP-ASan] Refactor memory mapping functions.
Oct 22 2020, 3:54 PM · Restricted Project
cryptoad committed rG3580a45014e9: [GWP-ASan] Move random-related code in the allocator (redo) (authored by cryptoad).
[GWP-ASan] Move random-related code in the allocator (redo)
Oct 22 2020, 1:57 PM
cryptoad closed D89984: [GWP-ASan] Move random-related code in the allocator (redo).
Oct 22 2020, 1:56 PM · Restricted Project
cryptoad added a comment to D89984: [GWP-ASan] Move random-related code in the allocator (redo).

I can confirm that this builds fine for me.

Oct 22 2020, 1:50 PM · Restricted Project
cryptoad requested review of D89984: [GWP-ASan] Move random-related code in the allocator (redo).
Oct 22 2020, 1:40 PM · Restricted Project
cryptoad added a comment to D89908: [GWP-ASan] Move random-related code in the allocator.

I've reverted this in https://github.com/llvm/llvm-project/commit/04e42f62548d4c0367664188a938b609435718e2 due to a build failure with GCC. The code seems a bit sensitive, so I didn't want to introduce random casts.

Oct 22 2020, 1:07 PM · Restricted Project
cryptoad committed rG9903b0586cfb: [GWP-ASan] Move random-related code in the allocator (authored by cryptoad).
[GWP-ASan] Move random-related code in the allocator
Oct 22 2020, 11:52 AM
cryptoad closed D89908: [GWP-ASan] Move random-related code in the allocator.
Oct 22 2020, 11:52 AM · Restricted Project
cryptoad updated the diff for D89908: [GWP-ASan] Move random-related code in the allocator.

Addressing review comments.

Oct 22 2020, 10:01 AM · Restricted Project

Oct 21 2020

cryptoad updated the diff for D89908: [GWP-ASan] Move random-related code in the allocator.
  • Restoring the old constants because some test failed with mine.
Oct 21 2020, 3:27 PM · Restricted Project
cryptoad added reviewers for D89908: [GWP-ASan] Move random-related code in the allocator: hctim, eugenis, mcgrathr.
Oct 21 2020, 2:32 PM · Restricted Project