Page MenuHomePhabricator

cryptoad (Kostya Kortchinsky)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2016, 2:57 PM (176 w, 3 d)

Recent Activity

Wed, Sep 11

cryptoad committed rG161cca266a9d: [scudo][standalone] Android related improvements (authored by cryptoad).
[scudo][standalone] Android related improvements
Wed, Sep 11, 7:48 AM
cryptoad committed rL371628: [scudo][standalone] Android related improvements.
[scudo][standalone] Android related improvements
Wed, Sep 11, 7:48 AM
cryptoad closed D67293: [scudo][standalone] Android related improvements.
Wed, Sep 11, 7:48 AM · Restricted Project, Restricted Project

Fri, Sep 6

cryptoad updated the diff for D67293: [scudo][standalone] Android related improvements.

SCM update.

Fri, Sep 6, 3:09 PM · Restricted Project, Restricted Project
cryptoad updated the summary of D67293: [scudo][standalone] Android related improvements.
Fri, Sep 6, 1:04 PM · Restricted Project, Restricted Project
cryptoad updated the summary of D67293: [scudo][standalone] Android related improvements.
Fri, Sep 6, 1:03 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D67293: [scudo][standalone] Android related improvements.

Add a LIKELY to be compliant with our stance that Primary based
allocations are likelier.

Fri, Sep 6, 11:00 AM · Restricted Project, Restricted Project
cryptoad created D67293: [scudo][standalone] Android related improvements.
Fri, Sep 6, 10:57 AM · Restricted Project, Restricted Project

Aug 20 2019

cryptoad committed rG3e5360f19465: [scudo][standalone] Fix malloc_iterate (authored by cryptoad).
[scudo][standalone] Fix malloc_iterate
Aug 20 2019, 9:25 AM
cryptoad committed rL369400: [scudo][standalone] Fix malloc_iterate.
[scudo][standalone] Fix malloc_iterate
Aug 20 2019, 9:16 AM
cryptoad closed D66231: [scudo][standalone] Fix malloc_iterate.
Aug 20 2019, 9:16 AM · Restricted Project, Restricted Project

Aug 19 2019

cryptoad updated the diff for D66231: [scudo][standalone] Fix malloc_iterate.

Following Mitch's suggestion, modify the test to use a
PageSize - BlockDelta sized chunk, that in all likelihood will be
backed by a page-aligned block (dependent on the SizeClassMap but
works with our default).

Aug 19 2019, 2:58 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D66231: [scudo][standalone] Fix malloc_iterate.
Aug 19 2019, 2:36 PM · Restricted Project, Restricted Project
cryptoad added a comment to D66231: [scudo][standalone] Fix malloc_iterate.

Is this good from the reviewers perspective?

Aug 19 2019, 11:28 AM · Restricted Project, Restricted Project

Aug 14 2019

cryptoad updated the diff for D66231: [scudo][standalone] Fix malloc_iterate.
  • Additional comments to the test function
  • Moving the initialization of the static variables within the test function
Aug 14 2019, 12:16 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D66231: [scudo][standalone] Fix malloc_iterate.
Aug 14 2019, 11:28 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D66231: [scudo][standalone] Fix malloc_iterate.

Update the test.

Aug 14 2019, 10:29 AM · Restricted Project, Restricted Project
cryptoad created D66231: [scudo][standalone] Fix malloc_iterate.
Aug 14 2019, 10:21 AM · Restricted Project, Restricted Project
cryptoad committed rG2be59170d433: [scudo][standalone] Add more stats to mallinfo (authored by cryptoad).
[scudo][standalone] Add more stats to mallinfo
Aug 14 2019, 9:07 AM
cryptoad committed rL368866: [scudo][standalone] Add more stats to mallinfo.
[scudo][standalone] Add more stats to mallinfo
Aug 14 2019, 9:03 AM
cryptoad closed D66112: [scudo][standalone] Add more stats to mallinfo.
Aug 14 2019, 9:03 AM · Restricted Project, Restricted Project

Aug 12 2019

cryptoad added a comment to D66123: [scudo][standalone] Clean-up of Android specific compilation..

We might have to discuss this.
I either compile Android binaries by compiling it with the Scudo sources, or I compile the platform with Scudo replacing jemalloc in Android.
Both work with -D_BIONIC=1 for the Bionic version, which can probably be replaced by BIONIC.
So I am not sure why compiling it on Android but not part of Bionic didn't work for you, I can give you the compilation command lines I used tomorrow.

Aug 12 2019, 9:24 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D66112: [scudo][standalone] Add more stats to mallinfo.

Adding usmblks as well.
Android uses it for getNativeHeapSize, so StatMapped will do.

Aug 12 2019, 3:37 PM · Restricted Project, Restricted Project
cryptoad created D66112: [scudo][standalone] Add more stats to mallinfo.
Aug 12 2019, 3:08 PM · Restricted Project, Restricted Project
cryptoad committed rG8095449e6832: [scudo][standalone] Minor corrections (authored by cryptoad).
[scudo][standalone] Minor corrections
Aug 12 2019, 8:37 AM
cryptoad committed rL368585: [scudo][standalone] Minor corrections.
[scudo][standalone] Minor corrections
Aug 12 2019, 8:37 AM
cryptoad closed D65660: [scudo][standalone] Minor corrections.
Aug 12 2019, 8:36 AM · Restricted Project, Restricted Project

Aug 2 2019

cryptoad created D65660: [scudo][standalone] Minor corrections.
Aug 2 2019, 8:04 AM · Restricted Project, Restricted Project

Jul 24 2019

cryptoad committed rG419f1a4185d5: [scudo][standalone] Optimization pass (authored by cryptoad).
[scudo][standalone] Optimization pass
Jul 24 2019, 9:37 AM
cryptoad committed rL366918: [scudo][standalone] Optimization pass.
[scudo][standalone] Optimization pass
Jul 24 2019, 9:36 AM
cryptoad closed D64664: [scudo][standalone] Optimization pass.
Jul 24 2019, 9:35 AM · Restricted Project, Restricted Project

Jul 15 2019

cryptoad updated the diff for D64664: [scudo][standalone] Optimization pass.

More optimizations:

BM_youtube/min_time:15.000/repeats:4/manual_time_mean       410274 us       615999 us            4
BM_youtube/min_time:15.000/repeats:4/manual_time_median     410246 us       616125 us            4
BM_youtube/min_time:15.000/repeats:4/manual_time_stddev        302 us          587 us            4
Jul 15 2019, 10:34 AM · Restricted Project, Restricted Project

Jul 12 2019

cryptoad updated the summary of D64664: [scudo][standalone] Optimization pass.
Jul 12 2019, 1:49 PM · Restricted Project, Restricted Project
cryptoad created D64664: [scudo][standalone] Optimization pass.
Jul 12 2019, 1:49 PM · Restricted Project, Restricted Project

Jul 11 2019

cryptoad committed rG8f18a4c980be: [scudo][standalone] NFC corrections (authored by cryptoad).
[scudo][standalone] NFC corrections
Jul 11 2019, 12:56 PM
cryptoad committed rL365816: [scudo][standalone] NFC corrections.
[scudo][standalone] NFC corrections
Jul 11 2019, 12:56 PM
cryptoad closed D64570: [scudo][standalone] NFC corrections.
Jul 11 2019, 12:56 PM · Restricted Project, Restricted Project
cryptoad created D64570: [scudo][standalone] NFC corrections.
Jul 11 2019, 9:16 AM · Restricted Project, Restricted Project
cryptoad committed rGaeb3826228a7: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one (authored by cryptoad).
[scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one
Jul 11 2019, 8:33 AM
cryptoad committed rL365790: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
[scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one
Jul 11 2019, 8:33 AM
cryptoad closed D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
Jul 11 2019, 8:33 AM · Restricted Project, Restricted Project

Jul 10 2019

cryptoad added inline comments to D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
Jul 10 2019, 9:18 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
Jul 10 2019, 9:10 AM · Restricted Project, Restricted Project
cryptoad added a comment to D64457: [GWP-ASan] Attempt to fix Android/ARM platforms..

It's OK with me. Part of the reason for splitting out the symbolizer was some memory overhead as well, which we probably want to look into.
Is COMPILER_RT_HAS_GWP_ASAN going to be true by default for Android? If so we probably should loop in the toolchain team so that there is no surprise on their next toolchain update.

Jul 10 2019, 8:12 AM · Restricted Project, Restricted Project

Jul 9 2019

cryptoad updated the diff for D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.

Addressing review comments:

  • commenting the use of the #pragma nounroll
  • using the platform specific types in mutex.h
Jul 9 2019, 12:18 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.

Move the mutex state enum into linux.cc since it's only used there.

Jul 9 2019, 9:12 AM · Restricted Project, Restricted Project

Jul 8 2019

cryptoad updated the diff for D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
  • Adding constexpr for the number of yields & trys in the mutex class;
  • Adding a test to ensure that scudo::getPageSizeCached is consitent with getpagesize;
Jul 8 2019, 1:47 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
Jul 8 2019, 1:33 PM · Restricted Project, Restricted Project
cryptoad created D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
Jul 8 2019, 11:52 AM · Restricted Project, Restricted Project

Jul 3 2019

cryptoad committed rGf50a953ea776: [scudo][standalone] Link tests against libatomic (authored by cryptoad).
[scudo][standalone] Link tests against libatomic
Jul 3 2019, 9:34 AM
cryptoad committed rL365052: [scudo][standalone] Link tests against libatomic.
[scudo][standalone] Link tests against libatomic
Jul 3 2019, 9:34 AM
cryptoad closed D64134: [scudo][standalone] Link tests against libatomic.
Jul 3 2019, 9:34 AM · Restricted Project, Restricted Project
cryptoad created D64134: [scudo][standalone] Link tests against libatomic.
Jul 3 2019, 7:51 AM · Restricted Project, Restricted Project
cryptoad committed rGd63d14f76b9a: [scudo][standalone] Potential fix for missing sized delete (authored by cryptoad).
[scudo][standalone] Potential fix for missing sized delete
Jul 3 2019, 7:40 AM
cryptoad committed rL365045: [scudo][standalone] Potential fix for missing sized delete.
[scudo][standalone] Potential fix for missing sized delete
Jul 3 2019, 7:39 AM
cryptoad closed D64086: [scudo][standalone] Potential fix for missing sized delete.
Jul 3 2019, 7:39 AM · Restricted Project, Restricted Project

Jul 2 2019

cryptoad added a comment to D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

Regarding Teresa's issue, it seems to boil down to the version of clang, and not inlining the __atomic_load_8 & co.
Looking at godbolt, it doesn't seem to happen until clang 6, while gcc did it since a while.
After attempting to conditionally add -latomic, and failing, I am resorting to adding -latomic unconditionally to the tests link flags, unless someone has a better idea.

Jul 2 2019, 1:49 PM · Restricted Project, Restricted Project
cryptoad added a comment to D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

Tentative fix for this is in https://reviews.llvm.org/D64086, if you could please let me know if that works for you.

Jul 2 2019, 12:44 PM · Restricted Project, Restricted Project
cryptoad accepted D64085: [GWP-ASan] [Scudo] Add GWP-ASan backtrace for alloc/free to Scudo..
Jul 2 2019, 10:24 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D64086: [scudo][standalone] Potential fix for missing sized delete.

s/kostya/kostyak/

Jul 2 2019, 10:11 AM · Restricted Project, Restricted Project
cryptoad created D64086: [scudo][standalone] Potential fix for missing sized delete.
Jul 2 2019, 9:58 AM · Restricted Project, Restricted Project

Jun 27 2019

cryptoad committed rGd44cb7a65673: [scudo][standalone] Introduce the C & C++ wrappers [fixed] (authored by cryptoad).
[scudo][standalone] Introduce the C & C++ wrappers [fixed]
Jun 27 2019, 7:25 AM
cryptoad committed rL364547: [scudo][standalone] Introduce the C & C++ wrappers [fixed].
[scudo][standalone] Introduce the C & C++ wrappers [fixed]
Jun 27 2019, 7:25 AM
cryptoad closed D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].
Jun 27 2019, 7:24 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

clang-format'd.

Jun 27 2019, 7:22 AM · Restricted Project, Restricted Project

Jun 26 2019

cryptoad added a comment to D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

Thank you Douglas!

Jun 26 2019, 3:31 PM · Restricted Project, Restricted Project
cryptoad created D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].
Jun 26 2019, 11:13 AM · Restricted Project, Restricted Project

Jun 25 2019

cryptoad committed rL364345: [scudo] Correct a behavior on the shared TSD registry.
[scudo] Correct a behavior on the shared TSD registry
Jun 25 2019, 1:08 PM
cryptoad committed rG3ad32a037efc: [scudo] Correct a behavior on the shared TSD registry (authored by cryptoad).
[scudo] Correct a behavior on the shared TSD registry
Jun 25 2019, 1:08 PM
cryptoad closed D63783: [scudo] Correct a behavior on the shared TSD registry.
Jun 25 2019, 1:07 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D63783: [scudo] Correct a behavior on the shared TSD registry.

Remove unchanged files from CL.

Jun 25 2019, 12:03 PM · Restricted Project, Restricted Project
cryptoad created D63783: [scudo] Correct a behavior on the shared TSD registry.
Jun 25 2019, 12:03 PM · Restricted Project, Restricted Project
cryptoad committed rL364332: [scudo][standalone] Introduce the C & C++ wrappers.
[scudo][standalone] Introduce the C & C++ wrappers
Jun 25 2019, 10:09 AM
cryptoad committed rG37340e3cd62d: [scudo][standalone] Introduce the C & C++ wrappers (authored by cryptoad).
[scudo][standalone] Introduce the C & C++ wrappers
Jun 25 2019, 10:02 AM
cryptoad closed D63612: [scudo][standalone] Introduce the C & C++ wrappers.
Jun 25 2019, 10:01 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D63612: [scudo][standalone] Introduce the C & C++ wrappers.

Adding a testcase for a Class to the New tests.

Jun 25 2019, 8:13 AM · Restricted Project, Restricted Project

Jun 24 2019

cryptoad updated the diff for D63612: [scudo][standalone] Introduce the C & C++ wrappers.

Changing some errno behaviors to be more consistent.
Renaming wrappers.inc to wrappers_c.inc and updated associated strings.

Jun 24 2019, 1:41 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D63612: [scudo][standalone] Introduce the C & C++ wrappers.
Jun 24 2019, 1:40 PM · Restricted Project, Restricted Project

Jun 21 2019

cryptoad updated the diff for D63612: [scudo][standalone] Introduce the C & C++ wrappers.

Fixing a couple of errors that came up in testing.

Jun 21 2019, 8:09 AM · Restricted Project, Restricted Project

Jun 20 2019

cryptoad created D63612: [scudo][standalone] Introduce the C & C++ wrappers.
Jun 20 2019, 9:54 AM · Restricted Project, Restricted Project

Jun 18 2019

cryptoad committed rG5cf216c9a72a: [scudo][standalone] Fuchsia related changes (authored by cryptoad).
[scudo][standalone] Fuchsia related changes
Jun 18 2019, 10:38 AM
cryptoad committed rL363705: [scudo][standalone] Fuchsia related changes.
[scudo][standalone] Fuchsia related changes
Jun 18 2019, 10:38 AM
cryptoad closed D63435: [scudo][standalone] Fuchsia related changes.
Jun 18 2019, 10:38 AM · Restricted Project, Restricted Project

Jun 17 2019

cryptoad created D63435: [scudo][standalone] Fuchsia related changes.
Jun 17 2019, 8:42 AM · Restricted Project, Restricted Project
cryptoad committed rGe4eadf174cb1: [scudo][standalone] Introduce the combined allocator (authored by cryptoad).
[scudo][standalone] Introduce the combined allocator
Jun 17 2019, 8:21 AM
cryptoad committed rL363569: [scudo][standalone] Introduce the combined allocator.
[scudo][standalone] Introduce the combined allocator
Jun 17 2019, 8:20 AM
cryptoad closed D63231: [scudo][standalone] Introduce the combined allocator.
Jun 17 2019, 8:20 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Removing a reinterpret_cast<void *>.

Jun 17 2019, 8:20 AM · Restricted Project, Restricted Project

Jun 14 2019

cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Addressing review comments:

  • renaming allocator.h to allocator_config.h
  • adding FuchsiaConfig to the battery of tests (64-bit only)
Jun 14 2019, 3:37 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D63231: [scudo][standalone] Introduce the combined allocator.
Jun 14 2019, 3:33 PM · Restricted Project, Restricted Project

Jun 13 2019

cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Tune some tests & Quarantine parameters.

Jun 13 2019, 10:01 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Enabled the Quarantine for some tests, which wasn't used before.

Jun 13 2019, 9:44 AM · Restricted Project, Restricted Project

Jun 12 2019

cryptoad created D63231: [scudo][standalone] Introduce the combined allocator.
Jun 12 2019, 3:30 PM · Restricted Project, Restricted Project

Jun 11 2019

cryptoad committed rG624a24e15633: [scudo][standalone] Unmap memory in tests (authored by cryptoad).
[scudo][standalone] Unmap memory in tests
Jun 11 2019, 12:48 PM
cryptoad committed rL363095: [scudo][standalone] Unmap memory in tests.
[scudo][standalone] Unmap memory in tests
Jun 11 2019, 12:47 PM
cryptoad closed D63146: [scudo][standalone] Unmap memory in tests.
Jun 11 2019, 12:47 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D63146: [scudo][standalone] Unmap memory in tests.

Update the deleters to actually delete the pointer itself as well.

Jun 11 2019, 10:35 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D63146: [scudo][standalone] Unmap memory in tests.
Jun 11 2019, 10:32 AM · Restricted Project, Restricted Project
cryptoad created D63146: [scudo][standalone] Unmap memory in tests.
Jun 11 2019, 9:33 AM · Restricted Project, Restricted Project

Jun 10 2019

cryptoad committed rG52bfd673d155: [scudo][standalone] Introduce the thread specific data structures (authored by cryptoad).
[scudo][standalone] Introduce the thread specific data structures
Jun 10 2019, 9:49 AM