cryptoad (Kostya Kortchinsky)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2016, 2:57 PM (107 w, 2 d)

Recent Activity

Wed, May 23

cryptoad created D47289: [scudo] Improve the scalability of the shared TSD model.
Wed, May 23, 3:05 PM
cryptoad committed rL333109: [sanitizer] Define UINTPTR_MAX.
[sanitizer] Define UINTPTR_MAX
Wed, May 23, 11:17 AM
cryptoad committed rCRT333109: [sanitizer] Define UINTPTR_MAX.
[sanitizer] Define UINTPTR_MAX
Wed, May 23, 11:17 AM
cryptoad closed D47270: [sanitizer] Define UINTPTR_MAX.
Wed, May 23, 11:17 AM
cryptoad created D47270: [sanitizer] Define UINTPTR_MAX.
Wed, May 23, 10:51 AM

Tue, May 22

cryptoad resigned from D47165: sanitizer: Don't intercept ustat for Linux.

Sorry I don't know enough about the ustat usages, resigning as a reviewer.

Tue, May 22, 10:32 AM

Fri, May 18

cryptoad committed rL332736: [docs] Scudo documentation minor update.
[docs] Scudo documentation minor update
Fri, May 18, 10:06 AM
cryptoad closed D47071: [docs] Scudo documentation minor update.
Fri, May 18, 10:06 AM
cryptoad created D47071: [docs] Scudo documentation minor update.
Fri, May 18, 8:20 AM
cryptoad abandoned D43975: [scudo] Update Scudo docs with configuration options..

This will be included in an upcoming documentation change I am making.

Fri, May 18, 8:05 AM
cryptoad commandeered D43975: [scudo] Update Scudo docs with configuration options..
Fri, May 18, 8:04 AM

Wed, May 16

cryptoad committed rL332502: [scudo] Quarantine optimization.
[scudo] Quarantine optimization
Wed, May 16, 11:16 AM
cryptoad committed rCRT332502: [scudo] Quarantine optimization.
[scudo] Quarantine optimization
Wed, May 16, 11:16 AM
cryptoad closed D46961: [scudo] Quarantine optimization.
Wed, May 16, 11:16 AM
cryptoad added a comment to D46961: [scudo] Quarantine optimization.

Making it static const makes the compiler use cxa_guard_acquire & cxa_guard_release which we don't want to be able to stay free of libc++ dependencies.

I meant keeping it as class member (not making it function-local static).

Wed, May 16, 10:50 AM
cryptoad added a comment to D46961: [scudo] Quarantine optimization.
  • const uptr BatchClassId = SizeClassMap::ClassID(sizeof(QuarantineBatch));

    Shouldn't it be constexpr? Or at least static const?
Wed, May 16, 10:31 AM
cryptoad created D46961: [scudo] Quarantine optimization.
Wed, May 16, 10:16 AM
cryptoad committed rCRT332478: [sanitizer] Minor 32-bit primary improvements.
[sanitizer] Minor 32-bit primary improvements
Wed, May 16, 8:17 AM
cryptoad committed rL332478: [sanitizer] Minor 32-bit primary improvements.
[sanitizer] Minor 32-bit primary improvements
Wed, May 16, 8:17 AM
cryptoad closed D46657: [sanitizer] Minor 32-bit primary improvements.
Wed, May 16, 8:17 AM

Tue, May 15

cryptoad updated the diff for D46657: [sanitizer] Minor 32-bit primary improvements.

The changes to the local cache were not worth doing. Reverting those.

Tue, May 15, 3:23 PM
cryptoad added inline comments to D46657: [sanitizer] Minor 32-bit primary improvements.
Tue, May 15, 3:22 PM
cryptoad added inline comments to D46657: [sanitizer] Minor 32-bit primary improvements.
Tue, May 15, 2:38 PM
cryptoad updated the diff for D46657: [sanitizer] Minor 32-bit primary improvements.

Addressing a couple of comments from Aleksey.

Tue, May 15, 2:38 PM

Sun, May 13

cryptoad added a comment to D35696: Fix compiler-rt build with aarch64 using -march=armv8-a.

I fixed at some point COMPILER_RT_HAS_MCRC_FLAG being defined for x86_64, it was due to warnings being disabled, making all the cmake checks pass.
See https://reviews.llvm.org/D46079. It might be what's happening here.

Sun, May 13, 10:40 AM

Wed, May 9

cryptoad added a comment to D46657: [sanitizer] Minor 32-bit primary improvements.

And I forgot:

  • the SizeClassInfo mutex should be a StaticSpinMutex since it's zero initialized and doesn't need to be "constructed";
Wed, May 9, 12:10 PM
cryptoad created D46657: [sanitizer] Minor 32-bit primary improvements.
Wed, May 9, 12:09 PM
cryptoad committed rCRT331890: [sanitizer] Correct 64-bit atomic_store on 32-bit "other" platforms.
[sanitizer] Correct 64-bit atomic_store on 32-bit "other" platforms
Wed, May 9, 9:27 AM
cryptoad committed rL331890: [sanitizer] Correct 64-bit atomic_store on 32-bit "other" platforms.
[sanitizer] Correct 64-bit atomic_store on 32-bit "other" platforms
Wed, May 9, 9:26 AM
cryptoad closed D46597: [sanitizer] Correct 64-bit atomic_store on 32-bit "other" platforms.
Wed, May 9, 9:26 AM
cryptoad updated the diff for D46597: [sanitizer] Correct 64-bit atomic_store on 32-bit "other" platforms.

Changing the break condition to Dmitry's suggestion.

Wed, May 9, 8:20 AM
cryptoad added inline comments to D46597: [sanitizer] Correct 64-bit atomic_store on 32-bit "other" platforms.
Wed, May 9, 7:16 AM

Tue, May 8

cryptoad created D46597: [sanitizer] Correct 64-bit atomic_store on 32-bit "other" platforms.
Tue, May 8, 1:01 PM

Mon, May 7

cryptoad committed rL331662: [sanitizer] s/TestOnlyInit/Init for the allocator ByteMap (NFC).
[sanitizer] s/TestOnlyInit/Init for the allocator ByteMap (NFC)
Mon, May 7, 12:06 PM
cryptoad committed rCRT331662: [sanitizer] s/TestOnlyInit/Init for the allocator ByteMap (NFC).
[sanitizer] s/TestOnlyInit/Init for the allocator ByteMap (NFC)
Mon, May 7, 12:06 PM
cryptoad closed D46408: [sanitizer] s/TestOnlyInit/Init for the allocator ByteMap (NFC).
Mon, May 7, 12:05 PM
cryptoad added inline comments to D46408: [sanitizer] s/TestOnlyInit/Init for the allocator ByteMap (NFC).
Mon, May 7, 11:33 AM

Thu, May 3

cryptoad created D46408: [sanitizer] s/TestOnlyInit/Init for the allocator ByteMap (NFC).
Thu, May 3, 1:47 PM
cryptoad committed rL331477: [sanitizer] Remove unused 32-bit allocator TransferBatch parameter.
[sanitizer] Remove unused 32-bit allocator TransferBatch parameter
Thu, May 3, 12:17 PM
cryptoad committed rCRT331477: [sanitizer] Remove unused 32-bit allocator TransferBatch parameter.
[sanitizer] Remove unused 32-bit allocator TransferBatch parameter
Thu, May 3, 12:17 PM
cryptoad closed D46397: [sanitizer] Remove unused 32-bit allocator TransferBatch parameter.
Thu, May 3, 12:17 PM
cryptoad created D46397: [sanitizer] Remove unused 32-bit allocator TransferBatch parameter.
Thu, May 3, 10:28 AM

Tue, May 1

cryptoad accepted D46344: [sanitizer] Fix Fuchsia ReadBinaryName not to crash when uninitialized.
Tue, May 1, 6:46 PM · Restricted Project

Fri, Apr 27

cryptoad committed rL331042: [CMake] Enable warnings for runtimes.
[CMake] Enable warnings for runtimes
Fri, Apr 27, 8:14 AM
cryptoad closed D46079: [CMake] Enable warnings for runtimes.
Fri, Apr 27, 8:14 AM

Apr 25 2018

cryptoad added inline comments to D45997: [CMake] Pass additional CMake flags in Fuchsia cache files.
Apr 25 2018, 5:26 PM
cryptoad added a comment to D46079: [CMake] Enable warnings for runtimes.

Currently not compatible with D45997's COMPILER_RT_ENABLE_WERROR ON.

Apr 25 2018, 3:33 PM
cryptoad created D46079: [CMake] Enable warnings for runtimes.
Apr 25 2018, 1:53 PM
cryptoad committed rL330857: [scudo] Adding an interface function to print allocator stats.
[scudo] Adding an interface function to print allocator stats
Apr 25 2018, 11:55 AM
cryptoad committed rCRT330857: [scudo] Adding an interface function to print allocator stats.
[scudo] Adding an interface function to print allocator stats
Apr 25 2018, 11:55 AM
cryptoad closed D46016: [scudo] Adding an interface function to print allocator stats.
Apr 25 2018, 11:55 AM
cryptoad updated the diff for D46016: [scudo] Adding an interface function to print allocator stats.

Add description of the function in the interface header.

Apr 25 2018, 8:53 AM

Apr 24 2018

cryptoad added reviewers for D46016: [scudo] Adding an interface function to print allocator stats: alekseyshl, flowerhack.
Apr 24 2018, 9:42 AM
cryptoad updated the diff for D46016: [scudo] Adding an interface function to print allocator stats.

Added a very generic test.

Apr 24 2018, 9:42 AM
cryptoad created D46016: [scudo] Adding an interface function to print allocator stats.
Apr 24 2018, 8:34 AM
cryptoad committed rL330724: [sanitizer] More dead code removal.
[sanitizer] More dead code removal
Apr 24 2018, 8:01 AM
cryptoad committed rCRT330724: [sanitizer] More dead code removal.
[sanitizer] More dead code removal
Apr 24 2018, 8:01 AM
cryptoad closed D45838: [sanitizer] More dead code removal.
Apr 24 2018, 8:01 AM

Apr 23 2018

cryptoad committed rL330598: [scudo] Read ARM feature bits using Fuchsia APIs..
[scudo] Read ARM feature bits using Fuchsia APIs.
Apr 23 2018, 7:56 AM
cryptoad committed rCRT330598: [scudo] Read ARM feature bits using Fuchsia APIs..
[scudo] Read ARM feature bits using Fuchsia APIs.
Apr 23 2018, 7:56 AM
cryptoad closed D45896: [scudo] Read ARM feature bits using Fuchsia APIs..
Apr 23 2018, 7:56 AM

Apr 21 2018

cryptoad accepted D45896: [scudo] Read ARM feature bits using Fuchsia APIs..
Apr 21 2018, 2:31 PM
cryptoad updated the diff for D45896: [scudo] Read ARM feature bits using Fuchsia APIs..

Sorry, you were right! The initial version was less complicated.
I'm updating this to fallback to it, with the style changes included.

Apr 21 2018, 9:46 AM

Apr 20 2018

cryptoad added inline comments to D45896: [scudo] Read ARM feature bits using Fuchsia APIs..
Apr 20 2018, 2:29 PM
cryptoad added inline comments to D45896: [scudo] Read ARM feature bits using Fuchsia APIs..
Apr 20 2018, 1:10 PM
cryptoad added a comment to D45838: [sanitizer] More dead code removal.

asan_test.cc leverages an intercepted prctl with the ThreadedTestFunc test which calls:

Apr 20 2018, 9:34 AM
cryptoad added a comment to D45838: [sanitizer] More dead code removal.

Tests are not linked with interceptors?

Apr 20 2018, 9:24 AM
cryptoad added a comment to D45838: [sanitizer] More dead code removal.

I am not following. Isn't it a test for prctl interceptor? Why are we removing useful tests?
Perhaps it's not the most critical functionality. And perhaps SanitizerSetThreadName needs to be moved to the test itself. But still it's a test.

Apr 20 2018, 9:10 AM

Apr 19 2018

cryptoad updated the diff for D45838: [sanitizer] More dead code removal.

Readding SetEnv.

Apr 19 2018, 3:08 PM
cryptoad created D45838: [sanitizer] More dead code removal.
Apr 19 2018, 2:55 PM
cryptoad committed rL330355: [sanitizer] Minor refactor of some ReservedAddressRange functions.
[sanitizer] Minor refactor of some ReservedAddressRange functions
Apr 19 2018, 11:42 AM
cryptoad committed rCRT330355: [sanitizer] Minor refactor of some ReservedAddressRange functions.
[sanitizer] Minor refactor of some ReservedAddressRange functions
Apr 19 2018, 11:42 AM
cryptoad closed D45775: [sanitizer] Minor refactor of some ReservedAddressRange functions.
Apr 19 2018, 11:42 AM

Apr 18 2018

cryptoad created D45775: [sanitizer] Minor refactor of some ReservedAddressRange functions.
Apr 18 2018, 9:10 AM
cryptoad committed rL330268: [sanitizer] Minor refactor of ThreadDescriptorSize.
[sanitizer] Minor refactor of ThreadDescriptorSize
Apr 18 2018, 8:34 AM
cryptoad committed rCRT330268: [sanitizer] Minor refactor of ThreadDescriptorSize.
[sanitizer] Minor refactor of ThreadDescriptorSize
Apr 18 2018, 8:34 AM
cryptoad closed D45725: [sanitizer] Minor refactor of ThreadDescriptorSize.
Apr 18 2018, 8:34 AM

Apr 17 2018

cryptoad created D45725: [sanitizer] Minor refactor of ThreadDescriptorSize.
Apr 17 2018, 8:50 AM
cryptoad committed rL330190: [sanitizer] Remove low-hanging-fruit dead code.
[sanitizer] Remove low-hanging-fruit dead code
Apr 17 2018, 7:58 AM
cryptoad committed rCRT330190: [sanitizer] Remove low-hanging-fruit dead code.
[sanitizer] Remove low-hanging-fruit dead code
Apr 17 2018, 7:58 AM
cryptoad closed D45704: [sanitizer] Remove low-hanging-fruit dead code.
Apr 17 2018, 7:58 AM

Apr 16 2018

cryptoad added a comment to D45701: Add Logging API Callback for All *SAN Passes.

It seems that the existing weak OnPrint could fulfill the purpose of an application defined "callback" .
Right now it's not be used by any of the sanitizers, and having a weak function & 8 callbacks serving the same purpose seems overkill.

Apr 16 2018, 3:22 PM
cryptoad created D45704: [sanitizer] Remove low-hanging-fruit dead code.
Apr 16 2018, 2:59 PM
cryptoad committed rL330146: [sanitizer] Fix OSX build failure post D45457.
[sanitizer] Fix OSX build failure post D45457
Apr 16 2018, 11:21 AM
cryptoad committed rCRT330146: [sanitizer] Fix OSX build failure post D45457.
[sanitizer] Fix OSX build failure post D45457
Apr 16 2018, 11:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Apr 16 2018, 11:21 AM
cryptoad created D45696: [sanitizer] Fix OSX build failure post D45457.
Apr 16 2018, 11:18 AM
cryptoad committed rCRT330134: [sanitizer] Build failures fixes post D45457.
[sanitizer] Build failures fixes post D45457
Apr 16 2018, 10:01 AM
cryptoad committed rL330134: [sanitizer] Build failures fixes post D45457.
[sanitizer] Build failures fixes post D45457
Apr 16 2018, 10:01 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Apr 16 2018, 10:01 AM
cryptoad updated the diff for D45694: [sanitizer] Build failures fixes post D45457.

Adding one cfi-diag.

Apr 16 2018, 10:00 AM
cryptoad created D45694: [sanitizer] Build failures fixes post D45457.
Apr 16 2018, 9:56 AM
cryptoad committed rL330131: [sanitizer] Split Symbolizer/StackTraces from core RTSanitizerCommon.
[sanitizer] Split Symbolizer/StackTraces from core RTSanitizerCommon
Apr 16 2018, 9:36 AM
cryptoad committed rCRT330131: [sanitizer] Split Symbolizer/StackTraces from core RTSanitizerCommon.
[sanitizer] Split Symbolizer/StackTraces from core RTSanitizerCommon
Apr 16 2018, 9:35 AM
cryptoad closed D45457: [sanitizer] Split Symbolizer/StackTraces from core RTSanitizerCommon.
Apr 16 2018, 9:35 AM
cryptoad updated the diff for D45457: [sanitizer] Split Symbolizer/StackTraces from core RTSanitizerCommon.

Rebasing.

Apr 16 2018, 8:01 AM

Apr 13 2018

cryptoad added inline comments to D45457: [sanitizer] Split Symbolizer/StackTraces from core RTSanitizerCommon.
Apr 13 2018, 3:16 PM
cryptoad added a comment to D45457: [sanitizer] Split Symbolizer/StackTraces from core RTSanitizerCommon.

Anyone else for comments?

Apr 13 2018, 2:52 PM
cryptoad committed rL330055: [sanitizer] Allow for the allocator "names" to be set by the tools.
[sanitizer] Allow for the allocator "names" to be set by the tools
Apr 13 2018, 12:24 PM
cryptoad committed rCRT330055: [sanitizer] Allow for the allocator "names" to be set by the tools.
[sanitizer] Allow for the allocator "names" to be set by the tools
Apr 13 2018, 12:24 PM