cryptoad (Kostya Kortchinsky)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2016, 2:57 PM (88 w, 5 d)

Recent Activity

Fri, Jan 12

cryptoad committed rL322389: [scudo] Add SANITIZER_CXX_ABI_LIBRARY to SCUDO_DYNAMIC_LIBS.
[scudo] Add SANITIZER_CXX_ABI_LIBRARY to SCUDO_DYNAMIC_LIBS
Fri, Jan 12, 10:47 AM
cryptoad committed rCRT322389: [scudo] Add SANITIZER_CXX_ABI_LIBRARY to SCUDO_DYNAMIC_LIBS.
[scudo] Add SANITIZER_CXX_ABI_LIBRARY to SCUDO_DYNAMIC_LIBS
Fri, Jan 12, 10:46 AM
cryptoad closed D41995: [scudo] Add SANITIZER_CXX_ABI_LIBRARY to SCUDO_DYNAMIC_LIBS.
Fri, Jan 12, 10:46 AM
cryptoad created D41995: [scudo] Add SANITIZER_CXX_ABI_LIBRARY to SCUDO_DYNAMIC_LIBS.
Fri, Jan 12, 8:14 AM

Thu, Jan 4

cryptoad committed rL321812: [scudo] Attempt to re-enable the valloc test on armhf.
[scudo] Attempt to re-enable the valloc test on armhf
Thu, Jan 4, 10:36 AM
cryptoad committed rCRT321812: [scudo] Attempt to re-enable the valloc test on armhf.
[scudo] Attempt to re-enable the valloc test on armhf
Thu, Jan 4, 10:36 AM
cryptoad closed D41707: [scudo] Attempt to re-enable the valloc test on armhf.
Thu, Jan 4, 10:36 AM
cryptoad committed rL321811: [docs] Update Scudo documentation.
[docs] Update Scudo documentation
Thu, Jan 4, 10:32 AM
cryptoad closed D41670: [docs] Update Scudo documentation.
Thu, Jan 4, 10:32 AM
cryptoad committed rL321803: [scudo] s/unsigned long/size_t/ for __scudo_set_rss_limit.
[scudo] s/unsigned long/size_t/ for __scudo_set_rss_limit
Thu, Jan 4, 9:06 AM
cryptoad committed rCRT321803: [scudo] s/unsigned long/size_t/ for __scudo_set_rss_limit.
[scudo] s/unsigned long/size_t/ for __scudo_set_rss_limit
Thu, Jan 4, 9:06 AM
cryptoad closed D41704: [scudo] s/unsigned long/size_t/ for __scudo_set_rss_limit.
Thu, Jan 4, 9:06 AM
cryptoad updated the diff for D41670: [docs] Update Scudo documentation.

Addressing review comments.

Thu, Jan 4, 9:03 AM

Wed, Jan 3

cryptoad created D41707: [scudo] Attempt to re-enable the valloc test on armhf.
Wed, Jan 3, 11:53 AM
cryptoad created D41704: [scudo] s/unsigned long/size_t/ for __scudo_set_rss_limit.
Wed, Jan 3, 10:21 AM

Tue, Jan 2

cryptoad created D41670: [docs] Update Scudo documentation.
Tue, Jan 2, 11:03 AM

Mon, Jan 1

cryptoad accepted D41649: [scudo] Touch memory to count as RSS.
Mon, Jan 1, 9:51 AM · Restricted Project
cryptoad added a project to D41649: [scudo] Touch memory to count as RSS: Restricted Project.
Mon, Jan 1, 9:50 AM · Restricted Project

Sun, Dec 31

cryptoad added a comment to D41128: [scudo] Adding a public Scudo interface.

Another point:
For ASan, an identical check exists as a background thread. We decided not to do that due to some requirements on Android.
It could potentially come back as a background thread check on supported platforms if that would address the concerns you are raising.

Sun, Dec 31, 5:16 PM
cryptoad added a comment to D41649: [scudo] Touch memory to count as RSS.

How about using calloc instead and benefiting of the "included" zero'd memory feature? That would avoid implementing the touch function.
I won't be able to test anything before Jan. 2nd.

Sun, Dec 31, 5:09 PM · Restricted Project
cryptoad added a comment to D41128: [scudo] Adding a public Scudo interface.

Any normal build on CentOS 7 failed reliably. I've submitted D41649 which solves the problem for me, I'll see if this also fixes the failure on ARM...

Sun, Dec 31, 4:46 PM
cryptoad added a comment to D41128: [scudo] Adding a public Scudo interface.

The added test has been disabled on armhf in rCRT320665 because it fails a bot: http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/2952/steps/ninja%20check%202/logs/FAIL%3A%20Scudo-armhf%3A%3A%20interface.cpp

I see the exact same error on x86_64 CentOS 7, did you find out what the problem is? I'm happy to assist if you have problems to reproduce the problem...

Sun, Dec 31, 10:33 AM

Tue, Dec 19

cryptoad added a comment to D41413: [scudo] Add -fsanitize=scudo option to Fuchsia..

As discussed: you probably want to enforce mutual exclusion of the sanitizers (eg: ASan is not compatible with Scudo).
I have not test Scudo+Safestack but they should be compatible (or at least with a small amount of work can should be made to be).

Tue, Dec 19, 2:33 PM

Dec 16 2017

cryptoad committed rL320931: [sanitizer] Define __sanitizer_clockid_t on FreeBSD.
[sanitizer] Define __sanitizer_clockid_t on FreeBSD
Dec 16 2017, 3:02 PM
cryptoad committed rCRT320931: [sanitizer] Define __sanitizer_clockid_t on FreeBSD.
[sanitizer] Define __sanitizer_clockid_t on FreeBSD
Dec 16 2017, 3:02 PM
cryptoad closed D41325: [sanitizer] Define __sanitizer_clockid_t on FreeBSD.
Dec 16 2017, 3:01 PM
cryptoad created D41325: [sanitizer] Define __sanitizer_clockid_t on FreeBSD.
Dec 16 2017, 12:53 PM

Dec 14 2017

cryptoad committed rL320745: [scudo] Refactor ScudoChunk.
[scudo] Refactor ScudoChunk
Dec 14 2017, 1:33 PM
cryptoad committed rCRT320745: [scudo] Refactor ScudoChunk.
[scudo] Refactor ScudoChunk
Dec 14 2017, 1:33 PM
cryptoad closed D41200: [scudo] Refactor ScudoChunk.
Dec 14 2017, 1:33 PM

Dec 13 2017

cryptoad committed rL320665: [scudo] Disabling the interface test on armhf.
[scudo] Disabling the interface test on armhf
Dec 13 2017, 6:55 PM
cryptoad committed rCRT320665: [scudo] Disabling the interface test on armhf.
[scudo] Disabling the interface test on armhf
Dec 13 2017, 6:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Dec 13 2017, 6:54 PM
cryptoad created D41218: [scudo] Disabling the interface test on armhf.
Dec 13 2017, 6:53 PM
cryptoad created D41200: [scudo] Refactor ScudoChunk.
Dec 13 2017, 1:30 PM
cryptoad committed rL320611: [scudo] Adding a public Scudo interface.
[scudo] Adding a public Scudo interface
Dec 13 2017, 12:42 PM
cryptoad committed rCRT320611: [scudo] Adding a public Scudo interface.
[scudo] Adding a public Scudo interface
Dec 13 2017, 12:42 PM
cryptoad closed D41128: [scudo] Adding a public Scudo interface.
Dec 13 2017, 12:42 PM
cryptoad updated the diff for D41128: [scudo] Adding a public Scudo interface.

Adding a TODO to add tests for the various defines.
Currently the tests we run leverage a static library built with a default
configuration. We should add gtests like the other sanitizers to ensure all
the compile time configuration options work as expected.

Dec 13 2017, 10:21 AM
cryptoad updated the diff for D41128: [scudo] Adding a public Scudo interface.

Added some words about security in the interface comment.
Added a define to allow the disabling of the function.

Dec 13 2017, 10:06 AM
cryptoad committed rL320594: [sanitizer] Introduce a vDSO aware timing function.
[sanitizer] Introduce a vDSO aware timing function
Dec 13 2017, 8:24 AM
cryptoad committed rCRT320594: [sanitizer] Introduce a vDSO aware timing function.
[sanitizer] Introduce a vDSO aware timing function
Dec 13 2017, 8:24 AM
cryptoad closed D41121: [sanitizer] Introduce a vDSO aware timing function.
Dec 13 2017, 8:24 AM
cryptoad committed rL320592: [scudo] Inline getScudoChunk function..
[scudo] Inline getScudoChunk function.
Dec 13 2017, 8:11 AM
cryptoad committed rCRT320592: [scudo] Inline getScudoChunk function..
[scudo] Inline getScudoChunk function.
Dec 13 2017, 8:11 AM
cryptoad closed D41138: [scudo] Inline getScudoChunk function..
Dec 13 2017, 8:11 AM

Dec 12 2017

cryptoad accepted D41138: [scudo] Inline getScudoChunk function..
Dec 12 2017, 3:28 PM
cryptoad added inline comments to D41121: [sanitizer] Introduce a vDSO aware timing function.
Dec 12 2017, 2:30 PM
cryptoad added inline comments to D41121: [sanitizer] Introduce a vDSO aware timing function.
Dec 12 2017, 2:14 PM
cryptoad added a comment to D41128: [scudo] Adding a public Scudo interface.

I should add here that this is required for programs wanting to set their RSS limit based on computations done at runtime due to hardware constraints or other factors.
From a security perspective, this could have an impact if called with parameters controlled by a malicious user, or if set too low by a program (memory exhaustion exploitation is on the rise).

Dec 12 2017, 1:08 PM
cryptoad created D41128: [scudo] Adding a public Scudo interface.
Dec 12 2017, 1:01 PM
cryptoad updated the diff for D41121: [sanitizer] Introduce a vDSO aware timing function.

Correct the last #endif comment of the file while I am at it, since it
didn't include SANITIZER_NETBSD.

Dec 12 2017, 12:11 PM
cryptoad updated the diff for D41121: [sanitizer] Introduce a vDSO aware timing function.

As suggested, split the code cleanly between Linux-non-Go and the rest.

Dec 12 2017, 12:03 PM
cryptoad updated the diff for D41121: [sanitizer] Introduce a vDSO aware timing function.

Moving the vDSO check under a SANITIZER_LINUX define.

Dec 12 2017, 10:46 AM
cryptoad added inline comments to D41121: [sanitizer] Introduce a vDSO aware timing function.
Dec 12 2017, 10:36 AM
cryptoad added inline comments to D41121: [sanitizer] Introduce a vDSO aware timing function.
Dec 12 2017, 10:30 AM
cryptoad created D41121: [sanitizer] Introduce a vDSO aware timing function.
Dec 12 2017, 10:20 AM

Dec 11 2017

cryptoad committed rCRT320417: [sanitizer] Revert rL320409.
[sanitizer] Revert rL320409
Dec 11 2017, 1:04 PM
cryptoad committed rL320417: [sanitizer] Revert rL320409.
[sanitizer] Revert rL320409
Dec 11 2017, 1:04 PM
cryptoad added a reverting commit for rL320409: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator…: rL320417: [sanitizer] Revert rL320409.
Dec 11 2017, 1:03 PM
cryptoad closed D41088: [sanitizer] Revert rL320409 by committing rCRT320417: [sanitizer] Revert rL320409.
Dec 11 2017, 1:03 PM
cryptoad closed D41088: [sanitizer] Revert rL320409 by committing rL320417: [sanitizer] Revert rL320409.
Dec 11 2017, 1:03 PM
cryptoad created D41088: [sanitizer] Revert rL320409.
Dec 11 2017, 12:51 PM
cryptoad committed rL320409: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator….
[sanitizer] Introduce a vDSO aware time function, and use it in the allocator…
Dec 11 2017, 11:24 AM
cryptoad committed rCRT320409: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator….
[sanitizer] Introduce a vDSO aware time function, and use it in the allocator…
Dec 11 2017, 11:23 AM
cryptoad closed D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo] by committing rCRT320409: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator….
Dec 11 2017, 11:23 AM
cryptoad updated the diff for D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].

Rebasing one last time.

Dec 11 2017, 8:56 AM

Dec 8 2017

cryptoad committed rL320160: [scudo] Minor code generation improvement.
[scudo] Minor code generation improvement
Dec 8 2017, 8:37 AM
cryptoad committed rCRT320160: [scudo] Minor code generation improvement.
[scudo] Minor code generation improvement
Dec 8 2017, 8:37 AM
cryptoad closed D40976: [scudo] Minor code generation improvement by committing rCRT320160: [scudo] Minor code generation improvement.
Dec 8 2017, 8:37 AM

Dec 7 2017

cryptoad updated the summary of D40976: [scudo] Minor code generation improvement.
Dec 7 2017, 3:31 PM
cryptoad created D40976: [scudo] Minor code generation improvement.
Dec 7 2017, 11:32 AM

Dec 6 2017

cryptoad updated the diff for D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].

Adding a MonotonicNanoTime stub for mac.

Dec 6 2017, 9:24 AM
cryptoad committed rL319903: [scudo] Correct performance regression in Secondary.
[scudo] Correct performance regression in Secondary
Dec 6 2017, 8:54 AM
cryptoad committed rCRT319903: [scudo] Correct performance regression in Secondary.
[scudo] Correct performance regression in Secondary
Dec 6 2017, 8:54 AM
cryptoad closed D40862: [scudo] Correct performance regression in Secondary.
Dec 6 2017, 8:53 AM
cryptoad updated the diff for D40862: [scudo] Correct performance regression in Secondary.

Replacing some const with constexpr.

Dec 6 2017, 8:52 AM

Dec 5 2017

cryptoad created D40862: [scudo] Correct performance regression in Secondary.
Dec 5 2017, 2:54 PM
cryptoad added a comment to D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].

@krytarowski: I'd be grateful if you could confirm that this would work on NetBSD. Thanks!

Dec 5 2017, 12:07 PM
cryptoad added a reviewer for D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo]: kubamracek.
Dec 5 2017, 12:07 PM
cryptoad updated the diff for D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].

Moving the NetBSD clock_gettime syscall mangling to
sanitizer_syscall_generic.inc as is the case for others.

Dec 5 2017, 12:05 PM
cryptoad updated the diff for D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].

Rebasing.
Use MonotonicNanoTime for the Scudo RSS checks.

Dec 5 2017, 11:56 AM
cryptoad committed rL319791: [scudo] Get rid of the thread local PRNG & header salt.
[scudo] Get rid of the thread local PRNG & header salt
Dec 5 2017, 9:09 AM
cryptoad committed rCRT319791: [scudo] Get rid of the thread local PRNG & header salt.
[scudo] Get rid of the thread local PRNG & header salt
Dec 5 2017, 9:09 AM
cryptoad closed D40796: [scudo] Get rid of the thread local PRNG & header salt.
Dec 5 2017, 9:09 AM

Dec 4 2017

cryptoad created D40796: [scudo] Get rid of the thread local PRNG & header salt.
Dec 4 2017, 11:58 AM
cryptoad committed rCRT319673: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor.
[sanitizer] 64-bit allocator's PopulateFreeArray partial refactor
Dec 4 2017, 10:57 AM
cryptoad committed rL319673: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor.
[sanitizer] 64-bit allocator's PopulateFreeArray partial refactor
Dec 4 2017, 10:57 AM
cryptoad closed D40754: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor.
Dec 4 2017, 10:57 AM
cryptoad requested review of D40754: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor.
Dec 4 2017, 10:11 AM
cryptoad updated the diff for D40754: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor.

Introduce IsRegionExhausted that checks if the region has enough room prior
to calling Mmap for the user & metadata portions of memory.
Fold all the metadata work in a if (kMetadataSize).

Dec 4 2017, 10:11 AM
cryptoad accepted D40765: Handle NetBSD symbol renaming in sanitizer_common_interceptors.inc.
Dec 4 2017, 8:26 AM · Restricted Project

Dec 2 2017

cryptoad added inline comments to D40754: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor.
Dec 2 2017, 3:01 PM

Dec 1 2017

cryptoad added inline comments to D40754: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor.
Dec 1 2017, 3:00 PM
cryptoad added a reviewer for D40754: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor: flowerhack.
Dec 1 2017, 2:25 PM
cryptoad updated the summary of D40754: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor.
Dec 1 2017, 2:21 PM
cryptoad created D40754: [sanitizer] 64-bit allocator's PopulateFreeArray partial refactor.
Dec 1 2017, 2:19 PM
cryptoad added inline comments to D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].
Dec 1 2017, 10:54 AM
cryptoad updated the diff for D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].

s/CanUseVDSO/CanUseLibcClockGetTime

Dec 1 2017, 10:53 AM
cryptoad added inline comments to D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].
Dec 1 2017, 10:09 AM