cryptoad (Kostya Kortchinsky)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2016, 2:57 PM (118 w, 5 d)

Recent Activity

Yesterday

cryptoad committed rL339705: [scudo] Fix race condition in deallocation path when Quarantine is bypassed.
[scudo] Fix race condition in deallocation path when Quarantine is bypassed
Tue, Aug 14, 11:35 AM
cryptoad committed rCRT339705: [scudo] Fix race condition in deallocation path when Quarantine is bypassed.
[scudo] Fix race condition in deallocation path when Quarantine is bypassed
Tue, Aug 14, 11:35 AM
cryptoad closed D50655: [scudo] Fix race condition in deallocation path when Quarantine is bypassed.
Tue, Aug 14, 11:35 AM
cryptoad added inline comments to D50655: [scudo] Fix race condition in deallocation path when Quarantine is bypassed.
Tue, Aug 14, 11:10 AM

Mon, Aug 13

cryptoad updated the diff for D50655: [scudo] Fix race condition in deallocation path when Quarantine is bypassed.

Grammar/punctuation corrections in comments.

Mon, Aug 13, 3:07 PM
cryptoad added inline comments to D50655: [scudo] Fix race condition in deallocation path when Quarantine is bypassed.
Mon, Aug 13, 2:30 PM
cryptoad updated the diff for D50655: [scudo] Fix race condition in deallocation path when Quarantine is bypassed.

Account for 0 size, which is more common than one would expect.

Mon, Aug 13, 1:53 PM
cryptoad created D50655: [scudo] Fix race condition in deallocation path when Quarantine is bypassed.
Mon, Aug 13, 11:37 AM
cryptoad committed rL339575: [sanitizer] Remove st(X) from the clobber list in 32-bit x86 atomics.
[sanitizer] Remove st(X) from the clobber list in 32-bit x86 atomics
Mon, Aug 13, 8:02 AM
cryptoad committed rCRT339575: [sanitizer] Remove st(X) from the clobber list in 32-bit x86 atomics.
[sanitizer] Remove st(X) from the clobber list in 32-bit x86 atomics
Mon, Aug 13, 8:02 AM
cryptoad closed D50562: [sanitizer] Remove st(X) from the clobber list in 32-bit x86 atomics.
Mon, Aug 13, 8:01 AM

Fri, Aug 10

cryptoad created D50562: [sanitizer] Remove st(X) from the clobber list in 32-bit x86 atomics.
Fri, Aug 10, 8:34 AM

Thu, Aug 9

cryptoad committed rL339370: [sanitizer] Remove rsp from the clobber list in internal_clone.
[sanitizer] Remove rsp from the clobber list in internal_clone
Thu, Aug 9, 1:01 PM
cryptoad committed rCRT339370: [sanitizer] Remove rsp from the clobber list in internal_clone.
[sanitizer] Remove rsp from the clobber list in internal_clone
Thu, Aug 9, 1:01 PM
cryptoad closed D50519: [sanitizer] Remove rsp from the clobber list in internal_clone.
Thu, Aug 9, 1:01 PM
cryptoad added a comment to D50406: SafeStack: Delay thread stack clean-up.

malloc() would only be called during thread destruction, so it doesn't seem like there should be an issue unless malloc() causes a thread to destruct and even then this function shouldn't re-enter because of the order of when pthread_setspecific() is called. Perhaps I'm just failing to imagine a situation under which this could be an issue?

Thu, Aug 9, 12:33 PM
cryptoad added a comment to D50406: SafeStack: Delay thread stack clean-up.

Random thought: isn't the introduction of malloc here (as opposed to an OS backed alternative like mmap) gonna mess compatibility with other Sanitizers that intercept it? (thinking of Scudo which is currently compatible with SafeStack but I haven't tested).

Thu, Aug 9, 12:05 PM
cryptoad created D50519: [sanitizer] Remove rsp from the clobber list in internal_clone.
Thu, Aug 9, 10:18 AM

Fri, Jul 20

cryptoad committed rL337574: [zorg] Set CHECK_SCUDO to 1 for ppc64.
[zorg] Set CHECK_SCUDO to 1 for ppc64
Fri, Jul 20, 9:45 AM
cryptoad closed D49604: [zorg] Set CHECK_SCUDO to 1 for ppc64.
Fri, Jul 20, 9:45 AM
cryptoad created D49604: [zorg] Set CHECK_SCUDO to 1 for ppc64.
Fri, Jul 20, 8:46 AM
cryptoad committed rL337557: [scudo] Simplify internal names (NFC).
[scudo] Simplify internal names (NFC)
Fri, Jul 20, 8:12 AM
cryptoad committed rCRT337557: [scudo] Simplify internal names (NFC).
[scudo] Simplify internal names (NFC)
Fri, Jul 20, 8:12 AM
cryptoad closed D49505: [scudo] Simplify internal names (NFC).
Fri, Jul 20, 8:12 AM
cryptoad committed rL337556: [zorg] Set CHECK_SCUDO to 1 for aarch64.
[zorg] Set CHECK_SCUDO to 1 for aarch64
Fri, Jul 20, 7:57 AM
cryptoad closed D48895: [zorg] Set CHECK_SCUDO to 1 for aarch64.
Fri, Jul 20, 7:57 AM

Wed, Jul 18

cryptoad updated the diff for D49505: [scudo] Simplify internal names (NFC).

Bringing back {Primary|Secondary}T.

Wed, Jul 18, 3:49 PM
cryptoad added a comment to D49505: [scudo] Simplify internal names (NFC).

Thanks. No worries I'll change it back!

Wed, Jul 18, 3:42 PM
cryptoad updated the diff for D49505: [scudo] Simplify internal names (NFC).

Keeping {Primary|Secondary}Allocator for clarity.

Wed, Jul 18, 1:23 PM
cryptoad created D49505: [scudo] Simplify internal names (NFC).
Wed, Jul 18, 1:04 PM
cryptoad edited reviewers for D48895: [zorg] Set CHECK_SCUDO to 1 for aarch64, added: alekseyshl, eugenis; removed: javed.absar.
Wed, Jul 18, 9:57 AM

Jul 13 2018

cryptoad committed rL337010: [sanitizer] Use -Wl,-z,global on Android.
[sanitizer] Use -Wl,-z,global on Android
Jul 13 2018, 8:36 AM
cryptoad committed rCRT337010: [sanitizer] Use -Wl,-z,global on Android.
[sanitizer] Use -Wl,-z,global on Android
Jul 13 2018, 8:36 AM
cryptoad closed D49198: [sanitizer] Use -Wl,-z,global on Android.
Jul 13 2018, 8:36 AM

Jul 12 2018

cryptoad retitled D49198: [sanitizer] Use -Wl,-z,global on Android from [scudo] Use -Wl,-z,global on Android to [sanitizer] Use -Wl,-z,global on Android.
Jul 12 2018, 11:58 AM
cryptoad added inline comments to D49198: [sanitizer] Use -Wl,-z,global on Android.
Jul 12 2018, 11:53 AM
cryptoad updated the diff for D49198: [sanitizer] Use -Wl,-z,global on Android.

Moving the "global" link flag to the common CMake code so that it can benefit
all the shared libraries. Remove the previous instances of said code in ASan
and HWAsan.

Jul 12 2018, 11:52 AM
cryptoad updated the summary of D49198: [sanitizer] Use -Wl,-z,global on Android.
Jul 12 2018, 11:14 AM
cryptoad added inline comments to D49198: [sanitizer] Use -Wl,-z,global on Android.
Jul 12 2018, 11:13 AM
cryptoad updated the diff for D49198: [sanitizer] Use -Wl,-z,global on Android.

s/ASAN/SCUDO because I failed at copy/pasting :(

Jul 12 2018, 11:10 AM
cryptoad updated the summary of D49198: [sanitizer] Use -Wl,-z,global on Android.
Jul 12 2018, 11:08 AM

Jul 11 2018

cryptoad updated the diff for D49198: [sanitizer] Use -Wl,-z,global on Android.

Updating comment.

Jul 11 2018, 12:17 PM
cryptoad updated the summary of D49198: [sanitizer] Use -Wl,-z,global on Android.
Jul 11 2018, 12:14 PM
cryptoad updated the summary of D49198: [sanitizer] Use -Wl,-z,global on Android.
Jul 11 2018, 12:13 PM
cryptoad created D49198: [sanitizer] Use -Wl,-z,global on Android.
Jul 11 2018, 11:44 AM

Jul 10 2018

cryptoad added a comment to D48895: [zorg] Set CHECK_SCUDO to 1 for aarch64.

Ping pretty please.

Jul 10 2018, 8:06 AM

Jul 6 2018

cryptoad committed rCRT336445: [scudo] Add some logs for Android.
[scudo] Add some logs for Android
Jul 6 2018, 9:55 AM
cryptoad committed rL336445: [scudo] Add some logs for Android.
[scudo] Add some logs for Android
Jul 6 2018, 9:55 AM
cryptoad closed D48902: [scudo] Add some logs for Android.
Jul 6 2018, 9:54 AM

Jul 3 2018

cryptoad updated the diff for D48902: [scudo] Add some logs for Android.

Updated the sequence.

Jul 3 2018, 3:39 PM
cryptoad created D48902: [scudo] Add some logs for Android.
Jul 3 2018, 3:37 PM
cryptoad created D48895: [zorg] Set CHECK_SCUDO to 1 for aarch64.
Jul 3 2018, 1:43 PM
cryptoad committed rL336221: [scudo] Get rid of builtin-declaration-mismatch warnings.
[scudo] Get rid of builtin-declaration-mismatch warnings
Jul 3 2018, 12:08 PM
cryptoad committed rCRT336221: [scudo] Get rid of builtin-declaration-mismatch warnings.
[scudo] Get rid of builtin-declaration-mismatch warnings
Jul 3 2018, 12:08 PM
cryptoad closed D48885: [scudo] Get rid of builtin-declaration-mismatch warnings.
Jul 3 2018, 12:08 PM
cryptoad created D48885: [scudo] Get rid of builtin-declaration-mismatch warnings.
Jul 3 2018, 10:07 AM
cryptoad committed rL336213: [scudo] Enable Scudo on PPC64.
[scudo] Enable Scudo on PPC64
Jul 3 2018, 9:14 AM
cryptoad committed rCRT336213: [scudo] Enable Scudo on PPC64.
[scudo] Enable Scudo on PPC64
Jul 3 2018, 9:14 AM
cryptoad closed D48834: [scudo] Enable Scudo on PPC64.
Jul 3 2018, 9:14 AM
cryptoad committed rL336202: [Driver] Add PPC64 as supported for Scudo.
[Driver] Add PPC64 as supported for Scudo
Jul 3 2018, 7:44 AM
cryptoad committed rC336202: [Driver] Add PPC64 as supported for Scudo.
[Driver] Add PPC64 as supported for Scudo
Jul 3 2018, 7:44 AM
cryptoad closed D48833: [Driver] Add PPC64 as supported for Scudo.
Jul 3 2018, 7:44 AM

Jul 2 2018

cryptoad committed rL336139: [scudo] Enable Scudo memory hooks for Fuchsia..
[scudo] Enable Scudo memory hooks for Fuchsia.
Jul 2 2018, 12:53 PM
cryptoad committed rCRT336139: [scudo] Enable Scudo memory hooks for Fuchsia..
[scudo] Enable Scudo memory hooks for Fuchsia.
Jul 2 2018, 12:52 PM
cryptoad closed D48618: [scudo] Enable Scudo memory hooks for Fuchsia..
Jul 2 2018, 12:52 PM
cryptoad added a comment to D48618: [scudo] Enable Scudo memory hooks for Fuchsia..

I like that this matches the style of the SCUDO_SHARED_TSD_POOL_SIZE enables, so I may leave it as-is, if that's alright with you.

Jul 2 2018, 12:50 PM
cryptoad created D48834: [scudo] Enable Scudo on PPC64.
Jul 2 2018, 9:11 AM
cryptoad created D48833: [Driver] Add PPC64 as supported for Scudo.
Jul 2 2018, 9:08 AM

Jun 29 2018

cryptoad committed rCRT335981: [scudo] Add some runtime tests for the minimal runtime.
[scudo] Add some runtime tests for the minimal runtime
Jun 29 2018, 8:01 AM
cryptoad committed rL335981: [scudo] Add some runtime tests for the minimal runtime.
[scudo] Add some runtime tests for the minimal runtime
Jun 29 2018, 8:01 AM
cryptoad closed D48553: [scudo] Add some runtime tests for the minimal runtime.
Jun 29 2018, 8:01 AM

Jun 28 2018

cryptoad updated the diff for D48553: [scudo] Add some runtime tests for the minimal runtime.

Addressing review comment.

Jun 28 2018, 11:13 AM
cryptoad updated the diff for D48553: [scudo] Add some runtime tests for the minimal runtime.

Rebasing.

Jun 28 2018, 10:01 AM
cryptoad added a comment to D48553: [scudo] Add some runtime tests for the minimal runtime.

Ping!

Jun 28 2018, 9:31 AM

Jun 26 2018

cryptoad accepted D48618: [scudo] Enable Scudo memory hooks for Fuchsia..

Or maybe wrap it all with # define SCUDO_CAN_USE_HOOKS (SANITIZER_FUCHSIA) or equivalent if it looks cleaner. Up to you.

Jun 26 2018, 5:53 PM
cryptoad committed rL335620: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android.
[Driver] Do not add -lpthread & -lrt with -static-libsan on Android
Jun 26 2018, 9:19 AM
cryptoad committed rC335620: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android.
[Driver] Do not add -lpthread & -lrt with -static-libsan on Android
Jun 26 2018, 9:19 AM
cryptoad closed D48570: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android.
Jun 26 2018, 9:19 AM
cryptoad updated the diff for D48570: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android.

Rebasing.

Jun 26 2018, 9:18 AM
cryptoad resigned from D48422: [CMake] Add compiler-rt header files to the list of sources for targets when building with an IDE.
Jun 26 2018, 8:23 AM

Jun 25 2018

cryptoad updated the diff for D48553: [scudo] Add some runtime tests for the minimal runtime.

Re-enabling the fsanitize test for Android, but this is contingent to the
landing of D48570.

Jun 25 2018, 2:59 PM
cryptoad created D48570: [Driver] Do not add -lpthread & -lrt with -static-libsan on Android.
Jun 25 2018, 2:47 PM
cryptoad updated the diff for D48553: [scudo] Add some runtime tests for the minimal runtime.

Disabling the fsanitize test on Android. When compiled with -static-libsan on
Android, linking fails due to -lrt & -lpthread being unavailable. I believe
this is linkSanitizerRuntimeDeps's fault.

Jun 25 2018, 2:01 PM
cryptoad updated the diff for D48553: [scudo] Add some runtime tests for the minimal runtime.

Remove the symbol InternalAlloc as the test wouldn't pass on a standalone
build (actively requires gc-sections).

Jun 25 2018, 10:43 AM
cryptoad created D48553: [scudo] Add some runtime tests for the minimal runtime.
Jun 25 2018, 10:37 AM

Jun 22 2018

cryptoad added a comment to D48446: [ubsan] Add support for reporting diagnostics to a monitor process.

This seems to have broken the Windows build.
vc:\b\slave\sanitizer-windows\llvm\projects\compiler-rt\lib\ubsan\ubsan_interface.inc(55): error C2065: '__ubsan_on_report': undeclared identifier
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/30528/steps/build%20compiler-rt/logs/stdio

Jun 22 2018, 12:30 PM
cryptoad committed rL335352: [Driver] Make scudo compatible with -fsanitize-minimal-runtime.
[Driver] Make scudo compatible with -fsanitize-minimal-runtime
Jun 22 2018, 7:36 AM
cryptoad committed rC335352: [Driver] Make scudo compatible with -fsanitize-minimal-runtime.
[Driver] Make scudo compatible with -fsanitize-minimal-runtime
Jun 22 2018, 7:36 AM
cryptoad closed D48373: [Driver] Make scudo compatible with -fsanitize-minimal-runtime.
Jun 22 2018, 7:36 AM

Jun 21 2018

cryptoad committed rL335296: [scudo] Add a minimal runtime for -fsanitize-minimal-runtime compatibility.
[scudo] Add a minimal runtime for -fsanitize-minimal-runtime compatibility
Jun 21 2018, 2:52 PM
cryptoad committed rCRT335296: [scudo] Add a minimal runtime for -fsanitize-minimal-runtime compatibility.
[scudo] Add a minimal runtime for -fsanitize-minimal-runtime compatibility
Jun 21 2018, 2:52 PM
cryptoad closed D48377: [scudo] Add a minimal runtime for -fsanitize-minimal-runtime compatibility.
Jun 21 2018, 2:52 PM

Jun 20 2018

cryptoad updated the diff for D48373: [Driver] Make scudo compatible with -fsanitize-minimal-runtime.

Adding tests.

Jun 20 2018, 2:32 PM
cryptoad created D48377: [scudo] Add a minimal runtime for -fsanitize-minimal-runtime compatibility.
Jun 20 2018, 9:13 AM
cryptoad created D48373: [Driver] Make scudo compatible with -fsanitize-minimal-runtime.
Jun 20 2018, 8:42 AM

Jun 19 2018

cryptoad accepted D48328: [Sanitizers] Remove OOM/BadRequest allocator error handling policies..
Jun 19 2018, 11:34 AM
cryptoad committed rL335054: [scudo] Move noinline functions definitions out of line.
[scudo] Move noinline functions definitions out of line
Jun 19 2018, 8:41 AM
cryptoad committed rCRT335054: [scudo] Move noinline functions definitions out of line.
[scudo] Move noinline functions definitions out of line
Jun 19 2018, 8:41 AM
cryptoad closed D48228: [scudo] Move noinline functions definitions out of line.
Jun 19 2018, 8:40 AM

Jun 15 2018

cryptoad created D48228: [scudo] Move noinline functions definitions out of line.
Jun 15 2018, 10:29 AM