Page MenuHomePhabricator

cryptoad (Kostya Kortchinsky)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2016, 2:57 PM (167 w, 3 d)

Recent Activity

Mon, Jul 15

cryptoad updated the diff for D64664: [scudo][standalone] Optimization pass.

More optimizations:

BM_youtube/min_time:15.000/repeats:4/manual_time_mean       410274 us       615999 us            4
BM_youtube/min_time:15.000/repeats:4/manual_time_median     410246 us       616125 us            4
BM_youtube/min_time:15.000/repeats:4/manual_time_stddev        302 us          587 us            4
Mon, Jul 15, 10:34 AM · Restricted Project, Restricted Project

Fri, Jul 12

cryptoad updated the summary of D64664: [scudo][standalone] Optimization pass.
Fri, Jul 12, 1:49 PM · Restricted Project, Restricted Project
cryptoad created D64664: [scudo][standalone] Optimization pass.
Fri, Jul 12, 1:49 PM · Restricted Project, Restricted Project

Thu, Jul 11

cryptoad committed rG8f18a4c980be: [scudo][standalone] NFC corrections (authored by cryptoad).
[scudo][standalone] NFC corrections
Thu, Jul 11, 12:56 PM
cryptoad committed rL365816: [scudo][standalone] NFC corrections.
[scudo][standalone] NFC corrections
Thu, Jul 11, 12:56 PM
cryptoad closed D64570: [scudo][standalone] NFC corrections.
Thu, Jul 11, 12:56 PM · Restricted Project, Restricted Project
cryptoad created D64570: [scudo][standalone] NFC corrections.
Thu, Jul 11, 9:16 AM · Restricted Project, Restricted Project
cryptoad committed rGaeb3826228a7: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one (authored by cryptoad).
[scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one
Thu, Jul 11, 8:33 AM
cryptoad committed rL365790: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
[scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one
Thu, Jul 11, 8:33 AM
cryptoad closed D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
Thu, Jul 11, 8:33 AM · Restricted Project, Restricted Project

Wed, Jul 10

cryptoad added inline comments to D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
Wed, Jul 10, 9:18 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
Wed, Jul 10, 9:10 AM · Restricted Project, Restricted Project
cryptoad added a comment to D64457: [GWP-ASan] Attempt to fix Android/ARM platforms..

It's OK with me. Part of the reason for splitting out the symbolizer was some memory overhead as well, which we probably want to look into.
Is COMPILER_RT_HAS_GWP_ASAN going to be true by default for Android? If so we probably should loop in the toolchain team so that there is no surprise on their next toolchain update.

Wed, Jul 10, 8:12 AM · Restricted Project, Restricted Project

Tue, Jul 9

cryptoad updated the diff for D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.

Addressing review comments:

  • commenting the use of the #pragma nounroll
  • using the platform specific types in mutex.h
Tue, Jul 9, 12:18 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.

Move the mutex state enum into linux.cc since it's only used there.

Tue, Jul 9, 9:12 AM · Restricted Project, Restricted Project

Mon, Jul 8

cryptoad updated the diff for D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
  • Adding constexpr for the number of yields & trys in the mutex class;
  • Adding a test to ensure that scudo::getPageSizeCached is consitent with getpagesize;
Mon, Jul 8, 1:47 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
Mon, Jul 8, 1:33 PM · Restricted Project, Restricted Project
cryptoad created D64358: [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one.
Mon, Jul 8, 11:52 AM · Restricted Project, Restricted Project

Wed, Jul 3

cryptoad committed rGf50a953ea776: [scudo][standalone] Link tests against libatomic (authored by cryptoad).
[scudo][standalone] Link tests against libatomic
Wed, Jul 3, 9:34 AM
cryptoad committed rL365052: [scudo][standalone] Link tests against libatomic.
[scudo][standalone] Link tests against libatomic
Wed, Jul 3, 9:34 AM
cryptoad closed D64134: [scudo][standalone] Link tests against libatomic.
Wed, Jul 3, 9:34 AM · Restricted Project, Restricted Project
cryptoad created D64134: [scudo][standalone] Link tests against libatomic.
Wed, Jul 3, 7:51 AM · Restricted Project, Restricted Project
cryptoad committed rGd63d14f76b9a: [scudo][standalone] Potential fix for missing sized delete (authored by cryptoad).
[scudo][standalone] Potential fix for missing sized delete
Wed, Jul 3, 7:40 AM
cryptoad committed rL365045: [scudo][standalone] Potential fix for missing sized delete.
[scudo][standalone] Potential fix for missing sized delete
Wed, Jul 3, 7:39 AM
cryptoad closed D64086: [scudo][standalone] Potential fix for missing sized delete.
Wed, Jul 3, 7:39 AM · Restricted Project, Restricted Project

Tue, Jul 2

cryptoad added a comment to D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

Regarding Teresa's issue, it seems to boil down to the version of clang, and not inlining the __atomic_load_8 & co.
Looking at godbolt, it doesn't seem to happen until clang 6, while gcc did it since a while.
After attempting to conditionally add -latomic, and failing, I am resorting to adding -latomic unconditionally to the tests link flags, unless someone has a better idea.

Tue, Jul 2, 1:49 PM · Restricted Project, Restricted Project
cryptoad added a comment to D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

Tentative fix for this is in https://reviews.llvm.org/D64086, if you could please let me know if that works for you.

Tue, Jul 2, 12:44 PM · Restricted Project, Restricted Project
cryptoad accepted D64085: [GWP-ASan] [Scudo] Add GWP-ASan backtrace for alloc/free to Scudo..
Tue, Jul 2, 10:24 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D64086: [scudo][standalone] Potential fix for missing sized delete.

s/kostya/kostyak/

Tue, Jul 2, 10:11 AM · Restricted Project, Restricted Project
cryptoad created D64086: [scudo][standalone] Potential fix for missing sized delete.
Tue, Jul 2, 9:58 AM · Restricted Project, Restricted Project

Thu, Jun 27

cryptoad committed rGd44cb7a65673: [scudo][standalone] Introduce the C & C++ wrappers [fixed] (authored by cryptoad).
[scudo][standalone] Introduce the C & C++ wrappers [fixed]
Thu, Jun 27, 7:25 AM
cryptoad committed rL364547: [scudo][standalone] Introduce the C & C++ wrappers [fixed].
[scudo][standalone] Introduce the C & C++ wrappers [fixed]
Thu, Jun 27, 7:25 AM
cryptoad closed D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].
Thu, Jun 27, 7:24 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

clang-format'd.

Thu, Jun 27, 7:22 AM · Restricted Project, Restricted Project

Wed, Jun 26

cryptoad added a comment to D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

Thank you Douglas!

Wed, Jun 26, 3:31 PM · Restricted Project, Restricted Project
cryptoad created D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].
Wed, Jun 26, 11:13 AM · Restricted Project, Restricted Project

Tue, Jun 25

cryptoad committed rL364345: [scudo] Correct a behavior on the shared TSD registry.
[scudo] Correct a behavior on the shared TSD registry
Tue, Jun 25, 1:08 PM
cryptoad committed rG3ad32a037efc: [scudo] Correct a behavior on the shared TSD registry (authored by cryptoad).
[scudo] Correct a behavior on the shared TSD registry
Tue, Jun 25, 1:08 PM
cryptoad closed D63783: [scudo] Correct a behavior on the shared TSD registry.
Tue, Jun 25, 1:07 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D63783: [scudo] Correct a behavior on the shared TSD registry.

Remove unchanged files from CL.

Tue, Jun 25, 12:03 PM · Restricted Project, Restricted Project
cryptoad created D63783: [scudo] Correct a behavior on the shared TSD registry.
Tue, Jun 25, 12:03 PM · Restricted Project, Restricted Project
cryptoad committed rL364332: [scudo][standalone] Introduce the C & C++ wrappers.
[scudo][standalone] Introduce the C & C++ wrappers
Tue, Jun 25, 10:09 AM
cryptoad committed rG37340e3cd62d: [scudo][standalone] Introduce the C & C++ wrappers (authored by cryptoad).
[scudo][standalone] Introduce the C & C++ wrappers
Tue, Jun 25, 10:02 AM
cryptoad closed D63612: [scudo][standalone] Introduce the C & C++ wrappers.
Tue, Jun 25, 10:01 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D63612: [scudo][standalone] Introduce the C & C++ wrappers.

Adding a testcase for a Class to the New tests.

Tue, Jun 25, 8:13 AM · Restricted Project, Restricted Project

Mon, Jun 24

cryptoad updated the diff for D63612: [scudo][standalone] Introduce the C & C++ wrappers.

Changing some errno behaviors to be more consistent.
Renaming wrappers.inc to wrappers_c.inc and updated associated strings.

Mon, Jun 24, 1:41 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D63612: [scudo][standalone] Introduce the C & C++ wrappers.
Mon, Jun 24, 1:40 PM · Restricted Project, Restricted Project

Jun 21 2019

cryptoad updated the diff for D63612: [scudo][standalone] Introduce the C & C++ wrappers.

Fixing a couple of errors that came up in testing.

Jun 21 2019, 8:09 AM · Restricted Project, Restricted Project

Jun 20 2019

cryptoad created D63612: [scudo][standalone] Introduce the C & C++ wrappers.
Jun 20 2019, 9:54 AM · Restricted Project, Restricted Project

Jun 18 2019

cryptoad committed rG5cf216c9a72a: [scudo][standalone] Fuchsia related changes (authored by cryptoad).
[scudo][standalone] Fuchsia related changes
Jun 18 2019, 10:38 AM
cryptoad committed rL363705: [scudo][standalone] Fuchsia related changes.
[scudo][standalone] Fuchsia related changes
Jun 18 2019, 10:38 AM
cryptoad closed D63435: [scudo][standalone] Fuchsia related changes.
Jun 18 2019, 10:38 AM · Restricted Project, Restricted Project

Jun 17 2019

cryptoad created D63435: [scudo][standalone] Fuchsia related changes.
Jun 17 2019, 8:42 AM · Restricted Project, Restricted Project
cryptoad committed rGe4eadf174cb1: [scudo][standalone] Introduce the combined allocator (authored by cryptoad).
[scudo][standalone] Introduce the combined allocator
Jun 17 2019, 8:21 AM
cryptoad committed rL363569: [scudo][standalone] Introduce the combined allocator.
[scudo][standalone] Introduce the combined allocator
Jun 17 2019, 8:20 AM
cryptoad closed D63231: [scudo][standalone] Introduce the combined allocator.
Jun 17 2019, 8:20 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Removing a reinterpret_cast<void *>.

Jun 17 2019, 8:20 AM · Restricted Project, Restricted Project

Jun 14 2019

cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Addressing review comments:

  • renaming allocator.h to allocator_config.h
  • adding FuchsiaConfig to the battery of tests (64-bit only)
Jun 14 2019, 3:37 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D63231: [scudo][standalone] Introduce the combined allocator.
Jun 14 2019, 3:33 PM · Restricted Project, Restricted Project

Jun 13 2019

cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Tune some tests & Quarantine parameters.

Jun 13 2019, 10:01 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D63231: [scudo][standalone] Introduce the combined allocator.

Enabled the Quarantine for some tests, which wasn't used before.

Jun 13 2019, 9:44 AM · Restricted Project, Restricted Project

Jun 12 2019

cryptoad created D63231: [scudo][standalone] Introduce the combined allocator.
Jun 12 2019, 3:30 PM · Restricted Project, Restricted Project

Jun 11 2019

cryptoad committed rG624a24e15633: [scudo][standalone] Unmap memory in tests (authored by cryptoad).
[scudo][standalone] Unmap memory in tests
Jun 11 2019, 12:48 PM
cryptoad committed rL363095: [scudo][standalone] Unmap memory in tests.
[scudo][standalone] Unmap memory in tests
Jun 11 2019, 12:47 PM
cryptoad closed D63146: [scudo][standalone] Unmap memory in tests.
Jun 11 2019, 12:47 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D63146: [scudo][standalone] Unmap memory in tests.

Update the deleters to actually delete the pointer itself as well.

Jun 11 2019, 10:35 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D63146: [scudo][standalone] Unmap memory in tests.
Jun 11 2019, 10:32 AM · Restricted Project, Restricted Project
cryptoad created D63146: [scudo][standalone] Unmap memory in tests.
Jun 11 2019, 9:33 AM · Restricted Project, Restricted Project

Jun 10 2019

cryptoad committed rG52bfd673d155: [scudo][standalone] Introduce the thread specific data structures (authored by cryptoad).
[scudo][standalone] Introduce the thread specific data structures
Jun 10 2019, 9:49 AM
cryptoad committed rL362962: [scudo][standalone] Introduce the thread specific data structures.
[scudo][standalone] Introduce the thread specific data structures
Jun 10 2019, 9:48 AM
cryptoad closed D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 10 2019, 9:48 AM · Restricted Project, Restricted Project

Jun 7 2019

cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Always call initOnce, and rename it initOnceMaybe to reflect that
initialization might not necessarily occur if it already happened.

Jun 7 2019, 2:01 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

clang-format'ing the code.

Jun 7 2019, 1:24 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Use an atomic_u8 for Initialized instead of a bool.

Jun 7 2019, 1:20 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 7 2019, 1:17 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

As discussed through comments, re-introduce a StaticSpinMutex to the
"once" initialization of the TSD registry, and remove its no-op
initLinkerInitialized in the various places it was used.
Also adds a test to exercise the path of "direct" initialization
via calling initLinkerInitialized directly on the registry.

Jun 7 2019, 9:16 AM · Restricted Project, Restricted Project

Jun 6 2019

cryptoad added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 6 2019, 5:02 PM · Restricted Project, Restricted Project
cryptoad accepted D62929: [GWP-ASan] Integration with Scudo [5]..
Jun 6 2019, 2:08 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
Jun 6 2019, 1:20 PM · Restricted Project, Restricted Project
cryptoad added a comment to D62258: [scudo][standalone] Introduce the thread specific data structures.

Ping pretty please! I think all the comments were addressed one way or another. The new structure doesn't "cycle" anymore.

Jun 6 2019, 8:00 AM · Restricted Project, Restricted Project

Jun 5 2019

cryptoad added a comment to D62929: [GWP-ASan] Integration with Scudo [5]..

I think it's good from the integration perspective.
The only potential concern I have is the specific use of the TLS variables in GWP-ASan which might not work everywhere here (eg: if a platform is using emutls as TLS as it uses malloc() internally).
Have you tested that locally with an Android emulator?

Jun 5 2019, 2:09 PM · Restricted Project, Restricted Project

Jun 3 2019

cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Disable a test on 32-bit for now: we are running out of address space.
This will be fixed in a subsequent CL, but affects the tests of this one.

Jun 3 2019, 10:32 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Change the Primary test again to be more forgiving to OOM.

Jun 3 2019, 10:13 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Add a comment for MinimalInit.

Jun 3 2019, 9:59 AM · Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

This, hopefully, detangles a bit the initialization process for
the registry. In order to do that, we get rid of the mutex in favor
of our own call_once type construct (losely inspired by
llvm::call_once). We move the initialization code into
initLinkerInitialized.

Jun 3 2019, 9:47 AM · Restricted Project, Restricted Project

May 29 2019

cryptoad added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
May 29 2019, 3:13 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D62258: [scudo][standalone] Introduce the thread specific data structures.
May 29 2019, 11:52 AM · Restricted Project, Restricted Project

May 24 2019

cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Switching from a spin mutex to a blocking mutex for initOnce.

May 24 2019, 2:07 PM · Restricted Project, Restricted Project
cryptoad added a comment to D62368: Add support for Hygon Dhyana processor.

Regarding the Scudo side of the patch: the code has to be able to compile with gcc as well, and not necessarily the latest version.
This won't compile on systems without a signature_HYGON_*.

May 24 2019, 10:00 AM · Restricted Project, Restricted Project, Restricted Project
cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Addressing several of Matt's review points:

  • adding comments to obscure code snippets
  • calling initLinkerInitialized when needed
  • changing unique_ptr's get()-> to ->
  • simplifying some code constructs
May 24 2019, 8:51 AM · Restricted Project, Restricted Project
cryptoad added a comment to D62258: [scudo][standalone] Introduce the thread specific data structures.

Matt, thank you for all the reviews you are doing. Very insightful points.

May 24 2019, 8:50 AM · Restricted Project, Restricted Project

May 22 2019

cryptoad updated the diff for D62258: [scudo][standalone] Introduce the thread specific data structures.

Correct a test and some formatting.

May 22 2019, 9:55 AM · Restricted Project, Restricted Project
cryptoad created D62258: [scudo][standalone] Introduce the thread specific data structures.
May 22 2019, 8:19 AM · Restricted Project, Restricted Project

May 20 2019

cryptoad committed rG52f013021673: [scudo][standalone] Introduce the Primary(s) and LocalCache (authored by cryptoad).
[scudo][standalone] Introduce the Primary(s) and LocalCache
May 20 2019, 7:42 AM
cryptoad committed rL361159: [scudo][standalone] Introduce the Primary(s) and LocalCache.
[scudo][standalone] Introduce the Primary(s) and LocalCache
May 20 2019, 7:37 AM
cryptoad committed rCRT361159: [scudo][standalone] Introduce the Primary(s) and LocalCache.
[scudo][standalone] Introduce the Primary(s) and LocalCache
May 20 2019, 7:37 AM
cryptoad closed D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.
May 20 2019, 7:37 AM · Restricted Project, Restricted Project

May 17 2019

cryptoad updated the diff for D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.

Correcting a typo (meaningul -> meaningful)

May 17 2019, 12:33 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.

Adding a forgotten CHECK as well.

May 17 2019, 12:09 PM · Restricted Project, Restricted Project
cryptoad updated the diff for D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache.

Correcting some code constructs as suggested by Matt:

  • using unique_ptr in tests;
  • accounting for a potential null TransferBatch in refill;
  • other corrections.
May 17 2019, 11:56 AM · Restricted Project, Restricted Project