- User Since
- May 5 2016, 2:57 PM (360 w, 2 d)
Mon, Mar 20
Mon, Mar 6
I like the idea of randomizing the regions' base!
Feb 24 2023
Feb 15 2023
Seems to be EXPECT_EQ(0, LastRequestSize); related. Potential fix would be 0U for both instances.
Jan 27 2023
Jan 17 2023
Jan 12 2023
Jan 11 2023
If you could please change InitRingBuffer & RingBufferSizeInBytes to abide to the LLVM coding standard (https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)
Jan 10 2023
Dec 27 2022
High level question: was this tested with Fuchsia/Linux/Android?
Dec 19 2022
Dec 13 2022
Dec 8 2022
Thanks! Missed one :)
Can we use the LLVM style for this change?
eg: no k* constants, casing for pos, fd etc.
Oct 28 2022
Oct 27 2022
Oct 17 2022
Oct 12 2022
Sep 19 2022
Sep 16 2022
Do we have rough numbers as to how this lowers the "randomness" of the pool of blocks to be chosen for various classes?
Sep 1 2022
While this is true, making the Counts smaller can have structure alignement consequences.
You probably want to make sure that TransferBatch, FreeBatch, PreClass etc all look fine (size multiple of sizeof(uptr) etc). If not the case, you would have to pad.
Other things to keep in consideration: u32 vs u16 in getMaxCachedHint, TransferBatch::get and others (static_cast<u32> might be a giveaway of some integer size inconsitency).
If all works out, that might mean that the SizeClassConfig will have to be adapted to best fit the new sizes.
Jul 8 2022
Jul 7 2022
Jun 1 2022
Jan 14 2022
Nov 16 2021
Oct 11 2021
Oct 8 2021
... and remove local debugging line.
Oct 7 2021
Sep 27 2021
Addressing Mitch's request.
Sep 4 2021
Sep 2 2021
Aug 17 2021
Aug 16 2021
I apologize, I messed up the revert of my other CL and this got reverted by mistake!
Aug 15 2021
Redoing this the way Vitaly suggested.
Aug 13 2021
So this turned out to be a little more complicated for 32-b.
The 'z' format specifier expects a size_t which is defined
as a unsigned int on 32-b Linux platforms, while our
scudo::uptr are defined a unsigned long. So zu wasn't
an appropriate specifier on 32-b platforms for a uptr.
Aug 11 2021
Aug 3 2021
Aug 2 2021
Jul 27 2021
Jul 22 2021
Jul 2 2021
Jul 1 2021
Jun 16 2021
Using using instead of typedef on the newly added ones.
Adding more isAligned DCHECK as Vitaly suggested.
Add stdlib.h to the test for posix_memalign. My builds don't
complain but I assume something will eventually.
Jun 14 2021
Jun 8 2021
Jun 7 2021
I patched it locally and everything passes for me.
Given the current timeline, I am OK with landing it now as is, and improve gradually on it.
I will pick up some of the action items, notably to try and reduce the memory footprint.
Jun 4 2021
Was it the DCHECK issues I fixed with https://reviews.llvm.org/D103716 or something else?