User Details
- User Since
- May 5 2016, 2:57 PM (321 w, 5 d)
Jun 1 2022
Jan 14 2022
Nov 16 2021
Oct 11 2021
Oct 8 2021
... and remove local debugging line.
Oct 7 2021
Sep 27 2021
Addressing Mitch's request.
Sep 4 2021
Thank you!
Sep 2 2021
Aug 17 2021
Aug 16 2021
I apologize, I messed up the revert of my other CL and this got reverted by mistake!
Aug 15 2021
Redoing this the way Vitaly suggested.
Aug 13 2021
So this turned out to be a little more complicated for 32-b.
The 'z' format specifier expects a size_t which is defined
as a unsigned int on 32-b Linux platforms, while our
scudo::uptr are defined a unsigned long. So zu wasn't
an appropriate specifier on 32-b platforms for a uptr.
Aug 11 2021
Aug 3 2021
Aug 2 2021
Jul 27 2021
Jul 22 2021
Jul 2 2021
Jul 1 2021
Jun 16 2021
Using using instead of typedef on the newly added ones.
Adding more isAligned DCHECK as Vitaly suggested.
Add stdlib.h to the test for posix_memalign. My builds don't
complain but I assume something will eventually.
Jun 14 2021
Jun 8 2021
Jun 7 2021
I patched it locally and everything passes for me.
Given the current timeline, I am OK with landing it now as is, and improve gradually on it.
I will pick up some of the action items, notably to try and reduce the memory footprint.
Jun 4 2021
Was it the DCHECK issues I fixed with https://reviews.llvm.org/D103716 or something else?
Jun 3 2021
Switching 2 lines around.
Change type in vector test.
and I forgot to copy over the test file.
Remove InitialSize as suggested.
Remove stray comment.
Based on feedback, remove for now the CanGrow aspect of the vector.
Corrected, with a test now.
Correcting a couple of ScopedString constructors.
Thank you Daniel, this looks like a good start!
I'll work on my side on reducing some of the memory footprint of some structures and whatnot (scoped strings come to mind).
As discussed, we can re-introduce the use-separate-class-for-batches distinction for Trusty, which can be a large win to get rid of a class size.
I still think the Primary32 might be better suited here, but we'll follow up.
May 27 2021
sanitizer-x86_64-linux https://lab.llvm.org/buildbot/#/builders/37/builds/4244 FAIL: ScudoStandalone-x86_64 :: preinit.c (772 of 856)
ppc64be-clang-test https://lab.llvm.org/buildbot#builders/52/builds/7794 TEST 'ScudoStandalone-powerpc64 :: preinit.c' FAILED
among others
May 26 2021
I saw some bots failure for preinit.c:
FAIL: ScudoStandalone-i386 :: preinit.c (768 of 856) ******************** TEST 'ScudoStandalone-i386 :: preinit.c' FAILED ******************** Script: -- : 'RUN: at line 1'; /b/sanitizer-x86_64-linux/build/clang_build/./bin/clang -m32 -pthread -fPIE -pie -O0 -UNDEBUG -Wl,--gc-sections -resource-dir=/b/sanitizer-x86_64-linux/build/clang_build/./lib/clang/13.0.0/lib/linux/../../ -fsanitize=scudo /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/scudo/standalone/preinit.c -o /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/scudo/standalone/I386LinuxConfig/Output/preinit.c.tmp : 'RUN: at line 2'; /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/scudo/standalone/I386LinuxConfig/Output/preinit.c.tmp 2>&1 -- Exit Code: 139
Docs have been udpated some time ago with new build instructions to reflect the migration to the standalone version. Abandoning this.
I think Fuchsia doesn't need COMPILER_RT_HAS_AUXV since it's only used in Linux parts.
May 25 2021
Remove HybridMutex::init, remove stray ;.