- User Since
- May 5 2016, 2:57 PM (194 w, 5 d)
Passing ReleaseToOsInterval from init to initLinkerInitialized in
Marking a parameter unused.
Wed, Jan 22
Tue, Jan 21
Commenting getNumberOfCPUs to indicate failure value in common.h,
moving sched_getaffinity comment in linux.cpp in body of function.
Mon, Jan 20
Thu, Jan 16
LGTM, Thanks for all the work Peter!
I think this looks good. I think this might not be Fuchsia compatible and could probably use some #if SCUDO_LINUX or ANDROID or top of the __aarch64__ checks.
Fuchsia will want memory tagging support at some point, I 'll check the patch on the platform once the inconsistencies I saw are addressed.
Tue, Jan 14
Disable GWP-ASan, FIXME added.
Mon, Jan 13
Adding a newline at end of file, to try and trigger presubmit.
Re-enable GWP-ASan, add a comment about the potentially failing test.
We will skip it if this occurs upstream.
Remove the NOINLINE for enable & disable, they were used to debug
I apologize for being pushy, but could I get a yay or nay on this to unblock Android?
Fri, Jan 10
Applying simplification suggested by eugenis@: malloc_disable just
calls disable, same for enable.
Adding a disable()/fork()/enable() test.
Thu, Jan 9
Disable GWP-ASan for now.
Wrong version of the makefiles.
Correct several inconsistencies wrt locking orders.
Adding Quarantine & ByteMap to the things we disable/enable.
Abandoning this one, this will come back in another form.
Wed, Jan 8
I realized that this is now no longer correct as the atfork handler is only installed in a disable.
Submitting this new design for consideration. I am working on adding
some tests but at least the code idea can get some feedback.
Updating test to exercise both disable and no-disable pre-fork.
Added an _exit in fork child.
Tue, Jan 7
The wrong version was uploaded.
Dec 20 2019
Correcting comment typo.
New proposal as per Peter's suggestion: include stdint.h in
platform.h and check for __BIONIC__.
Dec 19 2019
Add a comment for disable() with a TODO to improve the behavior.
Use an atomic_u8 for Disabled in the Exclusive Registry.
This should ensure that changes to the variable are visible to the
threads in a somewhat timely manner.
Dec 10 2019
Dec 9 2019
What's the current plan for testing? (Currently I have only enabled the standalone on Linux x86/64 for upstream)
Dec 6 2019
Could you please put a comment somewhere on how to use the benchmark?
Dec 5 2019
Dec 3 2019
Dec 2 2019
Adding a comment saying that a corrupted chunk won't be reported
as owned (well technically it might be "owned"), but that it's WAI.
Adding a log for the new static_assert.
Nov 29 2019
Nov 27 2019
Can this be abandoned? Looks stale.