- User Since
- May 5 2016, 2:57 PM (97 w, 2 d)
Fri, Mar 16
Adding a missed tsan & sanitizer_common tests.
Adding Symbolizer to esan & dfsan.
Here is a general idea for a split Coverage & Symbolizer/StackTraces: https://reviews.llvm.org/D44578
Still some minor changes to do for the less common sanitizers but tests for the main ones pass (on Linux).
With the patch as is, it fails with gcc/clang on Linux with: /usr/bin/ld: cannot find -lgcc_s
Should those new options be Fuchsia only?
Thu, Mar 15
On Linux with -Wl,-nostdlib++, this doesn't compile as is with some complains about -lgcc_s not being found (from memory, not in front of my desktop now).
I figured the minimal build would be solution, I can dig into this tomorrow.
Wed, Mar 14
So it looks like it's going to be a bit more complicated.
There is C++ dependencies in UBSan (dynamic_cast and whatnot) and we pull in RTUBsan.
The base link flags are SANITIZER_COMMON_LINK_LIBS, SANITIZER_CXX_ABI_LIBRARY, which will pull in a C++ library.
As far as I understand, you guys don't care about a -fsanitize=scudo,undefine yet, so the way to go is a UBsan free Scudo (scudo-minimal or something).
Unless I'm misunderstanding the point.
So as is this gets me clang-6.0: error: argument unused during compilation: '-nostdlib++' [-Werror,-Wunused-command-line-argument].
I duplicated SCUDO_CFLAGS to SCUDO_CXXFLAGS and added -nostdlib++ there, replacing the flags for the CXX static library & the .so and this works, but I am not sure it achieves what you want.
Tue, Mar 13
Mon, Mar 12
Fri, Mar 9
Couple of additional changes from the original patch.
Added comment with chunk layout.
Moved the LargeChunkHeader inside the LargeChunk namespace as Header,
because it makes more sense to me.
Thu, Mar 8
Addressing the other comment.
Addressing 1 comment.
Using @alekseyshl's much simpler solution.
Added a couple of DCHECKs for good measure.
Also forgotten in the initial description: I changed 2 CHECKs to DCHECKs
as they are either called from functions that perform the CHECK or from for
loops that bound the value properly.
Wed, Mar 7
Tue, Mar 6
Remove brackets from 1-liners (modulo the 80 character wrap).
Mon, Mar 5
Fri, Mar 2
Thu, Mar 1
Reordering a couple of lines, adding an UNLIKELY.
Tue, Feb 27
Rebasing & support for more tests.
Mon, Feb 26
Fri, Feb 16
Feb 13 2018
Feb 12 2018
Feb 9 2018
Replacing a c->class_size by size.
Feb 8 2018
Feb 7 2018
Replace TSAN_STRING_SETJMP__ (forgotten on the first go).
Removed an extraneous comment.
Introduce a SANITIZER_STRINGIFY macro in sanitizer_internal_defs.h, used
by the various flags parsers (ASan, Scudo, XRay).
Feb 6 2018
@rnk, could you please take a look? Thanks!
Feb 5 2018
Unless I am missing something, I think it's already in with https://reviews.llvm.org/D42617 (https://github.com/llvm-mirror/compiler-rt/blob/master/lib/sanitizer_common/sanitizer_fuchsia.cc#L52)
Hey @kubamracek, checking in to see if you are planning on committing this, we could use the functions. Thanks!