User Details
- User Since
- May 5 2016, 2:57 PM (245 w, 4 d)
Fri, Jan 15
Is there some test that can be added that would find a regression?
Mon, Jan 11
Sat, Jan 9
Fri, Jan 8
It all seems to be working.
I'll have to work on the EXPECT_DEATH aspect as a follow up.
Compiles and tests pass on Fuchsia.
The changes themselves look good to me.
Thu, Jan 7
There seems to be something wrong on Fuchsia with it, regular processes are crashing. Looking into this.
Wed, Jan 6
Is this still WIP like the title says?
Roland committed his change for the issue, this is no longer needed.
Tue, Jan 5
Let's go with yours, better comments/whitespaces.
Thanks Mitch! Looks reasonable to me.
Dec 18 2020
Dec 17 2020
Dec 14 2020
... and remove the unused field in the 32-bit primary. Sorry.
Correct copy/paste error in the 32-bit primary (!= => ==)
Dec 11 2020
Dec 10 2020
Dec 9 2020
Anything I can help address to move forward?
Dec 4 2020
Correct > to >=.
Dec 3 2020
Dec 2 2020
Do you need me to commit this?
Dec 1 2020
Updating the CL with another proposed fix: reseting the TLS data in
the uninit function called by the tests.
This is an arc fail on my side
Thank you, good catch!!
Nov 23 2020
Nov 18 2020
Nov 16 2020
Nov 14 2020
Addressing review comments.
Nov 12 2020
Ping please!
Nov 10 2020
Further simplify the release function.
Nov 9 2020
Nov 6 2020
Nov 5 2020
Nov 4 2020
And another, sorry for the back & forth, getting numbers as they come.
Restoring a couple of UNLIKELY in the loops.
Nov 3 2020
Changing some lines around.
Re-add a comment that got removed.
Nov 2 2020
Addressing Mitch's request.
Oct 31 2020
Oct 30 2020
Addressing Roland's comments.
Couple of small fixes.
Oct 29 2020
Addressing review comments.
Oct 28 2020
Thank you for all your work!
IIRC everything was working except as you point out some of the very Unixy tests.
Is your build creating a clang_rt.scudo_cxx library that also needs to be link as well? The C++ specific interceptors usually end up in a separate library that is not linked into the straight C programs, which is the most likely culprit for not having new/delete be intercepted.
Adding stdint.h to try and quell some clang-tidy warnings.
Address review comments.
Oct 26 2020
clang-format a file that was missed.
Addressing review comments:
- tried to strike a middle ground between name suggestions, settled on: `void *reserveGuardedPool(size_t Size);
void allocateInGuardedPool(void *Ptr, size_t Size) const;
void deallocateInGuardedPool(void *Ptr, size_t Size) const;
void unreserveGuardedPool();`
- added comments and clarifications about API contracts
- used anonymous namespace instead of static
Oct 22 2020
Correcting a potential conversion warning.
Addressing review comments.
Oct 21 2020
- Restoring the old constants because some test failed with mine.