Page MenuHomePhabricator

cryptoad (Kostya Kortchinsky)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2016, 2:57 PM (321 w, 5 d)

Recent Activity

Jun 1 2022

cryptoad added reviewers for D126752: Add Soft/Hard RSS Limits to Scudo Standalone: vitalybuka, eugenis.
Jun 1 2022, 9:32 AM · Restricted Project, Restricted Project

Jan 14 2022

cryptoad committed rG636a1cfdcdb8: [scudo] Make Scudo compile for C++20 (authored by cryptoad).
[scudo] Make Scudo compile for C++20
Jan 14 2022, 2:54 PM
cryptoad closed D117359: [scudo] Make Scudo compile for C++20.
Jan 14 2022, 2:53 PM · Restricted Project
cryptoad requested review of D117359: [scudo] Make Scudo compile for C++20.
Jan 14 2022, 1:52 PM · Restricted Project

Nov 16 2021

cryptoad accepted D113951: [scudo] Handle mallinfo2.
Nov 16 2021, 1:34 PM · Restricted Project
cryptoad added inline comments to D113951: [scudo] Handle mallinfo2.
Nov 16 2021, 8:31 AM · Restricted Project

Oct 11 2021

cryptoad committed rG56a9effc427b: [scudo] Skip AllocAfterFork test on machines with low max_map_count (authored by cryptoad).
[scudo] Skip AllocAfterFork test on machines with low max_map_count
Oct 11 2021, 10:34 AM
cryptoad closed D111465: [scudo] Skip AllocAfterFork test on machines with low max_map_count.
Oct 11 2021, 10:33 AM · Restricted Project

Oct 8 2021

cryptoad updated the diff for D111465: [scudo] Skip AllocAfterFork test on machines with low max_map_count.

... and remove local debugging line.

Oct 8 2021, 2:16 PM · Restricted Project
cryptoad requested review of D111465: [scudo] Skip AllocAfterFork test on machines with low max_map_count.
Oct 8 2021, 2:16 PM · Restricted Project

Oct 7 2021

cryptoad committed rG6727832c324c: [scudo] Reduce the scope of AllocAfterFork (authored by cryptoad).
[scudo] Reduce the scope of AllocAfterFork
Oct 7 2021, 2:02 PM
cryptoad closed D111342: [scudo] Reduce the scope of AllocAfterFork.
Oct 7 2021, 2:02 PM · Restricted Project
cryptoad requested review of D111342: [scudo] Reduce the scope of AllocAfterFork.
Oct 7 2021, 12:30 PM · Restricted Project

Sep 27 2021

cryptoad committed rG04f5913395de: [gwp-asan] Initialize AllocatorVersionMagic at runtime (authored by cryptoad).
[gwp-asan] Initialize AllocatorVersionMagic at runtime
Sep 27 2021, 1:51 PM
cryptoad closed D110575: [gwp-asan] Initialize AllocatorVersionMagic at runtime.
Sep 27 2021, 1:50 PM · Restricted Project
cryptoad updated the diff for D110575: [gwp-asan] Initialize AllocatorVersionMagic at runtime.

Addressing Mitch's request.

Sep 27 2021, 1:43 PM · Restricted Project
cryptoad requested review of D110575: [gwp-asan] Initialize AllocatorVersionMagic at runtime.
Sep 27 2021, 12:32 PM · Restricted Project

Sep 4 2021

cryptoad accepted D109196: scudo: Only add no-omit-frame-pointer flags when the compiler supports them.

Thank you!

Sep 4 2021, 9:41 AM · Restricted Project

Sep 2 2021

cryptoad added inline comments to D109196: scudo: Only add no-omit-frame-pointer flags when the compiler supports them.
Sep 2 2021, 3:17 PM · Restricted Project

Aug 17 2021

cryptoad committed rG5009be2f09ae: [scudo] Fix format string specifiers (authored by cryptoad).
[scudo] Fix format string specifiers
Aug 17 2021, 8:38 AM
cryptoad closed D108168: [scudo] Fix format string specifiers.
Aug 17 2021, 8:38 AM · Restricted Project

Aug 16 2021

cryptoad requested review of D108168: [scudo] Fix format string specifiers.
Aug 16 2021, 3:24 PM · Restricted Project
cryptoad committed rGb2aaafb8377a: [scudo] Use stdint types for internal types (redo) (authored by cryptoad).
[scudo] Use stdint types for internal types (redo)
Aug 16 2021, 2:47 PM
cryptoad closed D108152: [scudo] Use stdint types for internal types (redo).
Aug 16 2021, 2:46 PM · Restricted Project
cryptoad added a comment to rG45138f788c9b: [sanitizer] Define 32bit uptr as uint.

Are you looking at resolving this build failure? Or maybe @cryptoad is?

Aug 16 2021, 1:13 PM
cryptoad requested review of D108152: [scudo] Use stdint types for internal types (redo).
Aug 16 2021, 11:59 AM · Restricted Project
cryptoad added a comment to rGb7425e956be6: [NFC] Fix typos.

I apologize, I messed up the revert of my other CL and this got reverted by mistake!

Aug 16 2021, 11:16 AM
cryptoad added a reverting change for rG5fc841d8a278: [scudo] Use stdint types for internal scudo types: rG427c9aa7c440: Revert "[scudo] Use stdint types for internal scudo types".
Aug 16 2021, 11:14 AM
cryptoad committed rG427c9aa7c440: Revert "[scudo] Use stdint types for internal scudo types" (authored by cryptoad).
Revert "[scudo] Use stdint types for internal scudo types"
Aug 16 2021, 11:14 AM
cryptoad added a reverting change for rGb7425e956be6: [NFC] Fix typos: rG80ed75e7fb45: Revert "[NFC] Fix typos".
Aug 16 2021, 11:14 AM
cryptoad committed rG80ed75e7fb45: Revert "[NFC] Fix typos" (authored by cryptoad).
Revert "[NFC] Fix typos"
Aug 16 2021, 11:14 AM
cryptoad added a reverting change for D108089: [scudo] Use stdint types for internal scudo types: rG427c9aa7c440: Revert "[scudo] Use stdint types for internal scudo types".
Aug 16 2021, 11:14 AM · Restricted Project
cryptoad committed rG5fc841d8a278: [scudo] Use stdint types for internal scudo types (authored by cryptoad).
[scudo] Use stdint types for internal scudo types
Aug 16 2021, 10:53 AM
cryptoad closed D108089: [scudo] Use stdint types for internal scudo types.
Aug 16 2021, 10:53 AM · Restricted Project
cryptoad added a comment to D108089: [scudo] Use stdint types for internal scudo types.

Side note - it'd be nice at some point if we can LSC all the use-of-custom-types away, any reason to keep them?

Aug 16 2021, 9:04 AM · Restricted Project

Aug 15 2021

cryptoad requested review of D108089: [scudo] Use stdint types for internal scudo types.
Aug 15 2021, 9:10 AM · Restricted Project
cryptoad abandoned D108044: [scudo] Correct format string specifiers.

Redoing this the way Vitaly suggested.

Aug 15 2021, 7:57 AM · Restricted Project

Aug 13 2021

cryptoad updated the diff for D108044: [scudo] Correct format string specifiers.

So this turned out to be a little more complicated for 32-b.
The 'z' format specifier expects a size_t which is defined
as a unsigned int on 32-b Linux platforms, while our
scudo::uptr are defined a unsigned long. So zu wasn't
an appropriate specifier on 32-b platforms for a uptr.

Aug 13 2021, 10:26 AM · Restricted Project
cryptoad planned changes to D108044: [scudo] Correct format string specifiers.
Aug 13 2021, 9:04 AM · Restricted Project
cryptoad requested review of D108044: [scudo] Correct format string specifiers.
Aug 13 2021, 8:51 AM · Restricted Project

Aug 11 2021

cryptoad accepted D107909: [scudo] Add GWP-ASan state/metadata pointer proxies..
Aug 11 2021, 9:20 AM · Restricted Project

Aug 3 2021

cryptoad committed rG23a94af44939: [scudo] Make Vector() constexpr (authored by cryptoad).
[scudo] Make Vector() constexpr
Aug 3 2021, 8:26 AM
cryptoad closed D107308: [scudo] Make Vector() constexpr.
Aug 3 2021, 8:25 AM · Restricted Project

Aug 2 2021

cryptoad requested review of D107308: [scudo] Make Vector() constexpr.
Aug 2 2021, 1:40 PM · Restricted Project

Jul 27 2021

cryptoad added inline comments to D106919: [libc] add integration tests for scudo in libc.
Jul 27 2021, 2:53 PM · Restricted Project, Restricted Project

Jul 22 2021

cryptoad added a comment to D106502: [libc] add option to use SCUDO as the allocator.

@cryptoad - This adds a build level dependency across projects. Do you see any problems which this arrangement? We will also start testing this arrangement via integration tests on the LLVM libc buildbot workers.

Jul 22 2021, 12:30 AM · Restricted Project

Jul 2 2021

cryptoad accepted D105371: Name all DEATH tests using 'DeathTest' suffix..
Jul 2 2021, 1:42 PM · Restricted Project

Jul 1 2021

cryptoad accepted D105266: [scudo] Remove false DCHECK.
Jul 1 2021, 10:41 AM · Restricted Project

Jun 16 2021

cryptoad committed rG8b062b616062: [scudo] Ensure proper allocator alignment in TSD test (authored by cryptoad).
[scudo] Ensure proper allocator alignment in TSD test
Jun 16 2021, 2:22 PM
cryptoad closed D104402: [scudo] Ensure proper allocator alignment in TSD test.
Jun 16 2021, 2:22 PM · Restricted Project
cryptoad updated the diff for D104402: [scudo] Ensure proper allocator alignment in TSD test.

Using using instead of typedef on the newly added ones.

Jun 16 2021, 2:18 PM · Restricted Project
cryptoad updated the diff for D104402: [scudo] Ensure proper allocator alignment in TSD test.

Adding more isAligned DCHECK as Vitaly suggested.

Jun 16 2021, 2:07 PM · Restricted Project
cryptoad added inline comments to D104402: [scudo] Ensure proper allocator alignment in TSD test.
Jun 16 2021, 1:50 PM · Restricted Project
cryptoad updated the diff for D104402: [scudo] Ensure proper allocator alignment in TSD test.

Add stdlib.h to the test for posix_memalign. My builds don't
complain but I assume something will eventually.

Jun 16 2021, 10:56 AM · Restricted Project
cryptoad added a comment to D103119: [scudo] Get rid of initLinkerInitialized.

Hi,

this is due to a misaligned data access, in Thumb the code generated for unmapTestOnly
contains a Vector Store instruction vst1.64 {d16-d17}, [r0, :128] which needs a 16-bytes
alignement, but the adress of TSDs (which is in r0) is not.

Jun 16 2021, 10:55 AM · Restricted Project
cryptoad requested review of D104402: [scudo] Ensure proper allocator alignment in TSD test.
Jun 16 2021, 10:52 AM · Restricted Project

Jun 14 2021

cryptoad added a comment to D103119: [scudo] Get rid of initLinkerInitialized.

Hi,

This change introduced a regression on ARMv7 Thumb bots which wasn't noticed due to other issues.

logs can be seen here: https://lab.llvm.org/buildbot/#/builders/26/builds/2251

The 3 tests fail with a bus error raised from tsd_shared.h line 49

Jun 14 2021, 11:24 AM · Restricted Project

Jun 8 2021

cryptoad committed rG2551053e8d8d: [scudo] Add Scudo support for Trusty OS (authored by danieljm).
[scudo] Add Scudo support for Trusty OS
Jun 8 2021, 2:03 PM
cryptoad closed D103578: [scudo] Add Scudo support for Trusty OS.
Jun 8 2021, 2:02 PM · Restricted Project

Jun 7 2021

cryptoad added inline comments to D103578: [scudo] Add Scudo support for Trusty OS.
Jun 7 2021, 1:13 PM · Restricted Project
cryptoad accepted D103578: [scudo] Add Scudo support for Trusty OS.

I patched it locally and everything passes for me.
Given the current timeline, I am OK with landing it now as is, and improve gradually on it.
I will pick up some of the action items, notably to try and reduce the memory footprint.

Jun 7 2021, 11:10 AM · Restricted Project

Jun 4 2021

cryptoad accepted D103718: [Scudo] Improve ScopedString constructor.
Jun 4 2021, 6:08 PM · Restricted Project
cryptoad added a comment to D103718: [Scudo] Improve ScopedString constructor.

Was it the DCHECK issues I fixed with https://reviews.llvm.org/D103716 or something else?

Jun 4 2021, 4:26 PM · Restricted Project
cryptoad accepted D103725: [scudo] Remove ScopedString::Length.
Jun 4 2021, 4:07 PM · Restricted Project
cryptoad added inline comments to D103721: [NFC][scudo] Make formatString return uptr.
Jun 4 2021, 3:19 PM · Restricted Project
cryptoad added a comment to D103641: [scudo] Rework Vector/String.

This looks like it broke the sanitizer-x86_64-linux-qemu.
https://lab.llvm.org/buildbot/#/builders/169/builds/501

Found the issue, testing the fix.

Jun 4 2021, 1:42 PM · Restricted Project
cryptoad committed rG5019b0a56588: [scudo] Fix String DCHECK (authored by cryptoad).
[scudo] Fix String DCHECK
Jun 4 2021, 1:42 PM
cryptoad closed D103716: [scudo] Fix String DCHECK.
Jun 4 2021, 1:42 PM · Restricted Project
cryptoad requested review of D103716: [scudo] Fix String DCHECK.
Jun 4 2021, 1:38 PM · Restricted Project
cryptoad added a comment to D103641: [scudo] Rework Vector/String.

This looks like it broke the sanitizer-x86_64-linux-qemu.
https://lab.llvm.org/buildbot/#/builders/169/builds/501

Jun 4 2021, 1:21 PM · Restricted Project
cryptoad added a comment to rG868317b3fd76: [scudo] Rework Vector/String.

This looks like it broke the sanitizer-x86_64-linux-qemu.
https://lab.llvm.org/buildbot/#/builders/169/builds/501

Jun 4 2021, 12:56 PM
cryptoad added inline comments to D103578: [scudo] Add Scudo support for Trusty OS.
Jun 4 2021, 8:00 AM · Restricted Project
cryptoad added inline comments to D103578: [scudo] Add Scudo support for Trusty OS.
Jun 4 2021, 7:57 AM · Restricted Project

Jun 3 2021

cryptoad committed rG868317b3fd76: [scudo] Rework Vector/String (authored by cryptoad).
[scudo] Rework Vector/String
Jun 3 2021, 6:13 PM
cryptoad closed D103641: [scudo] Rework Vector/String.
Jun 3 2021, 6:13 PM · Restricted Project
cryptoad added inline comments to D103641: [scudo] Rework Vector/String.
Jun 3 2021, 3:03 PM · Restricted Project
cryptoad updated the diff for D103641: [scudo] Rework Vector/String.

Switching 2 lines around.

Jun 3 2021, 3:02 PM · Restricted Project
cryptoad updated the diff for D103641: [scudo] Rework Vector/String.

Change type in vector test.

Jun 3 2021, 2:46 PM · Restricted Project
cryptoad updated the diff for D103641: [scudo] Rework Vector/String.

and I forgot to copy over the test file.

Jun 3 2021, 2:19 PM · Restricted Project
cryptoad updated the diff for D103641: [scudo] Rework Vector/String.

Remove InitialSize as suggested.

Jun 3 2021, 2:17 PM · Restricted Project
cryptoad updated the diff for D103641: [scudo] Rework Vector/String.

Remove stray comment.

Jun 3 2021, 2:11 PM · Restricted Project
cryptoad updated the diff for D103641: [scudo] Rework Vector/String.

Based on feedback, remove for now the CanGrow aspect of the vector.

Jun 3 2021, 2:07 PM · Restricted Project
cryptoad added a comment to D103641: [scudo] Rework Vector/String.

CanGrow templated parameter that for now is
always true but would be set to false on Trusty.

Are we seeing OOMs on Trusty due to ScopedString? I had a quick look and it seemed like there's no non-ephemeral buffers (and really, this shouldn't be called very often at all), and it concerns me a little that push_back can silently fail on a ScopedErrorReport and truncate the text and it seems hard to test "all failure conditions log successfully".

Jun 3 2021, 1:55 PM · Restricted Project
cryptoad updated the diff for D103641: [scudo] Rework Vector/String.

Corrected, with a test now.

Jun 3 2021, 12:31 PM · Restricted Project
cryptoad updated the diff for D103641: [scudo] Rework Vector/String.

Correcting a couple of ScopedString constructors.

Jun 3 2021, 12:13 PM · Restricted Project
cryptoad requested review of D103641: [scudo] Rework Vector/String.
Jun 3 2021, 12:11 PM · Restricted Project
cryptoad added a comment to D103578: [scudo] Add Scudo support for Trusty OS.

Thank you Daniel, this looks like a good start!
I'll work on my side on reducing some of the memory footprint of some structures and whatnot (scoped strings come to mind).
As discussed, we can re-introduce the use-separate-class-for-batches distinction for Trusty, which can be a large win to get rid of a class size.
I still think the Primary32 might be better suited here, but we'll follow up.

Jun 3 2021, 7:56 AM · Restricted Project

May 27 2021

cryptoad added a comment to D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests..

sanitizer-x86_64-linux https://lab.llvm.org/buildbot/#/builders/37/builds/4244 FAIL: ScudoStandalone-x86_64 :: preinit.c (772 of 856)
ppc64be-clang-test https://lab.llvm.org/buildbot#builders/52/builds/7794 TEST 'ScudoStandalone-powerpc64 :: preinit.c' FAILED
among others

May 27 2021, 12:28 PM · Restricted Project, Restricted Project

May 26 2021

cryptoad added a comment to D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests..

I saw some bots failure for preinit.c:

FAIL: ScudoStandalone-i386 :: preinit.c (768 of 856)
******************** TEST 'ScudoStandalone-i386 :: preinit.c' FAILED ********************
Script:
--
: 'RUN: at line 1';      /b/sanitizer-x86_64-linux/build/clang_build/./bin/clang   -m32  -pthread -fPIE -pie -O0 -UNDEBUG -Wl,--gc-sections -resource-dir=/b/sanitizer-x86_64-linux/build/clang_build/./lib/clang/13.0.0/lib/linux/../../ -fsanitize=scudo /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/scudo/standalone/preinit.c -o /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/scudo/standalone/I386LinuxConfig/Output/preinit.c.tmp
: 'RUN: at line 2';    /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/scudo/standalone/I386LinuxConfig/Output/preinit.c.tmp 2>&1
--
Exit Code: 139
May 26 2021, 4:08 PM · Restricted Project, Restricted Project
cryptoad accepted D103200: [scudo] Build scudo_standalone on Android and Fuchsia..
May 26 2021, 2:56 PM · Restricted Project
cryptoad abandoned D70860: [docs] Fixed incorrect build instructions for Scudo.

Docs have been udpated some time ago with new build instructions to reflect the migration to the standalone version. Abandoning this.

May 26 2021, 2:04 PM · Restricted Project
cryptoad commandeered D70860: [docs] Fixed incorrect build instructions for Scudo.
May 26 2021, 2:04 PM · Restricted Project
cryptoad added a comment to D103200: [scudo] Build scudo_standalone on Android and Fuchsia..

I think Fuchsia doesn't need COMPILER_RT_HAS_AUXV since it's only used in Linux parts.

May 26 2021, 1:03 PM · Restricted Project
cryptoad committed rGa45877eea8c4: [scudo] Get rid of initLinkerInitialized (authored by cryptoad).
[scudo] Get rid of initLinkerInitialized
May 26 2021, 9:54 AM
cryptoad closed D103119: [scudo] Get rid of initLinkerInitialized.
May 26 2021, 9:54 AM · Restricted Project

May 25 2021

cryptoad updated the diff for D103119: [scudo] Get rid of initLinkerInitialized.

Remove HybridMutex::init, remove stray ;.

May 25 2021, 3:34 PM · Restricted Project
cryptoad accepted D103122: [NFC][SCUDO] Fix unittest for -gtest_repeat=10.
May 25 2021, 3:29 PM · Restricted Project
cryptoad requested review of D103119: [scudo] Get rid of initLinkerInitialized.
May 25 2021, 3:01 PM · Restricted Project
cryptoad committed rG1872283457fc: [scudo] Rework dieOnMapUnmapError (authored by cryptoad).
[scudo] Rework dieOnMapUnmapError
May 25 2021, 8:28 AM
cryptoad closed D103034: [scudo] Rework dieOnMapUnmapError.
May 25 2021, 8:28 AM · Restricted Project