Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

cryptoad (Kostya Kortchinsky)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2016, 2:57 PM (386 w, 6 d)

Recent Activity

Jun 22 2023

cryptoad added inline comments to D153480: [scudo] Fix data leak in wrappers_c_test.cpp.
Jun 22 2023, 8:34 AM · Restricted Project, Restricted Project

Jun 15 2023

cryptoad added a comment to D152985: [scudo] Add extra information when a header is corrupted..

To be fair, at this point, the process should be dead and the Cookie should no longer be relevant, but from a security perspective, I would be warry about echo'ing back the expected checksum.
I understand the rationale behind, but I could think about some circumstances (forked process, VM snapshots, etc), where that information could potentially be reused to craft a correct header.
It obviously would require the attacker to get their hands on the logs first.

Jun 15 2023, 8:06 AM · Restricted Project, Restricted Project

Jun 8 2023

cryptoad added inline comments to D149140: [scudo] Finer lock granularity in Region of SizeClassAllocator64.
Jun 8 2023, 10:51 AM · Restricted Project, Restricted Project

Mar 20 2023

cryptoad accepted D146454: [scudo] Manage pages with MemMap in Secondary Allocator.
Mar 20 2023, 2:39 PM · Restricted Project, Restricted Project

Mar 6 2023

cryptoad accepted D145427: [scudo] Reduce the times of holding MapAllocatorCache::Mutex (NFC).
Mar 6 2023, 5:23 PM · Restricted Project, Restricted Project
cryptoad accepted D145407: [scudo] Shuffle the regions.

I like the idea of randomizing the regions' base!

Mar 6 2023, 11:26 AM · Restricted Project, Restricted Project

Feb 24 2023

cryptoad added inline comments to D142658: [scudo] Improve the uses of roundUpTo/roundDownTo/isAligned.
Feb 24 2023, 10:30 AM · Restricted Project, Restricted Project

Feb 15 2023

cryptoad accepted D144121: [scudo] Fix inconsistent signed/unsigned comparison.
Feb 15 2023, 10:33 AM · Restricted Project, Restricted Project
cryptoad added a comment to D141407: [scudo] Call __scudo_deallocate_hook on reallocations..

Seems to be EXPECT_EQ(0, LastRequestSize); related. Potential fix would be 0U for both instances.

Feb 15 2023, 10:23 AM · Restricted Project, Restricted Project

Jan 27 2023

cryptoad accepted D136308: [docs] Update compiler-rt/CODE_OWNERS.TXT.
Jan 27 2023, 11:53 AM · Restricted Project, Restricted Project
cryptoad accepted D142658: [scudo] Improve the uses of roundUpTo/roundDownTo/isAligned.
Jan 27 2023, 8:34 AM · Restricted Project, Restricted Project

Jan 17 2023

cryptoad added inline comments to D141955: [scudo] Call getStats when the region is exhausted.
Jan 17 2023, 12:13 PM · Restricted Project, Restricted Project

Jan 12 2023

cryptoad added inline comments to D141407: [scudo] Call __scudo_deallocate_hook on reallocations..
Jan 12 2023, 9:33 AM · Restricted Project, Restricted Project

Jan 11 2023

cryptoad added a comment to D140932: Dynamically allocate scudo allocation buffer..

If you could please change InitRingBuffer & RingBufferSizeInBytes to abide to the LLVM coding standard (https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)

Jan 11 2023, 12:58 PM · Restricted Project, Restricted Project

Jan 10 2023

cryptoad added inline comments to D141407: [scudo] Call __scudo_deallocate_hook on reallocations..
Jan 10 2023, 12:35 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D141407: [scudo] Call __scudo_deallocate_hook on reallocations..
Jan 10 2023, 11:53 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D141407: [scudo] Call __scudo_deallocate_hook on reallocations..
Jan 10 2023, 11:16 AM · Restricted Project, Restricted Project

Dec 27 2022

cryptoad added a comment to D140706: [scudo] Add the thread-safety annotations.

High level question: was this tested with Fuchsia/Linux/Android?

Dec 27 2022, 3:34 PM · Restricted Project, Restricted Project

Dec 19 2022

cryptoad added inline comments to D140320: [scudo][standalone] Precommit pages.
Dec 19 2022, 1:13 PM · Restricted Project, Restricted Project
cryptoad added inline comments to D140320: [scudo][standalone] Precommit pages.
Dec 19 2022, 10:42 AM · Restricted Project, Restricted Project

Dec 13 2022

cryptoad added inline comments to D139897: [scudo][fuchsia] Precommit pages when going beyond static buffer size.
Dec 13 2022, 7:49 AM · Restricted Project, Restricted Project

Dec 8 2022

cryptoad accepted D139430: scudo-standalone: Add GetRSS method on Linux.

Thanks! Missed one :)

Dec 8 2022, 9:03 AM · Restricted Project, Restricted Project
cryptoad added a comment to D139430: scudo-standalone: Add GetRSS method on Linux.

Can we use the LLVM style for this change?
eg: no k* constants, casing for pos, fd etc.

Dec 8 2022, 8:22 AM · Restricted Project, Restricted Project

Oct 28 2022

cryptoad accepted D136898: [scudo] Fix the calculating of memory group usage.
Oct 28 2022, 12:13 PM · Restricted Project, Restricted Project

Oct 27 2022

cryptoad added inline comments to D136898: [scudo] Fix the calculating of memory group usage.
Oct 27 2022, 5:05 PM · Restricted Project, Restricted Project
cryptoad accepted D136873: [scudo] Lazy initialize the PageMap while page releasing.
Oct 27 2022, 2:41 PM · Restricted Project, Restricted Project

Oct 17 2022

cryptoad accepted D136025: [scudo] Change region size from 1 MB to 2 MB in tests.
Oct 17 2022, 10:24 AM · Restricted Project, Restricted Project

Oct 12 2022

cryptoad accepted D134226: [scudo] Support partial page releasing.
Oct 12 2022, 10:54 AM · Restricted Project, Restricted Project
cryptoad accepted D133897: [scudo] Manage free blocks in BatchGroup..
Oct 12 2022, 10:53 AM · Restricted Project, Restricted Project
cryptoad accepted D133895: [scudo] Add PageReleaseContext to convey page usage status..
Oct 12 2022, 10:53 AM · Restricted Project, Restricted Project
cryptoad accepted D133145: Use u16 to store Count/MaxCount.
Oct 12 2022, 10:47 AM · Restricted Project, Restricted Project

Sep 19 2022

cryptoad added inline comments to D133897: [scudo] Manage free blocks in BatchGroup..
Sep 19 2022, 11:39 AM · Restricted Project, Restricted Project

Sep 16 2022

cryptoad added a comment to D133897: [scudo] Manage free blocks in BatchGroup..

Do we have rough numbers as to how this lowers the "randomness" of the pool of blocks to be chosen for various classes?

Sep 16 2022, 12:03 PM · Restricted Project, Restricted Project
cryptoad added reviewers for D133145: Use u16 to store Count/MaxCount: vitalybuka, mcgrathr.
Sep 16 2022, 11:51 AM · Restricted Project, Restricted Project
cryptoad added inline comments to D133895: [scudo] Add PageReleaseContext to convey page usage status..
Sep 16 2022, 11:48 AM · Restricted Project, Restricted Project
cryptoad added reviewers for D133895: [scudo] Add PageReleaseContext to convey page usage status.: vitalybuka, mcgrathr.
Sep 16 2022, 11:48 AM · Restricted Project, Restricted Project

Sep 1 2022

cryptoad added inline comments to D133145: Use u16 to store Count/MaxCount.
Sep 1 2022, 3:01 PM · Restricted Project, Restricted Project
cryptoad added a comment to D133145: Use u16 to store Count/MaxCount.

While this is true, making the Counts smaller can have structure alignement consequences.
You probably want to make sure that TransferBatch, FreeBatch, PreClass etc all look fine (size multiple of sizeof(uptr) etc). If not the case, you would have to pad.
Other things to keep in consideration: u32 vs u16 in getMaxCachedHint, TransferBatch::get and others (static_cast<u32> might be a giveaway of some integer size inconsitency).
If all works out, that might mean that the SizeClassConfig will have to be adapted to best fit the new sizes.

Sep 1 2022, 12:57 PM · Restricted Project, Restricted Project

Jul 8 2022

cryptoad added inline comments to D129326: [scudo] Pass MapPlatformData to all map/unmap calls.
Jul 8 2022, 10:14 AM · Restricted Project, Restricted Project

Jul 7 2022

cryptoad added inline comments to D129326: [scudo] Pass MapPlatformData to all map/unmap calls.
Jul 7 2022, 2:02 PM · Restricted Project, Restricted Project

Jun 1 2022

cryptoad added reviewers for D126752: Add Soft/Hard RSS Limits to Scudo Standalone: vitalybuka, eugenis.
Jun 1 2022, 9:32 AM · Restricted Project, Restricted Project

Jan 14 2022

cryptoad committed rG636a1cfdcdb8: [scudo] Make Scudo compile for C++20 (authored by cryptoad).
[scudo] Make Scudo compile for C++20
Jan 14 2022, 2:54 PM
cryptoad closed D117359: [scudo] Make Scudo compile for C++20.
Jan 14 2022, 2:53 PM · Restricted Project
cryptoad requested review of D117359: [scudo] Make Scudo compile for C++20.
Jan 14 2022, 1:52 PM · Restricted Project

Nov 16 2021

cryptoad accepted D113951: [scudo] Handle mallinfo2.
Nov 16 2021, 1:34 PM · Restricted Project
cryptoad added inline comments to D113951: [scudo] Handle mallinfo2.
Nov 16 2021, 8:31 AM · Restricted Project

Oct 11 2021

cryptoad committed rG56a9effc427b: [scudo] Skip AllocAfterFork test on machines with low max_map_count (authored by cryptoad).
[scudo] Skip AllocAfterFork test on machines with low max_map_count
Oct 11 2021, 10:34 AM
cryptoad closed D111465: [scudo] Skip AllocAfterFork test on machines with low max_map_count.
Oct 11 2021, 10:33 AM · Restricted Project

Oct 8 2021

cryptoad updated the diff for D111465: [scudo] Skip AllocAfterFork test on machines with low max_map_count.

... and remove local debugging line.

Oct 8 2021, 2:16 PM · Restricted Project
cryptoad requested review of D111465: [scudo] Skip AllocAfterFork test on machines with low max_map_count.
Oct 8 2021, 2:16 PM · Restricted Project

Oct 7 2021

cryptoad committed rG6727832c324c: [scudo] Reduce the scope of AllocAfterFork (authored by cryptoad).
[scudo] Reduce the scope of AllocAfterFork
Oct 7 2021, 2:02 PM
cryptoad closed D111342: [scudo] Reduce the scope of AllocAfterFork.
Oct 7 2021, 2:02 PM · Restricted Project
cryptoad requested review of D111342: [scudo] Reduce the scope of AllocAfterFork.
Oct 7 2021, 12:30 PM · Restricted Project

Sep 27 2021

cryptoad committed rG04f5913395de: [gwp-asan] Initialize AllocatorVersionMagic at runtime (authored by cryptoad).
[gwp-asan] Initialize AllocatorVersionMagic at runtime
Sep 27 2021, 1:51 PM
cryptoad closed D110575: [gwp-asan] Initialize AllocatorVersionMagic at runtime.
Sep 27 2021, 1:50 PM · Restricted Project
cryptoad updated the diff for D110575: [gwp-asan] Initialize AllocatorVersionMagic at runtime.

Addressing Mitch's request.

Sep 27 2021, 1:43 PM · Restricted Project
cryptoad requested review of D110575: [gwp-asan] Initialize AllocatorVersionMagic at runtime.
Sep 27 2021, 12:32 PM · Restricted Project

Sep 4 2021

cryptoad accepted D109196: scudo: Only add no-omit-frame-pointer flags when the compiler supports them.

Thank you!

Sep 4 2021, 9:41 AM · Restricted Project

Sep 2 2021

cryptoad added inline comments to D109196: scudo: Only add no-omit-frame-pointer flags when the compiler supports them.
Sep 2 2021, 3:17 PM · Restricted Project

Aug 17 2021

cryptoad committed rG5009be2f09ae: [scudo] Fix format string specifiers (authored by cryptoad).
[scudo] Fix format string specifiers
Aug 17 2021, 8:38 AM
cryptoad closed D108168: [scudo] Fix format string specifiers.
Aug 17 2021, 8:38 AM · Restricted Project

Aug 16 2021

cryptoad requested review of D108168: [scudo] Fix format string specifiers.
Aug 16 2021, 3:24 PM · Restricted Project
cryptoad committed rGb2aaafb8377a: [scudo] Use stdint types for internal types (redo) (authored by cryptoad).
[scudo] Use stdint types for internal types (redo)
Aug 16 2021, 2:47 PM
cryptoad closed D108152: [scudo] Use stdint types for internal types (redo).
Aug 16 2021, 2:46 PM · Restricted Project
cryptoad added a comment to rG45138f788c9b: [sanitizer] Define 32bit uptr as uint.

Are you looking at resolving this build failure? Or maybe @cryptoad is?

Aug 16 2021, 1:13 PM
cryptoad requested review of D108152: [scudo] Use stdint types for internal types (redo).
Aug 16 2021, 11:59 AM · Restricted Project
cryptoad added a comment to rGb7425e956be6: [NFC] Fix typos.

I apologize, I messed up the revert of my other CL and this got reverted by mistake!

Aug 16 2021, 11:16 AM
cryptoad added a reverting change for rG5fc841d8a278: [scudo] Use stdint types for internal scudo types: rG427c9aa7c440: Revert "[scudo] Use stdint types for internal scudo types".
Aug 16 2021, 11:14 AM
cryptoad committed rG427c9aa7c440: Revert "[scudo] Use stdint types for internal scudo types" (authored by cryptoad).
Revert "[scudo] Use stdint types for internal scudo types"
Aug 16 2021, 11:14 AM
cryptoad added a reverting change for rGb7425e956be6: [NFC] Fix typos: rG80ed75e7fb45: Revert "[NFC] Fix typos".
Aug 16 2021, 11:14 AM
cryptoad committed rG80ed75e7fb45: Revert "[NFC] Fix typos" (authored by cryptoad).
Revert "[NFC] Fix typos"
Aug 16 2021, 11:14 AM
cryptoad added a reverting change for D108089: [scudo] Use stdint types for internal scudo types: rG427c9aa7c440: Revert "[scudo] Use stdint types for internal scudo types".
Aug 16 2021, 11:14 AM · Restricted Project
cryptoad committed rG5fc841d8a278: [scudo] Use stdint types for internal scudo types (authored by cryptoad).
[scudo] Use stdint types for internal scudo types
Aug 16 2021, 10:53 AM
cryptoad closed D108089: [scudo] Use stdint types for internal scudo types.
Aug 16 2021, 10:53 AM · Restricted Project
cryptoad added a comment to D108089: [scudo] Use stdint types for internal scudo types.

Side note - it'd be nice at some point if we can LSC all the use-of-custom-types away, any reason to keep them?

Aug 16 2021, 9:04 AM · Restricted Project

Aug 15 2021

cryptoad requested review of D108089: [scudo] Use stdint types for internal scudo types.
Aug 15 2021, 9:10 AM · Restricted Project
cryptoad abandoned D108044: [scudo] Correct format string specifiers.

Redoing this the way Vitaly suggested.

Aug 15 2021, 7:57 AM · Restricted Project

Aug 13 2021

cryptoad updated the diff for D108044: [scudo] Correct format string specifiers.

So this turned out to be a little more complicated for 32-b.
The 'z' format specifier expects a size_t which is defined
as a unsigned int on 32-b Linux platforms, while our
scudo::uptr are defined a unsigned long. So zu wasn't
an appropriate specifier on 32-b platforms for a uptr.

Aug 13 2021, 10:26 AM · Restricted Project
cryptoad planned changes to D108044: [scudo] Correct format string specifiers.
Aug 13 2021, 9:04 AM · Restricted Project
cryptoad requested review of D108044: [scudo] Correct format string specifiers.
Aug 13 2021, 8:51 AM · Restricted Project

Aug 11 2021

cryptoad accepted D107909: [scudo] Add GWP-ASan state/metadata pointer proxies..
Aug 11 2021, 9:20 AM · Restricted Project

Aug 3 2021

cryptoad committed rG23a94af44939: [scudo] Make Vector() constexpr (authored by cryptoad).
[scudo] Make Vector() constexpr
Aug 3 2021, 8:26 AM
cryptoad closed D107308: [scudo] Make Vector() constexpr.
Aug 3 2021, 8:25 AM · Restricted Project

Aug 2 2021

cryptoad requested review of D107308: [scudo] Make Vector() constexpr.
Aug 2 2021, 1:40 PM · Restricted Project

Jul 27 2021

cryptoad added inline comments to D106919: [libc] add integration tests for scudo in libc.
Jul 27 2021, 2:53 PM · Restricted Project, Restricted Project

Jul 22 2021

cryptoad added a comment to D106502: [libc] add option to use SCUDO as the allocator.

@cryptoad - This adds a build level dependency across projects. Do you see any problems which this arrangement? We will also start testing this arrangement via integration tests on the LLVM libc buildbot workers.

Jul 22 2021, 12:30 AM · Restricted Project

Jul 2 2021

cryptoad accepted D105371: Name all DEATH tests using 'DeathTest' suffix..
Jul 2 2021, 1:42 PM · Restricted Project

Jul 1 2021

cryptoad accepted D105266: [scudo] Remove false DCHECK.
Jul 1 2021, 10:41 AM · Restricted Project

Jun 16 2021

cryptoad committed rG8b062b616062: [scudo] Ensure proper allocator alignment in TSD test (authored by cryptoad).
[scudo] Ensure proper allocator alignment in TSD test
Jun 16 2021, 2:22 PM
cryptoad closed D104402: [scudo] Ensure proper allocator alignment in TSD test.
Jun 16 2021, 2:22 PM · Restricted Project
cryptoad updated the diff for D104402: [scudo] Ensure proper allocator alignment in TSD test.

Using using instead of typedef on the newly added ones.

Jun 16 2021, 2:18 PM · Restricted Project
cryptoad updated the diff for D104402: [scudo] Ensure proper allocator alignment in TSD test.

Adding more isAligned DCHECK as Vitaly suggested.

Jun 16 2021, 2:07 PM · Restricted Project
cryptoad added inline comments to D104402: [scudo] Ensure proper allocator alignment in TSD test.
Jun 16 2021, 1:50 PM · Restricted Project
cryptoad updated the diff for D104402: [scudo] Ensure proper allocator alignment in TSD test.

Add stdlib.h to the test for posix_memalign. My builds don't
complain but I assume something will eventually.

Jun 16 2021, 10:56 AM · Restricted Project
cryptoad added a comment to D103119: [scudo] Get rid of initLinkerInitialized.

Hi,

this is due to a misaligned data access, in Thumb the code generated for unmapTestOnly
contains a Vector Store instruction vst1.64 {d16-d17}, [r0, :128] which needs a 16-bytes
alignement, but the adress of TSDs (which is in r0) is not.

Jun 16 2021, 10:55 AM · Restricted Project
cryptoad requested review of D104402: [scudo] Ensure proper allocator alignment in TSD test.
Jun 16 2021, 10:52 AM · Restricted Project

Jun 14 2021

cryptoad added a comment to D103119: [scudo] Get rid of initLinkerInitialized.

Hi,

This change introduced a regression on ARMv7 Thumb bots which wasn't noticed due to other issues.

logs can be seen here: https://lab.llvm.org/buildbot/#/builders/26/builds/2251

The 3 tests fail with a bus error raised from tsd_shared.h line 49

Jun 14 2021, 11:24 AM · Restricted Project

Jun 8 2021

cryptoad committed rG2551053e8d8d: [scudo] Add Scudo support for Trusty OS (authored by danieljm).
[scudo] Add Scudo support for Trusty OS
Jun 8 2021, 2:03 PM
cryptoad closed D103578: [scudo] Add Scudo support for Trusty OS.
Jun 8 2021, 2:02 PM · Restricted Project

Jun 7 2021

cryptoad added inline comments to D103578: [scudo] Add Scudo support for Trusty OS.
Jun 7 2021, 1:13 PM · Restricted Project