- User Since
- May 5 2016, 2:57 PM (167 w, 3 d)
Mon, Jul 15
BM_youtube/min_time:15.000/repeats:4/manual_time_mean 410274 us 615999 us 4 BM_youtube/min_time:15.000/repeats:4/manual_time_median 410246 us 616125 us 4 BM_youtube/min_time:15.000/repeats:4/manual_time_stddev 302 us 587 us 4
Fri, Jul 12
Thu, Jul 11
Wed, Jul 10
It's OK with me. Part of the reason for splitting out the symbolizer was some memory overhead as well, which we probably want to look into.
Is COMPILER_RT_HAS_GWP_ASAN going to be true by default for Android? If so we probably should loop in the toolchain team so that there is no surprise on their next toolchain update.
Tue, Jul 9
Addressing review comments:
- commenting the use of the #pragma nounroll
- using the platform specific types in mutex.h
Move the mutex state enum into linux.cc since it's only used there.
Mon, Jul 8
- Adding constexpr for the number of yields & trys in the mutex class;
- Adding a test to ensure that scudo::getPageSizeCached is consitent with getpagesize;
Wed, Jul 3
Tue, Jul 2
Regarding Teresa's issue, it seems to boil down to the version of clang, and not inlining the __atomic_load_8 & co.
Looking at godbolt, it doesn't seem to happen until clang 6, while gcc did it since a while.
After attempting to conditionally add -latomic, and failing, I am resorting to adding -latomic unconditionally to the tests link flags, unless someone has a better idea.
Tentative fix for this is in https://reviews.llvm.org/D64086, if you could please let me know if that works for you.
Thu, Jun 27
Wed, Jun 26
Thank you Douglas!
Tue, Jun 25
Remove unchanged files from CL.
Adding a testcase for a Class to the New tests.
Mon, Jun 24
Changing some errno behaviors to be more consistent.
Renaming wrappers.inc to wrappers_c.inc and updated associated strings.
Jun 21 2019
Fixing a couple of errors that came up in testing.
Jun 20 2019
Jun 18 2019
Jun 17 2019
Removing a reinterpret_cast<void *>.
Jun 14 2019
Addressing review comments:
- renaming allocator.h to allocator_config.h
- adding FuchsiaConfig to the battery of tests (64-bit only)
Jun 13 2019
Tune some tests & Quarantine parameters.
Enabled the Quarantine for some tests, which wasn't used before.
Jun 12 2019
Jun 11 2019
Update the deleters to actually delete the pointer itself as well.
Jun 10 2019
Jun 7 2019
Always call initOnce, and rename it initOnceMaybe to reflect that
initialization might not necessarily occur if it already happened.
clang-format'ing the code.
Use an atomic_u8 for Initialized instead of a bool.
As discussed through comments, re-introduce a StaticSpinMutex to the
"once" initialization of the TSD registry, and remove its no-op
initLinkerInitialized in the various places it was used.
Also adds a test to exercise the path of "direct" initialization
via calling initLinkerInitialized directly on the registry.
Jun 6 2019
Ping pretty please! I think all the comments were addressed one way or another. The new structure doesn't "cycle" anymore.
Jun 5 2019
I think it's good from the integration perspective.
The only potential concern I have is the specific use of the TLS variables in GWP-ASan which might not work everywhere here (eg: if a platform is using emutls as TLS as it uses malloc() internally).
Have you tested that locally with an Android emulator?
Jun 3 2019
Disable a test on 32-bit for now: we are running out of address space.
This will be fixed in a subsequent CL, but affects the tests of this one.
Change the Primary test again to be more forgiving to OOM.
Add a comment for MinimalInit.
This, hopefully, detangles a bit the initialization process for
the registry. In order to do that, we get rid of the mutex in favor
of our own call_once type construct (losely inspired by
llvm::call_once). We move the initialization code into
May 29 2019
May 24 2019
Switching from a spin mutex to a blocking mutex for initOnce.
Regarding the Scudo side of the patch: the code has to be able to compile with gcc as well, and not necessarily the latest version.
This won't compile on systems without a signature_HYGON_*.
Addressing several of Matt's review points:
- adding comments to obscure code snippets
- calling initLinkerInitialized when needed
- changing unique_ptr's get()-> to ->
- simplifying some code constructs
Matt, thank you for all the reviews you are doing. Very insightful points.
May 22 2019
Correct a test and some formatting.
May 20 2019
May 17 2019
Correcting a typo (meaningul -> meaningful)
Adding a forgotten CHECK as well.
Correcting some code constructs as suggested by Matt:
- using unique_ptr in tests;
- accounting for a potential null TransferBatch in refill;
- other corrections.